Re: [squid-users] Error making squid-3.1.0.7-20090412 on Mac OS X 10.4
vollkom...@gmx.net wrote: Sorry, third try... Original-Nachricht Hmm, I have a small suspicion... what happens if you change the top of src/acl/Acl.cc from: #include "config.h" to: #include "squid.h" or to: #include "include/config.h" Amos -- Please be using Current Stable Squid 2.7.STABLE6 or 3.0.STABLE14 Current Beta Squid 3.1.0.7 It does appear as if config.h is being skipped for some reason. Possibly a double-include, lets try this attached patch (-p0) on a clean copy of todays snapshot. Amos -- Please be using Current Stable Squid 2.7.STABLE6 or 3.0.STABLE14 Current Beta Squid 3.1.0.7 === modified file 'compat/compat_shared.h' --- compat/compat_shared.h 2009-04-07 14:14:19 + +++ compat/compat_shared.h 2009-04-20 12:52:26 + @@ -210,4 +210,20 @@ #endif +/** + * gcc requires some special function formatting hints. + * + * gcc doesn't recognize the Windows native 64 bit formatting tags causing + * the compile fail, so we must disable the check on native Windows. + */ +#if __GNUC__ && !defined(_SQUID_MSWIN_) +#define PRINTF_FORMAT_ARG1 __attribute__ ((format (printf, 1, 2))) +#define PRINTF_FORMAT_ARG2 __attribute__ ((format (printf, 2, 3))) +#define PRINTF_FORMAT_ARG3 __attribute__ ((format (printf, 3, 4))) +#else +#define PRINTF_FORMAT_ARG1 +#define PRINTF_FORMAT_ARG2 +#define PRINTF_FORMAT_ARG3 +#endif + #endif /* _SQUID_COMPAT_SHARED_H */ === modified file 'include/config.h' --- include/config.h 2009-03-03 02:52:23 + +++ include/config.h 2009-04-20 12:50:52 + @@ -237,20 +237,6 @@ #define squid_srandom srand #endif -/* gcc doesn't recognize the Windows native 64 bit formatting tags causing - * the compile fail, so we must disable the check on native Windows. - */ - -#if __GNUC__ && !defined(_SQUID_MSWIN_) -#define PRINTF_FORMAT_ARG1 __attribute__ ((format (printf, 1, 2))) -#define PRINTF_FORMAT_ARG2 __attribute__ ((format (printf, 2, 3))) -#define PRINTF_FORMAT_ARG3 __attribute__ ((format (printf, 3, 4))) -#else -#define PRINTF_FORMAT_ARG1 -#define PRINTF_FORMAT_ARG2 -#define PRINTF_FORMAT_ARG3 -#endif - /* * Determine if this is a leak check build or standard */ === modified file 'include/fatal.h' --- include/fatal.h 2009-02-15 13:01:35 + +++ include/fatal.h 2009-04-20 12:53:08 + @@ -1,8 +1,10 @@ +#ifndef SQUID_CONFIG_H +#include "config.h" +#endif + #ifndef SQUID_FATAL_H #define SQUID_FATAL_H -#include "config.h" - SQUIDCEXTERN void fatal(const char *message); SQUIDCEXTERN void fatalf(const char *fmt,...) PRINTF_FORMAT_ARG1; SQUIDCEXTERN void fatal_dump(const char *message);
Re: More patches for squid2-HEAD
Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 On 20/04/2009, at 4:46 PM, Amos Jeffries wrote: Mark Nottingham wrote: Unless I hear otherwise, I'm going to apply the patches attached to the following bugs: http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 response in bugzilla. Likewise. http://www.squid-cache.org/bugs/show_bug.cgi?id=2632 IMO, this should be number of times squid tries _each_ available forwarding method before giving up on it. With a default of something lower, 1 or 2 may be reasonable in most of todays internet. +1 on the configurable idea though. Sorry, could you explain what you mean by each method? Is it direct vs. peer? Definitely relevant to squid-3, if you commit this for 2 before it gets to 3, please just comment "commited to squid-2" and bump target milestone to 3.HEAD Ack. http://www.squid-cache.org/bugs/show_bug.cgi?id=2515 Looks good to me. Mind the formatting though. Yeah. Still can't get the proper version of indent running on OSX, so I have to shove it to another box to indent before submission... Is it relevant to squid-3 parser? Don't think so; StringToInt64 doesn't look at errno. -- Mark Nottingham m...@yahoo-inc.com
Re: More patches for squid2-HEAD
Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 On 20/04/2009, at 4:46 PM, Amos Jeffries wrote: Mark Nottingham wrote: Unless I hear otherwise, I'm going to apply the patches attached to the following bugs: http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 response in bugzilla. Likewise. http://www.squid-cache.org/bugs/show_bug.cgi?id=2632 IMO, this should be number of times squid tries _each_ available forwarding method before giving up on it. With a default of something lower, 1 or 2 may be reasonable in most of todays internet. +1 on the configurable idea though. Sorry, could you explain what you mean by each method? Is it direct vs. peer? Definitely relevant to squid-3, if you commit this for 2 before it gets to 3, please just comment "commited to squid-2" and bump target milestone to 3.HEAD Ack. http://www.squid-cache.org/bugs/show_bug.cgi?id=2515 Looks good to me. Mind the formatting though. Yeah. Still can't get the proper version of indent running on OSX, so I have to shove it to another box to indent before submission... Is it relevant to squid-3 parser? Don't think so; StringToInt64 doesn't look at errno. -- Mark Nottingham m...@yahoo-inc.com
Re: More patches for squid2-HEAD
> > Responses inline, and a couple more: > > http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 > http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 > > > On 20/04/2009, at 4:46 PM, Amos Jeffries wrote: > >> Mark Nottingham wrote: >>> Unless I hear otherwise, I'm going to apply the patches attached to >>> the following bugs: >>> http://www.squid-cache.org/bugs/show_bug.cgi?id=2631 >> >> response in bugzilla. > > Likewise. > > >>> http://www.squid-cache.org/bugs/show_bug.cgi?id=2632 >> >> IMO, this should be number of times squid tries _each_ available >> forwarding method before giving up on it. With a default of >> something lower, 1 or 2 may be reasonable in most of todays internet. >> >> +1 on the configurable idea though. > > Sorry, could you explain what you mean by each method? Is it direct > vs. peer? Sorry I'm wandering in the vague area between access methods and routing directions here. What I mean is an aggregate of all that. At present we have: DIRECT via IP #1 DIRECT via IP #2 ... repeat for all possible IPs. PEER #1 PERR #2 REEP # ... 64 Doing each of those within a 1 minute timeout and 10x attempts per route causes unreasonably long delays and false-failures. A few hacks reduce this somewhat by dropping the timeout, doing one connect when >1 IPs found, and only trying one peer per request, using netdb to improve the peers chances of working, but still hitting the problem. > > >> Definitely relevant to squid-3, if you commit this for 2 before it >> gets to 3, please just comment "commited to squid-2" and bump target >> milestone to 3.HEAD > > Ack. > > >>> http://www.squid-cache.org/bugs/show_bug.cgi?id=2515 >> >> Looks good to me. Mind the formatting though. > > Yeah. Still can't get the proper version of indent running on OSX, so > I have to shove it to another box to indent before submission... Manual works easier and sometimes faster for small patches like this. :) > >> Is it relevant to squid-3 parser? > > Don't think so; StringToInt64 doesn't look at errno. > Great. Was wondering why I could not find it. Amos
Re: More patches for squid2-HEAD
Yeah, this came up in another bug as well, don't remember where, but really this whole section needs to be reworked pretty extensively; this is just a way to fine-tune the current behaviour until we figure out what the right thing to do should be (and I suspect that's not a trivial task). BTW, it's not exactly as you describe; it's not 10x attempts per route, it's 10 routes, AFAICT. Cheers, On 21/04/2009, at 1:08 PM, Amos Jeffries wrote: Sorry I'm wandering in the vague area between access methods and routing directions here. What I mean is an aggregate of all that. At present we have: DIRECT via IP #1 DIRECT via IP #2 ... repeat for all possible IPs. PEER #1 PERR #2 REEP # ... 64 Doing each of those within a 1 minute timeout and 10x attempts per route causes unreasonably long delays and false-failures. A few hacks reduce this somewhat by dropping the timeout, doing one connect when >1 IPs found, and only trying one peer per request, using netdb to improve the peers chances of working, but still hitting the problem. -- Mark Nottingham m...@yahoo-inc.com
Re: More patches for squid2-HEAD
>> >> Responses inline, and a couple more: >> >> http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 I can't tell from the patch which one is being remove. +1 if its the one directly in mainReconfigure() peerMonitorInit() should probably check for duplicate calls somehow too. But this is good for a quick fix. >> http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 -1 right now. see bug report. Amos
Re: More patches for squid2-HEAD
On 21/04/2009, at 1:24 PM, Amos Jeffries wrote: Responses inline, and a couple more: http://www.squid-cache.org/bugs/show_bug.cgi?id=2642 I can't tell from the patch which one is being remove. +1 if its the one directly in mainReconfigure() Yep. peerMonitorInit() should probably check for duplicate calls somehow too. But this is good for a quick fix. http://www.squid-cache.org/bugs/show_bug.cgi?id=2643 -1 right now. see bug report. Responded there. Cheers, -- Mark Nottingham m...@yahoo-inc.com
Re: [squid-users] Error making squid-3.1.0.7-20090412 on Mac OS X 10.4
> Attached please find the new "make" outut, after: > > # patch -p0 < macosx_fatal_fails_mk2.patch > patching file compat/compat_shared.h > patching file include/config.h > patching file include/fatal.h > > Here're the ./configure options I used: > > ./configure \ > --build=i686-apple-darwin \ > --with-large-files \ > --disable-ident-lookups --disable-dependency-tracking \ > --enable-ipv6 \ > --enable-filters --enable-snmp --enable-ssl \ > --enable-icap-client \ > --enable-removal-policies=heap,lru \ > --enable-external-acl-helpers=ip_user,ldap_group,unix_group,wbinfo_group \ > --enable-auth=basic,digest,ntlm,negotiate \ > --enable-basic-auth-helpers=PAM,NCSA,LDAP,MSNT,NCSA,SMB,YP,getpwnam,multi-domain-NTLM > \ > --enable-negotiate-auth-helpers=squid_kerb_auth \ > --enable-digest-auth-helpers=password \ > --enable-ntlm-auth-helpers=fakeauth \ > --enable-delay-pools \ > --enable-multicast-miss \ > --with-filedescriptors=16384 --with-dl \ > --enable-dl-malloc \ > --enable-gnuregex \ > --enable-storeio=coss \ > --with-ipv6-split-stack \ > Oooh. I don't think its relevant, but some cleanup is needed there... Drop: --with-ipv6-split-stack; it was partially added for Windows XP but never completed due to windows VCS issues. Squid does dual-stack nicely. --enable-ipv6; It's auto-detected. Just ensure you have the proper v6-capable kernel and headers present. --enable-dl-malloc; obsolete --enable-storeio=coss; COSS has too many bugs in Squid-3 to be considered usable. No change in the trace. This is really, really weird. Am I able to get shell access to the box you build these on? I'd like to test the build a bit and first-hand is best for that. Amos
Re: More patches for squid2-HEAD
> Yeah, this came up in another bug as well, don't remember where, but > really this whole section needs to be reworked pretty extensively; > this is just a way to fine-tune the current behaviour until we figure > out what the right thing to do should be (and I suspect that's not a > trivial task). > > BTW, it's not exactly as you describe; it's not 10x attempts per > route, it's 10 routes, AFAICT. Aokay, squid-2 is a little different again then to what I'm seeing in -3. There its 10x one route, or 1x any IP route, or something involving rotating IPs and ResetFD I didn't grasp well enough to describe intermixed with connection-level retries I think connected to the peer routes somehow through a maze of functions. Amos > > Cheers, > > > On 21/04/2009, at 1:08 PM, Amos Jeffries wrote: > >> Sorry I'm wandering in the vague area between access methods and >> routing >> directions here. What I mean is an aggregate of all that. >> >> At present we have: >> DIRECT via IP #1 >> DIRECT via IP #2 >> ... repeat for all possible IPs. >> PEER #1 >> PERR #2 >> REEP # ... 64 >> >> Doing each of those within a 1 minute timeout and 10x attempts per >> route >> causes unreasonably long delays and false-failures. A few hacks reduce >> this somewhat by dropping the timeout, doing one connect when >1 IPs >> found, and only trying one peer per request, using netdb to improve >> the >> peers chances of working, but still hitting the problem. > > -- > Mark Nottingham m...@yahoo-inc.com > > >
Introducing myself
Hi everyone, I'd like to introduce myself to the dev team and start helping out. My name is Alistair Reay and I'm a system engineer at a large New Zealand broadcaster that uses Squid and other open-source software extensively. Using squid we've built the nations largest and cheapest commercial CDN for our VOD offering so I've got a vested interest in helping Squid kick more ass. Although I'm not a professional developer, I have a lot of interest in contributing code to this project and I've created a production-ready load balancer project in SourceForge called Octopus http://sourceforge.net/projects/octopuslb/ that works really well behind Squid. Anyway, the first thing I'd like to do is investigate how refresh_stale_hit works and try to improve it. I searched to squid-users mail list and found this thread of conversation which is what I'd like to implement in Squid2.7. If you'll have me, I'll subscribe to this mailing list and make a new topic about this feature request then start work. http://www.squid-cache.org/mail-archive/squid-users/200609/0162.html User's query/request (also what I'd like to be able to do) http://www.squid-cache.org/mail-archive/squid-users/200609/0167.html Henrik's response Cheers Al == For more information on the Television New Zealand Group, visit us online at tvnz.co.nz == CAUTION: This e-mail and any attachment(s) contain information that is intended to be read only by the named recipient(s). This information is not to be used or stored by any other person and/or organisation.
Re: Introducing myself
Hi! Take a look at stale-while-revalidate (cache_peer option in 2.7); it may do what you need. Cheers, On 21/04/2009, at 2:10 PM, Alistair Reay wrote: Hi everyone, I'd like to introduce myself to the dev team and start helping out. My name is Alistair Reay and I'm a system engineer at a large New Zealand broadcaster that uses Squid and other open-source software extensively. Using squid we've built the nations largest and cheapest commercial CDN for our VOD offering so I've got a vested interest in helping Squid kick more ass. Although I'm not a professional developer, I have a lot of interest in contributing code to this project and I've created a production-ready load balancer project in SourceForge called Octopus http://sourceforge.net/projects/octopuslb/ that works really well behind Squid. Anyway, the first thing I'd like to do is investigate how refresh_stale_hit works and try to improve it. I searched to squid- users mail list and found this thread of conversation which is what I'd like to implement in Squid2.7. If you'll have me, I'll subscribe to this mailing list and make a new topic about this feature request then start work. http://www.squid-cache.org/mail-archive/squid-users/200609/0162.html User's query/request (also what I'd like to be able to do) http://www.squid-cache.org/mail-archive/squid-users/200609/0167.html Henrik's response Cheers Al == For more information on the Television New Zealand Group, visit us online at tvnz.co.nz == CAUTION: This e-mail and any attachment(s) contain information that is intended to be read only by the named recipient(s). This information is not to be used or stored by any other person and/or organisation. -- Mark Nottingham m...@yahoo-inc.com
