Build failed in Jenkins: 3.HEAD-ppc-MacOS-Leopard #43

2012-10-06 Thread noc
See 

--
[...truncated 3801 lines...]
-e 
"s%[@]DEFAULT_MIME_TABLE[@]%
 \
-e 
"s%[@]DEFAULT_DNSSERVER[@]%
 dnsserver | sed 's,x,x,;s/$//'`%g" \
-e 
"s%[@]DEFAULT_SSL_CRTD[@]%
 ssl_crtd  | sed 's,x,x,;s/$//'`%g" \
-e 
"s%[@]DEFAULT_UNLINKD[@]%
 unlinkd | sed 's,x,x,;s/$//'`%g" \
-e 
"s%[@]DEFAULT_PINGER[@]%
 pinger | sed 's,x,x,;s/$//'`%g" \
-e 
"s%[@]DEFAULT_DISKD[@]%
 diskd | sed 's,x,x,;s/$//'`%g" \
-e 
"s%[@]DEFAULT_LOGFILED[@]%
 log_file_daemon | sed 's,x,x,;s/$//'`%g;" \
-e 
"s%[@]DEFAULT_CACHE_LOG[@]%
 \
-e 
"s%[@]DEFAULT_ACCESS_LOG[@]%
 \
-e 
"s%[@]DEFAULT_STORE_LOG[@]%
 \
-e 
"s%[@]DEFAULT_PID_FILE[@]%
 \
-e 
"s%[@]DEFAULT_NETDB_FILE[@]%
 \
-e 
"s%[@]DEFAULT_SWAP_DIR[@]%
 \
-e 
"s%[@]DEFAULT_SSL_DB_DIR[@]%
 \
-e 
"s%[@]DEFAULT_ICON_DIR[@]%
 \
-e 
"s%[@]DEFAULT_CONFIG_DIR[@]%
 \
-e 
"s%[@]DEFAULT_ERROR_DIR[@]%
 \
-e 
"s%[@]DEFAULT_PREFIX[@]%
 \
-e "s%[@]DEFAULT_HOSTS[@]%/etc/hosts%g" \
-e "s%[@]SQUID[@]%SQUID\ 3.HEAD-BZR%g" \
< ../../src/cf.data.pre >cf.data
g++ -o cf_gen ../../src/cf_gen.cc -I../../src -I../include/ -I../src
./cf_gen cf.data ../../src/cf.data.depend
awk -f ../../src/mk-string-arrays.awk < ../../src/err_type.h > err_type.cc || 
(/bin/rm -f -f err_type.cc && exit 1)
awk -f ../../src/mk-string-arrays.awk < ../../src/err_detail_type.h | sed 
's/ERR_DETAIL_//' > err_detail_type.cc || (/bin/rm -f -f err_detail_type.cc && 
exit 1)
awk -f ../../src/mk-globals-c.awk < ../../src/globals.h > globals.cc || 
(/bin/rm -f -f globals.cc && exit 1)
awk -f ../../src/mk-string-arrays.awk < ../../src/hier_code.h > hier_code.cc || 
(/bin/rm -f -f hier_code.cc && exit 1)
awk -f ../../src/mk-string-arrays.awk < ../../src/icp_opcode.h > icp_opcode.cc 
|| (/bin/rm -f -f icp_opcode.cc && exit 1)
awk -f ../../src/mk-string-arrays.awk < ../../src/lookup_t.h > lookup_t.cc || 
(/bin/rm -f -f lookup_t.cc && exit 1)
/bin/sh ../../src/repl_modules.sh lru > repl_modules.cc
make  all-recursive
Making all in base
/bin/sh ../../libtool --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
-I/opt/local/include  -I../../../libltdl   -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT AsyncCall.lo 
-MD -MP -MF .deps/AsyncCall.Tpo -c -o AsyncCall.lo 
../../../src/base/AsyncCall.cc
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -I/opt/local/include 
-I../../../libltdl -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 

Build failed in Jenkins: 3.HEAD-amd64-opensuse #221

2012-10-06 Thread noc
See 

Changes:

[Amos Jeffries] Typo in rev12352

[Amos Jeffries] Fix error: 'opt_parse_cfg_only' was not declared in this scope

[Amos Jeffries] Release Notes: 3.3 updates

[Amos Jeffries] Polish: use DBG_PARSE_NOTE to warn about deprecated logformat 
tokens

--
[...truncated 7164 lines...]
Testing ../../src/comm.h ...Ok.
Testing ../../src/mime.h ...Ok.
Testing ../../src/ftp.h ...Ok.
Testing ../../src/LoadableModules.h ...Ok.
Testing ../../src/stmem.h ...Ok.
Testing ../../src/CompositePoolNode.h ...Ok.
Testing ../../src/Server.h ...Ok.
Testing ../../src/wccp.h ...Ok.
Testing ../../src/DelayTagged.h ...Ok.
Testing ../../src/swap_log_op.h ...Ok.
Testing ../../src/HierarchyLogEntry.h ...Ok.
Testing ../../src/StoreClient.h ...Ok.
Testing ../../src/HttpHeaderMask.h ...Ok.
Testing ../../src/unlinkd.h ...Ok.
Testing ../../src/client_side_reply.h ...Ok.
Testing ../../src/StoreMetaSTDLFS.h ...Ok.
Testing ../../src/defines.h ...Ok.
Testing ../../src/multicast.h ...Ok.
Testing ../../src/store_rebuild.h ...Ok.
Testing ../../src/HttpHeaderTools.h ...Ok.
Testing ../../src/RemovalPolicy.h ...Ok.
Testing ../../src/mem_node.h ...Ok.
Testing ../../src/helper.h ...Ok.
Testing ../../src/DelaySpec.h ...Ok.
Testing ../../src/CachePeerDomainList.h ...Ok.
Testing ../../src/AsyncEngine.h ...Ok.
Testing ../../src/StoreSwapLogData.h ...Ok.
Testing ../../src/HttpMsg.h ...Ok.
Testing ../../src/mime_header.h ...Ok.
Testing ../../src/StoreFileSystem.h ...Ok.
Testing ../../src/ICP.h ...Ok.
Testing ../../src/DnsLookupDetails.h ...Ok.
Testing ../../src/peer_userhash.h ...Ok.
Testing ../../src/cache_cf.h ...Ok.
Testing ../../src/Debug.h ...Ok.
Testing ../../src/ExternalACLEntry.h ...Ok.
Testing ../../src/CpuAffinityMap.h ...Ok.
Testing ../../src/HttpRequestMethod.h ...Ok.
Testing ../../src/SquidString.h ...Ok.
Testing ../../src/StoreMetaVary.h ...Ok.
Testing ../../src/fde.h ...Ok.
Testing ../../src/HttpHdrSc.h ...Ok.
Testing ../../src/AuthReg.h ...Ok.
Testing ../../src/StoreMetaObjSize.h ...Ok.
Testing ../../src/NullDelayId.h ...Ok.
Testing ../../src/YesNoNone.h ...Ok.
Testing ../../src/ClientDelayConfig.h ...Ok.
Testing ../../src/NeighborTypeDomainList.h ...Ok.
Testing ../../src/err_type.h ...Ok.
Testing ../../src/HttpHeaderRange.h ...Ok.
Testing ../../src/ExternalACL.h ...Ok.
Testing ../../src/forward.h ...Ok.
Testing ../../src/HttpControlMsg.h ...Ok.
Testing ../../src/whois.h ...Ok.
Testing ../../src/disk.h ...Ok.
Testing ../../src/repl_modules.h ...Ok.
Testing ../../src/StrList.h ...Ok.
Testing ../../src/SquidConfig.h ...Ok.
Testing ../../src/DiskIO/ReadRequest.h ...Ok.
Testing ../../src/DiskIO/DiskIOModule.h ...Ok.
Testing ../../src/DiskIO/DiskIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskFile.h ...Ok.
Testing ../../src/DiskIO/WriteRequest.h ...Ok.
Testing ../../src/DiskIO/IORequestor.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedFile.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedIOStrategy.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskFile.h ...Ok.
Testing ../../src/DiskIO/AIO/async_io.h ...Ok.
Testing ../../src/DiskIO/AIO/aio_win32.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskIOModule.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskFile.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/CommIO.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreads.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoFile.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdFile.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/diomsg.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdAction.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingIOStrategy.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingFile.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingDiskIOModule.h ...Ok.
..
OK (2)
PASS: tests/testACLMaxUserIP
.
OK (1)
PASS: tests/testBoilerplate
..
OK (2)
PASS: tests/testCacheManager
.
OK (1)
PASS: tests/testDiskIO
..Actual Text:
Last event to run: last event

Operation\tNext Execution \tWeight\tCallback Valid?
test event   \t0.000 sec\t0\t N/A
test event2  \t0.000 sec\t0\t N/A


OK (6)
PASS: tests/testEvent
...
OK (3)
PASS: tests/testEventLoop
PASS: tests/test_http_range
.
OK (5)
PASS: tests/testHttpParser
.SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
S

Jenkins build is back to normal : 3.HEAD-amd64-CentOS-5.3 #2067

2012-10-06 Thread noc
See 



Build failed in Jenkins: 3.HEAD-amd64-CentOS-5.3 #2066

2012-10-06 Thread noc
See 

Changes:

[Amos Jeffries] Fix error: 'opt_parse_cfg_only' was not declared in this scope

[Amos Jeffries] Release Notes: 3.3 updates

--
[...truncated 4347 lines...]
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT Strategised.lo 
-MD -MP -MF .deps/Strategised.Tpo -c ../../../src/acl/Strategised.cc  -fPIC 
-DPIC -o .libs/Strategised.o
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT FilledChecklist.lo -MD -MP -MF ".deps/FilledChecklist.Tpo" -c -o 
FilledChecklist.lo ../../../src/acl/FilledChecklist.cc; \
then mv -f ".deps/FilledChecklist.Tpo" ".deps/FilledChecklist.Plo"; 
else rm -f ".deps/FilledChecklist.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT 
FilledChecklist.lo -MD -MP -MF .deps/FilledChecklist.Tpo -c 
../../../src/acl/FilledChecklist.cc  -fPIC -DPIC -o .libs/FilledChecklist.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT Strategised.lo 
-MD -MP -MF .deps/Strategised.Tpo -c ../../../src/acl/Strategised.cc -o 
Strategised.o >/dev/null 2>&1
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT 
FilledChecklist.lo -MD -MP -MF .deps/FilledChecklist.Tpo -c 
../../../src/acl/FilledChecklist.cc -o FilledChecklist.o >/dev/null 2>&1
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT AclAddress.lo -MD -MP -MF ".deps/AclAddress.Tpo" -c -o AclAddress.lo 
../../../src/acl/AclAddress.cc; \
then mv -f ".deps/AclAddress.Tpo" ".deps/AclAddress.Plo"; else rm -f 
".deps/AclAddress.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT AclAddress.lo 
-MD -MP -MF .deps/AclAddress.Tpo -c ../../../src/acl/AclAddress.cc  -fPIC -DPIC 
-o .libs/AclAddress.o
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT IntRange.lo -MD -MP -MF ".deps/IntRange.Tpo" -c -o IntRange.lo 
../../../src/acl/IntRange.cc; \
then mv -f ".deps/IntRange.Tpo" ".deps/IntRange.Plo"; else rm -f 
".deps/IntRange.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT IntRange.lo 
-MD -MP -MF .deps/IntRange.Tpo -c ../../../src/acl/IntRange.cc  -fPIC -DPIC -o 
.libs/IntRange.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT IntRange.lo 
-MD -MP -MF .deps/IntRange.Tpo -c ../../../src/acl/IntRange.cc -o IntRange.o 
>/dev/null 2>&1
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT AclAddress.lo 
-MD -MP -MF .deps/AclAddress.Tpo -c ../../../src/acl/AclAddress.cc -o 
AclAddress.o >/dev/null 2>&1
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT RegexData.lo -MD -MP -MF ".deps/RegexData.Tpo" -c -o RegexData.lo 
../../../src/acl/RegexData.cc; \
then mv -f ".deps/RegexData.Tpo" ".deps/RegexData.Plo"; else rm -f 
".deps/RegexData.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT RegexData.lo 
-MD -MP -MF .deps/RegexData.Tpo -c ../../../src/acl/

Re: Summary of store_url project and some questions before posting some patches.

2012-10-06 Thread Henrik Nordström
lör 2012-10-06 klockan 17:24 +0200 skrev Eliezer Croitoru:

> Code implementation is quite simple but since I was working with the old 
> bzr revision 12317 ant now its about 30 revisions up I dont have a clue 
> on what to do.

are you stuck on repository format upgrade, or on incompatible changes
in later revisions of squid?




Build failed in Jenkins: 3.2-matrix » opensuse-x64 #271

2012-10-06 Thread noc
See 


Changes:

[Amos Jeffries] 3.2.2

[Amos Jeffries] Bug 3661: Segmentation fault when using more than 1 worker

Previous change to Ipc::Mem::PageStack making variable arrays into
dynamically-allocated arrays added an allocate after use bug.

[Amos Jeffries] Fix website config display of default settings

The website page cfgman builder script was omitted when adding the
DEFAULT_DOC parameter and making DEFAULT / DEFAULT_IF_NONE support
multi-line values.

[Amos Jeffries] Polish the ACLFilledChecklist::fd related documentation

[Amos Jeffries] Small memory leak in src ACL parse

Fixes one minor memory leak when IPv6 is disabled and parsing an IPv6
address. For example the default localhost ACL ::1 value.

Caught by Valgrind:

==26647== 384 bytes in 4 blocks are definitely lost in loss record 1,132 of 
1,726
==26647==at 0x4C25A28: calloc (vg_replace_malloc.c:467)
==26647==by 0x65B441: xcalloc (xalloc.cc:75)
==26647==by 0x657B99: MemPoolMalloc::allocate() (MemPoolMalloc.cc:62)
==26647==by 0x5A95B1: acl_ip_data::FactoryParse(char const*) (Ip.h:66)
==26647==by 0x5AA8BD: ACLIP::parse() (Ip.cc:523)
==26647==by 0x5E0A80: ACL::ParseAclLine(ConfigParser&, ACL**) (Acl.cc:174)
==26647==by 0x4B0C0F: parse_line(char*) (cache_cf.cc:1252)
==26647==by 0x4B2076: parseOneConfigFile(char const*, unsigned int) 
(cache_cf.cc:518)
==26647==by 0x4B29D0: parseConfigFile(char const*) (cache_cf.cc:558)
==26647==by 0x546B81: SquidMain(int, char**) (main.cc:1372)
==26647==by 0x547445: main (main.cc:1215)

[Amos Jeffries] Portability: squid provides strtoll()

[Amos Jeffries] Bug 3658: ERR_ZERO_SIZE errors propagates out even after 
successful retry

--
[...truncated 6931 lines...]
Testing ../../src/HttpVersion.h ...Ok.
Testing ../../src/HttpRequest.h ...Ok.
Testing ../../src/FileMap.h ...Ok.
Testing ../../src/ConfigParser.h ...Ok.
Testing ../../src/client_side.h ...Ok.
Testing ../../src/StoreMeta.h ...Ok.
Testing ../../src/SquidMath.h ...Ok.
Testing ../../src/LeakFinder.h ...Ok.
Testing ../../src/DelayIdComposite.h ...Ok.
Testing ../../src/CacheManager.h ...Ok.
Testing ../../src/CpuAffinitySet.h ...Ok.
Testing ../../src/URLScheme.h ...Ok.
Testing ../../src/MemBuf.h ...Ok.
Testing ../../src/DelayId.h ...Ok.
Testing ../../src/BodyPipe.h ...Ok.
Testing ../../src/HttpReply.h ...Ok.
Testing ../../src/StatHist.h ...Ok.
Testing ../../src/HttpHeaderStat.h ...Ok.
Testing ../../src/mem_node.h ...Ok.
Testing ../../src/DelayPool.h ...Ok.
Testing ../../src/StoreMetaObjSize.h ...Ok.
Testing ../../src/helper.h ...Ok.
Testing ../../src/errorpage.h ...Ok.
Testing ../../src/ClientInfo.h ...Ok.
Testing ../../src/HttpStatusLine.h ...Ok.
Testing ../../src/StoreIOBuffer.h ...Ok.
Testing ../../src/LoadableModule.h ...Ok.
Testing ../../src/typedefs.h ...Ok.
Testing ../../src/ipcache.h ...Ok.
Testing ../../src/comm_err_t.h ...Ok.
Testing ../../src/clientStream.h ...Ok.
Testing ../../src/FadingCounter.h ...Ok.
Testing ../../src/client_side_request.h ...Ok.
Testing ../../src/Mem.h ...Ok.
Testing ../../src/HttpHdrCc.h ...Ok.
Testing ../../src/htcp.h ...Ok.
Testing ../../src/StoreSearch.h ...Ok.
Testing ../../src/pconn.h ...Ok.
Testing ../../src/CpuAffinity.h ...Ok.
Testing ../../src/Generic.h ...Ok.
Testing ../../src/ETag.h ...Ok.
Testing ../../src/CpuAffinityMap.h ...Ok.
Testing ../../src/MemObject.h ...Ok.
Testing ../../src/SwapDir.h ...Ok.
Testing ../../src/ClientRequestContext.h ...Ok.
Testing ../../src/HelperChildConfig.h ...Ok.
Testing ../../src/StoreMetaUnpacker.h ...Ok.
Testing ../../src/err_detail_type.h ...Ok.
Testing ../../src/cbdata.h ...Ok.
Testing ../../src/lookup_t.h ...Ok.
Testing ../../src/snmp_core.h ...Ok.
Testing ../../src/URL.h ...Ok.
Testing ../../src/wordlist.h ...Ok.
Testing ../../src/StoreFileSystem.h ...Ok.
Testing ../../src/AccessLogEntry.h ...Ok.
Testing ../../src/ConfigOption.h ...Ok.
Testing ../../src/CommCalls.h ...Ok.
Testing ../../src/PeerSelectState.h ...Ok.
Testing ../../src/EventLoop.h ...Ok.
Testing ../../src/forward.h ...Ok.
Testing ../../src/DelayPools.h ...Ok.
Testing ../../src/ChunkedCodingParser.h ...Ok.
Testing ../../src/Store.h ...Ok.
Testing ../../src/StoreMetaMD5.h ...Ok.
Testing ../../src/enums.h ...Ok.
Testing ../../src/HttpHeaderMask.h ...Ok.
Testing ../../src/StoreIOState.h ...Ok.
Testing ../../src/TimeOrTag.h ...Ok.
Testing ../../src/DelayConfig.h ...Ok.
Testing ../../src/hier_code.h ...Ok.
Testing ../../src/DelayUser.h ...Ok.
Testing ../../src/HttpParser.h ...Ok.
Testing ../../src/MemBlob.h ...Ok.
Testing ../../src/HttpStatusCode.h ...Ok.
Testing ../../src/icp_opcode.h ...Ok.
Testing ../../src/HttpHdrContRange.h ...Ok.
Testing ../../src/SquidDns.h ...Ok.
Testing ../../src/globals.h ...Ok.
Testing ../../src/DelayVector.h ...Ok.
Testing ../../src/http.h ...Ok.
Testing ../../src/HttpHdrScTarget.h ...Ok.
Testing ../../src/SquidTime.h ...Ok.
Testing ../

Build failed in Jenkins: 3.2-matrix » obsd-51-x86 #271

2012-10-06 Thread noc
See 

--
Started by upstream project "3.2-matrix" build number 271
Building remotely on obsd-51-x86 in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:901)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1254)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:589)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
at hudson.model.Run.execute(Run.java:1502)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:236)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:901)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1254)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:589)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
at hudson.model.Run.execute(Run.java:1502)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:236)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:901)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1254)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:589)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
at hudson.model.Run.execute(Run.java:1502)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:236)


Build failed in Jenkins: 3.2-matrix » obsd-49-x86 #271

2012-10-06 Thread noc
See 

--
Started by upstream project "3.2-matrix" build number 271
Building remotely on obsd-49-x86 in workspace 

java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:901)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1254)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:589)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
at hudson.model.Run.execute(Run.java:1502)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:236)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:901)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1254)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:589)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
at hudson.model.Run.execute(Run.java:1502)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:236)
Retrying after 10 seconds
java.io.IOException: Failed to mkdirs: 

at hudson.FilePath.mkdirs(FilePath.java:901)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1254)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:589)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:88)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:494)
at hudson.model.Run.execute(Run.java:1502)
at hudson.matrix.MatrixRun.run(MatrixRun.java:146)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:236)


Jenkins build is back to normal : 3.2-matrix » master #271

2012-10-06 Thread noc
See 



Re[2]: Summary of store_url project and some questions before posting some patches.

2012-10-06 Thread Eliezer Croitoru
> Original Message 
>From: Alex Rousskov 
>To: "Eliezer Croitoru" 
>Cc: "Squid Developers" 
>Sent: Sat, Oct 6, 2012, 11:49 PM
>Subject: Re: Summary of store_url project and some questions before posting 
>some patches.
>
>On 10/06/2012 09:24 AM, Eliezer Croitoru wrote:
>> As I moved forward and managed to make store_url feature stable to pass
>> all of my tests The next step is to state a summary of the feature.
>>
>> The goal of store_url feature is to give squid a way to handle
>> De-duplication of objects.
>>
>> Code implementation is quite simple but since I was working with the old
>> bzr revision 12317 ant now its about 30 revisions up I dont have a clue
>> on what to do.
>> for now I downloaded the new 2a revision 12349.
What do you think about that? does it matters at all?

>>
>>
>> How it was done in squid 2.7 is less relevant for squid 3 branch
>> implementation and was reviewed in the other thread.
>>
>> We discussed earlier on "url" to "originalUrl" refactoring and it seems
>> to me that this will make a big and unneeded modification to the code
>> that is not needed to achieve the goal.
>
>One reason to rename the old "url" field is so that we can double check
>that you caught all usage cases. If you do not rename, the patch will
>not show the cases you missed (if any). Any renaming changes for this
>reason alone can be later dropped (after reviews and before the commit).
>
>Another reason is to alert future developers that they are dealing with
>a URL which may be different from the store URL. If this is a valid/good
>reason, the renaming should stay.
Ok seems reasonable to me.

>
>
>> Also At every place the store_url is mentioned can be the indication of
>> it while every other place a "url" or "canonicalUrl" is mentioned will
>> be the mark of original url usage.
>
>Yes, but those "every other places" will not be visible in the patch and
>since "url" is a rather generic term some of them may be difficult to
>find in Squid sources using a manual search.
>
I wont say that there is no possiblitiy but I didnt used only manual search for 
it since it's unreasonable in such a huge ammount of code.
I indeed found one place that I needed to change the code and since it was in a 
#IF statement only the compiler was able to recognize it.


>
>HTH,
>
>Alex.
Thanks,
Helps  a lot!



Re: Summary of store_url project and some questions before posting some patches.

2012-10-06 Thread Alex Rousskov
On 10/06/2012 09:24 AM, Eliezer Croitoru wrote:
> As I moved forward and managed to make store_url feature stable to pass
> all of my tests The next step is to state a summary of the feature.
> 
> The goal of store_url feature is to give squid a way to handle
> De-duplication of objects.
> 
> Code implementation is quite simple but since I was working with the old
> bzr revision 12317 ant now its about 30 revisions up I dont have a clue
> on what to do.
> for now I downloaded the new 2a revision 12349.
> 
> 
> How it was done in squid 2.7 is less relevant for squid 3 branch
> implementation and was reviewed in the other thread.
> 
> We discussed earlier on "url" to "originalUrl" refactoring and it seems
> to me that this will make a big and unneeded modification to the code
> that is not needed to achieve the goal.

One reason to rename the old "url" field is so that we can double check
that you caught all usage cases. If you do not rename, the patch will
not show the cases you missed (if any). Any renaming changes for this
reason alone can be later dropped (after reviews and before the commit).

Another reason is to alert future developers that they are dealing with
a URL which may be different from the store URL. If this is a valid/good
reason, the renaming should stay.


> Also At every place the store_url is mentioned can be the indication of
> it while every other place a "url" or "canonicalUrl" is mentioned will
> be the mark of original url usage.

Yes, but those "every other places" will not be visible in the patch and
since "url" is a rather generic term some of them may be difficult to
find in Squid sources using a manual search.


HTH,

Alex.



Re: /bzr/squid3/trunk/ r12345: Do not check 'reply content_length is too big' condition twice.

2012-10-06 Thread Alex Rousskov
On 10/05/2012 05:36 PM, Alex Rousskov wrote:
> 
> revno: 12345
> committer: Alex Rousskov 
> branch nick: trunk
> timestamp: Fri 2012-10-05 17:36:22 -0600
> message:
>   Do not check 'reply content_length is too big' condition twice.
>   
>   The check got duplicated was 
>   
>   4410
>   committer: hno
>   branch nick: HEAD
>   timestamp: Wed 2000-05-03 00:49:26 +
>   message:
> hno squid-2.2.STABLE2.to_large_objects-2.patch
> Squid-2.2.STABLE2: Don't swap out objects > maximum_object_size
> modified:
>   src/store.cc
> 


Amos,

Here is the correct version of that corrupted commit message for
trunk r12345:

---
Do not check 'reply content_length is too big' condition twice.

Saves a few CPU cycles. No visible runtime effects are expected.

The semi-duplicate check was introduced in trunk r4410 while trying to
prevent huge objects from being swapped out. It is not clear to me why
that change helped at the time (but it could have something to do with
negative content_length values and their effect on then-current size types).
---


Thank you,

Alex.

>  } else if ((getReply()->content_length > 0 &&
>  getReply()->content_length
>  > Config.Store.maxObjectSize) ||
> mem_obj->endOffset() > Config.Store.maxObjectSize) {
>  debugs(20, 2, "StoreEntry::checkCachable: NO: too big");
>  ++store_check_cachable_hist.no.too_big;
> -} else if (getReply()->content_length > Config.Store.maxObjectSize) {
> -debugs(20, 2, "StoreEntry::checkCachable: NO: too big");
> -++store_check_cachable_hist.no.too_big;
>  } else if (checkTooSmall()) {



Summary of store_url project and some questions before posting some patches.

2012-10-06 Thread Eliezer Croitoru
As I moved forward and managed to make store_url feature stable to pass 
all of my tests The next step is to state a summary of the feature.


The goal of store_url feature is to give squid a way to handle 
De-duplication of objects.


Code implementation is quite simple but since I was working with the old 
bzr revision 12317 ant now its about 30 revisions up I dont have a clue 
on what to do.

for now I downloaded the new 2a revision 12349.


How it was done in squid 2.7 is less relevant for squid 3 branch 
implementation and was reviewed in the other thread.


We discussed earlier on "url" to "originalUrl" refactoring and it seems 
to me that this will make a big and unneeded modification to the code 
that is not needed to achieve the goal.


Also At every place the store_url is mentioned can be the indication of 
it while every other place a "url" or "canonicalUrl" is mentioned will 
be the mark of original url usage.


The steps we were talking about in the feature implementation are:
1. add the "fake" store_url interface to the helper based on redirect.
2. prepare all methods\functions and variables to allow the actual 
store_url happen.
3. add the actual implementation of store_url feature (making fake into 
real) and adding the needed documentation and configuration related code 
to allow the usage of the feature.

4. integrating store_url related code into PURGE,ICP,HTCP.

Things to consider?
Proposals for Tests that should be done are more then welcome.


Eliezer

--
Eliezer Croitoru
https://www1.ngtech.co.il
IT consulting for Nonprofit organizations
eliezer  ngtech.co.il


Re: some notes and help to think is needed + Test results of testing basics in store_url_rewrite.

2012-10-06 Thread Eliezer Croitoru

On 10/6/2012 2:08 PM, Amos Jeffries wrote:


?? sure we are looking at the same Line-506 of src/client_side_reply.cc
in trunk ??

" switch (varyEvaluateMatch(e, r)) {"


well it seems one of us have caching problem? or what?
my 506 is:
"if (strcmp(e->mem_obj->url, urlCanonical(r)) != 0) {"

I also verified using https to make sure I dont have any regular cache 
problems:

https://bazaar.launchpad.net/~squid/squid/3-trunk/view/head:/src/client_side_reply.cc#L506

"if (strcmp(e->mem_obj->url, urlCanonical(r)) != 0) {"


I just wanted to post that as I was thinking it is possible to cache 
with my method and it works quite well.


I managed to cache sites by just adding additional check to make sure 
that we check a url mismatch only when there wasnt done any store_url.


I think it's the best method with no store_url written all over it.
the method assumes that if someone uses store_url_rewrite he knows what 
he is doing and not just doing some copy && paste.


It seems to me like a very straight forward way to implement it:
store in the mem_obj->request->store_url

in the state of hexdigest to get the public hash and set the public hash 
if there is a store_url by the store_url.


then later just to blow off the url mismatch check (before the Vary 
check) that will never ever suppose to match in store_url_rewrite cases.


Now I just need to update my source to the latest maybe 3.3 ? add the 
needed code, review the patch and apply.


Eliezer




Re: some notes and help to think is needed + Test results of testing basics in store_url_rewrite.

2012-10-06 Thread Amos Jeffries

On 6/10/2012 8:53 p.m., Eliezer Croitoru wrote:

On 9/27/2012 7:55 AM, Amos Jeffries wrote:


This is the HTTP/1.1 variant handling code. Each request URL may have
multiple response variants depending on the things indicated by Vary:
header and possibly ETag header as a unique ID for each variant. How it
is done in Squid is that the store contains a vary meta object as well
as the normal file meta object.

Well yes but this specific check:
http://bazaar.launchpad.net/~squid/squid/3-trunk/view/head:/src/client_side_reply.cc#L506 



is not related to the vary headers at all but a basic url match check.



?? sure we are looking at the same Line-506 of src/client_side_reply.cc 
in trunk ??


" switch (varyEvaluateMatch(e, r)) {"






The storeURL should point at the meta object, and then when loaded meta
object points at other bits to combine in addition to the storeURL to
make a new key for a second lookup which is expected to find the actual
file object for that variant.
So if I understood right you mean that we need to store the storeURL 
in the metadata?


No, not quite. The vary object needs only to store the additional 
details to append to the key (ie for "Vary:Accept-Encoding" it stores 
the encoding header values). Not a URL.
The URL being used (original or store) is already known to the code 
which looked it up ... using that URL.


We were talking about it before and never decided if to use the 
metadata or not.
If I understood correctly the store_url is in the ufs\aufs store 
metadata but not in others.
I can put the storeURL in the meta data and then to make a check for 
that.


We still have not found a case for it being added.





You should make these secondary keys use the storeURL instead of the
original URL (only when the original URL was used, some variant may be
looked up based on ETag or digest values alone).






Some other places which need it are:
   PURGE requets handling lookups
   ICP request lookups
   HTCP request lookups


This is after we decide whatever to do on regular cache checks behavior.


Yes the 2.7 store-URL is known not to support these well. First the 
portage, then the additional bug fixes.



Amos


Build failed in Jenkins: 3.HEAD-amd64-CentOS-5.3 #2065

2012-10-06 Thread noc
See 

Changes:

[Amos Jeffries] Polish: use DBG_PARSE_NOTE to warn about deprecated logformat 
tokens

--
[...truncated 4345 lines...]
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT Strategised.lo 
-MD -MP -MF .deps/Strategised.Tpo -c ../../../src/acl/Strategised.cc  -fPIC 
-DPIC -o .libs/Strategised.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT Acl.lo -MD -MP 
-MF .deps/Acl.Tpo -c ../../../src/acl/Acl.cc -o Acl.o >/dev/null 2>&1
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT Strategised.lo 
-MD -MP -MF .deps/Strategised.Tpo -c ../../../src/acl/Strategised.cc -o 
Strategised.o >/dev/null 2>&1
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT FilledChecklist.lo -MD -MP -MF ".deps/FilledChecklist.Tpo" -c -o 
FilledChecklist.lo ../../../src/acl/FilledChecklist.cc; \
then mv -f ".deps/FilledChecklist.Tpo" ".deps/FilledChecklist.Plo"; 
else rm -f ".deps/FilledChecklist.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT 
FilledChecklist.lo -MD -MP -MF .deps/FilledChecklist.Tpo -c 
../../../src/acl/FilledChecklist.cc  -fPIC -DPIC -o .libs/FilledChecklist.o
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT AclAddress.lo -MD -MP -MF ".deps/AclAddress.Tpo" -c -o AclAddress.lo 
../../../src/acl/AclAddress.cc; \
then mv -f ".deps/AclAddress.Tpo" ".deps/AclAddress.Plo"; else rm -f 
".deps/AclAddress.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT AclAddress.lo 
-MD -MP -MF .deps/AclAddress.Tpo -c ../../../src/acl/AclAddress.cc  -fPIC -DPIC 
-o .libs/AclAddress.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT AclAddress.lo 
-MD -MP -MF .deps/AclAddress.Tpo -c ../../../src/acl/AclAddress.cc -o 
AclAddress.o >/dev/null 2>&1
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT 
FilledChecklist.lo -MD -MP -MF .deps/FilledChecklist.Tpo -c 
../../../src/acl/FilledChecklist.cc -o FilledChecklist.o >/dev/null 2>&1
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT IntRange.lo -MD -MP -MF ".deps/IntRange.Tpo" -c -o IntRange.lo 
../../../src/acl/IntRange.cc; \
then mv -f ".deps/IntRange.Tpo" ".deps/IntRange.Plo"; else rm -f 
".deps/IntRange.Tpo"; exit 1; fi
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT IntRange.lo 
-MD -MP -MF .deps/IntRange.Tpo -c ../../../src/acl/IntRange.cc  -fPIC -DPIC -o 
.libs/IntRange.o
libtool: compile:  g++ -DHAVE_CONFIG_H -I../../.. -I../../../include 
-I../../../lib -I../../../src -I../../include -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 -MT IntRange.lo 
-MD -MP -MF .deps/IntRange.Tpo -c ../../../src/acl/IntRange.cc -o IntRange.o 
>/dev/null 2>&1
if /bin/sh ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H  
-I../../.. -I../../../include -I../../../lib -I../../../src -I../../include 
 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g 
-O2 -MT RegexData.lo -MD -MP -MF ".deps/RegexData.Tpo" -c -o RegexData.lo 
../../../src/acl/RegexData.cc; \
then mv -f ".deps/RegexData.Tpo" ".deps/RegexData.Plo"; else rm -f 
".deps/RegexData.Tpo"; exit 1; fi
libtool: compile:

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.0-clang #20

2012-10-06 Thread noc
See 

--
[...truncated 3006 lines...]
libtool: link: clang++ 
-DHELPERSCRIPT=\"/usr
 -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread -o basic_smb_auth 
basic_smb_auth-basic_smb_auth.o  -L/usr/local/lib 
../../../lib/.libs/libmiscencoding.a -L../../../compat -lcompat-squid -lm 
-pthread
clang++: warning: argument unused during compilation: '-g'
clang++: warning: argument unused during compilation: '-g'
Making all in fake
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl   -I/usr/include  -I/usr/include -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include -MT fake.o -MD -MP -MF .deps/fake.Tpo -c -o fake.o 
../../../../helpers/basic_auth/fake/fake.cc
mv -f .deps/fake.Tpo .deps/fake.Po
/bin/sh ../../../libtool --tag=CXX--mode=link clang++ -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include   -g -L/usr/local/lib -Wl,-R/usr/local/lib -pthread -o 
basic_fake_auth fake.o -L../../../compat -lcompat-squid  
libtool: link: clang++ -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread 
-o basic_fake_auth fake.o  -L/usr/local/lib -L../../../compat -lcompat-squid 
-pthread
clang++: warning: argument unused during compilation: '-g'
clang++: warning: argument unused during compilation: '-g'
Making all in getpwnam
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl   -I/usr/include  -I/usr/include -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include -MT basic_getpwnam_auth.o -MD -MP -MF 
.deps/basic_getpwnam_auth.Tpo -c -o basic_getpwnam_auth.o 
../../../../helpers/basic_auth/getpwnam/basic_getpwnam_auth.cc
mv -f .deps/basic_getpwnam_auth.Tpo .deps/basic_getpwnam_auth.Po
/bin/sh ../../../libtool --tag=CXX--mode=link clang++ -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include   -g -L/usr/local/lib -Wl,-R/usr/local/lib -pthread -o 
basic_getpwnam_auth basic_getpwnam_auth.o ../../../lib/libmiscencoding.la  
-L../../../compat -lcompat-squid   -lcrypt 
libtool: link: clang++ -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread 
-o basic_getpwnam_auth basic_getpwnam_auth.o  -L/usr/local/lib 
../../../lib/.libs/libmiscencoding.a -L../../../compat -lcompat-squid -lcrypt 
-pthread
clang++: warning: argument unused during compilation: '-g'
clang++: warning: argument unused during compilation: '-g'
Making all in digest_auth
Making all in file
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl -I../../../../helpers/digest_auth/file   
-I/usr/include  -I/usr/include -Wall -Wpointer-arith -Wwrite-strings -Wcomments 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT digest_file_auth.o 
-MD -MP -MF .deps/digest_file_auth.Tpo -c -o digest_file_auth.o 
../../../../helpers/digest_auth/file/digest_file_auth.cc
mv -f .deps/digest_file_auth.Tpo .deps/digest_file_auth.Po
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl -I../../../../helpers/digest_auth/file   
-I/usr/include  -I/usr/include -Wall -Wpointer-arith -Wwrite-strings -Wcomments 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT text_backend.o -MD 
-MP -MF .deps/text_backend.Tpo -c -o text_backend.o 
../../../../helpers/digest_auth/file/text_backend.cc
mv -f .deps/text_backend.Tpo .deps/text_backend.Po
/bin/sh ../../../libtool --tag=CXX--mode=link clang++ -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include   -g -L/usr/local/lib -Wl,-R/usr/local/lib -pthread -o 
digest_file_auth digest_file_auth.o  text_backend.o 
../../../lib/libmisccontainers.la  ../../../lib/libmiscencoding.la  
-L../../../compat -lcompat-squid   -lcrypt-lm 
libtool: link: clang++ -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread 
-o digest_file_auth digest_file_auth.o text_backend.o  -L/usr/local/lib 
../../../lib/.libs/libmisccontainers.a ../../../

Build failed in Jenkins: 3.HEAD-amd64-opensuse #220

2012-10-06 Thread noc
See 

--
[...truncated 7163 lines...]
Testing ../../src/mime.h ...Ok.
Testing ../../src/ftp.h ...Ok.
Testing ../../src/LoadableModules.h ...Ok.
Testing ../../src/stmem.h ...Ok.
Testing ../../src/CompositePoolNode.h ...Ok.
Testing ../../src/Server.h ...Ok.
Testing ../../src/wccp.h ...Ok.
Testing ../../src/DelayTagged.h ...Ok.
Testing ../../src/swap_log_op.h ...Ok.
Testing ../../src/HierarchyLogEntry.h ...Ok.
Testing ../../src/StoreClient.h ...Ok.
Testing ../../src/HttpHeaderMask.h ...Ok.
Testing ../../src/unlinkd.h ...Ok.
Testing ../../src/client_side_reply.h ...Ok.
Testing ../../src/StoreMetaSTDLFS.h ...Ok.
Testing ../../src/defines.h ...Ok.
Testing ../../src/multicast.h ...Ok.
Testing ../../src/store_rebuild.h ...Ok.
Testing ../../src/HttpHeaderTools.h ...Ok.
Testing ../../src/RemovalPolicy.h ...Ok.
Testing ../../src/mem_node.h ...Ok.
Testing ../../src/helper.h ...Ok.
Testing ../../src/DelaySpec.h ...Ok.
Testing ../../src/CachePeerDomainList.h ...Ok.
Testing ../../src/AsyncEngine.h ...Ok.
Testing ../../src/StoreSwapLogData.h ...Ok.
Testing ../../src/HttpMsg.h ...Ok.
Testing ../../src/mime_header.h ...Ok.
Testing ../../src/StoreFileSystem.h ...Ok.
Testing ../../src/ICP.h ...Ok.
Testing ../../src/DnsLookupDetails.h ...Ok.
Testing ../../src/peer_userhash.h ...Ok.
Testing ../../src/cache_cf.h ...Ok.
Testing ../../src/Debug.h ...Ok.
Testing ../../src/ExternalACLEntry.h ...Ok.
Testing ../../src/CpuAffinityMap.h ...Ok.
Testing ../../src/HttpRequestMethod.h ...Ok.
Testing ../../src/SquidString.h ...Ok.
Testing ../../src/StoreMetaVary.h ...Ok.
Testing ../../src/fde.h ...Ok.
Testing ../../src/HttpHdrSc.h ...Ok.
Testing ../../src/AuthReg.h ...Ok.
Testing ../../src/StoreMetaObjSize.h ...Ok.
Testing ../../src/NullDelayId.h ...Ok.
Testing ../../src/YesNoNone.h ...Ok.
Testing ../../src/ClientDelayConfig.h ...Ok.
Testing ../../src/NeighborTypeDomainList.h ...Ok.
Testing ../../src/err_type.h ...Ok.
Testing ../../src/HttpHeaderRange.h ...Ok.
Testing ../../src/ExternalACL.h ...Ok.
Testing ../../src/forward.h ...Ok.
Testing ../../src/HttpControlMsg.h ...Ok.
Testing ../../src/whois.h ...Ok.
Testing ../../src/disk.h ...Ok.
Testing ../../src/repl_modules.h ...Ok.
Testing ../../src/StrList.h ...Ok.
Testing ../../src/SquidConfig.h ...Ok.
Testing ../../src/DiskIO/ReadRequest.h ...Ok.
Testing ../../src/DiskIO/DiskIOModule.h ...Ok.
Testing ../../src/DiskIO/DiskIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskFile.h ...Ok.
Testing ../../src/DiskIO/WriteRequest.h ...Ok.
Testing ../../src/DiskIO/IORequestor.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedFile.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/Mmapped/MmappedIOStrategy.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskFile.h ...Ok.
Testing ../../src/DiskIO/AIO/async_io.h ...Ok.
Testing ../../src/DiskIO/AIO/aio_win32.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskIOModule.h ...Ok.
Testing ../../src/DiskIO/AIO/AIODiskIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskFile.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/CommIO.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreads.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskThreads/DiskThreadsDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoFile.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/IpcIo/IpcIoIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdFile.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/diomsg.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdIOStrategy.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskdAction.h ...Ok.
Testing ../../src/DiskIO/DiskDaemon/DiskDaemonDiskIOModule.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingIOStrategy.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingFile.h ...Ok.
Testing ../../src/DiskIO/Blocking/BlockingDiskIOModule.h ...Ok.
..
OK (2)
PASS: tests/testACLMaxUserIP
.
OK (1)
PASS: tests/testBoilerplate
..
OK (2)
PASS: tests/testCacheManager
.
OK (1)
PASS: tests/testDiskIO
..Actual Text:
Last event to run: last event

Operation\tNext Execution \tWeight\tCallback Valid?
test event   \t0.000 sec\t0\t N/A
test event2  \t0.000 sec\t0\t N/A


OK (6)
PASS: tests/testEvent
...
OK (3)
PASS: tests/testEventLoop
PASS: tests/test_http_range
.
OK (5)
PASS: tests/testHttpParser
.SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc enumInit (not implemented).
SKIP: StatHist.cc e

Build failed in Jenkins: 3.HEAD-amd64-FreeBSD-9.0-clang #19

2012-10-06 Thread noc
See 

Changes:

[Automatic source maintenance] Branch 3.3.0.0

--
[...truncated 3009 lines...]
libtool: link: clang++ 
-DHELPERSCRIPT=\"/usr
 -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread -o basic_smb_auth 
basic_smb_auth-basic_smb_auth.o  -L/usr/local/lib 
../../../lib/.libs/libmiscencoding.a -L../../../compat -lcompat-squid -lm 
-pthread
clang++: warning: argument unused during compilation: '-g'
clang++: warning: argument unused during compilation: '-g'
Making all in fake
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl   -I/usr/include  -I/usr/include -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include -MT fake.o -MD -MP -MF .deps/fake.Tpo -c -o fake.o 
../../../../helpers/basic_auth/fake/fake.cc
mv -f .deps/fake.Tpo .deps/fake.Po
/bin/sh ../../../libtool --tag=CXX--mode=link clang++ -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include   -g -L/usr/local/lib -Wl,-R/usr/local/lib -pthread -o 
basic_fake_auth fake.o -L../../../compat -lcompat-squid  
libtool: link: clang++ -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread 
-o basic_fake_auth fake.o  -L/usr/local/lib -L../../../compat -lcompat-squid 
-pthread
clang++: warning: argument unused during compilation: '-g'
clang++: warning: argument unused during compilation: '-g'
Making all in getpwnam
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl   -I/usr/include  -I/usr/include -Wall 
-Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include -MT basic_getpwnam_auth.o -MD -MP -MF 
.deps/basic_getpwnam_auth.Tpo -c -o basic_getpwnam_auth.o 
../../../../helpers/basic_auth/getpwnam/basic_getpwnam_auth.cc
mv -f .deps/basic_getpwnam_auth.Tpo .deps/basic_getpwnam_auth.Po
/bin/sh ../../../libtool --tag=CXX--mode=link clang++ -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include   -g -L/usr/local/lib -Wl,-R/usr/local/lib -pthread -o 
basic_getpwnam_auth basic_getpwnam_auth.o ../../../lib/libmiscencoding.la  
-L../../../compat -lcompat-squid   -lcrypt 
libtool: link: clang++ -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread 
-o basic_getpwnam_auth basic_getpwnam_auth.o  -L/usr/local/lib 
../../../lib/.libs/libmiscencoding.a -L../../../compat -lcompat-squid -lcrypt 
-pthread
clang++: warning: argument unused during compilation: '-g'
clang++: warning: argument unused during compilation: '-g'
Making all in digest_auth
Making all in file
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl -I../../../../helpers/digest_auth/file   
-I/usr/include  -I/usr/include -Wall -Wpointer-arith -Wwrite-strings -Wcomments 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT digest_file_auth.o 
-MD -MP -MF .deps/digest_file_auth.Tpo -c -o digest_file_auth.o 
../../../../helpers/digest_auth/file/digest_file_auth.cc
mv -f .deps/digest_file_auth.Tpo .deps/digest_file_auth.Po
clang++ -DHAVE_CONFIG_H  -I../../../.. -I../../../../include -I../../../../lib  
-I../../../../src -I../../../include  -I/usr/local/include -I/usr/include  
-I/usr/include -I../../../../libltdl -I../../../../helpers/digest_auth/file   
-I/usr/include  -I/usr/include -Wall -Wpointer-arith -Wwrite-strings -Wcomments 
-Werror -pipe -D_REENTRANT -g -O2 -I/usr/local/include -MT text_backend.o -MD 
-MP -MF .deps/text_backend.Tpo -c -o text_backend.o 
../../../../helpers/digest_auth/file/text_backend.cc
mv -f .deps/text_backend.Tpo .deps/text_backend.Po
/bin/sh ../../../libtool --tag=CXX--mode=link clang++ -Wall -Wpointer-arith 
-Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -g -O2 
-I/usr/local/include   -g -L/usr/local/lib -Wl,-R/usr/local/lib -pthread -o 
digest_file_auth digest_file_auth.o  text_backend.o 
../../../lib/libmisccontainers.la  ../../../lib/libmiscencoding.la  
-L../../../compat -lcompat-squid   -lcrypt-lm 
libtool: link: clang++ -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror 
-pipe -D_REENTRANT -g -O2 -I/usr/local/include -g -Wl,-R/usr/local/lib -pthread 
-o digest_file_auth digest_file_auth.o text_backend.o  -L

Re: some notes and help to think is needed + Test results of testing basics in store_url_rewrite.

2012-10-06 Thread Eliezer Croitoru

On 9/27/2012 7:55 AM, Amos Jeffries wrote:


This is the HTTP/1.1 variant handling code. Each request URL may have
multiple response variants depending on the things indicated by Vary:
header and possibly ETag header as a unique ID for each variant. How it
is done in Squid is that the store contains a vary meta object as well
as the normal file meta object.

Well yes but this specific check:
http://bazaar.launchpad.net/~squid/squid/3-trunk/view/head:/src/client_side_reply.cc#L506

is not related to the vary headers at all but a basic url match check.




The storeURL should point at the meta object, and then when loaded meta
object points at other bits to combine in addition to the storeURL to
make a new key for a second lookup which is expected to find the actual
file object for that variant.
So if I understood right you mean that we need to store the storeURL in 
the metadata?
We were talking about it before and never decided if to use the metadata 
or not.
If I understood correctly the store_url is in the ufs\aufs store 
metadata but not in others.

I can put the storeURL in the meta data and then to make a check for that.






You should make these secondary keys use the storeURL instead of the
original URL (only when the original URL was used, some variant may be
looked up based on ETag or digest values alone).






Some other places which need it are:
   PURGE requets handling lookups
   ICP request lookups
   HTCP request lookups


This is after we decide whatever to do on regular cache checks behavior.



   Cache Digest is a little more tricky. Ignore it for now. The remote
proxy will never be guaranteed to do the right lookups even if you add
both original and store URL to the digest.



--
Eliezer Croitoru
https://www1.ngtech.co.il
IT consulting for Nonprofit organizations
eliezer  ngtech.co.il