Re: request->my_addr change from 2.6.STABLE3 to 2.6.STABLE10

[Henrik Nordstrom]

mån 2007-03-19 klockan 08:46 +0900 skrev Steven Wilton:

> Can anyone confirm whether request->my_addr should contain the IP address
> that the customer has connected to, or the IP address that the OS has
> redirected the packet to for requests that have been semnt to squid using
> NAT.

The two should really be split in different fields.. doesn't really make
sense to overload my_addr in this manner these days.

It did sense in 2.5 as it didn't have a concept of transparent IP
interception and it all was running as piggyback on the IP based virtual
host for accelerator mode, but in 2.6 it's all separate.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel

RE: request->my_addr change from 2.6.STABLE3 to 2.6.STABLE10

[Steven Wilton]

> -Original Message-
> From: Steven Wilton [mailto:[EMAIL PROTECTED] 
> Sent: Monday, 19 March 2007 8:46 AM
> To: squid-dev@squid-cache.org
> Subject: request->my_addr change from 2.6.STABLE3 to 2.6.STABLE10
> 
> I've just discovered that due to the reworking of places that
> ClientNatLookup is called, request->my_addr now contains the 
> local IP of the
> proxy server rather than the IP address of the web server the 
> client thinks
> it's talking to for transparent requests.  I'm assuming that 
> this was done
> deliberately, but it has caused a regression for a patch that 
> I'm using.
> 
> Can anyone confirm whether request->my_addr should contain 
> the IP address
> that the customer has connected to, or the IP address that the OS has
> redirected the packet to for requests that have been semnt to 
> squid using
> NAT.  (ie client sends request to 66.102.7.104:80 proxy redirects to
> 192.168.0.1:3128.  Should request->my_addr contian the 
> 66.102.7.104 IP, or
> 192.168.0.1)?
> 

I just figured it out - the change was that clientNatLookup was only being
called if the host header was not given.  I've modifed my patch accordingly.

Steven

-- 
No virus found in this outgoing message.
Checked by AVG Free Edition.
Version: 7.5.446 / Virus Database: 268.18.13/726 - Release Date: 18/03/2007
3:34 PM