Re: [Squid-cvs] squid3-ipv6 squid3/src ACLIP.cc,1.8.2.4,1.8.2.5
On Wed, 25 May 2005, Rafael Martinez Torres wrote: Index: ACLIP.cc -if (ntohl(A.s_addr) ntohl(C.s_addr)) +if (memcmp(A, C, sizeof(struct IN_ADDR)) 0) Hmm.. this has quite different semantics. The original looks at the addresses in host byte order, while the memcmp looks at the addresses in network byte order... are you sure this change is OK here? Regards Henrik
Re: [Squid-cvs] squid3-ipv6 squid3/src ACLIP.cc,1.8.2.4,1.8.2.5
On Thu, 26 May 2005, Henrik Nordstrom wrote: On Wed, 25 May 2005, Rafael Martinez Torres wrote: Index: ACLIP.cc -if (ntohl(A.s_addr) ntohl(C.s_addr)) +if (memcmp(A, C, sizeof(struct IN_ADDR)) 0) Hmm.. this has quite different semantics. The original looks at the addresses in host byte order, while the memcmp looks at the addresses in network byte order... Err.. both methods looks at the addresses in the correct order. It's just my brain trying to compose emails while asleep. Regards Henrik
