Re: Squid 3.0 bugs that need you.

[Alex Rousskov]

On Sat, 2007-04-14 at 03:27 +1200, Amos Jeffries wrote:

> Here is the patch for that additional ICAP problem that came to light 
> testing cppunit removal.

Committed.

Thank you,

Alex.

Re: Squid 3.0 bugs that need you.

[Amos Jeffries]

Alex Rousskov wrote:

Hi there,

I went through the remaining Squid3 non-enhancement bug reports
targeted for 3.0. For most bugs, I was able to close or comment in the
bugzilla. The following bugs are special because the questions did not
seem appropriate for bugzilla. Please review.

http://www.squid-cache.org/bugs/show_bug.cgi?id=1345
Bug 1345 - Problem with tar-file

Squid3 needs a volunteer to remove cppunit from the distribution
and, probably, from CVS. Anybody is willing to do that? This is
a perfect work item for folks who hate C++ development as it
should not require much C++ programming...


http://www.squid-cache.org/bugs/show_bug.cgi?id=1475
Bug 1475 - File descriptor limit does work.

I am not sure what the final resolution for this bug is. Henrik?
Adrian?


ESI bugs targeted for 3.0
http://www.squid-cache.org/bugs/show_bug.cgi?id=951
http://www.squid-cache.org/bugs/show_bug.cgi?id=1088

If nobody is willing to work on ESI now, I would like to bump
any 3.0 target milestone for ESI to 3.1 because ESI is an
optional feature. Any objections?


Also, there are quite a few bugs targeted for 3.1 and bugs without a
specific target. I reviewed the ones without a target for possible 3.0
inclusion and updated some of the comments. If there is a Squid3 bug
that is not targeted for 3.0 release, but you think it should, please
flag it as such.


Thank you,

Alex.



Here is the patch for that additional ICAP problem that came to light 
testing cppunit removal.



Amos

--- Makefile.am	2007-04-14 03:26:33.0 +1200
+++ Makefile.am-2	2007-04-14 02:41:52.0 +1200
@@ -1249,6 +1249,7 @@
 	ACLStringData.cc \
 	ACLRegexData.cc \
 	ACLUserData.cc \
+	AsyncCall.cc \
 	authenticate.cc \
 	BodyPipe.cc \
 	cache_manager.cc \
@@ -1413,6 +1414,7 @@
 	ACLStringData.cc \
 	ACLRegexData.cc \
 	ACLUserData.cc \
+	AsyncCall.cc \
 	authenticate.cc \
 	BodyPipe.cc \
 	cache_manager.cc \
@@ -1563,6 +1565,7 @@
 	ACLStringData.cc \
 	ACLRegexData.cc \
 	ACLUserData.cc \
+	AsyncCall.cc \
 	authenticate.cc \
 	BodyPipe.cc \
 	cache_manager.cc \
@@ -1737,6 +1740,7 @@
 	ACLStringData.cc \
 	ACLRegexData.cc \
 	ACLUserData.cc \
+	AsyncCall.cc \
 	authenticate.cc \
 	BodyPipe.cc \
 	cache_cf.cc \
@@ -1893,6 +1897,7 @@
 	ACLStringData.cc \
 	ACLRegexData.cc \
 	ACLUserData.cc \
+	AsyncCall.cc \
 	authenticate.cc \
 	BodyPipe.cc \
 	cache_manager.cc \
@@ -2228,6 +2233,7 @@
 	ACLStringData.cc \
 	ACLRegexData.cc \
 	ACLUserData.cc \
+	AsyncCall.cc \
 	authenticate.cc \
 	BodyPipe.cc \
 	cache_manager.cc \

Re: Squid 3.0 bugs that need you.

[Amos Jeffries]

Alex Rousskov wrote:

Hi there,

I went through the remaining Squid3 non-enhancement bug reports
targeted for 3.0. For most bugs, I was able to close or comment in the
bugzilla. The following bugs are special because the questions did not
seem appropriate for bugzilla. Please review.

http://www.squid-cache.org/bugs/show_bug.cgi?id=1345
Bug 1345 - Problem with tar-file

Squid3 needs a volunteer to remove cppunit from the distribution
and, probably, from CVS. Anybody is willing to do that? This is
a perfect work item for folks who hate C++ development as it
should not require much C++ programming...



Done, patch submitted to bugzilla.

Branch nocpp under squid3 HEAD has been left open for now.


Amos

Re: Squid 3.0 bugs that need you.

[squid3]

> On Fri, 2007-04-13 at 12:45 +1200, [EMAIL PROTECTED] wrote:
>>
>> It has not been linked to the cppunit testers, but I have written a
>> specific test app to check each function and proivide for maula-eye
>> check
>> in increments from simplest up for both ipv4-pure then dual protocol
>> paths.
>> Then it has spent nearly a month in live run tests within squid and
>> manual
>> debug traces.
>>
>> That said, if anyone can think of any asserts that should be in there,
>> point them out.
>
> If the test logic is not hooked into 'make check', then it will not be
> run regularly. Platform changes or subsequent untested changes to the
> code base can introduce regressions.
>
> I think it should most definately be hooked into the cppunit test suite.
>

Um, which brings me to ...

Alex: didn't you ask for cppunit to be removed from squid3? if not, I need
a kick in the right direction on that.


Amos

Re: Squid 3.0 bugs that need you.

[Robert Collins]

On Fri, 2007-04-13 at 12:45 +1200, [EMAIL PROTECTED] wrote:
> 
> It has not been linked to the cppunit testers, but I have written a
> specific test app to check each function and proivide for maula-eye
> check
> in increments from simplest up for both ipv4-pure then dual protocol
> paths.
> Then it has spent nearly a month in live run tests within squid and
> manual
> debug traces.
> 
> That said, if anyone can think of any asserts that should be in there,
> point them out. 

If the test logic is not hooked into 'make check', then it will not be
run regularly. Platform changes or subsequent untested changes to the
code base can introduce regressions.

I think it should most definately be hooked into the cppunit test suite.

-Rob
-- 
GPG key available at: .


signature.asc
Description: This is a digitally signed message part

Re: Squid 3.0 bugs that need you.

[squid3]

> On Fri, 2007-04-13 at 01:40 +0200, Henrik Nordstrom wrote:
>>
>> > yay! this has been causing me some nightmares just thinking about
>> it.
>> > I'll get onto a purge this weekend unless there is anyone else who
>> wants
>> > to do it or veto it.
>> >   Speak up within 8 hours or I'll create a 'nocpp' branch and get to
>> work.
>>
>> Should be trivial. It already supports out-of-tree cppunit if you have
>> cppunit installed, and the cppunit requirements is only if your run
>> "make test".
>
> Which everyone should do before committing, of course!
>
> This reminds me - Amos - your IPAddress patch, is the code thoroughly
> unit tested? Thats as much a concern for me as is merging unused code.
> I'd really hate to add more chunks of untested functionality
> *particularly* when they are unused, as its easier for unused code to be
> spectacularly broken and unnoticed than for used to code to be the same.
>

It has not been linked to the cppunit testers, but I have written a
specific test app to check each function and proivide for maula-eye check
in increments from simplest up for both ipv4-pure then dual protocol
paths.
Then it has spent nearly a month in live run tests within squid and manual
debug traces.

That said, if anyone can think of any asserts that should be in there,
point them out.


Amos

Re: Squid 3.0 bugs that need you.

[Robert Collins]

On Fri, 2007-04-13 at 01:40 +0200, Henrik Nordstrom wrote:
> 
> > yay! this has been causing me some nightmares just thinking about
> it. 
> > I'll get onto a purge this weekend unless there is anyone else who
> wants 
> > to do it or veto it.
> >   Speak up within 8 hours or I'll create a 'nocpp' branch and get to
> work.
> 
> Should be trivial. It already supports out-of-tree cppunit if you have
> cppunit installed, and the cppunit requirements is only if your run
> "make test". 

Which everyone should do before committing, of course!

This reminds me - Amos - your IPAddress patch, is the code thoroughly
unit tested? Thats as much a concern for me as is merging unused code.
I'd really hate to add more chunks of untested functionality
*particularly* when they are unused, as its easier for unused code to be
spectacularly broken and unnoticed than for used to code to be the same.

-Rob
-- 
GPG key available at: .


signature.asc
Description: This is a digitally signed message part

Re: Squid 3.0 bugs that need you.

[Henrik Nordstrom]

fre 2007-04-13 klockan 11:05 +1200 skrev Amos Jeffries:

> yay! this has been causing me some nightmares just thinking about it. 
> I'll get onto a purge this weekend unless there is anyone else who wants 
> to do it or veto it.
>   Speak up within 8 hours or I'll create a 'nocpp' branch and get to work.

Should be trivial. It already supports out-of-tree cppunit if you have
cppunit installed, and the cppunit requirements is only if your run
"make test".

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel

Re: Squid 3.0 bugs that need you.

[Henrik Nordstrom]

tor 2007-04-12 klockan 11:42 -0600 skrev Alex Rousskov:

> http://www.squid-cache.org/bugs/show_bug.cgi?id=1475
> Bug 1475 - File descriptor limit does work.
> 
> I am not sure what the final resolution for this bug is. Henrik?
> Adrian?

Closing..

> ESI bugs targeted for 3.0
> http://www.squid-cache.org/bugs/show_bug.cgi?id=951
> http://www.squid-cache.org/bugs/show_bug.cgi?id=1088
> 
> If nobody is willing to work on ESI now, I would like to bump
> any 3.0 target milestone for ESI to 3.1 because ESI is an
> optional feature. Any objections?

Fine by me, assuming it's documented as such.. And hopefully these will
itch someone sufficiently badly to get them fixed and everyone wins.

Regards
Henrik


signature.asc
Description: Detta är en digitalt signerad	meddelandedel

Re: Squid 3.0 bugs that need you.

[Amos Jeffries]

Alex Rousskov wrote:

Hi there,

I went through the remaining Squid3 non-enhancement bug reports
targeted for 3.0. For most bugs, I was able to close or comment in the
bugzilla. The following bugs are special because the questions did not
seem appropriate for bugzilla. Please review.

http://www.squid-cache.org/bugs/show_bug.cgi?id=1345
Bug 1345 - Problem with tar-file

Squid3 needs a volunteer to remove cppunit from the distribution
and, probably, from CVS. Anybody is willing to do that? This is
a perfect work item for folks who hate C++ development as it
should not require much C++ programming...



yay! this has been causing me some nightmares just thinking about it. 
I'll get onto a purge this weekend unless there is anyone else who wants 
to do it or veto it.

 Speak up within 8 hours or I'll create a 'nocpp' branch and get to work.




http://www.squid-cache.org/bugs/show_bug.cgi?id=1475
Bug 1475 - File descriptor limit does work.

I am not sure what the final resolution for this bug is. Henrik?
Adrian?


ESI bugs targeted for 3.0
http://www.squid-cache.org/bugs/show_bug.cgi?id=951
http://www.squid-cache.org/bugs/show_bug.cgi?id=1088

If nobody is willing to work on ESI now, I would like to bump
any 3.0 target milestone for ESI to 3.1 because ESI is an
optional feature. Any objections?


Also, there are quite a few bugs targeted for 3.1 and bugs without a
specific target. I reviewed the ones without a target for possible 3.0
inclusion and updated some of the comments. If there is a Squid3 bug
that is not targeted for 3.0 release, but you think it should, please
flag it as such.


Thank you,

Alex.

Re: Squid 3.0 bugs that need you.

[Gonzalo Arana]

On 4/12/07, Alex Rousskov <[EMAIL PROTECTED]> wrote:

http://www.squid-cache.org/bugs/show_bug.cgi?id=1475
Bug 1475 - File descriptor limit does work.

I am not sure what the final resolution for this bug is. Henrik?
Adrian?


I believe this was a problem related with diskd.  I am checking out
squid3-HEAD in order to reproduce this bug.

Regards,

--
Gonzalo A. Arana