Re: [sr-dev] git:master:91b2c5da: siputils: fix debug logging

[Ovidiu Sas]

Hello Henning,

After the push I realized that I forgot to update the author. My bad.
I wanted to revert the commit, but I didn't know if we have a preferred way
of doing it.
So, is there a guideline for reverting a commit? I will revert it and
re-commit with proper credentials.

Thanks,
Ovidiu


On Thu, Feb 21, 2019, 02:51 Henning Westerholt  wrote:

> Am Mittwoch, 20. Februar 2019, 21:12:07 CET schrieb root:
> > Module: kamailio
> > Branch: master
> > Commit: 91b2c5da34ba7064f858b13bf0a1d27da74336d4
> > URL:
> >
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> > da74336d4
> >
> > Author: root 
> > Committer: root 
> > Date: 2019-02-21T07:11:25+11:00
> >
> > siputils: fix debug logging
> >
> > ---
> >
> > Modified: src/modules/siputils/contact_ops.c
> >
> > ---
> >
> > Diff:
> >
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> > da74336d4.diff Patch:
> >
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> > da74336d4.patch
>
> Hello,
>
> please add a proper User and e-mail address to your local git
> configuration:
>
>
> https://help.github.com/en/articles/setting-your-commit-email-address-in-git
> https://help.github.com/en/articles/setting-your-username-in-git
>
> It is necessary to have a proper (human) author for all commits in the
> public
> repository. Please reply to this e-mail that we have it in the archives as
> well.
>
> Otherwise I think we should revert this commit (could be of course applied
> again).
>
> Best regards,
>
> Henning
>
> --
> Henning Westerholt - https://skalatan.de/blog/
> Kamailio services - https://skalatan.de/services
> Kamailio security assessment - https://skalatan.de/de/assessment
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Can't install kamailio-sipcapture-daemon-config package due to missing dependency (#1861)

[pwakano]

Hi Sergey,
I just tested and now it is installing fine!
Thanks for your time!
Patrick Wakano

```
# yum install kamailio-sipcapture-daemon-config-5.2.1
Loaded plugins: fastestmirror
Loading mirror speeds from cached hostfile
 * base: mirror.ventraip.net.au
 * epel: fedora.mirror.serversaustralia.com.au
 * extras: centos.mirror.serversaustralia.com.au
 * updates: mirror.ventraip.net.au
Resolving Dependencies
--> Running transaction check
---> Package kamailio-sipcapture-daemon-config.x86_64 0:5.2.1-2.el7.centos will 
be installed
--> Finished Dependency Resolution

Dependencies Resolved

=
 Package  Arch  
Version   Repository
Size
=
Installing:
 kamailio-sipcapture-daemon-configx86_64
5.2.1-2.el7.centoshome_kamailio_v5.2.x-rpms 
15 k

Transaction Summary
=
Install  1 Package

Total download size: 15 k
Installed size: 39 k
Is this ok [y/d/N]: y
Downloading packages:
kamailio-sipcapture-daemon-config-5.2.1-2.el7.centos.x86_64.rpm 

  |  15 kB  00:00:02 
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : kamailio-sipcapture-daemon-config-5.2.1-2.el7.centos.x86_64  

 1/1 
  Verifying  : kamailio-sipcapture-daemon-config-5.2.1-2.el7.centos.x86_64  

 1/1 

Installed:
  kamailio-sipcapture-daemon-config.x86_64 0:5.2.1-2.el7.centos 

 

Complete!

```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1861#issuecomment-466273358___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:83a31b81: siputils: fix debug logging

[Ovidiu Sas]

Module: kamailio
Branch: master
Commit: 83a31b81740ac57ca8a82e5e4a9509484e740ae7
URL: 
https://github.com/kamailio/kamailio/commit/83a31b81740ac57ca8a82e5e4a9509484e740ae7

Author: Ovidiu Sas 
Committer: Ovidiu Sas 
Date: 2019-02-21T18:48:55-05:00

siputils: fix debug logging

---

Modified: src/modules/siputils/contact_ops.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/83a31b81740ac57ca8a82e5e4a9509484e740ae7.diff
Patch: 
https://github.com/kamailio/kamailio/commit/83a31b81740ac57ca8a82e5e4a9509484e740ae7.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:14b89ca9: Revert "siputils: fix debug logging"

[Ovidiu Sas]

Module: kamailio
Branch: master
Commit: 14b89ca98fbcd355e822115c126f23cba1649ca2
URL: 
https://github.com/kamailio/kamailio/commit/14b89ca98fbcd355e822115c126f23cba1649ca2

Author: Ovidiu Sas 
Committer: Ovidiu Sas 
Date: 2019-02-21T18:47:34-05:00

Revert "siputils: fix debug logging"

This reverts commit 91b2c5da34ba7064f858b13bf0a1d27da74336d4.

---

Modified: src/modules/siputils/contact_ops.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/14b89ca98fbcd355e822115c126f23cba1649ca2.diff
Patch: 
https://github.com/kamailio/kamailio/commit/14b89ca98fbcd355e822115c126f23cba1649ca2.patch


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] git:master:91b2c5da: siputils: fix debug logging

[Henning Westerholt]

Am Donnerstag, 21. Februar 2019, 14:55:32 CET schrieb Ovidiu Sas:
> After the push I realized that I forgot to update the author. My bad.
> I wanted to revert the commit, but I didn't know if we have a preferred way
> of doing it.
> So, is there a guideline for reverting a commit? I will revert it and
> re-commit with proper credentials.

Hello Ovidiu,

don't worry. Just revert the commit:

$ git revert 91b2c5da

This will create a new commit that revert this one. Then you can commit the 
change again with your credentials, e.g. after applying the diff from the 
first patch set.

This is the safest way to do in this situation, as it was already pushed to 
the public repository. Other ways have more side effects and are usually not 
necessary.

Best regards,

Henning


> On Thu, Feb 21, 2019, 02:51 Henning Westerholt  wrote:
> > Am Mittwoch, 20. Februar 2019, 21:12:07 CET schrieb root:
> > > Module: kamailio
> > > Branch: master
> > > Commit: 91b2c5da34ba7064f858b13bf0a1d27da74336d4
> > 
> > > URL:
> > https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d2
> > 7
> > 
> > > da74336d4
> > > 
> > > Author: root 
> > > Committer: root 
> > > Date: 2019-02-21T07:11:25+11:00
> > > 
> > > siputils: fix debug logging
> > > 
> > > ---
> > > 
> > > Modified: src/modules/siputils/contact_ops.c
> > > 
> > > ---
> > 
> > > Diff:
> > https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d2
> > 7
> > 
> > > da74336d4.diff Patch:
> > https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d2
> > 7
> > 
> > > da74336d4.patch
> > 
> > Hello,
> > 
> > please add a proper User and e-mail address to your local git
> > configuration:
> > 
> > 
> > https://help.github.com/en/articles/setting-your-commit-email-address-in-g
> > it https://help.github.com/en/articles/setting-your-username-in-git
> > 
> > It is necessary to have a proper (human) author for all commits in the
> > public
> > repository. Please reply to this e-mail that we have it in the archives as
> > well.
> > 
> > Otherwise I think we should revert this commit (could be of course applied
> > again).


-- 
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://skalatan.de/services
Kamailio security assessment - https://skalatan.de/de/assessment

___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] developing hiops module (#1856)

[mojtabaesfandiari]

@mojtabaesfandiari pushed 3 commits.

098e307e018e8866e3c7e09fb65c98850e82f3cf  core: move the received_in_via 
function to hiops module
bf31c7db4bfef15d89a24b663f9c05d68fe4a3e5  hiops: change function name
56ab9820cd957bb9af3aa7ebb7b79fdecc80a548  hiops: Add two function to these files


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/kamailio/kamailio/pull/1856/files/64f336d0ed2dca161beadf2892f83849874bba43..56ab9820cd957bb9af3aa7ebb7b79fdecc80a548
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Infinite loop inside htable module during dmq synch (#1863)

[Charles Chance]

Please can you try with the above and confirm whether or not it is fixed?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1863#issuecomment-466135406___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] registrar: memory leak in xavp_rcd (#1834)

[Olle E. Johansson]

That's interesting. So if a device keeps re-registering using the same call ID 
the structure stays open and the xavp's keep hanging to the registration 
structure?  Could that be it? Just a wild guess... We have a short time between 
re-registrations.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1834#issuecomment-466131349___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] registrar: memory leak in xavp_rcd (#1834)

[Daniel-Constantin Mierla]

@lazedo - the core file contains the shared memory, but you need to know where 
to look for xavps. They are linked either in the transaction structure, or 
registrar/location structure, or from global variables, a matter of what it is 
done at the moment of generating the crash.

You can use `abort()` (iirc, from cfgutils module )inside kamailio.cfg to 
trigger a crash at a specific line, so you know what that worker did just 
before crashing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1834#issuecomment-466035674___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Cannot use db_flatstore with siptrace module (#1850)

[Daniel-Constantin Mierla]

Can you try with current master branch or the patch referenced above? If all 
ok, it can be considered for backporting to make it work with write only db 
drivers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1850#issuecomment-466033915___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] git:master:4137bebe: siptrace: check database table version only if db connector supports query

[Daniel-Constantin Mierla]

Module: kamailio
Branch: master
Commit: 4137bebe3193075ab901f1cc9b2f23c34a9fb210
URL: 
https://github.com/kamailio/kamailio/commit/4137bebe3193075ab901f1cc9b2f23c34a9fb210

Author: Daniel-Constantin Mierla 
Committer: Daniel-Constantin Mierla 
Date: 2019-02-21T16:03:41+01:00

siptrace: check database table version only if db connector supports query

- reported by GH #1850

---

Modified: src/modules/siptrace/siptrace.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/4137bebe3193075ab901f1cc9b2f23c34a9fb210.diff
Patch: 
https://github.com/kamailio/kamailio/commit/4137bebe3193075ab901f1cc9b2f23c34a9fb210.patch

---

diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c
index 05a6310f40..bc9c316ce3 100644
--- a/src/modules/siptrace/siptrace.c
+++ b/src/modules/siptrace/siptrace.c
@@ -423,13 +423,15 @@ static int child_init(int rank)
   "configuration.\n");
return -1;
}
-   if(db_check_table_version(
-  _funcs, db_con, _table, 
SIP_TRACE_TABLE_VERSION)
-   < 0) {
-   DB_TABLE_VERSION_ERROR(siptrace_table);
-   db_funcs.close(db_con);
-   db_con = 0;
-   return -1;
+   if(DB_CAPABILITY(db_funcs, DB_CAP_QUERY)) {
+   if(db_check_table_version(
+   _funcs, db_con, _table, 
SIP_TRACE_TABLE_VERSION)
+   < 0) {
+   DB_TABLE_VERSION_ERROR(siptrace_table);
+   db_funcs.close(db_con);
+   db_con = 0;
+   return -1;
+   }
}
}
 


___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.2.0 - Segmentation fault in libcrypto.so.1.1 (#1860)

[Daniel-Constantin Mierla]

Is libcrypto using threads and deals with sockets itself from point of view of 
closing them? Kamailio is multi-process and at a given moment, only one process 
is supposed to write to the socket. Moreover, afaik, writing to a closed socket 
is not causing SIGSEGV.

>From the log messages, it seems an error related to the random number 
>generator from libcrypto.

You should install debugging symbols for libssl/libcrypto and see if you can 
get more details on the related frames from gdb. Last frame related to kamailio 
code is no. 11, the first 0..10 frames point to libss/libcrypto, but those have 
no symbols.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1860#issuecomment-466028508___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Infinite loop inside htable module during dmq synch (#1863)

[Charles Chance]

Thanks for reporting - I will take a look and fix accordingly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1863#issuecomment-466022037___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.2.0 - Segmentation fault in libcrypto.so.1.1 (#1860)

[shaunjstokes]

We've been testing this further.

- The problem doesn't occur when using TCP\UDP with-out making changes to our 
existing configuration.
- If we change 'children' from 16 to 1 then the problem no longer occurs when 
using TLS.

Are there any significant drawbacks setting 'children' to 1? Thus far 
everything appears to be working as expected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1860#issuecomment-466016359___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

[sr-dev] [kamailio/kamailio] Infinite loop inside htable module during dmq synch (#1863)

[Enrico Bandiera]

### Description
When restarting kamailio nodes in our infrastructure we noticed that under 
traffic some nodes started using the 100% of the CPU, with the precious help of 
@giavac we were able to track down the issue to an infinite loop inside the 
htable module when synchronizing somewhat big (60K) htables via dmq

### Troubleshooting

 Reproduction
Have 1 kamailio instance with a 60K+ htable and start a new instance, the first 
instance will try to send the whole table to the new instance and it will enter 
an infinite loop which consumes 100% of the CPU

This is caused by a double call to **ht_dmq_cell_group_flush** which creates a 
circular list on the json structure hierarchy, the second call happens in this 
block of code (hence why it's required a 60K htable):
https://github.com/kamailio/kamailio/blob/5.2/src/modules/htable/ht_dmq.c#L509

When this happens **ht_dmq_cell_group_flush** try to add 
**ht_dmq_jdoc_cell_group.jdoc_cells** inside 
**ht_dmq_jdoc_cell_group.jdoc->root** but this root already has **json_cells** 
as its child
so when **srjson_AddItemToObject** is called (and in turn 
**srjson_AddItemToArray**) it gets appended as the child of itself:
https://github.com/kamailio/kamailio/blob/master/src/lib/srutils/srjson.c#L813

This circular structure then causes a loop when calling 
**srjson_PrintUnformatted** because in the **print_object** function the 
circular list is looped over:
https://github.com/kamailio/kamailio/blob/master/src/lib/srutils/srjson.c#L679

### Possible Solutions

One possible solution could be to destroy and init again the 
**ht_dmq_jdoc_cell_group** structure after calling the flush:
```
if (ht_dmq_jdoc_cell_group.size >= dmq_cell_group_max_size) {
  LM_DBG("sending group count[%d]size[%d]\n", ht_dmq_jdoc_cell_group.count, 
ht_dmq_jdoc_cell_group.size);
  if (ht_dmq_cell_group_flush(node) < 0) {
ht_slot_unlock(ht, i);
goto error;
  }
  ht_dmq_cell_group_destroy();
  ht_dmq_cell_group_init();
}
```
But we are not sure about the performance implications.

### Additional Information
`# kamailio -v
version: kamailio 5.2.1 (x86_64/linux) 44e488
flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, 
DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, 
F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, 
USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, 
BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: 44e488 
compiled on 11:52:58 Feb 21 2019 with gcc 5.4.0
`

* **Operating System**:
ubuntu:xenial docker container
`# uname -a
Linux kama-0 4.4.0-135-generic #161-Ubuntu SMP Mon Aug 27 10:45:01 UTC 2018 
x86_64 x86_64 x86_64 GNU/Linux`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1863___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] git:master:91b2c5da: siputils: fix debug logging

[Ovidiu Sas]

Hello Henning,

After the push I realized that I forgot to update the author. My bad.
I wanted to revert the commit, but I didn't know if we have a preferred way
of doing it.
So, is there a guideline for reverting a commit? I will revert it and
re-commit with proper credentials.

Thanks,
Ovidiu

On Thu, Feb 21, 2019, 02:51 Henning Westerholt  wrote:

> Am Mittwoch, 20. Februar 2019, 21:12:07 CET schrieb root:
> > Module: kamailio
> > Branch: master
> > Commit: 91b2c5da34ba7064f858b13bf0a1d27da74336d4
> > URL:
> >
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> > da74336d4
> >
> > Author: root 
> > Committer: root 
> > Date: 2019-02-21T07:11:25+11:00
> >
> > siputils: fix debug logging
> >
> > ---
> >
> > Modified: src/modules/siputils/contact_ops.c
> >
> > ---
> >
> > Diff:
> >
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> > da74336d4.diff Patch:
> >
> https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27
> > da74336d4.patch
>
> Hello,
>
> please add a proper User and e-mail address to your local git
> configuration:
>
>
> https://help.github.com/en/articles/setting-your-commit-email-address-in-git
> https://help.github.com/en/articles/setting-your-username-in-git
>
> It is necessary to have a proper (human) author for all commits in the
> public
> repository. Please reply to this e-mail that we have it in the archives as
> well.
>
> Otherwise I think we should revert this commit (could be of course applied
> again).
>
> Best regards,
>
> Henning
>
> --
> Henning Westerholt - https://skalatan.de/blog/
> Kamailio services - https://skalatan.de/services
> Kamailio security assessment - https://skalatan.de/de/assessment
>
> ___
> Kamailio (SER) - Development Mailing List
> sr-dev@lists.kamailio.org
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
>
___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] SIPTrace trace_mode=1 does not respect hep_capture_id (#1838)

[Blake McKeeby]

Closed #1838.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1838#event-2154975496___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] SIPTrace trace_mode=1 does not respect hep_capture_id (#1838)

[Blake McKeeby]

Hey @miconda, 

Thanks for looking into this. I verified using hep wireshark dissector that 
siptrace module was sending capture-id properly. Turns out it was on the 
sipcapture side. Updated capture side to solve. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1838#issuecomment-466001828___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] developing hiops module (#1856)

[mojtabaesfandiari]

I updated and now the codes is available for hiops module.
In Regards of  new function in core, I will do that.


On Wed, Feb 20, 2019 at 2:15 PM Daniel-Constantin Mierla <
notificati...@github.com> wrote:

> There is no code for your module, it seems you try to add it as a git
> submodule. It has to be pushed with full code, if you want it to merge it
> inside kamailio repository.
>
> Then your commit messages do not follow the contributing guidelines:
>
>-
>
> https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format
>
> I also suggest that you put the function you added in core to your module,
> it seems to target usage only there and there is no reason it doesn't work
> having it inside your module. If it needs to be used in other modules
> later, it can be relocated.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
> 
> .
>


-- 
--Mojtaba Esfandiari.S


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1856#issuecomment-465940688___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Re: [sr-dev] [kamailio/kamailio] Kamailio 5.2.0 - Segmentation fault in libcrypto.so.1.1 (#1860)

[shaunjstokes]

I've looked at similar situations, apparently this can be caused by 
multi-threaded programming, accessing the socket on different threads at the 
same time. The solution is to make sure you're not writing to it on one thread 
and closing it on another but I'm at a loss as to how to check this in Kamailio.

Does anyone have any suggestions?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1860#issuecomment-465925284___
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev