[sr-dev] Re: [kamailio/kamailio] Kamailio crash with DMQ!? (Issue #3905)

[Olle E. Johansson via sr-dev]

> The developer of that part (which was developed by SER project during 
> 2005-2008, when Kamailio was separate project, then inherited it as part of 
> SIP-Router project merging) is no longer active. The design is rather 
> complex, without much documentation, but the code is available and you can 
> try to understand and fix issues that you find there. Or ask for a refund :-) 
> ...

If not even @miconda wants to touch or fix the code, maybe we should consider 
deprecating it. At least remove it from the sample configuration as a start.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3905#issuecomment-2258555354
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Contribute with AUR package

[Olle E. Johansson via sr-dev]

> On 27 Jul 2024, at 03:16, Nikos Toutountzoglou via sr-dev 
>  wrote:
> 
> Dear Sirs,
> 
> I have adopted an orphaned AUR package and tried to fine tune it to be used 
> with Your great Kamailio open source project.
> I can continue to maintain it in the AUR space. If anything needs to be 
> modified in the package please let me know.
> 
> Link to the package:
> https://aur.archlinux.org/packages/kamailio
> 
> or web search !aur kamailio
> 
> Regards,
> Nikos

Thank you Nikos!

Stay on the mailing list and try to follow changes to the Debian and Red Hat 
packages so that you can stay up to date. Please don’t hesitate to ask 
questions, we’re all interested in having Kamailio distributed in many places.

Regards,
/Olle


___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: git:master:61660322: core: new udp receiver mode - one multi-threaded process

[Olle E. Johansson via sr-dev]

> On 4 May 2024, at 20:19, Daniel-Constantin Mierla via sr-dev 
>  wrote:
> 
> core: new udp receiver mode - one multi-threaded  process
> 
> - activated with udp_receiver_mode=1
> - one process is created that starts one receiver thread per UDP socket
> - SIP messages are pushed to "udp" async tasks group
> - sending is still done by any of processes

Wow. That sounds like a huge improvement. Thanks for documenting this in the 
commit. 

Can you elaborate a bit more on what you think are the main advantages of this 
compared with the current behaviour with many processes handling incoming UDP? 
Any special situation where the new multithreaded architecture is better?

Cheers,
/O___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Olle E. Johansson via sr-dev]

I'm good. Good work!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#issuecomment-2042552775
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> +/**
+ *
+ */
+static int w_ptr_query(sip_msg_t *msg, char *ip, char *pv_name)
+{
+   str ip_address;
+   str name;
+
+   if(msg == NULL) {
+   LM_ERR("received null msg\n");
+   return -1;
+   }
+
+   if(fixup_get_svalue(msg, (gparam_t *)ip, _address) < 0) {
+   LM_ERR("cannot get the IP address\n");
+   return -1;

Seems like you have reasons for multiple return values, so go ahead.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#discussion_r1553359630
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> @@ -883,6 +883,57 @@ if(dns_query("test.com", "xyz"))
 
 
 
+
+  
+ptr_query(ip, pvid)
+  
+
+  
+ Store the hostname that correspond to ip
+ in a config variable $ptrquery(pvid=>hostname).

You are right. But it doesn't make it more correct... :-) 

xkaraman - you decide if you want to improve the docs or keep it at the current 
state.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#discussion_r1549218619
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.

You're doing good. Just a few small nits after reading it again.

> @@ -883,6 +883,57 @@ if(dns_query("test.com", "xyz"))
 
 
 
+
+  
+ptr_query(ip, pvid)
+  
+
+  
+ Store the hostname that correspond to ip

s/ip/an IP address/

Also document if you support both IPv4 and IPv6 clearly. Thanks!

> @@ -883,6 +883,57 @@ if(dns_query("test.com", "xyz"))
 
 
 
+
+  
+ptr_query(ip, pvid)
+  
+
+  
+ Store the hostname that correspond to ip
+ in a config variable $ptrquery(pvid=>hostname).

You mean a "pseudo variable" not a config variable.

> +  
+ptr_query(ip, pvid)
+  
+
+  
+ Store the hostname that correspond to ip
+ in a config variable $ptrquery(pvid=>hostname).
+  
+
+  Parameters:
+
+  
+
+  
+ ip - string or pseudo-variable 
containing the ip.
+ The resulting IP addresses from DNS query are 
compared with ipaddr.

In line 901 you just say "ip" and here "ipaddr". I suggest you write clear text 
on both cases. Like "containing the IP address" and "compared with the IP 
address"

> +   Store the hostname that correspond to ip
+ in a config variable $ptrquery(pvid=>hostname).
+  
+
+  Parameters:
+
+  
+
+  
+ ip - string or pseudo-variable 
containing the ip.
+ The resulting IP addresses from DNS query are 
compared with ipaddr.
+  
+
+
+  
+pvid - container id for script variable.

I don't think we call a pseudo variable a "container" anywhere. If so, I 
consider it a bug :-)



> @@ -418,6 +413,91 @@ int dns_update_pv(str *hostname, str *name)
return 1;
 }
 
+/*
+*

Add a comment here 

> @@ -24,13 +24,46 @@
 #define _IPOPS_PV_H_
 
 #include "../../core/pvar.h"
+#define PV_DNS_ADDR 64
+#define PV_DNS_RECS 32
+#define SR_DNS_PVIDX 1
+
+typedef struct _sr_dns_record
+{
+   int type;
+   char addr[PV_DNS_ADDR];
+} sr_dns_record_t;
+typedef struct _sr_dns_item

Empty line missing

> +/**
+ *
+ */
+static int w_ptr_query(sip_msg_t *msg, char *ip, char *pv_name)
+{
+   str ip_address;
+   str name;
+
+   if(msg == NULL) {
+   LM_ERR("received null msg\n");
+   return -1;
+   }
+
+   if(fixup_get_svalue(msg, (gparam_t *)ip, _address) < 0) {
+   LM_ERR("cannot get the IP address\n");
+   return -1;

Depends if you think there's any point of separating the various errors from 
each other in the script of if it doesn't matter - the coder just want to know 
that it failed, not caring about how. There are several functions in other 
modules, like TM, that has multiple return values. It's really up to you, just 
a suggestion that you consider this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#pullrequestreview-1975734865
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> +/**
+ *
+ */
+static int w_ptr_query(sip_msg_t *msg, char *ip, char *pv_name)
+{
+   str ip_address;
+   str name;
+
+   if(msg == NULL) {
+   LM_ERR("received null msg\n");
+   return -1;
+   }
+
+   if(fixup_get_svalue(msg, (gparam_t *)ip, _address) < 0) {
+   LM_ERR("cannot get the IP address\n");
+   return -1;

Just thinking loud - any reason you want different returns in different 
situations in your scripts? All errors return exactly the same value here.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#pullrequestreview-1974138167
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PTR query support (PR #3802)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> @@ -1292,6 +1297,31 @@ static int ki_dns_query(sip_msg_t *msg, str 
> *naptrname, str *pvid)
return dns_update_pv(naptrname, pvid);
 }
 
+/**
+ *

There is room for a description of the function here - that's why we have 
comments before functions.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#pullrequestreview-1974134325
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] ipops: Add PRT query support (PR #3802)

[Olle E. Johansson via sr-dev]

The topic contains a spelling error - you mean PTR and not PRT :-)

Please add documentation as well

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3802#issuecomment-2032283974
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tls: OpenSSL 3/1.1.1 is using shared ERR_STATE in all workers (Issue #3695)

[Olle E. Johansson via sr-dev]

I have mentioned this before as an issue and it was a driving factor behind 
creating the API to the curl module. Having multiple modules using Curl that 
initiates OpenSSL (or non-curl modules initiating OpenSSL) will lead to 
problems. I remember that Kevin Fleming while working with Asterisk wrote a 
wrapper library that initialised OpenSSL once only for all modules. I have no 
idea if that still exists, but if it does, it could be an inspiration.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3695#issuecomment-1876836964
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Hi, could you provide me with a .cfg demo for using SEMS as Announcements in the IMS module? (Issue #3662)

[Olle E. Johansson via sr-dev]

Closed #3662 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3662#event-11135406391
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Hi, could you provide me with a .cfg demo for using SEMS as Announcements in the IMS module? (Issue #3662)

[Olle E. Johansson via sr-dev]

The issue tracker is for issues - not for general questions and asking for 
help. Please join our mailing lists and ask there.

Thank you!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3662#issuecomment-1838024428
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] Dialog DMQ sync: Timer needs fixing, firing on wrong node! (Issue #3656)

[Olle E. Johansson via sr-dev]

Maybe we can add a setting in the dialog module for

- ignoring the timeout on the DMQ peer (receiver)
- adding a value on the DMQ peer so the primary server triggers first.

/O

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3656#issuecomment-1824654839
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: New Module For Kamailio (RTSP)

[Olle E. Johansson via sr-dev]

> On 24 Oct 2023, at 09:40, Mojtaba  wrote:
> 
> The SIP user agent can register in the same Kamailio which is support RTSP 
> module
> 
That’s thte SIP user agent client. Where do you run the SIP user agent SERVER?

/O
> 
> On Tue, Oct 24, 2023 at 11:00 AM Olle E. Johansson  > wrote:
>> Where do you run the SIP user agent?
>> 
>> /O
>> 
>>> On 24 Oct 2023, at 09:25, Mojtaba >> > wrote:
>>> 
>>> Absolutely yes, it has a built-in engine called "RTSPEngine" for media 
>>> management, moreover, it can work with other modules in Kamailio like 
>>> LRKProxy, RTPEngine or RTPProxy. 
>>> The main decision to use the internal engine in this module is to avoid 
>>> having multiple connections to each camera at the same time. Suppose two 
>>> different agents want to check the specific camera on their phone stations. 
>>> In this situation, the RTSP module initiates one connection to the camera. 
>>> After that, the RTP streams come to the RTSPEngine and then will be sent to 
>>> all agents.
>>> I am looking forward to hearing  more ideas.
>>> Thanks
>>> 
>>> On Mon, Oct 23, 2023 at 3:35 PM Olle E. Johansson >> > wrote:
 
 
 > On 23 Oct 2023, at 11:13, Mojtaba via sr-dev >>> > > wrote:
 > 
 > Hi All,
 >  I'm going to release a new module that I've been developing, Real Time 
 > Streaming is a protocol to connect to camera devices to record video.
 > Using this module, you can connect to all kinds of cameras and map them 
 > to internal numbers. When you call these numbers, the recorded video 
 > will appear on your video call station and change between cameras by 
 > DTMF. 
 > In addition, This module is used for video surveillance solutions.
 > Please let me know your ideas on this. I am looking forward to hearing 
 > new ideas in this regard.
 
 It sounds like a great application that many need. But I am curious on how 
 you see this as a Kamailio module, as
 kamailio does not handle media. Or do you have a server like RTPengine 
 that you control from Kamailio somehow?
 
 /O
>>> 
>>> 
>>> -- 
>>> --Mojtaba Esfandiari.S
>> 
> 
> 
> -- 
> --Mojtaba Esfandiari.S

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: New Module For Kamailio (RTSP)

[Olle E. Johansson via sr-dev]

Where do you run the SIP user agent?

/O

> On 24 Oct 2023, at 09:25, Mojtaba  wrote:
> 
> Absolutely yes, it has a built-in engine called "RTSPEngine" for media 
> management, moreover, it can work with other modules in Kamailio like 
> LRKProxy, RTPEngine or RTPProxy. 
> The main decision to use the internal engine in this module is to avoid 
> having multiple connections to each camera at the same time. Suppose two 
> different agents want to check the specific camera on their phone stations. 
> In this situation, the RTSP module initiates one connection to the camera. 
> After that, the RTP streams come to the RTSPEngine and then will be sent to 
> all agents.
> I am looking forward to hearing  more ideas.
> Thanks
> 
> On Mon, Oct 23, 2023 at 3:35 PM Olle E. Johansson  > wrote:
>> 
>> 
>> > On 23 Oct 2023, at 11:13, Mojtaba via sr-dev > > > wrote:
>> > 
>> > Hi All,
>> >  I'm going to release a new module that I've been developing, Real Time 
>> > Streaming is a protocol to connect to camera devices to record video.
>> > Using this module, you can connect to all kinds of cameras and map them to 
>> > internal numbers. When you call these numbers, the recorded video will 
>> > appear on your video call station and change between cameras by DTMF. 
>> > In addition, This module is used for video surveillance solutions.
>> > Please let me know your ideas on this. I am looking forward to hearing new 
>> > ideas in this regard.
>> 
>> It sounds like a great application that many need. But I am curious on how 
>> you see this as a Kamailio module, as
>> kamailio does not handle media. Or do you have a server like RTPengine that 
>> you control from Kamailio somehow?
>> 
>> /O
> 
> 
> -- 
> --Mojtaba Esfandiari.S

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: New Module For Kamailio (RTSP)

[Olle E. Johansson via sr-dev]

> On 23 Oct 2023, at 11:13, Mojtaba via sr-dev  
> wrote:
> 
> Hi All,
>  I'm going to release a new module that I've been developing, Real Time 
> Streaming is a protocol to connect to camera devices to record video.
> Using this module, you can connect to all kinds of cameras and map them to 
> internal numbers. When you call these numbers, the recorded video will appear 
> on your video call station and change between cameras by DTMF. 
> In addition, This module is used for video surveillance solutions.
> Please let me know your ideas on this. I am looking forward to hearing new 
> ideas in this regard.

It sounds like a great application that many need. But I am curious on how you 
see this as a Kamailio module, as
kamailio does not handle media. Or do you have a server like RTPengine that you 
control from Kamailio somehow?

/O
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] http_client: Add parameter connect_timeout_ms / timeout_ms (2) (PR #3611)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000)



-   Default value is zero, i.e.,
-   the timeout function is disabled.
+   Default value is 4.

Ouch, that seems like something that needs to be addressed, but in another PR. 
I think this PR should be focused and not have that change, even if it's small. 
Open an issue with the text you just wrote and attack it in a separate PR 
closing that issue. Thanks for pointing this out!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3611#discussion_r1368268457
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] http_client: Add parameter connect_timeout_ms / timeout_ms (2) (PR #3611)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> @@ -187,15 +187,35 @@ modparam("http_client", "maxdatasize", 2000)



-   Default value is zero, i.e.,
-   the timeout function is disabled.
+   Default value is 4.

Can you explain this change?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3611#pullrequestreview-1691808459
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] http_client: Add parameter connect_timeout_ms / timeout_ms (PR #3609)

[Olle E. Johansson via sr-dev]

I think we need two config options - but they set the same variable internally 
and only call ONE curl interface - the one you add here. We need also to verify 
the http_client API if we need to add something there. Having two variables 
internally is just overhead.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3609#issuecomment-1772753418
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Kamailio module http_client - setting timeout in ms - new parameter ?

[Olle E. Johansson via sr-dev]

> On 19 Oct 2023, at 14:02, Chaigneau, Nicolas via sr-dev 
>  wrote:
> 
> Hello Henning,
>  
>  
> Here is a pull request for this :
>  
> https://github.com/kamailio/kamailio/pull/3609
>  
>  
I’ve left some notes.

> Let me know if it’s ok.
> If it can be merged, I would like to backport the changes to 5.7.x branch.  
> (should I also do a pull request for this branch ?)
>  
We do not add new features to old branches. New features are part of new 
releases.

Thank you for contributing to Kamailio!

/O
>  
> Regards,
> Nicolas.
>  
> De : Henning Westerholt mailto:h...@gilawa.com>> 
> Envoyé : mardi 17 octobre 2023 19:23
> À : Kamailio (SER) - Development Mailing List
> Cc : Chaigneau, Nicolas
> Objet : RE: Kamailio module http_client - setting timeout in ms - new 
> parameter ?
>  
> Hello Nicolas,
>  
> sounds good, an additional parameter while keeping the existing functionality 
> for the existing timeout would work.
>  
> Just create a pull request, then developers can review it and maybe some 
> smaller adjustments could be done before a merge.
>  
> Thanks,
>  
> Henning
>  
> -- 
> Henning Westerholt – https://skalatan.de/blog/
> Kamailio services – https://gilawa.com 
>  
> From: Chaigneau, Nicolas via sr-dev  > 
> Sent: Dienstag, 17. Oktober 2023 18:11
> To: Kamailio (SER) - Development Mailing List  >
> Cc: Chaigneau, Nicolas  >
> Subject: [sr-dev] Kamailio module http_client - setting timeout in ms - new 
> parameter ?
>  
> Hello,
>  
>  
> I would like to set a timeout in milliseconds when using Kamailio module 
> http_client.
> From what I read, the module is accepting a parameter “connection_timeout”:
>  
> https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_client.p.connection_timeout
>  
> This is used to set curl option “CURLOPT_TIMEOUT”.
> I would like to set instead curl option “CURLOPT_TIMEOUT_MS”.
>  
> I think changing the parameter “connection_timeout” from seconds to 
> milliseconds is not a good idea, since it would break existing configurations.
> What about adding a new parameter “connection_timeout_ms” to the module ?
>  
> Curl documentation says that: “If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS 
> are set, the value set last is used.”
> The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so 
> that the current behaviour is kept if the new parameter is not configured.
>  
>  
> What do you think ?
>  
>  
> Regards,
> Nicolas.
> This message contains information that may be privileged or confidential and 
> is the property of the Capgemini Group. It is intended only for the person to 
> whom it is addressed. If you are not the intended recipient, you are not 
> authorized to read, print, retain, copy, disseminate, distribute, or use this 
> message or any part thereof. If you receive this message in error, please 
> notify the sender immediately and delete all copies of this message. 
> ___
> Kamailio (SER) - Development Mailing List
> To unsubscribe send an email to sr-dev-le...@lists.kamailio.org 
> 
___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] http_client: Add parameter connect_timeout_ms / timeout_ms (PR #3609)

[Olle E. Johansson via sr-dev]

Thank you for contributing. I would prefer if there's only one variable and 
that we use the milliseconds always internally and just keep the old setting 
for backwards compatibility.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3609#issuecomment-1771114732
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tools: route_graph - added README file (PR #3604)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> @@ -0,0 +1,16 @@
+This Python script, route_graph.py, serves as a utility tool for visualizing 
Kamailio SIP server configuration files. 
+It generates a graphical representation of the routing logic defined in the 
configuration. 
+
+Usage:
+1. Clone the GitHub repository:
+git clone https://github.com/kamailio/kamailio.git
+2. Navigate to the tool's directory:
+cd kamailio/misc/tools/route_graph/
+3. Run the script on your Kamailio configuration file:
+python3 route_graph.py /path/to/kamailio.cfg
+
+For a more detailed walkthrough, please refer to this article: 
+Visualizing Kamailio Configuration File Using Route Graph Tool.
+http://voipnuggets.com/2023/06/13/visualizing-kamailio-configuration-file-using-route_graph-tool/

Thanks for fixing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3604#discussion_r1363329301
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: [kamailio/kamailio] tools: route_graph - added README file (PR #3604)

[Olle E. Johansson via sr-dev]

@oej commented on this pull request.



> @@ -0,0 +1,16 @@
+This Python script, route_graph.py, serves as a utility tool for visualizing 
Kamailio SIP server configuration files. 
+It generates a graphical representation of the routing logic defined in the 
configuration. 
+
+Usage:
+1. Clone the GitHub repository:
+git clone https://github.com/kamailio/kamailio.git
+2. Navigate to the tool's directory:
+cd kamailio/misc/tools/route_graph/
+3. Run the script on your Kamailio configuration file:
+python3 route_graph.py /path/to/kamailio.cfg
+
+For a more detailed walkthrough, please refer to this article: 
+Visualizing Kamailio Configuration File Using Route Graph Tool.
+http://voipnuggets.com/2023/06/13/visualizing-kamailio-configuration-file-using-route_graph-tool/

Time to get HTTPS:// - certificates are free.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3604#pullrequestreview-1684189285
You are receiving this because you are subscribed to this thread.

Message ID: ___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: Kamailio module http_client - setting timeout in ms - new parameter ?

[Olle E. Johansson via sr-dev]

> On 17 Oct 2023, at 18:11, Chaigneau, Nicolas via sr-dev 
>  wrote:
> 
> Hello,
>  
>  
> I would like to set a timeout in milliseconds when using Kamailio module 
> http_client.
> From what I read, the module is accepting a parameter “connection_timeout”:
>  
> https://www.kamailio.org/docs/modules/devel/modules/http_client.html#http_client.p.connection_timeout
>  
> This is used to set curl option “CURLOPT_TIMEOUT”.
> I would like to set instead curl option “CURLOPT_TIMEOUT_MS”.
>  
> I think changing the parameter “connection_timeout” from seconds to 
> milliseconds is not a good idea, since it would break existing configurations.
> What about adding a new parameter “connection_timeout_ms” to the module ?
>  
> Curl documentation says that: “If both CURLOPT_TIMEOUT and CURLOPT_TIMEOUT_MS 
> are set, the value set last is used.”
> The CURLOPT_TIMEOUT_MS should only be set if the parameter is non-zero, so 
> that the current behaviour is kept if the new parameter is not configured.
>  
>  
> What do you think ?
>  
>  
It is propably a good idea. Looking forward to a patch. :-)

Cheers,
/O___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: git:master:8f3d76e9: corex: rpc command to print shm status report to file based on filter

[Olle E. Johansson via sr-dev]

> On 9 Oct 2023, at 15:45, Daniel-Constantin Mierla  wrote:
> 
> The execution of rpc commands has to be protected/firewalled anyhow, there 
> are commands that can kill kamailio or old commands that write to file (e.g, 
> dlg.dump_file). Also, the rpc over fifo writes to a file the response. The 
> rpc interface was designed to be used only by trusted apps, being them 
> restricted by firewal or OS permissions.
> 
I tried to avoid opening the old can of worms, more question if it’s a good 
thing to continue down that path without protections.
You are right, there are a lot of bad things one can do, so maybe we have to 
live with it. At some point maybe
add a light level of authorization.
> For more flexibility in setting "I want to be able to ..." rules, of course 
> contributions are more than welcome.
> 
As always!

…which is one of the reasons I’m dropping the ideas on the mailing list for 
everyone to consider… :-)

/O
> Cheers,
> Daniel
> 
> 
> 
> On 09.10.23 14:40, Olle E. Johansson via sr-dev wrote:
>> 
>> 
>>> On 9 Oct 2023, at 14:08, Daniel-Constantin Mierla via sr-dev 
>>>  <mailto:sr-dev@lists.kamailio.org> wrote:
>>> 
>>> corex: rpc command to print shm status report to file based on filter
>> 
>> How do we restrict this? I find it kind of scary that an external app can 
>> force kamailio to write
>> to files in the file system. 
>> 
>> - I want to be able to disable it in modparam
>> - I want to be able to restrict the directory Kamailio can write in
>> - I want to be able to restrict sizes
>> 
>> /O
>> 
>> 
>> ___
>> Kamailio (SER) - Development Mailing List
>> To unsubscribe send an email to sr-dev-le...@lists.kamailio.org 
>> <mailto:sr-dev-le...@lists.kamailio.org>
> -- 
> Daniel-Constantin Mierla (@ asipto.com)
> twitter.com/miconda -- linkedin.com/in/miconda
> Kamailio Consultancy and Development Services
> Kamailio Advanced Training - Online - Nov 14-16, 2023 -- asipto.com

___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

[sr-dev] Re: git:master:8f3d76e9: corex: rpc command to print shm status report to file based on filter

[Olle E. Johansson via sr-dev]

> On 9 Oct 2023, at 14:08, Daniel-Constantin Mierla via sr-dev 
>  wrote:
> 
> corex: rpc command to print shm status report to file based on filter

How do we restrict this? I find it kind of scary that an external app can force 
kamailio to write
to files in the file system. 

- I want to be able to disable it in modparam
- I want to be able to restrict the directory Kamailio can write in
- I want to be able to restrict sizes

/O___
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org