[SSSD] [sssd PR#820][comment] ad: delete domains disabled through ad_enabled_domains from cache
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
> Perhaps `ad_subdomains.c:193`? All other interactions with the list that I
> foud is case insensitive.
>
> ```c
> is_ad_in_domains = false;
> for (int i = 0; i < count; i++) {
> is_ad_in_domains += strcmp(ad_domain, domains[i]) == 0 ? true : false;
> }
> ```
>
> I don't have a test environment handy, would you mind trying it out?
Yes, that did the trick, good catch. Can you include this into your patchset?
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/820#issuecomment-519996331
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#863][comment] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863 Title: #863: ci: add Debian 10 jhrozek commented: """ Hi @pbrezina I would prefer if @alexey-tikhonov could check the valgrind errors, because he was already looking into them. Honestly they seem a bit too much like a black check :-) maybe Alexey would know how to make them more specific to the location of the error. Anyway, great job. One step closer to retiring the old CI :-) """ See the full comment at https://github.com/SSSD/sssd/pull/863#issuecomment-519933107 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] Re: Removing nscd from Fedora
Hi folks, On 8/8/19 9:09 PM, Florian Weimer wrote: We'd like to propose removing nscd from Fedora, for Fedora 32. (The goal is to make this change downstream, too.) I am using nscd for caching hosts lookups, even if sssd is installed. Is sssd capable of taking over this part? Regards Harri ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#863][opened] ci: add Debian 10
URL: https://github.com/SSSD/sssd/pull/863
Author: pbrezina
Title: #863: ci: add Debian 10
Action: opened
PR body:
"""
None
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/863/head:pr863
git checkout pr863
From ea86a77e35f657a3b1eb4b51706606223eaa8664 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Fri, 9 Aug 2019 10:43:01 +0200
Subject: [PATCH 1/2] ci: suppress Debian valgrind errors
This is a known issue id Debian version of OpenSSL.
---
contrib/ci/sssd.supp | 47
1 file changed, 47 insertions(+)
diff --git a/contrib/ci/sssd.supp b/contrib/ci/sssd.supp
index 4b279666b4..52ad0a66fd 100644
--- a/contrib/ci/sssd.supp
+++ b/contrib/ci/sssd.supp
@@ -236,3 +236,50 @@
...
fun:main
}
+
+{
+ debian-openssl-issue
+ Memcheck:Cond
+ ...
+ fun:s3crypt_gen_salt
+ ...
+}
+
+{
+ debian-openssl-issue
+ Memcheck:Value8
+ ...
+ fun:s3crypt_gen_salt
+ ...
+}
+
+{
+ debian-openssl-issue
+ Memcheck:Cond
+ ...
+ fun:sss_password_encrypt
+ ...
+}
+
+{
+ debian-openssl-issue
+ Memcheck:Value8
+ ...
+ fun:sss_password_encrypt
+ ...
+}
+
+{
+ debian-openssl-issue
+ Memcheck:Cond
+ ...
+ fun:sss_decrypt
+ ...
+}
+
+{
+ debian-openssl-issue
+ Memcheck:Cond
+ fun:test_sss_encrypt_decrypt
+ ...
+}
From a3cbab8bb50f426134d64bab705f815ebbb41efc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Fri, 9 Aug 2019 12:49:58 +0200
Subject: [PATCH 2/2] ci: add Debian 10
---
Jenkinsfile | 9 +
1 file changed, 9 insertions(+)
diff --git a/Jenkinsfile b/Jenkinsfile
index 2ebfe52ece..a90da8bb15 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -255,6 +255,15 @@ pipeline {
aborted { CI_Aborted() }
}
}
+stage('Test on Debian 10') {
+ agent {label "sssd-ci"}
+ environment { TEST_SYSTEM = "debian10" }
+ steps { CI_RunTests() }
+ post {
+always { CI_Post() }
+aborted { CI_Aborted() }
+ }
+}
}
}
}
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#820][comment] ad: delete domains disabled through ad_enabled_domains from cache
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
Perhaps `ad_subdomains.c:193`? All other interactions with the list that I foud
is case insensitive.
```c
is_ad_in_domains = false;
for (int i = 0; i < count; i++) {
is_ad_in_domains += strcmp(ad_domain, domains[i]) == 0 ? true : false;
}
```
I don't have a test environment handy, would you mind trying it out?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/820#issuecomment-519833290
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
