RE: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device
Hi Ben, > 3.2-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Avinash Patil > > commit bbea3bc432dc5c08d09ca5c80afdd82515470688 upstream. This patch is not for stable kernel. Thanks, Bing > > replace single queue function calls with equivalent multiple queue > functions. Wakeup queue and stop queue calls are guarded by spin lock. > > Signed-off-by: Avinash Patil > Signed-off-by: Kiran Divekar > Signed-off-by: Bing Zhao > Signed-off-by: John W. Linville > Signed-off-by: Ben Hutchings > --- > drivers/net/wireless/mwifiex/init.c | 40 > ++ > drivers/net/wireless/mwifiex/main.c | 11 > drivers/net/wireless/mwifiex/main.h |9 +++ > drivers/net/wireless/mwifiex/sta_event.c |6 ++--- > drivers/net/wireless/mwifiex/sta_ioctl.c |4 +-- > drivers/net/wireless/mwifiex/txrx.c |5 ++-- > 6 files changed, 63 insertions(+), 12 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device
On Mon, 2013-02-04 at 11:43 -0800, Bing Zhao wrote: > Hi Ben, > > > 3.2-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Avinash Patil > > > > commit bbea3bc432dc5c08d09ca5c80afdd82515470688 upstream. > > This patch is not for stable kernel. [...] Right, I've managed to pick up 3 changes to mwifiex that it looks like I shouldn't have included. Firstly: 9c969d8ccb1e mwifiex: check wait_event_interruptible return value This had "3.6+" to the left of , whereas I expect version qualifiers to be on the right. So my import script just put this in the queue without asking me to interpret the version qualifier. (I don't automate *that* because people use too wide a variety of syntaxes.) When trying to apply that, I found that it seemed to depend on these two: bbea3bc432dc mwifiex: wakeup and stop multiple tx queues in net_device b7097eb75fa1 mwifiex: handle association failure case correctly which also looked like they were important fixes. Presumably I should drop all of those? Ben. -- Ben Hutchings Everything should be made as simple as possible, but not simpler. - Albert Einstein signature.asc Description: This is a digitally signed message part
RE: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device
Hi Ben, > On Mon, 2013-02-04 at 11:43 -0800, Bing Zhao wrote: > > Hi Ben, > > > > > 3.2-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > -- > > > > > > From: Avinash Patil > > > > > > commit bbea3bc432dc5c08d09ca5c80afdd82515470688 upstream. > > > > This patch is not for stable kernel. > [...] > > Right, I've managed to pick up 3 changes to mwifiex that it looks like I > shouldn't have included. Firstly: > > 9c969d8ccb1e mwifiex: check wait_event_interruptible return value > > This had "3.6+" to the left of , whereas I > expect version qualifiers to be on the right. So my import script just > put this in the queue without asking me to interpret the version > qualifier. (I don't automate *that* because people use too wide a > variety of syntaxes.) Sorry. From now on I will put version qualifiers on the right side of > > When trying to apply that, I found that it seemed to depend on these > two: > > bbea3bc432dc mwifiex: wakeup and stop multiple tx queues in net_device I'd rather classify this patch as an enhancement because the code change is relatively large. To play it safe, let's drop this patch from -stable. > b7097eb75fa1 mwifiex: handle association failure case correctly This is a bug fix indeed. > > which also looked like they were important fixes. Presumably I should > drop all of those? Please drop bbea3bc432dc only. I can resend a backport of "b7097eb75fa1 mwifiex: handle association failure case correctly" for 3.2-stable. Thanks, Bing
RE: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device
Hi Ben,
> > Right, I've managed to pick up 3 changes to mwifiex that it looks like I
> > shouldn't have included. Firstly:
> >
> > 9c969d8ccb1e mwifiex: check wait_event_interruptible return value
> >
> > This had "3.6+" to the left of , whereas I
> > expect version qualifiers to be on the right. So my import script just
> > put this in the queue without asking me to interpret the version
> > qualifier. (I don't automate *that* because people use too wide a
> > variety of syntaxes.)
>
> Sorry. From now on I will put version qualifiers on the right side of
>
I forgot to mention that the upstream patch "9c969d8ccb1e mwifiex: check
wait_event_interruptible return value" is also needed for 3.2-stable, and your
backport patch [016/128] is correct.
The reason I put "3.6+" instead of "3.2+" for stable is that the upstream patch
cannot apply cleanly against kernel versions older than 3.6. It must be back
ported.
Thanks,
Bing
N�r��yb�X��ǧv�^�){.n�+��z)w* jg��� �ݢj/���z�ޖ��2�ޙ&�)ߡ�a���� �G���h��j:+v���w��٥
Re: [ 014/128] mwifiex: wakeup and stop multiple tx queues in net_device
On Mon, 2013-02-04 at 16:36 -0800, Bing Zhao wrote: > Hi Ben, > > > On Mon, 2013-02-04 at 11:43 -0800, Bing Zhao wrote: > > > Hi Ben, > > > > > > > 3.2-stable review patch. If anyone has any objections, please let me > > > > know. > > > > > > > > -- > > > > > > > > From: Avinash Patil > > > > > > > > commit bbea3bc432dc5c08d09ca5c80afdd82515470688 upstream. > > > > > > This patch is not for stable kernel. > > [...] > > > > Right, I've managed to pick up 3 changes to mwifiex that it looks like I > > shouldn't have included. Firstly: > > > > 9c969d8ccb1e mwifiex: check wait_event_interruptible return value > > > > This had "3.6+" to the left of , whereas I > > expect version qualifiers to be on the right. So my import script just > > put this in the queue without asking me to interpret the version > > qualifier. (I don't automate *that* because people use too wide a > > variety of syntaxes.) > > Sorry. From now on I will put version qualifiers on the right side of > > > > > > When trying to apply that, I found that it seemed to depend on these > > two: > > > > bbea3bc432dc mwifiex: wakeup and stop multiple tx queues in net_device > > I'd rather classify this patch as an enhancement because the code change is > relatively large. > To play it safe, let's drop this patch from -stable. > > > b7097eb75fa1 mwifiex: handle association failure case correctly > > This is a bug fix indeed. > > > > > which also looked like they were important fixes. Presumably I should > > drop all of those? > > Please drop bbea3bc432dc only. > > I can resend a backport of "b7097eb75fa1 mwifiex: handle association failure > case correctly" for 3.2-stable. Thanks, I've made these two changes. Ben. -- Ben Hutchings Everything should be made as simple as possible, but not simpler. - Albert Einstein signature.asc Description: This is a digitally signed message part
