[jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
[ https://issues.apache.org/jira/browse/STDCXX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov updated STDCXX-459: - Attachment: stdcxx-459.patch The proposed patch attached. time_get::date_order() should return actually date order taken from locale -- Key: STDCXX-459 URL: https://issues.apache.org/jira/browse/STDCXX-459 Project: C++ Standard Library Issue Type: Improvement Components: 22. Localization Affects Versions: 4.1.2, 4.1.3, 4.1.4 Environment: All Reporter: Farid Zaripov Assignee: Farid Zaripov Priority: Minor Fix For: 4.2.1 Attachments: stdcxx-459.patch The current implementation of the time_get::date_order() always returns no_order. It should return date order used by a locale facet (http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg03734.html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
[ https://issues.apache.org/jira/browse/STDCXX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov updated STDCXX-459: - Patch Info: [Patch Available] time_get::date_order() should return actually date order taken from locale -- Key: STDCXX-459 URL: https://issues.apache.org/jira/browse/STDCXX-459 Project: C++ Standard Library Issue Type: Improvement Components: 22. Localization Affects Versions: 4.1.2, 4.1.3, 4.1.4 Environment: All Reporter: Farid Zaripov Assignee: Farid Zaripov Priority: Minor Fix For: 4.2.1 Attachments: stdcxx-459.patch The current implementation of the time_get::date_order() always returns no_order. It should return date order used by a locale facet (http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg03734.html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
RE: [jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
The standard says the following about do_date_order() dateorder do_date_order() const; 1 Returns: An enumeration value indicating the preferred order of components for those date formats that are composed of day, month, and year. 244) Returns no_order if the date format specified by 'x' contains other variable components (e.g. Julian day, week number, week day). 224) This function is intended as a convenience only, for common formats, and may return no_order in valid locales. I think that __rw_get_dateorder() needs to handle unexpected date format specifiers [such as %j, %U, %V, %w] by returning no_order. I also think you might also want to handle %h in there as it is an alias for %b. Might there be a compatibility issue here also? Travis From: Farid Zaripov (JIRA) [mailto:[EMAIL PROTECTED] Farid Zaripov updated STDCXX-459: - Attachment: stdcxx-459.patch The proposed patch attached. time_get::date_order() should return actually date order taken from locale --- Key: STDCXX-459 URL: https://issues.apache.org/jira/browse/STDCXX-459 Project: C++ Standard Library Issue Type: Improvement Components: 22. Localization Affects Versions: 4.1.2, 4.1.3, 4.1.4 Environment: All Reporter: Farid Zaripov Assignee: Farid Zaripov Priority: Minor Fix For: 4.2.1 Attachments: stdcxx-459.patch
RE: [jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
-Original Message- From: Travis Vitek [mailto:[EMAIL PROTECTED] Sent: Thursday, November 29, 2007 7:35 PM To: stdcxx-dev@incubator.apache.org Subject: RE: [jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale The standard says the following about do_date_order() dateorder do_date_order() const; 1 Returns: An enumeration value indicating the preferred order of components for those date formats that are composed of day, month, and year. 244) Returns no_order if the date format specified by 'x' contains other variable components (e.g. Julian day, week number, week day). 224) This function is intended as a convenience only, for common formats, and may return no_order in valid locales. Thank's for the comment. I've forget to look into standard. :( I think that __rw_get_dateorder() needs to handle unexpected date format specifiers [such as %j, %U, %V, %w] by returning no_order. Yes. I think replacing case '\0': with default: will be enough? I also think you might also want to handle %h in there as it is an alias for %b. Might there be a compatibility issue here also? If the compiler doesn't optimizes the virtual call of the do_date_order(), the proposed patch, I think, is forward and backward source and binary compatible because the time_get::do_date_order() will be defined in the library binary file. There might be a functional incompatibility if the user's code want's the only no_order values, but receive the value other than no_order. Farid.
[jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
[ https://issues.apache.org/jira/browse/STDCXX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov updated STDCXX-459: - Attachment: (was: stdcxx-459.patch) time_get::date_order() should return actually date order taken from locale -- Key: STDCXX-459 URL: https://issues.apache.org/jira/browse/STDCXX-459 Project: C++ Standard Library Issue Type: Improvement Components: 22. Localization Affects Versions: 4.1.2, 4.1.3, 4.1.4 Environment: All Reporter: Farid Zaripov Assignee: Farid Zaripov Priority: Minor Fix For: 4.2.1 Attachments: stdcxx-459.patch The current implementation of the time_get::date_order() always returns no_order. It should return date order used by a locale facet (http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg03734.html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (STDCXX-459) time_get::date_order() should return actually date order taken from locale
[ https://issues.apache.org/jira/browse/STDCXX-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farid Zaripov updated STDCXX-459: - Fix Version/s: 4.2.1 Affects Version/s: 4.1.3 4.1.4 time_get::date_order() should return actually date order taken from locale -- Key: STDCXX-459 URL: https://issues.apache.org/jira/browse/STDCXX-459 Project: C++ Standard Library Issue Type: Improvement Components: 22. Localization Affects Versions: 4.1.2, 4.1.3, 4.1.4 Environment: All Reporter: Farid Zaripov Priority: Minor Fix For: 4.2.1 The current implementation of the time_get::date_order() always returns no_order. It should return date order used by a locale facet (http://www.mail-archive.com/stdcxx-dev@incubator.apache.org/msg03734.html). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
