DO NOT REPLY [Bug 5683] - Struts Javadoc URL incompatible with ant javadoc link option

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5683

Struts Javadoc URL incompatible with ant javadoc link option

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 05:36 ---
This has been fixed for the JavaDocs for the current version (1.0.2), which can
be found at "http://jakarta.apache.org/struts/doc-1.0.2/api"; (and this directory
*does* include the "package-list" file).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5707] - Local forwards to point to Global Forwards

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5707

Local forwards to point to Global Forwards

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 05:32 ---
The current implementation is actually more useful than this ... when you call
mapping.findForward(), it looks first at the local forwards and then (if not
found) looks at the global forwards.  Therefore, your action should decide what
it wants to do and ask for a foward by that name -- it's up to the person
setting up struts-config.xml to declare that particular forward name either
globally (because it applies to everyone), locally (because it applies to only
this action), or both places (because most actions can use the default, but this
action needs something different).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5774] - ActionServlet can't use Digester when digester classes are in parent classloader of webapp

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5774

ActionServlet can't use Digester when digester classes are in parent classloader of 
webapp

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 05:28 ---
This has been fixed in the HEAD branch (which will ultimately become Struts
1.1).  Also, it is now possible to put struts.jar in the shared library
directory and Struts will still correctly load things like Action and form bean
classes found in the web application itself.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5902] - Database Connection pooling error

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5902

Database Connection pooling error

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 05:25 ---
My experience with MySQL has been that, when you restart the database for any
reason, any existing connections will experience "Communications link failure".
 The original version of the Struts connection pool (in 1.0) did not have any
mechanism to detect such problems.  Now, however, you can use the "pingQuery"
property of GenericDataSource to define an SQL "SELECT" statement that will be
tried, whenever the pool is asked for a connection, before it is returned to
you.  If the query fails for any reason, the pool will assume that the old
connection no longer works, so it closes that one and creates a new one instead.
 This catches nearly all cases of problems caused by database shutdowns and
restarts, or other similar problems--please try this on your own application.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6085] - Struts not compatible with JDK1.4

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6085

Struts not compatible with JDK1.4

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 05:14 ---
Struts works for me, in internationalized modes, on both Windows and Linux,
under JDK 1.2.2, 1.3 and 1.4.  It sounds like you might be having a problem
specific to your JDK, or to the servlet container you are running on.  Please
reopen this bug with a *specific* reproducible test case if you are still having
problems.

Note:  Until very recently, it was not possible to compile Struts from source
under JDK 1.4, because of changes to the java.sql.Connection interface.  As of
nightly build 20020312 this has been fixed for the Struts 1.1 branch, which
relies on the commons-dbcp connection pool for providing a javax.sql.DataSource
implementation, and therefore delegates the problem of JDK 1.4 compatibility to
that package.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6098] - DefineTag uses setAttribute and causes an exception

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6098

DefineTag uses setAttribute and causes an exception

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 05:07 ---
The real problem was that  accepted null values in the first place,
since this is not allowed by the containers.  This will now cause an exception.

Fixed in nightly build 20020316.  Will be fixed in 1.0.3.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/bean DefineTag.java LocalStrings.properties

[craigmcc]

craigmcc02/03/15 21:07:02

  Modified:src/share/org/apache/struts/taglib/bean Tag:
STRUTS_1_0_BRANCH DefineTag.java
LocalStrings.properties
  Log:
  Port fix for Bugzilla #6098 (null values for ) to 1.0 branch.
  
  PR: Bugzilla #6098
  Submitted by: Bill Wallace 
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.12.2.1  +22 -5 
jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java
  
  Index: DefineTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java,v
  retrieving revision 1.12
  retrieving revision 1.12.2.1
  diff -u -r1.12 -r1.12.2.1
  --- DefineTag.java23 Apr 2001 22:52:20 -  1.12
  +++ DefineTag.java16 Mar 2002 05:07:02 -  1.12.2.1
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java,v 1.12 
2001/04/23 22:52:20 craigmcc Exp $
  - * $Revision: 1.12 $
  - * $Date: 2001/04/23 22:52:20 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java,v 
1.12.2.1 2002/03/16 05:07:02 craigmcc Exp $
  + * $Revision: 1.12.2.1 $
  + * $Date: 2002/03/16 05:07:02 $
*
* 
*
  @@ -68,6 +68,7 @@
   import javax.servlet.jsp.JspException;
   import javax.servlet.jsp.PageContext;
   import javax.servlet.jsp.tagext.TagSupport;
  +import org.apache.struts.util.MessageResources;
   import org.apache.struts.util.RequestUtils;
   
   
  @@ -76,12 +77,21 @@
* bean property.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.12 $ $Date: 2001/04/23 22:52:20 $
  + * @version $Revision: 1.12.2.1 $ $Date: 2002/03/16 05:07:02 $
*/
   
   public class DefineTag extends TagSupport {
   
   
  +//  Protected variables
  +
  +/**
  + * The message resources for this package.
  + */
  +protected static MessageResources messages =
  +MessageResources.getMessageResources
  +("org.apache.struts.taglib.bean.LocalStrings");
  +
   // - Properties
   
   
  @@ -196,8 +206,15 @@
   
   // Retrieve the required property value
   Object value = this.value;
  -if (value == null)
  +if ((value == null) && (name != null)) {
   value = RequestUtils.lookup(pageContext, name, property, scope);
  +}
  +if (value == null) {
  +JspException e =
  +new JspException(messages.getMessage("define.null"));
  +RequestUtils.saveException(pageContext, e);
  +throw e;
  +}
   
   // Expose this value as a scripting variable
   int inScope = PageContext.PAGE_SCOPE;
  
  
  
  1.12.2.1  +1 -0  
jakarta-struts/src/share/org/apache/struts/taglib/bean/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/LocalStrings.properties,v
  retrieving revision 1.12
  retrieving revision 1.12.2.1
  diff -u -r1.12 -r1.12.2.1
  --- LocalStrings.properties   9 May 2001 19:31:11 -   1.12
  +++ LocalStrings.properties   16 Mar 2002 05:07:02 -  1.12.2.1
  @@ -1,4 +1,5 @@
   cookie.get=No cookie {0} was included in this request
  +define.null=Define tag cannot set a null value
   header.get=No header {0} was included in this request
   include.destination=You must specify exactly one of forward, href, or page
   include.forward=Missing ActionForward entry {0}
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/bean DefineTag.java LocalStrings.properties

[craigmcc]

craigmcc02/03/15 21:04:34

  Modified:src/share/org/apache/struts/taglib/bean DefineTag.java
LocalStrings.properties
  Log:
  Make  throw an exception if it is requested to define
  a null value, since null attribute values are not allowed.
  
  PR: Bugzilla #6098
  Submitted by: Bill Wallace 
  
  Revision  ChangesPath
  1.16  +17 -6 
jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java
  
  Index: DefineTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- DefineTag.java25 Feb 2002 21:02:04 -  1.15
  +++ DefineTag.java16 Mar 2002 05:04:33 -  1.16
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java,v 1.15 
2002/02/25 21:02:04 oalexeev Exp $
  - * $Revision: 1.15 $
  - * $Date: 2002/02/25 21:02:04 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/DefineTag.java,v 1.16 
2002/03/16 05:04:33 craigmcc Exp $
  + * $Revision: 1.16 $
  + * $Date: 2002/03/16 05:04:33 $
*
* 
*
  @@ -77,7 +77,7 @@
* bean property.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.15 $ $Date: 2002/02/25 21:02:04 $
  + * @version $Revision: 1.16 $ $Date: 2002/03/16 05:04:33 $
*/
   
   public class DefineTag extends BodyTagSupport {
  @@ -223,10 +223,21 @@
   
   // Retrieve the required property value
   Object value = this.value;
  -if (value == null && name!=null) 
  +if ((value == null) && (name!=null)) {
   value = RequestUtils.lookup(pageContext, name, property, scope);
  -if (value == null) 
  +}
  +if (value == null) {
   value = bodyContent.getString();
  +if (value != null) {
  +value = ((String) value).trim();
  +}
  +}
  +if (value == null) {
  +JspException e =
  +new JspException(messages.getMessage("define.null"));
  +RequestUtils.saveException(pageContext, e);
  +throw e;
  +}
   
   // Expose this value as a scripting variable
   int inScope = PageContext.PAGE_SCOPE;
  
  
  
  1.17  +2 -1  
jakarta-struts/src/share/org/apache/struts/taglib/bean/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/bean/LocalStrings.properties,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- LocalStrings.properties   25 Feb 2002 20:56:53 -  1.16
  +++ LocalStrings.properties   16 Mar 2002 05:04:33 -  1.17
  @@ -1,4 +1,6 @@
   cookie.get=No cookie {0} was included in this request
  +define.null=Define tag cannot set a null value
  +define.value=Define tag can contain value/name attributes or body.
   header.get=No header {0} was included in this request
   include.destination=You must specify exactly one of forward, href, or page
   include.forward=Missing ActionForward entry {0}
  @@ -17,4 +19,3 @@
   struts.missing=No Struts internal object named {0} is available
   struts.selector=You must specify exactly one of formBean, forward, or mapping
   write.format=Wrong format string: '{0}'
  -define.value=Define tag can contain value/name attributes or body.
  \ No newline at end of file
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6183] - Example variable name confusing

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6183

Example variable name confusing

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 04:45 ---
Fixed in nightly build 20020316.  Will be fixed i 1.0.3.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/doc/userGuide building_controller.xml

[craigmcc]

craigmcc02/03/15 20:44:36

  Modified:doc/userGuide Tag: STRUTS_1_0_BRANCH building_controller.xml
  Log:
  Port the docco fix for Bugzilla #6183.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.1.2.5   +1 -1  jakarta-struts/doc/userGuide/building_controller.xml
  
  Index: building_controller.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/building_controller.xml,v
  retrieving revision 1.1.2.4
  retrieving revision 1.1.2.5
  diff -u -r1.1.2.4 -r1.1.2.5
  --- building_controller.xml   21 Nov 2001 16:12:18 -  1.1.2.4
  +++ building_controller.xml   16 Mar 2002 04:44:36 -  1.1.2.5
  @@ -286,7 +286,7 @@
 
   The "global-forwards" section is used to create logical name 
mappings for commonly used
   jsp pages.  Each of these forwards is available through a call to your 
action mapping instance,
  -i.e. actionMappingInstace.findForward("logicalName").
  +i.e. mapping.findForward("logicalName").
 
 
   As you can see, this mapping matches the path /logon (actually,
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/doc/userGuide building_controller.xml

[craigmcc]

craigmcc02/03/15 20:42:11

  Modified:doc/userGuide building_controller.xml
  Log:
  Change variable name to the one in the standard calling sequence, as
  documented in the JavaDocs.
  
  PR: Bugzilla #6183
  Submitted by: Garard Weathersby 
  
  Revision  ChangesPath
  1.10  +1 -1  jakarta-struts/doc/userGuide/building_controller.xml
  
  Index: building_controller.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/building_controller.xml,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- building_controller.xml   20 Feb 2002 00:41:14 -  1.9
  +++ building_controller.xml   16 Mar 2002 04:42:11 -  1.10
  @@ -286,7 +286,7 @@
 
   The "global-forwards" section is used to create logical name 
mappings for commonly used
   jsp pages.  Each of these forwards is available through a call to your 
action mapping instance,
  -i.e. actionMappingInstace.findForward("logicalName").
  +i.e. mapping.findForward("logicalName").
 
 
   As you can see, this mapping matches the path /logon (actually,
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6217] - org.apache.struts.action.ActionForm properties not well-formed.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6217

org.apache.struts.action.ActionForm properties not well-formed.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6217] - org.apache.struts.action.ActionForm properties not well-formed.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6217

org.apache.struts.action.ActionForm properties not well-formed.





--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 04:12 ---
Fixed in the 20020316 nightly build of commons-beanutils, and therefore in the
20020316 nightly build of Struts as well.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6345] - html.OptionsTag always filters for characters sensitive to HTML

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6345

html.OptionsTag always filters for characters sensitive to HTML

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 04:03 ---
Fixed in nightly build 20020316.  Will be fixed in 1.0.3.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html OptionsTag.java

[craigmcc]

craigmcc02/03/15 20:02:50

  Modified:doc  Tag: STRUTS_1_0_BRANCH struts-html.xml
   src/share/org/apache/struts/taglib/html Tag:
STRUTS_1_0_BRANCH OptionsTag.java
  Log:
  Port new "filter" attribute on  to the 1.0.x branch.
  
  PR: Bugzilla #6345
  Submitted by: Dave Terrian 
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.11.2.10 +11 -0 jakarta-struts/doc/Attic/struts-html.xml
  
  Index: struts-html.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/Attic/struts-html.xml,v
  retrieving revision 1.11.2.9
  retrieving revision 1.11.2.10
  diff -u -r1.11.2.9 -r1.11.2.10
  --- struts-html.xml   6 Feb 2002 05:04:05 -   1.11.2.9
  +++ struts-html.xml   16 Mar 2002 04:02:49 -  1.11.2.10
  @@ -3023,6 +3023,17 @@
   
   
   
  +filter
  +false
  +true
  +
  +Set to false if you do NOT want the option labels
  +filtered for sensitive characters in HTML.  By default, such
  +values are filtered.
  +
  +
  +
  +
   labelName
   false
   true
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.7.2.8   +20 -1 
jakarta-struts/src/share/org/apache/struts/taglib/html/OptionsTag.java
  
  Index: OptionsTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/OptionsTag.java,v
  retrieving revision 1.7.2.7
  retrieving revision 1.7.2.8
  diff -u -r1.7.2.7 -r1.7.2.8
  --- OptionsTag.java   12 Mar 2002 05:46:51 -  1.7.2.7
  +++ OptionsTag.java   16 Mar 2002 04:02:50 -  1.7.2.8
  @@ -111,6 +111,20 @@
   
   
   /**
  + * Should the label values be filtered for HTML sensitive characters?
  + */
  +protected boolean filter = true;
  +
  +public boolean getFilter() {
  +return filter;
  +}
  +
  +public void setFilter(boolean filter) {
  +this.filter = filter;
  +}
  +
  +
  +/**
* The name of the bean containing the labels collection.
*/
   protected String labelName = null;
  @@ -324,6 +338,7 @@
   
super.release();
   collection = null;
  +filter = true;
labelName = null;
labelProperty = null;
name = null;
  @@ -365,7 +380,11 @@
   sb.append("\"");
   }
   sb.append(">");
  -sb.append(ResponseUtils.filter(label));
  +if (filter) {
  +sb.append(ResponseUtils.filter(label));
  +} else {
  +sb.append(label);
  +}
   sb.append("\r\n");
   
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html OptionsTag.java

[craigmcc]

craigmcc02/03/15 20:02:07

  Modified:doc/userGuide struts-html.xml
   src/share/org/apache/struts/taglib/html OptionsTag.java
  Log:
  Add a "filter" attribute to the  tag so that you can turn off
  filtering on option labels.  Defaults to "true" for consistency with the
  previous behavior.
  
  PR: Bugzilla #6345
  Submitted by: Dave Terrian 
  
  Revision  ChangesPath
  1.4   +11 -0 jakarta-struts/doc/userGuide/struts-html.xml
  
  Index: struts-html.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/struts-html.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- struts-html.xml   3 Mar 2002 03:31:13 -   1.3
  +++ struts-html.xml   16 Mar 2002 04:02:07 -  1.4
  @@ -3494,6 +3494,17 @@
   
   
   
  +filter
  +false
  +true
  +
  +Set to false if you do NOT want the option labels
  +filtered for sensitive characters in HTML.  By default, such
  +values are filtered.
  +
  +
  +
  +
   labelName
   false
   true
  
  
  
  1.16  +20 -1 
jakarta-struts/src/share/org/apache/struts/taglib/html/OptionsTag.java
  
  Index: OptionsTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/OptionsTag.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- OptionsTag.java   12 Mar 2002 05:46:08 -  1.15
  +++ OptionsTag.java   16 Mar 2002 04:02:07 -  1.16
  @@ -111,6 +111,20 @@
   
   
   /**
  + * Should the label values be filtered for HTML sensitive characters?
  + */
  +protected boolean filter = true;
  +
  +public boolean getFilter() {
  +return filter;
  +}
  +
  +public void setFilter(boolean filter) {
  +this.filter = filter;
  +}
  +
  +
  +/**
* The name of the bean containing the labels collection.
*/
   protected String labelName = null;
  @@ -324,6 +338,7 @@
   
super.release();
   collection = null;
  +filter = true;
labelName = null;
labelProperty = null;
name = null;
  @@ -365,7 +380,11 @@
   sb.append("\"");
   }
   sb.append(">");
  -sb.append(ResponseUtils.filter(label));
  +if (filter) {
  +sb.append(ResponseUtils.filter(label));
  +} else {
  +sb.append(label);
  +}
   sb.append("\r\n");
   
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6349] - The form Bean is not populated with the request values

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6349

The form Bean is not populated with the request values

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 03:52 ---
Without more details, not much can really be done with this, so I am marking it
WORKSFORME.  If you still have problems, please reopen the bug report and
provide a specific example that we can investigate.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6409] - possible bug in org.apache.struts.taglib.logic.CompareTagBase.condition (int, int)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6409

possible bug in org.apache.struts.taglib.logic.CompareTagBase.condition (int, int)

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 03:07 ---
Fixed in nightly build 20020316.  Will be fixed in 1.0.3.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/web/exercise-taglib logic-compare.jsp

[craigmcc]

craigmcc02/03/15 19:06:42

  Modified:doc  Tag: STRUTS_1_0_BRANCH struts-logic.xml
   src/share/org/apache/struts/taglib/logic Tag:
STRUTS_1_0_BRANCH CompareTagBase.java
   web/exercise-taglib Tag: STRUTS_1_0_BRANCH logic-compare.jsp
  Log:
  Port enhancement to the comparison tags that coerces null variable results
  to a zero-length string before the comparison occurs.
  
  PR: Bugzilla #6409
  Submitted by: Ovidiu Podisor 
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.6.2.4   +2 -2  jakarta-struts/doc/Attic/struts-logic.xml
  
  Index: struts-logic.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/Attic/struts-logic.xml,v
  retrieving revision 1.6.2.3
  retrieving revision 1.6.2.4
  diff -u -r1.6.2.3 -r1.6.2.4
  --- struts-logic.xml  6 Feb 2002 05:04:05 -   1.6.2.3
  +++ struts-logic.xml  16 Mar 2002 03:06:42 -  1.6.2.4
  @@ -33,8 +33,8 @@
 name, parameter, property)
 present on this tag.  It will be converted to the appropriate type
 for the comparison, as determined above.
  -  A request time exception will be thrown if the specified variable
  -  cannot be retrieved, or has a null value.
  +  If the specified variable or property returns null, it will be
  +  coerced to a zero-length string before the comparison occurs.
 The specific comparison for this tag will be performed, and the nested
 body content of this tag will be evaluated if the comparison returns
 a true result.
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.6.2.1   +5 -8  
jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java
  
  Index: CompareTagBase.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java,v
  retrieving revision 1.6
  retrieving revision 1.6.2.1
  diff -u -r1.6 -r1.6.2.1
  --- CompareTagBase.java   12 Feb 2001 21:49:54 -  1.6
  +++ CompareTagBase.java   16 Mar 2002 03:06:42 -  1.6.2.1
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java,v
 1.6 2001/02/12 21:49:54 craigmcc Exp $
  - * $Revision: 1.6 $
  - * $Date: 2001/02/12 21:49:54 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java,v
 1.6.2.1 2002/03/16 03:06:42 craigmcc Exp $
  + * $Revision: 1.6.2.1 $
  + * $Date: 2002/03/16 03:06:42 $
*
* 
*
  @@ -78,7 +78,7 @@
* define values for desired1 and desired2.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.6 $ $Date: 2001/02/12 21:49:54 $
  + * @version $Revision: 1.6.2.1 $ $Date: 2002/03/16 03:06:42 $
*/
   
   public abstract class CompareTagBase extends ConditionalTagBase {
  @@ -253,10 +253,7 @@
   throw e;
   }
   if (variable == null) {
  -JspException e = new JspException
  -(messages.getMessage("logic.variable", value));
  -RequestUtils.saveException(pageContext, e);
  -throw e;
  +variable = "";// Coerce null to a zero-length String
   }
   
   // Perform the appropriate comparison
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.4.2.1   +64 -32jakarta-struts/web/exercise-taglib/logic-compare.jsp
  
  Index: logic-compare.jsp
  ===
  RCS file: /home/cvs/jakarta-struts/web/exercise-taglib/logic-compare.jsp,v
  retrieving revision 1.4
  retrieving revision 1.4.2.1
  diff -u -r1.4 -r1.4.2.1
  --- logic-compare.jsp 4 May 2001 21:49:31 -   1.4
  +++ logic-compare.jsp 16 Mar 2002 03:06:42 -  1.4.2.1
  @@ -390,38 +390,6 @@
   
 
 
  -string / EQ
  -
  -<%= str1 %>
  -equal greaterEqual lessEqual
  -
  -  
  -equal
  -  
  -  
  -greaterEqual
  -  
  -  
  -greaterThan
  -  
  -  
  -lessEqual
  -  
  -  
  -lessThan
  -  
  -  
  -notEqual
  -  
  -
  -  
  -  
   long / EQ
   
   <%= long1 %>
  @@ -614,6 +582,38 @@
   
 
 
  +string / EQ
  +
  +<%= str1 %>
  +equal greaterEqual lessEqual
  +
  +  
  +equal
  +  
  +  
  +greaterEqual
  +  
  +  
  +greaterThan
  +  
  +  
  +lessEqual
  +  
  +  
  +lessThan
  +  
  +  
  +notEqual
  +  
  +
  +  
  +  
   string / GT
   
   <%= str2 %>
  @@ -673,6 +673,38 @@

cvs commit: jakarta-struts/web/exercise-taglib logic-compare.jsp

[craigmcc]

craigmcc02/03/15 19:00:44

  Modified:doc/userGuide struts-logic.xml
   src/share/org/apache/struts/taglib/logic CompareTagBase.java
   web/exercise-taglib logic-compare.jsp
  Log:
  Relax the comparison rules so that a null variable will be coerced to
  a zero-length string before being compared to the specified value.  This
  avoids a lot of cases where  type tags were necessary to
  deal with null values.
  
  This is an upwards-compatible enhancement for 1.0 (the old behavior was to
  throw an exception, so nobody was able to write a page that used null
  properties before), so I'm going to port the change to 1.0.x as well.
  
  PR: Bugzilla #6409
  Submitted by: Ovidiu Podisor 
  
  Revision  ChangesPath
  1.2   +2 -2  jakarta-struts/doc/userGuide/struts-logic.xml
  
  Index: struts-logic.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/userGuide/struts-logic.xml,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- struts-logic.xml  20 Feb 2002 00:41:14 -  1.1
  +++ struts-logic.xml  16 Mar 2002 03:00:44 -  1.2
  @@ -33,8 +33,8 @@
 name, parameter, property)
 present on this tag.  It will be converted to the appropriate type
 for the comparison, as determined above.
  -  A request time exception will be thrown if the specified variable
  -  cannot be retrieved, or has a null value.
  +  If the specified variable or property returns null, it will be
  +  coerced to a zero-length string before the comparison occurs.
 The specific comparison for this tag will be performed, and the nested
 body content of this tag will be evaluated if the comparison returns
 a true result.
  
  
  
  1.8   +5 -8  
jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java
  
  Index: CompareTagBase.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- CompareTagBase.java   16 Jul 2001 00:44:56 -  1.7
  +++ CompareTagBase.java   16 Mar 2002 03:00:44 -  1.8
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java,v
 1.7 2001/07/16 00:44:56 craigmcc Exp $
  - * $Revision: 1.7 $
  - * $Date: 2001/07/16 00:44:56 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/CompareTagBase.java,v
 1.8 2002/03/16 03:00:44 craigmcc Exp $
  + * $Revision: 1.8 $
  + * $Date: 2002/03/16 03:00:44 $
*
* 
*
  @@ -78,7 +78,7 @@
* define values for desired1 and desired2.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.7 $ $Date: 2001/07/16 00:44:56 $
  + * @version $Revision: 1.8 $ $Date: 2002/03/16 03:00:44 $
*/
   
   public abstract class CompareTagBase extends ConditionalTagBase {
  @@ -253,10 +253,7 @@
   throw e;
   }
   if (variable == null) {
  -JspException e = new JspException
  -(messages.getMessage("logic.variable", value));
  -RequestUtils.saveException(pageContext, e);
  -throw e;
  +variable = "";// Coerce null to a zero-length String
   }
   
   // Perform the appropriate comparison
  
  
  
  1.5   +65 -32jakarta-struts/web/exercise-taglib/logic-compare.jsp
  
  Index: logic-compare.jsp
  ===
  RCS file: /home/cvs/jakarta-struts/web/exercise-taglib/logic-compare.jsp,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- logic-compare.jsp 4 May 2001 21:49:31 -   1.4
  +++ logic-compare.jsp 16 Mar 2002 03:00:44 -  1.5
  @@ -390,38 +390,6 @@
   
 
 
  -string / EQ
  -
  -<%= str1 %>
  -equal greaterEqual lessEqual
  -
  -  
  -equal
  -  
  -  
  -greaterEqual
  -  
  -  
  -greaterThan
  -  
  -  
  -lessEqual
  -  
  -  
  -lessThan
  -  
  -  
  -notEqual
  -  
  -
  -  
  -  
   long / EQ
   
   <%= long1 %>
  @@ -614,6 +582,38 @@
   
 
 
  +string / EQ
  +
  +<%= str1 %>
  +equal greaterEqual lessEqual
  +
  +  
  +equal
  +  
  +  
  +greaterEqual
  +  
  +  
  +greaterThan
  +  
  +  
  +lessEqual
  +  
  +  
  +lessThan
  +  
  +  
  +notEqual
  +  
  +
  +  
  +  
   string / GT
   
   <%= str2 %>
  @@ -677,7 +677,40 @@
 
   
 
  +  
  +string / 

DO NOT REPLY [Bug 6562] - Null values and the StringBuffer

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6562

Null values and the StringBuffer

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 02:30 ---
The  tag in particular was recently patched to fix this issue. 
Therefore, I'm going to mark this bug FIXED for now.  If you run into other
cases where a fix is needed, please reopen it -- and, as Martin pointed out, a
specific list of the tags that need to be repaired would be much appreciated.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 6571] - output from html:error is prefixed and suffixed with NULL

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6571

output from html:error is prefixed and suffixed with NULL

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 02:25 ---
As Jan pointed out, you need to have these two values in your application
resources bundle to avoid problems with this tag.  See the Tag Library Reference
for the HTML tags for more information.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 7060] - Incorrect Initialization of Actions in ActionServlet

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7060

Incorrect Initialization of Actions in ActionServlet

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 02:18 ---
Fixed in nightly build 20020316.  Will be fixed in 1.0.3.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/action ActionServlet.java

[craigmcc]

craigmcc02/03/15 18:17:35

  Modified:src/share/org/apache/struts/action Tag: STRUTS_1_0_BRANCH
ActionServlet.java
  Log:
  Port fix for 7060 (double checked locking allocating Action instances)
  to the 1.0 branch.
  
  PR: Bugzilla #7060
  Submitted by: Michael Rimov 
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.68.2.5  +34 -33
jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java
  
  Index: ActionServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java,v
  retrieving revision 1.68.2.4
  retrieving revision 1.68.2.5
  diff -u -r1.68.2.4 -r1.68.2.5
  --- ActionServlet.java7 Oct 2001 04:49:15 -   1.68.2.4
  +++ ActionServlet.java16 Mar 2002 02:17:34 -  1.68.2.5
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java,v 
1.68.2.4 2001/10/07 04:49:15 martinc Exp $
  - * $Revision: 1.68.2.4 $
  - * $Date: 2001/10/07 04:49:15 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java,v 
1.68.2.5 2002/03/16 02:17:34 craigmcc Exp $
  + * $Revision: 1.68.2.5 $
  + * $Date: 2002/03/16 02:17:34 $
*
* 
*
  @@ -231,7 +231,7 @@
* 
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.68.2.4 $ $Date: 2001/10/07 04:49:15 $
  + * @version $Revision: 1.68.2.5 $ $Date: 2002/03/16 02:17:34 $
*/
   
   public class ActionServlet
  @@ -245,7 +245,7 @@
* The set of Action instances that have been created and initialized,
* keyed by the fully qualified Java class name.
*/
  -protected FastHashMap actions = new FastHashMap();
  +protected HashMap actions = new HashMap();
   
   
   /**
  @@ -999,9 +999,7 @@
   protected void initActions() {
   
   synchronized (actions) {
  -actions.setFast(false);
   actions.clear();
  -actions.setFast(true);
   }
   
   }
  @@ -1609,37 +1607,40 @@
   protected Action processActionCreate(ActionMapping mapping,
HttpServletRequest request) {
   
  -// Acquire the Action instance we will be using
  +// Acquire the Action instance we will be using (if there is one)
   String actionClass = mapping.getType();
  -if (debug >= 1)
  +if (debug >= 1) {
   log(" Looking for Action instance for class " + actionClass);
  -Action actionInstance = (Action) actions.get(actionClass);
  -if (actionInstance == null) {
  -synchronized (actions) {
  -if (debug >= 1)
  -log("  Double checking for Action instance already there");
  -// Double check to avoid a race condition
  -actionInstance = (Action) actions.get(actionClass);
  -if (actionInstance != null)
  -return (actionInstance);
  -// Go ahead and create the new Action instance
  -// ASSERT:  This will never ever happen more than once
  -//  for a particular action class name
  -try {
  -if (debug >= 1)
  -log("  Creating new Action instance");
  -Class clazz = Class.forName(actionClass);
  -actionInstance = (Action) clazz.newInstance();
  -actionInstance.setServlet(this);
  -actions.put(actionClass, actionInstance);
  -} catch (Throwable t) {
  -log("Error creating Action instance for path '" +
  -mapping.getPath() + "', class name '" +
  -actionClass + "'", t);
  -return (null);
  +}
  +Action actionInstance = null;
  +synchronized (actions) {
  +
  +// Return any existing Action instance of this class
  +actionInstance = (Action) actions.get(actionClass);
  +if (actionInstance != null) {
  +if (debug >= 2) {
  +log("  Returning existing Action instance");
   }
  +return (actionInstance);
  +}
  +
  +// Create and return a new Action instance
  +if (debug >= 2) {
  +log("  Creating new Action instance");
  +}
  +try {
  +Class clazz = Class.forName(actionClass);
  +actionInstance = (Action) clazz.newInstance();
  +actionInstance.setServlet(this);
  +actions.put(actionClass, actionInstance);
  +} catch (Throwable t

cvs commit: jakarta-struts/src/share/org/apache/struts/action RequestProcessor.java

[craigmcc]

craigmcc02/03/15 18:07:11

  Modified:src/share/org/apache/struts/action RequestProcessor.java
  Log:
  Avoid the use of the "double checked locking" idiom when locating an
  Action instance to use (or creating one if necessary).  Since we're going
  synchronize on the "actions" collection anyway, there is no benefit in using
  a FastHashMap, so go back to a standard HashMap as well.
  
  PR: Bugzilla #7060
  Submitted by: Michael Rimov 
  
  Revision  ChangesPath
  1.8   +23 -21
jakarta-struts/src/share/org/apache/struts/action/RequestProcessor.java
  
  Index: RequestProcessor.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/RequestProcessor.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- RequestProcessor.java 10 Mar 2002 01:23:29 -  1.7
  +++ RequestProcessor.java 16 Mar 2002 02:07:11 -  1.8
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/RequestProcessor.java,v 
1.7 2002/03/10 01:23:29 craigmcc Exp $
  - * $Revision: 1.7 $
  - * $Date: 2002/03/10 01:23:29 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/RequestProcessor.java,v 
1.8 2002/03/16 02:07:11 craigmcc Exp $
  + * $Revision: 1.8 $
  + * $Date: 2002/03/16 02:07:11 $
*
* 
*
  @@ -64,6 +64,7 @@
   
   
   import java.io.IOException;
  +import java.util.HashMap;
   import java.util.Iterator;
   import java.util.Locale;
   import javax.servlet.RequestDispatcher;
  @@ -72,7 +73,6 @@
   import javax.servlet.http.HttpServletRequest;
   import javax.servlet.http.HttpServletResponse;
   import javax.servlet.http.HttpSession;
  -import org.apache.commons.collections.FastHashMap;
   import org.apache.commons.logging.Log;
   import org.apache.commons.logging.LogFactory;
   import org.apache.struts.config.ActionConfig;
  @@ -94,7 +94,7 @@
* interested in changing.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.7 $ $Date: 2002/03/10 01:23:29 $
  + * @version $Revision: 1.8 $ $Date: 2002/03/16 02:07:11 $
* @since Struts 1.1
*/
   
  @@ -127,7 +127,7 @@
* The set of Action instances that have been created and initialized,
* keyed by the fully qualified Java class name of the Action class.
*/
  -protected FastHashMap actions = new FastHashMap();
  +protected HashMap actions = new HashMap();
   
   
   /**
  @@ -181,9 +181,7 @@
  throws ServletException {
   
   synchronized (actions) {
  -actions.setFast(false);
   actions.clear();
  -actions.setFast(true);
   }
   this.servlet = servlet;
   this.appConfig = appConfig;
  @@ -296,21 +294,22 @@
   if (log.isDebugEnabled()) {
   log.debug(" Looking for Action instance for class " + className);
   }
  -Action instance = (Action) actions.get(className);
  -if (instance != null) {
  -if (log.isTraceEnabled()) {
  -log.trace("  Returning existing Action instance of class '" +
  -  className + "'");
  +Action instance = null;
  +synchronized (actions) {
  +
  +// Return any existing Action instance of this class
  +instance = (Action) actions.get(className);
  +if (instance != null) {
  +if (log.isTraceEnabled()) {
  +log.trace("  Returning existing Action instance");
  +}
  +return (instance);
   }
  -return (instance);
  -}
   
  -// Create a new Action instance if necessary
  -if (log.isTraceEnabled()) {
  -log.trace("  Creating new Action instance of class '" +
  -  className + "'");
  -}
  -synchronized (actions) {
  +// Create and return a new Action instance
  +if (log.isTraceEnabled()) {
  +log.trace("  Creating new Action instance");
  +}
   try {
   instance = (Action)
   RequestUtils.applicationInstance(className);
  @@ -325,8 +324,11 @@
 mapping.getPath()));
   return (null);
   }
  +
   }
  +
   return (instance);
  +
   }
   
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 7097] - when bean has null value for PresentTag exception is saved, even though value is cleared

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7097

when bean has null value for PresentTag exception is saved, even though value is 
cleared

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 01:54 ---
Fixed in nightly build 20020316.  Will be fixed in 1.0.3.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/logic PresentTag.java

[craigmcc]

craigmcc02/03/15 17:53:50

  Modified:src/share/org/apache/struts/taglib/logic Tag:
STRUTS_1_0_BRANCH PresentTag.java
  Log:
  Port fix for 7097 ( and  bogus
  exception) to the 1.0 branch.
  
  PR: Bugzilla #7097
  Submitted by: Gidado-Yisa Immanuel 
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.7.2.2   +10 -6 
jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java
  
  Index: PresentTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java,v
  retrieving revision 1.7.2.1
  retrieving revision 1.7.2.2
  diff -u -r1.7.2.1 -r1.7.2.2
  --- PresentTag.java   11 Jun 2001 17:34:40 -  1.7.2.1
  +++ PresentTag.java   16 Mar 2002 01:53:50 -  1.7.2.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java,v 
1.7.2.1 2001/06/11 17:34:40 craigmcc Exp $
  - * $Revision: 1.7.2.1 $
  - * $Date: 2001/06/11 17:34:40 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java,v 
1.7.2.2 2002/03/16 01:53:50 craigmcc Exp $
  + * $Revision: 1.7.2.2 $
  + * $Date: 2002/03/16 01:53:50 $
*
* 
*
  @@ -77,7 +77,7 @@
* is present for this request.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.7.2.1 $ $Date: 2001/06/11 17:34:40 $
  + * @version $Revision: 1.7.2.2 $ $Date: 2002/03/16 01:53:50 $
*/
   
   public class PresentTag extends ConditionalTagBase {
  @@ -135,8 +135,12 @@
   } else if (name != null) {
   Object value = null;
   try {
  -value =
  -RequestUtils.lookup(pageContext, name, property, scope);
  +if (property != null) {
  +value = RequestUtils.lookup(pageContext, name,
  +property, scope);
  +} else {
  +value = RequestUtils.lookup(pageContext, name, scope);
  +}
   } catch (JspException e) {
   value = null;
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/logic PresentTag.java

[craigmcc]

craigmcc02/03/15 17:47:14

  Modified:src/share/org/apache/struts/taglib/logic PresentTag.java
  Log:
  Refine the code used by  and  to not
  introduce a bogus exception (which gets saved as a request attribute) as part
  of determining the presence or absence of a bean.
  
  PR: Bugzilla #7097
  Submitted by: Gidado-Yisa Immanuel 
  
  Revision  ChangesPath
  1.11  +10 -6 
jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java
  
  Index: PresentTag.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- PresentTag.java   20 Jul 2001 23:34:04 -  1.10
  +++ PresentTag.java   16 Mar 2002 01:47:14 -  1.11
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java,v 
1.10 2001/07/20 23:34:04 mschachter Exp $
  - * $Revision: 1.10 $
  - * $Date: 2001/07/20 23:34:04 $
  + * $Header: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/logic/PresentTag.java,v 
1.11 2002/03/16 01:47:14 craigmcc Exp $
  + * $Revision: 1.11 $
  + * $Date: 2002/03/16 01:47:14 $
*
* 
*
  @@ -78,7 +78,7 @@
* is present for this request.
*
* @author Craig R. McClanahan
  - * @version $Revision: 1.10 $ $Date: 2001/07/20 23:34:04 $
  + * @version $Revision: 1.11 $ $Date: 2002/03/16 01:47:14 $
*/
   
   public class PresentTag extends ConditionalTagBase {
  @@ -138,8 +138,12 @@
   } else if (name != null) {
   Object value = null;
   try {
  -value =
  -RequestUtils.lookup(pageContext, name, property, scope);
  +if (property != null) {
  +value = RequestUtils.lookup(pageContext, name,
  +property, scope);
  +} else {
  +value = RequestUtils.lookup(pageContext, name, scope);
  +}
   } catch (JspException e) {
   value = null;
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 7143] - action path with a period (.) is not read correctly

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7143

action path with a period (.) is not read correctly

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||REMIND



--- Additional Comments From [EMAIL PROTECTED]  2002-03-16 01:08 ---
Unfortunately, it does not look feasible to fix this :-(.

The issue is one of backwards compatibility.  In early versions of Struts, the
 tag allowed you to include, or omit, the extension when you are
using extension mapping.  As a result, the existence of a period is ambiguous --
is it part of the action name or is it marking the extension?

I'm going to update the DTD to note that you should not use periods in your
action names.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-struts/conf/share struts-config_1_1.dtd

[craigmcc]

craigmcc02/03/15 17:08:01

  Modified:conf/share struts-config_1_1.dtd
  Log:
  Add a note that you shouldn't use periods in action paths, because they
  are ambiguous.
  
  PR:  Bugzilla #7143
  Submitted by:  Matt Raible <[EMAIL PROTECTED]>
  
  Revision  ChangesPath
  1.15  +4 -1  jakarta-struts/conf/share/struts-config_1_1.dtd
  
  Index: struts-config_1_1.dtd
  ===
  RCS file: /home/cvs/jakarta-struts/conf/share/struts-config_1_1.dtd,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- struts-config_1_1.dtd 12 Mar 2002 04:52:45 -  1.14
  +++ struts-config_1_1.dtd 16 Mar 2002 01:08:01 -  1.15
  @@ -11,7 +11,7 @@
  "-//Apache Software Foundation//DTD Struts Configuration 1.1//EN"
  "http://jakarta.apache.org/struts/dtds/struts-config_1_1.dtd";>
   
  - $Id: struts-config_1_1.dtd,v 1.14 2002/03/12 04:52:45 craigmcc Exp $
  + $Id: struts-config_1_1.dtd,v 1.15 2002/03/16 01:08:01 craigmcc Exp $
   -->
   
   
  @@ -354,6 +354,9 @@
pathThe Application-relative path of the submitted request,
starting with a "/" character, and without the
filename extension if extension mapping is used.
  + NOTE:  Do *not* include a period in your path name,
  + because it will look like a filename extension and
  + cause your Action to not be located.
   
parameter   General purpose configuration parameter that can be used
to pass extra information to the Action selected by this
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: DynaActionForm questions

[Craig R. McClanahan]

On Fri, 15 Mar 2002, Heath Chiavettone wrote:

> Date: Fri, 15 Mar 2002 15:56:42 -0800
> From: Heath Chiavettone <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: 'Struts Developers List' <[EMAIL PROTECTED]>
> Subject: RE: DynaActionForm questions
>
> Hello all,
>
> I'm looking for more information related to this thread.  I can see the
> javadoc for the class, but I can't seem to find any real documentation on
> how to configure things in the struts-config.xml file.  If someone can point
> me to where this information is, I'd appreciate it.
>

It's not heavily covered in the docs yet.  The places I would look first:

* The "lib/struts-config_1_1.dtd" file (the DTD for struts-config.xml
  files) documents the new attributes of the  and nested
   elements).

* The struts-config.xml for the Struts example app uses a dynamic form
  bean for the login form, configured like this:


  
  


Both of these are available in the recent nightly builds (which run from
the HEAD branch).

You might also download the commons-beanutils package (and associated
docs) from the Jakarta web site.  The Javadocs cover some of the general
concepts of programming DynaBeans:

  http://jakarta.apache.org/builds/jakarta-commons/nightly/commons-beanutils/

While you're there, Struts 1.1 will use several other Commons packages as
enhanced features or as replacements for code from org.apache.struts.util
- you might want to grab the packages for the collections, dbcp, digester,
pool, services, and validator packages as well.

> TIA,
> Heath
>

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: DynaActionForm questions

[Heath Chiavettone]

Hello all,

I'm looking for more information related to this thread.  I can see the
javadoc for the class, but I can't seem to find any real documentation on
how to configure things in the struts-config.xml file.  If someone can point
me to where this information is, I'd appreciate it.

TIA,
Heath

-Original Message-
From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] 
Sent: Friday, March 15, 2002 1:20 PM
To: Struts Developers List
Subject: Re: DynaActionForm questions

Hi Bryan,

On 15 Mar 2002, Bryan Field-Elliot wrote:

> Date: 15 Mar 2002 13:33:05 -0700
> From: Bryan Field-Elliot <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: DynaActionForm questions
>
> Hi,
>
> I'm just today getting around to having a peek at the new
> DynaActionForm. I'm slightly confused as to how useful this is, in a
> setting in which you don't know at compile-time what fields you're going
> to need to ask for.
>

Interesting that this has come up twice in the last week.

The current DynaActionForm implementation is indeed aimed at the case
where you know ahead of time which properties you need the bean to
represent, so that you can configure them in the struts-config.xml file.
The basic idea is to avoid the need to create custom ActionForm bean
classes for all the simple cases.

Right now, you would still need to create your own bean if you needed a
custom validate method, but even there we can look at adding declartive
ways to define simple validations (required fields, date formats, and so
on) so that even those don't require any custom Java code.

Since form beans are really part of the view tier in the Struts
implementation of MVC, one of the benefits of this will be that
responsibility for designing and configuring form beans can now be
migrated to the page designer that understands enough XML to code the
appropriate struts-config settings, instead of requiring a Java developer
to do this.  And, since creating form bean classes is pretty boring, the
Java developer gets to stay focused on the fun stuff.

> Let's say for example I'm introspecting a JDBC table for a list of
> columns and types, and want to dynamically build a form for CRUD
> operations on this table. Or, instead of a JDBC table, maybe I want to
> assemble a form out of an XML DTD or Schema.

DynaActionForm doesn't help you do either of these without custom Java
form bean classes.  Of course, neither did the original-style form beans
...

Doing this kind of form creation dynamically, though, is going to require
more than just "DynaDynaActionForm" classes.  You'll also need to figure
out how to decide what field prompts to create, what data types and
formats are valid, and other stuff like that.

>
> I see that I can build an ActionForm class to hold values for this
> table, out of DynaClasses (I'm basically already doing this in the
> Simper project).
>
> Where I'm missing something is, are there new Struts JSP tags for
> building an HTML form out of a DynaActionForm? I don't see them, but
> perhaps I'm missing the obvious.
>

You don't see them because they aren't needed :-)

> If the answer is, "There are no new JSP tags for building HTML forms out
> of DynaActionForms", then I'm wondering just how useful DynaActionForm
> is without it... What's a typical use case for it?
>

The existing Struts tags work fine because they use BeanUtils and
PropertyUtils underneath.  These two classes have been made smart about
the bean object they are manipulating -- if you pass them a DynaBean, they
use the dynamic getters and setters.  Otherwise they use the Java
reflection mechanism as before.

So, you can even change your mind about whether a particular form bean is
a DynaActionForm, or a plain old-style form bean, without affecting your
pages at all -- just change the  declaration and you are all
set.  Pretty slick, huh?  :-)

> Thanks,
>
> Bryan
>

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: DynaActionForm questions

[Bryan Field-Elliot]

Thanks Craig,

On Fri, 2002-03-15 at 14:19, Craig R. McClanahan wrote:
> Pretty slick, huh?  :-)
> 

It is slick indeed. The intended focus could just use a little more
refining (perhaps in the users manual).

If you know what your app needs to ask for, then DynaActionForms are a
new and easier way to express it.

On the other hand, if your application doesn't know what it's going to
be asking for until runtime, then DynaActionForms aren't the complete
solution, although they will probably be part of the solution I
ultimately build.

The two scenarios are pretty different, and the use of the "dyna"
keyword could lead over-eager developers like me to assume something
that isn't there.

Thanks,

Bryan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: DynaActionForm questions

[Craig R. McClanahan]

Hi Bryan,

On 15 Mar 2002, Bryan Field-Elliot wrote:

> Date: 15 Mar 2002 13:33:05 -0700
> From: Bryan Field-Elliot <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: DynaActionForm questions
>
> Hi,
>
> I'm just today getting around to having a peek at the new
> DynaActionForm. I'm slightly confused as to how useful this is, in a
> setting in which you don't know at compile-time what fields you're going
> to need to ask for.
>

Interesting that this has come up twice in the last week.

The current DynaActionForm implementation is indeed aimed at the case
where you know ahead of time which properties you need the bean to
represent, so that you can configure them in the struts-config.xml file.
The basic idea is to avoid the need to create custom ActionForm bean
classes for all the simple cases.

Right now, you would still need to create your own bean if you needed a
custom validate method, but even there we can look at adding declartive
ways to define simple validations (required fields, date formats, and so
on) so that even those don't require any custom Java code.

Since form beans are really part of the view tier in the Struts
implementation of MVC, one of the benefits of this will be that
responsibility for designing and configuring form beans can now be
migrated to the page designer that understands enough XML to code the
appropriate struts-config settings, instead of requiring a Java developer
to do this.  And, since creating form bean classes is pretty boring, the
Java developer gets to stay focused on the fun stuff.

> Let's say for example I'm introspecting a JDBC table for a list of
> columns and types, and want to dynamically build a form for CRUD
> operations on this table. Or, instead of a JDBC table, maybe I want to
> assemble a form out of an XML DTD or Schema.

DynaActionForm doesn't help you do either of these without custom Java
form bean classes.  Of course, neither did the original-style form beans
...

Doing this kind of form creation dynamically, though, is going to require
more than just "DynaDynaActionForm" classes.  You'll also need to figure
out how to decide what field prompts to create, what data types and
formats are valid, and other stuff like that.

>
> I see that I can build an ActionForm class to hold values for this
> table, out of DynaClasses (I'm basically already doing this in the
> Simper project).
>
> Where I'm missing something is, are there new Struts JSP tags for
> building an HTML form out of a DynaActionForm? I don't see them, but
> perhaps I'm missing the obvious.
>

You don't see them because they aren't needed :-)

> If the answer is, "There are no new JSP tags for building HTML forms out
> of DynaActionForms", then I'm wondering just how useful DynaActionForm
> is without it... What's a typical use case for it?
>

The existing Struts tags work fine because they use BeanUtils and
PropertyUtils underneath.  These two classes have been made smart about
the bean object they are manipulating -- if you pass them a DynaBean, they
use the dynamic getters and setters.  Otherwise they use the Java
reflection mechanism as before.

So, you can even change your mind about whether a particular form bean is
a DynaActionForm, or a plain old-style form bean, without affecting your
pages at all -- just change the  declaration and you are all
set.  Pretty slick, huh?  :-)

> Thanks,
>
> Bryan
>

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DynaActionForm questions

[Bryan Field-Elliot]

Hi,

I'm just today getting around to having a peek at the new
DynaActionForm. I'm slightly confused as to how useful this is, in a
setting in which you don't know at compile-time what fields you're going
to need to ask for.

Let's say for example I'm introspecting a JDBC table for a list of
columns and types, and want to dynamically build a form for CRUD
operations on this table. Or, instead of a JDBC table, maybe I want to
assemble a form out of an XML DTD or Schema.

I see that I can build an ActionForm class to hold values for this
table, out of DynaClasses (I'm basically already doing this in the
Simper project).

Where I'm missing something is, are there new Struts JSP tags for
building an HTML form out of a DynaActionForm? I don't see them, but
perhaps I'm missing the obvious.

If the answer is, "There are no new JSP tags for building HTML forms out
of DynaActionForms", then I'm wondering just how useful DynaActionForm
is without it... What's a typical use case for it?

Thanks,

Bryan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 7120] - File obtained from the FormFile interface differs from original file to upload.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7120

File obtained from the FormFile interface differs from original file to upload.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
Summary|File obtained from the  |File obtained from the
   |FormFile interface differs  |FormFile interface differs
   |from original file to   |from original file to
   |upload. |upload.



--- Additional Comments From [EMAIL PROTECTED]  2002-03-15 18:57 ---
I can't reproduce this problem in the 1.1 beta release;
however I did find a bug that happens when there's two CR's and
one LF, so I'll go ahead and try to fix that. I created a test case
for this bug regardless, just so in the future I doesn't pop up either.
It'll be committed some time over the next day or few. Thank you for
the detailed bug report, it was much appreciated.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Link Tag w/ improved javascript/ecma support

[Phase Web and Multimedia]

Greetings,

I don't know if a similar solution has been provided, but, I tweaked the
Link Tag to support the writing of
'javascript:[function_name]([param1,param2,param3...])' to the href
attribute of the final output. Here is a summarization of it's
functionality:

I added the following attributes:

function - This is the name of the javascript function that will be called;

functionName - This is the name of the bean that will provide parameter
values from one of it's properties.

functionProperty - This is a property of a bean that will either provide a
String or an ArrayList to populate the parameters of the function

urlIndex - This allows you to include the url generated by href,forward or
page to be included at a specific place in the funcion's parameters.

There is another class that I wrote that does the actual processing and
preparation of the url. I named it EcmaUtil.  I modeled the computeURL and
computerParam methods of the RequestUtils class when I built the methods for
the EcmaUtil.

The LinkTag class that I wrote extends the BaseHandlerTag under the
org.apache.struts.taglib.html package of struts jar.

I know the code needs a bit of reworking to fit back in to the struts
framework. I stripped out the MessageReources for the most part and removed
some exception handling that will need to be included again.

Anyways, if nobody has done this in the nightly or if it sounds like it
might be of use. Let me know and I will post the code,the tld and an example
of it's usage.

Brandon Goodin
Phase Web and Multimedia
P (406) 862-2245
F (406) 862-0354
[EMAIL PROTECTED]
http://www.phase.ws



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 7154] New: - Consultant addition

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7154

Consultant addition

   Summary: Consultant addition
   Product: Struts
   Version: 1.0.2 Final
  Platform: Other
   URL: http://www.caraveltech.com
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Documentation
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I'd like to add my firm under the list of consultants because we develop 
solutions in Struts. The name is Caravel Technologies. The URL is 
www.caraveltech.com. The contact should be Wellie Chao <[EMAIL PROTECTED]>.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Upload: java.io.IOException: Multipart data doesn't start with boundary

[Russell Caswell]

I am using a redirect instead of a forward to work
around this problem.

Russ
--- Matt Raible <[EMAIL PROTECTED]> wrote:
> I'm trying to do the following:
> 
> Add a new file using an UploadForm and
> UploadAction.add method.  This
> works fine.
> 
> Update the properties of this file using the same
> UploadForm and
> UploadAction.save method. After saving the
> information to the database,
> I leave the form in it's scope (session) and forward
> it to the
> UploadAction.edit method - which retrieves the
> record from the database.
> 
> However, when I forward back to the
> UploadAction.edit (using
> /do/upload?action=Edit), I get the following error:
> 
> Any ideas?
> 
> Matt
> 
> - Root Cause -
> java.io.IOException: Multipart data doesn't start
> with boundary
>   at
>
org.apache.struts.upload.MultipartBoundaryInputStream.readFirstElement(M
> ultipartBoundaryInputStream.java:348)
>   at
>
org.apache.struts.upload.MultipartBoundaryInputStream.setInputStream(Mul
> tipartBoundaryInputStream.java:172)
>   at
>
org.apache.struts.upload.MultipartIterator.parseRequest(MultipartIterato
> r.java:202)
>   at
>
org.apache.struts.upload.MultipartIterator.(MultipartIterator.java
> :171)
>   at
>
org.apache.struts.upload.DiskMultipartRequestHandler.handleRequest(DiskM
> ultipartRequestHandler.java:75)
>   at
>
org.apache.struts.util.RequestUtils.populate(RequestUtils.java:908)
>   at
>
org.apache.struts.action.RequestProcessor.processPopulate(RequestProcess
> or.java:793)
>   at
>
org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:
> 246)
>   at
>
org.apache.struts.action.ActionServlet.process(ActionServlet.java:1109)
>   at
>
org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:470)
>   at
>
javax.servlet.http.HttpServlet.service(HttpServlet.java:760)
>   at
>
javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
>   at
>
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatc
> her.java:679)
>   at
>
org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDisp
> atcher.java:431)
>   at
>
org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispat
> cher.java:355)
>   at
>
org.apache.struts.tiles.TilesRequestProcessor.doForward(TilesRequestProc
> essor.java:181)
> 
> 
> 
> --
> To unsubscribe, e-mail:  
> 
> For additional commands, e-mail:
> 
> 


__
Do You Yahoo!?
Yahoo! Sports - live college hoops coverage
http://sports.yahoo.com/

--
To unsubscribe, e-mail:   
For additional commands, e-mail: