Implementing canProcess method in RequestDispatcher
I have a servlet 2.3 filter that needs to forward requests based on whether they will be eventually be mapped to an action by struts. Ideally there would be boolean canProcess(HttpServletRequest, String uri) in RequestProcessor, where URI overrides the one in request unless it is null. I do not mind having to subclass RequestProcessor to implement this. That would be made much easier, however, if the default implementation of processMapping did not call response.sendError when no mapping is found. I'd suggest that it just returns null, and the error handling code is moved out into the process() method itself. As it is, I may be able to wrap the response into a dummy object that ignores the sendError call, and try to disable the logging of the error, but that's quite a hack. Thanks, Chris -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10535] New: - DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler'
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10535.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10535
DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler'
Summary: DynaActionForm, BeanUtils.populate, Unknown property
'multipartRequestHandler'
Product: Struts
Version: Nightly Build
Platform: Other
OS/Version: Other
Status: NEW
Severity: Normal
Priority: Other
Component: Utilities
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
When trying to populate a concrete form class from a DynaAction form, I get
the following error:
Exception in copying navForm to cpForm: java.lang.NoSuchMethodException:
Unknown property 'multipartRequestHandler'
code
// populate the courseProgress form
CourseProgressForm cpForm = new CourseProgressForm();
DynaActionForm navForm = (DynaActionForm)session.getAttribute
(Constants.NAVIGATION_KEY);
// Copy the navigationForm's properties to the courseProgressForm
try {
BeanUtils.populate(cpForm, BeanUtils.describe(navForm));
logCat.debug(populated courseProgressForm: + cpForm);
} catch (Exception e) {
logCat.error(Exception in copying navForm to cpForm: + e);
}
/code
I know I can write a workaround, but I'm also interested to know if this will
be possible in the future.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10536] New: - Closing tag is whitespace-sensitive
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10536. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10536 Closing tag is whitespace-sensitive Summary: Closing tag is whitespace-sensitive Product: Struts Version: 1.1 Beta 1 Platform: PC OS/Version: Linux Status: NEW Severity: Normal Priority: Other Component: Custom Tags AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When I close a tag with some added space after the tag name, struts barfs. Example 1 works fine. Example 2 does not. I use the weird spacing to prevent any spaces from being displayed (and thus preventing spacing from messing up my presentation). Struts finds the opening tag just fine, but does not seem to find the closing tag, leading to an error in the parser. Example 1: tr td html:link href=http://www.yahoo.com;Yahoo!/html:link /td /tr Example 2: tr td html:link href=http://www.yahoo.com; Yahoo!/html:link /td /tr -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/src/share/org/apache/struts/action ActionServlet.java
husted 2002/07/07 11:45:18
Modified:src/share/org/apache/struts/action ActionServlet.java
Log:
Change convertHack to convertNull so that we don't have the H-word in the public
API (jeez, this guy is ~such~ a spoil-sport =:0) and also to use a more descriptive
term. Also, after trying it both ways in various contexts (:don't tell my wife:),
change documentation to use term application module for sub-application and
module-relative for application-context. Corresponding changes to other
documentation to follow.
Revision ChangesPath
1.111 +19 -20
jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java
Index: ActionServlet.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java,v
retrieving revision 1.110
retrieving revision 1.111
diff -u -r1.110 -r1.111
--- ActionServlet.java6 Jul 2002 19:11:06 - 1.110
+++ ActionServlet.java7 Jul 2002 18:45:18 - 1.111
@@ -181,18 +181,17 @@
* listrongconfig/strong - Context-relative path to the XML resource
* containing the configuration information for the default application.
* [/WEB-INF/struts-config.xml]./li
- * listrongconfig/foo/strong - Context-relative path to the XML resource
- * containing the configuration information for the sub-application that
- * will be at prefix /foo. This can be repeated as many times as
- * required for multiple sub-applications. (Since Struts 1.1)/li
- * listrongconvertHack/strong - Set to codetrue/code to force form
- * bean population of bean properties that are of Java wrapper class types
- * (such as java.lang.Integer) to set the property to codenull/code,
- * instead of zero, in a manner equivalent to the behavior of Struts 1.0.
+ * listrongconfig/${module}/strong - Context-relative path to the XML resource
+ * containing the configuration information for the application module that
+ * will use the specified prefix (/${module}). This can be repeated as many
+ * times as required for multiple application modules. (Since Struts 1.1)/li
+ * listrongconvertNull/strong - Force simulation of the Struts 1.0 behavior
+ * when populating forms. If set to true, the numeric Java wrapper class types
+ * (like codejava.lang.Integer/code) will default to null (rather than 0).
* (Since Struts 1.1) [false] /li
- * listrongdebug/strong - The debugging detail level for this
- * servlet, which controls how much information is logged. Accepts
- * values 0 (off) and 1 (least serious) through 6 (most serious). [0]/li
+ * listrongdebug/strong - TThe debugging detail level that controls how much
+ * information is logged for this servlet. Accepts values 0 (off) and from
+ * 1 (least serious) through 6 (most serious). [0]/li
* listrongdetail/strong - The debugging detail level for the Digester
* we utilize to process the application configuration files. Accepts
* values 0 (off) and 1 (least serious) through 6 (most serious). [0]/li
@@ -323,7 +322,7 @@
* properties of the Java wrapper class types.
* @since Struts 1.1
*/
-protected boolean convertHack = false;
+protected boolean convertNull = false;
/**
@@ -1115,19 +1114,19 @@
// Backwards compatibility hack for form beans of Java wrapper classes
// Set to true for strict Struts 1.0 compatibility
-value = getServletConfig().getInitParameter(convertHack);
+value = getServletConfig().getInitParameter(convertNull);
if (value != null) {
if (true.equalsIgnoreCase(value) ||
yes.equalsIgnoreCase(value) ||
on.equalsIgnoreCase(value) ||
y.equalsIgnoreCase(value) ||
1.equalsIgnoreCase(value)) {
-convertHack = true;
+convertNull = true;
} else {
-convertHack = false;
+convertNull = false;
}
}
-if (convertHack) {
+if (convertNull) {
ConvertUtils.deregister();
ConvertUtils.register(new BooleanConverter(null), Boolean.class);
ConvertUtils.register(new ByteConverter(null), Byte.class);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/doc newbie.xml
husted 2002/07/07 11:57:50 Modified:doc newbie.xml Log: Add definitions for application modules and module-relative. Revision ChangesPath 1.8 +31 -0 jakarta-struts/doc/newbie.xml Index: newbie.xml === RCS file: /home/cvs/jakarta-struts/doc/newbie.xml,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- newbie.xml15 Jun 2002 12:09:33 - 1.7 +++ newbie.xml7 Jul 2002 18:57:50 - 1.8 @@ -13,6 +13,8 @@ their first project. bFor an in-depth, searchable FAQ, visit our friends at a href=http://www.jguru.com/faq/home.jsp?topic=Struts;JGuru/a./b/p ul +lia href=#modulesWhat is a modular application? What does module-relative mean?/a/li + lia href=#namingWhy are some of the class and element names counter-intuitive?/a/li liWhy is ActionForm a base class rather than an interface?/li @@ -64,6 +66,35 @@ /ul /section + +section href=modules name=What is a modular application? What does module-relative mean? + +p +Since Struts 1.1, the framework supports multiple application modules. All applications have at +least one root, or default, module. Like the root directory in a file system, the default application +has no name. (Or is named with an empty string, depending your viewpoint.) Developing an application +with only a default module is no different from how applications were developed under Struts 1.0. +Since Struts 1.1, you can add additional modules to your application, each of which can have their +own configuration files, messages resources, and so forth. Each module is developed in the same way as +the default module. Applications that were developed as a single module can added to a multiple +module application, and modules can promoted to a standalone application without change. For more +about configuring your application to support multiple modules, see +a href=userGuide/building_controller.html#module_configBuilding Controller Components/a in the +User Guide. +/p + +p +But to answer the question =:0), a modular application is a Struts application that uses more than +one module. Module-relative means that the URI starts at the application-module level, rather than at +the application-context level, or the absolute-URL level. +/p +ul +liAbsolute URL: http://localhost/myApplication/myModule/myAction.do/li +licontext-relative: /myModule/myAction.do/li +limodule-relative: /myAction.do/li +/ul + +/section section href=naming name=Why are some of the class and element names counter-intuitive? p -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/conf/share struts-config_1_1.dtd
husted 2002/07/07 12:00:14
Modified:conf/share struts-config_1_1.dtd
Log:
Update the comments documenting the DTD to enhance consistency and clarity. This is
the first update of two (about half-way through).
Revision ChangesPath
1.24 +155 -130 jakarta-struts/conf/share/struts-config_1_1.dtd
Index: struts-config_1_1.dtd
===
RCS file: /home/cvs/jakarta-struts/conf/share/struts-config_1_1.dtd,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- struts-config_1_1.dtd 6 Jul 2002 01:12:56 - 1.23
+++ struts-config_1_1.dtd 7 Jul 2002 19:00:13 - 1.24
@@ -89,38 +89,41 @@
!ATTLIST struts-config id ID #IMPLIED
-!-- The data-sources element describes a set of JDBC 2.0 Standard Extension
- data source objects which will be configured according to the nested
- data-source elements found inside.
+!-- The data-sources element describes a set of DataSource objects [JDBC 2.0
+ Standard Extension]. The individual DataSource objects are configured through
+ nested data-source elements.
--
-
!ELEMENT data-sources (data-source*)
!ATTLIST data-sources id ID #IMPLIED
-!-- The data-source element describes a JDBC 2.0 Standard Extension data
- source object (that implements javax.sql.DataSource) which will be
- configured according to the properties and nested elements found here,
- and made available as a servlet context attribute (i.e. application
- scope bean). The following attributes are required:
-
- className Implementation subclass of the standard configuration
- bean, if you do not want to use the standard value.
+!-- The data-source element describes a DataSource object [JDBC 2.0 Standard
+ Extension] that will be instantiated, configured, and made available as a
+ servlet context attribute (or application-scope bean). Any object can be
+ specified so long as it implements javax.sql.DataSource and can be
+ configured entirely from JavaBean properties. The following attributes
+ are required:
+
+ className The configuration bean for this DataSource object. If
+ specified, the object must be a subclass of the default
+ configuration bean.
[org.apache.struts.config.DataSourceConfig]
- key Servlet context attribute key under which this data
- source will be stored. Default is the value specified
- by string constant Action.DATA_SOURCE_KEY.
-
- NOTE: The attribute under which this data source is
- actually stored will be the key value suffixed by
- the application prefix for this sub-application
-
- typeFully qualified Java class name of the data source
- implementation class. This class must implement
- javax.sql.DataSource and be configurable totally
- from JavaBeans properties.
- [org.apache.struts.util.GenericDataSource]
+ key Servlet context attribute key under which this data source
+ will be stored. Default is the value specified by string
+ constant defined by Action.DATA_SOURCE_KEY. The application
+ module prefix (if any) is appended to the key
+ (${key}$prefix}).
+ [org.apache.struts.Action.DATA_SOURCE_KEY]
+
+ NOTE: The application module prefix includes the leading
+ slash, so the default datasource for a module named foo is
+ stored under org.apache.struts.action.DATA_SOURCE/foo.
+
+ typeFully qualified Java class name for this data source object.
+ The class must implement DataSource [javax.sql.DataSource],
+ and the object must be configurable entirely from JavaBean
+ properties.
--
!ELEMENT data-source (set-property*)
!ATTLIST data-sourceid ID #IMPLIED
@@ -129,45 +132,45 @@
!ATTLIST data-sourcetype %ClassName; #IMPLIED
-!-- The global-exceptions element configures the global handling of
- exceptions thrown by Actions to mappable resources (identified by
- application-relative URI paths). A global exception handler for a
- particular exception class can be locally overridden by defining an
- exception element with the same type attribute.
+!-- The global-exceptions element describes a set of exceptions that might be
+
Problems running JUnit unit tests
Being a good lad, I'm trying to run the unit tests before I check in, but they're not working for me. The ones that fail all seem to relate to DynaActionForm and friends. Here's an example of what I'm getting: [junit] Testcase: testBeanCreate took 0.17 sec [junit] Caused an ERROR [junit] Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] org.apache.commons.beanutils.ConversionException: Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] at org.apache.struts.action.DynaActionForm.set(DynaActionForm.java:364) [junit] at org.apache.struts.action.DynaActionFormClass.newInstance(DynaActionFormClass .java:234) [junit] at org.apache.struts.action.TestDynaActionForm.setUp(TestDynaActionForm.java:16 5) [junit] at junit.framework.TestCase.runBare(TestCase.java:138) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:131) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:173) [junit] at junit.framework.TestSuite.run(TestSuite.java:168) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRu nner.java:231) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestR unner.java:409) I have the 20020706 nightly BeanUtils (but I've tried with the release version as well). Any ideas on what I don't have, or don't have the right version of? Thanks! -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts STATUS
jholmes 2002/07/07 14:51:55 Modified:.STATUS Log: Add newly submitted bugs to STATUS. Revision ChangesPath 1.2 +8 -2 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- STATUS7 Jul 2002 02:26:12 - 1.1 +++ STATUS7 Jul 2002 21:51:55 - 1.2 @@ -13,12 +13,17 @@ 8487 Serializability issues in ActionServlet/RequestProcessor +Custom Tags: +--- +10534 html:link forward does not add servlet context correctly +10536 Closing tag is whitespace-sensitive + + Example Webapps: --- 9709 Does not work with BEA Weblogic 7.0 - File Upload: --- 7663 FileUpload example throws exception on JBoss 3.0 @@ -42,6 +47,7 @@ Utilities: - 7541 Digester/Commons Logging error with -security +10535 DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler' Validator Framework: -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: cvs commit: jakarta-struts STATUS
On Sun, 7 Jul 2002, James Mitchell wrote: Date: Sun, 7 Jul 2002 01:31:43 -0400 From: James Mitchell [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED], [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: cvs commit: jakarta-struts STATUS I know you are in the middle of a lot of changes in regards to tiles. I just wanted to point out that I was not able to build (ant dist) from cvs unless I comment out the tiles sub targets and documentation. It's impossible to tell whats going on unless you tell us what errors you were getting ... Please ignore this if I am just 'jumping the gun'. Craig -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Implementing canProcess method in RequestDispatcher
On Sun, 7 Jul 2002, Chris Nokleberg wrote: Date: Sun, 7 Jul 2002 09:53:09 -0700 From: Chris Nokleberg [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: Implementing canProcess method in RequestDispatcher I have a servlet 2.3 filter that needs to forward requests based on whether they will be eventually be mapped to an action by struts. One approach to this would be to check the URL of the incoming request against the servlet mapping pattern for the controller servlet -- it's stored as servlet context attribute Action.SERVLET_KEY (org.apache.struts.action.SERVLET_MAPPING). Ideally there would be boolean canProcess(HttpServletRequest, String uri) in RequestProcessor, where URI overrides the one in request unless it is null. I do not mind having to subclass RequestProcessor to implement this. That seems like a perfectly feasible way to deal with this, because it's not the kind of thing that everyone (or nearly everyone) needs. That would be made much easier, however, if the default implementation of processMapping did not call response.sendError when no mapping is found. I'd suggest that it just returns null, and the error handling code is moved out into the process() method itself. Again, that is something you can do in your custom subclass. As it is, I may be able to wrap the response into a dummy object that ignores the sendError call, and try to disable the logging of the error, but that's quite a hack. Thanks, Chris Craig -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5274] - OutOfMemoryError when uploading big files
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5274. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5274 OutOfMemoryError when uploading big files --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 21:57 --- FYI, 4258 (duplicate bug) has a patch attached to it. not sure if it is relevant or not. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5395] - ActionContext class
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5395. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5395 ActionContext class [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 21:59 --- changing priority to enhancement -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10536] - Closing tag is whitespace-sensitive
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10536. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10536 Closing tag is whitespace-sensitive [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 21:59 --- This is not a Struts issue -- it's an issue in the JSP compiler that you are using. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 5518] - Convert HTML Tags to be XHTML-compliant when html:html xhtml=true
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5518. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5518 Convert HTML Tags to be XHTML-compliant when html:html xhtml=true [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Enhancement --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 22:01 --- changing priority to enhancement -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Problems running JUnit unit tests
Do you have a hot off the presses commons-beanutils.jar file? There were some changes that Struts relies on since the last official release. Craig On Sun, 7 Jul 2002, Martin Cooper wrote: Date: Sun, 7 Jul 2002 13:28:47 -0700 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: '[EMAIL PROTECTED]' [EMAIL PROTECTED] Subject: Problems running JUnit unit tests Being a good lad, I'm trying to run the unit tests before I check in, but they're not working for me. The ones that fail all seem to relate to DynaActionForm and friends. Here's an example of what I'm getting: [junit] Testcase: testBeanCreate took 0.17 sec [junit] Caused an ERROR [junit] Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] org.apache.commons.beanutils.ConversionException: Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] at org.apache.struts.action.DynaActionForm.set(DynaActionForm.java:364) [junit] at org.apache.struts.action.DynaActionFormClass.newInstance(DynaActionFormClass .java:234) [junit] at org.apache.struts.action.TestDynaActionForm.setUp(TestDynaActionForm.java:16 5) [junit] at junit.framework.TestCase.runBare(TestCase.java:138) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:131) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:173) [junit] at junit.framework.TestSuite.run(TestSuite.java:168) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRu nner.java:231) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestR unner.java:409) I have the 20020706 nightly BeanUtils (but I've tried with the release version as well). Any ideas on what I don't have, or don't have the right version of? Thanks! -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/conf/share struts-config_1_1.dtd
husted 2002/07/07 15:02:17
Modified:conf/share struts-config_1_1.dtd
Log:
Update the comments documenting the DTD to enhance consistency and clarity. This is
the second and final update of this pass.
Revision ChangesPath
1.25 +246 -223 jakarta-struts/conf/share/struts-config_1_1.dtd
Index: struts-config_1_1.dtd
===
RCS file: /home/cvs/jakarta-struts/conf/share/struts-config_1_1.dtd,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- struts-config_1_1.dtd 7 Jul 2002 19:00:13 - 1.24
+++ struts-config_1_1.dtd 7 Jul 2002 22:02:17 - 1.25
@@ -89,40 +89,40 @@
!ATTLIST struts-config id ID #IMPLIED
-!-- The data-sources element describes a set of DataSource objects [JDBC 2.0
+!-- The data-sources element describes a set of DataSource objects [JDBC 2.0
Standard Extension]. The individual DataSource objects are configured through
- nested data-source elements.
+ nested data-source elements.
--
!ELEMENT data-sources (data-source*)
!ATTLIST data-sources id ID #IMPLIED
-!-- The data-source element describes a DataSource object [JDBC 2.0 Standard
- Extension] that will be instantiated, configured, and made available as a
- servlet context attribute (or application-scope bean). Any object can be
- specified so long as it implements javax.sql.DataSource and can be
- configured entirely from JavaBean properties. The following attributes
+!-- The data-source element describes a DataSource object [JDBC 2.0 Standard
+ Extension] that will be instantiated, configured, and made available as a
+ servlet context attribute (or application-scope bean). Any object can be
+ specified so long as it implements [javax.sql.DataSource] and can be
+ configured entirely from JavaBean properties. The following attributes
are required:
- className The configuration bean for this DataSource object. If
- specified, the object must be a subclass of the default
+ className The configuration bean for this DataSource object. If
+ specified, the object must be a subclass of the default
configuration bean.
- [org.apache.struts.config.DataSourceConfig]
+ [org.apache.struts.config.DataSourceConfig]
- key Servlet context attribute key under which this data source
- will be stored. Default is the value specified by string
+ key Servlet context attribute key under which this data source
+ will be stored. Default is the value specified by string
constant defined by Action.DATA_SOURCE_KEY. The application
- module prefix (if any) is appended to the key
- (${key}$prefix}).
+ module prefix (if any) is appended to the key
+ (${key}$prefix}).
[org.apache.struts.Action.DATA_SOURCE_KEY]
- NOTE: The application module prefix includes the leading
+ NOTE: The application module prefix includes the leading
slash, so the default datasource for a module named foo is
stored under org.apache.struts.action.DATA_SOURCE/foo.
typeFully qualified Java class name for this data source object.
- The class must implement DataSource [javax.sql.DataSource],
- and the object must be configurable entirely from JavaBean
+ The class must implement DataSource [javax.sql.DataSource],
+ and the object must be configurable entirely from JavaBean
properties.
--
!ELEMENT data-source (set-property*)
@@ -132,10 +132,10 @@
!ATTLIST data-sourcetype %ClassName; #IMPLIED
-!-- The global-exceptions element describes a set of exceptions that might be
- thrown by an Action object. The handling of individual exception types is
- configured through nested exception elements. An action element may
- override a global exception handler by registering a local exception handler
+!-- The global-exceptions element describes a set of exceptions that might be
+ thrown by an Action object. The handling of individual exception types is
+ configured through nested exception elements. An action element may
+ override a global exception handler by registering a local exception handler
for the same exception type. Since Struts 1.1.
--
!ELEMENT global-exceptions (exception*)
@@ -147,29
cvs commit: jakarta-struts/doc/userGuide release-notes.xml dev_validator.xml dev_tiles.xml
husted 2002/07/07 15:03:00 Modified:doc/userGuide release-notes.xml dev_validator.xml dev_tiles.xml Log: Routine updates. Revision ChangesPath 1.6 +7 -1 jakarta-struts/doc/userGuide/release-notes.xml Index: release-notes.xml === RCS file: /home/cvs/jakarta-struts/doc/userGuide/release-notes.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- release-notes.xml 5 Jul 2002 15:55:48 - 1.5 +++ release-notes.xml 7 Jul 2002 22:03:00 - 1.6 @@ -275,10 +275,16 @@ liDeprecated (Struts 0.5) configuration file format: Remove support./li liDeprecated (Struts 0.5) methods: Remove from codebase./li /ul +pstrongAdded Config Package/strong/p +ul +liVarious classes to support modular applications/li +/ul pstrongAction Package Changes/strong/p pThe following changes and bug fixes have occurred in the basic controller framework (package codeorg.apache.struts.action/code):/p ul +liActionServlet: Added convertNull parameter to simulate the Struts 1.0 behavior when populating forms. If set to true, the numeric Java wrapper class types (like java.lang.Integer) will default to null (rather than 0)./li +liActionServlet: Added config/$foo parameter and deprecated several others in favor of components in the new config package. /li liActionForms and related classes: now use a StringBuffer when responding a toString request in order to conserve resources./li liLookupDispatchAction: Added standard Action to help select between internationalized buttons./li liActionForm class: Modified to use ActionServletWrapper rather than expose ActionServlet./li @@ -522,7 +528,7 @@ ligetResources()/li liperform/li /ul -pa href=http://jakarta.apache.org/struts/api/org/apache/struts/action/ActionServlet.html;actionActionServlet/a/p +pa href=http://jakarta.apache.org/struts/api/org/apache/struts/action/ActionServlet.html;ActionServlet/a/p ul lifindDataSource/li lifindFormBean/li 1.3 +9 -0 jakarta-struts/doc/userGuide/dev_validator.xml Index: dev_validator.xml === RCS file: /home/cvs/jakarta-struts/doc/userGuide/dev_validator.xml,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- dev_validator.xml 29 Jun 2002 14:12:01 - 1.2 +++ dev_validator.xml 7 Jul 2002 22:03:00 - 1.3 @@ -15,6 +15,15 @@ /section +section href=tiles name=Validator API Guide + +p +A concise +a href=http://jakarta.apache.org/struts/api/org/apache/struts/validator/package-summary.html#package_description;Struts Validator API Guide/a is available to help you get started. +/p + +/section + section href=resources name=Validator Resources pbuValidating Input/u/b by David Winterfeldt and Ted Husted. 1.4 +2 -2 jakarta-struts/doc/userGuide/dev_tiles.xml Index: dev_tiles.xml === RCS file: /home/cvs/jakarta-struts/doc/userGuide/dev_tiles.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- dev_tiles.xml 29 Jun 2002 03:21:02 - 1.3 +++ dev_tiles.xml 7 Jul 2002 22:03:00 - 1.4 @@ -182,8 +182,8 @@ p A concise -a href=http://jakarta.apache.org/struts/api/org/apache/struts/taglib/template/package-summary.html#package_description;Tiles API Guide/a is available to help you get started -with the Tiles framework. [:TODO: Change link to Tiles API Guide when available.] +a href=http://jakarta.apache.org/struts/api/org/apache/struts/taglib/tiles/package-summary.html;Tiles API Guide/a is available to help you get started +with the Tiles framework. [:TODO: change link to #package_description when available.] /p /section -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10501] - Error running struts under JRun 3.1
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10501. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10501 Error running struts under JRun 3.1 [EMAIL PROTECTED] changed: What|Removed |Added Component|Standard Actions|Example --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 22:08 --- changing component -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts STATUS
jholmes 2002/07/07 15:08:53 Modified:.STATUS Log: Added *overlooked* old bugs. Revision ChangesPath 1.3 +5 -1 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- STATUS7 Jul 2002 21:51:55 - 1.2 +++ STATUS7 Jul 2002 22:08:53 - 1.3 @@ -15,6 +15,7 @@ Custom Tags: --- + 1586 The html:form tag generates incorrect focus javascript for radio buttons. 10534 html:link forward does not add servlet context correctly 10536 Closing tag is whitespace-sensitive @@ -22,10 +23,13 @@ Example Webapps: --- 9709 Does not work with BEA Weblogic 7.0 +10501 Error running struts under JRun 3.1 File Upload: --- + 4170 MaxLengthExceeded doesn't stop file upload + 5274 OutOfMemoryError when uploading big files 7663 FileUpload example throws exception on JBoss 3.0 8732 RequestProcessor doesn't uncast the Request properly 9198 First line feed in text parameters lost -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10537] New: - [:TODO:] sections
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10537. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10537 [:TODO:] sections Summary: [:TODO:] sections Product: Struts Version: Nightly Build Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Documentation AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Complete various :TODO: sections in User Guide to document 1.1 additions, including package descriptions (API Guides) for Tiles and Validator. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts STATUS
craigmcc2002/07/07 15:14:11 Modified:.STATUS Log: Remove a bug report resolved as INVALID. Revision ChangesPath 1.4 +1 -2 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- STATUS7 Jul 2002 22:08:53 - 1.3 +++ STATUS7 Jul 2002 22:14:11 - 1.4 @@ -17,7 +17,6 @@ --- 1586 The html:form tag generates incorrect focus javascript for radio buttons. 10534 html:link forward does not add servlet context correctly -10536 Closing tag is whitespace-sensitive Example Webapps: -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10537] - [:TODO:] sections
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10537. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10537 [:TODO:] sections [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 22:14 --- *** Bug 7348 has been marked as a duplicate of this bug. *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts STATUS
husted 2002/07/07 15:18:45 Modified:.STATUS Log: Add omnibus bug for documentation :TODO: Remove Validator documentation as duplicate. Revision ChangesPath 1.5 +6 -2 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- STATUS7 Jul 2002 22:14:11 - 1.4 +++ STATUS7 Jul 2002 22:18:45 - 1.5 @@ -19,6 +19,11 @@ 10534 html:link forward does not add servlet context correctly +Documentation +- +10537 [:TODO:] sections (18) + + Example Webapps: --- 9709 Does not work with BEA Weblogic 7.0 @@ -56,7 +61,6 @@ Validator Framework: --- 7347 Validator contrib directory should be dead - 7348 No Validator Documentation 7351 Validator JavaScript Primitive Validation Error 7352 Struts 1.1 Beta 1 Release incorrectly reference contrib/validator 7353 Validator JavaScript Select Error -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Problems running JUnit unit tests
Sigh. I *thought* I was using 20020706, but it turns out I was actually using the 1.3 release. I need to 'clean' more often... It's working now. -- Martin Cooper -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: Sunday, July 07, 2002 3:02 PM To: Struts Developers List Subject: Re: Problems running JUnit unit tests Do you have a hot off the presses commons-beanutils.jar file? There were some changes that Struts relies on since the last official release. Craig On Sun, 7 Jul 2002, Martin Cooper wrote: Date: Sun, 7 Jul 2002 13:28:47 -0700 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: '[EMAIL PROTECTED]' [EMAIL PROTECTED] Subject: Problems running JUnit unit tests Being a good lad, I'm trying to run the unit tests before I check in, but they're not working for me. The ones that fail all seem to relate to DynaActionForm and friends. Here's an example of what I'm getting: [junit] Testcase: testBeanCreate took 0.17 sec [junit] Caused an ERROR [junit] Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] org.apache.commons.beanutils.ConversionException: Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] at org.apache.struts.action.DynaActionForm.set(DynaActionForm.java:364) [junit] at org.apache.struts.action.DynaActionFormClass.newInstance(DynaA ctionFormClass .java:234) [junit] at org.apache.struts.action.TestDynaActionForm.setUp(TestDynaActi onForm.java:16 5) [junit] at junit.framework.TestCase.runBare(TestCase.java:138) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:131) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:173) [junit] at junit.framework.TestSuite.run(TestSuite.java:168) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.r un(JUnitTestRu nner.java:231) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.m ain(JUnitTestR unner.java:409) I have the 20020706 nightly BeanUtils (but I've tried with the release version as well). Any ideas on what I don't have, or don't have the right version of? Thanks! -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Problems running JUnit unit tests
On Sun, 7 Jul 2002, Martin Cooper wrote: Date: Sun, 7 Jul 2002 15:31:05 -0700 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: Problems running JUnit unit tests Sigh. I *thought* I was using 20020706, but it turns out I was actually using the 1.3 release. I need to 'clean' more often... It's working now. No problem. There will be yet another change requiring tonight's beanutils (to fix 10535), so plan on doing this again tomorrow. -- Martin Cooper Craig -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: Sunday, July 07, 2002 3:02 PM To: Struts Developers List Subject: Re: Problems running JUnit unit tests Do you have a hot off the presses commons-beanutils.jar file? There were some changes that Struts relies on since the last official release. Craig On Sun, 7 Jul 2002, Martin Cooper wrote: Date: Sun, 7 Jul 2002 13:28:47 -0700 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: '[EMAIL PROTECTED]' [EMAIL PROTECTED] Subject: Problems running JUnit unit tests Being a good lad, I'm trying to run the unit tests before I check in, but they're not working for me. The ones that fail all seem to relate to DynaActionForm and friends. Here's an example of what I'm getting: [junit] Testcase: testBeanCreate took 0.17 sec [junit] Caused an ERROR [junit] Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] org.apache.commons.beanutils.ConversionException: Cannot assign value of type 'java.lang.String' to property 'stringArray' of type '[Ljava.lang.String;' [junit] at org.apache.struts.action.DynaActionForm.set(DynaActionForm.java:364) [junit] at org.apache.struts.action.DynaActionFormClass.newInstance(DynaA ctionFormClass .java:234) [junit] at org.apache.struts.action.TestDynaActionForm.setUp(TestDynaActi onForm.java:16 5) [junit] at junit.framework.TestCase.runBare(TestCase.java:138) [junit] at junit.framework.TestResult$1.protect(TestResult.java:106) [junit] at junit.framework.TestResult.runProtected(TestResult.java:124) [junit] at junit.framework.TestResult.run(TestResult.java:109) [junit] at junit.framework.TestCase.run(TestCase.java:131) [junit] at junit.framework.TestSuite.runTest(TestSuite.java:173) [junit] at junit.framework.TestSuite.run(TestSuite.java:168) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.r un(JUnitTestRu nner.java:231) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.m ain(JUnitTestR unner.java:409) I have the 20020706 nightly BeanUtils (but I've tried with the release version as well). Any ideas on what I don't have, or don't have the right version of? Thanks! -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/src/share/org/apache/struts/tiles ActionComponentServlet.java TilesRequestProcessor.java
martinc 2002/07/07 16:15:36
Modified:.STATUS
src/share/org/apache/struts/action RequestProcessor.java
src/share/org/apache/struts/tiles
ActionComponentServlet.java
TilesRequestProcessor.java
Log:
Move the unwrapping of MultipartRequestWrapper to doForward() and
doInclude() to centralise handling of this, rather than having it
scattered through the code. Also updated Tiles to do the same thing.
PR: 8732, 7663
Submitted by: Robby Reinicke, Neal Sanche
Revision ChangesPath
1.6 +1 -3 jakarta-struts/STATUS
Index: STATUS
===
RCS file: /home/cvs/jakarta-struts/STATUS,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- STATUS7 Jul 2002 22:18:45 - 1.5
+++ STATUS7 Jul 2002 23:15:36 - 1.6
@@ -34,8 +34,6 @@
---
4170 MaxLengthExceeded doesn't stop file upload
5274 OutOfMemoryError when uploading big files
- 7663 FileUpload example throws exception on JBoss 3.0
- 8732 RequestProcessor doesn't uncast the Request properly
9198 First line feed in text parameters lost
10388 ServletException: Multipart data doesn't start with boundary
1.14 +13 -22
jakarta-struts/src/share/org/apache/struts/action/RequestProcessor.java
Index: RequestProcessor.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/RequestProcessor.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- RequestProcessor.java 5 Jul 2002 22:09:21 - 1.13
+++ RequestProcessor.java 7 Jul 2002 23:15:36 - 1.14
@@ -392,11 +392,6 @@
return;
}
-//unwrap the multipart request if there is one
-if (request instanceof MultipartRequestWrapper) {
-request = ((MultipartRequestWrapper) request).getRequest();
-}
-
String uri = RequestUtils.forwardURL(request, forward);
if (forward.getRedirect()) {
response.sendRedirect
@@ -529,11 +524,6 @@
return (true);
}
-// Unwrap the multipart request (if any)
-if (request instanceof MultipartRequestWrapper) {
-request = ((MultipartRequestWrapper) request).getRequest();
-}
-
// Construct a request dispatcher for the specified path
String uri = appConfig.getPrefix() + forward;
@@ -568,11 +558,6 @@
return (true);
}
-// Unwrap the multipart request (if any)
-if (request instanceof MultipartRequestWrapper) {
-request = ((MultipartRequestWrapper) request).getRequest();
-}
-
// Construct a request dispatcher for the specified path
String uri = appConfig.getPrefix() + include;
@@ -937,9 +922,6 @@
log.debug( Validation failed, returning to ' + input + ');
}
request.setAttribute(Action.ERROR_KEY, errors);
-if (request instanceof MultipartRequestWrapper) {
-request = ((MultipartRequestWrapper) request).getRequest();
-}
String uri = null;
if (appConfig.getControllerConfig().getInputForward()) {
ForwardConfig forward = mapping.findForward(input);
@@ -964,6 +946,10 @@
HttpServletResponse response)
throws IOException, ServletException
{
+// Unwrap the multipart request, if there is one.
+if (request instanceof MultipartRequestWrapper) {
+request = ((MultipartRequestWrapper) request).getRequest();
+}
RequestDispatcher rd = getServletContext().getRequestDispatcher(uri);
if (rd == null) {
@@ -988,6 +974,11 @@
HttpServletResponse response)
throws IOException, ServletException
{
+// Unwrap the multipart request, if there is one.
+if (request instanceof MultipartRequestWrapper) {
+request = ((MultipartRequestWrapper) request).getRequest();
+}
+
RequestDispatcher rd = getServletContext().getRequestDispatcher(uri);
if (rd == null) {
response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
1.2 +12 -19
jakarta-struts/src/share/org/apache/struts/tiles/ActionComponentServlet.java
Index: ActionComponentServlet.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/tiles/ActionComponentServlet.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
---
DO NOT REPLY [Bug 10535] - DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler'
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10535. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10535 DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler' --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 23:18 --- This is actually an issue in BeanUtils.describe(), which is not currently aware of DynaBeans so it was returning the real JavaBeans properties of the DynaActionForm class. Fixed in nightly build 20020708. You should also note that the BeanUtils.describe() and BeanUtils.populate() methods do object-string and string-object conversions that are probably wasted effort for this use case. You should probably look at using PropertyUtils.describe() and/or PropertyUtils.copyProperties() instead. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10535] - DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler'
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10535. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10535 DynaActionForm, BeanUtils.populate, Unknown property 'multipartRequestHandler' [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7663] - File Upload example throws exception when run in JBoss 3.0
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7663. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7663 File Upload example throws exception when run in JBoss 3.0 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 23:19 --- I believe this is fixed in the 20020708 nightly build. If there is still a problem, please reopen and provide a full stack trace. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html RadioTag.java
husted 2002/07/07 16:27:57
Modified:src/share/org/apache/struts/taglib/html RadioTag.java
Log:
Add idName attribute to RadioTag so that it is easy to use with an iterator.
Revision ChangesPath
1.13 +60 -4
jakarta-struts/src/share/org/apache/struts/taglib/html/RadioTag.java
Index: RadioTag.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/RadioTag.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- RadioTag.java 25 Jun 2002 00:45:41 - 1.12
+++ RadioTag.java 7 Jul 2002 23:27:57 - 1.13
@@ -77,6 +77,7 @@
* Tag for input fields of type radio.
*
* @author Craig R. McClanahan
+ * @author Ted Husted
* @version $Revision$ $Date$
*/
@@ -125,6 +126,20 @@
protected String value = null;
+/**
+ * Name of the bean (in some scope) that will return the
+ * value of the radio tag.
+ * p
+ * If an iterator is used to render a series of radio tags,
+ * this field may be used to specify the name of the bean
+ * exposed by the iterator. In this case, the value attribute is
+ * used as the name of a property on the codeidName/code bean
+ * that returns the value of the radio tag in this iteration.
+ */
+protected String idName = null;
+
+
+
// - Properties
@@ -172,6 +187,32 @@
}
+
+/**
+ * Return the idName.
+ * @since Struts 1.1
+ */
+public String getIdName() {
+
+return (this.idName);
+
+}
+
+
+/**
+ * Set the idName.
+ * @since Struts 1.1
+ *
+ * @param value The new idName
+ */
+public void setIdName(String idName) {
+
+this.idName=idName;
+
+}
+
+
+
// - Public Methods
@@ -190,9 +231,22 @@
throw new JspException
(messages.getMessage(getter.bean, name));
try {
+
current = BeanUtils.getProperty(bean, property);
if (current == null)
current = ;
+
+// @since Struts 1.1
+if (idName != null) {
+Object idBean = pageContext.findAttribute(idName);
+if (idBean == null)
+ throw new JspException
+(messages.getMessage(getter.bean, idName));
+value = BeanUtils.getProperty(idBean, value);
+if (value == null) value = ;
+}
+
+
} catch (IllegalAccessException e) {
throw new JspException
(messages.getMessage(getter.access, property, name));
@@ -205,6 +259,8 @@
throw new JspException
(messages.getMessage(getter.method, property, name));
}
+
+
// Create an appropriate input element based on our parameters
StringBuffer results = new StringBuffer(input type=\radio\);
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/doc/userGuide struts-html.xml
husted 2002/07/07 16:28:54 Modified:doc/userGuide struts-html.xml Log: Add idName attribute to RadioTag so that it is easy to use with an iterator. Revision ChangesPath 1.14 +79 -54jakarta-struts/doc/userGuide/struts-html.xml Index: struts-html.xml === RCS file: /home/cvs/jakarta-struts/doc/userGuide/struts-html.xml,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- struts-html.xml 6 Jul 2002 23:36:29 - 1.13 +++ struts-html.xml 7 Jul 2002 23:28:54 - 1.14 @@ -1289,24 +1289,24 @@ /info /attribute - attribute - nametitle/name - requiredfalse/required - rtexprvaluetrue/rtexprvalue - info - pThe advisory title for this element./p - /info - /attribute - - attribute - nametitleKey/name - requiredfalse/required - rtexprvaluetrue/rtexprvalue - info - pThe message resources key for the advisory title - for this element./p - /info - /attribute +attribute +nametitle/name +requiredfalse/required +rtexprvaluetrue/rtexprvalue +info +pThe advisory title for this element./p +/info +/attribute + +attribute +nametitleKey/name +requiredfalse/required +rtexprvaluetrue/rtexprvalue +info +pThe message resources key for the advisory title +for this element./p +/info +/attribute attribute namevalue/name @@ -1951,24 +1951,24 @@ /info /attribute - attribute - nametitle/name - requiredfalse/required - rtexprvaluetrue/rtexprvalue - info - pThe advisory title for this element./p - /info - /attribute - - attribute - nametitleKey/name - requiredfalse/required - rtexprvaluetrue/rtexprvalue - info - pThe message resources key for the advisory title - for this element./p - /info - /attribute +attribute +nametitle/name +requiredfalse/required +rtexprvaluetrue/rtexprvalue +info +pThe advisory title for this element./p +/info +/attribute + +attribute +nametitleKey/name +requiredfalse/required +rtexprvaluetrue/rtexprvalue +info +pThe message resources key for the advisory title +for this element./p +/info +/attribute attribute namevalue/name @@ -4511,9 +4511,18 @@ /summary tagclassorg.apache.struts.taglib.html.RadioTag/tagclass info +p Renders an HTML lt;inputgt; element of type radio, populated from the specified property of the bean associated with our current form. This tag is only valid when nested inside a form tag body. +/p +p +If an iterator is used to render a series of radio tags, the +idName attribute may be used to specify the name of the bean +exposed by the iterator. In this case, the value attribute is +used as the name of a property on the idName bean that returns +the value of the radio tag in this iteration. +/p /info @@ -4745,6 +4754,22 @@ /info /attribute +attribute +nameidName/name +requiredfalse/required +rtexprvaluetrue/rtexprvalue +info +Name of the bean (in some scope) that will return the +value of the radio tag. Usually exposed +by an iterator. When the idName attribute is +present, the valueattribute is used as the name of the +property on the idName bean that will return the +value of the radio tag for this iteration. +Since Struts 1.1. +/info +/attribute + + /tag @@ -5487,24 +5512,24 @@
cvs commit: jakarta-struts/src/test/org/apache/struts/util TestRequestUtils.java
craigmcc2002/07/07 16:45:21
Modified:src/share/org/apache/struts/action ActionForward.java
src/share/org/apache/struts/config ForwardConfig.java
src/share/org/apache/struts/util RequestUtils.java
src/test/org/apache/struts/mock TestMockBase.java
src/test/org/apache/struts/util TestRequestUtils.java
Log:
Deal with a path attribute on a forward that does not contain a leading
slash by inserting one if necessary, for backwards compatibility.
PR: Bugzilla #10534
Submitted by: Matt Raible matt at raibledesigns.com
Revision ChangesPath
1.8 +24 -4
jakarta-struts/src/share/org/apache/struts/action/ActionForward.java
Index: ActionForward.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionForward.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- ActionForward.java2 Jul 2002 01:52:15 - 1.7
+++ ActionForward.java7 Jul 2002 23:45:21 - 1.8
@@ -163,4 +163,24 @@
}
+/**
+ * Construct a new instance with the specified values.
+ *
+ * @param name Name of this instance
+ * @param path Path for this instance
+ * @param redirect Redirect flag for this instance
+ * @param contextRelative Context relative flag for this instance
+ */
+public ActionForward(String name, String path, boolean redirect,
+ boolean contextRelative) {
+
+super();
+setName(name);
+setPath(path);
+setRedirect(redirect);
+setContextRelative(contextRelative);
+
+}
+
+
}
1.6 +24 -4
jakarta-struts/src/share/org/apache/struts/config/ForwardConfig.java
Index: ForwardConfig.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/config/ForwardConfig.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- ForwardConfig.java4 Jul 2002 00:05:48 - 1.5
+++ ForwardConfig.java7 Jul 2002 23:45:21 - 1.6
@@ -109,6 +109,26 @@
}
+/**
+ * Construct a new instance with the specified values.
+ *
+ * @param name Name of this forward
+ * @param path Path to which control should be forwarded or redirected
+ * @param redirect Should we do a redirect?
+ * @param contextRelative Is this path context relative?
+ */
+public ForwardConfig(String name, String path, boolean redirect,
+ boolean contextRelative) {
+
+super();
+setName(name);
+setPath(path);
+setRedirect(redirect);
+setContextRelative(contextRelative);
+
+}
+
+
// - Instance Variables
1.45 +18 -7
jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java
Index: RequestUtils.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -r1.44 -r1.45
--- RequestUtils.java 5 Jul 2002 22:03:16 - 1.44
+++ RequestUtils.java 7 Jul 2002 23:45:21 - 1.45
@@ -1186,10 +1186,15 @@
public static String forwardURL(HttpServletRequest request,
ForwardConfig forward) {
+String path = forward.getPath();
+
// Handle a ForwardConfig marked as context relative
StringBuffer sb = new StringBuffer();
if (forward.getContextRelative()) {
-sb.append(forward.getPath());
+if (!path.startsWith(/)) {
+sb.append(/);
+}
+sb.append(path);
return (sb.toString());
}
@@ -1201,7 +1206,10 @@
if (forwardPattern == null) {
// Performance optimization for previous default behavior
sb.append(appConfig.getPrefix());
-sb.append(forward.getPath());
+if (!path.startsWith(/)) {
+sb.append(/);
+}
+sb.append(path);
} else {
boolean dollar = false;
for (int i = 0; i forwardPattern.length(); i++) {
@@ -1212,7 +1220,10 @@
sb.append(appConfig.getPrefix());
break;
case 'P':
-sb.append(forward.getPath());
+if (!path.startsWith(/)) {
+sb.append(/);
+}
+
DO NOT REPLY [Bug 10534] - html:link forward does not add servlet context correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10534. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10534 html:link forward does not add servlet context correctly [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-07 23:45 --- Fixed in nightly build 20020708. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts STATUS
craigmcc2002/07/07 16:46:27 Modified:.STATUS Log: Fixed 10534. Revision ChangesPath 1.8 +1 -2 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- STATUS7 Jul 2002 23:20:20 - 1.7 +++ STATUS7 Jul 2002 23:46:27 - 1.8 @@ -16,7 +16,6 @@ Custom Tags: --- 1586 The html:form tag generates incorrect focus javascript for radio buttons. -10534 html:link forward does not add servlet context correctly Documentation -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7541] - DIgester/Commons Logging error with -security
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7541 DIgester/Commons Logging error with -security [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-08 00:20 --- Problems with commons-logging under Tomcat with a security manager have been resolved in nightly commons-logging builds later than the 1.0 release (including the version of commons-logging.jar that is shipped with Tomcat 4.0.4 in the server/lib directory. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 7579] - Tomcat 4.0.3 + struts fails with -security
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7579. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7579 Tomcat 4.0.3 + struts fails with -security [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2002-07-08 00:41 --- The security manager issues with commons-logging have been resolved in recent nightly builds (tested against Tomcat 4.0.4 and 4.1.7 with security manager enabled). However, commons-beanutils requires the following permission to be granted if you use any beans that have mapped properties: permission java.lang.RuntimePermission accessDeclaredMembers; For Tomcat 4.x, this permission is granted by editing the file $CATALINA_HOME/conf/catalina.policy and granting this permission either to all code, or to just the codebase(s) you need. See the comments in catalina.policy for further instructions. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts/doc/userGuide installation.xml
craigmcc2002/07/07 17:55:49 Modified:.STATUS doc/userGuide installation.xml Log: Update the installation page to document the security manager permission you will need to grant when running Struts 1.1 (and thus commons-beanutils) apps that have mapped properties in their form beans. Remove 7579, which has been resolved. Revision ChangesPath 1.9 +0 -1 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- STATUS7 Jul 2002 23:46:27 - 1.8 +++ STATUS8 Jul 2002 00:55:49 - 1.9 @@ -44,7 +44,6 @@ Unknown: --- - 7579 Tomcat 4.0.3 + struts fails with -security 10380 DynaActionFormClass not serializable 10501 Error running struts under JRun 3.1 1.4 +17 -8 jakarta-struts/doc/userGuide/installation.xml Index: installation.xml === RCS file: /home/cvs/jakarta-struts/doc/userGuide/installation.xml,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- installation.xml 9 Jun 2002 22:23:25 - 1.3 +++ installation.xml 8 Jul 2002 00:55:49 - 1.4 @@ -216,13 +216,7 @@ codecommons-*.jar/code files (copied earlier) on the CLASSPATH that is submitted to the compiler./li /ul -/section section name=Installing Struts with your servlet container href=Containers - -pstrongWARNING/strong - Do strongNOT/strong add -codestruts.jar/code to the classpath of your servlet container in an -attempt to avoid placing it in the code/WEB-INF/lib/code directory of -each individual web app! Doing so will cause problems with -codeClassNotFoundException/code exceptions./p +/section section name=Installing Struts With Your Servlet Container href=Containers pFor most containers, you need only to: /p ul @@ -230,7 +224,22 @@ containers codewebapps/code directory. /li liIn some cases, you may need to restart your container if it is running./li /ul -h3Status of various containers/h3 + +h3Running Struts Applications Under A Security Manager/h3 + +pMany application servers execute web applications under the control of a +Java security manager, with restricted permissions on what classes in the web +application can do. If you utilize form beans with mapped properties, you may +encounter security exceptions unless you add the following permission to the +set of permissions granted to your Struts application's codebase:/p +pre + permission java.lang.RuntimePermission accessDeclaredMembers; +/pre + +pConsult the documentation on your application server for more information +about how to configure additional security manager permissions./p + +h3Installing Struts on Various Containers/h3 ul liBluestone Universal Business Server - a href=installation-ubs.htmlAdditional steps required./a/li -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-struts STATUS
craigmcc2002/07/07 18:03:25 Modified:.STATUS Log: Remove completed (7541) and duplicate (10501) entries. Revision ChangesPath 1.10 +10 -4 jakarta-struts/STATUS Index: STATUS === RCS file: /home/cvs/jakarta-struts/STATUS,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- STATUS8 Jul 2002 00:55:49 - 1.9 +++ STATUS8 Jul 2002 01:03:25 - 1.10 @@ -18,7 +18,7 @@ 1586 The html:form tag generates incorrect focus javascript for radio buttons. -Documentation +Documentation: - 10537 [:TODO:] sections (18) @@ -42,15 +42,17 @@ 10322 Problems with LookupDispatchAction and other locales +Tiles Framework: +--- + + Unknown: --- 10380 DynaActionFormClass not serializable -10501 Error running struts under JRun 3.1 Utilities: - - 7541 Digester/Commons Logging error with -security Validator Framework: @@ -66,3 +68,7 @@ 10348 Validator is not available under sub-application 10349 Validator: date validation does not allow blank input? 10432 DynaValidatorActionForm does not validate data + + +Web Site: + -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Logging in RequestProcessor
There are two log() methods in RequestProcessor that are, as far as I can tell, not used. They log to the owning servlet's logging instance. RequestProcessor creates its own logging instance, and uses that. Should we remove the log() methods, so that we don't have to keep them later just for backwards compatibility, or should we make them log to the local logging instance instead (or just leave them alone)? -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Logging in RequestProcessor
On Sun, 7 Jul 2002, Martin Cooper wrote: Date: Sun, 7 Jul 2002 18:16:30 -0700 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: '[EMAIL PROTECTED]' [EMAIL PROTECTED] Subject: Logging in RequestProcessor There are two log() methods in RequestProcessor that are, as far as I can tell, not used. They log to the owning servlet's logging instance. RequestProcessor creates its own logging instance, and uses that. Should we remove the log() methods, so that we don't have to keep them later just for backwards compatibility, or should we make them log to the local logging instance instead (or just leave them alone)? Lets leave them there but deprecate them (in case anyone is subclassing RequestProcessor and using them to write to the servlet context logs. -- Martin Cooper Craig -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Implementing canProcess method in RequestDispatcher
On Sun, Jul 07, 2002 at 02:56:52PM -0700, Craig R. McClanahan wrote: On Sun, 7 Jul 2002, Chris Nokleberg wrote: I have a servlet 2.3 filter that needs to forward requests based on whether they will be eventually be mapped to an action by struts. One approach to this would be to check the URL of the incoming request against the servlet mapping pattern for the controller servlet -- it's stored as servlet context attribute Action.SERVLET_KEY (org.apache.struts.action.SERVLET_MAPPING). Just because the struts servlet is mapped to a prefix does not mean that every action within that prefix is mapped to an action. Some background on why this may be useful to others. My goals are: - Not to have to restrict Action URLs to a special prefix (e.g. /control/*) or extension (e.g. *.do). - Have a mechanism to perform security checks for ALL URLs, including jsps and static content. My initial attempt was to map /* to ActionServlet, put all static content under WEB-INF and forward to there from a default Action. However, this runs into the well-known problem that even internal forwards to WEB-INF get mapped through /* back to the ActionServlet, resulting in infinite recursion. While I think this is a silly feature of the servlet spec, apparently there's no getting around it. My second attempt was more involved, and tried to leverage the new filters capabilities of the servlet 2.3 spec: - Map /control/* to ActionServlet. - Map a new filter (ActionFilter) to /*. The filter's job (after checking security) is to take the request URL, prepend /control, and ask the Struts framework if the new URL would eventually be mapped to an Action. If the answer is yes, the filter forwards to the modified URL. If no, the request is let through unmodified. (Direct requests to /control/* are also disallowed by the filter) This is where I ran into trouble--figuring out if a particular URL will be mapped to an action is rather difficult. -Chris -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 10542] New: - The multipartClass init-param is broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10542. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10542 The multipartClass init-param is broken Summary: The multipartClass init-param is broken Product: Struts Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Normal Priority: Other Component: Controller AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The servlet init-param for specifying a global multipart class handler (i.e. 'multipartClass') does not work. Specifying the class via the controller entry in struts-config.xml works fine, but we'll need to fix the init-param for backwards compatibility with Struts 1.0. (There's a FIXME - check this in ActionServlet.java, so I did. :) -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[PROPOSAL] Using Commons file upload implementation
Although several bugs have been fixed in the Struts multipart handling since Struts 1.0.x, there are still a number of issues, some of which will not be easy to resolve. (Not all of these issues have been logged in Bugzilla.) Meanwhile, a FileUpload project has appeared in the Commons sandbox. This implementation apparently originated in Turbine, and is claimed to be relatively mature. Although I have not yet tested it, examination of the source code leads me to believe that this implementation is significantly more robust that the current Struts implementation. Therefore, I propose to develop a CommonsMultipartRequestHandler which wraps the Commons FileUpload implementation. Initially, this would provide an alternative to the current Struts implementation, while in the longer term, it would allow Struts to get out of the multipart business by devolving to Commons. Comments, please? -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [PROPOSAL] Using Commons file upload implementation
I couldn't agree more, having used the O'Reilly multipart libraries with a lot of effort this would be a big win for those of us building document oriented systems on Struts. Ollie At 08:49 PM 7/7/2002 -0700, you wrote: Although several bugs have been fixed in the Struts multipart handling since Struts 1.0.x, there are still a number of issues, some of which will not be easy to resolve. (Not all of these issues have been logged in Bugzilla.) Meanwhile, a FileUpload project has appeared in the Commons sandbox. This implementation apparently originated in Turbine, and is claimed to be relatively mature. Although I have not yet tested it, examination of the source code leads me to believe that this implementation is significantly more robust that the current Struts implementation. Therefore, I propose to develop a CommonsMultipartRequestHandler which wraps the Commons FileUpload implementation. Initially, this would provide an alternative to the current Struts implementation, while in the longer term, it would allow Struts to get out of the multipart business by devolving to Commons. Comments, please? -- Martin Cooper -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] Michael Oliver Chief Technology Officer AppsAsPeers.com 7391 S. Bullrider Ave. Tucson, AZ 85747 520.574.1150 Voice 520.844.1036 Fax -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Action handler problem.
I am sorry James, but I have to disagree with you here. I think this is a development problem since its nothing to do with any setup or configuration files but it is about developing an application in strusts. warm regards -- Kedar -Original Message- From: Struts Developers List [EMAIL PROTECTED] at Internet Sent: Friday, July 05, 2002 2:43 PM To: Struts Developers List [EMAIL PROTECTED] at Internet Subject: RE: Action handler problem. Kedar-- These types of question are best asked on the Struts Users mailing list. [EMAIL PROTECTED] -james [EMAIL PROTECTED] http://www.jamesholmes.com/struts/ --- Kedar Upadhye [EMAIL PROTECTED] wrote: Hello All, One simple question about the action handler class. I have a form here (.JSP file ) with one submit button. I have the action mapping in the Strust-config.xml file so that this JSP is connected to one action handler class. However when the project runs and the button is pressed , the action handler class's perform method is not called. What else I need to do to achieve this ? Is there any other setting ? My action class is derived from the Action class. Let me know if I am missing anything. warm regards -- Kedar -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] __ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
RE: Action handler problem.
On Mon, 8 Jul 2002 [EMAIL PROTECTED] wrote: Date: Mon, 8 Jul 2002 10:30:00 -0700 From: [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Subject: RE: Action handler problem. I am sorry James, but I have to disagree with you here. I think this is a development problem since its nothing to do with any setup or configuration files but it is about developing an application in strusts. Kedar, This list is the place to participate in discussions about the development of the Struts framework itself. Questions such as yours, about *using* Struts, are off topic here, but are relevant on STRUTS-USER. Please see the background information on Jakarta mailing lists for more information about the purpose of each list: http://jakarta.apache.org/site/mail.html warm regards -- Kedar Craig McClanahan -Original Message- From: Struts Developers List [EMAIL PROTECTED] at Internet Sent: Friday, July 05, 2002 2:43 PM To: Struts Developers List [EMAIL PROTECTED] at Internet Subject: RE: Action handler problem. Kedar-- These types of question are best asked on the Struts Users mailing list. [EMAIL PROTECTED] -james [EMAIL PROTECTED] http://www.jamesholmes.com/struts/ --- Kedar Upadhye [EMAIL PROTECTED] wrote: Hello All, One simple question about the action handler class. I have a form here (.JSP file ) with one submit button. I have the action mapping in the Strust-config.xml file so that this JSP is connected to one action handler class. However when the project runs and the button is pressed , the action handler class's perform method is not called. What else I need to do to achieve this ? Is there any other setting ? My action class is derived from the Action class. Let me know if I am missing anything. warm regards -- Kedar -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] __ Do You Yahoo!? Sign up for SBC Yahoo! Dial - First Month Free http://sbc.yahoo.com -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
