Re: Bugzilla "protocol" question

2002-07-10 Thread Craig R. McClanahan



On Wed, 10 Jul 2002, Joe Germuska wrote:

> Date: Wed, 10 Jul 2002 23:34:23 -0500
> From: Joe Germuska <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: Bugzilla "protocol" question
>
> Hi:
>
> Are there any understandings about who marks Bugzilla bugs as
> "resolved"?  Earlier tonight, I marked #10006 as "Resolved/Wontfix"
> because it refers to BeanUtils as a Struts component, and it is now a
> commons component.
>
> Is this kind of resolution something which is meant to be done only by
> committers?  I don't want to step on anyone's toes or anything; I'm just
> trying to help knock out bugs en route to another beta release.
>
> The pages I found in bugzilla only seem to talk about posting bugs, not
> closing them.  Maybe I didn't look hard enough?
>
> Please advise,
>   Joe
>
>   http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10006
>

General protocol I am used to is that it's either done by a committer or
by the originator, unless it's clearly not a bug -- which probably isn't
really true on the bug report in question.  However, your conclusion that
it probably won't get fixed (in 1.0.x) is probably accurate in the end.

Craig


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Bugzilla "protocol" question

2002-07-10 Thread Joe Germuska

Hi:

Are there any understandings about who marks Bugzilla bugs as 
"resolved"?  Earlier tonight, I marked #10006 as "Resolved/Wontfix" 
because it refers to BeanUtils as a Struts component, and it is now a 
commons component.

Is this kind of resolution something which is meant to be done only by 
committers?  I don't want to step on anyone's toes or anything; I'm just 
trying to help knock out bugs en route to another beta release.

The pages I found in bugzilla only seem to talk about posting bugs, not 
closing them.  Maybe I didn't look hard enough?

Please advise,
Joe

  http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10006


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10006] - BeanUtils doesn't convert null values to target type

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10006

BeanUtils doesn't convert null values to target type

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2002-07-11 04:15 ---
The patched file is no longer part of Struts.  It looks like this issue was 
resolved in version 1.23 of 
org.apache.commons.beanutils.BeanUtils.java, if I read the log correctly.  
In any case, it's not relevant as a Struts bug any longer.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 9364] - html:hidden tag does not support styleId

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9364

html:hidden tag does not support styleId





--- Additional Comments From [EMAIL PROTECTED]  2002-07-11 04:01 ---
Created an attachment (id=2315)
patch adding style and event attributes to html:hidden

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 9364] - html:hidden tag does not support styleId

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9364

html:hidden tag does not support styleId





--- Additional Comments From [EMAIL PROTECTED]  2002-07-11 04:00 ---
According to the HTML 4.01 spec, all of the "coreattrs" and "event" 
attributes are legal for all input elements.  The coreattrs include "id", 
"style", and "class", or in Struts terms, "styleId," "style," and "styleClass".

When I saw that the events are also supported, I copied attribute blocks 
from another spot in struts-html.xml to add those three tags as well as the 
event tags to the hidden tag.  

I would guess that long-term, all HTML 4.01 attributes should be 
supported by all of the html tags, but some of that is kind of tedious.  Is 
there any other reason not to support things like the i18n tags (lang and 
dir)?

Patch to come.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10622] - Problem with nested iterate tags

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10622

Problem with nested iterate tags

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2002-07-11 01:31 ---
Thanks Craig, you are right. I do not have the same problem when using tomcat 
4.0.4.  Sorry for the false alarm so I should raise this as an issue in Tomcat 
then.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts STATUS

2002-07-10 Thread jholmes

jholmes 2002/07/10 15:47:57

  Modified:.STATUS
  Log:
  remove 7751
  
  Revision  ChangesPath
  1.16  +1 -2  jakarta-struts/STATUS
  
  Index: STATUS
  ===
  RCS file: /home/cvs/jakarta-struts/STATUS,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- STATUS10 Jul 2002 01:50:04 -  1.15
  +++ STATUS10 Jul 2002 22:47:57 -  1.16
  @@ -63,7 +63,6 @@
7351 Validator JavaScript Primitive Validation Error
7352 Struts 1.1 Beta 1 Release incorrectly reference contrib/validator
7353 Validator JavaScript Select Error
  - 7751 DynaValidatorActionForm throws NPE and class cast exception
8446 Zero values are not validated as byte, integer, etc.
9051 [PATCH] 0 should be a valid float
   10191 Validator range checking bug
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: DO NOT REPLY [Bug 7751] - DynaValidatorForm throwsNullPointerExceptionand ClassCastException

2002-07-10 Thread Craig R. McClanahan



On Wed, 10 Jul 2002, James Mitchell wrote:

> Date: Wed, 10 Jul 2002 16:54:49 -0400
> From: James Mitchell <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>,
>  [EMAIL PROTECTED]
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: RE: DO NOT REPLY [Bug 7751]  - DynaValidatorForm
> throwsNullPointerException and ClassCastException
>
> This is great Craig, I can't believe it wasn't thought of earlier.
>
> One quick question...(I'll probably try it later tonight anyway)...but:
>
> does this mean I can do this...
>
>  type="com.myform.that.extends.ActionForm">
>   
> 
> 
>
> ...and have only password/getPassword()/setPassword() defined???
>
> Or is it an 'all or nothing' approach?
>

I'm not sure I know quite what you mean by 'all or nothing', but a form
bean has to be either DynaActionForm (or a subclass), in which case it's a
DynaBean with the properties identified by  elements, or
it's an ActionForm (or subclass), in which case any 
settings are ignored.  All I changed is that the "dynamic" attribute is
calculated from the implementation class, based on whether it's a DAF or
not.

You can't mix standard JavaBean properties and DynaBean properties in the
same bean -- the commons-beanutils classes always do (bean instanceof
DynaBean) checks when deciding what to do.

>
>
> James Mitchell
> Software Engineer\Struts Evangelist
> Struts-Atlanta, the "Open Minded Developer Network"
> http://www.open-tools.org/struts-atlanta
>

Craig


>
>
>
> > -Original Message-
> > From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, July 10, 2002 4:38 PM
> > To: Struts Developers List
> > Subject: Re: DO NOT REPLY [Bug 7751] - DynaValidatorForm
> > throwsNullPointerException and ClassCastException
> >
> >
> > 
> > OK, OK, I just committed a fix based on this to eliminate having to set
> > the stupid "dynamic" attribute for DynaActionForm subclasses.  It shoulda
> > never been there in the first place.
> > 
> >
> > Craig
> >
> >
> >
> > On 10 Jul 2002 [EMAIL PROTECTED] wrote:
> >
> > > Date: 10 Jul 2002 18:38:39 -
> > > From: [EMAIL PROTECTED]
> > > Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> > > To: [EMAIL PROTECTED]
> > > Subject: DO NOT REPLY [Bug 7751]  - DynaValidatorForm throws
> > > NullPointerException and ClassCastException
> > >
> > > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
> > > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> > > .
> > > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
> > > INSERTED IN THE BUG DATABASE.
> > >
> > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7751
> > >
> > > DynaValidatorForm throws NullPointerException and ClassCastException
> > >
> > > [EMAIL PROTECTED] changed:
> > >
> > >What|Removed |Added
> > >
> > --
> > --
> > >  Status|NEW |RESOLVED
> > >  Resolution||FIXED
> > >
> > >
> > >
> > > --- Additional Comments From [EMAIL PROTECTED]  2002-07-10
> > 18:38 ---
> > > I have had the same problem, and Joe has right the
> > dynamic="true" attribute on
> > > the form-bean element solves the issue. But I think it's a
> > better solution if
> > > change some lines in the FormBeanConfig:
> > >
> > > Index: FormBeanConfig.java
> > > ===
> > > RCS file: /home/cvspublic/jakarta-
> > > struts/src/share/org/apache/struts/config/FormBeanConfig.java,v
> > > retrieving revision 1.6
> > > diff -u -r1.6 FormBeanConfig.java
> > > --- FormBeanConfig.java 9 Jul 2002 23:57:37 -   1.6
> > > +++ FormBeanConfig.java 10 Jul 2002 18:34:57 -
> > > @@ -152,8 +152,14 @@
> > >  throw new IllegalStateException("Configuration is frozen");
> > >  }
> > >  this.type = type;
> > > -if ("org.apache.struts.action.DynaActionForm".equals(type)) {
> > > -this.dynamic = true;
> > > +try {
> > > +Class formClazz = Class.forName(type);
> > > +Class dynaClazz = Class.forName
> > > ("org.apache.struts.action.DynaActionForm");
> > > +if (dynaClazz.isAssignableFrom(formClazz)) {
> > > +this.dynamic = true;
> > > +}
> > > +} catch (Exception e) {
> > > +throw new IllegalArgumentException("Form type
> > can't be found");
> > >  }
> > >  }
> > >
> > > --
> > > To unsubscribe, e-mail:
> 
> > For additional commands, e-mail:
> 
> >
> >
>
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
>
>
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-m

cvs commit: jakarta-struts/doc news.xml

2002-07-10 Thread jholmes

jholmes 2002/07/10 15:28:42

  Modified:doc  news.xml
  Log:
  add new Oracle JDeveloper 9i tutorial
  
  Revision  ChangesPath
  1.8   +7 -1  jakarta-struts/doc/news.xml
  
  Index: news.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/news.xml,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- news.xml  9 Jul 2002 23:10:25 -   1.7
  +++ news.xml  10 Jul 2002 22:28:42 -  1.8
  @@ -40,6 +40,13 @@

   
   
  +10 July 2002 - Using Struts in Oracle JDeveloper 9i 
Tutorial
  +
  +http://otn.oracle.com/products/jdev/howtos/jsp/StrutsHowTo.html";>
  +How Do I use Jakarta Struts with Oracle9i JDeveloper? by Oracle 
Corporation.
  +
  +
  +
   9 July 2002 - Struts Console version 2.0
   
   Struts Console version 2.0 is now available.
  @@ -81,7 +88,6 @@
   Extensive refactorings to improve performance and reduce code size.
   
   
  -
   
   
   09 July 2002 - Struts Adoption article
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/doc/resources tutorials.xml

2002-07-10 Thread jholmes

jholmes 2002/07/10 15:25:14

  Modified:doc/resources tutorials.xml
  Log:
  added Oracle JDeveloper tutorial
  
  Revision  ChangesPath
  1.3   +1 -0  jakarta-struts/doc/resources/tutorials.xml
  
  Index: tutorials.xml
  ===
  RCS file: /home/cvs/jakarta-struts/doc/resources/tutorials.xml,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- tutorials.xml 23 Jun 2002 18:24:30 -  1.2
  +++ tutorials.xml 10 Jul 2002 22:25:14 -  1.3
  @@ -10,6 +10,7 @@
   http://husted.com/struts/resources";> 
   
   
  +http://otn.oracle.com/products/jdev/howtos/jsp/StrutsHowTo.html";>How 
Do I use Jakarta Struts with Oracle9i JDeveloper? by Oracle Corporation.
   http://rollerjm.free.fr/pro/Struts.html";>Struts Controller UML 
Diagrams by Jean-Michel Garnier - The goal of this article is to illustrate 
the Struts 1.1 Controller with UML diagrams. This article is an introduction to the 
Struts framework in order to help beginners programmers to understand the MVC model 
2.
   http://husted.com/struts/tips/";>Struts Tips by Ted Husted - 
Practical cut-and-paste advice.
   http://rzserv2.fhnon.de/~lg002556/struts/";>Struts Tutorial 
by Stephan Wiesner - An easy step by step introduction to Struts. 
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: DO NOT REPLY [Bug 7751] - DynaValidatorForm throwsNullPointerException and ClassCastException

2002-07-10 Thread James Mitchell

This is great Craig, I can't believe it wasn't thought of earlier.

One quick question...(I'll probably try it later tonight anyway)...but:

does this mean I can do this...


  



...and have only password/getPassword()/setPassword() defined???

Or is it an 'all or nothing' approach?



James Mitchell
Software Engineer\Struts Evangelist
Struts-Atlanta, the "Open Minded Developer Network"
http://www.open-tools.org/struts-atlanta




> -Original Message-
> From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, July 10, 2002 4:38 PM
> To: Struts Developers List
> Subject: Re: DO NOT REPLY [Bug 7751] - DynaValidatorForm
> throwsNullPointerException and ClassCastException
>
>
> 
> OK, OK, I just committed a fix based on this to eliminate having to set
> the stupid "dynamic" attribute for DynaActionForm subclasses.  It shoulda
> never been there in the first place.
> 
>
> Craig
>
>
>
> On 10 Jul 2002 [EMAIL PROTECTED] wrote:
>
> > Date: 10 Jul 2002 18:38:39 -
> > From: [EMAIL PROTECTED]
> > Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> > To: [EMAIL PROTECTED]
> > Subject: DO NOT REPLY [Bug 7751]  - DynaValidatorForm throws
> > NullPointerException and ClassCastException
> >
> > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
> > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> > .
> > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
> > INSERTED IN THE BUG DATABASE.
> >
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7751
> >
> > DynaValidatorForm throws NullPointerException and ClassCastException
> >
> > [EMAIL PROTECTED] changed:
> >
> >What|Removed |Added
> >
> --
> --
> >  Status|NEW |RESOLVED
> >  Resolution||FIXED
> >
> >
> >
> > --- Additional Comments From [EMAIL PROTECTED]  2002-07-10
> 18:38 ---
> > I have had the same problem, and Joe has right the
> dynamic="true" attribute on
> > the form-bean element solves the issue. But I think it's a
> better solution if
> > change some lines in the FormBeanConfig:
> >
> > Index: FormBeanConfig.java
> > ===
> > RCS file: /home/cvspublic/jakarta-
> > struts/src/share/org/apache/struts/config/FormBeanConfig.java,v
> > retrieving revision 1.6
> > diff -u -r1.6 FormBeanConfig.java
> > --- FormBeanConfig.java 9 Jul 2002 23:57:37 -   1.6
> > +++ FormBeanConfig.java 10 Jul 2002 18:34:57 -
> > @@ -152,8 +152,14 @@
> >  throw new IllegalStateException("Configuration is frozen");
> >  }
> >  this.type = type;
> > -if ("org.apache.struts.action.DynaActionForm".equals(type)) {
> > -this.dynamic = true;
> > +try {
> > +Class formClazz = Class.forName(type);
> > +Class dynaClazz = Class.forName
> > ("org.apache.struts.action.DynaActionForm");
> > +if (dynaClazz.isAssignableFrom(formClazz)) {
> > +this.dynamic = true;
> > +}
> > +} catch (Exception e) {
> > +throw new IllegalArgumentException("Form type
> can't be found");
> >  }
> >  }
> >
> > --
> > To unsubscribe, e-mail:

> For additional commands, e-mail:

>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Running Unit Tests Before Commits

2002-07-10 Thread Craig R. McClanahan

Doing the fix for 7751, I ran into a case where the undo of the "/" adding
change caused the unit tests to fail, because I'd added some tests for the
new behavior.  I've commented those tests out until we figure out what to
do about that particular situation.

I'd like to ask all Struts committers to follow these practices:

* When fixing a bug, build a unit test to verify the corrected behavior
  if this is at all reasonable to do.  There are some mock objects in
  the src/test hierarchy now, so you should be able to write JUnit tests
  for pretty much any class other than the tag implementations.

* Always run "ant test.junit" and "ant test.tomcat.all" before checking
  in your changes, to ensure that we don't introduce any regressions on
  stuff that is already tested.

Thanks!

Craig



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: DO NOT REPLY [Bug 7751] - DynaValidatorForm throwsNullPointerException and ClassCastException

2002-07-10 Thread Craig R. McClanahan


OK, OK, I just committed a fix based on this to eliminate having to set
the stupid "dynamic" attribute for DynaActionForm subclasses.  It shoulda
never been there in the first place.


Craig



On 10 Jul 2002 [EMAIL PROTECTED] wrote:

> Date: 10 Jul 2002 18:38:39 -
> From: [EMAIL PROTECTED]
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: [EMAIL PROTECTED]
> Subject: DO NOT REPLY [Bug 7751]  - DynaValidatorForm throws
> NullPointerException and ClassCastException
>
> DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
> RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
> .
> ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
> INSERTED IN THE BUG DATABASE.
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7751
>
> DynaValidatorForm throws NullPointerException and ClassCastException
>
> [EMAIL PROTECTED] changed:
>
>What|Removed |Added
> 
>  Status|NEW |RESOLVED
>  Resolution||FIXED
>
>
>
> --- Additional Comments From [EMAIL PROTECTED]  2002-07-10 18:38 ---
> I have had the same problem, and Joe has right the dynamic="true" attribute on
> the form-bean element solves the issue. But I think it's a better solution if
> change some lines in the FormBeanConfig:
>
> Index: FormBeanConfig.java
> ===
> RCS file: /home/cvspublic/jakarta-
> struts/src/share/org/apache/struts/config/FormBeanConfig.java,v
> retrieving revision 1.6
> diff -u -r1.6 FormBeanConfig.java
> --- FormBeanConfig.java 9 Jul 2002 23:57:37 -   1.6
> +++ FormBeanConfig.java 10 Jul 2002 18:34:57 -
> @@ -152,8 +152,14 @@
>  throw new IllegalStateException("Configuration is frozen");
>  }
>  this.type = type;
> -if ("org.apache.struts.action.DynaActionForm".equals(type)) {
> -this.dynamic = true;
> +try {
> +Class formClazz = Class.forName(type);
> +Class dynaClazz = Class.forName
> ("org.apache.struts.action.DynaActionForm");
> +if (dynaClazz.isAssignableFrom(formClazz)) {
> +this.dynamic = true;
> +}
> +} catch (Exception e) {
> +throw new IllegalArgumentException("Form type can't be found");
>  }
>  }
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/src/test/org/apache/struts/util TestRequestUtils.java

2002-07-10 Thread craigmcc

craigmcc2002/07/10 13:36:23

  Modified:conf/share struts-config_1_1.dtd
   src/share/org/apache/struts/action ActionFormBean.java
   src/share/org/apache/struts/config FormBeanConfig.java
   src/test/org/apache/struts/action
TestDynaActionFormClass.java
   src/test/org/apache/struts/mock TestMockBase.java
   src/test/org/apache/struts/util TestRequestUtils.java
  Log:
  Remove the hacky need for a "dynamic" attribute on .  Subclasses
  of DynaActonFormBean are now recognized automatically.
  
  PR: Bugzilla #7751
  Submitted by: Lajos Papp 
  
  Revision  ChangesPath
  1.26  +3 -2  jakarta-struts/conf/share/struts-config_1_1.dtd
  
  Index: struts-config_1_1.dtd
  ===
  RCS file: /home/cvs/jakarta-struts/conf/share/struts-config_1_1.dtd,v
  retrieving revision 1.25
  retrieving revision 1.26
  diff -u -r1.25 -r1.26
  --- struts-config_1_1.dtd 7 Jul 2002 22:02:17 -   1.25
  +++ struts-config_1_1.dtd 10 Jul 2002 20:36:23 -  1.26
  @@ -222,7 +222,8 @@
conventional ActionForm subclass, then this attribute can be
omitted.
[true] if type is "org.apache.struts.action.DynaActionForm"
  - [false] otherwise
  + [false] otherwise  DEPRECATED - THIS IS NOW DETERMINED
  + DYNAMICALLY BASED ON THE SPECIFIED IMPLEMENTATION CLASS.
   
nameThe unique identifier for this form bean. Referenced by the
 element to specify which form bean to use with its
  
  
  
  1.7   +5 -7  
jakarta-struts/src/share/org/apache/struts/action/ActionFormBean.java
  
  Index: ActionFormBean.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionFormBean.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ActionFormBean.java   2 Jul 2002 04:23:13 -   1.6
  +++ ActionFormBean.java   10 Jul 2002 20:36:23 -  1.7
  @@ -101,14 +101,12 @@
*
* @param name Form bean name
* @param type Fully qualified class name
  - * @param dynamic Is this a DynaActionForm bean?
*/
  -public ActionFormBean(String name, String type, boolean dynamic) {
  +public ActionFormBean(String name, String type) {
   
   super();
   setName(name);
   setType(type);
  -setDynamic(dynamic);
   
   }
   
  
  
  
  1.7   +42 -4 
jakarta-struts/src/share/org/apache/struts/config/FormBeanConfig.java
  
  Index: FormBeanConfig.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/config/FormBeanConfig.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- FormBeanConfig.java   9 Jul 2002 23:57:37 -   1.6
  +++ FormBeanConfig.java   10 Jul 2002 20:36:23 -  1.7
  @@ -65,6 +65,7 @@
   
   import java.io.Serializable;
   import java.util.HashMap;
  +import org.apache.struts.action.DynaActionForm;
   
   
   /**
  @@ -109,11 +110,15 @@
   return (this.dynamic);
   }
   
  +/**
  + * @deprecated The value to be returned by getDynamic()
  + * is now computed automatically in setType()
  + */
   public void setDynamic(boolean dynamic) {
   if (configured) {
  -throw new IllegalStateException("Configuration is frozen");
  +throw new IllegalStateException("Configuration is frozen"); 
   }
  -this.dynamic = dynamic;
  +; // No action required
   }
   
   
  @@ -152,8 +157,16 @@
   throw new IllegalStateException("Configuration is frozen");
   }
   this.type = type;
  -if ("org.apache.struts.action.DynaActionForm".equals(type)) {
  -this.dynamic = true;
  +Class dynaBeanClass = DynaActionForm.class;
  +Class formBeanClass = formBeanClass();
  +if (formBeanClass != null) {
  +if (dynaBeanClass.isAssignableFrom(formBeanClass)) {
  +this.dynamic = true;
  +} else {
  +this.dynamic = false;
  +}
  +} else {
  +this.dynamic = false;
   }
   }
   
  @@ -253,6 +266,31 @@
   sb.append(this.type);
   sb.append("]");
   return (sb.toString());
  +
  +}
  +
  +
  +// -- Protected Methods
  +
  +
  +/**
  + * Return the Class instance for the form bean implementation
  + * configured by this FormBeanConfig instance.  This method
  + * uses the same algorithm as RequestUtils.applicationClass()
  + *

cvs commit: jakarta-struts/web/blank/WEB-INF/src/java/resources application.properties

2002-07-10 Thread husted

husted  2002/07/10 13:23:49

  Added:   web/blank/WEB-INF/src/java/resources application.properties
  Log:
  Update blank application for tiles, validator, et cetera.
  
  Revision  ChangesPath
  1.1  
jakarta-struts/web/blank/WEB-INF/src/java/resources/application.properties
  
  Index: application.properties
  ===
  # -- standard errors --
  errors.header=
  errors.prefix=
  errors.suffix=
  errors.footer=
  # -- validator --
  errors.invalid={0} is invalid.
  errors.maxlength={0} can not be greater than {1} characters.
  errors.minlength={0} can not be less than {1} characters.
  errors.range={0} is not in the range {1} through {2}.
  errors.required={0} is required.
  errors.byte={0} must be an byte.
  errors.date={0} is not a date.
  errors.double={0} must be an double.
  errors.float={0} must be an float.
  errors.integer={0} must be an integer.
  errors.long={0} must be an long.
  errors.short={0} must be an short.
  errors.creditcard={0} is not a valid credit card number.
  errors.email={0} is an invalid e-mail address.
  # -- other --
  errors.cancel=Operation cancelled.
  errors.detail={0}
  errors.general=The process did not complete. Details should follow.
  errors.token=Request could not be completed. Operation is not in sequence.
  # -- welcome --
  welcome.title=Struts Blank Application
  welcome.heading=Welcome!
  welcome.message=To get started on your own application, copy the struts-blank.war to 
a new WAR file using the name for your application. Place it in your container's 
"webapp" folder (or equivalent), and let your container auto-deploy the application. 
Edit the skeleton configuration files as needed, restart your container, and you are 
on your way! (You can find the application.properties file with this message in the 
/WEB-INF/src/java/resources folder.)
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/WEB-INF/src/java/resources - New directory

2002-07-10 Thread husted

husted  2002/07/10 13:23:36

  jakarta-struts/web/blank/WEB-INF/src/java/resources - New directory

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/WEB-INF/src build.xml

2002-07-10 Thread husted

husted  2002/07/10 13:23:29

  Added:   web/blank/WEB-INF/src build.xml
  Log:
  Update blank application for tiles, validator, et cetera.
  
  Revision  ChangesPath
  1.1  jakarta-struts/web/blank/WEB-INF/src/build.xml
  
  Index: build.xml
  ===
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  


  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  



  

  
 
  
  
  
  
  
  
  
  
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/WEB-INF/src/java - New directory

2002-07-10 Thread husted

husted  2002/07/10 13:23:18

  jakarta-struts/web/blank/WEB-INF/src/java - New directory

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/WEB-INF/src - New directory

2002-07-10 Thread husted

husted  2002/07/10 13:23:10

  jakarta-struts/web/blank/WEB-INF/src - New directory

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/WEB-INF validation.xml tiles-defs.xml web.xml struts-config.xml

2002-07-10 Thread husted

husted  2002/07/10 13:21:25

  Modified:web/blank/WEB-INF web.xml struts-config.xml
  Added:   web/blank/WEB-INF validation.xml tiles-defs.xml
  Log:
  Update blank application for tiles, validator, et cetera.
  
  Revision  ChangesPath
  1.4   +13 -23jakarta-struts/web/blank/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-struts/web/blank/WEB-INF/web.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- web.xml   19 Mar 2002 03:56:11 -  1.3
  +++ web.xml   10 Jul 2002 20:21:25 -  1.4
  @@ -6,20 +6,6 @@
   
   
   
  -
  -  
  -
  -
 
 
   action
  @@ -52,26 +38,30 @@
   index.jsp
 
   
  -  
   
 
 
  -/WEB-INF/struts-bean.tld
  +/tags/struts-bean
   /WEB-INF/struts-bean.tld
 
   
 
  -/WEB-INF/struts-html.tld
  +/tags/struts-html
   /WEB-INF/struts-html.tld
 
   
 
  -/WEB-INF/struts-logic.tld
  +/tags/struts-logic
  +/WEB-INF/struts-logic.tld
  +  
  +
  +  
  +/tags/struts-nested
  +/WEB-INF/struts-nested.tld
  +  
  +
  +  
  +/tags/struts-tiles
   /WEB-INF/struts-logic.tld
 
   
  
  
  
  1.5   +132 -96   jakarta-struts/web/blank/WEB-INF/struts-config.xml
  
  Index: struts-config.xml
  ===
  RCS file: /home/cvs/jakarta-struts/web/blank/WEB-INF/struts-config.xml,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- struts-config.xml 1 Apr 2002 06:03:07 -   1.4
  +++ struts-config.xml 10 Jul 2002 20:21:25 -  1.5
  @@ -5,114 +5,150 @@
 "http://jakarta.apache.org/struts/dtds/struts-config_1_1.dtd";>
   
   
   
   
   
   
  -
  -  
  +
   
   
  -  
  -  
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
  +
   
  -
  -
  -  
  -
  -
  -  
  -  
  -
  -
  -
  -  
  -
  -
  -  
  -  
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -  
  -
  -  
  -
  -  
  -
  -  
  -  
  -  
  -  
   
   
  
  
  
  1.1  jakarta-struts/web/blank/WEB-INF/validation.xml
  
  Index: validation.xml
  ===
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  1.1  jakarta-struts/web/blank/WEB-INF/tiles-defs.xml
  
  Index: tiles-defs.xml
  ===
  
  
   http://jakarta.apache.org/struts/dtds/tiles-config.dtd";>
  
  
  
  
  
  
  
  
  
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/pages Welcome.jsp

2002-07-10 Thread husted

husted  2002/07/10 13:21:03

  Added:   web/blank/pages Welcome.jsp
  Log:
  Update blank application for tiles, validator, et cetera.
  
  Revision  ChangesPath
  1.1  jakarta-struts/web/blank/pages/Welcome.jsp
  
  Index: Welcome.jsp
  ===
  <%@ taglib uri="/tags/struts-bean" prefix="bean" %>
  <%@ taglib uri="/tags/struts-html" prefix="html" %>
  <%@ taglib uri="/tags/struts-logic" prefix="logic" %>
  
  
  
  
  
  
  
  
  

  ERROR:  Application resources not loaded -- check servlet container
  logs for error messages.

  
  
  
  
  
  
  
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank/pages - New directory

2002-07-10 Thread husted

husted  2002/07/10 13:20:17

  jakarta-struts/web/blank/pages - New directory

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/web/blank index.jsp

2002-07-10 Thread husted

husted  2002/07/10 13:20:09

  Modified:web/blank index.jsp
  Log:
  Update blank application for tiles, validator, et cetera.
  
  Revision  ChangesPath
  1.2   +9 -24 jakarta-struts/web/blank/index.jsp
  
  Index: index.jsp
  ===
  RCS file: /home/cvs/jakarta-struts/web/blank/index.jsp,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- index.jsp 12 Feb 2001 23:59:40 -  1.1
  +++ index.jsp 10 Jul 2002 20:20:09 -  1.2
  @@ -1,24 +1,9 @@
  -<%@ page language="java" %>
  -<%@ taglib uri="/WEB-INF/struts-bean.tld" prefix="bean" %>
  -<%@ taglib uri="/WEB-INF/struts-html.tld" prefix="html" %>
  -<%@ taglib uri="/WEB-INF/struts-logic.tld" prefix="logic" %>
  -
  -
  -
  -
  -
  -
  -
  -
  -
  -  
  -ERROR:  Application resources not loaded -- check servlet container
  -logs for error messages.
  -  
  -
  -
  -
  -
  -
  -
  -
  +<%@ taglib uri="/tags/struts-logic" prefix="logic" %>
  +
  +
  +<%--
  +
  +Redirect default requests to Welcome global ActionForward.
  +By using a redirect, the user-agent will change address to match the path of our 
Welcome ActionForward. 
  +
  +--%>
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: DTDs for Validator Configuration Files

2002-07-10 Thread James Holmes

Steve,

That would be great.  If you could just send in
patches or complete files to this list, I or another
committer can get them into CVS.

Thanks,

-james
[EMAIL PROTECTED]
http://www.jamesholmes.com/struts/


--- "Byrne, Steven" <[EMAIL PROTECTED]> wrote:
> Take those DTDs with a hefty grain of salt.  I think
> it would be *FAR*
> better to derive them by looking at the digester
> code and the associated
> attribute sets.  If it would be of help, I can do
> this by the end of
> this week.
> 
> Steve
> 
> > -Original Message-
> > From: James Holmes [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, July 10, 2002 9:30 AM
> > To: Struts Developers List
> > Subject: Re: DTDs for Validator Configuration
> Files
> > 
> > 
> > Thanks for bringing light to this Craig.  I
> brought
> > this up awhile back and got no response.  There
> has
> > been some discussion on the Users' list as well
> about
> > this.  A couple of the people on the Users' list
> have
> > posted tools generated DTDs.  I'll forward those
> > messages to the dev list and that should get us
> > rolling. I'm happy to help as well.
> > 
> > I plan to add support for the Validator config
> files
> > to Struts Console once there is a DTD.  Just as
> there
> > is now Tiles config file support in Struts
> Console.
> > 
> > -james
> > [EMAIL PROTECTED]
> > http://www.jamesholmes.com/struts/
> > 
> > 
> > --- "Craig R. McClanahan" <[EMAIL PROTECTED]>
> wrote:
> > > (Primarily to David),
> > > 
> > > As Chuck points out in his new chapter, there
> are no
> > > DTDs available for
> > > the validator configuration files.  Would it be
> > > possible to create such
> > > things (in conf/share) so that the corresponding
> XML
> > > files can refer to
> > > them?
> > > 
> > > If you're not real comfortable with all the
> syntax
> > > quirks of DTDs, I'd be
> > > happy to just take an informal description of
> the
> > > elements and attributes
> > > that are supported, and turn that into a DTD
> like
> > > the one for
> > > struts-config.
> > > 
> > > Craig
> > > 
> > > 
> > > 
> > > --
> > > To unsubscribe, e-mail:  
> > >
> 
> > > For additional commands, e-mail:
> > > 
> > > 
> > 
> > 
> > __
> > Do You Yahoo!?
> > Sign up for SBC Yahoo! Dial - First Month Free
> > http://sbc.yahoo.com
> > 
> > --
> > To unsubscribe, e-mail:   
> 
> For additional commands, e-mail:
> 
> 
> 
> --
> To unsubscribe, e-mail:  
> 
> For additional commands, e-mail:
> 
> 


__
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: DTDs for Validator Configuration Files

2002-07-10 Thread Ted Husted

If it helps, I have a draft of some API documentation that I was getting
ready to review and release. 

http://husted.com/scaffolding/validator-grammar.htm


"Byrne, Steven" wrote:
> 
> Take those DTDs with a hefty grain of salt.  I think it would be *FAR*
> better to derive them by looking at the digester code and the associated
> attribute sets.  If it would be of help, I can do this by the end of
> this week.
> 
> Steve
> 
> > -Original Message-
> > From: James Holmes [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, July 10, 2002 9:30 AM
> > To: Struts Developers List
> > Subject: Re: DTDs for Validator Configuration Files
> >
> >
> > Thanks for bringing light to this Craig.  I brought
> > this up awhile back and got no response.  There has
> > been some discussion on the Users' list as well about
> > this.  A couple of the people on the Users' list have
> > posted tools generated DTDs.  I'll forward those
> > messages to the dev list and that should get us
> > rolling. I'm happy to help as well.
> >
> > I plan to add support for the Validator config files
> > to Struts Console once there is a DTD.  Just as there
> > is now Tiles config file support in Struts Console.
> >
> > -james
> > [EMAIL PROTECTED]
> > http://www.jamesholmes.com/struts/
> >
> >
> > --- "Craig R. McClanahan" <[EMAIL PROTECTED]> wrote:
> > > (Primarily to David),
> > >
> > > As Chuck points out in his new chapter, there are no
> > > DTDs available for
> > > the validator configuration files.  Would it be
> > > possible to create such
> > > things (in conf/share) so that the corresponding XML
> > > files can refer to
> > > them?
> > >
> > > If you're not real comfortable with all the syntax
> > > quirks of DTDs, I'd be
> > > happy to just take an informal description of the
> > > elements and attributes
> > > that are supported, and turn that into a DTD like
> > > the one for
> > > struts-config.
> > >
> > > Craig
> > >
> > >
> > >
> > > --
> > > To unsubscribe, e-mail:
> > > 
> > > For additional commands, e-mail:
> > > 
> > >
> >
> >
> > __
> > Do You Yahoo!?
> > Sign up for SBC Yahoo! Dial - First Month Free
> > http://sbc.yahoo.com
> >
> > --
> > To unsubscribe, e-mail:
> 
> For additional commands, e-mail:
> 
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 

-- Ted Husted, Husted dot Com, Fairport NY US
-- Java Web Development with Struts
-- Tel: +1 585 737-3463
-- Web: http://husted.com/about/services

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: DTDs for Validator Configuration Files

2002-07-10 Thread Byrne, Steven

Take those DTDs with a hefty grain of salt.  I think it would be *FAR*
better to derive them by looking at the digester code and the associated
attribute sets.  If it would be of help, I can do this by the end of
this week.

Steve

> -Original Message-
> From: James Holmes [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, July 10, 2002 9:30 AM
> To: Struts Developers List
> Subject: Re: DTDs for Validator Configuration Files
> 
> 
> Thanks for bringing light to this Craig.  I brought
> this up awhile back and got no response.  There has
> been some discussion on the Users' list as well about
> this.  A couple of the people on the Users' list have
> posted tools generated DTDs.  I'll forward those
> messages to the dev list and that should get us
> rolling. I'm happy to help as well.
> 
> I plan to add support for the Validator config files
> to Struts Console once there is a DTD.  Just as there
> is now Tiles config file support in Struts Console.
> 
> -james
> [EMAIL PROTECTED]
> http://www.jamesholmes.com/struts/
> 
> 
> --- "Craig R. McClanahan" <[EMAIL PROTECTED]> wrote:
> > (Primarily to David),
> > 
> > As Chuck points out in his new chapter, there are no
> > DTDs available for
> > the validator configuration files.  Would it be
> > possible to create such
> > things (in conf/share) so that the corresponding XML
> > files can refer to
> > them?
> > 
> > If you're not real comfortable with all the syntax
> > quirks of DTDs, I'd be
> > happy to just take an informal description of the
> > elements and attributes
> > that are supported, and turn that into a DTD like
> > the one for
> > struts-config.
> > 
> > Craig
> > 
> > 
> > 
> > --
> > To unsubscribe, e-mail:  
> > 
> > For additional commands, e-mail:
> > 
> > 
> 
> 
> __
> Do You Yahoo!?
> Sign up for SBC Yahoo! Dial - First Month Free
> http://sbc.yahoo.com
> 
> --
> To unsubscribe, e-mail:   

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 7751] - DynaValidatorForm throws NullPointerException and ClassCastException

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=7751

DynaValidatorForm throws NullPointerException and ClassCastException

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2002-07-10 18:38 ---
I have had the same problem, and Joe has right the dynamic="true" attribute on 
the form-bean element solves the issue. But I think it's a better solution if 
change some lines in the FormBeanConfig:

Index: FormBeanConfig.java
===
RCS file: /home/cvspublic/jakarta-
struts/src/share/org/apache/struts/config/FormBeanConfig.java,v
retrieving revision 1.6
diff -u -r1.6 FormBeanConfig.java
--- FormBeanConfig.java 9 Jul 2002 23:57:37 -   1.6
+++ FormBeanConfig.java 10 Jul 2002 18:34:57 -
@@ -152,8 +152,14 @@
 throw new IllegalStateException("Configuration is frozen");
 }
 this.type = type;
-if ("org.apache.struts.action.DynaActionForm".equals(type)) {
-this.dynamic = true;
+try {
+Class formClazz = Class.forName(type);
+Class dynaClazz = Class.forName
("org.apache.struts.action.DynaActionForm");
+if (dynaClazz.isAssignableFrom(formClazz)) {
+this.dynamic = true;
+}
+} catch (Exception e) {
+throw new IllegalArgumentException("Form type can't be found");
 }
 }

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Tiles DTD

2002-07-10 Thread Craig R. McClanahan



On Wed, 10 Jul 2002, James Holmes wrote:

> Date: Wed, 10 Jul 2002 10:49:35 -0700 (PDT)
> From: James Holmes <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: Tiles DTD
>
> While we're on the subject of DTDs I wanted to propose
> that we rename the Tiles DTD from tiles-config.dtd to
> tiles-config_1_1.dtd to be consistent.  Now that Tiles
> is in the core I think there should be a distinction
> between versions of the DTDs.  Already the Tiles DTD
> has more than one *deprecated* elements and/or
> attributes.
>
> Thoughts?
>

+1.  We should leave the existing one there, though, for backwards
compatibility.

> -james
> [EMAIL PROTECTED]
> http://www.jamesholmes.com/struts/
>

Craig


> __
> Do You Yahoo!?
> Sign up for SBC Yahoo! Dial - First Month Free
> http://sbc.yahoo.com
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Tiles DTD

2002-07-10 Thread James Holmes

While we're on the subject of DTDs I wanted to propose
that we rename the Tiles DTD from tiles-config.dtd to
tiles-config_1_1.dtd to be consistent.  Now that Tiles
is in the core I think there should be a distinction
between versions of the DTDs.  Already the Tiles DTD
has more than one *deprecated* elements and/or
attributes.

Thoughts?

-james
[EMAIL PROTECTED]
http://www.jamesholmes.com/struts/

__
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/conf/share validation_1_1.dtd validator-rules_1_1.dtd

2002-07-10 Thread craigmcc

craigmcc2002/07/10 10:32:58

  Added:   conf/share validation_1_1.dtd validator-rules_1_1.dtd
  Log:
  Initial checkin of DTDs for the two validator configuration files.  They are
  not yet referenced by the validator-rules.xml file, or the validation.xml file
  of the example app -- want to make sure they are correct first.  They also
  need to be propogated to the Struts website (which will happen automatically
  the next time someone uploads the struts-documentation webapp to the site.
  
  Now if someone would take the time to fill in the documentation inside the
  file, the way it is for struts-config_1_1.dtd, that would be great ...
  
  Revision  ChangesPath
  1.1  jakarta-struts/conf/share/validation_1_1.dtd
  
  Index: validation_1_1.dtd
  ===
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  1.1  jakarta-struts/conf/share/validator-rules_1_1.dtd
  
  Index: validator-rules_1_1.dtd
  ===
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Fwd: RE: Struts Validator DTD?

2002-07-10 Thread James Holmes


Note: forwarded message attached.


__
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com
--- Begin Message ---

Here's rules reverse engineered by NetBeans from the examples.

--Michael Marrotte

-Original Message-
From: Byrne, Steven [mailto:[EMAIL PROTECTED]]
Sent: Thursday, June 06, 2002 7:22 PM
To: [EMAIL PROTECTED]
Subject: Struts Validator DTD?


Is there a DTD (or schema) anywhere for the validation rule XML that's
accepted by the Struts Validator system?  I know it's using Digester to
parse the rule definitions, but I was hoping for a more
concrete/upleveled definition of the accepted syntax than the
operational one defined by the parsing code.

Thanks!

Steve



validator-rules.dtd
Description: Binary data


validation.dtd
Description: Binary data

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 
--- End Message ---

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


Fwd: Validation DTD (was R: DTD Question - SIMPLE SOLUTION)

2002-07-10 Thread James Holmes


Note: forwarded message attached.


__
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com
--- Begin Message ---


Hi all,
by the way last night I wrote down the DTDs for validation.xml
and validator-rules.xml

Hope it might help (well I'm not even sure I've written down right...)

bye,
d.rizzi


-Messaggio originale-
Da: Emaho, Ghoot [mailto:[EMAIL PROTECTED]]
Inviato: venerdì 31 maggio 2002 12.03
A: Struts Users Mailing List
Oggetto: RE: DTD Question - SIMPLE SOLUTION


A simple way of bypassing the need to access the DTD externally (as the
Struts 'automatic' resolution within the jar does NOT always work - see mail
archives) is to change the DOCTYPE def to something like the following:



where the dtd directory is a subdirectory of your WEB-INF directory. Copy
the web_app dtd into that directory and it will be found there. Nice and
simple.

NOTE it is still defined as 'PUBLIC'. There have been other posts about
using the 'SYSTEM' definition and looking locally, but this doesnt always
work - depending on which server/setup you have.

However, the suggested method works all the time and on as many different
environments as I've tried it.

Cheers

Ghoot Emaho

Lead Architect
Petrotechnics Ltd

> -Original Message-
> From: Struts Newsgroup (@Basebeans.com) [mailto:[EMAIL PROTECTED]]
> Sent: 30 May 2002 20:40
> To: [EMAIL PROTECTED]
> Subject: DTD Question
>
>
> Subject: DTD Question
> From: "Adam Cohen" <[EMAIL PROTECTED]>
>  ===
> I'm working on a web-app that is on a server that has no
> access to the web
> on port 80.
> When web.xml tries to get the dtd:
>  Application
> 2.2//EN" "http://java.sun.com/j2ee/dtds/web-app_2_2.dtd";>
> The server waits for a long time for the request to time out.
> I don't want to hard code a local path to the dtd and the
> server can't get
> accss to the web.
> Is there a better way to do?
> Thanks, Adam
>
>
>
> --
> To unsubscribe, e-mail:
> 
> For additional commands, e-mail:
> 
>
>

--
To unsubscribe, e-mail:

For additional commands, e-mail:





xml.zip
Description: Zip compressed data

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 
--- End Message ---

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


Re: DTDs for Validator Configuration Files

2002-07-10 Thread James Holmes

Thanks for bringing light to this Craig.  I brought
this up awhile back and got no response.  There has
been some discussion on the Users' list as well about
this.  A couple of the people on the Users' list have
posted tools generated DTDs.  I'll forward those
messages to the dev list and that should get us
rolling. I'm happy to help as well.

I plan to add support for the Validator config files
to Struts Console once there is a DTD.  Just as there
is now Tiles config file support in Struts Console.

-james
[EMAIL PROTECTED]
http://www.jamesholmes.com/struts/


--- "Craig R. McClanahan" <[EMAIL PROTECTED]> wrote:
> (Primarily to David),
> 
> As Chuck points out in his new chapter, there are no
> DTDs available for
> the validator configuration files.  Would it be
> possible to create such
> things (in conf/share) so that the corresponding XML
> files can refer to
> them?
> 
> If you're not real comfortable with all the syntax
> quirks of DTDs, I'd be
> happy to just take an informal description of the
> elements and attributes
> that are supported, and turn that into a DTD like
> the one for
> struts-config.
> 
> Craig
> 
> 
> 
> --
> To unsubscribe, e-mail:  
> 
> For additional commands, e-mail:
> 
> 


__
Do You Yahoo!?
Sign up for SBC Yahoo! Dial - First Month Free
http://sbc.yahoo.com

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DTDs for Validator Configuration Files

2002-07-10 Thread Craig R. McClanahan

(Primarily to David),

As Chuck points out in his new chapter, there are no DTDs available for
the validator configuration files.  Would it be possible to create such
things (in conf/share) so that the corresponding XML files can refer to
them?

If you're not real comfortable with all the syntax quirks of DTDs, I'd be
happy to just take an informal description of the elements and attributes
that are supported, and turn that into a DTD like the one for
struts-config.

Craig



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: TR: Struts dependencies

2002-07-10 Thread Craig R. McClanahan



On Wed, 10 Jul 2002, Arnaud HERITIER wrote:

> Date: Wed, 10 Jul 2002 14:08:46 +0200
> From: Arnaud HERITIER <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>,
>  [EMAIL PROTECTED]
> To: "Struts-Dev (E-mail)" <[EMAIL PROTECTED]>
> Subject: TR: Struts dependencies
>
>
>
> -Message d'origine-
> De : David Mulligan [mailto:[EMAIL PROTECTED]]
> Envoyé : mercredi 10 juillet 2002 14:09
> À : 'Struts Users Mailing List'
> Objet : RE: Struts dependencies
>
>
> I'm wondering the same!
>
> Would it be possible to name the jar files like so
>
> commons-beanutils-1.4.jar
> commons-collections-2.0.jar
> commons-digester-1.3.jar
> commons-logging-1.0.1.jar
> commons-pool-1.0.jar
> struts-1.1-b1.jar
> etc?
>

Putting version numbers in JAR file names has been the topic of raging
debate over the years, and there is not likely to ever be consensus.  What
there *is* consensus on, though, is a META-INF/MANIFEST.MF file that
contains correct versioning information so that you, and more importantly
build tools (like Maven) can tell what versions of what packages are
inside the JAR.

> I know this isn't a struts problem and it would be a bad idea for the struts
>
> team to start renaming the jar files from other Jakarta projects. But would
> it be possible for all Jakarta projects to follow this standard? That would
> make my and I'm sure a lot of other people's lives easier.
>
> Is this a bad idea, if so why?
> I know it would make the creation of build scripts a little harder, but it
> would still be possible to create them.
>
> The other option is the META-INF/MANIFEST.MF file.
> Most jar files contain there version number in them but not all.
> For example Version 2.0 of commons-collections.jar manifest file contains
> 'Implementation-Version: 1.1-dev' and not 'Implementation-Version: 2.0'
>

That sounds like a bug that should be reported against
commons-collections.  Could you please file a bug report?

  http://nagoya.apache.org/bugzilla/

> While struts.jar version 1.1-b1 contains 'Implementation-Vendor: Apache
> Software Foundation'
> Would it be possible to enforce this a bit more?
>

What should be enforced about "Implementation-Vendor"?  If you mean just
putting this line in, the best way to make that happen is to file bugs
against the offending packages.

> Just me 2 (euro) cents.
>

Craig


>
> -Original Message-
> From: Arnaud HERITIER [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, July 10, 2002 12:33 PM
> To: Struts-Dev (E-mail); Struts Users Mailing List (E-mail)
> Subject: Struts dependencies
>
>
> Hi guys.
>
> I downloaded the last nighty build of struts.
>
> I would like to know which releases of external libraries are packaged with
> it.
>
> I already uses some libraries of jakarta commons and I would like to know
> which one I need to upgrade.
>
> After studying the manifest of jars I listed this :
>
> commons-beanutils : 1.4 dev
> commons-collections : 2.0
> commons-dbcp : unknown (last dev I suppose)
> commons-digester : 1.3 dev
> commons-logging : 1.0.1 dev
> commons-pool : 1.0
> commons-services : 1.0 dev (can't find it on the jakarta site. What it is
> ??)
> commons-validator : unknown (last dev)
> jakarta-oro : unknown
>
> Can you confirm my assumptions.
>
> Are all jars usefull for struts or are there some of them used by some
> extensions like tiles, .. ???
>
> Thanks a lot.
>   Arnaud HERITIER
>   EAI Consulting
>   Sopra Group
>   Tél. : +33 (0)1 53 33 44 74
>   email : [EMAIL PROTECTED]
>
>   Ce message est exclusivement destiné aux personnes dont le nom figure
> ci-dessus. Il peut contenir des informations confidentielles dont la
> divulgation est à ce titre rigoureusement interdite. Dans l'hypothèse où
> vous avez reçu ce message par erreur, merci de le renvoyer à l'adresse
> e-mail ci-dessus et de détruire toute copie.
>
>   This message may contain confidential and proprietary material for the
> sole use of the intended recipient. Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact
> the sender and delete all copies.
>
>
> --
> To unsubscribe, e-mail:
> 
> For additional commands, e-mail:
> 
>
>
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 
>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Struts dependencies

2002-07-10 Thread Craig R. McClanahan

Nightly builds of Struts are always compiled from the latest source code
in CVS -- both for Struts itself and for all of the commons-x
dependencies.  There are definitely features and bugfixes in the commons
libraries that the current code in Struts depends on.  The only exception
for Apache code dependencies is ORO, where I'm packaging version 2.0.6.

At release time, we'll also do corresponding releases of stable versions
of the commons libraries we utilize.

By the way, commons-services is in the jakarta-commons-sandbox repository.
Nightly builds are available at:

  http://jakarta.apache.org/builds/jakarta-commons/nightly/commons-services/

By the way, a standard convention on most Apache library JARs is to
include versioning information in the META-INF/MANIFEST.MF file, so that
you (and tools) can determine which version is present.

Craig


On Wed, 10 Jul 2002, Arnaud HERITIER wrote:

> Date: Wed, 10 Jul 2002 13:33:02 +0200
> From: Arnaud HERITIER <[EMAIL PROTECTED]>
> Reply-To: Struts Users Mailing List <[EMAIL PROTECTED]>,
>  [EMAIL PROTECTED]
> To: "Struts-Dev (E-mail)" <[EMAIL PROTECTED]>,
>  "Struts Users Mailing List (E-mail)" <[EMAIL PROTECTED]>
> Subject: Struts dependencies
>
> Hi guys.
>
> I downloaded the last nighty build of struts.
>
> I would like to know which releases of external libraries are packaged with
> it.
>
> I already uses some libraries of jakarta commons and I would like to know
> which one I need to upgrade.
>
> After studying the manifest of jars I listed this :
>
> commons-beanutils : 1.4 dev
> commons-collections : 2.0
> commons-dbcp : unknown (last dev I suppose)
> commons-digester : 1.3 dev
> commons-logging : 1.0.1 dev
> commons-pool : 1.0
> commons-services : 1.0 dev (can't find it on the jakarta site. What it is
> ??)
> commons-validator : unknown (last dev)
> jakarta-oro : unknown
>
> Can you confirm my assumptions.
>
> Are all jars usefull for struts or are there some of them used by some
> extensions like tiles, .. ???
>
> Thanks a lot.
>   Arnaud HERITIER
>   EAI Consulting
>   Sopra Group
>   Tél. : +33 (0)1 53 33 44 74
>   email : [EMAIL PROTECTED]
>
>   Ce message est exclusivement destiné aux personnes dont le nom figure
> ci-dessus. Il peut contenir des informations confidentielles dont la
> divulgation est à ce titre rigoureusement interdite. Dans l'hypothèse où
> vous avez reçu ce message par erreur, merci de le renvoyer à l'adresse
> e-mail ci-dessus et de détruire toute copie.
>
>   This message may contain confidential and proprietary material for the
> sole use of the intended recipient. Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact
> the sender and delete all copies.
>
>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10622] - Problem with nested iterate tags

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10622

Problem with nested iterate tags





--- Additional Comments From [EMAIL PROTECTED]  2002-07-10 16:02 ---
This is likely to be a Tomcat 4.1.7 issue, rather than Struts; but I'm leaving
it classified here for the moment.  Would it be possible for you to test your
code against Tomcat 4.0.4 as well?  The reason this matters is that 4.1.x uses a
new JSP page compiler, which might still have bugs in the code that it generates.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: cvs commit: jakarta-struts/src/share/org/apache/struts/utilR equestUtils.java

2002-07-10 Thread Martin Cooper

This change undoes a change made by Craig to fix Bugzilla #10534 last
Sunday. It looks like we need a different way to fix both Bugzilla #10534
and Tiles...

--
Martin Cooper

> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, July 10, 2002 7:57 AM
> To: [EMAIL PROTECTED]
> Subject: cvs commit: jakarta-struts/src/share/org/apache/struts/util
> RequestUtils.java
> 
> 
> cedric  2002/07/10 07:57:10
> 
>   Modified:src/share/org/apache/struts/util RequestUtils.java
>   Log:
>   Remove the automatic '/' prefixing in forwardURL(). This 
> systematic prefixing
>   forbids the use of Tiles definition name as path in forward.
>   It is the user responsability to put the '/' before an URL.
>   
>   Revision  ChangesPath
>   1.47  +10 -4 
> jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java
>   
>   Index: RequestUtils.java
>   ===
>   RCS file: 
> /home/cvs/jakarta-struts/src/share/org/apache/struts/util/Requ
> estUtils.java,v
>   retrieving revision 1.46
>   retrieving revision 1.47
>   diff -u -r1.46 -r1.47
>   --- RequestUtils.java   10 Jul 2002 00:00:19 -  1.46
>   +++ RequestUtils.java   10 Jul 2002 14:57:10 -  1.47
>   @@ -1191,9 +1191,11 @@
>// Handle a ForwardConfig marked as context relative
>StringBuffer sb = new StringBuffer();
>if (forward.getContextRelative()) {
>   +/* Disabled to let Tiles definition names unchanged !
>if (!path.startsWith("/")) {
>sb.append("/");
>}
>   +*/
>sb.append(path);
>return (sb.toString());
>}
>   @@ -1206,9 +1208,11 @@
>if (forwardPattern == null) {
>// Performance optimization for previous 
> default behavior
>sb.append(appConfig.getPrefix());
>   +/* Disabled to let Tiles definition names unchanged !
>if (!path.startsWith("/")) {
>sb.append("/");
>}
>   +*/
>sb.append(path);
>} else {
>boolean dollar = false;
>   @@ -1220,9 +1224,11 @@
>sb.append(appConfig.getPrefix());
>break;
>case 'P':
>   +/* Disabled to let Tiles 
> definition names unchanged !
>if (!path.startsWith("/")) {
>sb.append("/");
>}
>   +*/
>sb.append(path);
>break;
>case '$':
>   
>   
>   
> 
> --
> To unsubscribe, e-mail:   
> 
> For additional commands, e-mail: 
> 
> 
> 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java

2002-07-10 Thread cedric

cedric  2002/07/10 07:57:10

  Modified:src/share/org/apache/struts/util RequestUtils.java
  Log:
  Remove the automatic '/' prefixing in forwardURL(). This systematic prefixing
  forbids the use of Tiles definition name as path in forward.
  It is the user responsability to put the '/' before an URL.
  
  Revision  ChangesPath
  1.47  +10 -4 
jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java
  
  Index: RequestUtils.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java,v
  retrieving revision 1.46
  retrieving revision 1.47
  diff -u -r1.46 -r1.47
  --- RequestUtils.java 10 Jul 2002 00:00:19 -  1.46
  +++ RequestUtils.java 10 Jul 2002 14:57:10 -  1.47
  @@ -1191,9 +1191,11 @@
   // Handle a ForwardConfig marked as context relative
   StringBuffer sb = new StringBuffer();
   if (forward.getContextRelative()) {
  +/* Disabled to let Tiles definition names unchanged !
   if (!path.startsWith("/")) {
   sb.append("/");
   }
  +*/
   sb.append(path);
   return (sb.toString());
   }
  @@ -1206,9 +1208,11 @@
   if (forwardPattern == null) {
   // Performance optimization for previous default behavior
   sb.append(appConfig.getPrefix());
  +/* Disabled to let Tiles definition names unchanged !
   if (!path.startsWith("/")) {
   sb.append("/");
   }
  +*/
   sb.append(path);
   } else {
   boolean dollar = false;
  @@ -1220,9 +1224,11 @@
   sb.append(appConfig.getPrefix());
   break;
   case 'P':
  +/* Disabled to let Tiles definition names unchanged !
   if (!path.startsWith("/")) {
   sb.append("/");
   }
  +*/
   sb.append(path);
   break;
   case '$':
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-struts/src/share/org/apache/struts/action ActionServlet.java

2002-07-10 Thread cedric

cedric  2002/07/10 07:52:46

  Modified:src/share/org/apache/struts/action ActionServlet.java
  Log:
  Minor modifications to facilitate TilesPlugin initialization :
   - Let propagate ServletException from initApplicationPlugin(). Such exception can 
be thrown
 by plugin initialization.
   - Make plugin configurations list available before plugin initializations. This 
allows
 a plugin to find its original configuration object.
   - Freeze AppConfig objects AFTER plugin initialization. This let a chance to plugin
 to change a particular configuration. Tiles use this to set the request processor
from the tiles plugin.
  
  Revision  ChangesPath
  1.114 +14 -7 
jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java
  
  Index: ActionServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/action/ActionServlet.java,v
  retrieving revision 1.113
  retrieving revision 1.114
  diff -u -r1.113 -r1.114
  --- ActionServlet.java9 Jul 2002 23:57:05 -   1.113
  +++ ActionServlet.java10 Jul 2002 14:52:46 -  1.114
  @@ -448,6 +448,7 @@
   initApplicationMessageResources(ac);
   initApplicationDataSources(ac);
   initApplicationPlugIns(ac);
  +ac.freeze();
   Enumeration names = getServletConfig().getInitParameterNames();
   while (names.hasMoreElements()) {
   String name = (String) names.nextElement();
  @@ -460,6 +461,7 @@
   initApplicationMessageResources(ac);
   initApplicationDataSources(ac);
   initApplicationPlugIns(ac);
  +ac.freeze();
   }
   destroyConfigDigester();
   
  @@ -873,7 +875,7 @@
   }
   
   // Return the completed configuration object
  -config.freeze();
  +//config.freeze();  // Now done after plugins init
   return (config);
   
   }
  @@ -956,6 +958,9 @@
   
   PlugInConfig plugInConfigs[] = config.findPlugInConfigs();
   PlugIn plugIns[] = new PlugIn[plugInConfigs.length];
  +
  +getServletContext().setAttribute
  +(Action.PLUG_INS_KEY + config.getPrefix(), plugIns);
   for (int i = 0; i < plugIns.length; i++) {
   try {
   plugIns[i] = (PlugIn)
  @@ -964,14 +969,16 @@
   BeanUtils.populate(plugIns[i],
  plugInConfigs[i].getProperties());
   plugIns[i].init(this, config);
  +} catch (ServletException e) {
  +  // Lets propagate
  +throw e;
   } catch (Exception e) {
  +e.printStackTrace();
   throw new UnavailableException
   (internal.getMessage("plugIn.init",
plugInConfigs[i].getClassName()));
   }
   }
  -getServletContext().setAttribute
  -(Action.PLUG_INS_KEY + config.getPrefix(), plugIns);
   
   
   }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 10641] New: - IncludeAction should unwrap request if it is a MultipartRequestWrapper

2002-07-10 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10641

IncludeAction should unwrap request if it is a MultipartRequestWrapper

   Summary: IncludeAction should unwrap request if it is a
MultipartRequestWrapper
   Product: Struts
   Version: 1.0.2 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Standard Actions
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


IncludeAction should unwrap the request if it is a MultipartRequestWrapper
before doing the include in line 161:

 // Forward control to the specified resource
 rd.include(request, response);

In the same way that ActionServlet does in processInclude, line 1878

//unwrap the multipart request if there is one
if (request instanceof MultipartRequestWrapper) {
request = ((MultipartRequestWrapper) request).getRequest();
}

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




TR: Struts dependencies

2002-07-10 Thread Arnaud HERITIER



-Message d'origine-
De : David Mulligan [mailto:[EMAIL PROTECTED]]
Envoyé : mercredi 10 juillet 2002 14:09
À : 'Struts Users Mailing List'
Objet : RE: Struts dependencies


I'm wondering the same!

Would it be possible to name the jar files like so

commons-beanutils-1.4.jar
commons-collections-2.0.jar
commons-digester-1.3.jar
commons-logging-1.0.1.jar
commons-pool-1.0.jar
struts-1.1-b1.jar
etc?

I know this isn't a struts problem and it would be a bad idea for the struts

team to start renaming the jar files from other Jakarta projects. But would
it be possible for all Jakarta projects to follow this standard? That would
make my and I'm sure a lot of other people's lives easier.

Is this a bad idea, if so why?
I know it would make the creation of build scripts a little harder, but it
would still be possible to create them.

The other option is the META-INF/MANIFEST.MF file.
Most jar files contain there version number in them but not all.
For example Version 2.0 of commons-collections.jar manifest file contains
'Implementation-Version: 1.1-dev' and not 'Implementation-Version: 2.0'

While struts.jar version 1.1-b1 contains 'Implementation-Vendor: Apache
Software Foundation'
Would it be possible to enforce this a bit more?

Just me 2 (euro) cents.


-Original Message-
From: Arnaud HERITIER [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, July 10, 2002 12:33 PM
To: Struts-Dev (E-mail); Struts Users Mailing List (E-mail)
Subject: Struts dependencies


Hi guys.

I downloaded the last nighty build of struts.

I would like to know which releases of external libraries are packaged with
it.

I already uses some libraries of jakarta commons and I would like to know
which one I need to upgrade.

After studying the manifest of jars I listed this :

commons-beanutils : 1.4 dev
commons-collections : 2.0
commons-dbcp : unknown (last dev I suppose)
commons-digester : 1.3 dev
commons-logging : 1.0.1 dev
commons-pool : 1.0
commons-services : 1.0 dev (can't find it on the jakarta site. What it is
??)
commons-validator : unknown (last dev)
jakarta-oro : unknown

Can you confirm my assumptions.

Are all jars usefull for struts or are there some of them used by some
extensions like tiles, .. ???

Thanks a lot.
  Arnaud HERITIER
  EAI Consulting
  Sopra Group
  Tél. : +33 (0)1 53 33 44 74
  email : [EMAIL PROTECTED]

  Ce message est exclusivement destiné aux personnes dont le nom figure
ci-dessus. Il peut contenir des informations confidentielles dont la
divulgation est à ce titre rigoureusement interdite. Dans l'hypothèse où
vous avez reçu ce message par erreur, merci de le renvoyer à l'adresse
e-mail ci-dessus et de détruire toute copie.

  This message may contain confidential and proprietary material for the
sole use of the intended recipient. Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact
the sender and delete all copies.


--
To unsubscribe, e-mail:

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Struts dependencies

2002-07-10 Thread Arnaud HERITIER

Hi guys.

I downloaded the last nighty build of struts.

I would like to know which releases of external libraries are packaged with
it.

I already uses some libraries of jakarta commons and I would like to know
which one I need to upgrade.

After studying the manifest of jars I listed this :

commons-beanutils : 1.4 dev
commons-collections : 2.0
commons-dbcp : unknown (last dev I suppose)
commons-digester : 1.3 dev
commons-logging : 1.0.1 dev
commons-pool : 1.0
commons-services : 1.0 dev (can't find it on the jakarta site. What it is
??)
commons-validator : unknown (last dev)
jakarta-oro : unknown

Can you confirm my assumptions.

Are all jars usefull for struts or are there some of them used by some
extensions like tiles, .. ???

Thanks a lot.
  Arnaud HERITIER
  EAI Consulting
  Sopra Group
  Tél. : +33 (0)1 53 33 44 74
  email : [EMAIL PROTECTED]

  Ce message est exclusivement destiné aux personnes dont le nom figure
ci-dessus. Il peut contenir des informations confidentielles dont la
divulgation est à ce titre rigoureusement interdite. Dans l'hypothèse où
vous avez reçu ce message par erreur, merci de le renvoyer à l'adresse
e-mail ci-dessus et de détruire toute copie.

  This message may contain confidential and proprietary material for the
sole use of the intended recipient. Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact
the sender and delete all copies.