Re: Assistance cross-building Windows target

2021-10-29 Thread Dirk Hohndel via subsurface
OK, I quickly pulled together a Ubuntu 21.04 virtual machine here and tested 
this; below are working instructions that will create a Windows installer for 
you
You need at least 20G of disk for this - assuming a minimum VM install

sudo apt install docker.io  git
mkdir $HOME/windows
cd $HOME/windows
ln -s /win/mxe . # <- yes, this looks weird... it's a step that fails 
in the script for some reason... just trust me
git clone git://github.com/subsurface/subsurface 

sudo docker run -v $HOME/windows:/__w subsurface/mxe-build-container:2.2 
/bin/bash /__w/subsurface/packaging/windows/create-win-installer.sh -64only


Still interested in the answer to "what's your goal with all this?", though.

/D

> On Oct 29, 2021, at 12:30 PM, Steven Morlock wrote:
> 
> Dirk,
> 
> Thanks for your reply.  I tried to follow the instructions in 
> packaging/windows.  I will start with a fresh machine and try to follow them 
> again.
> 
> Regards 
> Steve
> On Oct 29, 2021, at 2:18 PM, Dirk Hohndel  > wrote:
> Well, the log shows me very little of the MXE build environment that you are 
> using. Based on the error I'm guessing that you are using a different 
> compiler than I am...
> There's a reason why I am making a docker container with all the right tools 
> available - it's incredibly painful to create a "known good" MXE build 
> environment.
> 
> Did you look at packaging/windows/README.md ? It turns out that those 
> instructions aren't 100% accurate, but they should have gotten you a lot 
> closer.
> 
> Of course, part of the question here is "what's your goal with all this"? 
> Because depending on what you are actually trying to do here, the setup you 
> want might be different.
> 
> /D 
> 
>> On Oct 29, 2021, at 3:58 AM, Steven Morlock via subsurface < 
>> subsurface@subsurface-divelog.org 
>> > wrote:
>> 
>> Howdy,
>> 
>>   I have been trying to unsuccessfully follow guidance on how to cross-build 
>> the Windows client.  I am running on a OSBoxes.org   
>> Ubuntu 21.04 virtual machine.  I have followed as best I could the 
>> instructions in 'subsurface/INSTALL' and 
>> 'subsurface/packaging/windows/mxe-based-build.sh'.  Could someone please 
>> review the enclosed 'winbuild.log' and suggest where I may have gone wrong.
>> 
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Assistance cross-building Windows target

2021-10-29 Thread Steven Morlock via subsurface
Dirk,

Thanks for your reply.  I tried to follow the instructions in 
packaging/windows.  I will start with a fresh machine and try to follow them 
again.

Regards
Steve


On Oct 29, 2021, 2:18 PM, at 2:18 PM, Dirk Hohndel  wrote:
>Well, the log shows me very little of the MXE build environment that
>you are using. Based on the error I'm guessing that you are using a
>different compiler than I am...
>There's a reason why I am making a docker container with all the right
>tools available - it's incredibly painful to create a "known good" MXE
>build environment.
>
>Did you look at packaging/windows/README.md ? It turns out that those
>instructions aren't 100% accurate, but they should have gotten you a
>lot closer.
>
>Of course, part of the question here is "what's your goal with all
>this"? Because depending on what you are actually trying to do here,
>the setup you want might be different.
>
>/D
>
>> On Oct 29, 2021, at 3:58 AM, Steven Morlock via subsurface
> wrote:
>>
>> Howdy,
>>
>>   I have been trying to unsuccessfully follow guidance on how to
>cross-build the Windows client.  I am running on a OSBoxes.org Ubuntu
>21.04 virtual machine.  I have followed as best I could the
>instructions in 'subsurface/INSTALL' and
>'subsurface/packaging/windows/mxe-based-build.sh'.  Could someone
>please review the enclosed 'winbuild.log' and suggest where I may have
>gone wrong.
>>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Assistance cross-building Windows target

2021-10-29 Thread Thiago Macieira via subsurface
On Friday, 29 October 2021 03:58:03 PDT Steven Morlock via subsurface wrote:
> Howdy,
>   I have been trying to unsuccessfully follow guidance on how to cross-build
> the Windows client.  I am running on a OSBoxes.org Ubuntu 21.04 virtual
> machine.  I have followed as best I could the instructions in
> 'subsurface/INSTALL' and
> 'subsurface/packaging/windows/mxe-based-build.sh'.  Could someone please
> review the enclosed 'winbuild.log' and suggest where I may have gone wrong.
> Thanks,Steve

Hello Steve

statsview.h:187:21: error: missing template arguments before '(' token
  return ChartItemPtr(new T(*this, std::forward(args)...));

"missing template arguments" indicates the code is using template parameter 
deduction, which is a C++17 feature. 

statscolors.h:8:46: error: 'backgroundColor' declared as an 'inline' variable
 inline const QColor backgroundColor(Qt::white);

inline variables are a C++17 feature too.

barseries.cpp:93:14: error: expected unqualified-id before '[' token
   for (auto &[dives, label]: item.items) {
  ^

And this is the syntax for structured bindings, another C++17 feature.

Looks like your issue is that Subsurface is not being compiled as C++17. That 
means your compiler is old. Whether adding the "-std=c++17" / "-std=gnu++17" 
option would help you or not, I don't know. Recommendation: upgrade your 
MinGW's GCC.

PS: looks like Subsurface is using more C++17 features than my own code!
-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel DPG Cloud Engineering



___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Assistance cross-building Windows target

2021-10-29 Thread Dirk Hohndel via subsurface
Well, the log shows me very little of the MXE build environment that you are 
using. Based on the error I'm guessing that you are using a different compiler 
than I am...
There's a reason why I am making a docker container with all the right tools 
available - it's incredibly painful to create a "known good" MXE build 
environment.

Did you look at packaging/windows/README.md ? It turns out that those 
instructions aren't 100% accurate, but they should have gotten you a lot closer.

Of course, part of the question here is "what's your goal with all this"? 
Because depending on what you are actually trying to do here, the setup you 
want might be different.

/D

> On Oct 29, 2021, at 3:58 AM, Steven Morlock via subsurface 
>  wrote:
> 
> Howdy,
> 
>   I have been trying to unsuccessfully follow guidance on how to cross-build 
> the Windows client.  I am running on a OSBoxes.org Ubuntu 21.04 virtual 
> machine.  I have followed as best I could the instructions in 
> 'subsurface/INSTALL' and 'subsurface/packaging/windows/mxe-based-build.sh'.  
> Could someone please review the enclosed 'winbuild.log' and suggest where I 
> may have gone wrong.
> 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface