Re: Switching to Qt 5.10

2017-12-08 Thread Lubomir I. Ivanov
On 8 December 2017 at 17:00, Thiago Macieira  wrote:
> On sexta-feira, 8 de dezembro de 2017 05:49:34 PST Dirk Hohndel wrote:
>> > On Dec 8, 2017, at 7:46 AM, Thiago Macieira  wrote:
>> >
>> > On Friday, 8 December 2017 03:21:04 PST Dirk Hohndel wrote:
>> >> Actually, I just wanted to switch to Qt 5.10 and start testing with that.
>> >
>> > Please note that 5.10.0 has problems renaming files on Android, due to an
>> > unexpected SELinux rule. I advise to wait for 5.10.1.
>>
>> Thank you for that warning!
>>
>> I started looking at 5.10.0 for iOS, haven't even looked at Android, yet.
>> I will hold off. Is there an ETA for 5.10.1 (since that's a pretty
>> catastrophic bug)?
>
> I don't know if Subsurface uses Qt for renaming files. It doesn't affect
> QTemporaryFile, QSaveFile and QSettings, though.
>
> 5.10.1 should be out just after new years.
>

i don't think we have QFile::rename() anywhere.
we do use the  (_w)rename() which is wrapped around
"subsurface_rename()" and defined in the platform files - linux.c,
windows.c, etc.

on Android the  rename() is linked against, and possibly
called by subsurface_rename() in core/save-xml.c.
so this shouldn't be a problem unless the standard library rename() on
Android is broken too.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Switching to Qt 5.10

2017-12-08 Thread Thiago Macieira
On sexta-feira, 8 de dezembro de 2017 05:49:34 PST Dirk Hohndel wrote:
> > On Dec 8, 2017, at 7:46 AM, Thiago Macieira  wrote:
> > 
> > On Friday, 8 December 2017 03:21:04 PST Dirk Hohndel wrote:
> >> Actually, I just wanted to switch to Qt 5.10 and start testing with that.
> > 
> > Please note that 5.10.0 has problems renaming files on Android, due to an
> > unexpected SELinux rule. I advise to wait for 5.10.1.
> 
> Thank you for that warning!
> 
> I started looking at 5.10.0 for iOS, haven't even looked at Android, yet.
> I will hold off. Is there an ETA for 5.10.1 (since that's a pretty
> catastrophic bug)?

I don't know if Subsurface uses Qt for renaming files. It doesn't affect 
QTemporaryFile, QSaveFile and QSettings, though.

5.10.1 should be out just after new years.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Switching to Qt 5.10

2017-12-08 Thread Dirk Hohndel

> On Dec 8, 2017, at 7:46 AM, Thiago Macieira  wrote:
> 
> On Friday, 8 December 2017 03:21:04 PST Dirk Hohndel wrote:
>> Actually, I just wanted to switch to Qt 5.10 and start testing with that.
> 
> Please note that 5.10.0 has problems renaming files on Android, due to an 
> unexpected SELinux rule. I advise to wait for 5.10.1.

Thank you for that warning!

I started looking at 5.10.0 for iOS, haven't even looked at Android, yet.
I will hold off. Is there an ETA for 5.10.1 (since that's a pretty catastrophic 
bug)?

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Switching to Qt 5.10

2017-12-08 Thread Thiago Macieira
On Friday, 8 December 2017 03:21:04 PST Dirk Hohndel wrote:
> Actually, I just wanted to switch to Qt 5.10 and start testing with that.

Please note that 5.10.0 has problems renaming files on Android, due to an 
unexpected SELinux rule. I advise to wait for 5.10.1.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Switching to Qt 5.10

2017-12-08 Thread Dirk Hohndel

> On Dec 8, 2017, at 5:21 AM, Dirk Hohndel  wrote:
> 
> 
> So with all the releases out of the door I figured it was time to break 
> things :-)
> 
> Actually, I just wanted to switch to Qt 5.10 and start testing with that. And 
> I notice that suddenly I can't read our buttons anymore.
> 
> 
> 
> that used to be white on blue. Anyone got an idea why this might have changed 
> with 5.10?
> Or am I seeing an effect of something else and am just not realizing it?

Oh, I should have mentioned that this is an iOS screen shot (sorry, should have 
scaled it)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface