Re: maps on iOS

[Philippe Massart]

Everything works nice for me. I don’t own (yet?) a BLE computer, so I cannot 
test computer data import.

Philippe

> Le 6 avr. 2018 à 21:58, Dirk Hohndel  a écrit :
> 
> Thanks to Murillo we finally have a working map module on iOS as well.
> If you are registered for TestFlight you should have received a notification.
> If you aren't (or didn't) and would like to play with this, please drop me a 
> line.
> 
> Overall iOS is still our smallest user group with the fewest people actively
> testing - so if you have access to an iOS device, I'd really appreciate some
> feedback.
> 
> Thanks
> 
> /D
> ___
> subsurface mailing list
> subsurface@subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: maps on iOS

[Dirk Hohndel]

> On Apr 9, 2018, at 10:45 AM, Hartley Horwitz  wrote:
> The map on iOS is working on my phone - at least the features I've tested:
> * opening a map, selecting satellite or map view
> * selecting a dive site and returning to the dive list - the selected dive is 
> chosen
> * changing zoom by gestures or using +/- icons
> * selecting a dive from the list, and choosing "Map It" icon
> 
> All my dives have GPS coordinates.  I tried adding a new dive without 
> coordinates and the "Map It" function is dimmed as expected.   I couldn't 
> figure out how to manually add the location using the map, but I didn't spend 
> long trying.

Thanks for testing and reporting. Really appreciated.

> Overall, things working well for me.  Thanks - the apps looks great. Now all 
> I need is a BT dive computer. 

And since you are testing on iOS, you actually need a supported BLE dive 
computer - that's even fewer to chose from.

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: maps on iOS

[Hartley Horwitz]

>
> -- Forwarded message --
> From: "Lubomir I. Ivanov" <neolit...@gmail.com>
> To: Miika Turkia <miika.tur...@gmail.com>
> Cc: Dirk Hohndel <d...@hohndel.org>, Subsurface Mailing List <
> subsurface@subsurface-divelog.org>
> Bcc:
> Date: Sat, 7 Apr 2018 22:58:00 +0300
> Subject: Re: maps on iOS
> On 7 April 2018 at 07:35, Miika Turkia <miika.tur...@gmail.com> wrote:
> > On Fri, Apr 6, 2018 at 10:58 PM, Dirk Hohndel <d...@hohndel.org> wrote:
> >>
> >> Thanks to Murillo we finally have a working map module on iOS as well.
> >
> >
> > Great!
> >
> >>
> >> If you are registered for TestFlight you should have received a
> >> notification.
> >> If you aren't (or didn't) and would like to play with this, please drop
> me
> >> a line.
> >>
> >> Overall iOS is still our smallest user group with the fewest people
> >> actively
> >> testing - so if you have access to an iOS device, I'd really appreciate
> >> some
> >> feedback.
> >
> >
> > Initially the map seems to be working OK. At least it shows the dive I
> have
> > chosen from dive list.
> >
> > It appears that one cannot choose location for a dive that does not
> contain
> > any GPS coordinates. Looking at options for a dive with coordinates, it
> > appears that this might not be supported on mobile at all.
> >
>
> i must admit that i didn't test adding GPS to a dive that doesn't have it.
>
> if editing coordinates from the dive details creates a `dive_site`
> object and adds it to the list of dive sites, then the map will create
> a marker for it once re-opened / reloaded. that's how the map backend
> works on desktop and mobile.
> editing the coordinates of a dive with GPS did work the last time i've
> checked.
>
> > I wonder if both the mapit icon and gps icon at the bottom are both
> > required. Maybe just getting rid of the button at the top right corner?
> >
>
> hmm, i'm not sure which one is the GPS icon.
> i was only using the "map it" button on top of the dive details to open
> the map.
>
> > How is the choosing of shown dive sites supposed to work? Does it make
> any
> > sense on mobile? I can highlight the dives shown on the map, but they
> don't
> > seem to be selected when I return to dive list. If there is no proper
> > need/use for choosing multiple dives on mobile then maybe disable this
> > options from the map. Or do we somehow support editing multiple dives on
> > mobile?
> >
>
> selecting multiple flags on the map or selecting multiple dives in the
> dive list is not possible on mobile.
> selecting a flag from the map should select a single dive from the
> dive list (latest dive on that dive site).
>
> maybe you found a bug, because at least a couple of people confirmed
> that the selection works when this was merged.
>
> lubomir
> --
>
> The map on iOS is working on my phone - at least the features I've tested:
* opening a map, selecting satellite or map view
* selecting a dive site and returning to the dive list - the selected dive
is chosen
* changing zoom by gestures or using +/- icons
* selecting a dive from the list, and choosing "Map It" icon

All my dives have GPS coordinates.  I tried adding a new dive without
coordinates and the "Map It" function is dimmed as expected.   I couldn't
figure out how to manually add the location using the map, but I didn't
spend long trying.

Overall, things working well for me.  Thanks - the apps looks great. Now
all I need is a BT dive computer.

...Hartley

I
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: maps on iOS

[Lubomir I. Ivanov]

On 8 April 2018 at 08:10, Miika Turkia  wrote:
> Sorry for missing quotes, but starting the mail from mobile to attach
> the screenshot failed to quote your text.
>
> Adding coordinates to the edit text field does work. However, I did
> not see a way to select a spot on the map.
>

yep, not possible.
this is a missing feature and i'm not sure we want it on mobile.

if we want it, we need to talk about the UX - i.e. how is this going to work.
then i need to find time to do it.

> The attached screenshot shows a location icon on the left side of
> action button. This takes one to the map just like the mapit button.
>

oh, i didn't even know such a button exists.

> You can select multiple flags using the upper right icon on the map
> window. Opens up a menu allowing to select visible dive locations
> (along with copying coordinates and opening google maps). Except now
> that I re-test it, it seems that only one flag is actually selected.
> So we should get rid of this particular menu item if it is not working
> and cannot be used.
>

that's a limitation on mobile - the action only selects a single dive
from the dive list (the most recent dive).
on desktop it selects all the dives in the dive list for the visible
dive markers.

arguably still usable on mobile.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Maps on iOS

[Miika Turkia]

On Sun, Apr 8, 2018 at 11:26 AM, tormento  wrote:

> I have just downloaded TestFlight version.
>
> I'd like to add a diving before importing the data from diving computer.
> Sometimes you are on the boat and want to add the diving with divemaster,
> buddy, etc and you do further editing/importing from diving computer at
> home. Is it possible?
>

Sure. Just insert the basic information on mobile on the boat and dives
will be automatically merged (at least should be) when you sync the DC
later on. Time and duration should be reasonably correct for this to work.

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Maps on iOS

[tormento]

I have just downloaded TestFlight version.

I'd like to add a diving before importing the data from diving computer.
Sometimes you are on the boat and want to add the diving with divemaster,
buddy, etc and you do further editing/importing from diving computer at
home. Is it possible?
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: maps on iOS

[Lubomir I. Ivanov]

On 7 April 2018 at 07:35, Miika Turkia  wrote:
> On Fri, Apr 6, 2018 at 10:58 PM, Dirk Hohndel  wrote:
>>
>> Thanks to Murillo we finally have a working map module on iOS as well.
>
>
> Great!
>
>>
>> If you are registered for TestFlight you should have received a
>> notification.
>> If you aren't (or didn't) and would like to play with this, please drop me
>> a line.
>>
>> Overall iOS is still our smallest user group with the fewest people
>> actively
>> testing - so if you have access to an iOS device, I'd really appreciate
>> some
>> feedback.
>
>
> Initially the map seems to be working OK. At least it shows the dive I have
> chosen from dive list.
>
> It appears that one cannot choose location for a dive that does not contain
> any GPS coordinates. Looking at options for a dive with coordinates, it
> appears that this might not be supported on mobile at all.
>

i must admit that i didn't test adding GPS to a dive that doesn't have it.

if editing coordinates from the dive details creates a `dive_site`
object and adds it to the list of dive sites, then the map will create
a marker for it once re-opened / reloaded. that's how the map backend
works on desktop and mobile.
editing the coordinates of a dive with GPS did work the last time i've checked.

> I wonder if both the mapit icon and gps icon at the bottom are both
> required. Maybe just getting rid of the button at the top right corner?
>

hmm, i'm not sure which one is the GPS icon.
i was only using the "map it" button on top of the dive details to open the map.

> How is the choosing of shown dive sites supposed to work? Does it make any
> sense on mobile? I can highlight the dives shown on the map, but they don't
> seem to be selected when I return to dive list. If there is no proper
> need/use for choosing multiple dives on mobile then maybe disable this
> options from the map. Or do we somehow support editing multiple dives on
> mobile?
>

selecting multiple flags on the map or selecting multiple dives in the
dive list is not possible on mobile.
selecting a flag from the map should select a single dive from the
dive list (latest dive on that dive site).

maybe you found a bug, because at least a couple of people confirmed
that the selection works when this was merged.

lubomir
--
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: maps on iOS

[Miika Turkia]

On Fri, Apr 6, 2018 at 10:58 PM, Dirk Hohndel  wrote:

> Thanks to Murillo we finally have a working map module on iOS as well.
>

Great!


> If you are registered for TestFlight you should have received a
> notification.
> If you aren't (or didn't) and would like to play with this, please drop me
> a line.
>
> Overall iOS is still our smallest user group with the fewest people
> actively
> testing - so if you have access to an iOS device, I'd really appreciate
> some
> feedback.
>

Initially the map seems to be working OK. At least it shows the dive I have
chosen from dive list.

It appears that one cannot choose location for a dive that does not contain
any GPS coordinates. Looking at options for a dive with coordinates, it
appears that this might not be supported on mobile at all.

I wonder if both the mapit icon and gps icon at the bottom are both
required. Maybe just getting rid of the button at the top right corner?

How is the choosing of shown dive sites supposed to work? Does it make any
sense on mobile? I can highlight the dives shown on the map, but they don't
seem to be selected when I return to dive list. If there is no proper
need/use for choosing multiple dives on mobile then maybe disable this
options from the map. Or do we somehow support editing multiple dives on
mobile?

BTW I had some trouble getting the iOS version working. I have used it
before but last 2-3 versions were asking for PIN code as if the
registration process was being done. I had to clear my credentials, quit
Subsurface, do magic dance, start Subsurface, insert credentials and then
with a couple of more twists I got the divelog synced. No wonder people
have been asking for missing PIN code if they have ended up in the same
state (Subsurface was claiming the PIN was sent)

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface