[sugar] Landing patches about the network devices UI
Hello, we have a couple of patches that should be ready to be reviewed by tomorrow, which solves several issues with the UI of network devices. #6944 UI confuses which AP you are connected to #3993 The color of network icon in Home view becomes white after restarting Sugar. #2866 Network Manager GUI doesn't report success or failure #6995 Add a mesh device to the frame and remove mesh devices from Neighborhood view The tickets are a little confusing, so let me summarize what the patches does: 1 Adds "IP address" to the mesh & wireless palettes, with associated changes to their model classes. 2 Removes the "Disconnect" or "Turn On/off" entries from the wireless/mesh palettes. 3 Makes both frame icons pulse. 4 Don't show the mesh icons in the mesh view, instead show them in the frame. 5 Fix some iconsistency in the icon states by cleaning up the code. mtd did quite a bit of testing on them already, but they are pretty invasive and there is some risk of regressions. My opinion is: 2 is controversial and should be left as is for 8.2 1, 5 are important and we should try to get them in. 4 would be nice to have but I don't consider it essential. 3 should be delayed unless it's small and it's easier to take it then to refactor patches. 1,3,5 has been submitted for review as patch A. 2, 4 will be submitted today as patch B. My suggestion would be: * Rip off 3 from patch A if it's worth it and land it for 8.2.0 (before Friday) * Do *not* land patch B for 8.2.0 mtd has some free time today, so if we can let him know what we want and don't want to land soon it would be great. Thanks, Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 14:19, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > Hello, > > we have a couple of patches that should be ready to be reviewed by > tomorrow, which solves several issues with the UI of network devices. > > #6944 UI confuses which AP you are connected to > #3993 The color of network icon in Home view becomes white after > restarting Sugar. > #2866 Network Manager GUI doesn't report success or failure > #6995 Add a mesh device to the frame and remove mesh devices from > Neighborhood view > > The tickets are a little confusing, so let me summarize what the patches does: > > 1 Adds "IP address" to the mesh & wireless palettes, with associated > changes to their model classes. > 2 Removes the "Disconnect" or "Turn On/off" entries from the > wireless/mesh palettes. > 3 Makes both frame icons pulse. > 4 Don't show the mesh icons in the mesh view, instead show them in the frame. > 5 Fix some iconsistency in the icon states by cleaning up the code. http://dev.laptop.org/ticket/6944#comment:5 suggests this may help for the "Neighborhood view shows my AP twice" bug, #7415. > mtd did quite a bit of testing on them already, but they are pretty > invasive and there is some risk of regressions. > > My opinion is: > > 2 is controversial and should be left as is for 8.2 > 1, 5 are important and we should try to get them in. > 4 would be nice to have but I don't consider it essential. > 3 should be delayed unless it's small and it's easier to take it then > to refactor patches. > > 1,3,5 has been submitted for review as patch A. 2, 4 will be submitted > today as patch B. My suggestion would be: > > * Rip off 3 from patch A if it's worth it and land it for 8.2.0 (before > Friday) > * Do *not* land patch B for 8.2.0 > > mtd has some free time today, so if we can let him know what we want > and don't want to land soon it would be great. > > Thanks, > Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
I agree with your assessment. Note that right now (8.2-756), the mesh icons don't show up on either the Neighborhood view or the Frame; that is clearly not a satisfactory situation. regards. -walter On Mon, Aug 25, 2008 at 8:19 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > Hello, > > we have a couple of patches that should be ready to be reviewed by > tomorrow, which solves several issues with the UI of network devices. > > #6944 UI confuses which AP you are connected to > #3993 The color of network icon in Home view becomes white after > restarting Sugar. > #2866 Network Manager GUI doesn't report success or failure > #6995 Add a mesh device to the frame and remove mesh devices from > Neighborhood view > > The tickets are a little confusing, so let me summarize what the patches does: > > 1 Adds "IP address" to the mesh & wireless palettes, with associated > changes to their model classes. > 2 Removes the "Disconnect" or "Turn On/off" entries from the > wireless/mesh palettes. > 3 Makes both frame icons pulse. > 4 Don't show the mesh icons in the mesh view, instead show them in the frame. > 5 Fix some iconsistency in the icon states by cleaning up the code. > > mtd did quite a bit of testing on them already, but they are pretty > invasive and there is some risk of regressions. > > My opinion is: > > 2 is controversial and should be left as is for 8.2 > 1, 5 are important and we should try to get them in. > 4 would be nice to have but I don't consider it essential. > 3 should be delayed unless it's small and it's easier to take it then > to refactor patches. > > 1,3,5 has been submitted for review as patch A. 2, 4 will be submitted > today as patch B. My suggestion would be: > > * Rip off 3 from patch A if it's worth it and land it for 8.2.0 (before > Friday) > * Do *not* land patch B for 8.2.0 > > mtd has some free time today, so if we can let him know what we want > and don't want to land soon it would be great. > > Thanks, > Marco > ___ > Sugar mailing list > Sugar@lists.laptop.org > http://lists.laptop.org/listinfo/sugar > ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 15:13, Walter Bender <[EMAIL PROTECTED]> wrote: > I agree with your assessment. Note that right now (8.2-756), the mesh > icons don't show up on either the Neighborhood view or the Frame; that > is clearly not a satisfactory situation. That seems to be a regression in the firmware, with the msh0 interface not coming up - not a sugar problem... Regards Morgan ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 8:19 AM, Marco Pesenti Gritti <[EMAIL PROTECTED]> wrote: > Hello, > > we have a couple of patches that should be ready to be reviewed by > tomorrow, which solves several issues with the UI of network devices. > > #6944 UI confuses which AP you are connected to > #3993 The color of network icon in Home view becomes white after > restarting Sugar. > #2866 Network Manager GUI doesn't report success or failure > #6995 Add a mesh device to the frame and remove mesh devices from > Neighborhood view > > The tickets are a little confusing, so let me summarize what the patches does: > > 1 Adds "IP address" to the mesh & wireless palettes, with associated > changes to their model classes. > 2 Removes the "Disconnect" or "Turn On/off" entries from the > wireless/mesh palettes. > 3 Makes both frame icons pulse. > 4 Don't show the mesh icons in the mesh view, instead show them in the frame. > 5 Fix some iconsistency in the icon states by cleaning up the code. > > mtd did quite a bit of testing on them already, but they are pretty > invasive and there is some risk of regressions. > > My opinion is: > > 2 is controversial and should be left as is for 8.2 It's mainly controversial because they don't do what they say, or what you'd expect them to, but this can wait. Maybe we can actually do it correctly next time around. > 1, 5 are important and we should try to get them in. Yup. > 4 would be nice to have but I don't consider it essential. Actually, I think this is the most important aspect of the design, and I strongly suggest we try to land it. This has been confusing to many, and when we change it I think we need to commit to going the whole way, instead of leaving it in limbo which will only confuse people more down the road. > 3 should be delayed unless it's small and it's easier to take it then > to refactor patches. OK. - Eben > 1,3,5 has been submitted for review as patch A. 2, 4 will be submitted > today as patch B. My suggestion would be: > > * Rip off 3 from patch A if it's worth it and land it for 8.2.0 (before > Friday) > * Do *not* land patch B for 8.2.0 > > mtd has some free time today, so if we can let him know what we want > and don't want to land soon it would be great. > > Thanks, > Marco > ___ > Sugar mailing list > Sugar@lists.laptop.org > http://lists.laptop.org/listinfo/sugar > ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
Eben Eliason wrote: > On Mon, Aug 25, 2008 at 8:19 AM, Marco Pesenti Gritti > >> 4 would be nice to have but I don't consider it essential. >> > > Actually, I think this is the most important aspect of the design, and > I strongly suggest we try to land it. This has been confusing to > many, and when we change it I think we need to commit to going the > whole way, instead of leaving it in limbo which will only confuse > people more down the road. > Personally I think it's way too late for invasive UI changes. I'm fine to be overridden by Kim/Greg decision in that direction, though. Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 03:19:19PM +0200, Morgan Collett wrote: > On Mon, Aug 25, 2008 at 15:13, Walter Bender <[EMAIL PROTECTED]> wrote: > > [in joyride/8.2-756] the mesh icons don't show up on either the > > Neighborhood view or the Frame > > That seems to be a regression in the firmware, with the msh0 interface > not coming up - not a sugar problem... This is #8133: http://dev.laptop.org/ticket/8133 . > Regards > Morgan Martin pgpxOHTSNzZRz.pgp Description: PGP signature ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 02:19:02PM +0200, Marco Pesenti Gritti wrote: > we have a couple of patches that should be ready to be reviewed by > tomorrow, which solves several issues with the UI of network devices. [...] > 1 Adds "IP address" to the mesh & wireless palettes, with associated > changes to their model classes. Note this - part of #2866 - currenlty introduces one new string: "IP Address". I'd argue this should be un-translated/localized if this is a problem. What should I do? > Thanks, > Marco Martin pgpb3PXPGH0M3.pgp Description: PGP signature ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 7:57 PM, Martin Dengler <[EMAIL PROTECTED]> wrote: > On Mon, Aug 25, 2008 at 02:19:02PM +0200, Marco Pesenti Gritti wrote: >> we have a couple of patches that should be ready to be reviewed by >> tomorrow, which solves several issues with the UI of network devices. > [...] >> 1 Adds "IP address" to the mesh & wireless palettes, with associated >> changes to their model classes. > > Note this - part of #2866 - currenlty introduces one new string: "IP > Address". I'd argue this should be un-translated/localized if this is > a problem. > > What should I do? > > One of the problems with keeping strings untranslateable is that it looks awkward (visually) when the user is using a non Latin script (eg: Arabic, or Japanese, or Devanagari). The visual inconsistency can be even more jarring in case of RTL locales. I would say that this be made translateable, and I'm sure that the localization list would agree to a string freeze break for this. Localization list - any counter arguments on this ? Thanks, Sayamindu -- Sayamindu Dasgupta [http://sayamindu.randomink.org/ramblings] ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
I don't agree with adding #4 at this time (changing how/where we see the mesh icons). One of the many work-arounds that we have been telling people in field is that they may need to choose mesh ch 6 or 11 if they want a small group to collaborate in a school setting without any other infrastructure. If the mesh icon doesn't show up in the neighborhood view, that will be a problem. I'd like to see this UI change well before it is implemented. Is there a url, Eben? I'm less concerned about 1 and 3 because they don't seem invasive from the one line summary... if they get in this week as polish that would be ok. I don't know the depth of 5 or 2... and I'm most worried about 4. If all these fixes come in one patch, then I would ask that we do NOT take this patch. If we can pick and choose from this list to get some polish things into 8.2, then let's pick a few based on the invasiveness. Thanks, Kim 1 Adds "IP address" to the mesh & wireless palettes, with associated changes to their model classes. 2 Removes the "Disconnect" or "Turn On/off" entries from the wireless/mesh palettes. 3 Makes both frame icons pulse. 4 Don't show the mesh icons in the mesh view, instead show them in the frame. 5 Fix some iconsistency in the icon states by cleaning up the code. On Aug 25, 2008, at 10:01 AM, Marco Pesenti Gritti wrote: Eben Eliason wrote: On Mon, Aug 25, 2008 at 8:19 AM, Marco Pesenti Gritti 4 would be nice to have but I don't consider it essential. Actually, I think this is the most important aspect of the design, and I strongly suggest we try to land it. This has been confusing to many, and when we change it I think we need to commit to going the whole way, instead of leaving it in limbo which will only confuse people more down the road. Personally I think it's way too late for invasive UI changes. I'm fine to be overridden by Kim/Greg decision in that direction, though. Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
Just spoke with Ricardo and he stated that the wireless firmware we added to this build was for test purposes only and not the firmware that we want to ship. It has other test code in it and the simple mesh feature was specifically turned off; so we can't use this firmware for system testing and we need to revert until we have a better firmware release with the bug fix on top of what was otherwise working well. The issue I pointed out to him (and he will work with Marvell) is that we are only a few weeks away from our desired release date and the blocking bug in the firmware needs to be addressed in the next day or two. We really need a version of wireless firmware that we can be using in large scale testing by the end of the week. Thanks for your help in driving this, Ricardo! Kim On Aug 25, 2008, at 9:13 AM, Walter Bender wrote: > I agree with your assessment. Note that right now (8.2-756), the mesh > icons don't show up on either the Neighborhood view or the Frame; that > is clearly not a satisfactory situation. > > regards. > > -walter > > On Mon, Aug 25, 2008 at 8:19 AM, Marco Pesenti Gritti > <[EMAIL PROTECTED]> wrote: >> Hello, >> >> we have a couple of patches that should be ready to be reviewed by >> tomorrow, which solves several issues with the UI of network devices. >> >> #6944 UI confuses which AP you are connected to >> #3993 The color of network icon in Home view becomes white after >> restarting Sugar. >> #2866 Network Manager GUI doesn't report success or failure >> #6995 Add a mesh device to the frame and remove mesh devices from >> Neighborhood view >> >> The tickets are a little confusing, so let me summarize what the >> patches does: >> >> 1 Adds "IP address" to the mesh & wireless palettes, with associated >> changes to their model classes. >> 2 Removes the "Disconnect" or "Turn On/off" entries from the >> wireless/mesh palettes. >> 3 Makes both frame icons pulse. >> 4 Don't show the mesh icons in the mesh view, instead show them in >> the frame. >> 5 Fix some iconsistency in the icon states by cleaning up the code. >> >> mtd did quite a bit of testing on them already, but they are pretty >> invasive and there is some risk of regressions. >> >> My opinion is: >> >> 2 is controversial and should be left as is for 8.2 >> 1, 5 are important and we should try to get them in. >> 4 would be nice to have but I don't consider it essential. >> 3 should be delayed unless it's small and it's easier to take it then >> to refactor patches. >> >> 1,3,5 has been submitted for review as patch A. 2, 4 will be >> submitted >> today as patch B. My suggestion would be: >> >> * Rip off 3 from patch A if it's worth it and land it for 8.2.0 >> (before Friday) >> * Do *not* land patch B for 8.2.0 >> >> mtd has some free time today, so if we can let him know what we want >> and don't want to land soon it would be great. >> >> Thanks, >> Marco >> ___ >> Sugar mailing list >> Sugar@lists.laptop.org >> http://lists.laptop.org/listinfo/sugar >> ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
On Mon, Aug 25, 2008 at 11:27 AM, Kimberley Quirk <[EMAIL PROTECTED]> wrote: > I don't agree with adding #4 at this time (changing how/where we see the > mesh icons). One of the many work-arounds that we have been telling people > in field is that they may need to choose mesh ch 6 or 11 if they want a > small group to collaborate in a school setting without any other > infrastructure. If the mesh icon doesn't show up in the neighborhood view, > that will be a problem. Why would this be a problem? We're not changing the functionality; only the position of the button within the UI, to be more consistent with the device model we're following. > I'd like to see this UI change well before it is implemented. Is there a > url, Eben? This was mocked up as part of my initial redesign storyboards on the wiki: http://wiki.laptop.org/go/Designs/Frame#09. It's important that the mesh be recognized as a capability of the laptop, and not as a physical device somewhere else in space. The fact that the mesh devices were even added to the Neighborhood view was a last minute hack, and we've been living with it (and confusing people with it) ever since. - Eben > I'm less concerned about 1 and 3 because they don't seem invasive from the > one line summary... if they get in this week as polish that would be ok. I > don't know the depth of 5 or 2... and I'm most worried about 4. > If all these fixes come in one patch, then I would ask that we do NOT take > this patch. If we can pick and choose from this list to get some polish > things into 8.2, then let's pick a few based on the invasiveness. > Thanks, > Kim > > 1 Adds "IP address" to the mesh & wireless palettes, with associated > > changes to their model classes. > > 2 Removes the "Disconnect" or "Turn On/off" entries from the > > wireless/mesh palettes. > > 3 Makes both frame icons pulse. > > 4 Don't show the mesh icons in the mesh view, instead show them in the > frame. > > 5 Fix some iconsistency in the icon states by cleaning up the code. > > On Aug 25, 2008, at 10:01 AM, Marco Pesenti Gritti wrote: > > Eben Eliason wrote: > > On Mon, Aug 25, 2008 at 8:19 AM, Marco Pesenti Gritti > > > > 4 would be nice to have but I don't consider it essential. > > > > Actually, I think this is the most important aspect of the design, and > > I strongly suggest we try to land it. This has been confusing to > > many, and when we change it I think we need to commit to going the > > whole way, instead of leaving it in limbo which will only confuse > > people more down the road. > > > > Personally I think it's way too late for invasive UI changes. I'm fine to be > overridden by Kim/Greg decision in that direction, though. > > Marco > > ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
Am 25.08.2008 um 17:56 schrieb Eben Eliason: > The fact that the mesh > devices were even added to the Neighborhood view was a last minute > hack, and we've been living with it (and confusing people with it) > ever since. Have to agree, this causes a lot of confusion. Since the UI is redesigned anyway the icon should move to its rightful place. - Bert - ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
Re: [sugar] Landing patches about the network devices UI
[for the interested but impatient: http://dev.laptop.org/~mdengler/2866/2866_screenshot_20.png http://dev.laptop.org/ticket/2866 ] On Mon, Aug 25, 2008 at 02:19:02PM +0200, Marco Pesenti Gritti wrote: > we have a couple of patches that should be ready to be reviewed by > tomorrow, which solves several issues with the UI of network > devices. I've submitted the patches for: > #6944 UI confuses which AP you are connected to > #3993 The color of network icon in Home view becomes white after > restarting Sugar. > #2866 Network Manager GUI doesn't report success or failure ...which (the patches' content) you summarised as: > 1 Adds "IP address" to the mesh & wireless palettes, with associated > changes to their model classes. [...] > 3 Makes both frame icons pulse. [...] > 5 Fix some iconsistency in the icon states by cleaning up the code. ...because of the general agreement with: > * [land 1 and 5] for 8.2.0 (before Friday) This UI now looks like: http://dev.laptop.org/~mdengler/2866/2866_screenshot_20.png Any feedback welcome. (I haven't screenshotted the mesh icon because I'm hoping a new firmware will be out soon and I can test by rolling forward to a new joyride, rather than having to roll back to an old one) > Thanks, > Marco Martin PS: I wish we could risk some regressions as the full UI Eben wanted[1] will not be realized (Eben/Bert have already articulated reasons for wanting that), and I would like to run a patch for that by you / into joyride just in case you may have occasion to change your mind. 1. Something like: http://dev.laptop.org/~mdengler/6995/6995_screenshot_50.png http://dev.laptop.org/~mdengler/6995/6995_screenshot_51.png pgpAvFdVGdDbw.pgp Description: PGP signature ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar
