Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
On 09/08/2011 02:30 AM, Chris Leonard wrote: This has been pulled to Pootle and all langs sugar.po have been refreshed. Remove - clipboard http://translate.sugarlabs.org/es/glucose/sugar.po?item=247view_mode=translate Remove - volume http://translate.sugarlabs.org/es/glucose/sugar.po?item=369view_mode=translate cjl Wonderful Chris, this is great work! As a quick smoketest I checked as well how it looks like for German, does appear nicely as well. Thanks, Simon who is happy that this change is picked up nicely ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
I have translated to es now, thanks! Gonzalo On Thu, Sep 8, 2011 at 3:08 AM, Simon Schampijer si...@schampijer.dewrote: On 09/08/2011 02:30 AM, Chris Leonard wrote: This has been pulled to Pootle and all langs sugar.po have been refreshed. Remove - clipboard http://translate.sugarlabs.**org/es/glucose/sugar.po?item=** 247view_mode=translatehttp://translate.sugarlabs.org/es/glucose/sugar.po?item=247view_mode=translate Remove - volume http://translate.sugarlabs.**org/es/glucose/sugar.po?item=** 369view_mode=translatehttp://translate.sugarlabs.org/es/glucose/sugar.po?item=369view_mode=translate cjl Wonderful Chris, this is great work! As a quick smoketest I checked as well how it looks like for German, does appear nicely as well. Thanks, Simon who is happy that this change is picked up nicely __**_ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.**org Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/**listinfo/sugar-develhttp://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
Thanks for all the feedback! I pushed [1] now Sascha's patch which uses pgettext to give context for translators. Chris will be making sure the translators can pick those changes up. Regards, Simon [1] http://git.sugarlabs.org/sugar/mainline/commit/7e1fa4e984e00cfaaddb46d0c043bdf21ce09fd6 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
This has been pulled to Pootle and all langs sugar.po have been refreshed. Remove - clipboard http://translate.sugarlabs.org/es/glucose/sugar.po?item=247view_mode=translate Remove - volume http://translate.sugarlabs.org/es/glucose/sugar.po?item=369view_mode=translate cjl On Wed, Sep 7, 2011 at 2:19 AM, Simon Schampijer si...@schampijer.de wrote: Thanks for all the feedback! I pushed [1] now Sascha's patch which uses pgettext to give context for translators. Chris will be making sure the translators can pick those changes up. Regards, Simon [1] http://git.sugarlabs.org/sugar/mainline/commit/7e1fa4e984e00cfaaddb46d0c043bdf21ce09fd6 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
Excerpts from Gonzalo Odiard's message of Mon Aug 29 20:21:32 +0200 2011: Now I have a better question, why that patch was not applied?! Because Simon did not Ack' it yet. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
Rafael, In the ticket https://bugs.sugarlabs.org/ticket/1658 you said pgettext was working. Can you confirm if is working now, and the problems with the Cloack activity translations are not related to this? Thanks! Gonzalo On Tue, Aug 30, 2011 at 4:09 AM, Sascha Silbe si...@activitycentral.comwrote: Excerpts from Gonzalo Odiard's message of Mon Aug 29 20:21:32 +0200 2011: Now I have a better question, why that patch was not applied?! Because Simon did not Ack' it yet. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ -- Gonzalo Odiard SugarLabs Argentina ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
I can't say with 100% certainty. but I think we have moved beyond our problem with clock. I'll keep a close eye on it to be sure, and I can't be positive what exactly fixed it, but I think it is in the past. cjl On Tue, Aug 30, 2011 at 8:38 AM, Gonzalo Odiard godi...@sugarlabs.org wrote: Rafael, In the ticket https://bugs.sugarlabs.org/ticket/1658 you said pgettext was working. Can you confirm if is working now, and the problems with the Cloack activity translations are not related to this? Thanks! Gonzalo On Tue, Aug 30, 2011 at 4:09 AM, Sascha Silbe si...@activitycentral.com wrote: Excerpts from Gonzalo Odiard's message of Mon Aug 29 20:21:32 +0200 2011: Now I have a better question, why that patch was not applied?! Because Simon did not Ack' it yet. Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ -- Gonzalo Odiard SugarLabs Argentina ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
On 08/24/2011 04:12 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiardgodi...@gmail.com This more specific string, help solve translationes where Remove does not have the same meaning. In Spanish, for example the translation Eliminar means Destroy and must be used Quitar meaning take out. Yes, agreed, we need to do something about it. I just wonder if 'device' is the best naming. GNOME for example use 'Drive'. 'Volume' might be another candidate. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
I think Volume is too easily confused with sound volume (many activities) and book volume (book activities). cjl On Mon, Aug 29, 2011 at 11:06 AM, Simon Schampijer si...@schampijer.de wrote: On 08/24/2011 04:12 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiardgodi...@gmail.com This more specific string, help solve translationes where Remove does not have the same meaning. In Spanish, for example the translation Eliminar means Destroy and must be used Quitar meaning take out. Yes, agreed, we need to do something about it. I just wonder if 'device' is the best naming. GNOME for example use 'Drive'. 'Volume' might be another candidate. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
On 29 Aug 2011, at 16:06, Simon Schampijer si...@schampijer.de wrote: On 08/24/2011 04:12 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiardgodi...@gmail.com This more specific string, help solve translationes where Remove does not have the same meaning. In Spanish, for example the translation Eliminar means Destroy and must be used Quitar meaning take out. Yes, agreed, we need to do something about it. I just wonder if 'device' is the best naming. GNOME for example use 'Drive'. 'Volume' might be another candidate. Do we really need to change the string? It seems like we could just use pgettext. Marco ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
Excerpts from godiard's message of Wed Aug 24 16:12:21 +0200 2011: This more specific string, help solve translationes where Remove does not have the same meaning. In Spanish, for example the translation Eliminar means Destroy and must be used Quitar meaning take out. Why do you replace the english string instead of using pgettext (for which we have a patch [1] already)? What changed since the last time this was discussed? Sascha [1] https://patchwork.sugarlabs.org/patch/653/ -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
On Mon, Aug 29, 2011 at 1:10 PM, Sascha Silbe si...@activitycentral.comwrote: Excerpts from godiard's message of Wed Aug 24 16:12:21 +0200 2011: This more specific string, help solve translationes where Remove does not have the same meaning. In Spanish, for example the translation Eliminar means Destroy and must be used Quitar meaning take out. Why do you replace the english string instead of using pgettext (for which we have a patch [1] already)? Because I am very creative :) Now I have a better question, why that patch was not applied?! I am happy with any of the solutions, please go and fix it Gonzalo What changed since the last time this was discussed? Sascha [1] https://patchwork.sugarlabs.org/patch/653/ -- http://sascha.silbe.org/ http://www.infra-silbe.de/ -- Gonzalo Odiard SugarLabs Argentina ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] Change string Remove in device palette by Remove device
From: Gonzalo Odiard godi...@gmail.com This more specific string, help solve translationes where Remove does not have the same meaning. In Spanish, for example the translation Eliminar means Destroy and must be used Quitar meaning take out. Signed-off-by: Gonzalo Odiard gonz...@laptop.org --- src/jarabe/view/palettes.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/jarabe/view/palettes.py b/src/jarabe/view/palettes.py index d9c1f6b..5223858 100644 --- a/src/jarabe/view/palettes.py +++ b/src/jarabe/view/palettes.py @@ -217,7 +217,7 @@ class VolumePalette(Palette): self.connect('popup', self.__popup_cb) -menu_item = MenuItem(_('Remove')) +menu_item = MenuItem(_('Remove device')) icon = Icon(icon_name='media-eject', icon_size=gtk.ICON_SIZE_MENU) menu_item.set_image(icon) -- 1.7.4.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel