Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 4:40 PM Rodney W. Grimes wrote: > > > In message <20191118204836.GB43295@raichu>, Mark Johnston writes: > > > > On Mon, Nov 18, 2019 at 08:35:30PM +, Alexey Dokuchaev wrote: > > > > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston < > ma...@freebsd.org> wrote: > > > > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston < > ma...@freebsd.org> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Author: markj > > > > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > > > > New Revision: 354824 > > > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > > > > > > > Log: > > > > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > > > > > > > PR: 241973 > > > > > > > > > MFC after:3 days > > > > > > > > > > > > > > > > > > Modified: > > > > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content > changes. > > > > > > > > > > > > Isn't that a content change? I thought anything displayed to > the user > > > > > > counts as a content change? > > > > > > > > > > I presume that "content" means more like semantic, functional > changes > > > > > that affect some particular meaning. Grammar fixes are just, well, > > > > > grammar fixes and thus do not warrant .Dd bump. > > > > > > > > Indeed, this was always my understanding as well. I can't find a > > > > concrete definition anywhere. I don't understand why it would be > useful > > > > as a user to see the date of the last "content change" if such > changes > > > > might consist only of a small formatting change or typo fix. > > > > > > > > > > Should this be documented in the committers guide? > > > > This should be documented someplace, > > that place probably being where bumping of .Dd is documented as a > minimum. > that place also being where .Dd is documented. > The issue, though, is that we get the mdoc man page from upstream somewhere, so we'd have to change that. Plus, upstream seems to have a different .Dd policy that we do ($Mdocdate$ is the last modification time, for example, in OpenBSD's CVS client). So it's a bit tricky to implement. Warner ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
> > In message <20191118204836.GB43295@raichu>, Mark Johnston writes: > > > On Mon, Nov 18, 2019 at 08:35:30PM +, Alexey Dokuchaev wrote: > > > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston > > > > > wrote: > > > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > > > > > wrote: > > > > > > > > > > > > > > > Author: markj > > > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > > > New Revision: 354824 > > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > > > > > Log: > > > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > > > > > PR: 241973 > > > > > > > > MFC after:3 days > > > > > > > > > > > > > > > > Modified: > > > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > > > > > > > Isn't that a content change? I thought anything displayed to the user > > > > > counts as a content change? > > > > > > > > I presume that "content" means more like semantic, functional changes > > > > that affect some particular meaning. Grammar fixes are just, well, > > > > grammar fixes and thus do not warrant .Dd bump. > > > > > > Indeed, this was always my understanding as well. I can't find a > > > concrete definition anywhere. I don't understand why it would be useful > > > as a user to see the date of the last "content change" if such changes > > > might consist only of a small formatting change or typo fix. > > > > > > > Should this be documented in the committers guide? > > This should be documented someplace, > that place probably being where bumping of .Dd is documented as a minimum. that place also being where .Dd is documented. > > Cy Schubert > -- > Rod Grimes rgri...@freebsd.org -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
> In message <20191118204836.GB43295@raichu>, Mark Johnston writes: > > On Mon, Nov 18, 2019 at 08:35:30PM +, Alexey Dokuchaev wrote: > > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston > > > > wrote: > > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > > > > wrote: > > > > > > > > > > > > > Author: markj > > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > > New Revision: 354824 > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > > > Log: > > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > > > PR: 241973 > > > > > > > MFC after:3 days > > > > > > > > > > > > > > Modified: > > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > > > > > Isn't that a content change? I thought anything displayed to the user > > > > counts as a content change? > > > > > > I presume that "content" means more like semantic, functional changes > > > that affect some particular meaning. Grammar fixes are just, well, > > > grammar fixes and thus do not warrant .Dd bump. > > > > Indeed, this was always my understanding as well. I can't find a > > concrete definition anywhere. I don't understand why it would be useful > > as a user to see the date of the last "content change" if such changes > > might consist only of a small formatting change or typo fix. > > > > Should this be documented in the committers guide? This should be documented someplace, that place probably being where bumping of .Dd is documented as a minimum. > Cy Schubert -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, 18 Nov 2019 at 15:48, Mark Johnston wrote: > > > I presume that "content" means more like semantic, functional changes > > that affect some particular meaning. Grammar fixes are just, well, > > grammar fixes and thus do not warrant .Dd bump. > > Indeed, this was always my understanding as well. I can't find a > concrete definition anywhere. I don't understand why it would be useful > as a user to see the date of the last "content change" if such changes > might consist only of a small formatting change or typo fix. My understanding as well. My thinking - if the user last read the man page prior to the .Dd date then they know they have a reason to read it again. On Mon, 18 Nov 2019 at 15:50, Cy Schubert wrote: > > Should this be documented in the committers guide? Yes, it probably should. We probably need to provide more guidance on documentation in the committer's guide, but there's already a small bit about man pages in "18.3. Other Suggestions" and we could add this there. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 1:48 PM Mark Johnston wrote: > On Mon, Nov 18, 2019 at 08:35:30PM +, Alexey Dokuchaev wrote: > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston > wrote: > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > > > wrote: > > > > > > > > > > > Author: markj > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > New Revision: 354824 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > Log: > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > PR: 241973 > > > > > > MFC after:3 days > > > > > > > > > > > > Modified: > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > > > Isn't that a content change? I thought anything displayed to the user > > > counts as a content change? > > > > I presume that "content" means more like semantic, functional changes > > that affect some particular meaning. Grammar fixes are just, well, > > grammar fixes and thus do not warrant .Dd bump. > > Indeed, this was always my understanding as well. I can't find a > concrete definition anywhere. I don't understand why it would be useful > as a user to see the date of the last "content change" if such changes > might consist only of a small formatting change or typo fix. > Ok, seems like everybody else is in agreement. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
In message <20191118204836.GB43295@raichu>, Mark Johnston writes: > On Mon, Nov 18, 2019 at 08:35:30PM +, Alexey Dokuchaev wrote: > > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston wrote: > > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > > > wrote: > > > > > > > > > > > Author: markj > > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > > New Revision: 354824 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > > > Log: > > > > > > Fix grammar in gpart.8. > > > > > > > > > > > > PR: 241973 > > > > > > MFC after:3 days > > > > > > > > > > > > Modified: > > > > > > head/lib/geom/part/gpart.8 > > > > > > > > > > Don't forget to bump the .Dd date. > > > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > > > Isn't that a content change? I thought anything displayed to the user > > > counts as a content change? > > > > I presume that "content" means more like semantic, functional changes > > that affect some particular meaning. Grammar fixes are just, well, > > grammar fixes and thus do not warrant .Dd bump. > > Indeed, this was always my understanding as well. I can't find a > concrete definition anywhere. I don't understand why it would be useful > as a user to see the date of the last "content change" if such changes > might consist only of a small formatting change or typo fix. > Should this be documented in the committers guide? -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 08:35:30PM +, Alexey Dokuchaev wrote: > On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston wrote: > > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > > wrote: > > > > > > > > > Author: markj > > > > > Date: Mon Nov 18 19:05:52 2019 > > > > > New Revision: 354824 > > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > > > Log: > > > > > Fix grammar in gpart.8. > > > > > > > > > > PR: 241973 > > > > > MFC after:3 days > > > > > > > > > > Modified: > > > > > head/lib/geom/part/gpart.8 > > > > > > > > Don't forget to bump the .Dd date. > > > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > > > Isn't that a content change? I thought anything displayed to the user > > counts as a content change? > > I presume that "content" means more like semantic, functional changes > that affect some particular meaning. Grammar fixes are just, well, > grammar fixes and thus do not warrant .Dd bump. Indeed, this was always my understanding as well. I can't find a concrete definition anywhere. I don't understand why it would be useful as a user to see the date of the last "content change" if such changes might consist only of a small formatting change or typo fix. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 01:09:19PM -0700, Alan Somers wrote: > On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston wrote: > > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > > wrote: > > > > > > > Author: markj > > > > Date: Mon Nov 18 19:05:52 2019 > > > > New Revision: 354824 > > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > > > Log: > > > > Fix grammar in gpart.8. > > > > > > > > PR: 241973 > > > > MFC after:3 days > > > > > > > > Modified: > > > > head/lib/geom/part/gpart.8 > > > > > > Don't forget to bump the .Dd date. > > > > AFAIK we do not bump .Dd for such changes, only for content changes. > > Isn't that a content change? I thought anything displayed to the user > counts as a content change? I presume that "content" means more like semantic, functional changes that affect some particular meaning. Grammar fixes are just, well, grammar fixes and thus do not warrant .Dd bump. ./danfe ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 12:48 PM Mark Johnston wrote: > On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston > wrote: > > > > > Author: markj > > > Date: Mon Nov 18 19:05:52 2019 > > > New Revision: 354824 > > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > > > Log: > > > Fix grammar in gpart.8. > > > > > > PR: 241973 > > > MFC after:3 days > > > > > > Modified: > > > head/lib/geom/part/gpart.8 > > > > > > > Don't forget to bump the .Dd date. > > AFAIK we do not bump .Dd for such changes, only for content changes. > Isn't that a content change? I though anything displayed to the user counts as a content change? ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 12:43:48PM -0700, Alan Somers wrote: > On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston wrote: > > > Author: markj > > Date: Mon Nov 18 19:05:52 2019 > > New Revision: 354824 > > URL: https://svnweb.freebsd.org/changeset/base/354824 > > > > Log: > > Fix grammar in gpart.8. > > > > PR: 241973 > > MFC after:3 days > > > > Modified: > > head/lib/geom/part/gpart.8 > > > > Don't forget to bump the .Dd date. AFAIK we do not bump .Dd for such changes, only for content changes. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r354824 - head/lib/geom/part
On Mon, Nov 18, 2019 at 12:06 PM Mark Johnston wrote: > Author: markj > Date: Mon Nov 18 19:05:52 2019 > New Revision: 354824 > URL: https://svnweb.freebsd.org/changeset/base/354824 > > Log: > Fix grammar in gpart.8. > > PR: 241973 > MFC after:3 days > > Modified: > head/lib/geom/part/gpart.8 > Don't forget to bump the .Dd date. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
