svn commit: r243095 - head/sys/dev/agp

2012-11-15 Thread Eitan Adler 
Author: eadler
Date: Thu Nov 15 18:49:17 2012
New Revision: 243095
URL: http://svnweb.freebsd.org/changeset/base/243095

Log:
  Remove unneeded header from agp: opt_bus.h
  
  Tested with make universe
  
  Approved by:  cperciva
  MFC after:1 week

Modified:
  head/sys/dev/agp/agp.c
  head/sys/dev/agp/agp_ali.c
  head/sys/dev/agp/agp_amd.c
  head/sys/dev/agp/agp_amd64.c
  head/sys/dev/agp/agp_apple.c
  head/sys/dev/agp/agp_ati.c
  head/sys/dev/agp/agp_i810.c
  head/sys/dev/agp/agp_intel.c
  head/sys/dev/agp/agp_nvidia.c
  head/sys/dev/agp/agp_sis.c
  head/sys/dev/agp/agp_via.c

Modified: head/sys/dev/agp/agp.c
==
--- head/sys/dev/agp/agp.c  Thu Nov 15 18:05:38 2012(r243094)
+++ head/sys/dev/agp/agp.c  Thu Nov 15 18:49:17 2012(r243095)
@@ -28,7 +28,6 @@
 __FBSDID($FreeBSD$);
 
 #include opt_agp.h
-#include opt_bus.h
 
 #include sys/param.h
 #include sys/systm.h

Modified: head/sys/dev/agp/agp_ali.c
==
--- head/sys/dev/agp/agp_ali.c  Thu Nov 15 18:05:38 2012(r243094)
+++ head/sys/dev/agp/agp_ali.c  Thu Nov 15 18:49:17 2012(r243095)
@@ -27,8 +27,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_amd.c
==
--- head/sys/dev/agp/agp_amd.c  Thu Nov 15 18:05:38 2012(r243094)
+++ head/sys/dev/agp/agp_amd.c  Thu Nov 15 18:49:17 2012(r243095)
@@ -27,8 +27,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_amd64.c
==
--- head/sys/dev/agp/agp_amd64.cThu Nov 15 18:05:38 2012
(r243094)
+++ head/sys/dev/agp/agp_amd64.cThu Nov 15 18:49:17 2012
(r243095)
@@ -27,8 +27,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_apple.c
==
--- head/sys/dev/agp/agp_apple.cThu Nov 15 18:05:38 2012
(r243094)
+++ head/sys/dev/agp/agp_apple.cThu Nov 15 18:49:17 2012
(r243095)
@@ -27,8 +27,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_ati.c
==
--- head/sys/dev/agp/agp_ati.c  Thu Nov 15 18:05:38 2012(r243094)
+++ head/sys/dev/agp/agp_ati.c  Thu Nov 15 18:49:17 2012(r243095)
@@ -29,8 +29,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_i810.c
==
--- head/sys/dev/agp/agp_i810.c Thu Nov 15 18:05:38 2012(r243094)
+++ head/sys/dev/agp/agp_i810.c Thu Nov 15 18:49:17 2012(r243095)
@@ -40,8 +40,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #if 0
 #defineKTR_AGP_I810KTR_DEV
 #else

Modified: head/sys/dev/agp/agp_intel.c
==
--- head/sys/dev/agp/agp_intel.cThu Nov 15 18:05:38 2012
(r243094)
+++ head/sys/dev/agp/agp_intel.cThu Nov 15 18:49:17 2012
(r243095)
@@ -27,8 +27,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_nvidia.c
==
--- head/sys/dev/agp/agp_nvidia.c   Thu Nov 15 18:05:38 2012
(r243094)
+++ head/sys/dev/agp/agp_nvidia.c   Thu Nov 15 18:49:17 2012
(r243095)
@@ -32,8 +32,6 @@ __FBSDID($FreeBSD$);
  * NVIDIA nForce/nForce2 AGPGART Linux Kernel Patch.
  */
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_sis.c
==
--- head/sys/dev/agp/agp_sis.c  Thu Nov 15 18:05:38 2012(r243094)
+++ head/sys/dev/agp/agp_sis.c  Thu Nov 15 18:49:17 2012(r243095)
@@ -27,8 +27,6 @@
 #include sys/cdefs.h
 __FBSDID($FreeBSD$);
 
-#include opt_bus.h
-
 #include sys/param.h
 #include sys/systm.h
 #include sys/malloc.h

Modified: head/sys/dev/agp/agp_via.c
==
--- head/sys/dev/agp/agp_via.c  Thu

Re: svn commit: r243095 - head/sys/dev/agp

2012-11-15 Thread Konstantin Belousov 
On Thu, Nov 15, 2012 at 06:49:17PM +, Eitan Adler wrote:
 Author: eadler
 Date: Thu Nov 15 18:49:17 2012
 New Revision: 243095
 URL: http://svnweb.freebsd.org/changeset/base/243095
 
 Log:
   Remove unneeded header from agp: opt_bus.h
   
   Tested with make universe
make universe cannot prove anything about usefulness of the removed include,
just because *_opt.h files contains only defines, which are used later
by the code like
#ifdef OPTION
do something
#endif.

If you are removing the option include, the module Makefile should be
adjusted too.


pgpqE9uiBH7bi.pgp
Description: PGP signature

Re: svn commit: r243095 - head/sys/dev/agp

2012-11-15 Thread Eitan Adler 
On 15 November 2012 14:22, Konstantin Belousov kostik...@gmail.com wrote:
 On Thu, Nov 15, 2012 at 06:49:17PM +, Eitan Adler wrote:
 Author: eadler
 Date: Thu Nov 15 18:49:17 2012
 New Revision: 243095
 URL: http://svnweb.freebsd.org/changeset/base/243095

 Log:
   Remove unneeded header from agp: opt_bus.h

   Tested with make universe
 make universe cannot prove anything about usefulness of the removed include,
 just because *_opt.h files contains only defines, which are used later
 by the code like

This is a good point. In this case I had done the manual review as
well.  make universe was an additional check.

 If you are removing the option include, the module Makefile should be
 adjusted too.

:-\  I had sent this to Colin but forgot to include it in my final commit.



-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org