Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Looks fine. On 10.03.16 8:14, Rajeev Chamyal wrote: Hello Sergey, I have updated the test as per review comments. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 09 March 2016 18:57 To: Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. The fix looks fine, but the test should be updated. JFrame is created on non-EDT thread. It is unclear what l&f we should test(some specific,all,default?). This also can be simplified: 70 if (testFailed) { 71 dispose(); 72 throw new RuntimeException("Test Failed"); 73 } 74 dispose(); On 09.03.16 7:44, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal On 11-01-2016 15:27, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have updated BasicInternalFrameUI.java and added it to webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: Hello All, I need one more review for this webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Regards, Rajeev Chamyal *From:*Alexander Scherbatiy *Sent:* 23 December 2015 19:44 *To:* Rajeev Chamyal *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net *Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal -- Best regards, Sergey. -- Best regards, Sergey. -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hello Sergey, I have updated the test as per review comments. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.02/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 09 March 2016 18:57 To: Rajeev Chamyal; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. The fix looks fine, but the test should be updated. JFrame is created on non-EDT thread. It is unclear what l&f we should test(some specific,all,default?). This also can be simplified: 70 if (testFailed) { 71 dispose(); 72 throw new RuntimeException("Test Failed"); 73 } 74 dispose(); On 09.03.16 7:44, Rajeev Chamyal wrote: > Hello Sergey, > > Could you please review the updated webrev. > http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ > > Regards, > Rajeev Chamyal > > > On 11-01-2016 15:27, Rajeev Chamyal wrote: >> Hello Sergey, >> >> Could you please review the updated webrev. >> http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ >> >> Regards, >> Rajeev Chamyal >> >> -Original Message- >> From: Rajeev Chamyal >> Sent: 02 January 2016 11:46 >> To: Sergey Bylokhov; swing-dev@openjdk.java.net >> Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum >> before adding to desktop throws null pointer exception >> >> Hello Sergey, >> >> Thanks for review I have updated webrev. >> There was one more issue with fix to fix it , I have updated >> BasicInternalFrameUI.java and added it to webrev. >> http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ >> >> Regards, >> Rajeev Chamyal >> >> -Original Message- >> From: Sergey Bylokhov >> Sent: 30 December 2015 20:34 >> To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net >> Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum >> before adding to desktop throws null pointer exception >> >> Hi, Rajeev. >> A few notes: >> - The "Rectangle desktopBounds = f.getParent().getBounds();" can >> reuse the new "c" variable. >> - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It >> seems that it is not used after the null check. >> >> On 30/12/15 10:30, Rajeev Chamyal wrote: >>> Hello All, >>> >>> I need one more review for this webrev. >>> >>> http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ >>> <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> >>> >>> Regards, >>> >>> Rajeev Chamyal >>> >>> *From:*Alexander Scherbatiy >>> *Sent:* 23 December 2015 19:44 >>> *To:* Rajeev Chamyal >>> *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; >>> swing-dev@openjdk.java.net >>> *Subject:* Re: Review request for JDK-8145896 JInternalFrame >>> setMaximum before adding to desktop throws null pointer exception >>> >>> >>> The fix looks good to me. >>> >>> Thanks, >>> Alexandr. >>> >>> On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: >>> >>> Hello All, >>> >>> Please review the following fix for Jdk9: >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 >>> >>> Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ >>> <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> >>> >>> Issue: JInternalFrame setMaximum before adding to desktop throws >>> null pointer exception >>> >>> Cause: Null checks for parent and Desktop pane are missing >>> >>> Fix: Added null checks for parent and desktop pane. >>> >>> Verified the fix on windows,Ubuntu and Mac with all supported LAF. >>> >>> Regards, >>> >>> Rajeev Chamyal >>> >> >> -- >> Best regards, Sergey. > -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hi, Rajeev. The fix looks fine, but the test should be updated. JFrame is created on non-EDT thread. It is unclear what l&f we should test(some specific,all,default?). This also can be simplified: 70 if (testFailed) { 71 dispose(); 72 throw new RuntimeException("Test Failed"); 73 } 74 dispose(); On 09.03.16 7:44, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal On 11-01-2016 15:27, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have updated BasicInternalFrameUI.java and added it to webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: Hello All, I need one more review for this webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Regards, Rajeev Chamyal *From:*Alexander Scherbatiy *Sent:* 23 December 2015 19:44 *To:* Rajeev Chamyal *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net *Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal -- Best regards, Sergey. -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal On 11-01-2016 15:27, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have updated BasicInternalFrameUI.java and added it to webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: Hello All, I need one more review for this webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Regards, Rajeev Chamyal *From:*Alexander Scherbatiy *Sent:* 23 December 2015 19:44 *To:* Rajeev Chamyal *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net *Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
The fix looks good to me. Thanks, Alexandr. On 11/01/16 13:57, Rajeev Chamyal wrote: Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have updated BasicInternalFrameUI.java and added it to webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: Hello All, I need one more review for this webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Regards, Rajeev Chamyal *From:*Alexander Scherbatiy *Sent:* 23 December 2015 19:44 *To:* Rajeev Chamyal *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net *Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hello Sergey, Could you please review the updated webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Rajeev Chamyal Sent: 02 January 2016 11:46 To: Sergey Bylokhov; swing-dev@openjdk.java.net Subject: RE: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have updated BasicInternalFrameUI.java and added it to webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: > Hello All, > > I need one more review for this webrev. > > http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ > <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> > > Regards, > > Rajeev Chamyal > > *From:*Alexander Scherbatiy > *Sent:* 23 December 2015 19:44 > *To:* Rajeev Chamyal > *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net > *Subject:* Re: Review request for JDK-8145896 JInternalFrame > setMaximum before adding to desktop throws null pointer exception > > >The fix looks good to me. > >Thanks, >Alexandr. > > On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: > > Hello All, > > Please review the following fix for Jdk9: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 > > Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ > <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> > > Issue: JInternalFrame setMaximum before adding to desktop throws > null pointer exception > > Cause: Null checks for parent and Desktop pane are missing > > Fix: Added null checks for parent and desktop pane. > > Verified the fix on windows,Ubuntu and Mac with all supported LAF. > > Regards, > > Rajeev Chamyal > -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hello Sergey, Thanks for review I have updated webrev. There was one more issue with fix to fix it , I have updated BasicInternalFrameUI.java and added it to webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/ Regards, Rajeev Chamyal -Original Message- From: Sergey Bylokhov Sent: 30 December 2015 20:34 To: Rajeev Chamyal; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: > Hello All, > > I need one more review for this webrev. > > http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ > <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> > > Regards, > > Rajeev Chamyal > > *From:*Alexander Scherbatiy > *Sent:* 23 December 2015 19:44 > *To:* Rajeev Chamyal > *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net > *Subject:* Re: Review request for JDK-8145896 JInternalFrame > setMaximum before adding to desktop throws null pointer exception > > >The fix looks good to me. > >Thanks, >Alexandr. > > On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: > > Hello All, > > Please review the following fix for Jdk9: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 > > Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ > <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> > > Issue: JInternalFrame setMaximum before adding to desktop throws > null pointer exception > > Cause: Null checks for parent and Desktop pane are missing > > Fix: Added null checks for parent and desktop pane. > > Verified the fix on windows,Ubuntu and Mac with all supported LAF. > > Regards, > > Rajeev Chamyal > -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hi, Rajeev. A few notes: - The "Rectangle desktopBounds = f.getParent().getBounds();" can reuse the new "c" variable. - Is the "JDesktopPane d = f.getDesktopPane();" is necessary? It seems that it is not used after the null check. On 30/12/15 10:30, Rajeev Chamyal wrote: Hello All, I need one more review for this webrev. http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Regards, Rajeev Chamyal *From:*Alexander Scherbatiy *Sent:* 23 December 2015 19:44 *To:* Rajeev Chamyal *Cc:* Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net *Subject:* Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev:http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ <http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/> Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal -- Best regards, Sergey.
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hello All, I need one more review for this webrev. HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ Regards, Rajeev Chamyal From: Alexander Scherbatiy Sent: 23 December 2015 19:44 To: Rajeev Chamyal Cc: Sergey Bylokhov; Prasanta Sadhukhan; swing-dev@openjdk.java.net Subject: Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal
Re: Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
The fix looks good to me. Thanks, Alexandr. On 12/21/2015 3:09 PM, Rajeev Chamyal wrote: Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev: http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal
Review request for JDK-8145896 JInternalFrame setMaximum before adding to desktop throws null pointer exception
Hello All, Please review the following fix for Jdk9: Bug: https://bugs.openjdk.java.net/browse/JDK-8145896 Webrev: http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/ Issue: JInternalFrame setMaximum before adding to desktop throws null pointer exception Cause: Null checks for parent and Desktop pane are missing Fix: Added null checks for parent and desktop pane. Verified the fix on windows,Ubuntu and Mac with all supported LAF. Regards, Rajeev Chamyal