Re: [sword-devel] SWORD utility Diatheke
I don’t think the library is right with regard to headings. From what I can tell: a) It will hide canonical headings. b) It won’t hide non-canonical headings that are not pre-verse. I’ve been digging through the code and am not certain what I see, but it looks for the first (last?) title or div that is marked x-preverse and bases a decision on whether to show the content based upon that. Regarding a) The problem is that the x-preverse is only on the div and is never marked canonical. The preverse div contains all the inter-verse material that does not belong to the prior verse. Other than titles, all of it should always be shown. Titles should only be always shown if marked canonical. The titles are not also marked x-preverse. They are within the x-preverse div. Regarding b) It only looks for title and div marked x-preverse and does not look for headings within the body of a verse. Hope this helps. In Him, DM > On Dec 16, 2015, at 12:54 PM, Peter von Kaehne wrote: > > The library works right. Whether the module is right i do not know. > > Sent from my phone. Apologies for brevity and typos.On 16 Dec 2015 5:06 pm, > Greg Hellings wrote: >> >> I think the 'canonical="true"' is what's keeping them present. I >> thought the filters are not supposed to strip out any canonical text, >> ever. >> >> --Greg >> >> On Wed, Dec 16, 2015 at 10:42 AM, David Haslam wrote: >>> Although one of the diatheke command line options is -h to include Section >>> Headings, I have found that when using diatheke without this option, the >>> output still includes the acrostic stanza titles in Psalm 119 (as tested >>> with the KJV module). >>> >>> Is this a bug or a feature? >>> >>> In the KJV, these titles have OSIS like the following first example: >>> >>> >> n="א">ALEPH. >>> >>> Best regards, >>> >>> David >>> >>> >>> >>> -- >>> View this message in context: >>> http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451.html >>> Sent from the SWORD Dev mailing list archive at Nabble.com. >>> >>> ___ >>> sword-devel mailing list: sword-devel@crosswire.org >>> http://www.crosswire.org/mailman/listinfo/sword-devel >>> Instructions to unsubscribe/change your settings at above page >> >> ___ >> sword-devel mailing list: sword-devel@crosswire.org >> http://www.crosswire.org/mailman/listinfo/sword-devel >> Instructions to unsubscribe/change your settings at above page > ___ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD utility Diatheke
For any problem like this there are four potential places to look: front-end, SWORD engine, osis2mod, and module markup. It almost never is a front-end problem. Canonical titles should always be shown. They should never be hidden. If you are saying that diatheke is handling canonical titles inconsistently, then there is a bug in the SWORD engine that hides canonical titles. Non-canonical titles should be allowed within a verse. This is not a problem here, since they are canonical, but this may be indicative that the SWORD engine doesn’t handle them properly. However, there is a bug in the module. These titles should be between verses, but in the xml they are within the verse. Osis2mod is properly handling what it is given. I’m preparing version 2.8 now. Many thanks, DM > On Dec 16, 2015, at 11:42 AM, David Haslam wrote: > > Although one of the diatheke command line options is -h to include Section > Headings, I have found that when using diatheke without this option, the > output still includes the acrostic stanza titles in Psalm 119 (as tested > with the KJV module). > > Is this a bug or a feature? > > In the KJV, these titles have OSIS like the following first example: > > n="א">ALEPH. > > Best regards, > > David > > > > -- > View this message in context: > http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451.html > Sent from the SWORD Dev mailing list archive at Nabble.com. > > ___ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD utility Diatheke
I've added a new sub-section to DM's wiki page. http://www.crosswire.org/wiki/User:Dmsmith/KJV_2.6#Psalm_119_Acrostic_Stanza_Titles David -- View this message in context: http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451p4655458.html Sent from the SWORD Dev mailing list archive at Nabble.com. ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD utility Diatheke
The library works right. Whether the module is right i do not know. Sent from my phone. Apologies for brevity and typos.On 16 Dec 2015 5:06 pm, Greg Hellings wrote: > > I think the 'canonical="true"' is what's keeping them present. I > thought the filters are not supposed to strip out any canonical text, > ever. > > --Greg > > On Wed, Dec 16, 2015 at 10:42 AM, David Haslam wrote: > > Although one of the diatheke command line options is -h to include Section > > Headings, I have found that when using diatheke without this option, the > > output still includes the acrostic stanza titles in Psalm 119 (as tested > > with the KJV module). > > > > Is this a bug or a feature? > > > > In the KJV, these titles have OSIS like the following first example: > > > > > n="א">ALEPH. > > > > Best regards, > > > > David > > > > > > > > -- > > View this message in context: > > http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451.html > > Sent from the SWORD Dev mailing list archive at Nabble.com. > > > > ___ > > sword-devel mailing list: sword-devel@crosswire.org > > http://www.crosswire.org/mailman/listinfo/sword-devel > > Instructions to unsubscribe/change your settings at above page > > ___ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD utility Diatheke
That was my first thought, but it can't be the explanation, since the other 116 titles in which canonical="true" are not included in the diatheke output without the -h option. e.g. Psalm 15 for which the mod2imp output is: $$$Psalms 15:1 A Psalm of David. It may turn out to be a KJV module issue, rather than a diatheke issue. Or if osis2mod doesn't transform the 22 acrostic titles to subType="x-preverse", it might be a build issue. But unless the OSIS source text is such that it does that automatically, then we have a problem. Currently, Xiphos displays the "widowed" verse tag BEFORE each stanza title. This matches the behaviour of diatheke, in that the acrostic title is considered as part of the verse text. I think this might be first for DM to tackle - to see if we can improve the OSIS in this Psalm. Best regards, David -- View this message in context: http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451p4655453.html Sent from the SWORD Dev mailing list archive at Nabble.com. ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page
Re: [sword-devel] SWORD utility Diatheke
I think the 'canonical="true"' is what's keeping them present. I thought the filters are not supposed to strip out any canonical text, ever. --Greg On Wed, Dec 16, 2015 at 10:42 AM, David Haslam wrote: > Although one of the diatheke command line options is -h to include Section > Headings, I have found that when using diatheke without this option, the > output still includes the acrostic stanza titles in Psalm 119 (as tested > with the KJV module). > > Is this a bug or a feature? > > In the KJV, these titles have OSIS like the following first example: > > n="א">ALEPH. > > Best regards, > > David > > > > -- > View this message in context: > http://sword-dev.350566.n4.nabble.com/SWORD-utility-Diatheke-tp4655451.html > Sent from the SWORD Dev mailing list archive at Nabble.com. > > ___ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page