Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined
On Sat, Jul 20, 2013 at 08:37:14AM +0200, Holger Hans Peter Freyther wrote: > > But that looks like a plain automake bug. It should know that targets > > starting with a dot are not real targets. Could you file a bug > > report with automake, so this gets fixed properly? > > I sent an email to the automake list and will report back. automake 1.15 will have a fix for that. holger ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined
On Sat, Jul 20, 2013 at 03:20:02PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > ... that's at least how it looks in my testing. I don't think that > having %MAKEFILE% in the final Makefile makes any sense, and it > swhould always be "Makefile". Maybe automake forgets to substitute it > in your case, or something eelse is hapenning. okay, thanks for checking. so a human error on my side after all. :) ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined
On Sat, Jul 20, 2013 at 08:37:14AM +0200, Holger Hans Peter Freyther wrote: > On Sat, Jul 20, 2013 at 01:09:35AM +0200, Zbigniew Jędrzejewski-Szmek wrote: > > Hi, > > > > Applied for now. > > > I picked %MAKEFILE% as this is what was in the generated Makefile before > my patch. I just tried to match the output. Originally: .PRECIOUS: Makefile After 1st patch: .PRECIOUS: $(TEST_SUITE_LOG) With 2nd patch: .PRECIOUS: $(TEST_SUITE_LOG) %MAKEFILE% With 2nd patch modified: .PRECIOUS: $(TEST_SUITE_LOG) Makefile ... that's at least how it looks in my testing. I don't think that having %MAKEFILE% in the final Makefile makes any sense, and it swhould always be "Makefile". Maybe automake forgets to substitute it in your case, or something eelse is hapenning. > > > But that looks like a plain automake bug. It should know that targets > > starting with a dot are not real targets. Could you file a bug > > report with automake, so this gets fixed properly? > > I sent an email to the automake list and will report back. Thanks. Zbyszek -- they are not broken. they are refucktored -- alxchk ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined
On Sat, Jul 20, 2013 at 01:09:35AM +0200, Zbigniew Jędrzejewski-Szmek wrote: Hi, > Applied for now. I picked %MAKEFILE% as this is what was in the generated Makefile before my patch. I just tried to match the output. > But that looks like a plain automake bug. It should know that targets > starting with a dot are not real targets. Could you file a bug > report with automake, so this gets fixed properly? I sent an email to the automake list and will report back. ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
Re: [systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined
On Thu, Jul 18, 2013 at 09:18:55AM +0200, Holger Hans Peter Freyther wrote: > From: Holger Hans Peter Freyther > > Yesterday I added test-suite.log as dependency to the .PRECIOUS > target. Automake is warning about this target being redefined > and from what I see there is no way I can stop the warning but > I can add the %MAKEFILE% as dependency. > > automake warning: > Makefile.am:35: warning: user target '.PRECIOUS' defined here ... > /usr/share/automake-1.13/am/configure.am: ... overrides Automake target > '.PRECIOUS' defined here Applied for now. But that looks like a plain automake bug. It should know that targets starting with a dot are not real targets. Could you file a bug report with automake, so this gets fixed properly? Zbyszek > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index e598585..c9b0715 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -32,7 +32,7 @@ SUBDIRS = . po > .SECONDARY: > > # Keep the test-suite.log > -.PRECIOUS: $(TEST_SUITE_LOG) > +.PRECIOUS: $(TEST_SUITE_LOG) %MAKEFILE% > > LIBUDEV_CURRENT=4 > LIBUDEV_REVISION=6 > -- > 1.8.3.2 > > ___ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel > -- they are not broken. they are refucktored -- alxchk ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
[systemd-devel] [PATCH] make: Automake is complaining about .PRECIOUS being redefined
From: Holger Hans Peter Freyther Yesterday I added test-suite.log as dependency to the .PRECIOUS target. Automake is warning about this target being redefined and from what I see there is no way I can stop the warning but I can add the %MAKEFILE% as dependency. automake warning: Makefile.am:35: warning: user target '.PRECIOUS' defined here ... /usr/share/automake-1.13/am/configure.am: ... overrides Automake target '.PRECIOUS' defined here --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index e598585..c9b0715 100644 --- a/Makefile.am +++ b/Makefile.am @@ -32,7 +32,7 @@ SUBDIRS = . po .SECONDARY: # Keep the test-suite.log -.PRECIOUS: $(TEST_SUITE_LOG) +.PRECIOUS: $(TEST_SUITE_LOG) %MAKEFILE% LIBUDEV_CURRENT=4 LIBUDEV_REVISION=6 -- 1.8.3.2 ___ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
