Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
sajol...@pimienta.org wrote (07 Oct 2012 08:51:24 GMT) : Great! I fixed the language a bit with commit 4e08074. I fixed some grammar and merged again into devel. Will push soon. (I think such doc / style / grammar fixes, for already-merged branches, could be done directly in devel.) ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
On 02/10/12 15:14, anonym wrote: 30/09/12 21:01, intrigeri wrote: Hi, please, anyone who did the 0.18 release of tails-persistence-setup, push your pristine-tar branch. I followed the instructions in contribute/release_process/persistence-setup, and that branch wasn't modified (i.e. it's still at commit 0bc2057). How can I fix this? Other than that, a 0.18 release was made from the usual branches in there, with stuff that is not be ready yet for merging into devel. One drawback is that it has apparently blocked an improved t-p-s (with bigger timeout) from entering Tails 0.13. I'd like to avoid this happening again. I think we now have two possibilities: A. the NM presets persistence is finished and merged in time = t-p-s 0.18 or greater is shipped into Tails 0.14, with a (possibly much) bigger timeout. Great. B. the NM presets persistence is not finished and merged in time = I'd rather not fork a branch off t-p-s 0.17 and prepare 0.17.1 from there (overkill), so I think we should go for a chroot_local-patches. So, I think I'll wait a few days (say, until next Thursday), and go with #B if #A has not happened yet. Thoughts, better ideas? I'm gonna try for #A now: todo/persistence_preset_-_NM_connections has been implemented in feature/persistent_NM_connections. IMHO it's now in a good enough shape to be shipped in Tails 0.14, but there are some issues (see todo page): * violation of Single Responsibility Principle: Adding a 'gconf' persistence option would have to go into upstream live-boot, and IMHO this is way too Tails-specific for such inclusion. An alternative would be to put the code from commit 1d3cae2 in tails-greeter into our custom live-persist script. Since live-persist is the glue that fixes all the quirks we have with live-boot's vanilla persistence, this seems like a perfect fit. This is done in commits 77c3261 and 4db38e9. * Connect automatically checkbox gets unchecked on each boot: IMHO this bug is good :). Hence we can ignore this for now and just mention it as a known issue (commit 0f7f652). I also wrote the user documentation (commit 269b672). Great! I fixed the language a bit with commit 4e08074. signature.asc Description: OpenPGP digital signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
On Wed, Oct 03, 2012 at 11:21:05PM +0200, intrigeri wrote: intrigeri wrote (03 Oct 2012 17:30:10 GMT) : anonym wrote (03 Oct 2012 14:34:59 GMT) : So, with the current state of things it still looks like a bug to me, although with nice side-effects. Making it into a proper feature (i.e. patching nm-applet) is definitely desirable, but not something I'm willing to take on for the 0.14 release. I'm now convinced. Let's document this as a known issue, and create a ticket to remember we need to make up our mind some day on this topic (possibly after Wheezy is released). I've tested the branch and I'll be happy to merge it once we have made a decision on the autoconnect thing (deadline for anonym's proposal: Friday at noon CEST). Don't wait for me, I am convinced as well. -- Ague pgp5LnkSh9Ila.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
On Thu, Oct 04, 2012 at 05:33:18PM +, Ague Mill wrote: On Wed, Oct 03, 2012 at 11:21:05PM +0200, intrigeri wrote: intrigeri wrote (03 Oct 2012 17:30:10 GMT) : anonym wrote (03 Oct 2012 14:34:59 GMT) : So, with the current state of things it still looks like a bug to me, although with nice side-effects. Making it into a proper feature (i.e. patching nm-applet) is definitely desirable, but not something I'm willing to take on for the 0.14 release. I'm now convinced. Let's document this as a known issue, and create a ticket to remember we need to make up our mind some day on this topic (possibly after Wheezy is released). I've tested the branch and I'll be happy to merge it once we have made a decision on the autoconnect thing (deadline for anonym's proposal: Friday at noon CEST). Don't wait for me, I am convinced as well. Same here :) bert. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
Don't wait for me, I am convinced as well. Same here :) Merged. Adapted the network connections preset's name in the bundled doc. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
02/10/12 16:09, intrigeri wrote:
Hi,
anonym wrote (02 Oct 2012 13:14:58 GMT) :
30/09/12 21:01, intrigeri wrote:
please, anyone who did the 0.18 release of tails-persistence-setup,
push your pristine-tar branch.
I followed the instructions in
contribute/release_process/persistence-setup, and that branch wasn't
modified (i.e. it's still at commit 0bc2057).
Looks like you have pristine-tar disabled in your gbp configuration.
That's probably the default. I've just added pristine-tar = True to
debian/gbp.conf in the debian branch, so that won't happen anymore,
regardless of individual's configuration.
How can I fix this?
I would try re-doing the git-import-orig, with the --no-merge option.
Some steps are likely to fail, because they were run already. Then,
I would reset --hard the upstream and debian branches to their
previous state (the current one, as of when I'm writing), and then
push the pristine-tar branch updated with the missing orig
tarball delta.
Thanks! It's pushed now.
todo/persistence_preset_-_NM_connections has been implemented in
feature/persistent_NM_connections. IMHO it's now in a good enough
shape to be shipped in Tails 0.14, but there are some issues (see
todo page):
Great! I hope it makes it into 0.14.
If the rest of you agree that all is good now, please review and merge
this branch into devel so it can be included in Tails 0.14.
Some notes from a (too quick) static review follow.
I'll test that code once it is merged into experimental.
Sorry, I just forgot to push my experimental.
+name= $self-encoding-decode(gettext(q{NetworkManager
connections})),
+description = $self-encoding-decode(gettext(
+q{Network connections}
+)),
I'm not sure end-users know what NetworkManager is, and/or want to
learn about its name. I suggest:
* name = Network Connections
(Which uses title capitalization, like other existing presets.)
* description = Configuration of network devices and connections
(All credits due to the NM applet About dialog text.)
What do you think?
I definitely agree that this description is better. About the name, we
have the Networking with NetworkManager section in our docs, and it
even says that [T]he name is quite self-explanatory :). But I don't
really care, so I made it your way (commit 2dd6ed5 in
tails/persistence-setup).
Is this something that will require releasing 0.19 right away and
importing it in feature/persistent_NM_connections before merging it into
devel? Or can the rephrasing just live in git and be released as t-p-s
0.19 during the Tails 0.14 freeze when the translations has been done?
That way we may be able to avoid having to bump to 0.20 (= less binary
pollution in our git repo). Even if that wouldn't happen I don't think
the current name and description are much of a blocker.
Also, any thoughts about how we'll handle the migration to dconf when
Tails is based on Wheezy? (Not a blocker, I think, but still.)
I just had a look at this in a Wheezy install, and `dconf dump /` didn't
reveal any NM settings. It turns out that dconf isn't used, and that all
NM connections are saved as individual files in
/etc/NetworkManager/system-connections instead. I tried writing a new
connection file there by hand, and it immediately appeared in nm-applet,
so there seems to be no extra magic required. Great! Hence the
transition seems to be trivial.
Cheers!
signature.asc
Description: OpenPGP digital signature
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
hi, anonym wrote (03 Oct 2012 14:34:53 GMT) : Or can the rephrasing just live in git and be released as t-p-s 0.19 during the Tails 0.14 freeze when the translations has been done? I'm fine with that. Will you take care of make this happen? Also, any thoughts about how we'll handle the migration to dconf when Tails is based on Wheezy? (Not a blocker, I think, but still.) I just had a look at this in a Wheezy install, [...] Hence the transition seems to be trivial. Great! Thanks for testing. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
hi, anonym wrote (03 Oct 2012 14:34:59 GMT) : So, with the current state of things it still looks like a bug to me, although with nice side-effects. Making it into a proper feature (i.e. patching nm-applet) is definitely desirable, but not something I'm willing to take on for the 0.14 release. I'm now convinced. Let's document this as a known issue, and create a ticket to remember we need to make up our mind some day on this topic (possibly after Wheezy is released). ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
[Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
30/09/12 21:01, intrigeri wrote: Hi, please, anyone who did the 0.18 release of tails-persistence-setup, push your pristine-tar branch. I followed the instructions in contribute/release_process/persistence-setup, and that branch wasn't modified (i.e. it's still at commit 0bc2057). How can I fix this? Other than that, a 0.18 release was made from the usual branches in there, with stuff that is not be ready yet for merging into devel. One drawback is that it has apparently blocked an improved t-p-s (with bigger timeout) from entering Tails 0.13. I'd like to avoid this happening again. I think we now have two possibilities: A. the NM presets persistence is finished and merged in time = t-p-s 0.18 or greater is shipped into Tails 0.14, with a (possibly much) bigger timeout. Great. B. the NM presets persistence is not finished and merged in time = I'd rather not fork a branch off t-p-s 0.17 and prepare 0.17.1 from there (overkill), so I think we should go for a chroot_local-patches. So, I think I'll wait a few days (say, until next Thursday), and go with #B if #A has not happened yet. Thoughts, better ideas? I'm gonna try for #A now: todo/persistence_preset_-_NM_connections has been implemented in feature/persistent_NM_connections. IMHO it's now in a good enough shape to be shipped in Tails 0.14, but there are some issues (see todo page): * violation of Single Responsibility Principle: Adding a 'gconf' persistence option would have to go into upstream live-boot, and IMHO this is way too Tails-specific for such inclusion. An alternative would be to put the code from commit 1d3cae2 in tails-greeter into our custom live-persist script. Since live-persist is the glue that fixes all the quirks we have with live-boot's vanilla persistence, this seems like a perfect fit. This is done in commits 77c3261 and 4db38e9. * Connect automatically checkbox gets unchecked on each boot: IMHO this bug is good :). Hence we can ignore this for now and just mention it as a known issue (commit 0f7f652). I also wrote the user documentation (commit 269b672). If the rest of you agree that all is good now, please review and merge this branch into devel so it can be included in Tails 0.14. Cheers! signature.asc Description: OpenPGP digital signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
Since live-persist is the glue that fixes all the quirks we have with live-boot's vanilla persistence, this seems like a perfect fit. This is done in commits 77c3261 and 4db38e9. Looks nicer this way. The function `fix_gconf_dirs` might benefit from some more quoting of the variables. Maybe filesystem corruption could put a space somewhere bad... * Connect automatically checkbox gets unchecked on each boot: IMHO this bug is good :). Hence we can ignore this for now and just mention it as a known issue (commit 0f7f652). We have to rule this as either a bug or a feature. In my views, it is a feature and we just have to state it that way: Tails do not connect automatically to networks it was previously connected to. So I'd rather remove the addition to known issues, and document that behaviour better on `doc/first_steps/persistence/configure`. No tests done yet, but it looks good so far! :) -- Ague pgp8M6uoDVNAO.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
Hi,
anonym wrote (02 Oct 2012 13:14:58 GMT) :
30/09/12 21:01, intrigeri wrote:
please, anyone who did the 0.18 release of tails-persistence-setup,
push your pristine-tar branch.
I followed the instructions in
contribute/release_process/persistence-setup, and that branch wasn't
modified (i.e. it's still at commit 0bc2057).
Looks like you have pristine-tar disabled in your gbp configuration.
That's probably the default. I've just added pristine-tar = True to
debian/gbp.conf in the debian branch, so that won't happen anymore,
regardless of individual's configuration.
How can I fix this?
I would try re-doing the git-import-orig, with the --no-merge option.
Some steps are likely to fail, because they were run already. Then,
I would reset --hard the upstream and debian branches to their
previous state (the current one, as of when I'm writing), and then
push the pristine-tar branch updated with the missing orig
tarball delta.
todo/persistence_preset_-_NM_connections has been implemented in
feature/persistent_NM_connections. IMHO it's now in a good enough
shape to be shipped in Tails 0.14, but there are some issues (see
todo page):
Great! I hope it makes it into 0.14.
If the rest of you agree that all is good now, please review and merge
this branch into devel so it can be included in Tails 0.14.
Some notes from a (too quick) static review follow.
I'll test that code once it is merged into experimental.
+name= $self-encoding-decode(gettext(q{NetworkManager
connections})),
+description = $self-encoding-decode(gettext(
+q{Network connections}
+)),
I'm not sure end-users know what NetworkManager is, and/or want to
learn about its name. I suggest:
* name = Network Connections
(Which uses title capitalization, like other existing presets.)
* description = Configuration of network devices and connections
(All credits due to the NM applet About dialog text.)
What do you think?
Also, any thoughts about how we'll handle the migration to dconf when
Tails is based on Wheezy? (Not a blocker, I think, but still.)
To end with, I've pushed a minor doc rephrasing to that branch.
___
tails-dev mailing list
tails-dev@boum.org
https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
Hi, Ague Mill wrote (02 Oct 2012 14:08:05 GMT) : * Connect automatically checkbox gets unchecked on each boot: IMHO this bug is good :). Hence we can ignore this for now and just mention it as a known issue (commit 0f7f652). We have to rule this as either a bug or a feature. In my views, it is a feature and we just have to state it that way: Tails do not connect automatically to networks it was previously connected to. So I'd rather remove the addition to known issues, and document that behaviour better on `doc/first_steps/persistence/configure`. Agreed. ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
Re: [Tails-dev] Please review and merge feature/persistent_NM_connections [was: tails-persistence-setup releases vs. Tails 0.14]
From: anonym ano...@lavabit.com Date: Tue, 2 Oct 2012 15:14:58 +0200 [...] If the rest of you agree that all is good now, please review and merge this branch into devel so it can be included in Tails 0.14. Please merge the new state of this branch to experimental. And, by the way, is there a good reason this page is still tagged 'discuss' ? -- pgpGWxriv22qD.pgp Description: PGP signature ___ tails-dev mailing list tails-dev@boum.org https://mailman.boum.org/listinfo/tails-dev
