Re: [OSM-talk] Proposed mechanical edit: Empty Relations

2012-04-15 Thread Paul Norman
Since there still seems to be debate about some cases, would anyone object
to type=multipolygons and those missing type=* tags that are over a week and
others over a year? 

Then we can debate the validity of a relation not referenced by anything in
the database and not referencing anything itself.

 From: Paul Norman [mailto:penor...@mac.com]
 Subject: [OSM-talk] Proposed mechanical edit: Empty Relations
 
 Through editor errors or other mistakes there are a number of relations
 in OSM which have no members. I propose a mechanical edit to delete
 these where they are not members of some other way. My proposed
 procedure, documented at
 http://wiki.openstreetmap.org/wiki/Mechanical_Edits/pnorman_imports is
 to identify these with my pgsnapshot database and delete them if they
 aren't referenced by any other relation.
 
 If they are referenced by another relation I will investigate them and
 deal with them manually.
 
 I've investigated a few of them and they appear to be caused by people
 deleting ways from multipolygons but not deleting the relation. I don't
 want to investigate all 5200 by hand so I'm proposing the mechanical
 edit.
 
 I will filter out ones touched in the last 24 hours to avoid conflicting
 with anyone.
 
 If this goes ahead and anyone wishes to opt out for some unknown reason
 let me know. It would not be possible to opt out by area as an empty
 relation has no geodata associated with it.
 
 I was tempted to do this without posting, but it does fall under
 http://wiki.openstreetmap.org/wiki/Mechanical_Edit_Policy and therefore
 requires consultation.
 
 A quick sampling of the ones most recently created indicates that they
 are mainly made with JOSM, including recent versions. JOSM devs may want
 to make it harder to accidentally create a relation with no members.


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


[OSM-talk] Proposed mechanical edit: Empty Relations

2012-04-13 Thread Paul Norman
Through editor errors or other mistakes there are a number of relations in
OSM which have no members. I propose a mechanical edit to delete these where
they are not members of some other way. My proposed procedure, documented at
http://wiki.openstreetmap.org/wiki/Mechanical_Edits/pnorman_imports is to
identify these with my pgsnapshot database and delete them if they aren't
referenced by any other relation.

If they are referenced by another relation I will investigate them and deal
with them manually.

I've investigated a few of them and they appear to be caused by people
deleting ways from multipolygons but not deleting the relation. I don't want
to investigate all 5200 by hand so I'm proposing the mechanical edit.

I will filter out ones touched in the last 24 hours to avoid conflicting
with anyone.

If this goes ahead and anyone wishes to opt out for some unknown reason let
me know. It would not be possible to opt out by area as an empty relation
has no geodata associated with it.

I was tempted to do this without posting, but it does fall under
http://wiki.openstreetmap.org/wiki/Mechanical_Edit_Policy and therefore
requires consultation.

A quick sampling of the ones most recently created indicates that they are
mainly made with JOSM, including recent versions. JOSM devs may want to make
it harder to accidentally create a relation with no members.


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed mechanical edit: Empty Relations

2012-04-13 Thread Mike N

On 4/13/2012 5:12 AM, Paul Norman wrote:

I will filter out ones touched in the last 24 hours to avoid conflicting
with anyone.


Could this be extended to 30 days, or at least a week?   I remember 
creating a set from a survey on one weekend, and finishing it the 
following weekend.   I think part of this included the empty relation, 
although I would just go ahead and populate the relation immediately now 
that I know what I'm doing.


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed mechanical edit: Empty Relations

2012-04-13 Thread andrzej zaborowski
On 13 April 2012 11:12, Paul Norman penor...@mac.com wrote:
 Through editor errors or other mistakes there are a number of relations in
 OSM which have no members. I propose a mechanical edit to delete these where
 they are not members of some other way. My proposed procedure, documented at
 http://wiki.openstreetmap.org/wiki/Mechanical_Edits/pnorman_imports is to
 identify these with my pgsnapshot database and delete them if they aren't
 referenced by any other relation.

 If they are referenced by another relation I will investigate them and deal
 with them manually.

 I've investigated a few of them and they appear to be caused by people
 deleting ways from multipolygons but not deleting the relation. I don't want
 to investigate all 5200 by hand so I'm proposing the mechanical edit.

 I will filter out ones touched in the last 24 hours to avoid conflicting
 with anyone.

This thread comes up every some time
(http://lists.openstreetmap.org/pipermail/dev/2009-August/016658.html,
http://lists.openstreetmap.org/pipermail/talk/2010-November/055075.html).
 In 2009 I ran a very similar operation with 4.5k relations deleted as
discussed in the first thread I linked.  The lesson from it was that
some relations are referenced from outside of the database, mainly
from the OSM wiki.  Those should not be deleted automatically either
or it'll upset some users.

Cheers

___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] Proposed mechanical edit: Empty Relations

2012-04-13 Thread Werner Hoch
Hi Norman,

Am Freitag, den 13.04.2012, 02:12 -0700 schrieb Paul Norman:
 Through editor errors or other mistakes there are a number of relations in
 OSM which have no members. I propose a mechanical edit to delete these where
 they are not members of some other way. My proposed procedure, documented at
 http://wiki.openstreetmap.org/wiki/Mechanical_Edits/pnorman_imports is to
 identify these with my pgsnapshot database and delete them if they aren't
 referenced by any other relation.

In the following mail already mentioned by andrzej I've anounced a
wikipage about the reasons of empty relations.
http://lists.openstreetmap.org/pipermail/talk/2010-November/055075.html

Here's the wiki page:
http://wiki.openstreetmap.org/wiki/Empty_relations

In the following weeks I've talked to many osm editors that created lot
of empty relations and I've deleted those that obviously have been
created accidently.

I can not remember how many relations I've deleted since Nov 2010. Maybe
around 35000 or more.
I've restore several relations, too, when I thought the empty relation
was the result of wrong merge conflict resolution. (see wiki page for
details)

I'm still updating the statistic page from time to time:
http://www.h-renrew.de/h/osm/osmchecks/02_Relationstypen/empty_relations.html
and delete the relations with the rules I've written down on the wiki
page.

I've never got an answer from the Naptan importers. The naptan import is
the largest single creator of empty relations.

Regards
Werner


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk