Re: [OSM-talk] cyclemap layer z18 trouble?

2009-02-28 Thread Jon Burgess
On Sat, 2009-02-28 at 13:38 +, Jon Burgess wrote:
> On Sat, 2009-02-28 at 11:20 +, Dave Stubbs wrote:
> > The renderd process had crashed for some reason.. I've restarted it. I
> > deleted all the z18 tiles the other day because we're running out of
> > tile cache space (about 400GB)... a combination of that and the
> > process crash means that it's been churning out 404s for a while.
> > Anyway should all be working now.
> 
> I'd be interested if you could obtain a backtrace for any crashes and
> I'll investigate them. Capturing the core file by running the renderd
> from a shell with "ulimit -c unlimited" seems to be the best way to do
> this.
> 
> Over the past couple of days I've seen several crashes on the main OSM
> site and I've just tracked one of them back to an infinite recursion
> problem in the agg code. Applying the attached patch seems to fix it,
> provided you build with INTERNAL_LIBAGG=True. 
> 
> I have not been able to figure out which OSM feature was triggering
> this, but it occurs when rendering the metatile containing:
> http://tile.openstreetmap.org/17/78728/52568.png

I found the way causing the problem, approx 1km long:
http://www.openstreetmap.org/browse/way/31278148

It seems unusual for a new way to be using such low node IDs, it looks
like something got confused when creating new nodes.

Jon


___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] cyclemap layer z18 trouble?

2009-02-28 Thread Jon Burgess
On Sat, 2009-02-28 at 11:20 +, Dave Stubbs wrote:
> The renderd process had crashed for some reason.. I've restarted it. I
> deleted all the z18 tiles the other day because we're running out of
> tile cache space (about 400GB)... a combination of that and the
> process crash means that it's been churning out 404s for a while.
> Anyway should all be working now.

I'd be interested if you could obtain a backtrace for any crashes and
I'll investigate them. Capturing the core file by running the renderd
from a shell with "ulimit -c unlimited" seems to be the best way to do
this.

Over the past couple of days I've seen several crashes on the main OSM
site and I've just tracked one of them back to an infinite recursion
problem in the agg code. Applying the attached patch seems to fix it,
provided you build with INTERNAL_LIBAGG=True. 

I have not been able to figure out which OSM feature was triggering
this, but it occurs when rendering the metatile containing:
http://tile.openstreetmap.org/17/78728/52568.png

Jon
Index: agg/include/agg_rasterizer_cells_aa.h
===
--- agg/include/agg_rasterizer_cells_aa.h	(revision 930)
+++ agg/include/agg_rasterizer_cells_aa.h	(working copy)
@@ -323,6 +323,12 @@
 {
 int cx = (x1 + x2) >> 1;
 int cy = (y1 + y2) >> 1;
+
+// Bail if values are so large they are likely to wrap
+if ((abs(x1) >= INT_MAX/2) || (abs(y1) >= INT_MAX/2) ||
+(abs(x2) >= INT_MAX/2) || (abs(y2) >= INT_MAX/2))
+return;
+
 line(x1, y1, cx, cy);
 line(cx, cy, x2, y2);
 }
___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] cyclemap layer z18 trouble?

2009-02-28 Thread Dave Stubbs
2009/2/27 Richard Weait :
> Anybody else having trouble with cyclemap at z18?
>
> For me, this link delivers only a blank white map area.  The browser
> claims to have finished loading.  Right-clicking on the map area does
> not offer view image.
>
> I've tried this on Firefox/Linux and Epiphany/Linux and another
> browser/wine.
>
> http://www.openstreetmap.org/?lat=43.652824&lon=-79.383785&zoom=18&layers=00B0FTF
>
> Anybody else seeing this?
>


The renderd process had crashed for some reason.. I've restarted it. I
deleted all the z18 tiles the other day because we're running out of
tile cache space (about 400GB)... a combination of that and the
process crash means that it's been churning out 404s for a while.
Anyway should all be working now.

Dave

___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk


Re: [OSM-talk] cyclemap layer z18 trouble?

2009-02-28 Thread Andy Robinson
Richard Weait wrote:
> Anybody else having trouble with cyclemap at z18?
>
> For me, this link delivers only a blank white map area.  The browser
> claims to have finished loading.  Right-clicking on the map area does
> not offer view image.  
>
> I've tried this on Firefox/Linux and Epiphany/Linux and another
> browser/wine.  
>
> http://www.openstreetmap.org/?lat=43.652824&lon=-79.383785&zoom=18&layers=00B0FTF
>
> Anybody else seeing this?  
>
> Best regards,
> Richard
>
>
> ___
> talk mailing list
> talk@openstreetmap.org
> http://lists.openstreetmap.org/listinfo/talk
>   
If you go to www.opencyclemap.org you will see lots of "coming soon" at Z18


Cheers

Andy

___
talk mailing list
talk@openstreetmap.org
http://lists.openstreetmap.org/listinfo/talk