Re: [Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Greg]

Thanks for your suggestions, Dave F. I’ve created a number of issues in the 
GitHub repository (see links below). I won’t have time to improve the code for 
a while, but at least we will be able to keep track of suggestions. I am of 
course open to pull requests if anyone wants to have a go at improving it.


> The latest total for this district is 1767, so appears a bit more than a week 
> behind.
> Could the update date be added on the page so there's a guide to their 
> accuracy?

There is a date/time at the bottom of each district page, which reflects when 
that HTML page was generated. The update script gets the FHRS data using their 
API and downloads OSM data from GeoFabrik before processing the data and 
creating the HTML pages and JSON files which feed the slippy maps. The whole 
process takes an hour and a half ish.

The GeoFabrik data is probably a bit behind, but this seems the most convenient 
way to obtain large amounts of OSM data without having to filter the entire 
planet file.

https://github.com/gregrs-uk/python-fhrs-osm/issues/4 



> Could a 'Relevant OSM nodes/ways without fhrs:id' statistic be added?

Probably, although the goal of the tool is really to improve the OSM address 
(and particularly postcode) data, hence the ‘Relevant OSM nodes/ways without 
fhrs:id or postcode’ statistic instead. (There are generally quite a number of 
establishments with a postcode but no fhrs:id, although in Bath and NE Somerset 
I see there are loads of establishments with an fhrs:id but no postcode.)

https://github.com/gregrs-uk/python-fhrs-osm/issues/5 



> A Download (as Geojson?) of the mismatched/missing lists would be very 
> helpful.

JSON files are already created to feed the slippy maps, so could you try 
[http://gregrs.dev.openstreetmap.org/fhrs/json/overview-270.json 
] for example? 
What were you hoping to use the downloaded files for? Let me know if the linked 
one already does what you’d like and I can add links to the HTML pages.


> Does it check relations?

No, just nodes and ways at the moment.

https://github.com/gregrs-uk/python-fhrs-osm/issues/6 



> I'm a bit confused. It says:
> 'Relevant OSM nodes/ways without fhrs:id or postcode' = 173
> but then says:
> 'Percentage of relevant OSM nodes/ways with FHRS match or postcode' = 6.3%
> Am I misunderstanding something?

I’ve been through the code that generates the stats again to check what’s going 
on.

‘Relevant OSM nodes/ways without fhrs:id or postcode’ – seems to be OSM 
nodes/ways which have neither an fhrs:id that matches one in the FHRS database 
nor an addr:postcode.

‘Percentage of relevant OSM nodes/ways with FHRS match or postcode’ – this 
includes OSM nodes/ways which have an fhrs:id and postcode that both match the 
FHRS database, and those with a postcode but no fhrs:id. This doesn’t include 
those with a non-matching fhrs:id, or those for which the postcodes don’t agree 
(including cases where the OSM postcode is not set). This is probably what is 
misleading because the large number of establishments in Bath with a valid 
fhrs:id but no postcode will not be included. It’s meant as a measure of 
‘completeness’ really, with the goal to tag establishments with a postcode and 
possibly an fhrs:id. I think the label probably needs changing though.

https://github.com/gregrs-uk/python-fhrs-osm/issues/5 
 again


Thanks,
Greg.___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb

Re: [Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Greg]

I don’t usually bother with fhrs:authority or rating for the reasons Dave F has 
already suggested.

The FHRS data is often a good source for address and postcode data though, 
which was the reason for me writing the tool. It should hopefully provide a 
quicker way of getting this into JOSM.

Thanks,
Greg.

P.S. I’m not on Twitter but I believe someone tweeted @drsiant about my code. 
She probably won’t have seen the latest link for the entire of GB though so 
feel free to share it!


> On 2 Sep 2016, at 12:38, Jez Nicholson  wrote:
> 
> and have you met @drsiant  ? 
> https://twitter.com/drsiant 
> On Fri, 2 Sep 2016 at 12:25 Jez Nicholson  > wrote:
> Nice job.
> 
> Is the intention to apply fhrs:id only? I see that fhrs:rating and 
> fhrs:authority are offered in the iD editor. Personally, I would put the id 
> only. The authority at a push, and not the rating as it is temporal.
> 
> Regards,
>   Jez

___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb

Re: [Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Dave F]

fhrs:id is all I'm adding. It provides the required link into the fhrs 
database to retrieve all the other info on a specific establishment.


I certainly wouldn't add the ephemeral fhrs:rating.
I think the authority tag falls into the same camp as 'is_in'. It's 
superfluous if the administration is mapped as a boundary, which I'm 
pretty sure is the case for all the UK.


Cheers
Dave F.

On 02/09/2016 12:25, Jez Nicholson wrote:

Nice job.

Is the intention to apply fhrs:id only? I see that fhrs:rating and 
fhrs:authority are offered in the iD editor. Personally, I would put 
the id only. The authority at a push, and not the rating as it is 
temporal.


Regards,
  Jez




___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb

Re: [Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Dave F]

Hi
Looks very interesting

Bullet points of my thoughts are below.

On 31/08/2016 21:45, Greg wrote:

Hi all,

I have now set up these tools on the dev server to provide comparison
maps and statistics for the whole of Great Britain. They should be
updated weekly.

http://gregrs.dev.openstreetmap.org/fhrs/district-270.html

The latest total for this district is 1767, so appears a bit more than a 
week behind.
Could the update date be added on the page so there's a guide to their 
accuracy?


Could a 'Relevant OSM nodes/ways without fhrs:id' statistic be added?

A Download (as Geojson?) of the mismatched/missing lists would be very 
helpful.


Does it check relations?

I'm a bit confused. It says:
'Relevant OSM nodes/ways without fhrs:id or postcode' = 173
but then says:
'Percentage of relevant OSM nodes/ways with FHRS match or postcode' = 6.3%
Am I misunderstanding something?

Thanks
Dave F.

___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb

Re: [Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Jez Nicholson]

and have you met @drsiant  ?
https://twitter.com/drsiant

On Fri, 2 Sep 2016 at 12:25 Jez Nicholson  wrote:

> Nice job.
>
> Is the intention to apply fhrs:id only? I see that fhrs:rating and
> fhrs:authority are offered in the iD editor. Personally, I would put the id
> only. The authority at a push, and not the rating as it is temporal.
>
> Regards,
>   Jez
>
> On Wed, 31 Aug 2016 at 21:47 Greg  wrote:
>
>> Hi all,
>>
>> I posted to the West Midlands list in April (and a reply was CC'd here)
>> regarding some tools I've developed for visualising Food Hygiene Rating
>> Scheme (FHRS) and OSM data, finding possible matches between it and
>> importing useful tags into JOSM.
>>
>> I have now set up these tools on the dev server to provide comparison
>> maps and statistics for the whole of Great Britain. They should be
>> updated weekly. Just go to [http://gregrs.dev.openstreetmap.org/fhrs/]
>> and select a district.
>>
>> I think the FHRS data is a useful source of postcodes and addresses, and
>> it can also be a helpful reminder of local establishments to add to the
>> map. It is my hope that these tools could help us to efficiently add and
>> verify data in our local areas. Please do have a look at the link above.
>>
>> If anyone would like to improve or re-use parts of the code, it's
>> available on GitHub: [https://github.com/gregrs-uk/python-fhrs-osm]
>>
>> Thanks,
>> Greg.
>>
>> ___
>> Talk-GB mailing list
>> Talk-GB@openstreetmap.org
>> https://lists.openstreetmap.org/listinfo/talk-gb
>>
>
___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb

Re: [Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Jez Nicholson]

Nice job.

Is the intention to apply fhrs:id only? I see that fhrs:rating and
fhrs:authority are offered in the iD editor. Personally, I would put the id
only. The authority at a push, and not the rating as it is temporal.

Regards,
  Jez

On Wed, 31 Aug 2016 at 21:47 Greg  wrote:

> Hi all,
>
> I posted to the West Midlands list in April (and a reply was CC'd here)
> regarding some tools I've developed for visualising Food Hygiene Rating
> Scheme (FHRS) and OSM data, finding possible matches between it and
> importing useful tags into JOSM.
>
> I have now set up these tools on the dev server to provide comparison
> maps and statistics for the whole of Great Britain. They should be
> updated weekly. Just go to [http://gregrs.dev.openstreetmap.org/fhrs/]
> and select a district.
>
> I think the FHRS data is a useful source of postcodes and addresses, and
> it can also be a helpful reminder of local establishments to add to the
> map. It is my hope that these tools could help us to efficiently add and
> verify data in our local areas. Please do have a look at the link above.
>
> If anyone would like to improve or re-use parts of the code, it's
> available on GitHub: [https://github.com/gregrs-uk/python-fhrs-osm]
>
> Thanks,
> Greg.
>
> ___
> Talk-GB mailing list
> Talk-GB@openstreetmap.org
> https://lists.openstreetmap.org/listinfo/talk-gb
>
___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb

[Talk-GB] Tools for using Food Hygiene data e.g. quickly adding addresses/postcodes

[Greg]

Hi all,

I posted to the West Midlands list in April (and a reply was CC'd here)
regarding some tools I've developed for visualising Food Hygiene Rating
Scheme (FHRS) and OSM data, finding possible matches between it and
importing useful tags into JOSM.

I have now set up these tools on the dev server to provide comparison
maps and statistics for the whole of Great Britain. They should be
updated weekly. Just go to [http://gregrs.dev.openstreetmap.org/fhrs/]
and select a district.

I think the FHRS data is a useful source of postcodes and addresses, and
it can also be a helpful reminder of local establishments to add to the
map. It is my hope that these tools could help us to efficiently add and
verify data in our local areas. Please do have a look at the link above.

If anyone would like to improve or re-use parts of the code, it's
available on GitHub: [https://github.com/gregrs-uk/python-fhrs-osm]

Thanks,
Greg.

___
Talk-GB mailing list
Talk-GB@openstreetmap.org
https://lists.openstreetmap.org/listinfo/talk-gb