Re: Difference between pf_test and pf_test6
* Vadim Zhukov persg...@gmail.com [2009-10-07 10:30]: Hello all again. Could anyone explain the reasons of the following difference? More precisely: 1. Why does pf_test() add log flag PF_LOG_FORCE, and pf_test6() resets log flag to plain 1 (PF_LOG)? i probably missed the ipvshit case when fixing the log flag abuse -- Henning Brauer, h...@bsws.de, henn...@openbsd.org BS Web Services, http://bsws.de Full-Service ISP - Secure Hosting, Mail and DNS Services Dedicated Servers, Rootservers, Application Hosting - Hamburg Amsterdam
Re: Difference between pf_test and pf_test6
On 7 October 2009 c. 13:38:54 Henning Brauer wrote:
* Vadim Zhukov persg...@gmail.com [2009-10-07 10:30]:
Hello all again.
Could anyone explain the reasons of the following difference? More
precisely:
1. Why does pf_test() add log flag PF_LOG_FORCE, and pf_test6()
resets log flag to plain 1 (PF_LOG)?
i probably missed the ipvshit case when fixing the log flag abuse
So this patch should be somewhat OK? I looked on pf_test() for analogies.
--
Best wishes,
Vadim Zhukov
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
Index: pf.c
===
RCS file: /cvs/src/sys/net/pf.c,v
retrieving revision 1.664
diff -u -p -r1.664 pf.c
--- pf.c6 Oct 2009 21:21:48 - 1.664
+++ pf.c7 Oct 2009 10:44:32 -
@@ -5767,7 +5767,7 @@ pf_test6(int dir, struct ifnet *ifp, str
if (m-m_pkthdr.len (int)sizeof(*h)) {
action = PF_DROP;
REASON_SET(reason, PFRES_SHORT);
- log = 1;
+ log |= PF_LOG_FORCE;
goto done;
}
@@ -5825,7 +5825,7 @@ pf_test6(int dir, struct ifnet *ifp, str
(pf: IPv6 more than one rthdr\n));
action = PF_DROP;
REASON_SET(reason, PFRES_IPOPTIONS);
- log = 1;
+ log |= PF_LOG_FORCE;
goto done;
}
if (!pf_pull_hdr(m, off, rthdr, sizeof(rthdr), NULL,
@@ -5834,7 +5834,7 @@ pf_test6(int dir, struct ifnet *ifp, str
(pf: IPv6 short rthdr\n));
action = PF_DROP;
REASON_SET(reason, PFRES_SHORT);
- log = 1;
+ log |= PF_LOG_FORCE;
goto done;
}
if (rthdr.ip6r_type == IPV6_RTHDR_TYPE_0) {
@@ -5842,7 +5842,7 @@ pf_test6(int dir, struct ifnet *ifp, str
(pf: IPv6 rthdr0\n));
action = PF_DROP;
REASON_SET(reason, PFRES_IPOPTIONS);
- log = 1;
+ log |= PF_LOG_FORCE;
goto done;
}
/* FALLTHROUGH */
@@ -5858,7 +5858,7 @@ pf_test6(int dir, struct ifnet *ifp, str
DPFPRINTF(PF_DEBUG_MISC,
(pf: IPv6 short opt\n));
action = PF_DROP;
- log = 1;
+ log |= PF_LOG_FORCE;
goto done;
}
if (pd.proto == IPPROTO_AH)
@@ -5887,7 +5887,8 @@ pf_test6(int dir, struct ifnet *ifp, str
pd.hdr.tcp = th;
if (!pf_pull_hdr(m, off, th, sizeof(th),
action, reason, AF_INET6)) {
- log = action != PF_PASS;
+ if (action != PF_PASS)
+ log |= PF_LOG_FORCE;
goto done;
}
pd.p_len = pd.tot_len - off - (th.th_off 2);
@@ -5904,7 +5905,7 @@ pf_test6(int dir, struct ifnet *ifp, str
#endif /* NPFSYNC */
r = s-rule.ptr;
a = s-anchor.ptr;
- log = s-log;
+ log |= s-log;
} else if (s == NULL)
action = pf_test_rule(r, s, dir, kif,
m, off, h, pd, a, ruleset, ip6intrq);
@@ -5924,7 +5925,8 @@ pf_test6(int dir, struct ifnet *ifp, str
pd.hdr.udp = uh;
if (!pf_pull_hdr(m, off, uh, sizeof(uh),
action, reason, AF_INET6)) {
- log = action != PF_PASS;
+ if (action != PF_PASS)
+ log |= PF_LOG_FORCE;
goto done;
}
if (uh.uh_dport == 0 ||
@@ -5943,7 +5945,7 @@ pf_test6(int dir, struct ifnet *ifp, str
#endif /* NPFSYNC */
r = s-rule.ptr;
a = s-anchor.ptr;
- log = s-log;
+ log |= s-log;
} else if (s == NULL)
action = pf_test_rule(r, s, dir, kif,
m, off, h, pd, a, ruleset, ip6intrq);
@@ -5968,7 +5970,8 @@ pf_test6(int dir, struct ifnet *ifp, str
pd.hdr.icmp6 = ih.icmp6;
if (!pf_pull_hdr(m, off, ih, icmp_hlen,
action,
Distro Summit 2010: call for papers extended until 18 Oct 2009
Please redistribute this call for papers. The deadline has been extended to 18 Oct 2009. === CALL FOR PAPERS === Distro Summit 2010 is a one-day technical conference with a strong focus on collaboration between Free Software distributions hosted at the linux.conf.au 2010. We are looking for proposals from any Free Software distribution, from the typical full distributions (both linux and non-linux) to the niche market derivatives. In spite of the strong focus on collaboration between Free Software distributions, topics may include packaging, maintenance, relationship with upstream developers, release management and QA. For more informtion, please visit: http://distrosummit.org. Important dates === * Call for papers ends: Wednesday 18 October 2009 * Announcing the schedule: Friday 2 October 2009 * Conference begins: Monday 18 January 2010 Presentation types == We will accept proposals for: * 25 minute standard-length presentations; * 50 minute long presentations. Session lengths include time for audience questions. We intend for standard-length presentation to make up the vast majority of our presentations. If you plan on submitting a proposal for a long presentation, a willingness to present a standard-length presentation will impact positively on your proposal. Submit a proposal = To submit your proposal, we'll need the following information: * Your name, contact details and a short biography; * Your proposal title; * Intended audience; * An abstract; * Presentation outline; * Presentation type (standard-length or long). To submit a proposal, or get more information, please write to c...@distrosummit.org. Unfortunately, we cannot offer sponsorship for speakers. About the Distro Summit === The Distro Summit 2010 is a one-day developer conference with a strong focus on collaboration between free software distributions hosted at the linux.conf.au 2010 (http://www.lca2010.org.nz). In addition to a schedule of technical, social and policy talks, the Distro Summit provides an opportunity for developers, contributors and other interested people to meet in person and work together more closely. Previous similar events have featured speakers from around the world. They have also been extremely beneficial for developing key free software software components and for improving collaboration and sharing between the different distributions. Target Audience === The Distro Summit is (mainly) a technical event, but this does not mean that the only target audience are developers and maintainers of free software distributions: the event will feature talks that range from the development to real-world use cases, going through marketing and the social aspects of the maintenance of free software distributions. -- Martin Krafft on the behalf of the Distro Summit organizers
Re: cwm - menu pops up when clicking inside a window
On Fri 2009.10.02 at 10:33 +0200, Thomas Pfaff wrote: Hi. This is not a new issue, but I thought it was about time to report it. Some programs will pop up the menu_unhide (launch hidden window list) menu when being clicked certain places inside their window. Examples are Sylpheed, Pidgin, and gvim. Please see http://tp76.info/menu_unhide for a list of images that show where to click to bring up menu_unhide. heh - i never noticed until just now... along with others, i too will take a look. Surely this behaviour is not intended? The menu should only pop up when clicking the root window, yes? I don't have a patch for this, sorry.
Re: cwm(1) change on 9/25
On Fri 2009.10.02 at 00:32 +0159, Simon Nicolussi wrote:
Hello,
as a consequence to the last change to cwm(1) no borders are being drawn
for maximized windows. This is fine as long as there's no gap defined in
the cwmrc(5), otherwise the borders between window and gaps are missing.
Is this behaviour intended?
There's another strange problem I experienced after this change: Almost
every time I try to maximize my Firefox window its whole content freezes
and returns back to normal as soon as I resize the window with my mouse.
I haven't really looked into this, though.
i haven't experienced this (yet) - does this still occur if you simply
backout the change?
Here's a patch that addresses theses issues: Now maximized windows keep
all four borders, but always inside the screen (and thus visible for the
user) and Firefox behaves as before the change.
the below changes the current behaviour of fullscreen, now adding a
border.
of course, if we did this, it would match other tiling wm's, all of
which i know do have a border, fullscreened or not.
Tested on amd64 but unfortunately no multi-monitor configuration.
Index: client.c
===
RCS file: /cvs/xenocara/app/cwm/client.c,v
retrieving revision 1.65
diff -u client.c
--- client.c 25 Sep 2009 15:57:49 - 1.65
+++ client.c 1 Oct 2009 21:30:27 -
@@ -246,8 +246,10 @@
calc:
cc-geom.x = x_org + Conf.gap_left;
cc-geom.y = y_org + Conf.gap_top;
- cc-geom.height = ymax - (Conf.gap_top + Conf.gap_bottom);
- cc-geom.width = xmax - (Conf.gap_left + Conf.gap_right);
+ cc-geom.height = ymax - (cc-bwidth * 2) -
+ (Conf.gap_top + Conf.gap_bottom);
+ cc-geom.width = xmax - (cc-bwidth * 2) -
+ (Conf.gap_left + Conf.gap_right);
cc-flags |= CLIENT_DOMAXIMIZE;
}
@@ -323,7 +325,6 @@
CLIENT_HMAXIMIZED);
if (cc-flags CLIENT_DOMAXIMIZE) {
- cc-bwidth = 0;
cc-flags = ~CLIENT_DOMAXIMIZE;
cc-flags |= CLIENT_MAXIMIZED;
} else if (cc-flags CLIENT_DOVMAXIMIZE) {
@@ -332,11 +333,7 @@
} else if (cc-flags CLIENT_DOHMAXIMIZE) {
cc-flags = ~CLIENT_DOHMAXIMIZE;
cc-flags |= CLIENT_HMAXIMIZED;
- } else {
- cc-bwidth = Conf.bwidth;
}
-
- client_draw_border(cc);
XMoveResizeWindow(X_Dpy, cc-win, cc-geom.x,
cc-geom.y, cc-geom.width, cc-geom.height);
--
Simon Nicolussi, simon.nicolu...@student.uibk.ac.at
http://homepage.uibk.ac.at/~csag9583/
Re: FW: Broadcom BCM5787
Still some problems.. System is uppdated to current.. Hangs at bge0 at pci3 dev 0 function 0 Broadcom BCM5787M rev 0x02, BCM5754/5787 A2 (0xb002) Anybody have any ideas ? otherwise I will have to send the machine back.. OpenBSD/i386 BOOT 3.02... boot booting hd0a:/bsd: 24491124+1053776 [52+344688+327471]=0x1900c0c entry point at 0x200120 [ using 672584 bytes of bsd ELF symbol table ] Copyright (c) 1982, 1986, 1989, 1991, 1993 The Regents of the University of California. All rights reserved. Copyright (c) 1995-2009 OpenBSD. All rights reserved. http://www.OpenBSD.org OpenBSD 4.6-current (GENERIC) #0: Tue Oct 6 21:55:29 CEST 2009 dr...@probec.islan.lab:/opt/flash/flashboot/obj/GENERIC cpu0: VIA C7 Processor 1000MHz (CentaurHauls 686-class) 1 GHz cpu0: FPU,V86,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,CMOV,PAT,CFLUSH,ACPI,MMX ,FXSR,SSE,SSE2,TM,SBF,SSE3,EST,TM2,xTPR real mem = 519663616 (495MB) avail mem = 477478912 (455MB) mainbus0 at root bios0 at mainbus0: AT/286+ BIOS, date 05/27/08, BIOS32 rev. 0 @ 0xfb5c0, SMBIOS rev. 2.3 @ 0xf0800 (33 entries) bios0: vendor Phoenix Technologies, LTD version 6.00 PG date 05/27/2008 apm0 at bios0: Power Management spec V1.2 (slowidle) apm0: AC on, battery charge unknown acpi at bios0 function 0x0 not configured pcibios0 at bios0: rev 3.0 @ 0xf/0xdc04 pcibios0: PCI IRQ Routing Table rev 1.0 @ 0xfda50/416 (24 entries) pcibios0: bad IRQ table checksum pcibios0: PCI BIOS has 25 Interrupt Routing table entries pcibios0: PCI Exclusive IRQs: 5 7 10 11 pcibios0: no compatible PCI ICU found pcibios0: Warning, unable to fix up PCI interrupt routing pcibios0: PCI bus #2 is the last bus bios0: ROM list: 0xc/0xf200 0xd/0x8000! cpu0 at mainbus0: (uniprocessor) cpu0: RNG AES AES-CTR SHA1 SHA256 RSA cpu0: unknown Enhanced SpeedStep CPU, msr 0x08100a1308000a13 cpu0: using only highest and lowest power states cpu0: Enhanced SpeedStep 998 MHz: speeds: 1333, 1067 MHz pci0 at mainbus0 bus 0: configuration mode 1 (bios) pchb0 at pci0 dev 0 function 0 VIA CN700 Host rev 0x00 viaagp0 at pchb0: v3 agp0 at viaagp0: aperture at 0xd000, size 0x1000 pchb1 at pci0 dev 0 function 1 VIA CN700 Host rev 0x00 pchb2 at pci0 dev 0 function 2 VIA CN700 Host rev 0x00 pchb3 at pci0 dev 0 function 3 VIA PT890 Host rev 0x00 pchb4 at pci0 dev 0 function 4 VIA CN700 Host rev 0x00 pchb5 at pci0 dev 0 function 7 VIA CN700 Host rev 0x00 ppb0 at pci0 dev 1 function 0 VIA VT8377 AGP rev 0x00 pci1 at ppb0 bus 1 vga1 at pci1 dev 0 function 0 VIA S3 Unichrome PRO IGP rev 0x01 wsdisplay0 at vga1 mux 1: console (80x25, vt100 emulation) wsdisplay0: screen 1-5 added (80x25, vt100 emulation) pciide0 at pci0 dev 15 function 0 vendor VIA, unknown product 0x5287 rev 0x07: DMA (unsupported), channel 0 configured to compatibility, channel 1 configured to compatibility pciide0: channel 0 ignored (not responding; disabled or no drives?) wd0 at pciide0 channel 1 drive 0: SanDisk SDCFH-002G wd0: 1-sector PIO, LBA, 1918MB, 3928176 sectors uhci0 at pci0 dev 16 function 0 VIA VT83C572 USB rev 0x91: irq 11 uhci1 at pci0 dev 16 function 1 VIA VT83C572 USB rev 0x91: irq 7 uhci2 at pci0 dev 16 function 2 VIA VT83C572 USB rev 0x91: irq 10 uhci3 at pci0 dev 16 function 3 VIA VT83C572 USB rev 0x91: irq 5 ehci0 at pci0 dev 16 function 4 VIA VT6202 USB rev 0x90: irq 7 usb0 at ehci0: USB revision 2.0 uhub0 at usb0 VIA EHCI root hub rev 2.00/1.00 addr 1 viapm0 at pci0 dev 17 function 0 VIA VT8251 ISA rev 0x00 iic0 at viapm0 spdmem0 at iic0 addr 0x50: 512MB DDR2 SDRAM non-parity PC2-4200CL3 SO-DIMM pchb6 at pci0 dev 17 function 7 VIA VT8251 VLINK rev 0x00 ppb1 at pci0 dev 19 function 0 VIA VT8251 PCIE rev 0x00 pci2 at ppb1 bus 128 bridge io address conflict 0xc000/0x1000 bridge mem address conflict 0xcfb0/0x10 bridge mem address conflict 0xcfe0/0x10 bridge io address conflict 0xb000/0x1000 bridge mem address conflict 0xcfd0/0x10 bridge mem address conflict 0xcfc0/0x10 ppb2 at pci2 dev 0 function 0 VIA VT8251 PCIE rev 0x00: irq 5 pci3 at ppb2 bus 129 bge0 at pci3 dev 0 function 0 Broadcom BCM5787M rev 0x02, BCM5754/5787 A2 (0xb002) Hangs here.. Mvh Daniel Rapp Incabus Systems AB Vdxel: + 46 8 556 964 60 http://www.incabus.com -Original Message- From: owner-t...@openbsd.org [mailto:owner-t...@openbsd.org] On Behalf Of Mark Kettenis Sent: den 5 oktober 2009 14:21 To: Daniel Rapp Cc: tech@openbsd.org Subject: Re: FW: Broadcom BCM5787 Date: Mon, 5 Oct 2009 14:03:08 +0200 From: Daniel Rapp daniel.r...@incabus.com Hi, Here are the dmesg and pcidump -v I have asked the developers and they are positive ther is two gigabit network ports with BCM5787 chipset on there, there are also two 10/100 ports with the BCM4401 and those are found.. ... pchb6 at pci0 dev 17 function 7 VIA VT8251 VLINK rev 0x00 pchb7 at pci0 dev 19 function 0 VIA VT8251 PCIE rev 0x00 Ah, a VIA VT8251 chipset. This should be fixed in -current.
Re: FW: Broadcom BCM5787
Date: Wed, 7 Oct 2009 14:23:01 +0200 From: Daniel Rapp daniel.r...@incabus.com Still some problems.. System is uppdated to current.. Hangs at bge0 at pci3 dev 0 function 0 Broadcom BCM5787M rev 0x02, BCM5754/5787 A2 (0xb002) Anybody have any ideas ? otherwise I will have to send the machine back.. Can you boot the machine with those bge's disabled (boot -c, disable bge at the UKC prompt) and send me dmesg, pcidump -xv and acpidump -o output? Please send things directly o me as the list will strip off any attachments.
Re: FW: Broadcom BCM5787
Daniel Rapp wrote: Anybody have any ideas ? otherwise I will have to send the machine back.. .. acpi at bios0 function 0x0 not configured pcibios0 at bios0: rev 3.0 @ 0xf/0xdc04 pcibios0: PCI IRQ Routing Table rev 1.0 @ 0xfda50/416 (24 entries) pcibios0: bad IRQ table checksum pcibios0: PCI BIOS has 25 Interrupt Routing table entries pcibios0: PCI Exclusive IRQs: 5 7 10 11 pcibios0: no compatible PCI ICU found pcibios0: Warning, unable to fix up PCI interrupt routing pcibios0: PCI bus #2 is the last bus ... Hi, What about trying ACPI? those pcibios warnings don't look very pleasant.. boot boot -c UKC disable apm UKC quit Perhaps that may work. -Brynet.
Lebanon, Thailand, Cyprus Opportunities for Investors
You are seeing this message in Text format. if your email is in the junk folder, add the sender email to your address book and move this email into your inbox to view the HTML version.
Re: cwm(1) change on 9/25
Okan Demirmen wrote: i haven't experienced this (yet) - does this still occur if you simply backout the change? No, no problem at all with revision 1.64 of client.c. -- Simon Nicolussi, simon.nicolu...@student.uibk.ac.at http://homepage.uibk.ac.at/~csag9583/
