Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2004-10-28 Thread Geoffrey Young 
@
if (my $custom_config_path = custom_config_path()) {
debug loading custom config data from: '$custom_config_path';
$custom_config_loaded++;
   +($candidate) = $candidate=~/^(.*)/; # launder for -T
require $custom_config_path;

huh?

something is definitely wrong here - there is no $candidate in the scope of
the current function, so this actually fails with errors.

$ perl Makefile.PL -apxs /apache/2.0/prefork/perl-5.8.5/bin/apxs
Global symbol $candidate requires explicit package name at
lib/Apache/TestConfig.pm line 2080.

--Geoff

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2004-10-28 Thread Geoffrey Young 


[EMAIL PROTECTED] wrote:
 geoff   2004/10/28 07:33:56
 
   Modified:perl-framework/Apache-Test Changes
perl-framework/Apache-Test/lib/Apache TestConfig.pm
   Log:
   revert last change to keep things compiling

sorry stas if you would have gotten to this quickly, but I thought it was a
good idea to keep things in cvs compiling and gozer said you would be
offline for a few days due to a crazy landlord or something :)

--Geoff

Re: cvs commit: httpd-test/perl-framework/t/security CAN-2004-0940.t

2004-10-28 Thread Geoffrey Young 


[EMAIL PROTECTED] wrote:
 jorton  2004/10/25 06:04:14
 
   Modified:perl-framework/t/conf extra.conf.in
   Added:   perl-framework/t/htdocs/security CAN-2004-0940.shtml
perl-framework/t/security CAN-2004-0940.t
   Log:
   Regression test for CAN-2004-0940, 1.3 mod_include overflow.

hi joe :)

I get the following failures on 1.3.32 but not on 1.3.33.

t/modules/rewrite.t  222   9.09%  18 20
t/security/CAN-2004-0940.t11 100.00%  1
t/security/CAN-2004-0958.t92  22.22%  1 3

I think these are all recent additions from you.  should each of these
failures be skipped unless something like

  ( have_apache(1)  have_min_apache_version(1.3.33) ) ||
  ( have_apache(2)  have_min_apache_version(2.0.XX) )

?

--Geoff

Re: cvs commit: httpd-test/perl-framework/t/security CAN-2004-0940.t

2004-10-28 Thread Cliff Woolley 
On Thu, 28 Oct 2004, Geoffrey Young wrote:

 I get the following failures on 1.3.32 but not on 1.3.33.

 t/modules/rewrite.t  222   9.09%  18 20
 t/security/CAN-2004-0940.t11 100.00%  1
 t/security/CAN-2004-0958.t92  22.22%  1 3

 I think these are all recent additions from you.  should each of these
 failures be skipped unless something like

   ( have_apache(1)  have_min_apache_version(1.3.33) ) ||
   ( have_apache(2)  have_min_apache_version(2.0.XX) )

I don't think so -- it's detecting an actual legitimate failure.  It's not
that the test requires a new version to work right, it's that that
particular version was broken.  No sense obfuscating that fact.

--Cliff

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfig.pm

2004-10-28 Thread Stas Bekman 
Geoffrey Young wrote:
[EMAIL PROTECTED] wrote:
geoff   2004/10/28 07:33:56
 Modified:perl-framework/Apache-Test Changes
  perl-framework/Apache-Test/lib/Apache TestConfig.pm
 Log:
 revert last change to keep things compiling

sorry stas if you would have gotten to this quickly, but I thought it was a
good idea to keep things in cvs compiling and gozer said you would be
offline for a few days due to a crazy landlord or something :)
That's exactly right. you did the right thing. I'm still relying on a 
anonymous friendly neighbour somewhere on the same block to get my oxygen. 
One day we will be able to get online in a matter of seconds...

--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com