Re: Subscription

2005-09-13 Thread Sander Temme

Hey Zubin!

On Sep 13, 2005, at 5:04 AM, Zubin Kika wrote:


I am a member of the Covalent QA team,  and would like
tocontribute to httpd-test.


Welcome, welcome. The way this works is as follows: when you have a  
suggestion for improvement, or a test that you would like to submit  
to httpd-test, you send it to this mailinglist as a unified diff  
against the Subversion checkout. Just use svn diff, it'll use the  
right format (I think).


Then, a member of the httpd-test community can review your submission  
and commit it to the Subversion repository, or post suggestions for  
improvement to the mailinglist. All communications happen on this  
list. If you send us patches for a while and the httpd-test community  
likes their quality, they can vote and give you commit access. I can  
not tell you how long this takes: it's the impression that counts.


You can find some information on how the ASF works and how to  
contribute at the following URLs:


http://www.apache.org/dev/contributors.html
http://www.apache.org/foundation/how-it-works.html
http://httpd.apache.org/dev/patches.html

Finally, please make sure that you have permission from your company  
to submit patches. Submitting material means that you give it, and  
its copyright, to the Apache Software Foundation. Covalent has a long  
history of contributing to the ASF, and I don't think you'll have any  
problems. Folks like wrowe and Jim Jagielski can undoubtedly provide  
you with guidance.


Looking forward to your contributions!

S.

PS. List, Zubin and I worked together when I was at Covalent.

--
[EMAIL PROTECTED]  http://www.temme.net/sander/
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF



smime.p7s
Description: S/MIME cryptographic signature


Re: Apache 1.3.31 RC Tarballs available

2004-05-10 Thread Sander Temme
On May 9, 2004, at 4:18 PM, Geoffrey Young wrote:
t/apache/errordoc.t 2   51214   14 100.00%  1-14
I added that test recently and it passes for me on fedora.  can you try
$ t/TEST t/apache/errordoc.t -v
and send that along (along with any relevant error_log messages).   
that all
tests fail probably mean that it's not picking up on a required
configuration thingy.
Same exact configuration I originally posted about, on same somewhat  
updated RH 8 box.

tty says:
t/TEST -httpd /tmp/ap/bin/httpd -apxs /tmp/ap/bin/apxs  -v  
t/apache/errordoc.t
[warning] setting ulimit to allow core files
ulimit -c unlimited; /usr/bin/perl  
/home/sctemme/asf/perl-framework/t/TEST -httpd '/tmp/ap/bin/httpd'  
-apxs '/tmp/ap/bin/apxs' -v 't/apache/errordoc.t'
[ notice] mod_test_ssl.c requires Apache version 2, skipping.
[ notice] mod_test_pass_brigade.c requires Apache version 2, skipping.
[ notice] mod_test_apr_uri.c requires Apache version 2, skipping.
[ notice] mod_nntp_like.c requires Apache version 2, skipping.
[ notice] mod_input_body_filter.c requires Apache version 2, skipping.
[ notice] mod_client_add_filter.c requires Apache version 2, skipping.
make: Nothing to be done for `all'.
/tmp/ap/bin/httpd -d /home/sctemme/asf/perl-framework/t -f  
/home/sctemme/asf/perl-framework/t/conf/httpd.conf -D APACHE1 -D  
PERL_USEITHREADS
using Apache/1.3.31

waiting 60 seconds for server to start: .
waiting 60 seconds for server to start: ok (waited 3 secs)
server eartha:8529 started
t/apache/errordoc1..14
# Running under perl version 5.008 for linux
# Current time local: Mon May 10 09:56:05 2004
# Current time GMT:   Mon May 10 16:56:05 2004
# Using Test.pm version 1.23
Use of uninitialized value in concatenation (.) or string at  
/home/sctemme/asf/perl-framework/Apache-Test/lib/Apache/TestRequest.pm  
line 185.
dubious
Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 1-14
Failed 14/14 tests, 0.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
 
---
t/apache/errordoc.t2   51214   14 100.00%  1-14
Failed 1/1 test scripts, 0.00% okay. 14/14 subtests failed, 0.00% okay.
[warning] server eartha:8529 shutdown
[  error] error running tests (please examine t/logs/error_log)

Access log:
127.0.0.1 - - [10/May/2004:09:56:05 -0700] GET /index.html HTTP/1.0  
200 26
(Huh, only one entry for fourteen tests?)
Error log:
[Mon May 10 09:56:04 2004] [info] created shared memory segment #524292
[Mon May 10 09:56:04 2004] [notice] Apache/1.3.31 (Unix) configured --  
resuming normal operations
[Mon May 10 09:56:04 2004] [info] Server built: May  8 2004 07:49:35
[Mon May 10 09:56:04 2004] [notice] Accept mutex: sysvsem (Default:  
sysvsem)
[Mon May 10 09:56:07 2004] [info] removed PID file  
/home/sctemme/asf/perl-framework/t/logs/httpd.pid (pid=11234)
[Mon May 10 09:56:07 2004] [notice] caught SIGTERM, shutting down
(not exotic at all)
Rewrite log:
127.0.0.1 - - [10/May/2004:09:56:05 -0700]  
[eartha/sid#8093d54][rid#80c3edc/initial] (2) init rewrite engine with  
requested uri /index.html
127.0.0.1 - - [10/May/2004:09:56:05 -0700]  
[eartha/sid#8093d54][rid#80c3edc/initial] (1) pass through /index.html
(that's that same request we saw in access_log)

The single request for /index.html is the framework's ping to see if  
the server has started. It is not part of the errordoc tests, which  
suggests that these don't get to the server at all.


t/modules/cgi.t464   8.70%  5-6 13-14
this just hangs for me, but there were some changes introduced  
recently that
may account for this - without looking at the change log it something  
about
STDERR IIRC.
Yes, it hangs for the longest time and then continues.
t/modules/expires.t924   4.35%  13 21 33 45
fails for me as well.
it would be great to have the tests at 100% for current 1.3, 2.0, and  
2.1.
if we can get it to that point I volunteer to be the project watchdog  
who
will pipe up if some commit causes the framework to suddenly fail (at  
least
on the platform I run, currently fedora).  but until we get to 100% the
framework is kinda useless for RC testing as far as I'm concerned -  
known
failures don't really mean much for this kind of thing.
It has long been one of my desires to do an automated nightly  
build/test run on all three branches. As I get my lab set up here  
(which should happen in the next couple of weeks), I may be able to  
finally get that set up.

When I was testing a product based on httpd 2.0, I would keep a list of  
known failures (we had some patches that the framework didn't deal  
with) on our internal Wiki, so I would know that a test had been  
failing and I wouldn't have to analyze every failure to death every  
time. That was stuff like OpenSSL would put the email field name of a  
certificate DN in uppercase, and RSA SSLC would put it in lowercase. Or  
was it 

Re: Regarding Apache 2.0.48 and specweb99

2003-12-04 Thread Sander Temme
 I recall hearing that SysV sems are notorious for that on
 some platforms.
 
 I'm thinking of having the SEM_UNDO flag while creating the semaphore (if
 it's not already enabled)

APR's sysvsem IPC locks have undo enbaled.

 There's one more thing I noticed (might be specific to HP-UX) : I saw more
 errors with keepalive ON rather than when it was OFF.

I think you may be looking at a problem where server and client(s) are
messing with each other. Threads blocking on the server could be tying up
the clients, untill all clients are hanging and everything stops. I have
found the SPECWeb99 clients less than wonderfully robust under these
circumstances.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

PGP FP: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and
destroy all copies of the original message
===



Re: running on embedded devices

2003-10-07 Thread Sander Temme
 /usr/bin/perl -I/usr/lib/perl/5.6.1 -I/usr/share/perl/5.6.1 Makefile.PL
   generating script ./t/htdocs/modules/rewrite/db.pl
 APXS (/usr/sbin/apxs) query for SBINDIR failed
 APXS (/usr/sbin/apxs) query for TARGET failed
 APXS (/usr/sbin/apxs) query for SYSCONFDIR failed

This happens when you have relocated your Apache binaries and
LD_LIBRARY_PATH (or platform equiv) is not set to point to the directory
that has the libapr and libapr-util shared libraries.

apxs executes httpd to get some of this info. If that's broken because httpd
can't find its libraries, apxs fails.

Don't know if this is what's happening to you, but this is what's wrong when
I see this error. What does t/TEST -start do for you?

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

PGP FP: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and
destroy all copies of the original message
===



Re: running on embedded devices

2003-10-07 Thread Sander Temme
 where is config_vars.mk supposed to come from ?

Ought to be installed with Apache 2... in the build directory where libtool
sits, and a bunch of other build helpers.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

PGP FP: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and
destroy all copies of the original message
===



Re: [STATUS] (perl-framework) Wed Sep 24 23:47:46 EDT 2003

2003-09-25 Thread Sander Temme
 So it can't be used to test remote servers now?

This is correct. Perl-framework and httpd are required to be on the same
host.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

PGP FP: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9 



[PATCH] mod_specweb99.c: thread-safe lock

2003-08-06 Thread Sander Temme
All,

Months ago, Madhu posted a patch to put thread-safe locks around the Post
logging in mod_specweb99... here's an alternative using apr_global_mutex
locks:

Index: mod_specweb99.c
===
RCS file: /home/cvs/httpd-test/specweb99/specweb99-2.0/mod_specweb99.c,v
retrieving revision 1.28
diff -u -r1.28 mod_specweb99.c
--- mod_specweb99.c 25 Jun 2003 18:51:11 -  1.28
+++ mod_specweb99.c 6 Aug 2003 01:29:29 -
@@ -84,6 +84,20 @@
 #include unistd.h
 #endif
 
+#if !defined(OS2)  !defined(WIN32)  !defined(BEOS)  
!defined(NETWARE)
+#include unixd.h
+#define MOD_SPECWEB_SET_MUTEX_PERMS /* XXX Apache should define something
*/
+#endif
+
+/* Hardcoded lock file path for the Post log file mutex. Whether this file
+ * will actually be created depends on the default global mutex
implementation
+ * that APR was compiled with.
+ *
+ * Global mutex structure pointer for Post log mutex.
+ */
+#define LOCKFILENAME /tmp/specweb99_lockfile
+apr_global_mutex_t *log_mutex;
+
 /* Note: version must be of the x.yy type - as it is
  * send over the http protocol wire; where x and y
  * are single 0-9 ascii digits :-). The name should
@@ -559,16 +573,57 @@
 return (void *) _my;
 }
 
+/* Get rid of the Post log mutex. This function is registered as
+ * cleanup for the pool that we are passed when the parent is
+ * initialized. 
+ */
+ 
+static apr_status_t log_mutex_remove(void *data)
+{
+apr_global_mutex_destroy(log_mutex);
+log_mutex = NULL;
+return(0);
+}
+
 static int specweb99_module_init(apr_pool_t * p, apr_pool_t * plog,
  apr_pool_t * ptemp, server_rec *s)
 {
+apr_status_t rv;
+
 ap_add_version_component(p, NAME / VERSION);
 
 ap_log_error(APLOG_MARK, APLOG_INFO | APLOG_NOERRNO, 0, s,
  NAME / VERSION  module: Compiled on %s at %s,
__DATE__,
  __TIME__);
+
+/* Create the Post log mutex, using the default global locking method
that 
+ * APR was compiled with.
+ */
+rv = apr_global_mutex_create(log_mutex, LOCKFILENAME,
APR_LOCK_DEFAULT, p);
+if (rv != APR_SUCCESS) {
+ap_log_error(APLOG_MARK, APLOG_CRIT, rv, s,
+mod_specweb99: Parent could not create Post log mutex 
+with file %s, LOCKFILENAME);
+return HTTP_INTERNAL_SERVER_ERROR;
+}
+
+/* This is defined at the top of this file and causes the permissions
+ * function to not get called on platforms that don't require it.
+ */
+#ifdef MOD_SPECWEB_SET_MUTEX_PERMS
+rv = unixd_set_global_mutex_perms(log_mutex);
+if (rv != APR_SUCCESS) {
+ap_log_error(APLOG_MARK, APLOG_CRIT, rv, s,
+mod_specweb99: Parent could not set permissions 
+on Post log mutex; check User and Group directives);
+return HTTP_INTERNAL_SERVER_ERROR;
+}
+#endif /* MOD_SPECWEB_SET_MUTEX_PERMS */
+
+apr_pool_cleanup_register(p, (void *)s, log_mutex_remove,
+  apr_pool_cleanup_null);
 
-return 0;
+return OK;
 }
 
 static void specweb99_child_init(apr_pool_t * p, server_rec *s)
@@ -615,6 +670,13 @@
  * concept of a docroot).
  */
 };
+
+/* Re-open the Post log mutex for this child. I assume this does the
+ * initialization of the intra-process part of the global mutex.
+ */
+if (apr_global_mutex_child_init(log_mutex, LOCKFILENAME, p) !=
APR_SUCCESS)
+exit(APEXIT_CHILDFATAL);
+
 }   /* specweb99_child_init */
 
 static int do_housekeeping(request_rec *r)
@@ -1160,7 +1222,7 @@
 return HTTP_INTERNAL_SERVER_ERROR;
 }
 
-if ((rv = _wlock(r-server, r, f, _my-log_path)) != APR_SUCCESS) {
+if ((rv = apr_global_mutex_lock(log_mutex)) != APR_SUCCESS) {
 returnHTMLPageWithMessage(r, Failed to lock post.log file);
 }
 else {
@@ -1174,7 +1236,7 @@
 }
 }
 
-if ((rv2 = apr_file_unlock(f)) != APR_SUCCESS) {
+if ((rv2 = apr_global_mutex_unlock(log_mutex)) != APR_SUCCESS) {
 if (rv == APR_SUCCESS) {
 rv = rv2;
 ap_log_error(APLOG_MARK, APLOG_ERR, rv, r-server,

(also attached to get around line-wrapping by the mailer).

This approach is also used in mod_rewrite. I know apr_global_mutexes are
advertised as potentially expensive, but in a hybrid situation you're going
to end up doing something like this, and apr_global_mutexes turn into
process locks when APR is thread-free or (not tested) on Win32.

Tested on Darwin under light load and Solaris under moderate load. Thoughts,
opinions, comments? Or shall I just commit the thing?

Thanks,

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 

[PATCH] Enable client certificate for https-https proxy tests

2003-08-04 Thread Sander Temme
Hi all,

This patch fixes a problem that occurs when RSA SSL-C is used as back-end
for mod_ssl:

Index: t/conf/ssl/proxyssl.conf.in
===
RCS file: 
/home/cvspublic/httpd-test/perl-framework/t/conf/ssl/proxyssl.conf.in,v
retrieving revision 1.11
diff -u -r1.11 proxyssl.conf.in
--- t/conf/ssl/proxyssl.conf.in 2 May 2002 19:25:52 -   1.11
+++ t/conf/ssl/proxyssl.conf.in 4 Aug 2003 19:30:00 -
@@ -34,7 +34,7 @@
 #these are not on by default in the 1.x based mod_ssl
 IfDefine APACHE2
 SSLProxyEngine On
-#SSLProxyMachineCertificateFile @SSLCA@/asf/proxy/client_ok.pem
+SSLProxyMachineCertificateFile @SSLCA@/asf/proxy/client_ok.pem
 #client_ok.pem should be loaded first
 SSLProxyMachineCertificatePath @SSLCA@/asf/proxy
 SSLProxyCACertificateFile @SSLCA@/asf/certs/ca.crt

If I don't explicitly specify the proxy client cert when running on SSL-C,
the wrong certificate gets picked for proxy client authentication. The
result is a 403 Forbidden from the upstream, and a 502 Bad Gateway from the
proxy. 

The regular mod_ssl/OpenSSL combination is not affected, but is not broken
by this patch either. Tested on Darwin (OpenSSL), Linux (both OpenSSL and
SSL-C) and Solaris (both).

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



proxyssl.conf.in.patch
Description: Binary data


Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Sander Temme
on 7/10/03 18:00, Stas Bekman at [EMAIL PROTECTED] wrote:

 
 Does this work?
 
 else if ($redir) {
$RedirectOK = $redir;
 }

It does. However, isn't this the same condition as in the top if clause?
Wouldn't you want to:

Index: Apache-Test/lib/Apache/TestRequest.pm
===
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest
.pm,v
retrieving revision 1.81
diff -u -r1.81 TestRequest.pm
--- Apache-Test/lib/Apache/TestRequest.pm   8 Jul 2003 07:56:24 -
1.81
+++ Apache-Test/lib/Apache/TestRequest.pm   11 Jul 2003 04:28:45 -
@@ -88,14 +88,12 @@
 $UA = undef;
 }
 
-if (my $redir = $args-{requests_redirectable}) {
+if (defined (my $redir = $args-{requests_redirectable})) {
 if (ref $redir and (@$redir  1 or $redir-[0] ne 'POST')) {
 $RedirectOK = 1;
 } else {
 $RedirectOK = 0;
 }
-} else {
-$RedirectOK = $redir;
 }
 
 $args-{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};

In other words, if $redir is defined, do something with it to the effect of
$RedirectOK. If it isn't defined, go with the default value which is 1. What
exactly is this code trying to do?

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



TestRequest.pm.patch
Description: Binary data


Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-10 Thread Sander Temme
on 7/8/03 0:28, [EMAIL PROTECTED] at [EMAIL PROTECTED] wrote:

 stas2003/07/08 00:28:28
 
 Modified:perl-framework/Apache-Test/lib/Apache TestRequest.pm
 Log:
 Change the way the redirect_ok parameter works so that it affects only
 _that call_ to the function. Afterward it should revert to the old
 value of $RedirectOK.
 
 Change user_agent() so that the LWP::UserAgent requests_redirectable
 parameter actually does something useful vis-à-vis $RedirectOK.
 
 Submitted by:David Wheeler [EMAIL PROTECTED]
 Reviewed by:stas

This patch causes the following failures, across multiple platforms:

apache/acceptpathinfo.t   366  16.67%  1-2 13-14 25-26
modules/alias.t   62   20  32.26%  19-38

In analysing, I concentrated on the acceptpathinfo tests and noticed that we
are no longer following redirects, getting 301 responses where we expect
200. Backing out the patch resolves all these failures.

In the documentation, I read that the default behaviours is to follow the
redirects. In the acceptpathinfo cases, this does not seem to happen. I
tried both setting 

$Apache::TestRequest::RedirectOK = 1;

and passing a 

redirect_ok = 1

parameter to the request invocations in t/apache/acceptpathinfo.t. Neither
produces any result. Am I looking in the right place?

 Revision  ChangesPath
 1.79  +16 -3 
 httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest.pm
 
 Index: TestRequest.pm
 ===
 RCS file: 
 /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest.pm,v
 retrieving revision 1.78
 retrieving revision 1.79
 diff -u -r1.78 -r1.79
 --- TestRequest.pm24 Apr 2003 05:16:57 -1.78
 +++ TestRequest.pm8 Jul 2003 07:28:27 -1.79
 @@ -88,6 +88,16 @@
  $UA = undef;
  }
  
 +if (my $redir = $args-{requests_redirectable}) {
 +if (ref $redir and (@$redir  1 or $redir-[0] ne 'POST')) {
 +$RedirectOK = 1;
 +} else {
 +$RedirectOK = 0;
 +}
 +} else {
 +$RedirectOK = $redir;
 +}
 +
  $args-{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};
  
  if ($args-{keep_alive}) {
 @@ -278,9 +288,6 @@
  }
  push @$pass, content = $content;
  }
 -if (exists $keep-{redirect_ok}) {
 -$RedirectOK = $keep-{redirect_ok};
 -}
  if ($keep-{cert}) {
  set_client_cert($keep-{cert});
  }
 @@ -291,6 +298,9 @@
  sub UPLOAD {
  my($url, $pass, $keep) = prepare(@_);
  
 +if (exists $keep-{redirect_ok}) {
 +local $RedirectOK = $keep-{redirect_ok};
 +}
  if ($keep-{filename}) {
  return upload_file($url, $keep-{filename}, $pass);
  }
 @@ -451,6 +461,9 @@
  
  *$name = sub {
  my($url, $pass, $keep) = prepare(@_);
 +if (exists $keep-{redirect_ok}) {
 +local $RedirectOK = $keep-{redirect_ok};
 +}
  return lwp_call($method, undef, $url, @$pass);
  };
  
 
 
 
 
 


-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



[PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-10 Thread Sander Temme
on 7/10/03 12:56, Sander Temme at [EMAIL PROTECTED] wrote:

 parameter to the request invocations in t/apache/acceptpathinfo.t. Neither
 produces any result. Am I looking in the right place?

Breadcrumbing my way through Apache-Test/lib/Apache/TestRequest.pm by
liberally sprinkling print statements, I get to the following around line
97:
 
 +if (my $redir = $args-{requests_redirectable}) {
 +if (ref $redir and (@$redir  1 or $redir-[0] ne 'POST')) {
 +$RedirectOK = 1;
 +} else {
 +$RedirectOK = 0;
 +}
 +} else {
 +$RedirectOK = $redir;
 +}
 +

We arrive at this if statement in all failing acceptpathinfo and
modules/alias tests, and end up in the else clause because $redir is
undefined. The result is that we reset RedirectOK to something undefined,
hence don't follow the redirection. Getting rid of the else clause gets me
my passing tests back, since RedirectOK stays at its default value of '1'.
Like so:

Index: Apache-Test/lib/Apache/TestRequest.pm
===
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRequest
.pm,v
retrieving revision 1.81
diff -u -r1.81 TestRequest.pm
--- Apache-Test/lib/Apache/TestRequest.pm   8 Jul 2003 07:56:24 -
1.81
+++ Apache-Test/lib/Apache/TestRequest.pm   10 Jul 2003 21:05:34 -
@@ -94,8 +94,6 @@
 } else {
 $RedirectOK = 0;
 }
-} else {
-$RedirectOK = $redir;
 }
 
 $args-{keep_alive} ||= $ENV{APACHE_TEST_HTTP11};

(also attached to avoid breakage by line wrappage). Tested on Darwin 6.6,
Perl 5.6.0, against Apache 2.0.47.

Does that sound sound?

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



TestRequest.pm.patch
Description: Binary data


Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-20 Thread Sander Temme
on 5/19/03 23:01, [EMAIL PROTECTED] at [EMAIL PROTECTED] wrote:

This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the following
protest:

pxs /tmp/apache2/bin/apxs
Useless use of a constant in void context at
Apache-Test/lib/Apache/TestConfig.pm line 784.
Compilation failed in require at Apache-Test/lib/Apache/TestMM.pm line 7.
BEGIN failed--compilation aborted at Apache-Test/lib/Apache/TestMM.pm line
7.
Compilation failed in require at Makefile.PL line 9.
BEGIN failed--compilation aborted at Makefile.PL line 9.

The offending line is the following:

 +push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;

Does that IS_MOD_PERL_2_BUILD need to be in a name space when it is
referenced within the subroutine?

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



Re: cvs commit: httpd-test/perl-framework/Apache-Test Changes

2003-05-20 Thread Sander Temme
on 5/20/03 10:53, Sander Temme at [EMAIL PROTECTED] wrote:

 This breaks on RH 8.0 and Solaris 7, both on perl 5.8.0, with the following

The following patch gets me back in the saddle, not only on Linux/Solaris
but also on Darwin 6.6:

Index: Apache-Test/lib/Apache/TestConfig.pm
===
RCS file: 
/home/cvspublic/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.
pm,v
retrieving revision 1.162
diff -u -r1.162 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm20 May 2003 06:01:38 -
1.162
+++ Apache-Test/lib/Apache/TestConfig.pm20 May 2003 18:18:08 -
@@ -781,7 +781,7 @@
 push @dirs, '../lib';
 }
 
-push @dirs, 'Apache-Test' if IS_MOD_PERL_2_BUILD;
+push @dirs, 'Apache-Test/lib';
 
 return EOF;
 
I'm not building mod_perl, so that Apache-Test did not get included on
Darwin (running perl 5.6.0 which apparently doesn't choke on the constant)
and furthermore it needs to be Apache-Test/lib.

Please let me know if I'm onto something, or merely on something.

Thanks,

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



Re: SPEC / mod_specweb99.c

2003-02-19 Thread Sander Temme
 Does anybody know if the mod_specweb99.c been 'blessed' by the SPEC
 committee ?..I mean, have they acknowledged that the module acts in a SPEC
 compliant manner?

As far as I am aware, the module has not been used for benchmarks submitted
to the SPEC organization. That is the moment any code would get 'blessed':
SPEC validates the results and the way they were obtained and the
benchmarkee submits the API source code as part of this process.

 I had a doubt regarding executing CGI scripts in SPECweb99 - somebody here
 told me that the SPEC mandates the web server to fork a child process to
 execute a CGI script - is that so ?.

This is the case for Dynamic CGI GET requests. You set a special URL for
this in your rc file. All other dynamic requests can be processed by
in-process code and most if not all submittors have written code for this.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9




Re: gettimeofday calls

2003-01-24 Thread Sander Temme
 Is this against the spec or something ?.
 
 Which spec?  If you are referring to either the SPECWeb99 run rules or to
 RFC2616, neither of them dictate which syscalls you use.

IIRC, the SPECWeb99 run rules just say that you have to treat ad expiration
correctly.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



Re: [PATCH] Use mutex locks in mod_specweb99.c

2002-12-13 Thread Sander Temme
 If you're worried about the overhead of calling pthread_lock and
 pthread_unlock under the covers when it's not needed (like on the prefork MPM)
 then I would say that's not a big problem. Locking mutexes that are not
 contended for can be quite cheap, and often those calls do not even translate
 into syscalls.

What we're pondering here is locking a logfile in mod_specweb99. During a
SPECWeb99 run, mutexes are not cheap and there is a lot of camping out going
on.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



Re: [PATCH] Get mod_specweb99 to compile against 2.0.43

2002-10-25 Thread Sander Temme
 I noticed that there were some places where u_int32_t is being used instead
 of apr_uint32_t. Is it purposefully done OR is it one of those Oh, the apr
 interface changed stuff ?.
 
 Anyways, I've included a patch that atleast gets the module to compile
 against 2.0.43. Pl. let me know if it's okay.

Madhu,

+1 on concept; I'll look at committing it in the near future.

Thanks,

Sander

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 856 4214
303 Second Street #375 South   Fax: (415) 856 4210
San Francisco CA 94107

   PGP Fingerprint: 7A8D B189 E871 80CB 9521  9320 C11E 7B47 964F 31D9

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



Re: mod_specweb99 debugging...

2002-08-16 Thread Sander Temme
 Also - hack the conf to do short runs first !
 
 Oh yeah, excellent point.  That's the SPEC rc file.  Look for *_TIME,
 ITERATIONS, and SIMULTANEOUS_CONNECTIONS.

My rc files usually have trial (short) values for *_TIME and a single
iteration. You can force all those in line for a compliant run with the -C
option on the command line. The only time parameter that is not affected by
-C is WARMUP_TIME.

Note that when you do short runs and get bandwidth misreporting, increasing
the run length (like, from two to four or five minutes) will allow you to go
further. Also, I have seen divide-by-zero problems on extremely short runs.

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 536 5214
645 Howard St. Fax: (415) 536 5210
San Francisco CA 94105

   PGP Fingerprint: 1E74 4E58 DFAC 2CF5 6A03  5531 AFB1 96AF B584 0AB1

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===



Re: Perl framework 'server exited' on AIX

2002-01-27 Thread Sander Temme
 When trying to run vanilla 't/TEST' on AIX, with httpd-2.0 HEAD,
 I'm getting a
 
 waiting for server to start: 00:00
 server has died with status 255 (please examine t/logs/error_log)

Exactly the same deal on:

Darwin 5.2
FreeBSD 4.4

S.

-- 
Covalent Technologies [EMAIL PROTECTED]
Engineering groupVoice: (415) 536 5214
645 Howard St. Fax: (415) 536 5210
San Francisco CA 94105

   PGP Fingerprint: 1E74 4E58 DFAC 2CF5 6A03  5531 AFB1 96AF B584 0AB1

===
This email message is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. Any unauthorized review,
use, disclosure or distribution is prohibited.  If you are not the intended
recipient, please contact the sender by reply email and destroy all copies
of the original message
===