Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
At 10:35 AM 11/4/2004, Geoffrey Young wrote:
-TEST_VERBOSE ?= 0
+TEST_VERBOSE = 0
why not if (WIN32) {} then?
do win32 environments add some magic WIN32 environment variable I can check
in the Makefile? if they do and we can work around them that's cool with me.
If I had to guess, this borks anything but gmake. Test for that.
Bill
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
If I had to guess, this borks anything but gmake. Test for that. I had asked on #asf about this and somebody (I forget who) said that the make manpage on minortaur (some bsd variant) supports ?= as well. from looking at that it seems to be the manpage for pmake, which I guess is some other make variant. so limiting it to gmake at least would seem to wipe out bsd folks. a little digging on my own at the time made it seem like solaris make is really gmake, so between linux, solaris, and bsd a decent case was being made that most unix make variants to support the syntax. of course, that list of 3 was hardly exhaustive :) anyway, this just isn't my area, so I'm happy to defer to others that grok all this SA-type stuff. but if most unix-variants support ?=, or if there is another more universal way to work around the issue, I would hate to see the correct behavior only for unix people using gmake. --Geoff
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
At 11:23 AM 11/4/2004, Geoffrey Young wrote: If I had to guess, this borks anything but gmake. Test for that. I had asked on #asf about this and somebody (I forget who) said that the make manpage on minortaur (some bsd variant) supports ?= as well. from looking at that it seems to be the manpage for pmake, which I guess is some other make variant. so limiting it to gmake at least would seem to wipe out bsd folks. Ok, looks good for pmake, yes... however... a little digging on my own at the time made it seem like solaris make is really gmake Well, the way you have it installed perhaps. But attempting this against /usr/ccs/bin/make it most definately blows up. , so between linux, solaris, and bsd a decent case was being made that most unix make variants to support the syntax. of course, that list of 3 was hardly exhaustive :) Hardly. The man page for hpux 11 make makes no mention of ?= nor does AIX 5.1. you are 2 for 5. Explicitly fails on native make(s) on AIX 5.1, HPUX 11, Solaris 2.6. Please find another solution. Bill p.s. simple test I used... TERM ?= uberterm all: echo $(TERM)
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
Geoffrey Young wrote: a little digging on my own at the time made it seem like solaris make is really gmake, so between linux, solaris, and bsd a decent case was being made that most unix make variants to support the syntax. of course, that list of 3 was hardly exhaustive :) Umm, on all the solaris systems I've used make is in fact not gmake, there are a number of solaris specific differences. This is at least true on solaris 2.6 through solaris 8. I'm not sure about 9 or 10. -garrett
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
a little digging on my own at the time made it seem like solaris make is really gmake Well, the way you have it installed perhaps. But attempting this against /usr/ccs/bin/make it most definately blows up. ok. I actually don't have a solaris box to try on - I just went to sun's support site and saw that the manpage for make was gmake (at least the one that google first pointed me toward :) , so between linux, solaris, and bsd a decent case was being made that most unix make variants to support the syntax. of course, that list of 3 was hardly exhaustive :) Hardly. The man page for hpux 11 make makes no mention of ?= nor does AIX 5.1. you are 2 for 5. yeah, not good. Explicitly fails on native make(s) on AIX 5.1, HPUX 11, Solaris 2.6. Please find another solution. well, the solution at the moment is to not have a solution - cvs has been reverted, so unless a real solution can be found it will remain a minor nit. p.s. simple test I used... TERM ?= uberterm all: echo $(TERM) the gmake manual suggests that ?= is equivalent to ifeq ($(origin TEST_VERBOSE), undefined) TEST_VERBOSE = 0 endif so that might make for a good test - the gmake manual didn't speficially say that origin was explicit to it, but then again it didn't mention ?= either :) --Geoff
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
Seems it's not Win32 friendly, see this complaint: http://marc.theaimsgroup.com/?t=10994804082r=1w=2 [EMAIL PROTECTED] wrote: geoff 2004/10/25 18:42:14 Modified:perl-framework/Apache-Test/lib/Apache TestMM.pm Log: make sure TEST_VERBOSE respects the environment, not just the current shell command. somebody shout if ?= isn't portable, but a few accounts indicate that it is Revision ChangesPath 1.42 +1 -1 httpd-test/perl-framework/Apache-Test/lib/Apache/TestMM.pm -- Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5 http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5 signature.asc Description: OpenPGP digital signature
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
[EMAIL PROTECTED] wrote:
geoff 2004/11/03 12:37:22
Modified:perl-framework/Apache-Test/lib/Apache TestMM.pm
Log:
reverting to 1.41 - apparently the conditional assignment borks win32
return $preamble . 'EOF' . $cover;
-TEST_VERBOSE ?= 0
+TEST_VERBOSE = 0
why not if (WIN32) {} then?
--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestMM.pm
[EMAIL PROTECTED] wrote:
geoff 2004/09/15 16:55:31
Modified:perl-framework/Apache-Test Changes
perl-framework/Apache-Test/lib/Apache TestMM.pm
Log:
run_tests make target no longer invokes t/TEST -clean, making it
possible to save a few development cycles when a full cleanup is
not required between runs.
TestMB.pm probably should be updated to be consistent as well.
David, I think the attached patch is right but I'll leave TestMB entirely up
to you.
--Geoff
? mb.patch
? quick.patch
Index: lib/Apache/TestMB.pm
===
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestMB.pm,v
retrieving revision 1.7
diff -u -r1.7 TestMB.pm
--- lib/Apache/TestMB.pm 5 Sep 2004 00:11:30 - 1.7
+++ lib/Apache/TestMB.pm 15 Sep 2004 23:56:48 -
@@ -53,7 +53,6 @@
sub ACTION_run_tests {
my $self = shift;
-$self-depends_on('test_clean');
# XXX I'd love to do this without t/TEST.
$self-do_system($self-perl, $self-_bliblib,
$self-localize_file_path($self-apache_test_script),
@@ -71,8 +70,8 @@
sub ACTION_test {
my $self = shift;
$self-depends_on('code');
-$self-depends_on('run_tests');
$self-depends_on('test_clean');
+$self-depends_on('run_tests');
}
sub _cmodules {
