Re: need to require Cwd 2.06 for A-T
Stas Bekman wrote:
I know we tried to avoid external dependencies, but Cwd coming with
5.6.x is unusable under -T. At the moment this breaks some mp2 tests
(the problem comes from A-T, which indirectly invokes Cwd::cwd via
File::Spec's rel2abs. I've tried to code a workaround, but it doesn't
work and it's a bad idea to get it working since it's very OS specific.
(_backtick_pwd is the problem).
so we probably have no choice but require Cwd 2.06
So it's:
WriteMakefile(
NAME = 'Apache::Test',
VERSION = $VERSION,
PREREQ_PM = { 'File::Spec' = '0.8',
'Cwd'= '2.06',
},
...
);
but if this is not run from CPAN/CPANPLUS shell, most likely this
requirement will be ignored. Should we add:
die Cwd 2.06 or higher is required
unless eval { require Cwd $Cwd::VERSION = 2.06 };
after WriteMakefile(), this won't get on the way of CPAN/CPANPLUS shell
will it?
--
__
Stas BekmanJAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide --- http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
Re: need to require Cwd 2.06 for A-T
Stas Bekman wrote: Stas Bekman wrote: I know we tried to avoid external dependencies, but Cwd coming with 5.6.x is unusable under -T. At the moment this breaks some mp2 tests (the problem comes from A-T, which indirectly invokes Cwd::cwd via File::Spec's rel2abs. I've tried to code a workaround, but it doesn't work and it's a bad idea to get it working since it's very OS specific. (_backtick_pwd is the problem). so we probably have no choice but require Cwd 2.06 if it's only breaking mp2 tests then those tests should probably have plan tests = $n, need_min_module_version(Cwd = 2.06); instead of requiring an external dependency for the entire framework. not that I'm against external dependencies, but we should only require an external dependency when the codebase itself requires it. that is, it is your tests that need a higher Cwd, not Apache-Test proper. --Geoff
Re: need to require Cwd 2.06 for A-T
Geoffrey Young wrote: Stas Bekman wrote: Stas Bekman wrote: I know we tried to avoid external dependencies, but Cwd coming with 5.6.x is unusable under -T. At the moment this breaks some mp2 tests (the problem comes from A-T, which indirectly invokes Cwd::cwd via File::Spec's rel2abs. I've tried to code a workaround, but it doesn't work and it's a bad idea to get it working since it's very OS specific. (_backtick_pwd is the problem). so we probably have no choice but require Cwd 2.06 if it's only breaking mp2 tests then those tests should probably have plan tests = $n, need_min_module_version(Cwd = 2.06); instead of requiring an external dependency for the entire framework. not that I'm against external dependencies, but we should only require an external dependency when the codebase itself requires it. that is, it is your tests that need a higher Cwd, not Apache-Test proper. It can affect any test, the problem is triggered by A-T. Any File::Spec-rel2abs call may trigger the problem. It just happens to be triggered so far under mp2 tests. -- __ Stas BekmanJAm_pH -- Just Another mod_perl Hacker http://stason.org/ mod_perl Guide --- http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
