[Therion] Therion hanging after compile
On Fri, Jun 13, 2014 at 11:15:26AM +0100, Wookey wrote:
> +++ Jenny Black [2014-06-11 19:12 +1200]:
> >Olly has just had a look (thank you Olly!), and in xtherion he changed:
> >set rx {\S*[^\]\s]\s+\[\d+\]}
> >to:
> >set rx {\s\[\d+\]}
> >It now no longer hangs, and runs as well as ever. We're not sure what the
> >regular expression search was for, or whether changing it matters. As far
> >as I can see it doesn't, as the pdf and log files have already been made.
>
> Just noticed this. Well fettled. I've filed a bug in Debian BTS about
> this so it doesn't get forgotten.
>
> I'll do a 5.3.15 upload with this and ol's other fixes in very soon.
I'm not at all confident this fix is correct - my grasp of Tcl is
insufficient to understand what the code is actually doing with this
regex.
All I did was to prune the bit off the start of the pattern which was
causing the regex engine to do insane amount of backtracking (which
with a large log file could easily result in it taking 10 minutes to
run this regex over the whole log).
So you might want to wait for comments from Stacho or Martin before
shipping this.
Cheers,
Olly
[Therion] wxWidgets 3.0.0
On Sat, Jun 14, 2014 at 12:16:31PM +0200, Stacho Mudrak wrote: > Unfortunatelly, I do not understand what exactly is the problem with wx 3.0. > > I have installed debian jessie/sid on my virtual linux box and all I needed > to do to get therion 5.3.15 working was related to VTK6. > > I needed to change lxData.cxx and link all existing vtk libraries in the > system this dirty way: > > VTKLIB = $(addprefix -l,$(subst xxxlib,,$(addprefix xxx,$(notdir $(basename > $(shell ls /usr/lib/x86_64-linux-gnu/libvtk*-6.1.so)) > VTKLIBS = $(VTKLIB) -lfreetype -lpng -ljpeg > > No need to change anything with wx3.0. > > When I run loch - it prints a lot of assertions, but it runs without any > problem, if I click to ignore them. My patch from the message at start of this thread should fix those assertions. Another option is to build with -DNDEBUG - this will disable these assertion messages, and wx3.0 will then handle these cases quietly, just like it does in a default build of wx2.8. However, these assertions are due to incorrect uses of the wx API, so it's better to try to actually deal with them really. The assertion dialogs appearing will of course change the timing though, so you may find that without them you see the problems I do. > I have not yet tested Olly's patches, I have done this two weeks ago > or so. This isn't one of the patches I sent recently - it was sent to this list in November last year: http://thread.gmane.org/gmane.comp.gis.therion/3886 The more recent patches aren't connected to wx3.0 support. > Even running loch with filename as argument works fine. I have not > tried on a box with 3D hardware acceleration, may be there timing > issue will rise. But is this related with wx3.0? As far as I know, > there were problems with intel 3D cards on Linux box from the > beginning. I think I did compare results with the build of loch already in Debian, but I'll recheck. FWIW, I do have intel graphics hardware in the machine I have been testing on, but other 3D stuff seems to work fine. Cheers, Olly
[Therion] wxWidgets 3.0.0
+++ Stacho Mudrak [2014-06-14 12:16 +0200]: >Unfortunatelly, I do not understand what exactly is the problem with wx >3.0. >I have installed debian jessie/sid on my virtual linux box and all I >needed to do to get therion 5.3.15 working was related to VTK6. >I needed to change lxData.cxx and link all existing vtk libraries in the >system this dirty way: >VTKLIB = $(addprefix -l,$(subst xxxlib,,$(addprefix xxx,$(notdir >$(basename $(shell ls /usr/lib/x86_64-linux-gnu/libvtk*-[1]6.1.so)) >VTKLIBS = $(VTKLIB) -lfreetype -lpng -ljpeg OK. I have a more specific library list, from using the tool they provide to analyse your code for library requirements. -lvtkCommonCore -lvtkCommonDataModel -lvtkFiltersCore -lvtkFiltersHybrid -lvtkIOLegacy -lvtkjpeg -lvtkpng I don't think that adding all 363 vtk libraries to the link link is the right way to go ! Can you send me your vtk6 lxData.cxx patch? I've made one but don't really know what I'm doing so am not sure if it's right. >No need to change anything with wx3.0. >When I run loch - it prints a lot of assertions, but it runs without any >problem, if I click to ignore them. I have not yet tested Olly's patches, >I have done this two weeks ago or so. Even running loch with filename as >argument works fine. OK. Interesting. Thanks for doing that. >I have not tried on a box with 3D hardware >acceleration, may be there timing issue will rise. But is this related >with wx3.0? I guess if it works on some machines then remaining issues may well be hardware/driver specific. Although it's odd that wx2.8 does nnot produce issues on the same hardware. I'll test on my machines and see what I get. >As far as I know, there were problems with intel 3D cards on >Linux box from the beginning. There was for a time but that went away a couple of years ago. And yes that apeared to be a problem at the wx/opengl drivers level. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
[Therion] Some patches
+++ Olly Betts [2014-06-07 06:43 +0100]: > Hi therioneers, > > Attached are five patches: ... > therion-fix-init-order.patch > > In C++, class members are initialised in the order declared in the > class, and it's clearer if the order of the initialiser list matches > the order the members are actually initialised in. Some compilers > will issue a warning if they don't match. This is already applied in the existing package as part of the "fix-compiler-warnings.patch" you previously supplied. I've included the others ready for the next upload. Cheers. Wookey -- Principal hats: Linaro, Emdebian, Wookware, Balloonboard, ARM http://wookware.org/
