Re: [twdev] [TW5] Unexpected effect of $:/tags/Macro on the story river
Thanks for info, Jeremy. <:-) -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/a8fd8990-8b8f-4eb3-adb0-26bf507abeda%40googlegroups.com.
Re: [twdev] [TW5] Unexpected effect of $:/tags/Macro on the story river
Hi Mat > On 11 Feb 2020, at 11:42, Mat wrote: > > I'm hijacking the thread (since the question seems straightened out) with a > long shot but: The long time problem with refresh and therefore lost focus > when one is editing a maro tiddler... could this somehow be prevented using > importvariables…? The long time problem with the refresh mechanism is that it doesn’t maintain certain state when widgets are deleted and recreated as part of the refresh cycle (selection status, focus, scroll positions, the state of summary/detail widgets etc). Xavier’s specific problem here is that changing a global macro tiddler causes the entire page template to be reconstructed, losing the focus status. The lack of state preservation is a major flaw that I’d like to see fixed. We have some proposals for partial solutions that work for some state in some situations, but we really need a rethink that makes state preservation just work. One possibility is adopting a more conventional virtual DOM strategy for updating the DOM. Best wishes Jeremy. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/0C6E1AEA-D25F-4B82-92FC-FB56EE2E89A7%40gmail.com.
Re: [twdev] Re: [TW5] Unexpected effect of $:/tags/Macro on the story river
Xavier Cazin wrote: > > I'm inclined to rather try loading macros explicitly with > <$importvariables>, in order to keep compatibility with as many releases as > possible. > @Eric and @Xavier I'm hijacking the thread (since the question seems straightened out) with a long shot but: The long time problem with refresh and therefore lost focus when one is editing a maro tiddler... could this somehow be prevented using importvariables...? <:-) -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/71dc2fcb-9fcd-44a0-8d8b-82d6d6290fc2%40googlegroups.com.
Re: [twdev] Re: [TW5] Unexpected effect of $:/tags/Macro on the story river
Hi Mat, On Mon, Feb 10, 2020 at 10:23 PM Mat wrote: > It sounds like a bug but meanwhile you can perhaps add a *naviation* in > the save tiddler button, i.e $:/core/ui/Buttons/save or to the macro that > tiddler calls, i.e the save-tiddler-actions macro which is found in > $:/core/ui/EditTemplate . Maybe surround it with a condition that current > is tagged with $:/tags/Macro. > Thank you for the suggestion, that would be a good exercise to master navigation inside the story! Having now seen Eric's answer, I'm inclined to rather try loading macros explicitly with <$importvariables>, in order to keep compatibility with as many releases as possible. Cheers, --Xavier. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/CADeSwYN_ukvuePOVT0rkoWN8tu6Jcs0-9tj2tevdPTNn275PAg%40mail.gmail.com.
Re: [twdev] Re: [TW5] Unexpected effect of $:/tags/Macro on the story river
Hi Eric, On Mon, Feb 10, 2020 at 11:13 PM Eric Shulman wrote: > On Monday, February 10, 2020 at 10:47:49 AM UTC-8, Xavier Cazin wrote: >> >> tag a tiddler in the middle of the story with $:/tags/Macro, open it, >> then save it. It will lead you above the story. >> > > I suspect that it has to do with the way that global macros are loaded by > the $:/core/ui/PageTemplate, which does the following: > \import [[$:/core/ui/PageMacros]] [all[shadows+tiddlers]tag[$:/tags/Macro > ]!has[draft.of]] > > This line causes an automatic refresh of the PageTemplate whenever a > tiddler tagged with $:/tags/Macro is changed. > This is it! When I remove my plugin namespace from this filter, the issue disappears :-) Thank you Eric, you saved me some hair. I'll use <$importvariables> to load my macros explicitly and I'll fill a ticket on GitHub. --Xavier. -- You received this message because you are subscribed to the Google Groups "TiddlyWikiDev" group. To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywikidev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywikidev/CADeSwYPmWbNKvcaFK4Apw5K%2Bx2j8Xbwk51FOYwpFKXRiewcQ2w%40mail.gmail.com.