Re: [Tigervnc-devel] libvnc.so X server extension in Debian Squeeze
On Mon, Aug 23, 2010 at 09:15:18PM +0100, Tim Small wrote: > Hi, > > I'd like to get a working libvnc.so for Debian Squeeze which will work > with the Debian packaged xorg servers. I followed unix/README from > tigervnc svn trunk, using the Debian Squeeze xorg-server-1.7.7 build > package. Having hacked hw/vnc/Makefile.am so that it doesn't assume the > build dir is the same as the src dir (the Debian package doesn't get > built like that), I finally got it to spit out a libvnc.so which I > installed manually. > > It seems to do something, in that the Xserver starts up and can be > connected to using a VNC client, but as soon as there is any pointer or > keyboard activity from a client, the X server dies with: > > /usr/bin/X: symbol lookup error: > /usr/lib/xorg/modules/extensions/libvnc.so: undefined symbol: > AllocDevicePair > > and a grep -r -l AllocDevicePair /usr/lib/xorg/modules/ > > ... only says ... > > /usr/lib/xorg/modules/extensions/libvnc.so > > Before I go and start digging around the Byzantine xorg tree, am I > missing something obvious? As that symbol isn't included in any other > xort modules on Debian, I assume the linking for libvnc.so needs to be > modified? greping for the same symbol name in the build directory gives: > > ./unix/xserver/build-main/Xext/.libs/xtest.o > ./unix/xserver/build-main/Xext/.libs/libXext.a > ./unix/xserver/build-main/Xi/.libs/xichangehierarchy.o > ./unix/xserver/build-main/Xi/.libs/libXi.a > ./unix/xserver/build-main/dix/.libs/devices.o > ./unix/xserver/build-main/dix/.libs/libdix.a > ./unix/xserver/build-main/hw/vnc/.libs/libvnccommon_la-Input.o > ./unix/xserver/build-main/hw/vnc/.libs/libvnccommon.a > ./unix/xserver/build-main/hw/vnc/.libs/libvnc.so > ./unix/xserver/build-main/hw/vnc/Xvnc > ./unix/xserver/build-main/hw/xfree86/loader/sdksyms.c > ./unix/xserver/build-main/include/input.h > ./unix/xserver/build-main/test/.libs/libxservertest.lax/libdix.a/devices.o Hello, please check if Debian Xorg server (main Xorg server, not Xvnc sources) has following patches applied: http://cgit.freedesktop.org/xorg/xserver/commit/?id=2f29b163bbdebe384c24f781bb97b446959e8f4c http://cgit.freedesktop.org/xorg/xserver/commit/?id=626f97688a89dbc5da80390d822d21b1a737de0e With those patches livnc.so should work fine. Regards, Adam -- Adam Tkac, Red Hat, Inc. -- Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d ___ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
Re: [Tigervnc-devel] 1.1 release schedule
On Sun, Aug 22, 2010 at 11:35:17PM +0100, Antoine Martin wrote: > Hi, Hello, > Although I very much appreciate the "release when it's ready" approach > to open source development, can anyone give me a clue as to when 1.1 is > likely to land? As DRC wrote there is still some work on the build system, especially on Windows platform. Another part which must be completed (and I'm currently working on this task) is GUI improvements to expose TLS encryption settings for normal users, not only for experienced hackers. If I take into consideration overall development activity and things which must be done I guess 1.1 will be ready in ~3 months. It might look as a long time but we simply must complete all "accepted" features. Regards, Adam -- Adam Tkac, Red Hat, Inc. -- Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d ___ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
Re: [Tigervnc-devel] [PATCH] Provide default pixel format for depth 32
On Tue, Aug 24, 2010 at 08:05:38AM +0200, Martin Koegler wrote: > Libraries like qt segfault, if reader is enabled but this information > is not set Commited with little modifications as r4124. Thanks for the patch. Regards, Adam > > Signed-off-by: Martin Koegler > --- > unix/xserver/hw/vnc/xvnc.cc |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/unix/xserver/hw/vnc/xvnc.cc b/unix/xserver/hw/vnc/xvnc.cc > index 15235e1..2fae601 100644 > --- a/unix/xserver/hw/vnc/xvnc.cc > +++ b/unix/xserver/hw/vnc/xvnc.cc > @@ -1210,6 +1210,14 @@ vfbScreenInit(int index, ScreenPtr pScreen, int argc, > char **argv) > pvfb->greenBits = 6; > } > > +if (!pvfb->pixelFormatDefined && pvfb->fb.depth == 32) { > + pvfb->pixelFormatDefined = TRUE; > + pvfb->rgbNotBgr = TRUE; > + pvfb->blueBits = 8; > + pvfb->redBits = 8; > + pvfb->greenBits = 8; > +} > + > if (pvfb->pixelFormatDefined) { > VisualPtr vis = pScreen->visuals; > for (int i = 0; i < pScreen->numVisuals; i++) { > -- > 1.5.6.5 > > > -- > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > ___ > Tigervnc-devel mailing list > Tigervnc-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tigervnc-devel -- Adam Tkac, Red Hat, Inc. -- Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d ___ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
Re: [Tigervnc-devel] [PATCH] Properly report transport errors to GNUTLS
On Tue, Aug 24, 2010 at 08:05:39AM +0200, Martin Koegler wrote: > Signed-off-by: Martin Koegler Commited as r4125, thanks for the patch. Regards, Adam > --- > common/rdr/TLSInStream.cxx | 27 --- > common/rdr/TLSOutStream.cxx | 14 ++ > 2 files changed, 26 insertions(+), 15 deletions(-) > > diff --git a/common/rdr/TLSInStream.cxx b/common/rdr/TLSInStream.cxx > index f6bf334..7a9859e 100644 > --- a/common/rdr/TLSInStream.cxx > +++ b/common/rdr/TLSInStream.cxx > @@ -35,19 +35,24 @@ enum { DEFAULT_BUF_SIZE = 16384 }; > ssize_t rdr::gnutls_InStream_pull(gnutls_transport_ptr str, void* data, > size_t size) > { > - InStream* in= (InStream*) str; > - > - if (!in->check(1, 1, false)) { > -errno=EAGAIN; > + try { > +InStream* in= (InStream*) str; > + > +if (!in->check(1, 1, false)) { > + gnutls_transport_set_global_errno (EAGAIN); > + return -1; > +} > + > +if (in->getend() - in->getptr() < size) > + size = in->getend() - in->getptr(); > + > +in->readBytes(data, size); > + > +return size; > + } catch (Exception& e) { > +gnutls_transport_set_global_errno (EINVAL); > return -1; >} > - > - if (in->getend() - in->getptr() < size) > -size = in->getend() - in->getptr(); > - > - in->readBytes(data, size); > - > - return size; > } > > TLSInStream::TLSInStream(InStream* _in, gnutls_session _session) > diff --git a/common/rdr/TLSOutStream.cxx b/common/rdr/TLSOutStream.cxx > index 59edf15..03997d4 100644 > --- a/common/rdr/TLSOutStream.cxx > +++ b/common/rdr/TLSOutStream.cxx > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > > #ifdef HAVE_GNUTLS > using namespace rdr; > @@ -34,10 +35,15 @@ enum { DEFAULT_BUF_SIZE = 16384 }; > ssize_t rdr::gnutls_OutStream_push(gnutls_transport_ptr str, const void* > data, > size_t size) > { > - OutStream* out = (OutStream*) str; > - out->writeBytes(data, size); > - out->flush(); > - return size; > + try { > +OutStream* out = (OutStream*) str; > +out->writeBytes(data, size); > +out->flush(); > +return size; > + } catch (Exception& e) { > +gnutls_transport_set_global_errno (EINVAL); > +return -1; > + } > } > > TLSOutStream::TLSOutStream(OutStream* _out, gnutls_session _session) > -- > 1.5.6.5 > > > -- > Sell apps to millions through the Intel(R) Atom(Tm) Developer Program > Be part of this innovative community and reach millions of netbook users > worldwide. Take advantage of special opportunities to increase revenue and > speed time-to-market. Join now, and jumpstart your future. > http://p.sf.net/sfu/intel-atom-d2d > ___ > Tigervnc-devel mailing list > Tigervnc-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tigervnc-devel -- Adam Tkac, Red Hat, Inc. -- Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d ___ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel
Re: [Tigervnc-devel] [PATCH] Provide default pixel format for depth 32
On Wed, Aug 25, 2010 at 03:40:29PM +0200, Adam Tkac wrote: > On Tue, Aug 24, 2010 at 08:05:38AM +0200, Martin Koegler wrote: > > Libraries like qt segfault, if reader is enabled but this information > > is not set > > Commited with little modifications as r4124. Thanks for the patch. Your patch leaves pvfb->blueBits, pvfb->redBits, pvfb->greenBits and pvfb->rgbNotBgr undefined but uses their values, if the pixelformat has not been specifed on the command line and the depth is not 16 or 32. Regards, Martin Kögler -- Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d ___ Tigervnc-devel mailing list Tigervnc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-devel