Re: [rfbproto] [PATCH] Describe the xvp extension
On Mon, Jun 01, 2009 at 01:09:44PM +0200, Peter Rosin wrote: Den 2009-06-01 11:37 skrev Pierre Ossman: On Fri, 29 May 2009 21:41:22 +0100 Colin Dean c.c.d...@durham.ac.uk wrote: I suggest just stick with xvp, which is what it's been called up to now. After all, it could be applied to systems other than virtual machines, so having a name with virtual machine in it is unnecessarily restrictive. A very good point. So something along the lines of Power Control Pseudo-encoding then. :) I won't veto this addition based on the name, but I strongly believe that we should make every effort to produce general extensions so that we don't end up with multiple almost identical ones. I think the point Colin is trying to make is that he wants to stick to xvp as that name has already been exposed, google has indexed it etc etc. Changing the name this late will only cause confusion. So, instead of trying to find some (poor) expansion of xvp, we just leave it at xvp and describe what you can do with it (and maybe include a note about where the name originated for the curious, but in that case state that the uses are more general than the original name implies). I'm sorry for starting this thread now. I think keeping the existing xvp name is the right answer. Many of the existing extensions are simply named after the product initiially defining the extension. We shouldn't try to rename them now. I merely wanted the descriptive text in the spec of the extension to be generic, leaving xvp as the name. Regards, Daniel -- |: http://berrange.com/ -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://freshmeat.net/~danielpb/-o- http://gtk-vnc.sourceforge.net :| signature.asc Description: Digital signature -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, Big Spaceship. http://p.sf.net/sfu/creativitycat-com ___ tigervnc-rfbproto mailing list tigervnc-rfbproto@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-rfbproto
Re: [rfbproto] [PATCH] Describe the xvp extension
Hi all, I think the point Colin is trying to make is that he wants to stick to xvp as that name has already been exposed, google has indexed it etc etc. Changing the name this late will only cause confusion. So, instead of trying to find some (poor) expansion of xvp, we just leave it at xvp and describe what you can do with it (and maybe include a note about where the name originated for the curious, but in that case state that the uses are more general than the original name implies). Peter has got my point: there's already been discussion on the Citrix mailing lists, and I made public a self-contained spec for the extension, in a style to match the RealVNC spec: http://www.dur.ac.uk/c.c.dean/xvp/rfb-extensions.html both using the xvp name. Re Pierre's point ... +See http://www.dur.ac.uk/c.c.dean/xvp/ for details of the reference +implementation, which allows shutdown, reboot and reset of virtual +machines running on Citrix XenServer. Does this page add anything to the protocol definition? We don't have official reference implementations for anything else, so I'm sceptical about adding one here. ... I put this wording in at Daniel's suggestion. Can I suggest we probably have spent enough time on this thread (!) and ask somebody to sign off and apply my most recent patch (from Friday evening)? Thanks, Colin -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, Big Spaceship. http://p.sf.net/sfu/creativitycat-com ___ tigervnc-rfbproto mailing list tigervnc-rfbproto@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-rfbproto
Re: [rfbproto] [PATCH] Describe the xvp extension
On Fri, 29 May 2009 07:29:40 +0100 DEAN C.C. c.c.d...@durham.ac.uk wrote: That sounds like a perfectly good description, Peter. Pierre: would you be happy if I changed all occurrences of (Xen VNC Proxy) in my patch to (eXtension for Virtual machine Power options)? It's a lot more generic, so yes. Although I don't think that it would be a problem to loose the connect to the XVP acronym and avoid this convoluted backronym. I don't think people will be that confused by different names in RealVNC's and our spec. :) Rgds -- Pierre OssmanOpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio ABWeb: http://www.cendio.com signature.asc Description: PGP signature -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, Big Spaceship. http://p.sf.net/sfu/creativitycat-com ___ tigervnc-rfbproto mailing list tigervnc-rfbproto@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-rfbproto
Re: [rfbproto] [PATCH] Describe the xvp extension
On Fri, 29 May 2009 07:29:40 +0100 DEAN C.C. c.c.d...@durham.ac.uk wrote: That sounds like a perfectly good description, Peter. Pierre: would you be happy if I changed all occurrences of (Xen VNC Proxy) in my patch to (eXtension for Virtual machine Power options)? It's a lot more generic, so yes. Although I don't think that it would be a problem to loose the connect to the XVP acronym and avoid this convoluted backronym. I don't think people will be that confused by different names in RealVNC's and our spec. :) I suggest just stick with xvp, which is what it's been called up to now. After all, it could be applied to systems other than virtual machines, so having a name with virtual machine in it is unnecessarily restrictive. Attached is another attempt at a patch. If anybody would like to modify it further, please just go ahead and do so. Cheers, Colin Describe the xvp extension The xvp extension allows a client to perform shutdown, reboot and reset operations on the system whose framebuffer it is displaying. Signed-off-by: Colin Dean c.c.d...@durham.ac.uk --- Index: rfbproto.rst === --- rfbproto.rst (revision 3823) +++ rfbproto.rst (working copy) @@ -788,7 +788,7 @@ 253 `gii Client Message`_ 252 tight 251 `SetDesktopSize`_ -250 Colin Dean xvp +250 `xvp Client Message`_ === === Note that before sending a message with an optional message type a @@ -1413,6 +1413,27 @@ should make every effort to preserve the fields it does not wish to modify, including any unknown *flags* bits. +xvp Client Message +-- + +A client supporting the *xvp* extension sends this to request that the +server initiate a clean shutdown, clean reboot or abrupt reset of the +system whose framebuffer the client is displaying. + +=== == === +No. of bytesType [Value]Description +=== == === +1 ``U8`` 250*message-type* +1 *padding* +1 ``U8`` 1 *xvp-extension-version* +1 ``U8`` *xvp-message-code* +=== == === + +The possible values for *xvp-message-code* are: 2 - XVP_SHUTDOWN, +3 - XVP_REBOOT, and 4 - XVP_RESET. The client must have already +established that the server supports this extension, by requesting the +`xvp Pseudo-encoding`_. + Server to Client Messages + @@ -1436,7 +1457,7 @@ 254, 127VMWare 253 `gii Server Message`_ 252 tight -250 Colin Dean xvp +250 `xvp Server Message`_ === === Note that before sending a message with an optional message type a @@ -1593,6 +1614,31 @@ communications. A *device-origin* of zero indicates device creation failure. +xvp Server Message +-- + +This has the following format: + +=== == === +No. of bytesType [Value]Description +=== == === +1 ``U8`` 250*message-type* +1 *padding* +1 ``U8`` 1 *xvp-extension-version* +1 ``U8`` *xvp-message-code* +=== == === + +The possible values for *xvp-message-code* are: 0 - XVP_FAIL and 1 - +XVP_INIT. + +A server which supports the *xvp* extension declares this by sending a +message with an XVP_INIT *xvp-message-code* when it receives a request +from the client to use the `xvp Pseudo-encoding`_. + +A server which subsequently receives an `xvp Client Message`_ requesting +an operation which it is unable to perform, informs the client of this +by sending a message with an XVP_FAIL *xvp-message-code*. + Encodings + @@ -1613,6 +1659,7 @@ -223`DesktopSize Pseudo-encoding`_ -305`gii Pseudo-encoding`_ -308`ExtendedDesktopSize Pseudo-encoding`_ +-309`xvp Pseudo-encoding`_ === === Other registered encodings are: @@ -1630,7 +1677,6 @@ -273 to -304VMWare -306popa -307Peter Astrand DesktopName --309Colin Dean xvp 0x574d5600 to 0x574d56ffVMWare === === @@ -2329,3 +2375,16 @@ need to parse the list of screens and can simply display
Re: [rfbproto] [PATCH] Describe the xvp extension
Pierre, I'd be happy with that. Tristan allocated the numbers as XVP, so do people think we should keep this as an abbreviation, i.e. refer to it as XVP (virtual machine control) ..., or banish the letters XVP completely? Personally, I'd vote to keep the XVP, just for consistency with RealVNC's document, and so one can refer to the XVP extensions to RFB, which is more concise than virtual machine control extensions to RFB. Thoughts? Colin -Original Message- From: Pierre Ossman [mailto:oss...@cendio.se] Sent: Thu 5/28/2009 2:49 PM To: DEAN C.C. Cc: Daniel P. Berrange; tigervnc-rfbproto@lists.sourceforge.net Subject: Re: [rfbproto] [PATCH] Describe the xvp extension On Wed, 27 May 2009 10:18:46 +0100 Colin Dean c.c.d...@durham.ac.uk wrote: It would be really good if QEMU/KVM's VNC server supported this. Can we agree on some naming, and then I'll submit a new patch. How about using Xen VM control pseudo-encoding, Xen VM control client message and Xen VM control server message? Personally I think we should drop the Xen name completely (it could still be mentioned in the text as the origin though). Having something that sounds Xen-specific, even if it isn't, doesn't help adoption IMO. So my vote is Virtual Machine Control ... so that it's clear what this extension does even from just the name. Rgds -- Pierre OssmanOpenSource-based Thin Client Technology System Developer Telephone: +46-13-21 46 00 Cendio ABWeb: http://www.cendio.com -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, Big Spaceship. http://p.sf.net/sfu/creativitycat-com ___ tigervnc-rfbproto mailing list tigervnc-rfbproto@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-rfbproto
Re: [rfbproto] [PATCH] Describe the xvp extension
Hi Daniel, I think perhaps it might be desirable to change the description to avoid direct reference to Citrix XenServer / XVP in the docs. Instead say that the XVP extension allows for lifecycle control of a virtual machine associated with the VNC server. Then refer to XVP / XenServer as the primary / reference implementation of the extension. The reason I'm suggesting, is that I'm inclined to try adding this VNC extension to QEMU/KVM's VNC server too - this would in fact also allow Xen to be rebooted/shutdown/etc without talking to XenServer. It would be really good if QEMU/KVM's VNC server supported this. Can we agree on some naming, and then I'll submit a new patch. How about using Xen VM control pseudo-encoding, Xen VM control client message and Xen VM control server message? Colin -- Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, iPhoneDevCamp as they present alongside digital heavyweights like Barbarian Group, R/GA, Big Spaceship. http://p.sf.net/sfu/creativitycat-com ___ tigervnc-rfbproto mailing list tigervnc-rfbproto@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tigervnc-rfbproto
