Re: "Modern" compilation

[Patrick Beard]

At 6:40 PM -0700 10/23/2000, Arun Katkere wrote:
>While trying to figure out why exactly is Jasper page loading dog slow
>(initial compilation is very slow, most time spent in Zip file read, and
>page load is slow because of secure session id initialization), I noticed
>that Tomcat still uses "classic" javac (sun.tools.javac.Main) instead of
>"modern" javac (com.sun.tools.javac.Main) even in JDK 1.3 context.

I've seen serious performance problems with the current 3.3 
development version, but the 3.1 release is quite snappy, so I really 
doubt this is a compiler performance problem.

>Great software, but it is not easy to convince that to folks used to near
>instantaneous page compilation/load times of JServ/GNUJSP/jikes combo that
>Tomcat is the greatest thing out there when they sit waiting for 30-45
>seconds waiting for page to compile (or even just load!!). We are not
>talking about bottlenecks in outside code. It is the same with Tomcat sample
>JSPs.

Which version of Tomcat are you running against? On my Powerbook 
G3/500, I get near instantaneous page loads using Tomcat 3.1.

- Patrick
-- 

// Patrick C. Beard
// Java Runtime Enthusiast -- "Will invoke interfaces for food."
// mailto:[EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: "Modern" compilation

[casper mdb]

Arun Katkere  <[EMAIL PROTECTED]> wrote
> 
> Great software, but it is not easy to convince that to folks used to near
> instantaneous page compilation/load times of JServ/GNUJSP/jikes combo that
> Tomcat is the greatest thing out there when they sit waiting for 30-45
> seconds waiting for page to compile (or even just load!!). We are not
> talking about bottlenecks in outside code. It is the same with Tomcat sample
> JSPs.

I have never been waiting 30-45 seconds with Tomcat, not even on my experimentel 
Linuxbox - a Pentium 100MHz with 64 MB. It is more like 5-10 seconds. I tried Rasin 
with Jikes last night, wich compiled new jsp-pages so fast (< 1s), that I thougth I 
had made a mistake updating my files. 
But overall I really really like Tomcat. So keep up the good work. 

-Casper


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

"Modern" compilation

[Arun Katkere]

While trying to figure out why exactly is Jasper page loading dog slow
(initial compilation is very slow, most time spent in Zip file read, and
page load is slow because of secure session id initialization), I noticed
that Tomcat still uses "classic" javac (sun.tools.javac.Main) instead of
"modern" javac (com.sun.tools.javac.Main) even in JDK 1.3 context. 

Is there plans to support this compiler (which is much faster)? Does anyone
have a patch/plugin we can use?

While trying to write a compiler plugin myself, I realized there is no way
to force the modern compiler to write to my stream instead of
System.out/err. Perhaps this is the reason why modern compiler is not
supported??

Also, use of any compiler plugin other than the standard SunJavaCompiler is
next to impossible since the JSP engine does not read web.xml in
$TOMCAT_HOME/conf. So, we are left with two unfriendly choices. Patch tomcat
code or insert Tomcat specific code into each web.xml. Is there plans to
move JSP compiler plugin specification to server.xml?

Great software, but it is not easy to convince that to folks used to near
instantaneous page compilation/load times of JServ/GNUJSP/jikes combo that
Tomcat is the greatest thing out there when they sit waiting for 30-45
seconds waiting for page to compile (or even just load!!). We are not
talking about bottlenecks in outside code. It is the same with Tomcat sample
JSPs.

-arun

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #301 was closed (apparently by: Nick Bauman)

[BugRat Mail System]

Report #301 was closed by Person #0

   Synopsis: java.awt package

 (logged in as: Nick Bauman)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[BUG TACKING] BugRat searches improved

[Nick Bauman]

Hello all,

BugRat is no longer as slow as a constipated Nepalese yak herder. (pardon
to all my yak-herding friends from Nepal)

Searches now return before you have to get up and shave. Sorry for the
inconvienience.

-Nick




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler ForwardGenerator.java IncludeGenerator.java

[pierred]

pierred 00/10/23 17:38:00

  Modified:jasper/src/share/org/apache/jasper/compiler
ForwardGenerator.java IncludeGenerator.java
  Log:
  Bug fix: make sure params is not null before checking its size
  
  Revision  ChangesPath
  1.3   +4 -4  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/ForwardGenerator.java
  
  Index: ForwardGenerator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/ForwardGenerator.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ForwardGenerator.java 2000/10/11 19:35:12 1.2
  +++ ForwardGenerator.java 2000/10/24 00:37:57 1.3
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/ForwardGenerator.java,v
 1.2 2000/10/11 19:35:12 shemnon Exp $
  - * $Revision: 1.2 $
  - * $Date: 2000/10/11 19:35:12 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/ForwardGenerator.java,v
 1.3 2000/10/24 00:37:57 pierred Exp $
  + * $Revision: 1.3 $
  + * $Date: 2000/10/24 00:37:57 $
*
* 
* 
  @@ -105,7 +105,7 @@
   writer.println("out.clear();");
writer.println("String _jspx_qfStr = \"\";");

  - if (params.size() > 0) {
  + if (params != null && params.size() > 0) {
Enumeration en = params.keys();
while (en.hasMoreElements()) {
String key = (String) en.nextElement();
  
  
  
  1.5   +4 -4  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java
  
  Index: IncludeGenerator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- IncludeGenerator.java 2000/10/11 19:35:14 1.4
  +++ IncludeGenerator.java 2000/10/24 00:37:58 1.5
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
 1.4 2000/10/11 19:35:14 shemnon Exp $
  - * $Revision: 1.4 $
  - * $Date: 2000/10/11 19:35:14 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
 1.5 2000/10/24 00:37:58 pierred Exp $
  + * $Revision: 1.5 $
  + * $Date: 2000/10/24 00:37:58 $
*
* 
* 
  @@ -132,7 +132,7 @@
if (flush) {
writer.println("out.flush();");
}
  - if (params.size() > 0) {
  + if (params != null && params.size() > 0) {
Enumeration en = params.keys();
while (en.hasMoreElements()) {
String key = (String) en.nextElement();
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler JspParseEventListener.java

[pierred]

pierred 00/10/23 14:19:57

  Modified:jasper/src/share/org/apache/jasper/compiler
JspParseEventListener.java
  Log:
  Better error message when an included file is not found.
  
  Revision  ChangesPath
  1.7   +9 -4  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspParseEventListener.java
  
  Index: JspParseEventListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspParseEventListener.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- JspParseEventListener.java2000/10/11 19:35:14 1.6
  +++ JspParseEventListener.java2000/10/23 21:19:56 1.7
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspParseEventListener.java,v
 1.6 2000/10/11 19:35:14 shemnon Exp $
  - * $Revision: 1.6 $
  - * $Date: 2000/10/11 19:35:14 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/JspParseEventListener.java,v
 1.7 2000/10/23 21:19:56 pierred Exp $
  + * $Revision: 1.7 $
  + * $Date: 2000/10/23 21:19:56 $
*
* 
*
  @@ -738,7 +738,12 @@
*/
try {
parserCtl.parse(file, encoding);
  - } catch (Exception fnfe) {
  + } catch (FileNotFoundException ex) {
  + throw new CompileException(
  +start,
  +
Constants.getString("jsp.error.file.not.found",
  +new Object[]{file}));
  + } catch (Exception ex) {
throw new CompileException(
   start,
   
Constants.getString("jsp.error.include.bad.file"));
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Policy based Security in Tomcat 3.1

[Glenn Nielsen]

Tomcat support for policy based security was added after 3.1,
and is available in the 3.2 release candidate.

Regards,

Glenn

Gino Cerro Jr wrote:
> 
> Hello everybody,
> 
> It seems to me that there's no Policy Base Security support via a
> SecurityManager implementation in Tomcat.  Am I wrong?
> 
> I have some code that calls getProtectionDomain() from the Class class.
> When it is used from Tomcat 3.1, the method returns NULL and when it's used
> from the JVM (in a test class of mine), it returns a valid ProtectionDomain
> reference.  Is that related to the SecurityManager implementation missing in
> Tomcat?
> 
> TIA.
> 
> - Gino
> 
> --
> Gino Cerro Jr
> Acolyte Technologies
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]

-- 
--
Glenn Nielsen [EMAIL PROTECTED] | /* Spelin donut madder|
MOREnet System Programming   |  * if iz ina coment.  |
Missouri Research and Education Network  |  */   |
--

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Policy based Security in Tomcat 3.1

[Gino Cerro Jr]

Hello everybody,

It seems to me that there's no Policy Base Security support via a
SecurityManager implementation in Tomcat.  Am I wrong?

I have some code that calls getProtectionDomain() from the Class class.
When it is used from Tomcat 3.1, the method returns NULL and when it's used
from the JVM (in a test class of mine), it returns a valid ProtectionDomain
reference.  Is that related to the SecurityManager implementation missing in
Tomcat?

TIA.

- Gino

--
Gino Cerro Jr
Acolyte Technologies


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core ContextManager.java

[Nacho]

Sorry, forget to name the original Submitter was :

Andrew Sudell [[EMAIL PROTECTED]] 


Saludos ,
Ignacio J. Ortega


> -Mensaje original-
> De: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> Enviado el: lunes 23 de octubre de 2000 18:56
> Para: [EMAIL PROTECTED]
> Asunto: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core
> ContextManager.java
> 
> 
> nacho   00/10/23 09:55:51
> 
>   Modified:src/share/org/apache/tomcat/core Tag: tomcat_32
> ContextManager.java
>   Log:
>   Allowing to compile under jdk 1.1
>   
>   Revision  ChangesPath
>   No   revision
>   
>   
>   No   revision
>   
>   
>   1.100.2.12 +2 -1  
> jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java
>   
>   Index: ContextManager.java
>   ===
>   RCS file: 
> /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Cont
extManager.java,v
>   retrieving revision 1.100.2.11
>   retrieving revision 1.100.2.12
>   diff -u -r1.100.2.11 -r1.100.2.12
>   --- ContextManager.java 2000/10/04 20:49:16 1.100.2.11
>   +++ ContextManager.java 2000/10/23 16:55:48 1.100.2.12
>   @@ -332,7 +332,8 @@
> *  session id generator. 
> */
>public void setRandomClass(String randomClass) {
>   -System.setProperty("tomcat.sessionid.randomclass", 
> randomClass);
>   +Properties sysProp = System.getProperties();
>   +   sysProp.put("tomcat.sessionid.randomclass", randomClass);
>}
>
>/** Get the showDebugInfo property to be used for 
> controlling the display of
>   
>   
>   
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core ContextManager.java

[nacho]

nacho   00/10/23 09:55:51

  Modified:src/share/org/apache/tomcat/core Tag: tomcat_32
ContextManager.java
  Log:
  Allowing to compile under jdk 1.1
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.100.2.12 +2 -1  
jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java
  
  Index: ContextManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java,v
  retrieving revision 1.100.2.11
  retrieving revision 1.100.2.12
  diff -u -r1.100.2.11 -r1.100.2.12
  --- ContextManager.java   2000/10/04 20:49:16 1.100.2.11
  +++ ContextManager.java   2000/10/23 16:55:48 1.100.2.12
  @@ -332,7 +332,8 @@
*  session id generator. 
*/
   public void setRandomClass(String randomClass) {
  -System.setProperty("tomcat.sessionid.randomclass", randomClass);
  +Properties sysProp = System.getProperties();
  + sysProp.put("tomcat.sessionid.randomclass", randomClass);
   }
   
   /** Get the showDebugInfo property to be used for controlling the display of
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #110 - entire org.apache.tomcat.util package locks up under load

[BugRat Mail System]

- Sender's Comment -
Here is an odd one
- End Of Sender's Comment ---
Report URL: 

Report #110 Details

Project: Tomcat
Category: Feature Requests
SubCategory: Enhancement
Class: swbug
State: linked
Priority: high
Severity: serious
Confidence: public
Environment: 
   Release: 3.1
   JVM Release: SE linux1.3.0b7
   Operating System: linux
   OS Release: 2.2
   Platform: i686

Synopsis: 
entire org.apache.tomcat.util package locks up under load

Description:
The use of the StringManager.getManager() that is everywhere in that package makes 
every thread compete for the lock of that class. The only reason I can see why that 
method is synchronized in the first place is to prevent duplicate loads of the same 
ResourceBundle (which would later be garbagecollected anyway...). Therefore either

a) remove the synchronization of StringManager.getManager()
b) pass the manager around within the package

Please note that this method is called MANY times by each thread when writing the 
reponse.

Title: 
BugRat Report #
110





BugRat Report #
110




Project:
Tomcat


Release:
3.1




Category:
Feature Requests


SubCategory:
Enhancement




Class:
swbug


State:
linked




Priority:
high


Severity:
serious




Confidence:
public





Submitter:
_Anonymous ( [EMAIL PROTECTED] )

Date Submitted:
Sep 12 2000, 01:51:49 CDT

Responsible:
Z_Tomcat Alias ( [EMAIL PROTECTED] )


Synopsis:

entire org.apache.tomcat.util package locks up under load


 Environment: (jvm, os, osrel, platform)

SE linux1.3.0b7, linux, 2.2, i686



Additional Environment Description:





Report Description:

The use of the StringManager.getManager() that is everywhere in that package makes every thread compete for the lock of that class. The only reason I can see why that method is synchronized in the first place is to prevent duplicate loads of the same ResourceBundle (which would later be garbagecollected anyway...). Therefore either

a) remove the synchronization of StringManager.getManager()
b) pass the manager around within the package

Please note that this method is called MANY times by each thread when writing the reponse.



How To Reproduce:





Workaround:





View this Report online...






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 3.2 release?

[[EMAIL PROTECTED]]

On Mon, 23 Oct 2000, Graham Wright wrote:

> We are about to enter the final test phase of a project which we would
> like to run against a release version of 3.2.
> 
> Is there any information on when the release will be built?
> 
> 
> thanks
> Graham Wright
> 

there are still problems with sessions under load balancing and cookies
with or without load balancing in 3.2b6 ...anyone planning to integrate
those patches ?

-Ys-
[EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Tomcat 3.2 release?

[Sam Ruby/Raleigh/IBM]

Graham Wright wrote:
>
> We are about to enter the final test phase of a
> project which we would like to run against a
> release version of 3.2.
>
> Is there any information on when the release
> will be built?

I'm building it now I saw the report where a change was made that
precluded running Tomcat on JDK 1.1 which troubles me, so I may add that
change in and rebuild.  So plan for tomorrow...

To be clear, that's for a version that everybody can vote on.  But I don't
expect the vote to be controversial...

- Sam Ruby


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #301 has been filed.

[BugRat Mail System]

Bug report #301 has just been filed.

You can view the report at the following URL:

   

REPORT #301 Details.

Project: Tomcat
Category: Bug Report
SubCategory: New Bug Report
Class: swbug
State: received
Priority: low
Severity: non-critical
Confidence: public
Environment: 
   Release: 3.2.6
   JVM Release: 1.2.
   Operating System: NT
   OS Release: 4.0
   Platform: Windows

Synopsis: 
java.awt package

Description:
I have some server-side image creation code that utilizes the java.awt package.  When 
I try to use it with tomcat, I get a java.lang.NoClassDefFound for any java.awt 
classes.

Title: 
BugRat Report #
301





BugRat Report #
301




Project:
Tomcat


Release:
3.2.6




Category:
Bug Report


SubCategory:
New Bug Report




Class:
swbug


State:
received




Priority:
low


Severity:
non-critical




Confidence:
public





Submitter:
Leon Palermo ( [EMAIL PROTECTED] )

Date Submitted:
Oct 23 2000, 10:15:27 CDT

Responsible:
Z_Tomcat Alias ( [EMAIL PROTECTED] )


Synopsis:

java.awt package


 Environment: (jvm, os, osrel, platform)

1.2., NT, 4.0, Windows



Additional Environment Description:





Report Description:

I have some server-side image creation code that utilizes the java.awt package.  When I try to use it with tomcat, I get a java.lang.NoClassDefFound for any java.awt classes.



How To Reproduce:

null



View this report online...






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Tomcat 3.2 release?

[Graham Wright]

We are about to enter the final test phase of a project which we would
like to run against a release version of 3.2.

Is there any information on when the release will be built?


thanks
Graham Wright



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core ApplicationFilterChain.java ApplicationFilterConfig.java LocalStrings.properties StandardContext.java StandardWrapperValve.java ApplicationFilterWrapper.java

[Bob Jamison]

[EMAIL PROTECTED] wrote:

> craigmcc00/10/22 02:55:54

I just noticed the time-of-day on the message, and the
CVS time.   You need to get some sleep, guy!   ;-)



Bob



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #300 has been filed.

[BugRat Mail System]

Bug report #300 has just been filed.

You can view the report at the following URL:

   

REPORT #300 Details.

Project: Tomcat
Category: Bug Report
SubCategory: New Bug Report
Class: swbug
State: received
Priority: medium
Severity: non-critical
Confidence: public
Environment: 
   Release: 3.4b6
   JVM Release: 1.2.2
   Operating System: NT
   OS Release: 4.0
   Platform: Intel

Synopsis: 
Exception below thrown

Description:
2000-10-23 04:04:26 - ContextManager: Error reading request, ignored - 
java.lang.ArrayIndexOutOfBoundsException
at 
org.apache.tomcat.service.http.HttpRequestAdapter.parseHeaderFiled(HttpRequestAdapter.java:224)
at 
org.apache.tomcat.service.http.HttpRequestAdapter.readHeaders(HttpRequestAdapter.java:205)
at 
org.apache.tomcat.service.http.HttpRequestAdapter.readNextRequest(HttpRequestAdapter.java:140)
at 
org.apache.tomcat.service.http.HttpConnectionHandler.processConnection(HttpConnectionHandler.java:195)
at org.apache.tomcat.service.TcpWorkerThread.runIt(PoolTcpEndpoint.java:407)
at org.apache.tomcat.util.ThreadPool$ControlRunnable.run(ThreadPool.java:498)
at java.lang.Thread.run(Thread.java:484)

Title: 
BugRat Report #
300





BugRat Report #
300




Project:
Tomcat


Release:
3.4b6




Category:
Bug Report


SubCategory:
New Bug Report




Class:
swbug


State:
received




Priority:
medium


Severity:
non-critical




Confidence:
public





Submitter:
_Anonymous ( [EMAIL PROTECTED] )

Date Submitted:
Oct 23 2000, 09:15:06 CDT

Responsible:
Z_Tomcat Alias ( [EMAIL PROTECTED] )


Synopsis:

Exception below thrown


 Environment: (jvm, os, osrel, platform)

1.2.2, NT, 4.0, Intel



Additional Environment Description:





Report Description:

2000-10-23 04:04:26 - ContextManager: Error reading request, ignored - java.lang.ArrayIndexOutOfBoundsException
at org.apache.tomcat.service.http.HttpRequestAdapter.parseHeaderFiled(HttpRequestAdapter.java:224)
at org.apache.tomcat.service.http.HttpRequestAdapter.readHeaders(HttpRequestAdapter.java:205)
at org.apache.tomcat.service.http.HttpRequestAdapter.readNextRequest(HttpRequestAdapter.java:140)
at org.apache.tomcat.service.http.HttpConnectionHandler.processConnection(HttpConnectionHandler.java:195)
at org.apache.tomcat.service.TcpWorkerThread.runIt(PoolTcpEndpoint.java:407)
at org.apache.tomcat.util.ThreadPool$ControlRunnable.run(ThreadPool.java:498)
at java.lang.Thread.run(Thread.java:484)



View this report online...






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/startup Main.java

[nacho]

nacho   00/10/23 08:17:58

  Modified:src/share/org/apache/tomcat/request JDBCRealm.java
SimpleRealm.java
   src/share/org/apache/tomcat/startup Main.java
  Log:
  Porting a patch done for 3.2, into the main branch,
  it solves a bug in authorization handling.
  
  Revision  ChangesPath
  1.22  +9 -5  
jakarta-tomcat/src/share/org/apache/tomcat/request/JDBCRealm.java
  
  Index: JDBCRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/request/JDBCRealm.java,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- JDBCRealm.java2000/09/29 21:10:02 1.21
  +++ JDBCRealm.java2000/10/23 15:17:57 1.22
  @@ -1,7 +1,7 @@
   /* 
  - * $Header: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/request/JDBCRealm.java,v 1.21 
2000/09/29 21:10:02 costin Exp $
  - * $Revision: 1.21 $
  - * $Date: 2000/09/29 21:10:02 $
  + * $Header: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/request/JDBCRealm.java,v 1.22 
2000/10/23 15:17:57 nacho Exp $
  + * $Revision: 1.22 $
  + * $Date: 2000/10/23 15:17:57 $
*
* The Apache Software License, Version 1.1
*
  @@ -292,7 +292,7 @@
* @param algorithm the Encode type
*/
   
  -public void setEncode(String algorithm) {
  +public void setDigest(String algorithm) {
   digest = algorithm;
   }
   
  @@ -535,7 +535,10 @@
   
if( checkPassword( user, password ) ) {
if( debug > 0 ) log( "Auth ok, user=" + user );
  - req.setRemoteUser( user );
  +Context ctx = req.getContext();
  +if (ctx != null)
  +req.setAuthType(ctx.getAuthMethod());
  +req.setRemoteUser( user );
   req.setNote(reqRealmSignNote,this);
}
return 0;
  @@ -579,6 +582,7 @@
return 401; //HttpServletResponse.SC_UNAUTHORIZED
   // XXX check transport
   }
  +
   /**
* Digest password using the algorithm especificied and
* convert the result to a corresponding hex string.
  
  
  
  1.10  +4 -1  
jakarta-tomcat/src/share/org/apache/tomcat/request/SimpleRealm.java
  
  Index: SimpleRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/request/SimpleRealm.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- SimpleRealm.java  2000/09/01 00:48:12 1.9
  +++ SimpleRealm.java  2000/10/23 15:17:57 1.10
  @@ -136,9 +136,12 @@
   
if( debug > 0 ) log( "Verify user=" + user + " pass=" + password );
if( memoryRealm.checkPassword( user, password ) ) {
  + if( debug > 0 ) log( "Auth ok, user=" + user );
  +Context ctx = req.getContext();
  +if (ctx != null)
  +req.setAuthType(ctx.getAuthMethod());
req.setRemoteUser( user );
   req.setNote(reqRealmSignNote,this);
  - if( debug > 0 ) log( "Auth ok, user=" + user );
}
return 0;
   }
  
  
  
  1.12  +2 -3  jakarta-tomcat/src/share/org/apache/tomcat/startup/Main.java
  
  Index: Main.java
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/startup/Main.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- Main.java 2000/10/13 00:58:37 1.11
  +++ Main.java 2000/10/23 15:17:58 1.12
  @@ -379,13 +379,12 @@
File dir = new File(ld);
String[] names = dir.list( new FilenameFilter(){
   public boolean accept(File dir, String name) {
  -if (name.endsWith(".jar"))
  -{
  +if (name.endsWith(".jar")){
   return true;
   }
   return false;
   }
  -} );
  +});
return names;
   }
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #299 has been filed.

[BugRat Mail System]

Bug report #299 has just been filed.

You can view the report at the following URL:

   

REPORT #299 Details.

Project: Tomcat
Category: Bug Report
SubCategory: New Bug Report
Class: swbug
State: received
Priority: high
Severity: serious
Confidence: public
Environment: 
   Release: reg exp 1.1
   JVM Release: 1.1
   Operating System: Solaris
   OS Release: 7.1
   Platform: Sun

Synopsis: 
The end of line feature ($) doesn't work in jakarta-regexp-1.0

Description:
Once I use it there is no
match. For example, doesn't match "12345" with "^12345$"
but matches "12345" with "^12345".

Martin Gercsak, [EMAIL PROTECTED]

Title: 
BugRat Report #
299





BugRat Report #
299




Project:
Tomcat


Release:
reg exp 1.1




Category:
Bug Report


SubCategory:
New Bug Report




Class:
swbug


State:
received




Priority:
high


Severity:
serious




Confidence:
public





Submitter:
_Anonymous ( [EMAIL PROTECTED] )

Date Submitted:
Oct 23 2000, 08:50:46 CDT

Responsible:
Z_Tomcat Alias ( [EMAIL PROTECTED] )


Synopsis:

The end of line feature ($) doesn't work in jakarta-regexp-1.0


 Environment: (jvm, os, osrel, platform)

1.1, Solaris, 7.1, Sun



Additional Environment Description:





Report Description:

Once I use it there is no
match. For example, doesn't match "12345" with "^12345$"
but matches "12345" with "^12345".

Martin Gercsak, [EMAIL PROTECTED]



View this report online...






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: building Tomcat 3.2 on JDK 1.1

[Nacho]

Thanks for the patch i'll commit  it ASAP, 

i think  tomcat 3.2 is not suppoused to build on JDK 1.1, some time ago
this issue was discussed on Tomcat-dev and the result was 3.x is built
on jdk 1.2 and can run on 1.1 and tomcat 4.x only runs on 1.2 and up,
but your patch it's needed to be able to run on 1.1...

Lesson: RELEASE 3.2 ASAP no more "secure" commits in please.

Saludos ,
Ignacio J. Ortega


> -Mensaje original-
> De: Andrew Sudell [mailto:[EMAIL PROTECTED]]
> Enviado el: lunes 23 de octubre de 2000 15:34
> Para: [EMAIL PROTECTED]
> Asunto: building Tomcat 3.2 on JDK 1.1
> 
> 
> Recently, there was a post from [EMAIL PROTECTED], who was failing
> to build 3.2 on JDK 1.1.8.  I'd run into the same problem, but due
> to ISP dificulties (bad DNS lookups to the mail server) have recently
> been unable to mail to the jakarta lists.  Since, I haven't 
> seen anyone
> put forth this answer, and I don't se a similar change in the code.
> Here's what I've done to get around it.
> 
> Catch: 
> While the change makes sense to me, and I can build, and I can run,
> it's worth noting that I haven't had time to really test it.  
> Specifically,
> I haven't actually tried supplying an alternate random class.
> 
> Drew Sudell
> 
> Index: build.sh
> ===
> RCS file: /home/cvspublic/jakarta-tomcat/build.sh,v
> retrieving revision 1.11
> diff -c -r1.11 build.sh
> *** build.sh  2000/05/01 15:46:47 1.11
> --- build.sh  2000/10/23 04:55:15
> ***
> *** 20,26 
>   
>   JAVACMD=$JAVA_HOME/bin/java $ANT_OPTS
>   
> ! 
> cp=../jakarta-ant/lib/ant.jar:../jakarta-servletapi/lib/servle
t.jar:../jakarta-tools/moo.jar:../build/tomcat/classes:>
$JAVA_HOME/lib/tools.jar:$JAVA_HOME/lib/dev.jar
>   
>   $JAVACMD -classpath $cp:$CLASSPATH org.apache.tools.ant.Main "$@"
>   
> --- 20,26 
>   
>   JAVACMD=$JAVA_HOME/bin/java $ANT_OPTS
>   
> ! 
> cp=../jakarta-ant/lib/ant.jar:../jakarta-servletapi/lib/servle
t.jar:../jakarta-tools/moo.jar:../build/tomcat/classes:>
$JAVA_HOME/lib/tools.jar:$JAVA_HOME/lib/dev.jar:$JAVA_HOME/lib
> /classes.zip
>   
>   $JAVACMD -classpath $cp:$CLASSPATH org.apache.tools.ant.Main "$@"
>   
> Index: src/share/org/apache/tomcat/core/ContextManager.java
> ===
> RCS file: 
> /home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/cor
e/ContextManager.java,v
> retrieving revision 1.100.2.11
> diff -c -r1.100.2.11 ContextManager.java
> *** src/share/org/apache/tomcat/core/ContextManager.java  
> 2000/10/04 20:49:16   1.100.2.11
> --- src/share/org/apache/tomcat/core/ContextManager.java  
> 2000/10/23 04:55:46
> ***
> *** 332,338 
>*  session id generator. 
>*/
>   public void setRandomClass(String randomClass) {
> ! System.setProperty("tomcat.sessionid.randomclass", 
> randomClass);
>   }
>   
>   /** Get the showDebugInfo property to be used for 
> controlling the display of
> --- 332,341 
>*  session id generator. 
>*/
>   public void setRandomClass(String randomClass) {
> !   // XXX - JDK 1.1 lacks System.setProperty()
> !   Properties sysProp = System.getProperties();
> !   sysProp.put("tomcat.sessionid.randomclass", 
> randomClass);
> ! 
>   }
>   
>   /** Get the showDebugInfo property to be used for 
> controlling the display of
> -- 
> Drew Sudell[EMAIL PROTECTED] 
http://www.op.net/~asudell

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #296 has been filed.

[BugRat Mail System]

Bug report #296 has just been filed.

You can view the report at the following URL:

   

REPORT #296 Details.

Project: Tomcat
Category: Bug Report
SubCategory: New Bug Report
Class: swbug
State: received
Priority: medium
Severity: non-critical
Confidence: public
Environment: 
   Release: Tomcat3.2b6
   JVM Release: JDK1.1.X
   Operating System: Windows 2000
   OS Release: SP1
   Platform: Windows

Synopsis: 
Tomcat cannot build in JDK1.1.X

Description:
When I try to build Tomcat3.2b6 in JDK1.1.X, a compile error occurs in 
jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java's setRandomClass 
method.
Because System.setProperty method isnot support in JDK1.1.X.

Otherwise, Tomcat binary works in JDK1.1.X.

Maybe all platform have this problem.

Title: 
BugRat Report #
296





BugRat Report #
296




Project:
Tomcat


Release:
Tomcat3.2b6




Category:
Bug Report


SubCategory:
New Bug Report




Class:
swbug


State:
received




Priority:
medium


Severity:
non-critical




Confidence:
public





Submitter:
_Anonymous ( [EMAIL PROTECTED] )

Date Submitted:
Oct 23 2000, 04:38:17 CDT

Responsible:
Z_Tomcat Alias ( [EMAIL PROTECTED] )


Synopsis:

Tomcat cannot build in JDK1.1.X


 Environment: (jvm, os, osrel, platform)

JDK1.1.X, Windows 2000, SP1, Windows



Additional Environment Description:





Report Description:

When I try to build Tomcat3.2b6 in JDK1.1.X, a compile error occurs in 
jakarta-tomcat/src/share/org/apache/tomcat/core/ContextManager.java's setRandomClass method.
Because System.setProperty method isnot support in JDK1.1.X.

Otherwise, Tomcat binary works in JDK1.1.X.

Maybe all platform have this problem.



View this report online...






-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #295 was closed (apparently by: Ignacio Ortega)

[BugRat Mail System]

Report #295 was closed by Person #0

   Synopsis: Very serious BASIC authentication failure mode

 (logged in as: Ignacio Ortega)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

BugRat Report #294 was closed (apparently by: Ignacio Ortega)

[BugRat Mail System]

Report #294 was closed by Person #0

   Synopsis: Very serious BASIC authentication failure mode

 (logged in as: Ignacio Ortega)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]