cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters IdentityInputFilter.java

[remm]

remm01/12/05 22:46:46

  Modified:http11/src/java/org/apache/coyote/http11/filters
IdentityInputFilter.java
  Log:
  - Handle the case where no content-length was specified.
  
  Revision  ChangesPath
  1.4   +1 -5  
jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters/IdentityInputFilter.java
  
  Index: IdentityInputFilter.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11/filters/IdentityInputFilter.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- IdentityInputFilter.java  2001/12/04 06:33:07 1.3
  +++ IdentityInputFilter.java  2001/12/06 06:46:46 1.4
  @@ -162,18 +162,14 @@
   chunk.setBytes(chunk.getBytes(), chunk.getStart(), 
  (int) remaining);
   result = (int) remaining;
  -remaining = -1;
  -} else {
  -remaining = remaining - result;
   }
  +remaining = remaining - result;
   } else {
   // No more bytes left to be read : return -1 and clear the 
   // buffer
   chunk.recycle();
   result = -1;
   }
  -} else {
  -result = -1;
   }
   
   return result;
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Using inet parameter with StopTomcat in 3.2.3

[Derek Suzuki]

I have configured several connectors in server.xml with the "inet"
parameter, allowing them to bind to a single IP address.  This seems to work
fine, but it causes shutdown.sh to fail.  It seems that StopTomcat uses the
hardcoded hostname "localhost" when establishing a socket connection to the
Ajp12 connector.  I got around this by adding a getAddr() method to
PoolTcpConnector.java and using the return value in StopTomcat.
This was with Tomcat 3.2.3, but it looks like 3.2.4 does the same
thing.  If anyone else is facing this problem (and I'm not just totally
missing the correct procedure), the following diffs resolved the problem for
me.

diff -u -p -r1.1 -r1.2
--- PoolTcpConnector.java   2001/11/06 00:40:29 1.1
+++ PoolTcpConnector.java   2001/12/06 00:13:26 1.2
@@ -227,6 +227,10 @@ public final class PoolTcpConnector impl
return port;
 }

+public String getAddr() {
+return address.getHostAddress();
+}
+
 /** Generic configure system - this allows Connector
  * configuration using name/value.
  *


diff -u -p -r1.1 -r1.2
--- StopTomcat.java 2001/11/06 00:40:34 1.1
+++ StopTomcat.java 2001/12/06 00:13:26 1.2
@@ -87,6 +87,7 @@ public class StopTomcat {
 {
// Find Ajp12 connector
int portInt=8007;
+   String inetStr="localhost";
Enumeration enum=cm.getConnectors();
while( enum.hasMoreElements() ) {
Object con=enum.nextElement();
@@ -95,13 +96,14 @@ public class StopTomcat {
if( tcpCon.getTcpConnectionHandler()
instanceof Ajp12ConnectionHandler ) {
portInt=tcpCon.getPort();
+   inetStr=tcpCon.getAddr();
}
}
}

// use Ajp12 to stop the server...
try {
-   Socket socket = new Socket("localhost", portInt);
+   Socket socket = new Socket(inetStr, portInt);
OutputStream os=socket.getOutputStream();
byte stopMessage[]=new byte[2];
stopMessage[0]=(byte)254;

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: mod_webapp and apache 2.0

[Charles Yates]

>On Wed, Dec 05, 2001 at 09:34:55AM -0800, Charles Yates wrote:
>>After getting errors from "apachectl configtest" relating
>> to invalid port I added a Port directive to httpd.conf and got
>> an error that Port directive had been replaced by Listen.  I then
>> removed my Port directive, hacked on webapp.c and wa_config.c
>> to hard code server Port references and . . . . Yay, it works!
>
>I think the webapp code in the j-t-c CVS repository is updated.
>If not, then please post what you did and we can try and sort
>out the "right" fix.  -- justin
>
Ok, this is pretty ugly:

? diff
Index: webapp.c
===
RCS file: /home/cvspublic/jakarta-tomcat-connectors/webapp/nsapi/webapp.c,v
retrieving revision 1.1
diff -r1.1 webapp.c
659c659
< req->serv->port = conf_getglobals()->Vport;
---
> req->serv->port = 8080;//conf_getglobals()->Vport;
802c802
< int serverPort = conf_getglobals()->Vport;
---
> int serverPort = 8080;//conf_getglobals()->Vport;
950c950
< 
\ No newline at end of file
---
> 
? wa_conf.diff
Index: wa_config.c
===
RCS file: /home/cvspublic/jakarta-tomcat-connectors/webapp/lib/wa_config.c,v
retrieving revision 1.7
diff -r1.7 wa_config.c
109c109
< 
---
> p=8080;






--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/webapps/admin admin.css header.jsp

[patrickl]

patrickl01/12/05 21:52:22

  Modified:webapps/admin header.jsp
  Added:   webapps/admin admin.css
  Log:
  Added admin.css file to help provide some standard formatting stylesheet classes
  
  Revision  ChangesPath
  1.4   +1 -0  jakarta-tomcat-4.0/webapps/admin/header.jsp
  
  Index: header.jsp
  ===
  RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/header.jsp,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- header.jsp2001/11/10 18:06:39 1.3
  +++ header.jsp2001/12/06 05:52:21 1.4
  @@ -7,4 +7,5 @@
 
 
 
  +  
   
  
  
  
  1.1  jakarta-tomcat-4.0/webapps/admin/admin.css
  
  Index: admin.css
  ===
  .masthead-title-text {
color: #FF;
margin: 3px 5px 5px 3px;
font-size: large;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .page-title-text {
color: #FF;
margin: 3px 5px 5px 3px;
font-size: large;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .table-title-text {
color: #00;
font-weight: bold;
margin: 3px 5px 5px 4px;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .table-header-text {
color: #FF;
font-weight: bold;
margin: 3px 5px 1px 15px;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .table-label-text {
color: #00;
margin: 3px 5px 3px 15px;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .table-normal-text {
color: #00;
margin: 3px 5px 3px 15px;
font-family: "Times New Roman", Times, serif;
  }
  
  .back-table {
background-color: #CC;
margin: 0px 5px 3px 5px;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .front-table {
background-color: #FF;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .page-title-row {
background-color: #7171A5;
text-align: right;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .header-row {
background-color: #CC;
text-align: center;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .sort-row {
background-color: #CECEFF;
text-align: center;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .line-row {
background-color:#CC;
font-family: Verdana, Arial, Helvetica, Sans-Serif;
  }
  
  .button {
background-color: #FF;
  }
  
  a.button-link-text:visited, a.button-link-text:link, a.button-link-text:active {
color: #00;
background-color: #FF;
font-weight: bold;
font-family: Verdana, Geneva, Helvetica, Arial, Sans-Serif;
text-decoration: none;
  }
  
  a.button-link-text:hover {
color: #00;
background-color: #FF;
font-weight: bold;
font-family: Verdana, Geneva, Helvetica, Arial, Sans-Serif;
text-decoration: underline;
  }
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/config - New directory

[billbarker]

billbarker01/12/05 18:56:53

  jakarta-tomcat-connectors/jk/java/org/apache/ajp/tomcat4/config - New directory

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Bug 4954 - When specifying CATALINA_BASE explicitly,that dir has to have "shared/lib/jasper-*.jar" in it

[KIN-MAN CHUNG]

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4954

Looks like a build environment issue.  Want to take a look at this?
Thanks.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Jk2: pools and memory

[costinm]

Hi,

The current code is using some 'interesting' tricks with the jk_pools -
it does some funny buffer allocations on the stack and use the buffer
to create a pool ( which itself is allocated on the stack ).

While this may have some performance benefits, the code is extremely hard
to read, and doesn't 'map' to the new APR pool.

What I would like to do ( if nobody objects ) is to use:
 struct jk_pool {

  ...
  jk_pool_t *(*createChild)( jk_pool_t *_this, int sizeHint );
  ...
 }

The pool_open, etc will be removed - same for the buf[] based allocation.

Given that we recycle the endpoint ( and it's pool ) - I don't think we'll
loose too much. If APR is used we'll use apr pools anyway ( which don't
have support for the funny stack allocation ). For non-APR case, malloc
will be fine.

I'll also go ahead and replace all mallocs in the code to use the
pools.

However, I'm not an C expert ( or even a C programmer ) - if I'm missing
something please let me know.

Costin






--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5181] - HttpConnector [8080] No processor available, rejecting this connection

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5181

HttpConnector [8080] No processor available, rejecting this connection

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:32 ---
I have tested this extensively using ab (which is the load testing tool from
Apache), without experiencing any problems. Since no further details were given,
except than the bug was obvious (which clearly isn't the case for me), I'll
close the bug.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4941] - appearence of taglib directive after the usage of tag/prefix should result in fatal error.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4941

appearence of taglib directive after the usage of tag/prefix should result in fatal 
error.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||LATER



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:32 ---
This bug is actually quite hard to fix with the current structure of Jasper. 
Jasper currently treats an undeclared custom tag as an uninterpreted tag.  Not
only is the error not detected, but no code is generated for the tag.  A proper
fix requires a multi-pass compiler to scan all taglib directives before
processing tags.  A multi-pass compiler is planned for a future release.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5078] - org.apache.catalina.connector.http.HttpRequestStream.close() method is too strict - it does not allow to close the stream twice

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5078

org.apache.catalina.connector.http.HttpRequestStream.close() method is too strict - it 
does not allow to close the stream twice

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:27 ---
As stated before, that won't be fixed. The current stream is actually not strict
enough in some cases.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4138] - HttpProcessor threads have inconsistent ClassLoader state

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4138

HttpProcessor threads have inconsistent ClassLoader state

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:23 ---
While it's true that the thread binding won't be coherent between requests, it
is never a problem, since the state will be adjusted at the beginning of the
next request.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4941] - appearence of taglib directive after the usage of tag/prefix should result in fatal error.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4941

appearence of taglib directive after the usage of tag/prefix should result in fatal 
error.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||tomcat-
   ||[EMAIL PROTECTED]
 AssignedTo|tomcat- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 4138] - HttpProcessor threads have inconsistent ClassLoader state

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4138

HttpProcessor threads have inconsistent ClassLoader state

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|REMIND  |



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:22 ---
Reopen before closing.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH] latest mod_jk and Apache 2.0 initialization

[GAWLAS,JULIUS (HP-Cupertino,ex1)]

Seems like the latest j-t-c mod_jk calls initialization (init_jk) twice -
once during post_config and then in child_init. This has a side effect of
trying to create non existing workers and subsequently failing. Enclosed
simple patch prevents second initialization call.

Julius

Index: mod_jk.c
===
RCS file:
/home/cvspublic/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.39
diff -u -r1.39 mod_jk.c
--- mod_jk.c2001/12/04 21:38:26 1.39
+++ mod_jk.c2001/12/05 23:56:17
@@ -1473,7 +1473,10 @@
 jk_server_conf_t *conf =
 (jk_server_conf_t *)ap_get_module_config(s->module_config,
&jk_module);
 
-init_jk( pconf, conf, s );
+if(!conf->was_initialized) {
+conf->was_initialized = JK_TRUE;   
+   init_jk( pconf, conf, s );
+   }
 }
 
 /** Initialize jk, using worker.properties. 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 3712] - need to setup custom error page when somebody accesses stopped web application

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3712

need to setup custom error page when somebody accesses stopped web application

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|LATER   |



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:17 ---
Reopen before closing.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5277] - JDBC Realms crashs with empty password on Oracle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5277

JDBC Realms crashs with empty password on Oracle

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
  Component|AJP Connector   |Catalina
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 16:12 ---
I think there's a misunderstanding here. The problem doesn't crash Tomcat, it
just causes every request made by a user with an empty password which uses the
realm to return a 500 (which is normal since the realm throws an exception).
There's no way I can think of to differentiate this error from a generic SQL
error, and I am -1 with adding an Oracle specific fix for what is a bug in the
Oracle driver (regardless of what they say; the biggest proof is that they say
they plan to fix it).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5222] - Catalina startup

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5222

Catalina startup

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution||WORKSFORME



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 15:12 ---
Without further details, I'll close the bug as WORKFORME. Tomcat 4 does run 
well on my Windows systems.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5198] - one Apache with two Tomcats via warp failed

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5198

one Apache with two Tomcats via warp failed

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Webapps |WARP Connector



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 15:09 ---
I don't think that deployment scenario is supported at the moment.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5199] - in section not correct

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5199

 in  section not correct

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Unknown |Jasper



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 15:07 ---
Categorizing.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5226] - Strange tomcat behavior

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5226

Strange tomcat behavior

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 15:06 ---
Without further details, I'll consider this is caused by the well-known VM 
crash problem under Linux (which has well documented workarounds).

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5285] - JSP File Not Found

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5285

JSP File Not Found

[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Catalina|Jasper



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 15:05 ---
I'm afraid I can't consider this a valid bug report, as it doesn't include what 
your webapplication is doing (the JSP source), nor your directory sturcture 
(where the JSPs are, etc). Also, that functionality has been extensively 
tested, so it's likely to be a user error.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5288] - org.apache.naming.resources.Resource should be an interface

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5288

org.apache.naming.resources.Resource should be an interface

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 15:01 ---
I don't agree with that. The implementation of Resource is not trivial, and 
using the Resource interface in another directory context implementation would 
make that implementation Catalina specific. If you're doing that, there should 
be no problem with extending a class.
Wrapping will happen in all other cases, but it should be pointed out that 
using standard directory contexts with Catalina is not really supported (I 
didn't ever try it), and won't give very useful results even if it does work.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5295] - Error building Catalina when optional build.jsse Ant property not used

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5295

Error building Catalina when optional build.jsse Ant property not used

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 14:58 ---
This has been fixed in the HEAD branch, but the patch won't be ported.
Building a second time should succeed.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5295] New: - Error building Catalina when optional build.jsse Ant property not used

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5295

Error building Catalina when optional build.jsse Ant property not used

   Summary: Error building Catalina when optional build.jsse Ant
property not used
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


JSSE is not a required library in order to build Catalina.  However, if in the
build.properties file, jsse.home and other JSSE-related properties are not
defined (hence the build.jsse won't be defined in the Ant build script), javac
gives a compiler error.

Here is the problem:

In the Ant build script, if build.jsse is not defined, javac is told to exclude
the class "org.apache.catalina.net.SSLServerSocketFactory" from its FileSet. 
However, since there are other Java class files that reference
SSLServerSocketFactory, javac attempts to compile it but fails when it cannot
import the dependent JSSE-related classes.
Suggested solution:

The Catalina class "org.apache.catalina.startup.Embedded" references class
SSLServerSocketFactory, so it must be patched to no longer import the class. 
Also it must be updated to not explicity create an instance of
SSLServerSocketFactory but perhaps use the
Class.forName(...)/clazz.newInstance() mechanism.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/jk/native2/jni jk_jni_aprImpl.c

[costin]

costin  01/12/05 12:52:41

  Modified:jk/native2 build.xml
  Added:   jk/native2/jni jk_jni_aprImpl.c
  Log:
  Added the initial stub for the jni code to use apr from java.
  
  This is needed to implement any 'fun' channel ( unix domain, shmem, etc ). It'll
  also be used to implement signals ( so Jk can triger soft restarts on apache )
  and maybe change uid ( not related with jk, but trivial to do ).
  
  For now the focus is getting the functionality in ( i.e. the JNI code ), not
  the interfaces - long term we should use some nice interfaces ( like
  Socket for unix domain sockets, etc )
  
  Revision  ChangesPath
  1.4   +2 -0  jakarta-tomcat-connectors/jk/native2/build.xml
  
  Index: build.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/build.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- build.xml 2001/12/04 19:11:02 1.3
  +++ build.xml 2001/12/05 20:52:41 1.4
  @@ -83,6 +83,7 @@
 


  + 


 
  @@ -115,6 +116,7 @@



  + 
   
   

  
  
  
  1.1  jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
  
  Index: jk_jni_aprImpl.c
  ===
  /* = *
   *   *
   * The Apache Software License,  Version 1.1 *
   *   *
   *  Copyright (c) 1999-2001 The Apache Software Foundation.  *
   *   All rights reserved.*
   *   *
   * = *
   *   *
   * Redistribution and use in source and binary forms,  with or without modi- *
   * fication, are permitted provided that the following conditions are met:   *
   *   *
   * 1. Redistributions of source code  must retain the above copyright notice *
   *notice, this list of conditions and the following disclaimer.  *
   *   *
   * 2. Redistributions  in binary  form  must  reproduce the  above copyright *
   *notice,  this list of conditions  and the following  disclaimer in the *
   *documentation and/or other materials provided with the distribution.   *
   *   *
   * 3. The end-user documentation  included with the redistribution,  if any, *
   *must include the following acknowlegement: *
   *   *
   *   "This product includes  software developed  by the Apache  Software *
   *Foundation ."  *
   *   *
   *Alternately, this acknowlegement may appear in the software itself, if *
   *and wherever such third-party acknowlegements normally appear. *
   *   *
   * 4. The names  "The  Jakarta  Project",  "Jk",  and  "Apache  Software *
   *Foundation"  must not be used  to endorse or promote  products derived *
   *from this  software without  prior  written  permission.  For  written *
   *permission, please contact <[EMAIL PROTECTED]>.*
   *   *
   * 5. Products derived from this software may not be called "Apache" nor may *
   *"Apache" appear in their names without prior written permission of the *
   *Apache Software Foundation.*
   *   *
   * THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESSED OR IMPLIED WARRANTIES *
   * INCLUDING, BUT NOT LIMITED TO,  THE IMPLIED WARRANTIES OF MERCHANTABILITY *
   * AND FITNESS FOR  A PARTICULAR PURPOSE  ARE DISCLAIMED.  IN NO EVENT SHALL *
   * THE APACHE  SOFTWARE  FOUNDATION OR  ITS CONTRIBUTORS  BE LIABLE  FOR ANY *
   * DIRECT,  INDIRECT,   INCIDENTAL,  SPECIAL,  EXEMPLARY,  OR  CONSEQUENTIAL *
   * DAMAGES (INCLUDING,  BUT NOT LIMITED TO,  PROCUREMENT OF SUBSTITUTE GOODS *
   * OR SERVICES;  LOSS OF USE,  DATA,  OR PROFITS;  OR BUSINESS INTERRUPTION) *
   * HOWEVER CAUSED AND  ON ANY

cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 jk_logger_apache2.c jk_pool_apr.c mod_jk.c

[costin]

costin  01/12/05 12:49:48

  Modified:jk/native2/server/apache2 jk_logger_apache2.c jk_pool_apr.c
mod_jk.c
  Log:
  Few small fixes in apache logger and pool.
  
  Removed the old 'manual config' code, it'll be replaced with 'real' per_dir struct.
  
  Revision  ChangesPath
  1.3   +1 -1  
jakarta-tomcat-connectors/jk/native2/server/apache2/jk_logger_apache2.c
  
  Index: jk_logger_apache2.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/jk_logger_apache2.c,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- jk_logger_apache2.c   2001/12/04 19:11:56 1.2
  +++ jk_logger_apache2.c   2001/12/05 20:49:48 1.3
  @@ -152,7 +152,7 @@
   if( buf[rc-1] == '\n' )
   buf[rc-1]='\0';
   
  -if( level >= JK_LOG_ERROR ) {
  +if( level >= JK_LOG_ERROR_LEVEL ) {
   ap_log_error( file, line, APLOG_EMERG | APLOG_NOERRNO, 0, s, buf);
   } else {
   ap_log_error( file, line, APLOG_DEBUG | APLOG_NOERRNO, 0, s, buf);
  
  
  
  1.2   +11 -1 
jakarta-tomcat-connectors/jk/native2/server/apache2/jk_pool_apr.c
  
  Index: jk_pool_apr.c
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/jk_pool_apr.c,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- jk_pool_apr.c 2001/12/05 00:11:27 1.1
  +++ jk_pool_apr.c 2001/12/05 20:49:48 1.2
  @@ -64,7 +64,16 @@
   #include "jk_pool.h"
   #include "jk_env.h"
   #include "apr_pools.h"
  +#include "apr_strings.h"
   
  +int jk_pool_apr_create( jk_pool_t **newPool, jk_pool_t *parent );
  +
  +int JK_METHOD jk_pool_apr_factory(jk_env_t *env, void **result,
  +  char *type, char *name);
  +
  +void jk_pool_apr_open(jk_pool_t *_this, apr_pool_t *realPool );
  +
  +
   /** Nothing - apache will take care
*/
   static void jk_close_pool(jk_pool_t *p)
  @@ -112,10 +121,11 @@
   }
   
   static void *jk_pool_apr_strdup(jk_pool_t *p, 
  -const char *s)
  +const char *s)
   {
   return apr_pstrdup( (apr_pool_t *)p->_private, s);
   }
  +
   
   
   /* Not implemented yet */
  
  
  
  1.6   +8 -32 jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk.c
  
  Index: mod_jk.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk.c,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- mod_jk.c  2001/12/04 23:59:01 1.5
  +++ mod_jk.c  2001/12/05 20:49:48 1.6
  @@ -60,7 +60,7 @@
* Description: Apache 2 plugin for Jakarta/Tomcat *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Henri Gomez <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.5 $   *
  + * Version: $Revision: 1.6 $   *
***/
   
   /*
  @@ -1124,46 +1124,22 @@
 return DECLINED;
   
   workerEnv = (jk_workerEnv_t *)ap_get_module_config(r->server->module_config, 
  - &jk_module);
  -worker_name = apr_table_get(r->notes, JK_WORKER_ID);
  +   &jk_module);
   l = workerEnv->l;
   
  +worker_name = apr_table_get(r->notes, JK_WORKER_ID);
  +
   /* Set up r->read_chunked flags for chunked encoding, if present */
   if(rc = ap_setup_client_block(r, REQUEST_CHUNKED_DECHUNK)) {
   return rc;
   }
   
   if( worker_name == NULL ) {
  -  /* we may be here because of a manual directive ( that overrides 
  - translate and
  - sets the handler directly ). We still need to know the worker.
  -  */
  -  if( workerEnv->num_of_workers == 1 ) {
  -  /** We have a single worker ( the common case ). 
  -  ( lb is a bit special, it should count as a single worker but 
  -  I'm not sure how ). We also have a manual config directive that
  -  explicitely give control to us. */
  -  worker =  workerEnv->defaultWorker;
  -  worker_name=worker->name;
  -  l->jkLog(l, JK_LOG_DEBUG, 
  +/* SetHandler case - per_dir config should have the worker*/
  +worker =  workerEnv->defaultWorker;
  +worker_name=worker->name;
  +l->jkLog(l, JK_LOG_DEBUG, 
"Default worker for %s %s\n", r->uri, worker->name); 
  -  } else {
  -  jk_uriMap_t *uriMap=workerEnv->uriMap;
  -  jk_uriEnv_t *uriEnv;
  - 

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_ajp14_worker.c jk_channel_socket.c jk_endpoint.c jk_env.c jk_handler_discovery.c jk_handler_logon.c jk_handler_request.c jk_handler_response.c jk_jni_worker.c jk_map.c jk_pool.c jk_registry.c jk_uriMap.c jk_workerEnv.c

[costin]

costin  01/12/05 12:48:21

  Modified:jk/native2/common jk_ajp14_worker.c jk_channel_socket.c
jk_endpoint.c jk_env.c jk_handler_discovery.c
jk_handler_logon.c jk_handler_request.c
jk_handler_response.c jk_jni_worker.c jk_map.c
jk_pool.c jk_registry.c jk_uriMap.c jk_workerEnv.c
  Log:
  Get rid of most compile warnings.
  
  We still have the handler to resolve ( it'll be a generic interface, similar with
  the workers )
  
  Revision  ChangesPath
  1.4   +114 -107  jakarta-tomcat-connectors/jk/native2/common/jk_ajp14_worker.c
  
  Index: jk_ajp14_worker.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_ajp14_worker.c,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- jk_ajp14_worker.c 2001/12/04 18:40:42 1.3
  +++ jk_ajp14_worker.c 2001/12/05 20:48:20 1.4
  @@ -72,30 +72,85 @@
   #include "jk_service.h"
   #include "jk_env.h"
   
  -/* Ajp14 methods - XXX move to handler abstraction */
  -int logon(jk_endpoint_t *ae,
  -  jk_logger_t*l);
  -
  -int discovery(jk_endpoint_t *ae,
  -  jk_workerEnv_t *we,
  -  jk_logger_t*l);
  +int JK_METHOD jk_worker_ajp14_factory( jk_env_t *env, void **result,
  +   char *type, char *name);
   
  -/*
  - * Functions
  - */
  -static int validate(jk_worker_t *pThis,
  - jk_map_t*props,
  - jk_workerEnv_t *we,
  - jk_logger_t *l );
  +static int JK_METHOD
  +jk_worker_ajp14_service(jk_endpoint_t   *e, jk_ws_service_t *s,
  +jk_logger_t *l, int *is_recoverable_error);
  +
  +static int JK_METHOD
  +jk_worker_ajp14_validate(jk_worker_t *pThis, jk_map_t*props,
  + jk_workerEnv_t *we, jk_logger_t *l );
   
  -int JK_METHOD ajp_done(jk_endpoint_t **e,
  -   jk_logger_t*l);
  +static int JK_METHOD
  +jk_worker_ajp14_done(jk_endpoint_t **e, jk_logger_t*l);
   
  +static int JK_METHOD
  +jk_worker_ajp14_getEndpoint(jk_worker_t *_this, jk_endpoint_t **e,
  +jk_logger_t*l);
   
  +static int JK_METHOD
  +jk_worker_ajp14_init(jk_worker_t *_this, jk_map_t*props, 
  + jk_workerEnv_t *we, jk_logger_t *l);
   
  -/*  Method  */
  +static int JK_METHOD
  +jk_worker_ajp14_destroy(jk_worker_t **pThis, jk_logger_t *l);
  +
  +
   #define  JK_RETRIES 3
   
  +/*  Impl  */
  +
  +int JK_METHOD jk_worker_ajp14_factory( jk_env_t *env, void **result,
  +   char *type, char *name)
  +{
  +jk_logger_t *l=env->logger;
  +jk_worker_t *w=(jk_worker_t *)malloc(sizeof(jk_worker_t));
  +   
  +l->jkLog(l, JK_LOG_DEBUG, "Into ajp14_worker_factory\n");
  +
  +if (name == NULL || w == NULL) {
  +l->jkLog(l, JK_LOG_ERROR, "In ajp14_worker_factory, NULL parameters\n");
  +return JK_FALSE;
  +}
  +
  +w->name = strdup(name);
  +
  +w->proto= AJP14_PROTO;
  +
  +w->login= (jk_login_service_t *)malloc(sizeof(jk_login_service_t));
  +
  +if (w->login == NULL) {
  +l->jkLog(l, JK_LOG_ERROR,
  +   "In ajp14_worker_factory, malloc failed for login area\n");
  +return JK_FALSE;
  +}
  + 
  +memset(w->login, 0, sizeof(jk_login_service_t));
  +
  +w->login->negociation=
  +(AJP14_CONTEXT_INFO_NEG | AJP14_PROTO_SUPPORT_AJP14_NEG);
  +w->login->web_server_name=NULL; /* must be set in init */
  +
  +w->ep_cache_sz= 0;
  +w->ep_cache= NULL;
  +w->connect_retry_attempts= AJP_DEF_RETRY_ATTEMPTS;
  +
  +w->channel= NULL;
  +   
  +w->validate= jk_worker_ajp14_validate;
  +w->init= jk_worker_ajp14_init;
  +w->get_endpoint= jk_worker_ajp14_getEndpoint;
  +w->destroy=jk_worker_ajp14_destroy;
  +
  +w->logon= NULL; 
  +
  +*result = w;
  +
  +return JK_TRUE;
  +}
  +
   /*
* service is now splitted in ajp_send_request and ajp_get_reply
* much more easier to do errors recovery
  @@ -103,10 +158,11 @@
* We serve here the request, using AJP13/AJP14 (e->proto)
*
*/
  -int JK_METHOD ajp_service(jk_endpoint_t   *e, 
  -  jk_ws_service_t *s,
  -  jk_logger_t *l,
  -  int *is_recoverable_error)
  +static int JK_METHOD
  +jk_worker_ajp14_service(jk_endpoint_t   *e, 
  +jk_ws_service_t *s,
  +jk_logger_t *l,
  +int  *is_recoverable_error)
   {
   int i;
   int err;
  @@ -215,10 +271,11 @@
   /*
* Validate the worker (ajp13/ajp14)
*/
  -static int validate(jk_worker_t *pThis,
  -

cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_lb_worker.c

[costin]

costin  01/12/05 12:46:47

  Modified:jk/native2/common jk_lb_worker.c
  Log:
  A bit of cleanup after reorganising the data structures.
  
  There is still one configuration issue, I want to eliminate the duplicated
  creation of workers ( lb can create workers as well ).
  
  Revision  ChangesPath
  1.5   +220 -299  jakarta-tomcat-connectors/jk/native2/common/jk_lb_worker.c
  
  Index: jk_lb_worker.c
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_lb_worker.c,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- jk_lb_worker.c2001/12/04 23:56:07 1.4
  +++ jk_lb_worker.c2001/12/05 20:46:47 1.5
  @@ -60,7 +60,7 @@
*  several workers.   *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
* Based on:   *
  - * Version: $Revision: 1.4 $   *
  + * Version: $Revision: 1.5 $   *
***/
   
   #include "jk_pool.h"
  @@ -72,157 +72,83 @@
   
   #define DEFAULT_LB_FACTOR   (1.0)
   
  -int JK_METHOD lb_worker_factory(jk_worker_t **w,
  -const char *name,
  -jk_logger_t *l);
  -
  -
  -/*
  - * The load balancing code in this 
  - */
  -
  -
  -/* 
  - * Time to wait before retry...
  - */
  +/* Time to wait before retry... */
   #define WAIT_BEFORE_RECOVER (60*1) 
  -#define ADDITINAL_WAIT_LOAD (20)
  -
  -struct worker_record {
  -char*name;
  -double  lb_factor;
  -double  lb_value;
  -int in_error_state;
  -int in_recovering;
  -time_t  error_time;
  -jk_worker_t *w;
  -};
  -typedef struct worker_record worker_record_t;
   
  -struct lb_worker {
  -worker_record_t *lb_workers;
  -unsigned num_of_workers;
  -
  -jk_pool_t p;
  -jk_pool_atom_t buf[TINY_POOL_SIZE];
  +#define ADDITINAL_WAIT_LOAD (20)
   
  -char *name; 
  -jk_worker_t worker;
  -};
  -typedef struct lb_worker lb_worker_t;
  +int JK_METHOD jk_worker_lb_factory(jk_env_t *env,
  +   void **result,
  +   char *type,
  +   char *name);
   
  -struct lb_endpoint {
  -jk_endpoint_t *e;
  -lb_worker_t *worker;
  -
  -jk_endpoint_t endpoint;
  -};
  -typedef struct lb_endpoint lb_endpoint_t;
   
  -static void close_workers(lb_worker_t *p, 
  -  int num_of_workers,
  -  jk_logger_t *l)
  -{
  -int i = 0;
  -for(i = 0 ; i < num_of_workers ; i++) {
  -p->lb_workers[i].w->destroy(&(p->lb_workers[i].w),
  -l);
  -}
  -}
   
  -static double get_max_lb(lb_worker_t *p) 
  +/* Find the biggest lb_value for all my workers.
  + * This + ADDITIONAL_WAIT_LOAD will be set on all the workers
  + * that recover after an error.
  + */
  +static double get_max_lb(jk_worker_t *p) 
   {
  -unsigned i;
  +int i;
   double rc = 0.0;
   
   for(i = 0 ; i < p->num_of_workers ; i++) {
  -if(!p->lb_workers[i].in_error_state) {
  -if(p->lb_workers[i].lb_value > rc) {
  -rc = p->lb_workers[i].lb_value;
  +if(!p->lb_workers[i]->in_error_state) {
  +if(p->lb_workers[i]->lb_value > rc) {
  +rc = p->lb_workers[i]->lb_value;
   }
   }
   }
  -
   return rc;
  -
   }
  -
  -double jk_get_lb_factor(jk_map_t *m, 
  -const char *wname)
  -{
  -char buf[1024];
  -
  -if(!m || !wname) {
  -return DEFAULT_LB_FACTOR;
  -}
   
  -sprintf(buf, "%s.%s.%s", "worker", wname, "lbfactor");
  +/** Find the best worker. In process, check if timeout expired
  +for workers that failed in the past and give them another chance.
   
  -return map_get_double(m, buf, DEFAULT_LB_FACTOR);
  -}
  +This will check the JSESSIONID and forward to the right worker
  +if in a session.
   
  -int jk_get_lb_worker_list(jk_map_t *m, 
  -  const char *lb_wname,
  -  char ***list, 
  -  unsigned *num_of_wokers)
  +It'll also adjust the load balancing factors.
  +*/
  +static jk_worker_t *get_most_suitable_worker(jk_worker_t *p, 
  + jk_ws_service_t *s)
   {
  -char buf[1024];
  -
  -if(m && list && num_of_wokers && lb_wname) {
  -char **ar = NULL;
  -
  -sprintf(buf, "%s.%s.%s", "worker", lb_wname, "balanced_workers");
  -ar = map_get_string_list(m, buf, num_of_wokers, NULL);

cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_handler.h jk_endpoint.h jk_map.h jk_pool.h jk_uriEnv.h jk_uriMap.h jk_worker.h jk_workerEnv.h

[costin]

costin  01/12/05 12:45:13

  Modified:jk/native2/include jk_endpoint.h jk_map.h jk_pool.h
jk_uriEnv.h jk_uriMap.h jk_worker.h jk_workerEnv.h
  Added:   jk/native2/include jk_handler.h
  Log:
  Changed 'unsigned' to normal 'int's - unsingneds are a bit confusing ( for a java
  programmer :-), and the code already had few 'foo>0' or even 'foo=-1' with foo
  unsigned. Please avoid unsigned if possible, for most of our stuff int should be
  enough.
  
  Continued the data structure consolidation. As I mentioned in a previous commit,
  we lose some of the data hiding  (the 'private' fields ), but we gain the ability
  to extract detailed informations about what's going in and to control all
  data structures using callbacks from tomcat.
  
  Long term we need some 'introspection' capabilities, most likely a generic
  getProperty/setProperty ( or getNote/setNote - 3.3 style ) plus getPropertyNames().
  
  Now load balancing properties are visible in the main worker. Of course, most
  of it is quite generic - for example 'realEndpoint' is to be used by any
  worker that is using another worker to do the work. Having lb exposed will
  eventually allow us to finish jni worker in multiprocess mode.
  
  Added prototypes, get rid of most warnings.
  
  Revision  ChangesPath
  1.2   +25 -2 jakarta-tomcat-connectors/jk/native2/include/jk_endpoint.h
  
  Index: jk_endpoint.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_endpoint.h,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- jk_endpoint.h 2001/12/04 18:29:11 1.1
  +++ jk_endpoint.h 2001/12/05 20:45:13 1.2
  @@ -1,4 +1,3 @@
  -/* -*- Mode: C; tab-width: 4; c-basic-offset: 4; indent-tabs-mode: nil-*- */
   /* = *
*   *
* The Apache Software License,  Version 1.1 *
  @@ -62,7 +61,7 @@
* Author:  Gal Shachor <[EMAIL PROTECTED]>   
* Author:  Dan Milstein <[EMAIL PROTECTED]>
* Author:  Henri Gomez <[EMAIL PROTECTED]>   
  - * Version: $Revision: 1.1 $  
  + * Version: $Revision: 1.2 $  
***/
   
   #ifndef JK_ENDPOINT_H
  @@ -135,7 +134,7 @@
   
   int sd;
   int reuse;
  -unsigned left_bytes_to_send;
  +int left_bytes_to_send;
   
   /* Buffers for req/res */
   /* Used to be ajp_operation */
  @@ -145,7 +144,13 @@
   int uploadfd;   /* future persistant storage id */
   int recoverable;/* if exchange could be conducted on another TC */
   
  +/* For redirecting endpoints like lb */
  +jk_endpoint_t *realEndpoint;
   
  +/* int (JK_METHOD *sendRequest)(jk_endpoint_t *e,  */
  +/*  struct jk_ws_service *s, */
  +/*  jk_logger_t *l ); */
  +
   /*
* Forward a request to the servlet engine.  The request is described
* by the jk_ws_service_t object.  I'm not sure exactly how
  @@ -188,6 +193,24 @@
   int ajp_connection_tcp_get_message(jk_endpoint_t *ae,
  jk_msg_buf_t   *msg,
  jk_logger_t*l);
  +
  +
  +int ajp_send_request(jk_endpoint_t *e,
  + struct jk_ws_service *s,
  + jk_logger_t *l);
  +
  +int ajp_get_reply(jk_endpoint_t *e,
  +  struct jk_ws_service *s,
  +  jk_logger_t *l);
  +
  +void ajp_reset_endpoint(jk_endpoint_t *ae);
  +
  +int ajp_read_into_msg_buff(jk_endpoint_t  *ae,
  +   struct jk_ws_service *r,
  +   jk_msg_buf_t*msg,
  +   intlen,
  +   jk_logger_t *l);
  +
   
   
   #ifdef __cplusplus
  
  
  
  1.2   +17 -2 jakarta-tomcat-connectors/jk/native2/include/jk_map.h
  
  Index: jk_map.h
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_map.h,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- jk_map.h  2001/12/01 22:30:57 1.1
  +++ jk_map.h  2001/12/05 20:45:13 1.2
  @@ -58,7 +58,7 @@
   /***
* Description: Map object header file *
* Author:  Gal Shachor <[EMAIL PROTECTED]>   *
  - * Version: $Revision: 1.1

Re: Emulating JServ's session.topleveldomain with Catalina

[Daniel Rall]

"Craig R. McClanahan" <[EMAIL PROTECTED]> writes:

> I'd certainly be interested in a patch to allow pattern matching in the
> host mapper, as long as the code was smart about using direct string
> compares when no patterns are specified (to avoid slowing down all
> requests by regexp processing).
>
> Note that Tomcat already loads jakarta-regexp for use in the
> RemoteAddrValve and RemoteHostValve filters.  If you need regexp patterns,
> that would be a convenient choice because no additional dependencies would
> be created.

Hi Craig.  Did you have a chance to look over my initial rev of the
patch to add pattern matching to the host mapper?  Is the Alias change
acceptable?  (Sorry if you already responded -- I've been off-line.
My ATT@Home service was temporarily down after Excite declared chapter
11.)

If so, would you comment on how to get the Digester/Modeler to
properly configure an Alias object?  I could use some guidance with
that.

If not, how would you suggest I proceed to make such a patch
acceptable (i.e. what other constraints should I take into account)?


 Thanks, Dan

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: getPathInfo problem

[Bill Barker]

A JSP page (that is using the default "*.jsp" mapping) can't have PathInfo
(section 10.1 of the 2.2 spec, or 11.1 of the 2.3 spec).  If PathInfo ==
null, then IMHO, then Tomcat "cannot determine a valid file path", and so
must return null from getPathTranslated (section 5.5, resp section 4.5).
ServletContext.getRealPath("/") should give the file-system path to the
context (although it will also return null under 4.x if you are using war
files of course).

Of course, if the JSP page is defined in the web.xml as a prefix-mapped
servlet, then getPathTranslated and getPathInfo should work as expected.
- Original Message -
From: "Anand Bashyam Narasimham" <[EMAIL PROTECTED]>
To: "Tomcat Dev Mailing List (E-mail)" <[EMAIL PROTECTED]>
Sent: Wednesday, December 05, 2001 11:32 AM
Subject: getPathInfo problem


> Hi,
>
> I know there's been a lot of discussion around this and the bug filed says
> it's a "WORKSFORME" but somehow if I just install TOmcat3.3 and run the
> Snoop JSP in the example I get a "null" on getPathInfo as well as
> getPathTranslated(). Is there something that needs to be set on the
servlet
> mapping etc.
>
> If some on can give a concrete answer as to why this is so much a problem
it
> would be of great help. I tried a JSP with calls to getPathInfo() and
> getPathTranslated() on WebLogic 5.1 and the getPathTranslated works fine
but
> returns null in Tomcat.
>
> Anand
>
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


**

This message is intended only for the use of the person(s) listed above 
as the intended recipient(s), and may contain information that is 
PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, 
you may not read, copy, or distribute this message or any attachment.  
If you received this communication in error, please notify us immediately 
by e-mail and then delete all copies of this message and any attachments.


In addition you should be aware that ordinary (unencrypted) e-mail sent 
through the Internet is not secure. Do not send confidential or sensitive 
information, such as social security numbers, account numbers, personal 
identification numbers and passwords, to us via ordinary (unencrypted) 
e-mail. 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: getPathInfo problem

[Craig R. McClanahan]

On Wed, 5 Dec 2001, Anand Bashyam Narasimham wrote:

> Date: Wed, 5 Dec 2001 11:32:08 -0800
> From: Anand Bashyam Narasimham <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: "Tomcat Dev Mailing List (E-mail)" <[EMAIL PROTECTED]>
> Subject: getPathInfo problem
>
> Hi,
>
> I know there's been a lot of discussion around this and the bug filed says
> it's a "WORKSFORME" but somehow if I just install TOmcat3.3 and run the
> Snoop JSP in the example I get a "null" on getPathInfo as well as
> getPathTranslated(). Is there something that needs to be set on the servlet
> mapping etc.
>
> If some on can give a concrete answer as to why this is so much a problem it
> would be of great help. I tried a JSP with calls to getPathInfo() and
> getPathTranslated() on WebLogic 5.1 and the getPathTranslated works fine but
> returns null in Tomcat.
>
> Anand
>

As I asked for (twice!) in the bug report dialog, can you please provide a
test case that shows exactly what you think is wrong?  The original
statement in the bug report was not correct, and you have not provided the
detail of exactly what behavior you are seeing, and what you are
expecting.

Without that, there's nothing anyone here can do.

Craig McClanahan


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

getPathInfo problem

[Anand Bashyam Narasimham]

Hi,

I know there's been a lot of discussion around this and the bug filed says
it's a "WORKSFORME" but somehow if I just install TOmcat3.3 and run the
Snoop JSP in the example I get a "null" on getPathInfo as well as
getPathTranslated(). Is there something that needs to be set on the servlet
mapping etc.

If some on can give a concrete answer as to why this is so much a problem it
would be of great help. I tried a JSP with calls to getPathInfo() and
getPathTranslated() on WebLogic 5.1 and the getPathTranslated works fine but
returns null in Tomcat.

Anand



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5288] - org.apache.naming.resources.Resource should be an interface

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5288

org.apache.naming.resources.Resource should be an interface





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 11:15 ---
More documentation on the Resource class would also be helpful.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5288] New: - org.apache.naming.resources.Resource should be an interface

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5288

org.apache.naming.resources.Resource should be an interface

   Summary: org.apache.naming.resources.Resource should be an
interface
   Product: Tomcat 4
   Version: Unknown
  Platform: All
OS/Version: All
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Resource is required to let DefaultServlet serve web pages from a JNDI
DirContext. Currently, if the DirContext does not contain Resource objects, a
wrapper must be used to bridge the two interfaces. It would be easier if the
objects in the JNDI DirContext could immediately implement the correct
interface, so no wrapper/bridge is requird.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime BodyContentImpl.java JspRuntimeLibrary.java JspWriterImpl.java PageContextImpl.java

[kinman]

kinman  01/12/05 10:41:47

  Modified:jasper/src/share/org/apache/jasper Tag: tomcat_40_branch
Constants.java
   jasper/src/share/org/apache/jasper/compiler Tag:
tomcat_40_branch IncludeGenerator.java
   jasper/src/share/org/apache/jasper/runtime Tag:
tomcat_40_branch BodyContentImpl.java
JspRuntimeLibrary.java JspWriterImpl.java
PageContextImpl.java
  Log:
  -- Back-ported fixes from the head branch.
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.13.2.1  +1 -0  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/Constants.java
  
  Index: Constants.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/Constants.java,v
  retrieving revision 1.13
  retrieving revision 1.13.2.1
  diff -u -r1.13 -r1.13.2.1
  --- Constants.java2001/07/23 19:57:32 1.13
  +++ Constants.java2001/12/05 18:41:46 1.13.2.1
  @@ -149,6 +149,7 @@
   public static final String INC_REQUEST_URI = 
"javax.servlet.include.request_uri";
   public static final String INC_SERVLET_PATH = 
"javax.servlet.include.servlet_path";
   public static final String TMP_DIR = "javax.servlet.context.tempdir";
  +public static final String FORWARD_SEEN = "javax.servlet.forward.seen";
   
   /**
* Public Id and the Resource path (of the cached copy) 
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.8.2.1   +10 -3 
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java
  
  Index: IncludeGenerator.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
  retrieving revision 1.8
  retrieving revision 1.8.2.1
  diff -u -r1.8 -r1.8.2.1
  --- IncludeGenerator.java 2001/08/14 23:28:55 1.8
  +++ IncludeGenerator.java 2001/12/05 18:41:46 1.8.2.1
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
 1.8 2001/08/14 23:28:55 craigmcc Exp $
  - * $Revision: 1.8 $
  - * $Date: 2001/08/14 23:28:55 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/compiler/IncludeGenerator.java,v
 1.8.2.1 2001/12/05 18:41:46 kinman Exp $
  + * $Revision: 1.8.2.1 $
  + * $Date: 2001/12/05 18:41:46 $
*
* 
* 
  @@ -186,6 +186,13 @@
   writer.println("JspRuntimeLibrary.include(request, response, " +
  JspUtil.getExpr(page, isXml) + " + _jspx_qStr, " +
  "out, " + flush + ");");
  +
  +// If there is a forward in the include chain, quit.
  +writer.println("if (\"true\".equals(request.getAttribute(\"" +
  +Constants.FORWARD_SEEN + "\")))");
  +writer.pushIndent();
  +writer.println("return;");
  + writer.popIndent();
   
writer.popIndent();
writer.println("}");
  
  
  
  No   revision
  
  
  No   revision
  
  
  1.2.2.1   +12 -12
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/BodyContentImpl.java
  
  Index: BodyContentImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/runtime/BodyContentImpl.java,v
  retrieving revision 1.2
  retrieving revision 1.2.2.1
  diff -u -r1.2 -r1.2.2.1
  --- BodyContentImpl.java  2001/03/12 22:17:33 1.2
  +++ BodyContentImpl.java  2001/12/05 18:41:46 1.2.2.1
  @@ -82,19 +82,25 @@
   protected int bufferSize = Constants.DEFAULT_BUFFER_SIZE;
   private int nextChar;
   static String lineSeparator = System.getProperty("line.separator");
  +private boolean closed = false;
   
  -
   public BodyContentImpl (JspWriter writer) {
   super(writer);
cb = new char[bufferSize];
nextChar = 0;
   }
   
  +private void ensureOpen() throws IOException {
  + if (closed)
  + throw new IOException("Stream closed");
  +}
  +
   /**
* Write a single character.
*
*/
   public void write(int c) throws IOException {
  + ensureOpen();
   synchronized (lock) {
   if (nextChar >= bufferSize) {
reAllocBuff (0);
  @@ -141,6 +147,7 @@
   public void write(char cbuf[], int off, int len) 
   throws IOException 
   {
  + ensureOpen();
   synchronized (lock) {
   
   if ((off < 0) || (off > cbuf.length) || (len < 0) ||
  @@ -175,6 +182,7 @@
*
  

DO NOT REPLY [Bug 5277] - JDBC Realms crashs with empty password on Oracle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5277

JDBC Realms crashs with empty password on Oracle





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 10:47 ---
I will try to look at this shortly, at least try to not crash withtout a log 
message :), later we can build a suitable fix..

Thanks for the report, i wil confirm it here if i can..althought i'm using 
Oracle 8.1.7 in my tests box, perhaps this can make a difference,..

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: mod_webapp and apache 2.0

[Justin Erenkrantz]

On Wed, Dec 05, 2001 at 09:34:55AM -0800, Charles Yates wrote:
>After getting errors from "apachectl configtest" relating
> to invalid port I added a Port directive to httpd.conf and got
> an error that Port directive had been replaced by Listen.  I then
> removed my Port directive, hacked on webapp.c and wa_config.c
> to hard code server Port references and . . . . Yay, it works!

I think the webapp code in the j-t-c CVS repository is updated.
If not, then please post what you did and we can try and sort
out the "right" fix.  -- justin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5061] - Improper flush in JspRuntimeLibrary.java

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5061>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5061

Improper flush in JspRuntimeLibrary.java

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 10:29 ---
Fixed in 20011205 nightly build.  Thanks [EMAIL PROTECTED] for the patch

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 4609] - IOException is not thrown if JspWriter object is closed and an attempt to write to the object is made.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4609>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4609

IOException is not thrown if JspWriter object is closed and an attempt to write to the 
object is made.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 10:27 ---
Fixed in 20011205 nightly build.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 4542] - jsp:include inside a custom tag can throw an exception.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4542>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4542

jsp:include inside a custom tag can throw an exception.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 10:26 ---
Fixed in 20011205 nightly build.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

DO NOT REPLY [Bug 5277] - JDBC Realms crashs with empty password on Oracle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5277

JDBC Realms crashs with empty password on Oracle





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 10:05 ---
Anyway it should not crash without any comment. It's not a bug of the
Oracle-Driver. Oracle introduced this behaviour as a feature in Oracle 7. This
is really stupid but I don't have a choice.

Somewhere in the ORACLE7 documentation it states:
"ORACLE7 currently treats a character value with a length of zero as null.
However, this may not continue to be true in future versions of ORACLE7".

I use Oracle 8i 8.6.1 and the problem is still there

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5277] - JDBC Realms crashs with empty password on Oracle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5277

JDBC Realms crashs with empty password on Oracle





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 09:56 ---
Given the description, it sounds a lot more like a bug with the Oracle driver. 
What so we suggest we do ?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

mod_webapp and apache 2.0

[Charles Yates]

After getting errors from "apachectl configtest" relating
to invalid port I added a Port directive to httpd.conf and got
an error that Port directive had been replaced by Listen.  I then
removed my Port directive, hacked on webapp.c and wa_config.c
to hard code server Port references and . . . . Yay, it works!
Am I having problems because I built the thing wrong?
(RedHat 7.1, i686)

Charles



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Superb OSS Java IDE

[Nick Betteridge]

Ever tried Netbeans? http://www.netbeans.org

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Superb OSS Java IDE

[Steve Jones]

On Wed, 2001-12-05 at 11:05, GOMEZ Henri wrote:
> >on 12/4/01 8:23 AM, "GOMEZ Henri" <[EMAIL PROTECTED]> wrote:
> >
> >> www.eclipse.org
> >> 
> >> OSS version of VisualAge for Java, by the
> >> team who does VA Java :)
> >> 
> >> Excellent 
> >
> >Cool news. However, it isn't truly superb until it runs on OSX.
> >
> >:-)
> 
> Some lobbying to be conducted ;)
> 
> Important point, this IDE support CVS as repository .
> Trully tailored for java OSS projects.

It is wonderful... but the CVS integration puts everything in as binary
right now :-( (also looks very old on Linux)
> 
> NB: It's the Visual Age for Java team who do Eclipse


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5261] - Directory Listing in Tomcat 3.2.4

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5261

Directory Listing in Tomcat 3.2.4





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 08:38 ---
I might try with Linux and apache. That's what I'm using.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5285] New: - JSP File Not Found

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5285

JSP File Not Found

   Summary: JSP File Not Found
   Product: Tomcat 4
   Version: 4.0 Final
  Platform: PC
OS/Version: Other
Status: NEW
  Severity: Blocker
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Tomcat is not able to find a jsp when it exists.  The jsp that it is not able 
to find is included in another jsp.  Here is the stack trace:

2001-12-05 10:04:58 ApplicationDispatcher[/yourelate] Servlet.service() for 
servlet jsp threw exception
org.apache.jasper.compiler.CompileException: d:\projects\yc45
\website\webtop\jsp\ep_list.jsp(57,0) d:\projects\yc45
\website\webtop\jsp\list_header.jsp(9,4) File "page_number_header.jsp" not found
at org.apache.jasper.compiler.JspParseEventListener.handleDirective
(JspParseEventListener.java:783)
at org.apache.jasper.compiler.DelegatingListener.handleDirective
(DelegatingListener.java:121)
at org.apache.jasper.compiler.Parser$Directive.accept(Parser.java:243)
at org.apache.jasper.compiler.Parser.parse(Parser.java:1126)
at org.apache.jasper.compiler.Parser.parse(Parser.java:1091)
at org.apache.jasper.compiler.Parser.parse(Parser.java:1087)
at org.apache.jasper.compiler.ParserController.parse
(ParserController.java:220)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:207)
at org.apache.jasper.servlet.JspServlet.loadJSP(JspServlet.java:523)
at 
org.apache.jasper.servlet.JspServlet$JspServletWrapper.loadIfNecessary
(JspServlet.java:175)
at org.apache.jasper.servlet.JspServlet$JspServletWrapper.service
(JspServlet.java:187)
at org.apache.jasper.servlet.JspServlet.serviceJspFile
(JspServlet.java:379)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:453)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at org.apache.catalina.core.ApplicationDispatcher.invoke
(ApplicationDispatcher.java:679)
at org.apache.catalina.core.ApplicationDispatcher.doForward
(ApplicationDispatcher.java:431)
at org.apache.catalina.core.ApplicationDispatcher.forward
(ApplicationDispatcher.java:355)
at com.youcentric.webtop.WebRequestContext.deferControl
(D:/projects/yc45/src/com/youcentric/webtop/WebRequestContext.java:937)
at com.youcentric.webtop.view.AbstractView.renderJsp
(D:/projects/yc45/src/com/youcentric/webtop/view/AbstractView.java:90)
at com.youcentric.webtop.view.EPView.handleListView
(D:/projects/yc45/src/com/youcentric/webtop/view/EPView.java:163)
at com.youcentric.webtop.view.EPView.present
(D:/projects/yc45/src/com/youcentric/webtop/view/EPView.java:79)
at com.youcentric.mvc.ViewManager.present
(D:/projects/yc45/src/com/youcentric/mvc/ViewManager.java:247)
at 
com.youcentric.webtop.controller.NavigationController$selectEP.actionPerformed
(D:/projects/yc45/src/com/youcentric/webtop/controller/NavigationController.java
:569)
at com.youcentric.mvc.AbstractRequestContext.fireAction
(D:/projects/yc45/src/com/youcentric/mvc/AbstractRequestContext.java:416)
at com.youcentric.webtop.WebRequestContext.fireAction
(D:/projects/yc45/src/com/youcentric/webtop/WebRequestContext.java:1401)
at com.youcentric.webtop.ActionServlet.completeRequest
(D:/projects/yc45/src/com/youcentric/webtop/ActionServlet.java:191)
at com.youcentric.webtop.AbstractServlet.processRequest
(D:/projects/yc45/src/com/youcentric/webtop/AbstractServlet.java:456)
at com.youcentric.webtop.AbstractServlet.doGet
(D:/projects/yc45/src/com/youcentric/webtop/AbstractServlet.java:542)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:740)
at com.youcentric.webtop.AbstractServlet.service
(D:/projects/yc45/src/com/youcentric/webtop/AbstractServlet.java:596)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at com.youcentric.webtop.AbstractServlet.service
(D:/projects/yc45/src/com/youcentric/webtop/AbstractServlet.java:616)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
(ApplicationFilterChain.java:247)
at org.apache.catalina.core.ApplicationFilterChain.doFilter
(ApplicationFilterChain.java:193)
at org.apache.catalina.core.StandardWrapperValve.invoke
(StandardWrapperValve.java:243)
at org.apache.catalina.core.StandardPipeline.invokeNext
(StandardPipeline.java:566)
at org.apache.catalina.core.StandardPipeline.invoke
(StandardPipeline.java:472)
at org.apache.catalina.core.ContainerBase.invoke(Containe

DO NOT REPLY [Bug 5261] - Directory Listing in Tomcat 3.2.4

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5261

Directory Listing in Tomcat 3.2.4





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 08:07 ---
Which version of Apache are you using?  With Apache 1.3.20, I get

Forbidden
You don't have permission to access /?.jsp on this server

I'm using Tomcat 3.2.4 and the mod_jk.dll from that release.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5261] - Directory Listing in Tomcat 3.2.4

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5261

Directory Listing in Tomcat 3.2.4





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 07:47 ---
The configuration I'm using is with apache and mod_jk ( ajp13 ).

Mapping:
JkMount /*.jsp ajp13

Thanks for the help.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5265] - With JDBCRealm: cant add new user online to my authentification database, the new user will not work until I restart the server.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5265

With JDBCRealm: cant add new user online to my authentification database, the new user 
will not work until I restart the server.





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 05:56 ---
For your information, I use InstantDB database. I've check in the log and I see
this :

2001-12-05 08:38:28 - JDBCRealm: Authentification rÚussie pour l'utilisateur
christian
2001-12-05 08:38:28 - JDBCRealm: Auth ok, user=christian

but my code that was working in 3.2.3 do not work in 3.3. Even if authentication
is successfull, none users are authorized after authentication.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: [PATCH] about kjc

[Takashi Okamoto]

At Sun, 2 Dec 2001 15:19:05 -0800 (PST),
Craig R. McClanahan <[EMAIL PROTECTED]> wrote:
> I looked at this option a little bit a while back, and have only one
> concern -- multiple threads trying to compile at the same time.  Ant tasks
> generally assume that they don't need to worry about thread safety issues,
> so we need to review this code carefully. (Of course, this issue applies
> even more so to the "new" Javac entry point in 1.4 -- it writes error
> messages to System.out).

Well, I refered org.apache.tools.ant.taskdefs.compilers.Javac13.java

Class c = Class.forName ("com.sun.tools.javac.Main");
Object compiler = c.newInstance ();
Method compile = c.getMethod ("compile",
new Class [] {(new String [] {}).getClass ()});
int result = ((Integer) compile.invoke
  (compiler, new Object[] {cmd.getArguments()})) .intVal
ue ();

So, above code shows that compiler output messages to System.out. Some
of other compilers are same as Jikes13.java. They are thread-unsafe.
They should be locked.

Takashi Okamoto

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: JK versions status and web pages ?

[jean-frederic clere]

GOMEZ Henri wrote:
> 
> What's the final status of versioning ?
> 
> - jtc/jk/native mod_jk 1.2
> - jtc/jk/native2mod_jk 2.0
> 
> So we could make soon a release of mod_jk 1.2.
> 
> BTW: I need guidelines to create the JTC, at least jk webpages.
> 
>  - Did we have to choose anakia / buildsite ?

Anakia so that it looks like the rest of jakarta.apache.org.

>  - what will be the URL ? (http://jakarta.apache.org/jtc/) ?

http://jakarta.apache.org/tomcat/connectors/?

>where will it be put on jakarta.apache.org ?

Add a link in http://jakarta.apache.org/tomcat/index.html

> 
> I plan to move some of the current Tomcat 3.3 documents,
> ie mod_jk, IIS, part of SSL to this page.

I would also put there the mod_webapp existing documents.

> 
> -
> Henri Gomez ___[_]
> EMAIL : [EMAIL PROTECTED](. .)
> PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
> PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6
> 
> >-Original Message-
> >From: GOMEZ Henri [mailto:[EMAIL PROTECTED]]
> >Sent: Tuesday, December 04, 2001 10:12 AM
> >To: Tomcat Developers List
> >Subject: RE: JK versions
> >
> >
> >>After reading the commit log - most changes related to jk_channel,
> >>jk_registry, etc are pretty safe ( as they don't change any logic ).
> >>
> >>We could actually release Jk1.2 using the main tree - if everyone is
> >>comfortable with that. If not - Oct21 is probably a good point
> >>to branch
> >>( the release date for 3.3 ).
> >>
> >>There are few fixes for ebcdic support and few small things that would
> >>have to be re-applied.
> >
> >Let's get the old version, and then I'll reapply the EBCDIC changes.
> >We should keep ajp12 is JK 1.2 :)
> >
> >--
> >To unsubscribe, e-mail:
> >
> >For additional commands, e-mail:
> >
> >
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.1.txt

[larryi]

larryi  01/12/05 03:29:50

  Modified:.RELEASE-NOTES-3.3.1.txt
  Log:
  Document recent updates
  
  Revision  ChangesPath
  1.10  +15 -3 jakarta-tomcat/RELEASE-NOTES-3.3.1.txt
  
  Index: RELEASE-NOTES-3.3.1.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.1.txt,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- RELEASE-NOTES-3.3.1.txt   2001/12/04 02:27:17 1.9
  +++ RELEASE-NOTES-3.3.1.txt   2001/12/05 11:29:50 1.10
  @@ -3,7 +3,7 @@
Release Notes
=
   
  -$Id: RELEASE-NOTES-3.3.1.txt,v 1.9 2001/12/04 02:27:17 larryi Exp $
  +$Id: RELEASE-NOTES-3.3.1.txt,v 1.10 2001/12/05 11:29:50 larryi Exp $
   
   
   This document describes the changes that have been made since the
  @@ -41,7 +41,17 @@
 Moved the setting of the default "*.jsp" mapping so that it is now 
 possible to entirely disable support for jsp files.
   
  + Context properties and ContextManager properties can now be set with
  +  elements, i.e: 
  + 
  + For backwards compatibility, the ContextManager "lower-case-p"
  +  version supported by Tomcat 3.3. is still supported.
  +
  + Added variable substitution handling to ContextXmlReader, allowing
  + variable substitution to be used in 
  + declarations.
   
  +
   Server:
   
   Bug No.  Description
  @@ -105,12 +115,14 @@
Tomcat-on-NetWare-HowTo.html updated to fix errors related to new
functionality in Tomcat 3.3.
   
  - tomcat-ug.html updated with additional classloader information.
  + tomcat-ug.html updated with additional classloader information and
  + details on the variable substitution available in Context
  + declarations.

serverxml.html updated to document new checkSSLSessionId attribute on
SessionId module.  A note was added to Ajp12Connector to document the
requirement for maxThreads to be 2 or more if it is to be used to
  - shutdown Tomcat.
  + shutdown Tomcat.  Section on variable substitution was updated.
   
tomcat-iis-howto.html updated to make it clearer that the "Filter Dlls"
key is used only on Win98.
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/doc tomcat-ug.html

[larryi]

larryi  01/12/05 03:29:30

  Modified:src/doc  tomcat-ug.html
  Log:
  Document the variable substitution now available in Context definitions,
  plus other updates.
  
  Revision  ChangesPath
  1.22  +36 -4 jakarta-tomcat/src/doc/tomcat-ug.html
  
  Index: tomcat-ug.html
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/doc/tomcat-ug.html,v
  retrieving revision 1.21
  retrieving revision 1.22
  diff -u -r1.21 -r1.22
  --- tomcat-ug.html2001/11/07 13:46:02 1.21
  +++ tomcat-ug.html2001/12/05 11:29:30 1.22
  @@ -1,7 +1,7 @@
   
   
   
  -
  +
   
   
   
  @@ -1199,13 +1199,13 @@
   
   Tomcat Server.xml Customization
   
  -The following are some of the more common customization made to the
  +The following are some of the more common customizations made to the
   server.xml file.
   
   
   Change ports for Http, Https, and Web Server 
connectors
   Speed up initial session creation for 
development
  -Configure whether Tomcat or a web server does 
authentication\
  +Configure whether Tomcat or a web server does 
authentication
   Turn off directory listings>
   Use Jikes as the Java compiler
   Bind a connector to a single IP address
  @@ -1510,9 +1510,41 @@
 Context declarations.none, must be 
specified
   
   
  +In Tomcat 3.3.1, each attribute value may use the ant-style variable
  +substitution by using "${variable}" in the attribute string, i.e.
  +attribute="text${variable}text".
  +
  +The variable must specify a Context property, a ContextManager
  +property, or System property.  The Context properties take precedence, followed
  +by ContextManager propertiers, and finally System properties.  If a matching
  +property isn't found the attribute string is left as is.  Note that properties
  +are not the same as attributes, and attributes are not accessible via
  +"variable substitution".
  +
  +There are two methods for setting Context 
properties.
  +
  +
  +  Include a name="value"
  +specification on the Context element, where name doesn't correspond
  +to a Context attribute. For example:
  +
  +  Include a Property element within the scope of the
  +Context element. For example:
  +
  +
  +
  +...
  +
  +This form of setting properties is logged if the Context's debug
  +level is one or greater.
  +
  +
  +Note: The property values may themselves use "variable
  +substitution", provided the specified property is already defined.
  +
   Currently the SimpleRealm,
   JDBCRealm, and
  -Logsetter modules are know to work
  +Logsetter modules are known to work
   successfully as "context local" modules.  Other modules that can
   be used as "context local" modules and would be useful have yet to
   be identified.
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat/src/doc serverxml.html

[larryi]

larryi  01/12/05 03:28:49

  Modified:src/doc  serverxml.html
  Log:
  Document feature updates to ServerXmlReader, ContextXmlReader, and
  LoaderInterceptor11, plus other miscellaneous updates.
  
  Revision  ChangesPath
  1.12  +89 -27jakarta-tomcat/src/doc/serverxml.html
  
  Index: serverxml.html
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/doc/serverxml.html,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- serverxml.html2001/11/08 21:43:24 1.11
  +++ serverxml.html2001/12/05 11:28:49 1.12
  @@ -4,7 +4,7 @@
   
   
   
  -  
  +  
 
 
 
  @@ -40,14 +40,50 @@
   will be read after server.xml, allowing local configurations.
   
   
  -Variable substitution
  +Variable substitution
   
  -Each attribute value may use the ant-style variable substitution ( ${variable}
  -). The values are stored as ContextManager properties, and defined using
  -either , as attributes 
in the
  - element, or in the command line using "-foo bar" 
  -syntax, or as system properties.
  +In Tomcat 3.3.1, each attribute value may use the ant-style variable
  +substitution by using "${variable}" in the attribute string, i.e.
  +attribute="text${variable}text". (Note: A
  +bug prevented this from working in Tomcat 3.3.)
  +
  +The variable must specify a ContextManager property or System property,
  +with ContextManager properties taking precedence.  If a matching property
  +isn't found, the attribute string is left as is.  Note that the properties are
  +not the same as attributes, and attributes are not accessible via variable
  +substitution.
  +
  +There are two predefined ContextManager properties,
  +"tomcat.home" and "tomcat.install".
  +These correspond to the ContextManager home and installDir
  +attributes, respectively. There are three methdos for setting additional
  +ContextManager properties.
  +
  +
  +  Include a name="value"
  +specification on the ContextManager element in server.xml,
  +where name doesn't correspond to a ContextManager attribute. For
  +example:
  +
  +  Include a Property element within the scope of the
  +ContextManager element in server.xml. For example:
  +
  +
  +
  +...
  +
  +This form of setting properties is logged if the ContextManager's debug
  +level is one or greater.
  +  Include "-name value" as command line
  +arguments, where name doesn't match any of the arguments supported
  +by the "start" task.
  +For example:
  +bin/startup.sh -my.prop myvalue
  +
   
  +Note: The property values may themselves use "variable
  +substitution", provided the specified property is already defined.
  +
   Common Parameters
   
   All modules have the following common attributes:
  @@ -133,7 +169,7 @@
   Default
 
 
  -install
  +installDir
   Base directory for tomcat installation. It is typically guessed by the 
 startup program, but you can override it here.
   TOMCAT_HOME or one level above the location of the startup script or 
  @@ -830,8 +866,13 @@
   the default context settings.
   
   For details on the syntax of the context configuration file, refer to the
  -Customizing Contexts section
  -of the Tomcat 3.3 Users Guide.
  +Adding and Customizing Contexts
  +section of the Tomcat 3.3 Users Guide.
  +
  +Note: In Tomcat 3.3.1, ant-style variable substitution is supported
  +in the XML files. Details are included in the "Adding and Customizing 
Contexts"
  +section mentioned above.
  +
   Attributes
   
   
  @@ -1404,23 +1445,18 @@
   
   Description
   
  -Generate configuration file for mod_jk to be included in Apache's httpd.conf.
  +Generate configuration file for mod_jserv to be included in Apache's 
httpd.conf.
   
  -For additional information on connecting Tomcat to Apache via mod_jk, see the
  -Working with mod_jk document.
  +For additional information on connecting Tomcat to Apache via mod_jserv, see the
  +Tomcat Apache HowTo document.
   
  -Important Note: The configuration files are not written as part of a
  -normal startup of Tomcat.  To generate the configuration files on demand,
  -append:
  -jkconf
  -or
  --jkconf
  -to the startup command.  Tomcat will initialize sufficiently to write the
  -configuration files and then exit. This may be done while Tomcat 3.3 is running.
  -To generate the configuration files during normal startup, add:
  -jkconf="true"
  -to the  element in the
  -server.xml file.
  +Important Note: The most stable and robust connector for connecting
  +Tomcat 3.3 to Apache is mod_jk.  Its use is recommended over mod_jserv.
  +Also, unlike the ApacheConfig,
  +IISConfig, and
  +N

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/config LoaderInterceptor11.java

[larryi]

larryi  01/12/05 03:26:57

  Modified:src/share/org/apache/tomcat/modules/config
LoaderInterceptor11.java
  Log:
  Updates so jaxpJars can include absolute paths.
  
  Added a "jarSeparator" attribute to allow changing the separator from
  the default ':' so Windows absolute paths can be used.
  
  Implemented "additionalJars" attribute and support for an additionalJars
  context property to add a list of jars to the web application classloader.
  This avoids trying to use jaxpJars to perform this feature..
  
  Revision  ChangesPath
  1.23  +75 -10
jakarta-tomcat/src/share/org/apache/tomcat/modules/config/LoaderInterceptor11.java
  
  Index: LoaderInterceptor11.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/modules/config/LoaderInterceptor11.java,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- LoaderInterceptor11.java  2001/10/09 17:42:27 1.22
  +++ LoaderInterceptor11.java  2001/12/05 11:26:57 1.23
  @@ -89,8 +89,12 @@
   private int attributeInfo;
   String loader=null;
   Vector jaxpJars=new Vector();
  -String jaxpJarsS="jaxp.jar:crimson.jar:xalan.jar:xerces.jar";
  +String jaxpJarsSDefault="jaxp.jar:crimson.jar:xalan.jar:xerces.jar";
  +String jaxpJarsS=null;
   String jaxpDir=null;
  +Vector additionalJars=new Vector();
  +String additionalJarsS=null;
  +String jarSeparator=":";
   
   public LoaderInterceptor11() {
   }
  @@ -125,6 +129,31 @@
jaxpJarsS=jars;
   }
   
  +/** List of additional jars to add to each web application.
  + */
  +public void setAdditionalJars(String jars ) {
  + additionalJarsS=jars;
  +}
  +
  +/** Character to use to separate jars in the jaxpJars list.
  +It also applies to the additionalJars context property
  +list.
  + */
  +public void setJarSeparator(String sep) {
  +if( sep != null && sep.length() > 0 ) {
  +if( sep.length() > 1 )
  +sep = sep.substring(0,1);
  +
  +char oldSep[]=new char[1];
  +char newSep[]=new char[1];
  +jarSeparator.getChars(0,1,oldSep,0 );
  +sep.getChars(0,1,newSep,0);
  +jaxpJarsSDefault=jaxpJarsSDefault.replace(oldSep[0],newSep[0]);
  +
  +jarSeparator=sep;
  +}
  +}
  +
   /** Check if the webapp contains jaxp , and add one if not.
This allow apps to include their own parser if they want,
while using the normal delegation model.
  @@ -146,6 +175,7 @@
attributeInfo=cm.getNoteId(ContextManager.REQUEST_NOTE,
   "req.attribute");
initJaxpJars();
  +initAdditionalJars();
   }
   
   
  @@ -228,11 +258,30 @@
*  
*/
   public void prepareClassLoader(Context context) throws TomcatException {
  +String list = context.getProperty("additionalJars");
  +if( list != null ) {
  +Vector urls=new Vector();
  +getUrls( null, list, urls );
  +Enumeration en=urls.elements();
  +while( en.hasMoreElements() ) {
  +URL url=(URL)en.nextElement();
  +if( debug > 0 ) log(context + " adding: " + url);
  +context.addClassPath( url );
  +}
  +}
  +
  +Enumeration en=additionalJars.elements();
  +while( en.hasMoreElements() ) {
  +URL url=(URL)en.nextElement();
  +if( debug > 0 ) log(context + " adding: " + url);
  +context.addClassPath( url );
  +}
  +
ClassLoader loader=constructLoader( context );
if( addJaxp ) {
boolean hasJaxp=checkJaxp( loader, context );
if( ! hasJaxp ) {
  - Enumeration en=jaxpJars.elements();
  + en=jaxpJars.elements();
while( en.hasMoreElements() ) {
URL url=(URL)en.nextElement();
if( debug > 0 ) log(context + " adding jaxp: " + url);
  @@ -241,6 +290,7 @@
loader=constructLoader( context );
}
}
  +
if( debug>5 ) {
URL classP[]=context.getClassPath();
log("  Context classpath URLs:");
  @@ -267,7 +317,7 @@
if( debug > 0 ) log( "Using no parent loader ");
parent=null;
} else if( useAppsL && !context.isTrusted() ) {
  - if( debug > 0 ) log( "Using webapp loader " + context.isTrusted());
  + if( debug > 0 ) log( "Using webapp loader ");
parent=cm.getAppsLoader();
} else {
if( debug > 0 ) log( "Using container loader ");
  @@ -284,22 +334,37 @@
   }
   
   private void initJaxpJars() {
  - if( jaxpDir==null ) jaxpDir=cm.getInstallDir() + "/lib/container";
  - File 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/config ContextXmlReader.java

[larryi]

larryi  01/12/05 03:20:52

  Modified:src/share/org/apache/tomcat/modules/config
ContextXmlReader.java
  Log:
  For consistency with server.xml handling, added support for
   and ant-style variable substitution in Context definitions
  
  Revision  ChangesPath
  1.12  +69 -2 
jakarta-tomcat/src/share/org/apache/tomcat/modules/config/ContextXmlReader.java
  
  Index: ContextXmlReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/modules/config/ContextXmlReader.java,v
  retrieving revision 1.11
  retrieving revision 1.12
  diff -u -r1.11 -r1.12
  --- ContextXmlReader.java 2001/10/20 02:52:12 1.11
  +++ ContextXmlReader.java 2001/12/05 11:20:52 1.12
  @@ -68,6 +68,7 @@
   import org.apache.tomcat.util.xml.*;
   import org.apache.tomcat.core.*;
   import org.apache.tomcat.modules.server.*;
  +import org.apache.tomcat.util.IntrospectionUtils;
   import org.apache.tomcat.util.log.Log;
   import org.xml.sax.*;
   
  @@ -110,6 +111,7 @@
// use the same tags for context-local modules
addTagRules(cm, xh);
setContextRules( xh );
  +setPropertiesRules( cm, xh );
setBackward( xh );
   
// load the config file(s)
  @@ -144,7 +146,58 @@
   
   //  Xml reading details 
   
  -// rules for reading teh context config
  +static class ContextPropertySource
  +implements IntrospectionUtils.PropertySource
  +{
  +ContextManager cm;
  +Context ctx=null;
  + 
  +ContextPropertySource( ContextManager cm ) {
  +this.cm=cm;
  +}
  +
  +public void setContext(Context ctx) {
  +this.ctx=ctx;
  +}
  + 
  +public String getProperty( String key ) {
  +// XXX add other "predefined" properties
  +String s=null;
  +if( ctx != null )
  +s=ctx.getProperty( key );  
  +if( s == null )
  +s=cm.getProperty( key );
  +if( s == null )
  + s=System.getProperty( key );
  +return s;
  +}
  +}
  +
  +public static void setPropertiesRules( ContextManager cm, XmlMapper xh )
  + throws TomcatException
  +{
  + ContextPropertySource propS=new ContextPropertySource( cm );
  + xh.setPropertySource( propS );
  + 
  + xh.addRule( "Context/Property", new XmlAction() {
  + public void start(SaxContext ctx ) throws Exception {
  + AttributeList attributes = ctx.getCurrentAttributes();
  + String name=attributes.getValue("name");
  + String value=attributes.getValue("value");
  + if( name==null || value==null ) return;
  + XmlMapper xm=ctx.getMapper();
  + 
  + Context context=(Context)ctx.currentObject();
  + // replace ${foo} in value
  + value=xm.replaceProperties( value );
  + if( context.getDebug() > 0 )
  + context.log("Setting " + name + "=" + value);
  + context.setProperty( name, value );
  + }
  + });
  +}
  +
  +// rules for reading the context config
   public static void setContextRules( XmlMapper xh ) {
// Default host
xh.addRule( "Context",
  @@ -172,9 +225,23 @@
}
});
   
  +xh.addRule( "Context", new XmlAction() {
  +public void start( SaxContext xctx) throws Exception {
  +Context tcCtx=(Context)xctx.currentObject();
  +XmlMapper xm=xctx.getMapper();
  +ContextPropertySource propS = 
(ContextPropertySource)xm.getPropertySource();
  +if( propS != null )
  +propS.setContext(tcCtx);
  +}
  +});
  +
xh.addRule( "Context", new XmlAction() {
public void end( SaxContext xctx) throws Exception {
Context tcCtx=(Context)xctx.currentObject();
  +XmlMapper xm=xctx.getMapper();
  +ContextPropertySource propS = 
(ContextPropertySource)xm.getPropertySource();
  +if( propS != null )
  +propS.setContext(null);
String host=(String)xctx.getVariable("current_host");
String address=(String)xctx.getVariable("current_address");
Vector aliases=(Vector)xctx.getVariable( "host_aliases" );
  @@ -199,7 +266,7 @@
xh.addChild("addContext",
"org.apache.tomcat.core.Context") );
   }
  -
  +
   //  Backward compatibility  
   
   // Read old 

cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/modules/config ServerXmlReader.java

[larryi]

larryi  01/12/05 03:19:06

  Modified:src/share/org/apache/tomcat/modules/config
ServerXmlReader.java
  Log:
  Added a "tomcat.install" predefined property.
  
  Since all other server.xml tags start with a capital letter, added support for
   and kept the  for backwards compatibility.
  
  Revision  ChangesPath
  1.18  +23 -1 
jakarta-tomcat/src/share/org/apache/tomcat/modules/config/ServerXmlReader.java
  
  Index: ServerXmlReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/modules/config/ServerXmlReader.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- ServerXmlReader.java  2001/08/21 05:11:45 1.17
  +++ ServerXmlReader.java  2001/12/05 11:19:06 1.18
  @@ -190,6 +190,9 @@
if( "tomcat.home".equals( key ) ) {
return cm.getHome();
}
  +if( "tomcat.install".equals( key ) ) {
  +return cm.getInstallDir();
  + }
// XXX add other "predefined" properties
String s=cm.getProperty( key );
if( s==null )
  @@ -203,7 +206,26 @@
   {
CMPropertySource propS=new CMPropertySource( cm );
xh.setPropertySource( propS );
  - 
  +
  +// add the "correct" first-letter-capitalized version
  +xh.addRule( "ContextManager/Property", new XmlAction() {
  +public void start(SaxContext ctx ) throws Exception {
  +AttributeList attributes = ctx.getCurrentAttributes();
  +String name=attributes.getValue("name");
  +String value=attributes.getValue("value");
  +if( name==null || value==null ) return;
  +XmlMapper xm=ctx.getMapper();
  +
  +ContextManager cm1=(ContextManager)ctx.currentObject();
  +// replace ${foo} in value
  +value=xm.replaceProperties( value );
  +if( cm1.getDebug() > 0 )
  +cm1.log("Setting " + name + "=" + value);
  +cm1.setProperty( name, value );
  +}
  +});
  +
  +// for backward compatibility, keep old version
xh.addRule( "ContextManager/property", new XmlAction() {
public void start(SaxContext ctx ) throws Exception {
AttributeList attributes = ctx.getCurrentAttributes();
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

RE: Superb OSS Java IDE

[GOMEZ Henri]

>on 12/4/01 8:23 AM, "GOMEZ Henri" <[EMAIL PROTECTED]> wrote:
>
>> www.eclipse.org
>> 
>> OSS version of VisualAge for Java, by the
>> team who does VA Java :)
>> 
>> Excellent 
>
>Cool news. However, it isn't truly superb until it runs on OSX.
>
>:-)

Some lobbying to be conducted ;)

Important point, this IDE support CVS as repository .
Trully tailored for java OSS projects.

NB: It's the Visual Age for Java team who do Eclipse

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

JK versions status and web pages ?

[GOMEZ Henri]

What's the final status of versioning ?

- jtc/jk/native mod_jk 1.2
- jtc/jk/native2mod_jk 2.0

So we could make soon a release of mod_jk 1.2.

BTW: I need guidelines to create the JTC, at least jk webpages.
 
 - Did we have to choose anakia / buildsite ?
 - what will be the URL ? (http://jakarta.apache.org/jtc/) ?
   where will it be put on jakarta.apache.org ?
 
I plan to move some of the current Tomcat 3.3 documents, 
ie mod_jk, IIS, part of SSL to this page.

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: GOMEZ Henri [mailto:[EMAIL PROTECTED]]
>Sent: Tuesday, December 04, 2001 10:12 AM
>To: Tomcat Developers List
>Subject: RE: JK versions
>
>
>>After reading the commit log - most changes related to jk_channel,
>>jk_registry, etc are pretty safe ( as they don't change any logic ).
>>
>>We could actually release Jk1.2 using the main tree - if everyone is
>>comfortable with that. If not - Oct21 is probably a good point 
>>to branch
>>( the release date for 3.3 ).
>>
>>There are few fixes for ebcdic support and few small things that would
>>have to be re-applied.
>
>Let's get the old version, and then I'll reapply the EBCDIC changes.
>We should keep ajp12 is JK 1.2 :)
>
>--
>To unsubscribe, e-mail:   
>
>For additional commands, e-mail: 
>
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5277] New: - JDBC Realms crashs with empty password on Oracle

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5277

JDBC Realms crashs with empty password on Oracle

   Summary: JDBC Realms crashs with empty password on Oracle
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: AJP Connector
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The problem is that the Oracle-DB treats an empty String as null. When I set the
password for a user to "" Oracle sets it to null... When I now try to login via
JDBCRealms I get a 500er Errorpage.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

Re: Building the WebApp module instruction errors

[jean-frederic clere]

Thanks, committed in jakarta-tomcat-connectors/webapp/docs

Andrew Savory wrote:
> 
> Hi,
> 
> Working through the instructions for building WebApp at:
> http://nagoya.apache.org/~pier/documentation/build-u.html
> ... I noticed a few possible errors.
> 
> The line:
> # rmdir jakarta-tomcat-connectors
> should be 
> # rm -rf jakarta-tomcat-connectors
> (because the CVS directory inside will prevent rmdir from working)
> 
> The second line saying:
> # cd webapp
> shouldn't be there, as we've already changed to that directory before cvs
> update -Pd.
> 
> The line:
> # sh ./apr/buildconf
> fails:
> ./apr/buildconf: build/buildcheck.sh: No such file or directory
> It should probably be:
> # cd apr
> # sh ./buildconf
> (or else fix the paths)
> 
> Oh, and it still fails to build (see "mod_webapp fails to build").
> 
> Hope that helps.
> 
> Andrew.
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5275] - Equals sign was not allowed in URL parameter values

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5275

Equals sign was not allowed in URL parameter values

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 00:38 ---
Unfortunately, this patch would allow you to violate the HTTP/1.1 specification,
which says that any special characters like '=' in a request URL need to be URL
encoded by the client.  The fact that some prior version of Tomcat might have
let you get away with this is no excuse for violating the specifications.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/docs build-u.html

[jfclere]

jfclere 01/12/05 00:19:17

  Modified:webapp/docs build-u.html
  Log:
  rm -rf not rmdiri -rf ...
  
  Revision  ChangesPath
  1.4   +2 -2  jakarta-tomcat-connectors/webapp/docs/build-u.html
  
  Index: build-u.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/docs/build-u.html,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- build-u.html  2001/12/05 08:18:19 1.3
  +++ build-u.html  2001/12/05 08:19:17 1.4
  @@ -73,7 +73,7 @@
   [...]
   # mv apr jakarta-tomcat-connectors/webapp
   # mv jakarta-tomcat-connectors/webapp webapp
  -# rmdir -rf jakarta-tomcat-connectors
  +# rm -rf jakarta-tomcat-connectors
   # cd webapp
   # cvs update -Pd
   [...]
  @@ -103,7 +103,7 @@
 Copyright © The http://www.apache.org/";>Apache Software
 Foundation 1999-2001. All Rights Reserved.
 Written by mailto:[EMAIL PROTECTED]";>Pier Fumagalli.
  -  CVS Revision $Id: build-u.html,v 1.3 2001/12/05 08:18:19 jfclere Exp $
  +  CVS Revision $Id: build-u.html,v 1.4 2001/12/05 08:19:17 jfclere Exp $
   
 
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

cvs commit: jakarta-tomcat-connectors/webapp/docs build-u.html

[jfclere]

jfclere 01/12/05 00:18:19

  Modified:webapp/docs build-u.html
  Log:
  Arrange some small problems.
  Submitted by: Andrew Savory, [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.3   +2 -3  jakarta-tomcat-connectors/webapp/docs/build-u.html
  
  Index: build-u.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/webapp/docs/build-u.html,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- build-u.html  2001/11/01 22:20:51 1.2
  +++ build-u.html  2001/12/05 08:18:19 1.3
  @@ -73,7 +73,7 @@
   [...]
   # mv apr jakarta-tomcat-connectors/webapp
   # mv jakarta-tomcat-connectors/webapp webapp
  -# rmdir jakarta-tomcat-connectors
  +# rmdir -rf jakarta-tomcat-connectors
   # cd webapp
   # cvs update -Pd
   [...]
  @@ -83,7 +83,6 @@
 the WebApp module and APR:
   
   
  -# cd webapp
   # sh ./support/buildconf.sh
   [...]
   # sh ./apr/buildconf
  @@ -104,7 +103,7 @@
 Copyright © The http://www.apache.org/";>Apache Software
 Foundation 1999-2001. All Rights Reserved.
 Written by mailto:[EMAIL PROTECTED]";>Pier Fumagalli.
  -  CVS Revision $Id: build-u.html,v 1.2 2001/11/01 22:20:51 pier Exp $
  +  CVS Revision $Id: build-u.html,v 1.3 2001/12/05 08:18:19 jfclere Exp $
   
 
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5275] - Equals sign was not allowed in URL parameter values

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5275

Equals sign was not allowed in URL parameter values





--- Additional Comments From [EMAIL PROTECTED]  2001-12-05 00:34 ---
Created an attachment (id=870)
The fixed source by Hoad and Lepri. Fixes are marked by comments // NEW RLH

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

[PATCH] mod_webapp and Apache 2.0

[Justin Erenkrantz]

Gets rid of lame warnings against latest httpd-2.0 and APR.
-- justin

Index: webapp/apache-2.0/mod_webapp.c
===
RCS file: /home/cvspublic/jakarta-tomcat-connectors/webapp/apache-2.0/mod_webapp.c,v
retrieving revision 1.6
diff -u -r1.6 mod_webapp.c
--- webapp/apache-2.0/mod_webapp.c  2001/11/01 22:20:51 1.6
+++ webapp/apache-2.0/mod_webapp.c  2001/12/05 08:14:13
@@ -70,6 +70,7 @@
 #include 
 #include 
 #include 
+#include 
 
 /* * */
 /* GENERIC DECLARATIONS  */
@@ -477,7 +478,7 @@
 
 /* Copy headers into webapp request structure */
 if (r->headers_in!=NULL) {
-apr_array_header_t *arr=apr_table_elts(r->headers_in);
+const apr_array_header_t *arr=apr_table_elts(r->headers_in);
 apr_table_entry_t *ele=(apr_table_entry_t *)arr->elts;
 int x=0;
 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 

DO NOT REPLY [Bug 5275] New: - Equals sign was not allowed in URL parameter values

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5275

Equals sign was not allowed in URL parameter values

   Summary: Equals sign was not allowed in URL parameter values
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


org.apache.catalina.util.RequestUtil does not parse URL parameters where the 
value contains '='. This bug was identified by my colleague Ennio Lepri.

We have a fix which I will also post to the developer list:
 Line ~507  case '=':
if (key == null)// NEW RLH
{
key = new String(data, 0, ox, encoding);
ox = 0;
} // NEW RLH
else // NEW RLH
data[ox++] = c; // NEW RLH
break;

--
To unsubscribe, e-mail:   
For additional commands, e-mail: