Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper Constants.java
hey remy, is this patch included in 4.1.3? If so I'll test it out with the JSTL pages I have. peter [EMAIL PROTECTED] wrote: remm02/05/29 17:02:35 Modified:jasper2/src/share/org/apache/jasper Constants.java Log: - The suggested amount was actually 512. - Patch submitted by Tyler Van Gorder tkv at landacorp.com. Sorry for forgetting to give you credit the first time around. Revision ChangesPath 1.3 +1 -1 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Constants.java Index: Constants.java === RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/Constants.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- Constants.java29 May 2002 23:24:59 - 1.2 +++ Constants.java30 May 2002 00:02:35 - 1.3 @@ -134,7 +134,7 @@ /** * Default size for the tag buffers. */ -public static final int DEFAULT_TAG_BUFFER_SIZE = 256; +public static final int DEFAULT_TAG_BUFFER_SIZE = 512; /** * The query parameter that causes the JSP engine to just -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9516] - Filter.doFilter(): program flow does not survive chain.doFilter() when using RequestDispatcher.include() before
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9516. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9516 Filter.doFilter(): program flow does not survive chain.doFilter() when using RequestDispatcher.include() before [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2002-05-30 11:40 --- sorry, seems as if this was my own stupidity. will re-open the bug if i need to. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9519] New: - Preventing Tomcat 4 running under Mac OS X
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9519. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9519 Preventing Tomcat 4 running under Mac OS X Summary: Preventing Tomcat 4 running under Mac OS X Product: Tomcat 4 Version: 4.0.3 Final Platform: Macintosh OS/Version: MacOS X Status: NEW Severity: Blocker Priority: Other Component: Webapps:Documentation AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The documentation clearly states that there isn't much that can go wrong during an installation of Tomcat 4 but there are a important difference between Tomcat 3.x and 4.x under (at least) Mac OS X (possibly all OS's). After installing you need to set the rights correctly for the Tomcat folder for Tomcat to be able to actually run any code. If you don't - Tomcat will still start up and display to normal index page but will NOT be able to run any code (i.e. the included examples). Sollution is to run a chmod -R 775 $TOMCAT_HOME for example. Please include this in the readme distrubuted with Tomcat. Thank you! -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [4.1.3] Milestone available for testing
Remy Maucherat wrote: The 4.1.3 milestone is available for testing. The vote on how much the build should be publicized will happen later this week (unless a showstopper bug is found before, in which case a new milestone will be released). Binaries are available at: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.3/ WARNING: This is not an official Tomcat release and should be considered as stable as a nightly build. The build is available for testing purposes only. I am not able to get the administration tool working (like if the role manager would not be enough to use it (403 and 404 - /admin/j_security_check). I noted that the problem I had to run coyote on port 88 is fixed ;-)). But the problems with permissions (after setuid(nobody) using BootstrapService) are still there: +++ javax.naming.NamingException: /export/home/apache20/jakarta-tomcat-4.1.3/conf/to mcat-users.xml.new (Permission denied) at org.apache.naming.NamingContext.lookup(NamingContext.java:844) at org.apache.naming.NamingContext.lookup(NamingContext.java:194) at org.apache.catalina.realm.UserDatabaseRealm.start(UserDatabaseRealm.j +++ The same for the logs... Highlights in this build include further performance improvements in Jasper (with a lot more to come), usage of Ant 1.5 as the JSP compiler, and a complete rewrite of the SSI functionality. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [4.1.3] Milestone available for testing
Remy Maucherat wrote: The 4.1.3 milestone is available for testing. The vote on how much the build should be publicized will happen later this week (unless a showstopper bug is found before, in which case a new milestone will be released). Binaries are available at: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.3/ WARNING: This is not an official Tomcat release and should be considered as stable as a nightly build. The build is available for testing purposes only. I am not able to get the administration tool working (like if the role manager would not be enough to use it (403 and 404 - /admin/j_security_check). It needs role admin. I noted that the problem I had to run coyote on port 88 is fixed ;-)). But the problems with permissions (after setuid(nobody) using BootstrapService) are still there: +++ javax.naming.NamingException: /export/home/apache20/jakarta-tomcat-4.1.3/conf/to mcat-users.xml.new (Permission denied) at org.apache.naming.NamingContext.lookup(NamingContext.java:844) at org.apache.naming.NamingContext.lookup(NamingContext.java:194) at org.apache.catalina.realm.UserDatabaseRealm.start(UserDatabaseRealm.j +++ The same for the logs... The admin stuff and the new memory realm insist to write to the conf/ folder. You can configure the old memory realm to avoid that. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper Constants.java
I'll give it a run through later today when I get home. too many things to do at work right now. thanks for the info. peter Remy Maucherat wrote: hey remy, is this patch included in 4.1.3? No. Reusing the buffers and tags is the more interesting optimization. However, it still seemed useless to allocate big buffers, so I applied the patch. If so I'll test it out with the JSTL pages I have. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: New releases
On Thu, 30 May 2002, Lars George wrote: Does this also mean that the deprecated jk1, which was in exactly the same code tree does not exist anymore, ie. the current code is jk2 and only that? Of course not. Jk1 still exists in at least 2 places. Again, split by language: - mod_jk1 ( the C side ) is in j-t-c/jk/native, and also j-t/src/native/jk ( part of 3.3, but works with any tomcat ). The last one will eventually be removed, but there's no hurry. - the java side of what is considered jk1 is implemented in org.apache.ajp package, in j-t-c/jk/java ( for tomcat 4.x ) and jakarta-tomcat for 3.3. ( each server has it's own impl - coyote resolves that ). The goal is not to confuse people, but to be extra safe and not remove code that works very well. jk2 may have a better architecture and extra features / faster, but the core functionality is still the same - forwarding requests between web server and tomcat. Costin -- Lars - Original Message - From: [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Thursday, May 30, 2002 3:25 PM Subject: RE: New releases On Thu, 30 May 2002, Lars George wrote: - The Apache/jakarta-tomcat-connectors/coyote only implements a framework. What package does implement the actual protocol, ie. where is tomcat-jk2? in j-t-c/jk/java. - The Apache/jakarta-tomcat-connectors/jk/native implements mod_jk1 and Apache/jakarta-tomcat-connectors/jk/native2 implements mod_jk2? Yes. Note that the '2' is just a version number, and reflects internal code changes and config changes. The actual protocol is the same (ajp13), so you can use either implementation. ( there are some extensions and many extra features in native2/, but it is backward compatible ). Sory for all confusion - it's just normal software evolution, but we try to keep some basic compatibility and interoperability between components, and the whole thing is pretty modular and flexible. When native2 is released and enough people are satisfied, we'll have a simpler story ( until jk3 is started :-) Costin Thanks again, Lars -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]] Sent: Thursday, 30 May 2002 12:14 To: Tomcat Developers List Subject: RE: New releases On Thu, 30 May 2002, Lars George wrote: Remy, Thanks for the explanation, if the sources in the cvs named tomcat 4.0 then where will I find the 4.0.4 code? Is this branched off and what would its tag/flag be? One more question if you do not mind, am I correct assuming that JK2 is only for Tomcat 4.1.x and it is named Coyote in the connector package? Sorry, me confused! Coyote is a set of APIs to abstract the connectors ( http, etc ) and servlet container. It can be used with any kind of connector and with any container ( curently 3.3, 4.0, 4.1 - but it is possible to add 3.2 or even other containers ). tomcat-jk2 is the java implementation for the ajp13 protocol - and is using Coyote APIs ( so it works with any servlet container supported by coyote ). Same for the http11 implementation. On the web server side, you can use either mod_jk1 or mod_jk2. Both are using the same protocol and will work with any version of tomcat ( including 3.2.x ). mod_jk2 is getting close to 'stable', but there is still work going on. Costin Thanks a lot, Lars -Original Message- From: Remy Maucherat [mailto:[EMAIL PROTECTED]] Sent: Thursday, 30 May 2002 1:58 To: Tomcat Developers List Subject: Re: New releases Remy, I would be very happy if the new version would be declared stable. I just spent 1 man-day to fix a bug in 4.0.3 just to release that this is already fixed in the current 4.0 sources. One question if you don't mind, would this be what I mentioned above, ie. is the current code in the nightly folder for tomcat 4.0 the latest version you want to promote to 4.0.4? If so I could get started testing it in our environment. No, the nightlies are 4.1.x. Please note that it will also give me a chance to check this bug I submitted earlier but which is not handled yet: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9334 All the JK guys are working on JK 2, which is a (big) refactoring of JK, and is part of Coyote. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: catalina/build.xml JDK1.4.0 and Ant 1.5Beta1
Try ant1.5Beta2 ( or the ant nightly ), it should be fixed now.
For tomcat3.3 and all other components that are still maintaining
compatibility with JDK1.1 - it is absolutely required we add a
'target=1.1', since code generated by 1.4.0 will _not_ work with
JDK1.1 ( or jikes and many other tools ).
Costin
On Thu, 30 May 2002, jean-frederic clere wrote:
Hi,
I have an error with making ant dist when I am using
ant1.5Beta1 anf JDK1.4.0.
The error is due to the property name=build.compilervalue=classic/ of
catalina/build.xml.
Why do we need to set build.compiler to classic?
The work-around is easy: build.compiler=modern in build.properties ;-)
Cheers
Jean-frederic
+++
build-prepare:
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/endorsed
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/conf
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/logs
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/shared/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/shared/lib
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/work
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/temp
copy-activation.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-daemon.jar:
[copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin
copy-dbcp.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-jaas.jar:
copy-jdbc20ext.jar:
copy-jmx.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
copy-jndi.jar:
copy-jsse.jar:
copy-jta.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-ldap.jar:
copy-modeler.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
copy-pool.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-tyrex.jar:
copy-xerces.jar:
copy-xerces2.jars:
build-static:
[copy] Copying 13 files to /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 5 files to /home/jakarta/jakarta-tomcat-4.1/catalina/build/conf
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
build-tomcat-util:
detect:
build-prepare:
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build/lib
build-main:
[echo] - Java-utils -
[echo] -- puretls.present = ${puretls.present}
[echo] -- jsse.present = true
[echo] -- commons-logging = true
[javac] Compiling 57 source files to
/home/jakarta/jakarta-tomcat-connectors/util/build/classes
BUILD FAILED
/home/jakarta/jakarta-tomcat-connectors/util/build.xml:47: This version of java
does not support the classic compiler
Total time: 4 seconds
+++
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Strange servlet behaviour with tomcat 4
Hi, We have several web sites based on servlets working with apache 1.3.23 + mod_ssl + tomcat 3.3 + mod_jk. We use an authentication servlet to validate our users into the private part of the sites. We only use SSL to encapsulate the authentication servlet transactions. Now we are trying tomcat 4 (with the same apache, mod_ssl mod_jk version), but the first call to the authentication servlet does not receive any parameters. The second call receives the parameters correctly though. After closing the browser and opening it again, the anomaly repeats. When we disable SSL in the calls to the servlet the problem disappears. Despite debugging the code and inspecting tomcat/apache logs we have not detected the cause. Since the only thing that has changed in the scenario is tomcat (we have tried tomcat 4.0.3 and tomcat 4.0.4-beta3), could it be a problem in apache/ssl/tomcat4 interaction? a problem with http sessions? Thanks in advance, Sergio -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [4.1.3] Milestone available for testing
Remy Maucherat wrote: Remy Maucherat wrote: The 4.1.3 milestone is available for testing. The vote on how much the build should be publicized will happen later this week (unless a showstopper bug is found before, in which case a new milestone will be released). Binaries are available at: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.3/ WARNING: This is not an official Tomcat release and should be considered as stable as a nightly build. The build is available for testing purposes only. I am not able to get the administration tool working (like if the role manager would not be enough to use it (403 and 404 - /admin/j_security_check). It needs role admin. But it was manager in TC4.0 :-( I noted that the problem I had to run coyote on port 88 is fixed ;-)). But the problems with permissions (after setuid(nobody) using BootstrapService) are still there: +++ javax.naming.NamingException: /export/home/apache20/jakarta-tomcat-4.1.3/conf/to mcat-users.xml.new (Permission denied) at org.apache.naming.NamingContext.lookup(NamingContext.java:844) at org.apache.naming.NamingContext.lookup(NamingContext.java:194) at org.apache.catalina.realm.UserDatabaseRealm.start(UserDatabaseRealm.j +++ The same for the logs... The admin stuff and the new memory realm insist to write to the conf/ folder. You can configure the old memory realm to avoid that. Ok, and if I use the admin tool I need to write the user information. What about the logs? The question is would it be possible to open the file before being nobody? Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: catalina/build.xml JDK1.4.0 and Ant 1.5Beta1
[EMAIL PROTECTED] wrote:
Try ant1.5Beta2 ( or the ant nightly ), it should be fixed now.
For tomcat3.3 and all other components that are still maintaining
compatibility with JDK1.1 - it is absolutely required we add a
'target=1.1', since code generated by 1.4.0 will _not_ work with
JDK1.1 ( or jikes and many other tools ).
That was with TC4.0 it only requires compatibility with JDK1.2. (javac1.2).
Moving the build.compiler=classic or javac1.2 to the top build.xml would
make sense, or do we have things that only compile with JDK1.3? (For example in
connectors).
Costin
On Thu, 30 May 2002, jean-frederic clere wrote:
Hi,
I have an error with making ant dist when I am using
ant1.5Beta1 anf JDK1.4.0.
The error is due to the property name=build.compilervalue=classic/ of
catalina/build.xml.
Why do we need to set build.compiler to classic?
The work-around is easy: build.compiler=modern in build.properties ;-)
Cheers
Jean-frederic
+++
build-prepare:
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/endorsed
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/conf
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/logs
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[mkdir] Created dir:
/home/jakarta/jakarta-tomcat-4.1/catalina/build/shared/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/shared/lib
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/work
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/temp
copy-activation.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-daemon.jar:
[copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin
copy-dbcp.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-jaas.jar:
copy-jdbc20ext.jar:
copy-jmx.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
copy-jndi.jar:
copy-jsse.jar:
copy-jta.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-ldap.jar:
copy-modeler.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
copy-pool.jar:
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
copy-tyrex.jar:
copy-xerces.jar:
copy-xerces2.jars:
build-static:
[copy] Copying 13 files to /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 5 files to /home/jakarta/jakarta-tomcat-4.1/catalina/build/conf
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib
[copy] Copying 1 file to
/home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib
build-tomcat-util:
detect:
build-prepare:
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build/classes
[mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build/lib
build-main:
[echo] - Java-utils -
[echo] -- puretls.present = ${puretls.present}
[echo] -- jsse.present = true
[echo] -- commons-logging = true
[javac] Compiling 57 source files to
/home/jakarta/jakarta-tomcat-connectors/util/build/classes
BUILD FAILED
/home/jakarta/jakarta-tomcat-connectors/util/build.xml:47: This version of java
does not support the classic compiler
Total time: 4 seconds
+++
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [4.1.3] Milestone available for testing
Clere, Jean-Frederic wrote: Remy Maucherat wrote: Remy Maucherat wrote: The 4.1.3 milestone is available for testing. The vote on how much the build should be publicized will happen later this week (unless a showstopper bug is found before, in which case a new milestone will be released). Binaries are available at: http://jakarta.apache.org/builds/jakarta-tomcat-4.0/test/v4.1.3/ WARNING: This is not an official Tomcat release and should be considered as stable as a nightly build. The build is available for testing purposes only. I am not able to get the administration tool working (like if the role manager would not be enough to use it (403 and 404 - /admin/j_security_check). It needs role admin. But it was manager in TC4.0 :-( How do deploy a new application using the administration tool? I have a war file (servlet-tests.war) to deploy as /servlet-tests. I noted that the problem I had to run coyote on port 88 is fixed ;-)). But the problems with permissions (after setuid(nobody) using BootstrapService) are still there: +++ javax.naming.NamingException: /export/home/apache20/jakarta-tomcat-4.1.3/conf/to mcat-users.xml.new (Permission denied) at org.apache.naming.NamingContext.lookup(NamingContext.java:844) at org.apache.naming.NamingContext.lookup(NamingContext.java:194) at org.apache.catalina.realm.UserDatabaseRealm.start(UserDatabaseRealm.j +++ The same for the logs... The admin stuff and the new memory realm insist to write to the conf/ folder. You can configure the old memory realm to avoid that. Ok, and if I use the admin tool I need to write the user information. What about the logs? The question is would it be possible to open the file before being nobody? Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/tester/web/WEB-INF/cgi test-cgi.pl
craigmcc02/05/30 09:35:15 Modified:tester/web/WEB-INF/cgi test-cgi.pl Log: Remove Sun license that was mistakenly left on the initial commit. This file has been contributed to the Apache Software Foundation. Revision ChangesPath 1.2 +57 -17jakarta-tomcat-4.0/tester/web/WEB-INF/cgi/test-cgi.pl Index: test-cgi.pl === RCS file: /home/cvs/jakarta-tomcat-4.0/tester/web/WEB-INF/cgi/test-cgi.pl,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- test-cgi.pl 1 Jun 2001 00:24:21 - 1.1 +++ test-cgi.pl 30 May 2002 16:35:15 - 1.2 @@ -1,21 +1,61 @@ #!/usr/local/bin/perl # -# @(#)test-cgi.pl1.2 98/05/28 -# -# Copyright (c) 1996-1998 Sun Microsystems, Inc. All Rights Reserved. -# -# Permission to use, copy, modify, and distribute this software -# and its documentation for NON-COMMERCIAL purposes and without -# fee is hereby granted provided that this copyright notice -# appears in all copies. Please refer to the file copyright.html -# for further important copyright and licensing information. -# -# SUN MAKES NO REPRESENTATIONS OR WARRANTIES ABOUT THE SUITABILITY OF -# THE SOFTWARE, EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED -# TO THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -# PARTICULAR PURPOSE, OR NON-INFRINGEMENT. SUN SHALL NOT BE LIABLE FOR -# ANY DAMAGES SUFFERED BY LICENSEE AS A RESULT OF USING, MODIFYING OR -# DISTRIBUTING THIS SOFTWARE OR ITS DERIVATIVES. +# = * +# * +# The Apache Software License, Version 1.1 * +# * +# Copyright (c) 1999, 2000, 2001 The Apache Software Foundation. * +# All rights reserved.* +# * +# = * +# * +# Redistribution and use in source and binary forms, with or without modi- * +# fication, are permitted provided that the following conditions are met: * +# * +# 1. Redistributions of source code must retain the above copyright notice * +#notice, this list of conditions and the following disclaimer. * +# * +# 2. Redistributions in binary form must reproduce the above copyright * +#notice, this list of conditions and the following disclaimer in the * +#documentation and/or other materials provided with the distribution. * +# * +# 3. The end-user documentation included with the redistribution, if any, * +#must include the following acknowlegement: * +# * +# This product includes software developed by the Apache Software * +#Foundation http://www.apache.org/. * +# * +#Alternately, this acknowlegement may appear in the software itself, if * +#and wherever such third-party acknowlegements normally appear. * +# * +# 4. The names The Jakarta Project, Tomcat, and Apache Software * +#Foundation must not be used to endorse or promote products derived * +#from this software without prior written permission. For written * +#permission, please contact [EMAIL PROTECTED].* +# * +# 5. Products derived from this software may not be called Apache nor may * +#Apache appear in their names without prior written permission of the * +#Apache Software Foundation.* +# * +# THIS SOFTWARE IS PROVIDED AS IS AND ANY EXPRESSED OR IMPLIED WARRANTIES * +# INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY * +# AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL * +# THE APACHE SOFTWARE FOUNDATION OR ITS CONTRIBUTORS BE LIABLE FOR ANY * +# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL *
cvs commit: jakarta-tomcat-4.0/tester/web/WEB-INF/cgi test-cgi.pl
craigmcc02/05/30 09:36:40 Modified:tester/web/WEB-INF/cgi Tag: tomcat_40_branch test-cgi.pl Log: Replace the Sun license that was mistakenly left on the original commit. This file has been contributed to the Apache Software Foundation. Revision ChangesPath No revision No revision 1.1.2.2 +56 -16jakarta-tomcat-4.0/tester/web/WEB-INF/cgi/test-cgi.pl Index: test-cgi.pl === RCS file: /home/cvs/jakarta-tomcat-4.0/tester/web/WEB-INF/cgi/test-cgi.pl,v retrieving revision 1.1.2.1 retrieving revision 1.1.2.2 diff -u -r1.1.2.1 -r1.1.2.2 --- test-cgi.pl 26 Mar 2002 14:18:43 - 1.1.2.1 +++ test-cgi.pl 30 May 2002 16:36:40 - 1.1.2.2 @@ -1,21 +1,61 @@ #!/usr/local/bin/perl # -# @(#)test-cgi.pl1.2 98/05/28 -# -# Copyright (c) 1996-1998 Sun Microsystems, Inc. All Rights Reserved. -# -# Permission to use, copy, modify, and distribute this software -# and its documentation for NON-COMMERCIAL purposes and without -# fee is hereby granted provided that this copyright notice -# appears in all copies. Please refer to the file copyright.html -# for further important copyright and licensing information. -# -# SUN MAKES NO REPRESENTATIONS OR WARRANTIES ABOUT THE SUITABILITY OF -# THE SOFTWARE, EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED -# TO THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A -# PARTICULAR PURPOSE, OR NON-INFRINGEMENT. SUN SHALL NOT BE LIABLE FOR -# ANY DAMAGES SUFFERED BY LICENSEE AS A RESULT OF USING, MODIFYING OR -# DISTRIBUTING THIS SOFTWARE OR ITS DERIVATIVES. +# = * +# * +# The Apache Software License, Version 1.1 * +# * +# Copyright (c) 1999, 2000, 2001 The Apache Software Foundation. * +# All rights reserved.* +# * +# = * +# * +# Redistribution and use in source and binary forms, with or without modi- * +# fication, are permitted provided that the following conditions are met: * +# * +# 1. Redistributions of source code must retain the above copyright notice * +#notice, this list of conditions and the following disclaimer. * +# * +# 2. Redistributions in binary form must reproduce the above copyright * +#notice, this list of conditions and the following disclaimer in the * +#documentation and/or other materials provided with the distribution. * +# * +# 3. The end-user documentation included with the redistribution, if any, * +#must include the following acknowlegement: * +# * +# This product includes software developed by the Apache Software * +#Foundation http://www.apache.org/. * +# * +#Alternately, this acknowlegement may appear in the software itself, if * +#and wherever such third-party acknowlegements normally appear. * +# * +# 4. The names The Jakarta Project, Tomcat, and Apache Software * +#Foundation must not be used to endorse or promote products derived * +#from this software without prior written permission. For written * +#permission, please contact [EMAIL PROTECTED].* +# * +# 5. Products derived from this software may not be called Apache nor may * +#Apache appear in their names without prior written permission of the * +#Apache Software Foundation.* +# * +# THIS SOFTWARE IS PROVIDED AS IS AND ANY EXPRESSED OR IMPLIED WARRANTIES * +# INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY * +# AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL * +# THE APACHE SOFTWARE
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml
manveen 02/05/30 10:03:01 Modified:catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml Log: Added some missing attributes under JNDIRealm. Revision ChangesPath 1.58 +18 -1 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml Index: mbeans-descriptors.xml === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v retrieving revision 1.57 retrieving revision 1.58 diff -u -r1.57 -r1.58 --- mbeans-descriptors.xml16 May 2002 20:46:00 - 1.57 +++ mbeans-descriptors.xml30 May 2002 17:03:01 - 1.58 @@ -6,7 +6,7 @@ !-- Descriptions of JMX MBeans for Catalina - $Id: mbeans-descriptors.xml,v 1.57 2002/05/16 20:46:00 amyroh Exp $ + $Id: mbeans-descriptors.xml,v 1.58 2002/05/30 17:03:01 manveen Exp $ -- mbeans-descriptors @@ -1011,13 +1011,30 @@ description=The message format used to select roles for a user type=java.lang.String/ +attribute name=roleName + description=The name of the attribute containing roles held elsewhere + type=java.lang.String/ + attribute name=roleSubtree description=Should we search the entire subtree for matching memberships? type=boolean/ +attribute name=userSubtree + description=Should we search the entire subtree for matching + users? + type=boolean/ + +attribute name=userPassword + description=The attribute name used to retrieve the user password + type=java.lang.String/ + attribute name=userPattern description=The message format used to select a user + type=java.lang.String/ + +attribute name=contextFactory + description=The JNDI context factory for this Realm type=java.lang.String/ /mbean -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/realm jndiRealm.jsp
manveen 02/05/30 10:22:04
Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm
EditRealmAction.java SaveJNDIRealmAction.java
webapps/admin/realm jndiRealm.jsp
Log:
Fix for jndi realm throwing exception while adding a new realm.
Revision ChangesPath
1.7 +7 -7
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/EditRealmAction.java
Index: EditRealmAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/EditRealmAction.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- EditRealmAction.java 30 May 2002 06:23:08 - 1.6
+++ EditRealmAction.java 30 May 2002 17:22:04 - 1.7
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/EditRealmAction.java,v
1.6 2002/05/30 06:23:08 manveen Exp $
- * $Revision: 1.6 $
- * $Date: 2002/05/30 06:23:08 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/EditRealmAction.java,v
1.7 2002/05/30 17:22:04 manveen Exp $
+ * $Revision: 1.7 $
+ * $Date: 2002/05/30 17:22:04 $
*
*
*
@@ -92,7 +92,7 @@
* Realm /em transactions, based on the type of Realm.
*
* @author Manveen Kaur
- * @version $Revision: 1.6 $ $Date: 2002/05/30 06:23:08 $
+ * @version $Revision: 1.7 $ $Date: 2002/05/30 17:22:04 $
*/
public class EditRealmAction extends Action {
@@ -383,16 +383,16 @@
attribute = digest;
realmFm.setDigest
((String) mBServer.getAttribute(rname, attribute));
-attribute = roleSearch;
+attribute = roleSubtree;
realmFm.setSearch
-((String) mBServer.getAttribute(rname, attribute));
+(((Boolean) mBServer.getAttribute(rname,
attribute)).toString());
attribute = roleName;
realmFm.setRoleAttribute
((String) mBServer.getAttribute(rname, attribute));
attribute = roleBase;
realmFm.setRoleBase
((String) mBServer.getAttribute(rname, attribute));
-attribute = roleSubtree;
+attribute = roleSearch;
realmFm.setRolePattern
((String) mBServer.getAttribute(rname, attribute));
attribute = contextFactory;
1.4 +6 -6
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java
Index: SaveJNDIRealmAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- SaveJNDIRealmAction.java 9 May 2002 01:07:31 - 1.3
+++ SaveJNDIRealmAction.java 30 May 2002 17:22:04 - 1.4
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java,v
1.3 2002/05/09 01:07:31 manveen Exp $
- * $Revision: 1.3 $
- * $Date: 2002/05/09 01:07:31 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/SaveJNDIRealmAction.java,v
1.4 2002/05/30 17:22:04 manveen Exp $
+ * $Revision: 1.4 $
+ * $Date: 2002/05/30 17:22:04 $
*
*
*
@@ -96,7 +96,7 @@
* emEdit Realm/em transactions for JNDI realm.
*
* @author Manveen Kaur
- * @version $Revision: 1.3 $ $Date: 2002/05/09 01:07:31 $
+ * @version $Revision: 1.4 $ $Date: 2002/05/30 17:22:04 $
*/
public final class SaveJNDIRealmAction extends Action {
@@ -288,7 +288,7 @@
attribute = roleSearch;
mBServer.setAttribute(roname,
- new Attribute(roleSearch, rform.getSearch()));
+ new Attribute(roleSearch,
rform.getRolePattern()));
attribute = roleName;
mBServer.setAttribute(roname,
@@ -300,7 +300,7 @@
attribute = roleSubtree;
mBServer.setAttribute(roname,
- new Attribute(roleSubtree,
rform.getRolePattern()));
+ new Attribute(roleSubtree, new
Boolean(rform.getSearch(;
attribute = roleBase;
mBServer.setAttribute(roname,
1.7 +1 -1 jakarta-tomcat-4.0/webapps/admin/realm/jndiRealm.jsp
Re: catalina/build.xml JDK1.4.0 and Ant 1.5Beta1
On Thu, 30 May 2002, jean-frederic clere wrote: [EMAIL PROTECTED] wrote: Try ant1.5Beta2 ( or the ant nightly ), it should be fixed now. For tomcat3.3 and all other components that are still maintaining compatibility with JDK1.1 - it is absolutely required we add a 'target=1.1', since code generated by 1.4.0 will _not_ work with JDK1.1 ( or jikes and many other tools ). That was with TC4.0 it only requires compatibility with JDK1.2. (javac1.2). Moving the build.compiler=classic or javac1.2 to the top build.xml would make sense, or do we have things that only compile with JDK1.3? (For example in connectors). Removing build.compiler=classic would be the best - it was an workaround for older versions of ant. Ant is now able to ignore 'classic' if 1.4 is detected or fallback if 'modern' is specified. Plus this have no meaning if jikes is used. Regarding 'target=1.1' - if it is not used and you compile with JDK1.4, it is possible that various tools like jikes will stop working ( they may be unable to read the .class generated by the 1.4 compiler ). At least on linux with the current release of jikes I'm not able to use 1.4-compiled classes. Of course, for tomcat3 and all other tools that support JDK1.1 ( and J2ME, kaffe, gcj, etc ) - using target 1.1 or not using JDK1.4 to compile is essential. Costin Costin On Thu, 30 May 2002, jean-frederic clere wrote: Hi, I have an error with making ant dist when I am using ant1.5Beta1 anf JDK1.4.0. The error is due to the property name=build.compilervalue=classic/ of catalina/build.xml. Why do we need to set build.compiler to classic? The work-around is easy: build.compiler=modern in build.properties ;-) Cheers Jean-frederic +++ build-prepare: [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/classes [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/endorsed [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/conf [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/logs [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/classes [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/shared/classes [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/shared/lib [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/work [mkdir] Created dir: /home/jakarta/jakarta-tomcat-4.1/catalina/build/temp copy-activation.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib copy-daemon.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin copy-dbcp.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib copy-jaas.jar: copy-jdbc20ext.jar: copy-jmx.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib copy-jndi.jar: copy-jsse.jar: copy-jta.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib copy-ldap.jar: copy-modeler.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib copy-pool.jar: [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib copy-tyrex.jar: copy-xerces.jar: copy-xerces2.jars: build-static: [copy] Copying 13 files to /home/jakarta/jakarta-tomcat-4.1/catalina/build/bin [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib [copy] Copying 5 files to /home/jakarta/jakarta-tomcat-4.1/catalina/build/conf [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/common/lib [copy] Copying 1 file to /home/jakarta/jakarta-tomcat-4.1/catalina/build/server/lib build-tomcat-util: detect: build-prepare: [mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build [mkdir] Created dir: /home/jakarta/jakarta-tomcat-connectors/util/build/classes
cvs commit: jakarta-tomcat-4.0/webapps/admin/realm memoryRealm.jsp
manveen 02/05/30 10:27:31 Modified:webapps/admin/realm memoryRealm.jsp Log: Realm form name should be memoryRealmForm Revision ChangesPath 1.7 +1 -1 jakarta-tomcat-4.0/webapps/admin/realm/memoryRealm.jsp Index: memoryRealm.jsp === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/realm/memoryRealm.jsp,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- memoryRealm.jsp 21 May 2002 00:36:43 - 1.6 +++ memoryRealm.jsp 30 May 2002 17:27:31 - 1.7 @@ -43,7 +43,7 @@ controls:action selected=true bean:message key=actions.available.actions/ /controls:action controls:action - /controls:action logic:notEqual name=memoryRealmForm property=adminAction value=Create -logic:notEqual name=userDatabaseRealmForm property=allowDeletion value=false +logic:notEqual name=memoryRealmForm property=allowDeletion value=false controls:action url='%= /DeleteRealm.do?select= + URLEncoder.encode(thisObjectName) %' bean:message key=actions.realms.delete/ -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
PROPOSAL: clientFlush() method
Hi, I would like to add a new method to Response. clientFlush() will be called by ServletOutputStream.flush() to notify the container ( and the low level connector ) that the user has explicitely asked for the stream to be flushed. The default impl. will be empty, and in coyote adapter we'll generate an Action.CLIENT_FLUSH that may be interpreted by the connector. This would allow the connector to increase the granularity, which in turns result in about 20% reduction in the overhead ( for ajp/socket ). This happens by allowing the use of a BufferedOutputStream on the socket - the packets to send the header and the first chunk and the end response messages will all be sent at once, in one write() operation instead of 3. The servlet spec allows us to do that, but we must honor the flush() requests. I'll leave the option as disabled in jk2 ( since 4.1 and the current 3.3 doesn't support this ), but an option will enable the buffered writing. Comments ? Larry, Bill ? ( I tested this with 3.3 - Remy, I suppose something similar will be done in a future release of 4.1.x, I don't want to delay the release ) Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2 build.xml
costin 02/05/30 11:00:56
Modified:jk/native2 build.xml
Log:
Link jni with APR for hpux and solaris.
XXX need to create a is.unix flag - if not win or netware ( or other special cases ).
Revision ChangesPath
1.34 +4 -0 jakarta-tomcat-connectors/jk/native2/build.xml
Index: build.xml
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/build.xml,v
retrieving revision 1.33
retrieving revision 1.34
diff -u -r1.33 -r1.34
--- build.xml 29 May 2002 22:18:04 - 1.33
+++ build.xml 30 May 2002 18:00:56 - 1.34
@@ -363,6 +363,10 @@
linkOpt value=-lcrypt if=linux /
linkOpt value=-L${apr.lib} if=linux /
linkOpt value=-lapr if=linux /
+ linkOpt value=-L${apr.lib} if=solaris /
+ linkOpt value=-lapr if=solaris /
+ linkOpt value=-L${apr.lib} if=hpux /
+ linkOpt value=-lapr if=hpux /
altSoFile value=jni_conn if=netware /
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9526] New: - HttpServletRequest.getHeader(String) yields inconsistent results depending on how the request header was provided to tomcat
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9526. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9526 HttpServletRequest.getHeader(String) yields inconsistent results depending on how the request header was provided to tomcat Summary: HttpServletRequest.getHeader(String) yields inconsistent results depending on how the request header was provided to tomcat Product: Tomcat 4 Version: Nightly Build Platform: All OS/Version: All Status: NEW Severity: Major Priority: Other Component: Catalina AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The javadocs for HttpServletRequest.getHeaders(String name) states that this method will yield an enumeration of all values associated with the specified header. However, the result will yield unexpected results if the header is presented in a certain fashion. For example, take the following: GET /test.jsp HTTP/1.0 header1: val1 header1: val2 HTTP/1.1 200 OK Content-Type: text/html;ISO-8859-1 Set-Cookie: JSESSIONID=5952D8602392F093E5203582AACC4A65; Path=/ Date: Thu, 30 May 2002 18:50:14 GMT Server: Apache Coyote HTTP/1.1 Connector [1.0] Connection: close val1 val2 Now consider the same request, except in this case, instead of sending two request headers, the values are aggregated into a comma-separated list of values: -- Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. GET /test.jsp HTTP/1.0 header1: val1, val2 HTTP/1.1 200 OK Content-Type: text/html;ISO-8859-1 Set-Cookie: JSESSIONID=94E82F0181EE1001D109531544CAE960; Path=/ Date: Thu, 30 May 2002 18:55:36 GMT Server: Apache Coyote HTTP/1.1 Connector [1.0] Connection: close val1, val2 Connection closed by foreign host. --- In the above case, the call to getHeaders() is returning the list of values as a single enumerated entity. This seems to go against what is described in the javadocs. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_bean.h jk_channel.h jk_shm.h
costin 02/05/30 11:03:59 Modified:jk/native2/include jk_bean.h jk_channel.h jk_shm.h Log: Added a special flag to indicate that an invoke() operation has a response. This allows as to use JNI_ABORT and discard the buffer for most operations, only few calls need the buffer. Also removed unused methods in jk_shm, added a common 'super' impl for channel setAttribute. Revision ChangesPath 1.6 +2 -0 jakarta-tomcat-connectors/jk/native2/include/jk_bean.h Index: jk_bean.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_bean.h,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- jk_bean.h 28 May 2002 22:47:43 - 1.5 +++ jk_bean.h 30 May 2002 18:03:59 - 1.6 @@ -80,6 +80,8 @@ #define JK_STATE_DISABLED 0 #define JK_STATE_NEW 1 #define JK_STATE_INIT 2 + +#define JK_INVOKE_WITH_RESPONSE 1 /** * Factory used to create all jk objects. Factories are registered with 1.14 +3 -1 jakarta-tomcat-connectors/jk/native2/include/jk_channel.h Index: jk_channel.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_channel.h,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- jk_channel.h 28 May 2002 22:37:11 - 1.13 +++ jk_channel.h 30 May 2002 18:03:59 - 1.14 @@ -168,7 +168,9 @@ int JK_METHOD jk2_channel_invoke(struct jk_env *env, struct jk_bean *bean, struct jk_endpoint *ep, int code, struct jk_msg *msg, int raw); - + +int JK_METHOD jk2_channel_setAttribute(struct jk_env *env, struct jk_bean *mbean, char *name, void *valueP) + #ifdef __cplusplus } #endif /* __cplusplus */ 1.7 +0 -9 jakarta-tomcat-connectors/jk/native2/include/jk_shm.h Index: jk_shm.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_shm.h,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- jk_shm.h 15 May 2002 19:32:42 - 1.6 +++ jk_shm.h 30 May 2002 18:03:59 - 1.7 @@ -159,11 +159,6 @@ */ int (JK_METHOD *destroy)(struct jk_env *env, struct jk_shm *shm); -/** - */ -int (JK_METHOD *setWorkerEnv)( struct jk_env *env, struct jk_shm *shm, - struct jk_workerEnv *wEnv ); - /** Get a shm slot. Each slot has different rules for synchronization, based on type. */ struct jk_shm_slot *(JK_METHOD *getSlot)(struct jk_env *env, struct jk_shm *shm, int pos); @@ -171,10 +166,6 @@ /** Create a slot. This typically involves inter-process synchronization. */ struct jk_shm_slot *(JK_METHOD *createSlot)(struct jk_env *env, struct jk_shm *shm, char *name, int size); - -/** Get an ID that is unique across processes. - */ -int (JK_METHOD *getId)(struct jk_env *env, struct jk_shm *shm); int size; -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_channel_apr_socket.c jk_channel.c jk_channel_jni.c jk_channel_socket.c jk_channel_un.c
costin 02/05/30 11:05:08
Modified:jk/native2/common jk_channel_apr_socket.c jk_channel.c
jk_channel_jni.c jk_channel_socket.c
jk_channel_un.c
Log:
Use the common super method for setAttribute.
This allows setDisabled() on channel to propagate to worker, and reduce
the code duplication.
Added the JK_INVOKE_WITH_RESPONSE case to read().
Revision ChangesPath
1.21 +1 -4
jakarta-tomcat-connectors/jk/native2/common/jk_channel_apr_socket.c
Index: jk_channel_apr_socket.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_apr_socket.c,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- jk_channel_apr_socket.c 26 May 2002 07:30:01 - 1.20
+++ jk_channel_apr_socket.c 30 May 2002 18:05:08 - 1.21
@@ -122,10 +122,7 @@
} else if( strcmp( port, name ) == 0 ) {
socketInfo-port=atoi( value );
} else {
- if( ch-worker!=NULL ) {
-return ch-worker-mbean-setAttribute( env, ch-worker-mbean, name,
valueP );
-}
-return JK_ERR;
+return jk2_channel_setAttribute( env, mbean, name, valueP );
}
return JK_OK;
}
1.3 +28 -0 jakarta-tomcat-connectors/jk/native2/common/jk_channel.c
Index: jk_channel.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- jk_channel.c 28 May 2002 22:40:25 - 1.2
+++ jk_channel.c 30 May 2002 18:05:08 - 1.3
@@ -69,6 +69,32 @@
#include string.h
#include jk_registry.h
+/** Common attributes for all channels
+ */
+int JK_METHOD jk2_channel_setAttribute(jk_env_t *env,
+ jk_bean_t *mbean,
+ char *name, void *valueP)
+{
+jk_channel_t *ch=(jk_channel_t *)mbean-object;
+char *value=valueP;
+
+if( strcmp( debug, name ) == 0 ) {
+ch-mbean-debug=atoi( value );
+} else if( strcmp( disabled, name ) == 0 ) {
+ch-mbean-disabled=atoi( value );
+if( ch-worker!=NULL)
+ch-worker-mbean-disabled=ch-mbean-disabled;
+} else {
+ if( ch-worker!=NULL ) {
+return ch-worker-mbean-setAttribute( env, ch-worker-mbean, name,
valueP );
+}
+return JK_ERR;
+}
+return JK_OK;
+}
+
+
+
/** Called by java ( local or remote ).
*/
int JK_METHOD jk2_channel_invoke(jk_env_t *env, jk_bean_t *bean, jk_endpoint_t *ep,
int code,
@@ -101,6 +127,8 @@
env-l-jkLog(env, env-l, JK_LOG_INFO, ch.recv()\n);
if( ch-recv != NULL )
rc=ch-recv(env, ch, ep, msg);
+if( rc==JK_OK )
+return JK_INVOKE_WITH_RESPONSE;
return rc;
}
case CH_WRITE: {
1.24 +2 -14 jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c
Index: jk_channel_jni.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_jni.c,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- jk_channel_jni.c 27 May 2002 15:54:44 - 1.23
+++ jk_channel_jni.c 30 May 2002 18:05:08 - 1.24
@@ -106,19 +106,6 @@
-static int JK_METHOD jk2_channel_jni_setAttribute(jk_env_t *env,
- jk_bean_t *mbean,
- char *name, void *valueP)
-{
-jk_channel_t *ch=(jk_channel_t *)mbean-object;
-char *value=valueP;
-
-if( ch-worker!=NULL ) {
-return ch-worker-mbean-setAttribute( env, ch-worker-mbean, name,
valueP );
-}
-return JK_OK;
-}
-
static int JK_METHOD jk2_channel_jni_init(jk_env_t *env,
jk_bean_t *jniWB)
{
@@ -553,7 +540,8 @@
sizeof(jk_channel_jni_private_t));
ch-is_stream=JK_FALSE;
-result-setAttribute= jk2_channel_jni_setAttribute;
+/* No special attribute */
+result-setAttribute= jk2_channel_setAttribute;
ch-mbean=result;
result-object= ch;
result-init= jk2_channel_jni_init;
1.30 +1 -4 jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c
Index: jk_channel_socket.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_channel_socket.c,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- jk_channel_socket.c 26
cvs commit: jakarta-tomcat-connectors/jk/native2/jni jk_jni_aprImpl.c
costin 02/05/30 11:08:48
Modified:jk/native2/jni jk_jni_aprImpl.c
Log:
Added a flag to select the byte[] access mechanism.
getArrayElements is the fastest - if pinning is supported by the VM. Aparently
JDK1.4 doesn't pin, so the performance will go down.
getArrayRegion works well on all VMs, so it is the default.
The third option will work only on JDK1.4, with direct buffers ( it'll probably have
the same performance with getArrayElements with pinning ). For this
to work we need to implemnet a direct buffer version for ByteChunk and
MsgAjp.
Revision ChangesPath
1.29 +63 -26jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c
Index: jk_jni_aprImpl.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/jni/jk_jni_aprImpl.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- jk_jni_aprImpl.c 29 May 2002 17:51:23 - 1.28
+++ jk_jni_aprImpl.c 30 May 2002 18:08:48 - 1.29
@@ -100,6 +100,18 @@
static jk_workerEnv_t *workerEnv;
static int jniDebug=0;
+#define JK_GET_REGION 1
+#define JK_GET_BYTE_ARRAY_ELEMENTS 2
+#define JK_DIRECT_BUFFER_NIO 3
+
+static int arrayAccessMethod=JK_GET_REGION;
+
+JNIEXPORT void JNICALL
+Java_org_apache_jk_apr_AprImpl_setArrayAccessMode(JNIEnv *jniEnv, jobject _jthis,
jint mode)
+{
+arrayAccessMethod=mode;
+}
+
/* Apr initialization and pools */
JNIEXPORT jint JNICALL
@@ -527,26 +539,27 @@
return JK_ERR;
}
-nbuf = (*jniEnv)-GetByteArrayElements(jniEnv, data, iscopy);
-
-if( iscopy )
-env-l-jkLog(env, env-l, JK_LOG_INFO,
- aprImpl.jkInvoke() get java bytes iscopy %d\n, iscopy);
-
-if(nbuf==NULL) {
-env-l-jkLog(env, env-l, JK_LOG_ERROR,
- jkInvoke() NullPointerException 2\n);
- return -1;
-}
-
-if( raw==0 ) {
-ep-reply-reset(env, ep-reply);
+if( arrayAccessMethod == JK_GET_BYTE_ARRAY_ELEMENTS ) {
+nbuf = (*jniEnv)-GetByteArrayElements(jniEnv, data, iscopy);
+if( iscopy )
+env-l-jkLog(env, env-l, JK_LOG_INFO,
+ aprImpl.jkInvoke() get java bytes iscopy %d\n, iscopy);
+
+if(nbuf==NULL) {
+env-l-jkLog(env, env-l, JK_LOG_ERROR,
+ jkInvoke() NullPointerException 2\n);
+return -1;
+}
+if( raw==0 ) {
+ep-reply-reset(env, ep-reply);
+}
+
+oldBuf=ep-reply-buf;
+ep-reply-buf = nbuf;
+} else if ( arrayAccessMethod == JK_GET_REGION ) {
+(*jniEnv)-GetByteArrayRegion( jniEnv, data, off, len, ep-reply-buf );
}
-
-//memcpy( ep-reply-buf, nbuf , len );
-oldBuf=ep-reply-buf;
-ep-reply-buf = nbuf;
-
+
if( raw == 0 ) {
rc=ep-reply-checkHeader( env, ep-reply, ep );
@@ -565,9 +578,10 @@
return JK_ERR;
}
-env-l-jkLog(env, env-l, JK_LOG_DEBUG,
- jkInvoke() component dispatch %d %d %p\n, rc, code,
bean-invoke);
-
+if( bean-debug 0 )
+env-l-jkLog(env, env-l, JK_LOG_INFO,
+ jkInvoke() component dispatch %d %d %p\n, rc, code,
bean-invoke);
+
if( bean-invoke != NULL ) {
rc=bean-invoke( env, bean, ep, code, ep-reply, raw );
} else {
@@ -575,12 +589,35 @@
locate a handler. Deprecated, use the invoke() method ! */
rc=workerEnv-dispatch( env, workerEnv, target, ep, code, ep-reply );
}
-/* XXX Copy back the response, if any */
-
-(*jniEnv)-ReleaseByteArrayElements(jniEnv, data, nbuf, 0);
-ep-reply-buf=oldBuf;
+/* Copy back the response, if any */
+if( arrayAccessMethod == JK_GET_BYTE_ARRAY_ELEMENTS ) {
+if( rc == JK_INVOKE_WITH_RESPONSE ) {
+(*jniEnv)-ReleaseByteArrayElements(jniEnv, data, nbuf, JNI_ABORT );
+rc=JK_OK;
+} else {
+(*jniEnv)-ReleaseByteArrayElements(jniEnv, data, nbuf, 0);
+}
+ep-reply-buf=oldBuf;
+} else if ( arrayAccessMethod == JK_GET_REGION ) {
+if( rc == JK_INVOKE_WITH_RESPONSE ) {
+/* env-l-jkLog(env, env-l, JK_LOG_INFO, */
+/*jkInvoke() release %d %d %p\n, */
+/*ep-reply-pos, ep-reply-len , ep-reply-buf ); */
+(*jniEnv)-SetByteArrayRegion( jniEnv, data, 0, ep-reply-len + 4 ,
ep-reply-buf );
+rc=JK_OK;
+}
+}
+
+if( (*jniEnv)-ExceptionCheck( jniEnv ) ) {
+env-l-jkLog(env, env-l, JK_LOG_INFO,
+ jkInvoke()
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_config.c
costin 02/05/30 11:20:49
Modified:jk/native2/common jk_config.c
Log:
Pass the disabled and debug attributes to the component.
Revision ChangesPath
1.24 +24 -7 jakarta-tomcat-connectors/jk/native2/common/jk_config.c
Index: jk_config.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_config.c,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- jk_config.c 29 May 2002 17:51:23 - 1.23
+++ jk_config.c 30 May 2002 18:20:49 - 1.24
@@ -58,7 +58,7 @@
/***
* Description: General purpose config object *
* Author: Gal Shachor [EMAIL PROTECTED] *
- * Version: $Revision: 1.23 $ *
+ * Version: $Revision: 1.24 $ *
***/
#include jk_global.h
@@ -262,9 +262,11 @@
} else {
cfg-map-put( env, cfg-map, pname, val, NULL );
}
-
-/* env-l-jkLog( env, env-l, JK_LOG_INFO, config: set %s / %s /
%s=%s\n, */
-/*mbean-name, name, pname, val); */
+
+if( cfg-mbean-debug 0 )
+env-l-jkLog( env, env-l, JK_LOG_INFO, config: set %s / %s / %p / %s =
%s\n,
+ mbean-name, name, mbean, pname, val);
+
if( strcmp( name, name ) == 0 ) {
return JK_OK;
}
@@ -274,10 +276,16 @@
}
if( strcmp( name, debug ) == 0 ) {
mbean-debug=atoi( val );
+if(mbean-setAttribute) {
+mbean-setAttribute( env, mbean, name, val );
+}
return JK_OK;
}
if( strcmp( name, disabled ) == 0 ) {
mbean-disabled=atoi( val );
+if(mbean-setAttribute) {
+mbean-setAttribute( env, mbean, name, val );
+}
return JK_OK;
}
if( strcmp( name, info ) == 0 ) {
@@ -460,6 +468,10 @@
int ver;
char *verString;
+if( cfg-mbean-debug 5 )
+env-l-jkLog(env, env-l, JK_LOG_INFO,
+ config.setConfig(): process %s\n, name );
+
bean=env-getBean( env, name );
if( bean==NULL ) {
if( cfg-mbean-debug 0 ) {
@@ -530,8 +542,13 @@
return JK_ERR;
}
-if( !firstTime statbuf.st_mtime cfg-mtime )
+if( !firstTime statbuf.st_mtime cfg-mtime ) {
+if( cfg-mbean-debug 0 )
+env-l-jkLog(env, env-l, JK_LOG_ERROR,
+ config.update(): No reload needed %s %ld %ld\n,
cfg-file,
+ cfg-mtime, statbuf.st_mtime );
return JK_OK;
+}
JK_ENTER_CS(cfg-cs, csOk);
@@ -589,9 +606,9 @@
static int jk2_config_update(jk_env_t *env,
- jk_config_t *cfg, int *didReload)
+ jk_config_t *cfg, int *didReload)
{
- return jk2_config_readFile( env, cfg, didReload, JK_FALSE );
+return jk2_config_readFile( env, cfg, didReload, JK_FALSE );
}
/** Set a property for this config object
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/common jk_workerEnv.c jk_worker_ajp13.c
costin 02/05/30 11:24:10
Modified:jk/native2/common jk_workerEnv.c jk_worker_ajp13.c
Log:
If no explicit setAttribute( logger ) is configured, use the default
server-specific logger.
Without this apache native logger will be replaced with the file logger.
Also ( to avoid beeing acused I send too many commits ) a small fix in
ajp13 to better display the status.
Revision ChangesPath
1.49 +2 -3 jakarta-tomcat-connectors/jk/native2/common/jk_workerEnv.c
Index: jk_workerEnv.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_workerEnv.c,v
retrieving revision 1.48
retrieving revision 1.49
diff -u -r1.48 -r1.49
--- jk_workerEnv.c29 May 2002 00:40:44 - 1.48
+++ jk_workerEnv.c30 May 2002 18:24:09 - 1.49
@@ -59,7 +59,7 @@
* Description: Workers controller *
* Author: Gal Shachor [EMAIL PROTECTED] *
* Author: Henri Gomez [EMAIL PROTECTED] *
- * Version: $Revision: 1.48 $ *
+ * Version: $Revision: 1.49 $ *
***/
#include jk_env.h
@@ -695,7 +695,7 @@
ARCH, NULL );
-wEnv-logger_name = logger.file;
+wEnv-logger_name = NULL;
wEnv-was_initialized = JK_FALSE;
wEnv-options = JK_OPT_FWDURIDEFAULT;
@@ -786,7 +786,6 @@
} else {
env-alias(env, shm:, shm);
wEnv-shm=(jk_shm_t *)jkb-object;
-wEnv-shm-setWorkerEnv( env, wEnv-shm, wEnv );
}
JK_INIT_CS((wEnv-cs), csOk);
1.26 +3 -3 jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c
Index: jk_worker_ajp13.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/common/jk_worker_ajp13.c,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- jk_worker_ajp13.c 23 May 2002 14:54:07 - 1.25
+++ jk_worker_ajp13.c 30 May 2002 18:24:09 - 1.26
@@ -117,12 +117,12 @@
if( worker-in_error_state )
return Y;
else
-return NULL;
+return N;
} else if (strcmp( name, graceful )==0 ) {
-if( worker-mbean-disabled )
+if( worker-mbean-disabled != 0)
return Y;
else
-return NULL;
+return N;
} else if (strcmp( name, epCount )==0 ) {
char *result;
if( worker-endpointCache==NULL ) return 0;
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: JNDI/Webapp ClassLoader Bug (ContextBindings.java), patch (?)attached
Hi Remy, Thanks for responding and thanks for adding the patch to 4.1. I do have a question for you though: Looking at the J2EE spec, I can't find anything that says applications shouldn't create ClassLoaders, although you do say it is implied. I am just wondering, where do you find this implication? I realize that most web applications probably don't need to create their own classloaders, but (I've only glanced at this part of the Cocoon code) it seems to be justified at first look in this case. Just looking for some clarification. Thanks again, David Remy Maucherat wrote: Hi, I believe I have found a bug (or a problem at least) with the way Tomcat handles associating webapp contexts to JNDI naming contexts. ContextBindings.java, which apparently handles these associations does not account for the fact that a web application may have its own ClassLoader. I am trying to use Apache Cocoon which does this. I've properly enlisted the object I want in the namespace using the server.xml file and the web.xml file. After Tomcat creates this NamingContext, it binds it to Cocoon's context in ContextBindings.java, using the current ClassLoader as a key, which happens to be Tomcat's WebAppClassLoader. Cocoon provides its own ClassLoader (because it is a rather complex beast :-), so when I try to get to my object in the namespace it can't be found (even though its parent ClassLoader is the correct WebAppClassLoader) This may or may not be appropriate, but I've found that it works for me. I've modified the following methods in ContextBindings.java: getClassLoader() getClassLoaderName() isClassLoaderBound() so that they check the hashtable for the current ClassLoader, and continue to search up the heirarchy by looking at that ClassLoader's parent -- returning success at the first match, and returning failure once it has been all the way up the heirarchy. A method I did not modify was unbindClassLoader() -- I'll leave that to further discussion because (if my solution is acceptable) I'm not sure if it is appropriate to leave it or change it. This patch is against CVS revision 1.4 of the file, which I got from the source distribution of Tomcat 4.0.4 beta 3. The J2EE ENC is, by definition, a J2EE features. Applications which would like to use it should comply with the J2EE model, which implies: - not forking threads - not creating classloaders - running inside a security manager Cocoon does not adhere to this model, and will probably have problems using the J2EE ENC in other app servers. To get around this, it would be better for Cocoon to set the webapp CL as the thread context CL during the processing of the user code. Since this patch does not seem to introduce any problems and improves robustness, I think I'll apply it to the 4.1.x codebase. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native2/include jk_channel.h
costin 02/05/30 11:27:16 Modified:jk/native2/include jk_channel.h Log: Ok, a ';' - just to get more commits. Revision ChangesPath 1.15 +1 -1 jakarta-tomcat-connectors/jk/native2/include/jk_channel.h Index: jk_channel.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native2/include/jk_channel.h,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- jk_channel.h 30 May 2002 18:03:59 - 1.14 +++ jk_channel.h 30 May 2002 18:27:16 - 1.15 @@ -169,7 +169,7 @@ struct jk_msg *msg, int raw); -int JK_METHOD jk2_channel_setAttribute(struct jk_env *env, struct jk_bean *mbean, char *name, void *valueP) +int JK_METHOD jk2_channel_setAttribute(struct jk_env *env, struct jk_bean *mbean, char *name, void *valueP); #ifdef __cplusplus } -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/realm jndiRealm.jsp
manveen 02/05/30 11:30:36
Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin
ApplicationResources_en.properties
ApplicationResources_es.properties
webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm
AddRealmAction.java EditRealmAction.java
JNDIRealmForm.java SaveJNDIRealmAction.java
webapps/admin/realm jndiRealm.jsp
Log:
Add provision to be able to set userSubtree property from the admintool.
Revision ChangesPath
1.60 +2 -1
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties
Index: ApplicationResources_en.properties
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- ApplicationResources_en.properties30 May 2002 06:23:08 - 1.59
+++ ApplicationResources_en.properties30 May 2002 18:30:35 - 1.60
@@ -221,7 +221,8 @@
realm.roleBase=Role Base Element
realm.Attribute=Role Name Attribute
realm.pattern=Role Search Pattern
-realm.search=Search Subtrees
+realm.role.subtree=Search Role Subtree
+realm.user.subtree=Search User Subtree
realm.userPassword=User Password
realm.userPattern=User Search Pattern
valve.access.properties=Access Logger Properties
1.51 +2 -1
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties
Index: ApplicationResources_es.properties
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties,v
retrieving revision 1.50
retrieving revision 1.51
diff -u -r1.50 -r1.51
--- ApplicationResources_es.properties30 May 2002 06:23:08 - 1.50
+++ ApplicationResources_es.properties30 May 2002 18:30:35 - 1.51
@@ -221,7 +221,8 @@
realm.roleBase=Elemento Bajo Del Papel
realm.Attribute=Role Name Attribute
realm.pattern=Modelo De la Busqueda Del Papel
-realm.search=Search Subtrees
+realm.role.subtree=Search Role Subtree
+realm.user.subtree=Search User Subtree
realm.userPassword=Palabra de paso Del Utilizador
realm.userPattern=User Search Pattern
valve.access.properties=Propiedades del Access Logger
1.2 +7 -6
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java
Index: AddRealmAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- AddRealmAction.java 16 Apr 2002 06:00:17 - 1.1
+++ AddRealmAction.java 30 May 2002 18:30:35 - 1.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java,v
1.1 2002/04/16 06:00:17 manveen Exp $
- * $Revision: 1.1 $
- * $Date: 2002/04/16 06:00:17 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java,v
1.2 2002/05/30 18:30:35 manveen Exp $
+ * $Revision: 1.2 $
+ * $Date: 2002/05/30 18:30:35 $
*
*
*
@@ -82,7 +82,7 @@
* The codeAction/code that sets up emAdd Realm/em transactions.
*
* @author Manveen Kaur
- * @version $Revision: 1.1 $ $Date: 2002/04/16 06:00:17 $
+ * @version $Revision: 1.2 $ $Date: 2002/05/30 18:30:35 $
*/
public class AddRealmAction extends Action {
@@ -194,8 +194,9 @@
realmFm.setRealmType(realmType);
realmFm.setDebugLvl(0);
realmFm.setDigest();
-realmFm.setRoleBase();
-realmFm.setSearch(false);
+realmFm.setRoleBase();
+realmFm.setUserSubtree(false);
+realmFm.setRoleSubtree(false);
realmFm.setRolePattern();
realmFm.setRoleAttribute();
realmFm.setRoleBase();
1.8 +8 -5
jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/EditRealmAction.java
Index: EditRealmAction.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/EditRealmAction.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
---
DO NOT REPLY [Bug 8992] - IE6/XP: Limitation of POST Area within HTTP request?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8992. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8992 IE6/XP: Limitation of POST Area within HTTP request? --- Additional Comments From [EMAIL PROTECTED] 2002-05-30 18:55 --- Some additional information regarding this defect: (1) The SocketException that was not caught, can be reproduced on a Win 2000 machine running IE5.5. (2) If a proxy is created (I wrote mine in 'C' to rule out the JVM as a potential problem area) that merely recieves the information from the browser and sends it to Tomcat, then this problem disappears. (3) Also, if you modify the OutputBuffer class in the realWriteBytes method, to include a Thread.sleep(2000), then the problem goes away (please note that you must catch an InterruptedException and that the sleep value may need to be adjusted to prevent the problem). [Note: You will need to patch tomcat_core.jar for this solution to work.] Similarly, if you log the byte array (once you translate it to a StringBuffer) that represents the response (which will dump the raw HTML to the screen), then the problem will no longer occur). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 8992] - IE6/XP: Limitation of POST Area within HTTP request?
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8992. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8992 IE6/XP: Limitation of POST Area within HTTP request? --- Additional Comments From [EMAIL PROTECTED] 2002-05-30 19:31 --- I haven't had a chance to try this myself, but I'm guessing that it is a problem with Chunked-Encoding. You should try replacing the Http10 Connector with the Coyote Connector downloadable from: http://jakarta.apache.org/builds/jakarta-tomcat- connectors/coyote/release/v1.0-rc2/ Coyote is much better at dealing with modern HTTP/1.1 browsers. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/realm jndiRealm.jsp
manveen 02/05/30 12:42:23 Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties ApplicationResources_es.properties webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm AddRealmAction.java EditRealmAction.java JNDIRealmForm.java SaveJNDIRealmAction.java webapps/admin/realm jndiRealm.jsp Log: Add the userRoleName attribute to jndirealm. Revision ChangesPath 1.61 +4 -2 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties Index: ApplicationResources_en.properties === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties,v retrieving revision 1.60 retrieving revision 1.61 diff -u -r1.60 -r1.61 --- ApplicationResources_en.properties30 May 2002 18:30:35 - 1.60 +++ ApplicationResources_en.properties30 May 2002 19:42:22 - 1.61 @@ -219,7 +219,8 @@ realm.connURL=Connection URL realm.connFactory=Context Factory realm.roleBase=Role Base Element -realm.Attribute=Role Name Attribute +realm.roleName=Role Name +realm.user.roleName=User Role Name realm.pattern=Role Search Pattern realm.role.subtree=Search Role Subtree realm.user.subtree=Search User Subtree @@ -248,7 +249,8 @@ error.connectionPassword.required=liDatabase password is required./li error.connectionURL.required=liDatabase URL is required./li error.connectionName.required=liDatabase username is required./li -error.roleAttribute.required=liRole name attribute is required./li +error.roleName.required=liRole name is required./li +error.userRoleName.required=liUser Role name is required./li error.digest.required=liDigest algorithm is required./li error.roleBase.required=liRole base element is required./li error.rolePattern.required=liRole search pattern is required./li 1.52 +4 -2 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties Index: ApplicationResources_es.properties === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_es.properties,v retrieving revision 1.51 retrieving revision 1.52 diff -u -r1.51 -r1.52 --- ApplicationResources_es.properties30 May 2002 18:30:35 - 1.51 +++ ApplicationResources_es.properties30 May 2002 19:42:23 - 1.52 @@ -219,7 +219,8 @@ realm.connURL=URL De la Conexion realm.connFactory=Fabrica Del Contexto realm.roleBase=Elemento Bajo Del Papel -realm.Attribute=Role Name Attribute +realm.roleName=Role Name +realm.user.roleName=User Role Name realm.pattern=Modelo De la Busqueda Del Papel realm.role.subtree=Search Role Subtree realm.user.subtree=Search User Subtree @@ -248,7 +249,8 @@ error.connectionPassword.required=liSe requiere la palabra de paso de la base de datos./li error.connectionURL.required=liSe requiere el URL de la base de datos./li error.connectionName.required=liSe requiere el username de la base de datos./li -error.roleAttribute.required=liSe requiere el atributo del nombre del role./li +error.roleName.required=liRole name attribute requiredo./li +error.userRoleName.required=liUser Role name attribute requiredo./li error.digest.required=liSe requiere el algoritmo del digest/li error.roleBase.required=liSe requiere el elemento bajo del papel./li error.rolePattern.required=liSe requiere el modelo de la busqueda del papel./li 1.3 +6 -5 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java Index: AddRealmAction.java === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- AddRealmAction.java 30 May 2002 18:30:35 - 1.2 +++ AddRealmAction.java 30 May 2002 19:42:23 - 1.3 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java,v 1.2 2002/05/30 18:30:35 manveen Exp $ - * $Revision: 1.2 $ - * $Date: 2002/05/30 18:30:35 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/realm/AddRealmAction.java,v 1.3 2002/05/30 19:42:23 manveen Exp $ + * $Revision: 1.3 $ + * $Date: 2002/05/30 19:42:23 $ * *
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml
manveen 02/05/30 12:43:29 Modified:catalina/src/share/org/apache/catalina/mbeans mbeans-descriptors.xml Log: add userRoleName attribute to JNDIRealm. Revision ChangesPath 1.59 +6 -1 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml Index: mbeans-descriptors.xml === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/mbeans/mbeans-descriptors.xml,v retrieving revision 1.58 retrieving revision 1.59 diff -u -r1.58 -r1.59 --- mbeans-descriptors.xml30 May 2002 17:03:01 - 1.58 +++ mbeans-descriptors.xml30 May 2002 19:43:29 - 1.59 @@ -6,7 +6,7 @@ !-- Descriptions of JMX MBeans for Catalina - $Id: mbeans-descriptors.xml,v 1.58 2002/05/30 17:03:01 manveen Exp $ + $Id: mbeans-descriptors.xml,v 1.59 2002/05/30 19:43:29 manveen Exp $ -- mbeans-descriptors @@ -1009,6 +1009,11 @@ attribute name=roleSearch description=The message format used to select roles for a user + type=java.lang.String/ + + attribute name=userRoleName + description=The name of the attribute in the user's entry containing + roles for that user type=java.lang.String/ attribute name=roleName -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: PROPOSAL: clientFlush() method
- Original Message - From: [EMAIL PROTECTED] To: List Tomcat-Dev [EMAIL PROTECTED] Sent: Thursday, May 30, 2002 10:55 AM Subject: PROPOSAL: clientFlush() method Hi, I would like to add a new method to Response. +1 clientFlush() will be called by ServletOutputStream.flush() to notify the container ( and the low level connector ) that the user has explicitely asked for the stream to be flushed. Presumably, it would need to be called by ServletWriter.flush() as well. The default impl. will be empty, and in coyote adapter we'll generate an Action.CLIENT_FLUSH that may be interpreted by the connector. This would allow the connector to increase the granularity, which in turns result in about 20% reduction in the overhead ( for ajp/socket ). This happens by allowing the use of a BufferedOutputStream on the socket - the packets to send the header and the first chunk and the end response messages will all be sent at once, in one write() operation instead of 3. The servlet spec allows us to do that, but we must honor the flush() requests. I'll leave the option as disabled in jk2 ( since 4.1 and the current 3.3 doesn't support this ), but an option will enable the buffered writing. Comments ? Larry, Bill ? ( I tested this with 3.3 - Remy, I suppose something similar will be done in a future release of 4.1.x, I don't want to delay the release ) Costin -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED] -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: [4.1.3] Milestone available for testing
jean-frederic clere said, I am not able to get the administration tool working (like if the role manager would not be enough to use it (403 and 404 - /admin/j_security_check). I ran into this error for the same reason, the admin role was not defined in the tomcat-users.xml database. Since tomcat has no admin/manage role when shipped, a lot of people are going to run into this head on. It would be nice if the error message more gently pushed the user in the right direction, like No 'admin' role yet defined or user with 'admin' requied to access this page or something that mentions roles. The 403 j_security_check doesnt give an immediate place to turn and resembles an installation or internal error. my $.02 bob -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/realm RealmBase.java
remm02/05/30 13:14:29 Modified:catalina/src/share/org/apache/catalina/realm RealmBase.java Log: - Throw LifecycleException instead of ISE, to be cosistent with most other components (I guess we'll harmonize all components on LE, and change the Javadoc). Revision ChangesPath 1.11 +6 -6 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/realm/RealmBase.java Index: RealmBase.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- RealmBase.java26 Feb 2002 00:49:22 - 1.10 +++ RealmBase.java30 May 2002 20:14:29 - 1.11 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v 1.10 2002/02/26 00:49:22 remm Exp $ - * $Revision: 1.10 $ - * $Date: 2002/02/26 00:49:22 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/realm/RealmBase.java,v 1.11 2002/05/30 20:14:29 remm Exp $ + * $Revision: 1.11 $ + * $Date: 2002/05/30 20:14:29 $ * * * @@ -91,7 +91,7 @@ * location) are identical to those currently supported by Tomcat 3.X. * * @author Craig R. McClanahan - * @version $Revision: 1.10 $ $Date: 2002/02/26 00:49:22 $ + * @version $Revision: 1.11 $ $Date: 2002/05/30 20:14:29 $ */ public abstract class RealmBase @@ -516,7 +516,7 @@ // Validate and update our current component state if (started) -throw new IllegalStateException +throw new LifecycleException (sm.getString(realmBase.alreadyStarted)); lifecycle.fireLifecycleEvent(START_EVENT, null); started = true; @@ -549,7 +549,7 @@ // Validate and update our current component state if (!started) -throw new IllegalStateException +throw new LifecycleException (sm.getString(realmBase.notStarted)); lifecycle.fireLifecycleEvent(STOP_EVENT, null); started = false; -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/startup HostConfig.java
remm02/05/30 15:12:28 Modified:catalina/src/share/org/apache/catalina/startup HostConfig.java Log: - Do web.xml tracking on all contexts if liveDeploy is true (as it has an extremely small performance impact). Revision ChangesPath 1.23 +4 -7 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/startup/HostConfig.java Index: HostConfig.java === RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v retrieving revision 1.22 retrieving revision 1.23 diff -u -r1.22 -r1.23 --- HostConfig.java 3 May 2002 23:19:37 - 1.22 +++ HostConfig.java 30 May 2002 22:12:28 - 1.23 @@ -1,7 +1,7 @@ /* - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v 1.22 2002/05/03 23:19:37 craigmcc Exp $ - * $Revision: 1.22 $ - * $Date: 2002/05/03 23:19:37 $ + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/startup/HostConfig.java,v 1.23 2002/05/30 22:12:28 remm Exp $ + * $Revision: 1.23 $ + * $Date: 2002/05/30 22:12:28 $ * * * @@ -102,7 +102,7 @@ * * @author Craig R. McClanahan * @author Remy Maucherat - * @version $Revision: 1.22 $ $Date: 2002/05/03 23:19:37 $ + * @version $Revision: 1.23 $ $Date: 2002/05/30 22:12:28 $ */ public class HostConfig @@ -595,9 +595,6 @@ String contextName = contextNames[i]; Context context = deployer.findDeployedApp(contextName); - -if (!context.getReloadable()) -continue; if (!(context instanceof Lifecycle)) continue; -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9531] New: - 1.0 RC2 - Exception in CoyoteResponseFacade.reset() when hitting error-page
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9531.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9531
1.0 RC2 - Exception in CoyoteResponseFacade.reset() when hitting error-page
Summary: 1.0 RC2 - Exception in CoyoteResponseFacade.reset() when
hitting error-page
Product: Tomcat 4
Version: 4.0.3 Final
Platform: PC
OS/Version: Linux
Status: NEW
Severity: Normal
Priority: Other
Component: Connector:Coyote HTTP/1.1
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Coyote Connector 1.0 RC2
I'm getting an IllegalStateException when a servlet of mine throws an exception
that should forward me to an error page. The exception is on line 251 of
CoyoteResponseFacade.java:
248 public void reset() {
249
250 if (isCommitted())
251 throw new IllegalStateException
252 (/*sm.getString(responseBase.reset.ise)*/);
253 remm 1.1
254 response.reset();
255
256 }
Here's the portion of the web.xml for my webapp that adds the error-page:
error-page
exception-typemy.package.web.SessionTimeoutException/exception-type
location/errors/sessiontimeout.jsp/location
/error-page
I'll attach a stack trace as a separate text file.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9531] - 1.0 RC2 - Exception in CoyoteResponseFacade.reset() when hitting error-page
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9531. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9531 1.0 RC2 - Exception in CoyoteResponseFacade.reset() when hitting error-page --- Additional Comments From [EMAIL PROTECTED] 2002-05-30 22:31 --- Created an attachment (id=1980) Stack trace from original exception up to the IllegalStateException inside the connector -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties
manveen 02/05/30 16:29:32 Modified:webapps/admin/WEB-INF/classes/org/apache/webapp/admin ApplicationResources_en.properties Log: missing / in /li. Revision ChangesPath 1.62 +1 -1 jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties Index: ApplicationResources_en.properties === RCS file: /home/cvs/jakarta-tomcat-4.0/webapps/admin/WEB-INF/classes/org/apache/webapp/admin/ApplicationResources_en.properties,v retrieving revision 1.61 retrieving revision 1.62 diff -u -r1.61 -r1.62 --- ApplicationResources_en.properties30 May 2002 19:42:22 - 1.61 +++ ApplicationResources_en.properties30 May 2002 23:29:32 - 1.62 @@ -327,7 +327,7 @@ users.error.rolename.required=Role Name is required users.error.select=Error selecting managed objects users.error.token=Transaction submitted out of order -users.error.username.required=liUser Name is requiredli +users.error.username.required=liUser Name is required/li users.group.newGroup=Create New Group Properties users.group.oldGroup=Edit Existing Group Properties users.group.properties=Group Properties -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9531] - 1.0 RC2 - Exception in CoyoteResponseFacade.reset() when hitting error-page
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9531. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9531 1.0 RC2 - Exception in CoyoteResponseFacade.reset() when hitting error-page --- Additional Comments From [EMAIL PROTECTED] 2002-05-30 23:43 --- I have reservations regarding the validity of your test case, given that the functionality is tested by the tester and Watchdog. You have to make sure that the response isn't actually really committed. You'll need to attach a test case if your servlet is doing something unusual (or it's just a bug I introduced when moving the facades). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/deploy NamingResources.java
remm02/05/30 16:44:14
Modified:catalina/src/share/org/apache/catalina/deploy
NamingResources.java
Log:
- The namingResources wasn't properly reset on stop after the addition of the
entries hashtable.
- Type default to a blank string now for resource links.
Revision ChangesPath
1.7 +17 -5
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/deploy/NamingResources.java
Index: NamingResources.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/deploy/NamingResources.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- NamingResources.java 29 May 2002 18:22:41 - 1.6
+++ NamingResources.java 30 May 2002 23:44:14 - 1.7
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/deploy/NamingResources.java,v
1.6 2002/05/29 18:22:41 remm Exp $
- * $Revision: 1.6 $
- * $Date: 2002/05/29 18:22:41 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/deploy/NamingResources.java,v
1.7 2002/05/30 23:44:14 remm Exp $
+ * $Revision: 1.7 $
+ * $Date: 2002/05/30 23:44:14 $
*
*
*
@@ -76,7 +76,7 @@
* Naming Context and their associated JNDI context.
*
* @author Remy Maucherat
- * @version $Revision: 1.6 $ $Date: 2002/05/29 18:22:41 $
+ * @version $Revision: 1.7 $ $Date: 2002/05/30 23:44:14 $
*/
public final class NamingResources {
@@ -310,7 +310,7 @@
} else {
Object value = resourceLink.getType();
if (value == null) {
-value = new Integer(0);
+value = ;
}
entries.put(resourceLink.getName(), value);
}
@@ -542,6 +542,8 @@
*/
public void removeEjb(String name) {
+entries.remove(name);
+
ContextEjb ejb = null;
synchronized (ejbs) {
ejb = (ContextEjb) ejbs.remove(name);
@@ -561,6 +563,8 @@
*/
public void removeEnvironment(String name) {
+entries.remove(name);
+
ContextEnvironment environment = null;
synchronized (envs) {
environment = (ContextEnvironment) envs.remove(name);
@@ -580,6 +584,8 @@
*/
public void removeLocalEjb(String name) {
+entries.remove(name);
+
ContextLocalEjb localEjb = null;
synchronized (localEjbs) {
localEjb = (ContextLocalEjb) ejbs.remove(name);
@@ -611,6 +617,8 @@
*/
public void removeResource(String name) {
+entries.remove(name);
+
ContextResource resource = null;
synchronized (resources) {
resource = (ContextResource) resources.remove(name);
@@ -630,6 +638,8 @@
*/
public void removeResourceEnvRef(String name) {
+entries.remove(name);
+
String type = null;
synchronized (resourceEnvRefs) {
type = (String) resourceEnvRefs.remove(name);
@@ -648,6 +658,8 @@
* @param name Name of the resource link to remove
*/
public void removeResourceLink(String name) {
+
+entries.remove(name);
ContextResourceLink resourceLink = null;
synchronized (resourceLinks) {
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/naming ContextBindings.java
remm2002/05/30 19:55:21
Modified:catalina/src/share/org/apache/naming ContextBindings.java
Log:
- Make the JNDI context available from webapp created CL (as long as one
of the parents in the hierarchy is the webapp CL).
- Patch submitted by David Haraburda david-tomcat at haraburda.com
Revision ChangesPath
1.7 +31 -18
jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/ContextBindings.java
Index: ContextBindings.java
===
RCS file:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/ContextBindings.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ContextBindings.java 16 Apr 2002 00:42:10 - 1.6
+++ ContextBindings.java 31 May 2002 02:55:21 - 1.7
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/ContextBindings.java,v
1.6 2002/04/16 00:42:10 remm Exp $
- * $Revision: 1.6 $
- * $Date: 2002/04/16 00:42:10 $
+ * $Header:
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/ContextBindings.java,v
1.7 2002/05/31 02:55:21 remm Exp $
+ * $Revision: 1.7 $
+ * $Date: 2002/05/31 02:55:21 $
*
*
*
@@ -76,7 +76,7 @@
* /ul
*
* @author Remy Maucherat
- * @version $Revision: 1.6 $ $Date: 2002/04/16 00:42:10 $
+ * @version $Revision: 1.7 $ $Date: 2002/05/31 02:55:21 $
*/
public class ContextBindings {
@@ -361,12 +361,16 @@
*/
public static Context getClassLoader()
throws NamingException {
-Context context = (Context) clBindings.get
-(Thread.currentThread().getContextClassLoader());
-if (context == null)
-throw new NamingException
-(sm.getString(contextBindings.noContextBoundToCL));
-return context;
+ClassLoader cl = Thread.currentThread().getContextClassLoader();
+Context context = null;
+do {
+context = (Context) clBindings.get(cl);
+if (context != null) {
+return context;
+}
+} while ((cl = cl.getParent()) != null);
+throw new NamingException
+(sm.getString(contextBindings.noContextBoundToCL));
}
@@ -375,12 +379,16 @@
*/
static Object getClassLoaderName()
throws NamingException {
-Object name =
-clNameBindings.get(Thread.currentThread().getContextClassLoader());
-if (name == null)
-throw new NamingException
-(sm.getString(contextBindings.noContextBoundToCL));
-return name;
+ClassLoader cl = Thread.currentThread().getContextClassLoader();
+Object name = null;
+do {
+name = clNameBindings.get(cl);
+if (name != null) {
+return name;
+}
+} while ((cl = cl.getParent()) != null);
+throw new NamingException
+(sm.getString(contextBindings.noContextBoundToCL));
}
@@ -388,8 +396,13 @@
* Tests if current class loader is bound to a context.
*/
public static boolean isClassLoaderBound() {
-return (clBindings.containsKey
-(Thread.currentThread().getContextClassLoader()));
+ClassLoader cl = Thread.currentThread().getContextClassLoader();
+do {
+if (clBindings.containsKey(cl)) {
+return true;
+}
+} while ((cl = cl.getParent()) != null);
+return false;
}
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 9535] New: - There are NO downloadable connectors on the apache build site
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9535. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9535 There are NO downloadable connectors on the apache build site Summary: There are NO downloadable connectors on the apache build site Product: Tomcat 4 Version: 4.0.4 Beta 3 Platform: All URL: http://jakarta.apache.org/builds/jakarta-tomcat- connectors/webapp/release/v1.2.0/bin/linux/i386/ OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Connector:Webapp AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I spent quite a while yesterday attempting to locate the webapp connector on the download site. I spent a similar amount of time last year and never did locate mod_webapp.so. I am attempting to build a test system out of Apache 2.0.36, Tomcat 4.0.4-b3 and the latest Cocoon. It appears that Apache won't be usable until the connector is available. Your website says that it is availabel, but I can't find it. Please fix the build to provide the binary connector OR remove the indications that the binary connector is available. I know this is probably just a permissions problem but it is definitely a time-waster. Of course, once you provide the connector, people will start to while about the (lack of) accurate documentation for configuring it. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java
remm2002/05/30 22:13:13
Modified:jasper2/src/share/org/apache/jasper
EmbededServletOptions.java JspC.java Options.java
jasper2/src/share/org/apache/jasper/compiler Compiler.java
Log:
- Refactoring part 3.
- Remove outdated compiler options.
- Add new compiler option, which accepts the Ant name of the compiler.
Revision ChangesPath
1.5 +11 -41
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java
Index: EmbededServletOptions.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- EmbededServletOptions.java11 May 2002 05:00:21 - 1.4
+++ EmbededServletOptions.java31 May 2002 05:13:13 - 1.5
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
1.4 2002/05/11 05:00:21 remm Exp $
- * $Revision: 1.4 $
- * $Date: 2002/05/11 05:00:21 $
+ * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/EmbededServletOptions.java,v
1.5 2002/05/31 05:13:13 remm Exp $
+ * $Revision: 1.5 $
+ * $Date: 2002/05/31 05:13:13 $
*
*
*
@@ -145,14 +145,9 @@
public String classpath = null;
/**
- * Plugin class to use to compile JSP pages.
+ * Compiler to use.
*/
-public Class jspCompilerPlugin = null;
-
-/**
- * Path of the compiler to use for compiling JSP pages.
- */
-public String jspCompilerPath = null;
+public String compiler = null;
/**
* Cache for the TLD locations
@@ -244,19 +239,12 @@
}
/**
- * What compiler plugin should I use to compile the servlets
- * generated from JSP files?
+ * Compiler to use.
*/
-public Class getJspCompilerPlugin() {
-return jspCompilerPlugin;
+public String getCompiler() {
+return compiler;
}
-/**
- * Path of the compiler to use for compiling JSP pages.
- */
-public String getJspCompilerPath() {
-return jspCompilerPath;
-}
public TldLocationsCache getTldLocationsCache() {
return tldLocationsCache;
@@ -385,33 +373,15 @@
scratchDir.getAbsolutePath()
}, Logger.FATAL);
-String jspCompilerPath = config.getInitParameter(jspCompilerPath);
-if (jspCompilerPath != null) {
-if (new File(jspCompilerPath).exists()) {
-this.jspCompilerPath = jspCompilerPath;
-} else {
-Constants.message(jsp.warning.compiler.path.notfound,
- new Object[] { jspCompilerPath },
- Logger.FATAL);
-}
-}
-
-String jspCompilerPlugin = config.getInitParameter(jspCompilerPlugin);
-if (jspCompilerPlugin != null) {
-try {
-this.jspCompilerPlugin = Class.forName(jspCompilerPlugin);
-} catch (ClassNotFoundException cnfe) {
-Constants.message(jsp.warning.compiler.class.notfound,
- new Object[] { jspCompilerPlugin },
- Logger.FATAL);
-}
-}
+this.compiler = config.getInitParameter(compiler);
this.javaEncoding = config.getInitParameter(javaEncoding);
// Setup the global Tag Libraries location cache for this
// web-application.
tldLocationsCache = new TldLocationsCache(context);
+
}
+
}
1.5 +11 -3
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
Index: JspC.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- JspC.java 16 May 2002 00:43:15 - 1.4
+++ JspC.java 31 May 2002 05:13:13 - 1.5
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v 1.4
2002/05/16 00:43:15 kinman Exp $
- * $Revision: 1.4 $
- * $Date: 2002/05/16 00:43:15 $
+ * $Header:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v 1.5
2002/05/31 05:13:13 remm Exp $
+ * $Revision: 1.5 $
+ * $Date: 2002/05/31 05:13:13 $
*
*
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Compiler.java
But I have one question. When the dust settles will I still be able to configure and use jikes as an external JSP java source compiler? Looking at the source in Ant, I think if you put jikes as the compiler parameter, and put the Jikes executable in your path (Ant doesn't support specifying the compiler path), it should work. That's the theory; I don't know how well it works in practice ;-) Part 4 of the refactoring is removing the now useless classes and interfaces. Part 5 is making JspC work again :) Note: I noticed the Ant compiler only works with Ant 1.5, so be sure to use Ant 1.5 Beta 1. Remy -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JavaCompiler.java JikesJavaCompiler.java JspCompiler.java KjcJavaCompiler.java Mangler.java SunJavaCompiler.java
remm2002/05/30 22:56:17 Removed: jasper2/src/share/org/apache/jasper/compiler JavaCompiler.java JikesJavaCompiler.java JspCompiler.java KjcJavaCompiler.java Mangler.java SunJavaCompiler.java Log: - Refactoring part 4. - Remove uneeded classes. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
