DO NOT REPLY [Bug 25060] - Reloading context orphans currently open jndi datasource connections
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25060. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25060 Reloading context orphans currently open jndi datasource connections --- Additional Comments From [EMAIL PROTECTED] 2003-12-06 16:38 --- I have verified your bug report. If this is happening with a JNDI Named DataSource it might also be happening with other JNDI resources created. And be a source of a memory leak. Great bug report. I don't have a solution yet, but will be researching this. Thanks Wayne - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25060] - Reloading context orphans currently open jndi datasource connections
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25060. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25060 Reloading context orphans currently open jndi datasource connections --- Additional Comments From [EMAIL PROTECTED] 2003-12-06 16:47 --- I think the only clean way to fix this is to define the data source as global, and use links. There's no API in JNDI for releasing resources, so ... (and I don't want to introduce any proprietary APIs either). Maybe waiting for GC would be the solution, and maybe there's a memory leak associated with the JNDI context. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs/config resources.xml
remm2003/12/06 09:53:43 Modified:webapps/docs/config resources.xml Log: - The Context (or DefaultContext) element should now be used to configure the file based resources (which is the default). Other types of resources can have their properties set through this element. Revision ChangesPath 1.6 +2 -49 jakarta-tomcat-catalina/webapps/docs/config/resources.xml Index: resources.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/resources.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- resources.xml 30 Nov 2003 14:35:45 - 1.5 +++ resources.xml 6 Dec 2003 17:53:43 - 1.6 @@ -70,55 +70,8 @@ subsection name=Standard Implementation pThe standard implementation of strongResources/strong is -strongorg.apache.naming.resources.FileDirContext/strong. -It supports the following additional attributes (in addition to the -common attributes listed above):/p - -attributes - - attribute name=allowLinking required=false -pIf the value of this flag is codetrue/code, symlinks will be -allowed inside the web application, pointing to resources outside the -web application base path. If not specified, the default value -of the flag is codefalse/code./p -pbNOTE: This flag MUST NOT be set to true on the Windows platform -(or any other OS which does not have a case sensitive filesystem), -as it will disable case sensitivity checks, allowing JSP source code -disclosure, among other security problems./b/p - /attribute - - attribute name=cached required=false -pThis boolean flag indicates if the resources should be cached. It -defaults to codetrue/code./p - /attribute - - attribute name=cacheMaxSize required=false -pMaximum size in kilobytes (KB) of the cache associated with -the resources, if cached is set to true. It defaults -to code10240/code (10 megabytes)./p - /attribute - - attribute name=cacheTTL required=false -pAmount of time in milliseconds between cache entries revalidation. -If not specified, the default value is code5000/code -(5 seconds)./p - /attribute - - attribute name=caseSensitive required=false -pThis boolean flag toggles case sensitivity checks. -Defaults to codetrue/code./p -pbNOTE: This flag MUST NOT be set to false on the Windows platform -(or any other OS which does not have a case sensitive filesystem), -as it will disable case sensitivity checks, allowing JSP source code -disclosure, among other security problems./b/p - /attribute - - attribute name=docBase required=false -pThis is the functional equivalent to the emDocument Base/em -of a a href=context.htmlContext/a./p - /attribute - -/attributes +strongorg.apache.naming.resources.FileDirContext/strong, and +is configured by its parent Context element./p /subsection - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-catalina/webapps/docs manager-howto.xml
remm2003/12/06 09:55:08 Modified:webapps/docs manager-howto.xml Log: - There's no pause attribute (this was a good bad idea). Sorry for the trouble. - Bug 25119. Revision ChangesPath 1.11 +0 -4 jakarta-tomcat-catalina/webapps/docs/manager-howto.xml Index: manager-howto.xml === RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/manager-howto.xml,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- manager-howto.xml 13 Oct 2003 13:21:20 - 1.10 +++ manager-howto.xml 6 Dec 2003 17:55:08 - 1.11 @@ -298,10 +298,6 @@ licodetag/code: Specifying a tag name, this allows associating the deployed webapp with a version number. The application version can be later redeployed when needed using only the tag./li -licodepause/code: Pause webapps so that incoming connections are not lost -during an application update. This option is only used with the update -parameter, and its default is false. Note that a large amount of request -processors may be used if the amount of incoming requests is large./li /ul /p - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25119] - pause attribute not supported by catalina ant deploy task
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25119. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25119 pause attribute not supported by catalina ant deploy task [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-12-06 17:56 --- Fixed. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25013] - Symbolic link related troubles should be logged as such.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25013. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25013 Symbolic link related troubles should be logged as such. --- Additional Comments From [EMAIL PROTECTED] 2003-12-06 17:58 --- This seems like a good idea, and a specific message should be logged in this case. (actually, you should have had this idea two weeks ago) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 6582] - Sample code does not match behavior
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6582. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6582 Sample code does not match behavior --- Additional Comments From [EMAIL PROTECTED] 2003-12-06 19:23 --- Created an attachment (id=9425) Patch for TC4 to fix this bug - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 6582] - Sample code does not match behavior
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6582. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=6582 Sample code does not match behavior --- Additional Comments From [EMAIL PROTECTED] 2003-12-06 19:23 --- Created an attachment (id=9426) Patch for TC5 to fix this bug - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] Servlet Examples
Noticed this while looking at the examples. Worth making sure we get this sort of thing right. Mark Index: webapps/examples/servlets/helloworld.html === RCS file: /home/cvspublic/jakarta-tomcat-4.0/webapps/examples/servlets/helloworld.html,v retrieving revision 1.1 diff -u -r1.1 helloworld.html --- webapps/examples/servlets/helloworld.html 17 Aug 2000 00:58:20 - 1.1 +++ webapps/examples/servlets/helloworld.html 6 Dec 2003 18:47:56 - @@ -21,7 +21,6 @@ response.setContentType(quot;font color=#009900text/html/fontquot;); PrintWriter out = response.getWriter(); out.println(quot;font color=#009900lt;htmlgt;/fontquot;); -out.println(quot;font color=#009900lt;bodygt;/fontquot;); out.println(quot;font color=#009900lt;headgt;/fontquot;); out.println(quot;font color=#009900lt;titlegt;Hello World!lt;/titlegt;/fontquot;); out.println(quot;font color=#009900lt;/headgt;/fontquot;); Index: jsr154/examples/helloworld.html === RCS file: /home/cvspublic/jakarta-servletapi-5/jsr154/examples/helloworld.html,v retrieving revision 1.2 diff -u -r1.2 helloworld.html --- jsr154/examples/helloworld.html 29 Oct 2002 17:42:57 - 1.2 +++ jsr154/examples/helloworld.html 6 Dec 2003 18:49:44 - @@ -21,7 +21,6 @@ response.setContentType(quot;font color=#009900text/html/fontquot;); PrintWriter out = response.getWriter(); out.println(quot;font color=#009900lt;htmlgt;/fontquot;); -out.println(quot;font color=#009900lt;bodygt;/fontquot;); out.println(quot;font color=#009900lt;headgt;/fontquot;); out.println(quot;font color=#009900lt;titlegt;Hello World!lt;/titlegt;/fontquot;); out.println(quot;font color=#009900lt;/headgt;/fontquot;); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25263] New: - Incorrect SMAP generated for JSP
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25263.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25263
Incorrect SMAP generated for JSP
Summary: Incorrect SMAP generated for JSP
Product: Tomcat 5
Version: 5.0.16
Platform: Other
OS/Version: Windows NT/2K
Status: NEW
Severity: Normal
Priority: Other
Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Below is an example SMAP, JSP, and generated Java file that demonstrate an
error in the SMAP generation.
The test JSP (with line numbers) looks like this:
01 !DOCTYPE HTML PUBLIC -//W3C//DTD HTML 4.01 Transitional//EN
02 %@ page language=java import=java.lang.*,java.util.* %
03 %
04 String path = request.getContextPath();
05 String basePath = http://+request.getServerName()
06 +:+request.getServerPort()+path+/;
07 %
08 HTML
09HEAD
10 BASE HREF=%=basePath%
11 TITLEMy JSP 'TestJSP.jsp' starting page/TITLE
12/HEAD
13
14 BODY
15%
16 Date date = new Date();
17 out.println(Current time is: + date);
18 out.println(. );
19 date = new Date();
20 out.println(Now the time is + date);
21 out.println(. );
22%
23BRThis is my test JSP page. BR
24 /BODY
25 /HTML
The SMAP generated is as follows:
SMAP
TomcatTestJSP_jsp.java
JSP
*S JSP
*F
+ 0 TomcatTestJSP.jsp
TomcatTestJSP.jsp
*L
1,3:42
4,3:44
6,4:47
9:48,2
10,5:50
15,7:51
21,5:58
*E
The mapping of 10,5:50 is erroneous. It is both the wrong area within the
generated java file, and it overlaps with the subsequent correct mapping of the
embedded java scriptlet at 15,7:51.
Here's the generated java file to which I added line number comments for
illustration:
package org.apache.jsp;
import javax.servlet.*;
import javax.servlet.http.*;
import javax.servlet.jsp.*;
import java.lang.*;
import java.util.*;
public final class TomcatTestJSP_jsp extends
org.apache.jasper.runtime.HttpJspBase
implements org.apache.jasper.runtime.JspSourceDependent {
private static java.util.Vector _jspx_dependants;
public java.util.List getDependants() {
return _jspx_dependants;
}
public void _jspService(HttpServletRequest request, HttpServletResponse
response)
throws java.io.IOException, ServletException {
JspFactory _jspxFactory = null;
PageContext pageContext = null;
HttpSession session = null;
ServletContext application = null;
ServletConfig config = null;
JspWriter out = null;
Object page = this;
JspWriter _jspx_out = null;
try {
_jspxFactory = JspFactory.getDefaultFactory();
response.setContentType(text/html);
pageContext = _jspxFactory.getPageContext(this, request, response,
null, true, 8192, true);
application = pageContext.getServletContext();
config = pageContext.getServletConfig();
session = pageContext.getSession();
out = pageContext.getOut();
_jspx_out = out;
out.write(!DOCTYPE HTML PUBLIC \-//W3C//DTD HTML 4.01
Transitional//EN\\r\n\r\n); // line number 42
String path = request.getContextPath(); // line 44
String basePath = http://+request.getServerName()+:+request.getServerPort()
+path+/; // line 45
out.write(\r\nHTML\r\n\tHEAD\r\n\t\tBASE HREF=\); //line 47
out.print(basePath); // line 48
out.write(\\t\t\r\n\t\tTITLEMy JSP 'TestJSP.jsp' starting
page/TITLE\r\n\t/HEAD\r\n\r\n\tBODY\r\n\t ); // line 49
Date date = new Date(); // line 51
out.println(Current time is: + date); // line 52
out.println(. ); // line 53
date = new Date(); // line 54
out.println(Now the time is + date); // line 55
out.println(. ); // line 56
out.write(\r\n\t\tBRThis is my test JSP page.
BR\r\n\t/BODY\r\n/HTML\r\n);
} catch (Throwable t) {
if (!(t instanceof SkipPageException)){
out = _jspx_out;
if (out != null out.getBufferSize() != 0)
out.clearBuffer();
if (pageContext != null) pageContext.handlePageException(t);
}
} finally {
if (_jspxFactory != null) _jspxFactory.releasePageContext(pageContext);
}
}
}
From this code, the lines 10-14 in the JSP should be mapped only to line 49
(like 10,5:49,0), but not to 50-54 as the 10,5:50 mapping dictates. This is
certainly not the only time we've seen problems with this latest release, but
this is one of the smallest test cases we could produce.
For the record, the mappings in the previous version we tested, 5.0.12 were
correct and are reproduced below.
SMAP
TomcatTestJSP_jsp.java
JSP
*S JSP
*F
+ 0 /TomcatTestJSP.jsp
jakarta pmc
A small administrative issue - people are looking to expand jakarta PMC with more members, with the goal of getting most active jakarta committers in PMC. I haven't seen too many new nominees from tomcat - I think it would be good if all the people who have been in tomcat for a while and are still active in tomcat to also join the jakarta pmc. Please send an email to one of the people who are in the pmc, so you are included in the next round ( i.e. Remy, Larry, Henri, me, etc ). For example, the httpd PMC includes all httpd committers ( maybe with few exceptions ). Jakarta has been a bit abnormal by having a much smaller PMC, but this is beeing fixed :-) Costin - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
