Re: Your music

[stefano]

Your document is attached.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Hi

[mikeb]

--  Virus Warning Message (on uusnwa0n)

Found virus WORM_NETSKY.Z in file Important.txt 

.exe (in Important.zip)
The file is deleted.

-
Important document!


--  Virus Warning Message (on uusnwa0n)

Important.zip is removed from here because it contains a virus.

-
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml realm-howto.xml

[markt]

markt   2004/11/22 14:42:30

  Modified:catalina/src/share/org/apache/catalina/realm JDBCRealm.java
LocalStrings.properties
   webapps/docs changelog.xml realm-howto.xml
  Log:
  Add support for DIGEST authentication to the JDBCRealm
  
  Revision  ChangesPath
  1.9   +126 -69   
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JDBCRealm.java
  
  Index: JDBCRealm.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/realm/JDBCRealm.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- JDBCRealm.java23 Jun 2004 13:51:37 -  1.8
  +++ JDBCRealm.java22 Nov 2004 22:42:28 -  1.9
  @@ -385,81 +385,44 @@
* @param username Username of the Principal to look up
* @param credentials Password or other credentials to use in
*  authenticating this username
  - *
  - * @exception SQLException if a database error occurs
*/
   public synchronized Principal authenticate(Connection dbConnection,
  String username,
  -   String credentials)
  -throws SQLException {
  -
  -// Look up the user's credentials
  -String dbCredentials = null;
  -PreparedStatement stmt = null;
  -ResultSet rs = null;
  -
  -try {
  -stmt = credentials(dbConnection, username);
  -rs = stmt.executeQuery();
  -
  -if (rs.next()) {
  -dbCredentials = rs.getString(1);
  -}
  -rs.close();
  -rs = null;
  -if (dbCredentials == null) {
  -return (null);
  -}
  -
  -dbCredentials = dbCredentials.trim();
  +   String credentials) {
   
  +// No user - can't possibly authenticate
  +if (username == null) {
  +return (null);
  +}
   
  -// Validate the user's credentials
  -boolean validated = false;
  -if (hasMessageDigest()) {
  -// Hex hashes should be compared case-insensitive
  -validated = 
(digest(credentials).equalsIgnoreCase(dbCredentials));
  -} else {
  -validated = (digest(credentials).equals(dbCredentials));
  -}
  -
  -if (validated) {
  -if (container.getLogger().isTraceEnabled())
  -
container.getLogger().trace(sm.getString("jdbcRealm.authenticateSuccess",
  - username));
  -} else {
  -if (container.getLogger().isTraceEnabled())
  -
container.getLogger().trace(sm.getString("jdbcRealm.authenticateFailure",
  - username));
  -return (null);
  -}
  +// Look up the user's credentials
  +String dbCredentials = getPassword(username);
   
  -// Accumulate the user's roles
  -ArrayList roleList = new ArrayList();
  -stmt = roles(dbConnection, username);
  -rs = stmt.executeQuery();
  -while (rs.next()) {
  -String role = rs.getString(1);
  -if (null!=role) {
  -roleList.add(role.trim());
  -}
  -}
  -rs.close();
  -rs = null;
  +// Validate the user's credentials
  +boolean validated = false;
  +if (hasMessageDigest()) {
  +// Hex hashes should be compared case-insensitive
  +validated = 
(digest(credentials).equalsIgnoreCase(dbCredentials));
  +} else {
  +validated = (digest(credentials).equals(dbCredentials));
  +}
   
  -// Create and return a suitable Principal for this user
  -return (new GenericPrincipal(this, username, credentials, 
roleList));
  -} finally {
  -if (rs!=null) {
  -try {
  -rs.close();
  -} catch(SQLException e) {
  -
container.getLogger().warn(sm.getString("jdbcRealm.abnormalCloseResultSet"));
  -}
  -}
  -dbConnection.commit();
  +if (validated) {
  +if (container.getLogger().isTraceEnabled())
  +
container.getLogger().trace(sm.getString("jdbcRealm.authenticateSuccess",
  + username));
  +} else {
  +if (container.getLogger().isTraceEnabled())
  +
container.getLogger().trace(sm.getString("jdbcRealm.authenticateFailure",
  + username));
  +return (null)

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java mbeans-descriptors.xml

[Remy Maucherat]

Jean-Francois Arcand wrote:
Remy Maucherat wrote:
Jean-Francois Arcand wrote:
Yes, I can explore that. I will re-add the writerThread for now 
since the current implementation doesn't work since the byteBuffer 
will never be flushed. This is temporary. Again, consider this valve 
as exploration.

I do agree to some extent with the rest (except your benchmark 
results, which look wrong)

Well, I do trust my performance team :-)
Sounds fair :) It doesn't convince me though, as the two implementations 
do more or less the same thing (unless on the VM and platform they 
tested on, classic IO sucks and NIO is more optimized - not the case on 
Window$, from what I can see) ;)

> Fine. I will remove it.
I'm ok with that, since if you leave it around, I would start hacking it ;)
The background thread per component was (IMO) the biggest design mistake 
in 4.x.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31267] - RequestUtil.parseCookieHeader not fully RFC 2109 compliant

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31267


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 22:42 ---
Please note that (as of Tomcat 5.0.29 and 5.5.4), even though the 
parseCookieHeader method may be deficient as you describe, it's not used 
anywhere except the WARP connector which has long been deprecated and 
unsupported.

The relevant code is now in org.apache.tomcat.util.http.Cookies, part of the 
jakarta-tomcat-connectors CVS module.  Upon cursory inspection, it seems to 
handle the $ as a special character approrpiately, and be generally compliant 
with RFC2109.  So I'm closing this issue.

If you'd like to evaluate the util.http.Cookies class, please go ahead -- 
that'd be great.  If you then find a place where it doesn't handle RFC2109 
well, feel free to reopen this issue with specific information.  Thank you.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 32317] - Making mod_jk replication aware (Clustering Support)

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32317


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Component|Native:JK   |Catalina:Cluster




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs/config http.xml

[yoavs]

yoavs   2004/11/22 12:18:30

  Modified:webapps/docs/config http.xml
  Log:
  Bugzilla 30048: minor doc patch.
  
  Revision  ChangesPath
  1.20  +1 -1  jakarta-tomcat-catalina/webapps/docs/config/http.xml
  
  Index: http.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/http.xml,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- http.xml  16 Oct 2004 09:20:06 -  1.19
  +++ http.xml  22 Nov 2004 20:18:30 -  1.20
  @@ -186,7 +186,7 @@
 2048 bytes will be provided.
   
   
  -
  +
 The value is a comma separated list of MIME types for which HTTP
 compression may be used.
 The default value is text/html,text/xml,text/plain.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30048] - Setting compressableMimeTypes is ignored.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30048


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30048] - Setting compressableMimeTypes is ignored.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30048





--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 21:17 ---
Docs updated in CVS to reflect correct spelling.  Thanks for pointing this out.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs/config http.xml

[yoavs]

yoavs   2004/11/22 12:12:08

  Modified:webapps/docs/config Tag: TOMCAT_5_0 http.xml
  Log:
  Bugzilla 30048: minor (as minor as they get, one letter ;)) doc patch.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.10.2.2  +1 -1  jakarta-tomcat-catalina/webapps/docs/config/http.xml
  
  Index: http.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/config/http.xml,v
  retrieving revision 1.10.2.1
  retrieving revision 1.10.2.2
  diff -u -r1.10.2.1 -r1.10.2.2
  --- http.xml  21 Aug 2004 15:50:12 -  1.10.2.1
  +++ http.xml  22 Nov 2004 20:12:08 -  1.10.2.2
  @@ -151,7 +151,7 @@
 2048 bytes will be provided.
   
   
  -
  +
 The value is a comma separated list of MIME types for which HTTP
 compression may be used.
 The default value is text/html,text/xml,text/plain.
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

[markt]

markt   2004/11/22 11:37:06

  Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
  Log:
  Port Remy's fix for ensuring mime boundaries start with a new line
  
  Revision  ChangesPath
  1.64  +6 -2  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
  
  Index: DefaultServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
  retrieving revision 1.63
  retrieving revision 1.64
  diff -u -r1.63 -r1.64
  --- DefaultServlet.java   26 Aug 2004 21:38:13 -  1.63
  +++ DefaultServlet.java   22 Nov 2004 19:37:06 -  1.64
  @@ -1241,7 +1241,7 @@
   
   // Parsing the range list
   while (commaTokenizer.hasMoreTokens()) {
  -String rangeDefinition = commaTokenizer.nextToken();
  +String rangeDefinition = commaTokenizer.nextToken().trim();
   
   Range currentRange = new Range();
   currentRange.length = fileLength;
  @@ -1851,6 +1851,7 @@
   Range currentRange = (Range) ranges.nextElement();
   
   // Writing MIME header.
  +ostream.println();
   ostream.println("--" + mimeSeparation);
   if (contentType != null)
   ostream.println("Content-Type: " + contentType);
  @@ -1871,6 +1872,7 @@
   
   }
   
  +ostream.println();
   ostream.print("--" + mimeSeparation + "--");
   
   // Rethrow any exception that has occurred
  @@ -1905,6 +1907,7 @@
   Range currentRange = (Range) ranges.nextElement();
   
   // Writing MIME header.
  +writer.println();
   writer.println("--" + mimeSeparation);
   if (contentType != null)
   writer.println("Content-Type: " + contentType);
  @@ -1925,6 +1928,7 @@
   
   }
   
  +writer.println();
   writer.print("--" + mimeSeparation + "--");
   
   // Rethrow any exception that has occurred
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java mbeans-descriptors.xml

[Jean-Francois Arcand]

Remy Maucherat wrote:
Jean-Francois Arcand wrote:
Yes, I can explore that. I will re-add the writerThread for now since 
the current implementation doesn't work since the byteBuffer will 
never be flushed. This is temporary. Again, consider this valve as 
exploration.

I do agree to some extent with the rest (except your benchmark results, 
which look wrong)
Well, I do trust my performance team :-)
, but I cannot agree to this. If you want to play with
something on your own, then don't contribute it or place it in an 
experimental folder.
Fine. I will remove it.
-- Jeanfrancois

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/xdocs/install apache2.xml

[jfclere]

jfclere 2004/11/22 09:36:03

  Modified:jk/xdocs/install apache2.xml
  Log:
  EAPI is only for Apache-1.3.
  
  Revision  ChangesPath
  1.2   +0 -5  jakarta-tomcat-connectors/jk/xdocs/install/apache2.xml
  
  Index: apache2.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/install/apache2.xml,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- apache2.xml   18 Nov 2004 18:31:37 -  1.1
  +++ apache2.xml   22 Nov 2004 17:36:03 -  1.2
  @@ -82,11 +82,6 @@
   DIR is something like: /home/apache/apache_1.3.33
   It builds a static Apache module.
 
  -  
  -  This parameter is needed when using Apache-1.3 and mod_ssl, otherwise 
you will get the error message:
  -"this module might crash under EAPI!" when loading mod_jk.so in httpd.
  -Not needed when --with-apxs has been used.
  -  
   
   
   JNI related parameters :
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-site/xdocs index.xml

[yoavs]

yoavs   2004/11/22 10:16:26

  Modified:docs bugreport.html index.html irc.html resources.html
   xdocsindex.xml
  Log:
  Removed ApacheCon notice, updatd stable listing to show 5.5.4 instead of 
5.0.28.
  
  Revision  ChangesPath
  1.27  +0 -11 jakarta-tomcat-site/docs/bugreport.html
  
  Index: bugreport.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/bugreport.html,v
  retrieving revision 1.26
  retrieving revision 1.27
  diff -u -r1.26 -r1.27
  --- bugreport.html31 Oct 2004 23:34:11 -  1.26
  +++ bugreport.html22 Nov 2004 18:16:26 -  1.27
  @@ -41,23 +41,12 @@
   
   
   
  -
  -
  -http://ApacheCon.Com/2004/US/";>
  -http://ApacheCon.Com/2004/US/logos/logo_only.gif";
  -width="170" height="100" alt="ApacheCon!" title=
  -"Join Us At ApacheCon!"
  -border="0" />
  -
  -
  -
   
   http://jakarta.apache.org";>http://jakarta.apache.org/images/jakarta-logo.gif"; border="0"/>
   
   
   http://jakarta.apache.org/tomcat";>
   
  -
   
   
   
  
  
  
  1.72  +5 -42 jakarta-tomcat-site/docs/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/jakarta-tomcat-site/docs/index.html,v
  retrieving revision 1.71
  retrieving revision 1.72
  diff -u -r1.71 -r1.72
  --- index.html1 Nov 2004 14:56:26 -   1.71
  +++ index.html22 Nov 2004 18:16:26 -  1.72
  @@ -43,23 +43,12 @@
   
   
   
  -
  -
  -http://ApacheCon.Com/2004/US/";>
  -http://ApacheCon.Com/2004/US/logos/logo_only.gif";
  -width="170" height="100" alt="ApacheCon!" title=
  -"Join Us At ApacheCon!"
  -border="0" />
  -
  -
  -
   
   http://jakarta.apache.org";>http://jakarta.apache.org/images/jakarta-logo.gif"; border="0"/>
   
   
   http://jakarta.apache.org/tomcat";>
   
  -
   
   
   
  @@ -151,29 +140,6 @@
   
 
   
  -  Join Us At ApacheCon 13-17 November 2004 in Las Vegas, 
Nevada, USA
  -
  -  
  -  
  -
  -
  -http://apachecon.com/2004/US/";>ApacheCon is a once-in-a-year 
opportunity to
  -learn about Apache projects and meet old and new friends in the Apache 
community. 
  -
  -
  -Jakarta
  -will be well represented together with the wider Apache Java community. The 
number of ASF 
  -projects likely to be of interest to Java developers has never been higher: 
  -so if you're never joined us before, there's never been a better time to 
start the habit!
  -
  -
  -
  -  
  -  
  -
  -
  -  
  -
 Apache Jakarta 
Tomcat
   
 
  @@ -227,7 +193,7 @@
   
   
   
  -5.0.28
  +5.5.4
   
   
   
  @@ -275,14 +241,11 @@
 
 
   
  -Tomcat 5.x is the 
current major release of Tomcat, and
  -builds upon the Tomcat 3.3 and Tomcat 4.1 codebases. 
  -The 5.x releases implement the Servlet 2.4 
  -and JSP 2.0 specifications.
  -Tomcat 
5.5.x.  Tomcat 5.5 is the next branch in the 
  -Tomcat 5.x major release.  While it supports the same Servlet and JSP
  +Tomcat 5.5.x.  
Tomcat 5.5 is the current focus of
  +development.  While it supports the same Servlet and JSP
   Specification versions as Tomcat 5.0.x, there are significant changes
  -in many areas under the hood.  Please refer to the Tomcat 5.5 Changelog
  +in many areas under the hood, resulting in improved performance, stability,
  +and total cost of ownership.  Please refer to the Tomcat 5.5 Changelog
   for details.
   
   Tomcat 
5.0.x.  Tomcat 5.0 improves on Tomcat 4.1 in many
  
  
  
  1.26  +0 -11 jakarta-tomcat-site/docs/irc.html
  
  Index: irc.html
  ===
  RCS file: /home/cvs

Re: Website updates

[jean-frederic clere]

Remy Maucherat wrote:
I propose the following changes to the main website:
- in the "Documentation" section, add "JK 1.2"
- add the new JK documentation to the website
- in the "Documentation" section, add "mod_proxy", linking to the Apache 
2.1 documentation
- when the next Tomcat 5.5 stable is released, update the "Tomcat 
Versions" chart with 5.5, and move the Tomcat 5.0 documentation link to 
the archives
I have arranged my cronjob that rebuild the documentation, please check if it is 
 OK.

Cheers
Jean-Frederic
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-connectors/jk/xdocs/config workers.xml

[mturk]

mturk   2004/11/22 08:51:44

  Modified:jk/xdocs/config workers.xml
  Log:
  More workers properties documented.
  
  Revision  ChangesPath
  1.4   +28 -0 jakarta-tomcat-connectors/jk/xdocs/config/workers.xml
  
  Index: workers.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/config/workers.xml,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- workers.xml   19 Nov 2004 10:39:36 -  1.3
  +++ workers.xml   22 Nov 2004 16:51:44 -  1.4
  @@ -103,6 +103,10 @@
   to send KEEP_ALIVE message on inactive connections (interval 
depend on global OS settings,
   generally 120ms), and thus prevent the firewall to cut the connection.
   To enable keepalive set this property value to the number greater then 
0.
  +
  +The problem with Firewall cutting inactive connections is that sometimes, 
neither webserver or tomcat
  +have informations about the cut and couldn't handle it.
  +
   
   
   
  @@ -118,6 +122,30 @@
   The number of retries that the worker will try in case of error returned 
from remote
   Tomcat. If the number of retries set is greater then three (the default 
value), on
   each retry after default an extra wait of 100ms will be inserted.
  +
  +
  +
  +Cachesize property is usefull when you're using JK in multithreaded 
  +web servers such as Apache 2.0 (worker), IIS and Netscape. They will benefit 
the most by 
  +setting this value to a higher level (such as the estimated average 
concurrent users for Tomcat).
  +If cachesize is not set, the connection cache support is disabled.
  +Cachesize determines the minimum number of open connections to backend 
Tomcat.
  +
  +
  +
  +Cache timeout property should be used with cachesize to specify how 
to time JK should keep
  +an open socket in cache before closing it. This property should be used to 
reduce the number of threads 
  +on the Tomcat WebServer.
  + 
  +Each child could open an ajp13 connection if it have to forward a request to 
Tomcat, creating
  +a new ajp13 thread on Tomcat side.
  +
  +
  +The problem is that after an ajp13 connection is created, the child won't 
drop it
  +until killed. And since the webserver will keep its childs/threads running
  +to handle high-load, even it the child/thread handle only static contents, 
you could
  +finish having many unused ajp13 threads on the Tomcat side.
  +
   
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session PersistentManagerBase.java StandardManager.java StandardSession.java

[jfarcand]

jfarcand2004/11/22 08:35:18

  Modified:catalina/src/share/org/apache/catalina/connector
CoyoteInputStream.java InputBuffer.java
OutputBuffer.java RequestFacade.java Response.java
ResponseFacade.java
   catalina/src/share/org/apache/catalina/core
ApplicationContextFacade.java
ApplicationDispatcher.java
ApplicationFilterChain.java StandardWrapper.java
   catalina/src/share/org/apache/catalina/security
SecurityUtil.java
   catalina/src/share/org/apache/catalina/session
PersistentManagerBase.java StandardManager.java
StandardSession.java
  Log:
  Port patch from Tomcat 5.0: When the package protection is not used, do not 
create the doPrivileged objects .
  
  Revision  ChangesPath
  1.2   +6 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/CoyoteInputStream.java
  
  Index: CoyoteInputStream.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/CoyoteInputStream.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- CoyoteInputStream.java23 Jun 2004 08:24:57 -  1.1
  +++ CoyoteInputStream.java22 Nov 2004 16:35:17 -  1.2
  @@ -24,6 +24,7 @@
   
   import javax.servlet.ServletInputStream;
   
  +import org.apache.catalina.security.SecurityUtil;
   
   /**
* This class handles reading bytes.
  @@ -65,7 +66,7 @@
   
   public int read()
   throws IOException {
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   
   try{
   Integer result = 
  @@ -94,7 +95,7 @@
   
   public int available() throws IOException {
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   try{
   Integer result = 
   (Integer)AccessController.doPrivileged(
  @@ -122,7 +123,7 @@
   
   public int read(final byte[] b) throws IOException {
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   try{
   Integer result = 
   (Integer)AccessController.doPrivileged(
  @@ -153,7 +154,7 @@
   public int read(final byte[] b, final int off, final int len)
   throws IOException {
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   try{
   Integer result = 
   (Integer)AccessController.doPrivileged(
  @@ -193,7 +194,7 @@
*/
   public void close() throws IOException {
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   try{
   AccessController.doPrivileged(
   new PrivilegedExceptionAction(){
  
  
  
  1.4   +2 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/InputBuffer.java
  
  Index: InputBuffer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/InputBuffer.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- InputBuffer.java  29 Aug 2004 16:46:09 -  1.3
  +++ InputBuffer.java  22 Nov 2004 16:35:17 -  1.4
  @@ -23,6 +23,7 @@
   import java.security.PrivilegedExceptionAction;
   import java.util.HashMap;
   
  +import org.apache.catalina.security.SecurityUtil;
   import org.apache.coyote.Request;
   import org.apache.tomcat.util.buf.B2CConverter;
   import org.apache.tomcat.util.buf.ByteChunk;
  @@ -465,7 +466,7 @@
   enc = DEFAULT_ENCODING;
   conv = (B2CConverter) encoders.get(enc);
   if (conv == null) {
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   try{
   conv = (B2CConverter)AccessController.doPrivileged(
   new PrivilegedExceptionAction(){
  
  
  
  1.4   +2 -1  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/OutputBuffer.java
  
  Index: OutputBuffer.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/connector/OutputBuffer.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- OutputBuffer.java 25 Ju

Reminder: Tomcat 5.0.30 this Wednesday...

[Shapira, Yoav]

... as per my original message:

Hi,
If no one objects, I'd like to cut Tomcat 5.0.30 next week.  Right now
let's say Wednesday, November 24th, at 1600h GMT
(http://www.timeanddate.com/worldclock/converted.html?month=11&day=24&ye
ar=2004&hour=11&min=0&sec=0&p1=43&p2=0).

Yoav Shapira http://www.yoavshapira.com





This e-mail, including any attachments, is a confidential business 
communication, and may contain information that is confidential, proprietary 
and/or privileged.  This e-mail is intended only for the individual(s) to whom 
it is addressed, and may not be saved, copied, printed, disclosed or used by 
anyone else.  If you are not the(an) intended recipient, please immediately 
delete this e-mail from your computer system and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java

[jfarcand]

jfarcand2004/11/22 08:40:53

  Removed: catalina/src/share/org/apache/catalina/valves
ByteBufferAccessLogValve.java
  Log:
  Remove experimental works.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 29727] - JNDI env-entry not reload when context reloaded

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29727


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|5.0.25  |5.0.28




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 17:37 ---
Updating version to 5.0.28.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JasperLoader.java

[jfarcand]

jfarcand2004/11/22 08:35:52

  Modified:jasper2/src/share/org/apache/jasper/runtime
JspWriterImpl.java PageContextImpl.java
ProtectedFunctionMapper.java
   jasper2/src/share/org/apache/jasper/servlet
JasperLoader.java
  Added:   jasper2/src/share/org/apache/jasper/security
SecurityUtil.java
  Log:
  Port patch from Tomcat 5.0: When the package protection is not used, do not 
create the doPrivileged objects .
  
  Revision  ChangesPath
  1.14  +2 -1  
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspWriterImpl.java
  
  Index: JspWriterImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/JspWriterImpl.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- JspWriterImpl.java5 Oct 2004 16:07:18 -   1.13
  +++ JspWriterImpl.java22 Nov 2004 16:35:52 -  1.14
  @@ -26,6 +26,7 @@
   
   import org.apache.jasper.Constants;
   import org.apache.jasper.compiler.Localizer;
  +import org.apache.jasper.security.SecurityUtil;
   
   /**
* Write text to a character-output stream, buffering characters so as
  @@ -125,7 +126,7 @@
   }

   private String getLocalizeMessage(final String message){
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
  return (String)AccessController.doPrivileged(new 
PrivilegedAction(){
   public Object run(){
   return Localizer.getMessage(message); 
  
  
  
  1.62  +14 -13
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/PageContextImpl.java
  
  Index: PageContextImpl.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/runtime/PageContextImpl.java,v
  retrieving revision 1.61
  retrieving revision 1.62
  diff -u -r1.61 -r1.62
  --- PageContextImpl.java  20 Sep 2004 17:58:26 -  1.61
  +++ PageContextImpl.java  22 Nov 2004 16:35:52 -  1.62
  @@ -49,6 +49,7 @@
   import org.apache.commons.logging.LogFactory;
   import org.apache.jasper.Constants;
   import org.apache.jasper.compiler.Localizer;
  +import org.apache.jasper.security.SecurityUtil;
   
   /**
* Implementation of the PageContext class from the JSP spec.
  @@ -216,7 +217,7 @@
   Localizer.getMessage("jsp.error.attribute.null_name"));
   }
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   return AccessController.doPrivileged(new PrivilegedAction(){
   public Object run(){
   return doGetAttribute(name);
  @@ -239,7 +240,7 @@
   Localizer.getMessage("jsp.error.attribute.null_name"));
   }
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   return AccessController.doPrivileged(new PrivilegedAction(){
   public Object run(){
   return doGetAttribute(name, scope);
  @@ -281,7 +282,7 @@
   Localizer.getMessage("jsp.error.attribute.null_name"));
   }
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   AccessController.doPrivileged(new PrivilegedAction(){
   public Object run(){
   doSetAttribute(name, attribute);
  @@ -308,7 +309,7 @@
   Localizer.getMessage("jsp.error.attribute.null_name"));
   }
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   AccessController.doPrivileged(new PrivilegedAction(){
   public Object run(){
   doSetAttribute(name, o, scope);
  @@ -358,7 +359,7 @@
   throw new NullPointerException(
   Localizer.getMessage("jsp.error.attribute.null_name"));
   }
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   AccessController.doPrivileged(new PrivilegedAction(){
   public Object run(){
   doRemoveAttribute(name, scope);
  @@ -404,7 +405,7 @@
   Localizer.getMessage("jsp.error.attribute.null_name"));
   }
   
  -if (System.getSecurityManager() != null){
  +if (SecurityUtil.isPackageProtectionEnabled()){
   return ((Integer)AccessController.doPrivileged(new 
PrivilegedAction(){
   public Object run(){
   return n

cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF web.xml

[yoavs]

yoavs   2004/11/22 08:32:59

  Modified:webapps/admin/WEB-INF Tag: TOMCAT_5_0 web.xml
  Log:
  Enable this filter by default for Bugzilla 29091.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.8.2.2   +1 -5  jakarta-tomcat-catalina/webapps/admin/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/web.xml,v
  retrieving revision 1.8.2.1
  retrieving revision 1.8.2.2
  diff -u -r1.8.2.1 -r1.8.2.2
  --- web.xml   25 Oct 2004 18:50:41 -  1.8.2.1
  +++ web.xml   22 Nov 2004 16:32:59 -  1.8.2.2
  @@ -29,26 +29,22 @@
  Uncomment this filter definition and the mapping to use
  the filter to decode post and get parameters -->
   
  -  
   
 
   
  -  
   
 
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java

[jfarcand]

jfarcand2004/11/22 08:31:04

  Modified:catalina/src/share/org/apache/catalina/valves
ByteBufferAccessLogValve.java
  Log:
  Re-add the writer thread since the valve doesn't work properly without it. 
This is temporary.
  
  Revision  ChangesPath
  1.4   +105 -3
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ByteBufferAccessLogValve.java
  
  Index: ByteBufferAccessLogValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ByteBufferAccessLogValve.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ByteBufferAccessLogValve.java 22 Nov 2004 15:16:24 -  1.3
  +++ ByteBufferAccessLogValve.java 22 Nov 2004 16:31:04 -  1.4
  @@ -62,7 +62,7 @@
   
   public final class ByteBufferAccessLogValve
   extends ValveBase
  -implements Lifecycle {
  +implements Lifecycle, Runnable {
   
   
   // --- 
Constructors
  @@ -111,7 +111,7 @@
* The descriptive information about this implementation.
*/
   protected static final String info =
  -"org.apache.catalina.valves.ByteBufferAccessLogValve/1.0";
  +"org.apache.catalina.valves.AccessLogValve/1.0";
   
   
   /**
  @@ -277,6 +277,12 @@
   
   
   /**
  + * The background writerThread.
  + */
  +private Thread writerThread = null;   
  +
  +
  +/**
* The background writerThread completion semaphore.
*/
   private boolean threadDone = false;
  @@ -314,6 +320,12 @@
   
   
   /**
  + * The interval (in seconds) between writting the log.
  + */
  +private int writeInterval = 5 * 60;
  +
  +
  +/**
* Per-Thread StringBuffer used to store the log.
*/
   static private ThreadLocal stringBufferThreadLocal = new ThreadLocal(){
  @@ -355,6 +367,21 @@
   }
   
   
  +/**
  + * Return writerThread interval (seconds)
  + */
  +public int getWriterInterval() {
  +return this.writeInterval; 
  +}
  +
  +
  +/**
  + * Set writerthread interval (seconds)
  + */
  +public void setWriterInterval(int t) {
  +this.writeInterval = t;
  +}
  +
   // - 
Properties
   
   
  @@ -953,6 +980,8 @@
   dateStamp = dateFormatter.format(new Date());
   
   open();
  +
  +threadStart();
   
   }
   
  @@ -975,6 +1004,9 @@
   started = false;
   
   close();
  +
  +threadStop();
  +
   }
   
   
  @@ -984,6 +1016,76 @@
* throwables will be caught and logged.
*/
   public void backgroundProcess() {
  -log();
  +// log();
  +}
  +
  +
  +/**
  + * The background writerThread that checks for write the log.
  + */
  +public void run() {
  +
  +// Loop until the termination semaphore is set
  +while (!threadDone) {
  +threadWait();
  +log();
  +}
   }
  +
  +
  +/**
  + * Sleep for the duration specified by the writeInterval
  + * property.
  + */
  +private void threadWait() {
  +
  +synchronized(lock){
  +try {
  +lock.wait(writeInterval * 1000L);
  +} catch (InterruptedException e) {
  +;
  +}
  +}
  +
  +}
  +
  +
  +   /**
  + * Start the background writerThread that will periodically write access 
log
  + */
  +private void threadStart() {
  +
  +if (writerThread != null)
  +return;
  +
  +threadDone = false;
  +String threadName = "AccessLogWriter";
  +writerThread = new Thread(this, threadName);
  +writerThread.setDaemon(true);
  +writerThread.start();
  +
  +}
  +
  +
  +/**
  + * Stop the background writerThread that is periodically write logs
  + */
  +private void threadStop() {
  +
  +if (writerThread == null)
  +return;
  +
  +threadDone = true;
  +writerThread.interrupt();
  +try {
  +writerThread.join();
  +} catch (InterruptedException e) {
  +;
  +}
  +
  +writerThread = null;
  +
  +}
  +
  +
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/admin/WEB-INF web.xml

[yoavs]

yoavs   2004/11/22 08:30:15

  Modified:webapps/admin/WEB-INF web.xml
  Log:
  Enable this filter by default to help with Bugzilla 29091.
  
  Revision  ChangesPath
  1.13  +0 -4  jakarta-tomcat-catalina/webapps/admin/WEB-INF/web.xml
  
  Index: web.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/admin/WEB-INF/web.xml,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- web.xml   25 Oct 2004 19:00:22 -  1.12
  +++ web.xml   22 Nov 2004 16:30:14 -  1.13
  @@ -13,7 +13,6 @@
  Uncomment this filter definition and the mapping to use
  the filter to decode post and get parameters -->
   
  -  
   
 
   
  -  
   
 
 
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 32065] - Unable to install as service, if the name contains "_"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32065


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 17:27 ---
Commons-Daemon requires that the service name be alphanumeric.  See this method 
in jakarta-commons/daemon/src/../service.c:
static BOOL __apxIsValidServiceName(LPCWSTR szServiceName)
{
do {
if (!IsCharAlphaNumericW(*szServiceName)) {
apxDisplayError(TRUE, NULL, 0, "NonAlpha %d", *szServiceName);
return FALSE;
}
} while( *(++szServiceName));
return TRUE;
}

Therefore, this is by design.  If you want this enhanced, feel free to reopen 
this issue:
- as an enhancement (not bug),
- and for Commons/Daemon, not Tomcat

Thank you.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java mbeans-descriptors.xml

[Remy Maucherat]

Jean-Francois Arcand wrote:
Yes, I can explore that. I will re-add the writerThread for now since 
the current implementation doesn't work since the byteBuffer will 
never be flushed. This is temporary. Again, consider this valve as 
exploration.
I do agree to some extent with the rest (except your benchmark results, 
which look wrong), but I cannot agree to this. If you want to play with 
something on your own, then don't contribute it or place it in an 
experimental folder.

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 32065] - Unable to install as service, if the name contains "_"

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32065


[EMAIL PROTECTED] changed:

   What|Removed |Added

 OS/Version||All




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 17:08 ---
What OS are you running?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java mbeans-descriptors.xml

[Jean-Francois Arcand]

Remy Maucherat wrote:
Jean-Francois Arcand wrote:
Without access log valve, we are 20% faster. With the ByteBuffer one, 
13%.

There are 3 access log valves ;) Maybe you should give a chart.
I did formally benchmark
+ FastCommonAccessLogValve
+ ByteBufferAccessLogValve
I didn't bother about AccessLogValve. I did a lot of exploration:
+ use a ByteBuffer, call ByteBuffer.asCharBuffer() and then use 
CharBuffer.put() (no StringBuffer/ThreadLocal). Works fine except there 
is some garbage in the log since when a CharBuffer view buffer is used 
against a ByteBuffer or using ByteBuffer.putChar(char x) will result in 
'^' (control) characters and null characters to be written to the 
ByteBuffer. These '^' (control) characters then get written to the 
access log.
+ StringBuffer without a ThreadLocal.
+ CharBuffer.allocate() with a ByteBuffer.allocateDirect()

I did also try to synchronize the valve invoke method and use the 
current thread to write the log (instead of using a background 
thread/writter thread).


I'll do my byte based improvements (to be able to save on char to byte) 
in your implementation.

The buffer isn't big enough. 16k will hold 500 requests maximum. If you 
were afraid of doing one I/O operations, it's bad, as you'll end up 
doing a lot of I/O synchronously. Can we allow the buffers to grow ?
Yes, but growing a direct byte buffer is very bad. I did put 16k as a 
baseline. Using a 128k will gives better results, but 256k didn't.

 At
least they would need to be a lot bigger otherwise (we could "reinvest" 
the memory saved from not having a background thread :) ).
Another trick if you want to tweak the interval inside the valve, you 
can use an integer that you increment and do a modulo (i % n). I do that 
for the manager checks (one check every 6 invocations of 
backgroundProcess).
Yes, I can explore that. I will re-add the writerThread for now since 
the current implementation doesn't work since the byteBuffer will never 
be flushed. This is temporary. Again, consider this valve as exploration.

-- Jeanfrancois

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs developers.xml

[pero]

pero2004/11/22 07:50:57

  Modified:webapps/docs developers.xml
  Log:
  add me to the developers list
  
  Revision  ChangesPath
  1.7   +1 -0  jakarta-tomcat-catalina/webapps/docs/developers.xml
  
  Index: developers.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/developers.xml,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- developers.xml1 Sep 2004 22:04:27 -   1.6
  +++ developers.xml22 Nov 2004 15:50:57 -  1.7
  @@ -40,6 +40,7 @@
 Jean-Frederic Clere (jfclere): Connectors
 Kin-Man Chung (kinman): Jasper
 Mladen Turk (mturk): Connectors
  +  Peter Rossbach (pero): Catalina, Clustering
 Remy Maucherat (remm): Catalina, Connectors, Docs
 Tim Funk (funkman): Catalina, Docs
 Yoav Shapira (yoavs): Docs, JMX, Catalina, balancer, Release 
Manager
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs project.xml

[remm]

remm2004/11/22 07:26:42

  Modified:webapps/docs project.xml
  Log:
  - Point to the new JK docs (with a symlink I added).
  
  Revision  ChangesPath
  1.25  +2 -2  jakarta-tomcat-catalina/webapps/docs/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/project.xml,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -r1.24 -r1.25
  --- project.xml   7 Oct 2004 18:16:05 -   1.24
  +++ project.xml   22 Nov 2004 15:26:42 -  1.25
  @@ -47,8 +47,8 @@
   
   
   
  -http://jakarta.apache.org/tomcat/connectors-doc/jk2/index.html"/>
  +http://jakarta.apache.org/tomcat/jk-1.2/"/>
   
   
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp SimpleTcpCluster.java

[pero]

pero2004/11/22 06:51:52

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/tcp
SimpleTcpCluster.java
  Log:
  Better log support to see detail information at debug level.
  
  Revision  ChangesPath
  1.54  +6 -7  
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java
  
  Index: SimpleTcpCluster.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/tcp/SimpleTcpCluster.java,v
  retrieving revision 1.53
  retrieving revision 1.54
  diff -u -r1.53 -r1.54
  --- SimpleTcpCluster.java 11 Nov 2004 14:47:27 -  1.53
  +++ SimpleTcpCluster.java 22 Nov 2004 14:51:52 -  1.54
  @@ -268,9 +268,6 @@
   }
   
   
  -
  -
  -
   // - Public 
Methods
   
   
  @@ -369,9 +366,11 @@
   if (started)
   throw new LifecycleException
   (sm.getString("cluster.alreadyStarted"));
  -log.info("Cluster is about to start");
  +if(log.isInfoEnabled())
  +log.info("Cluster is about to start");
   try {
  -log.debug("Invoking addValve on "+getContainer()+ " with 
class="+valve.getClass().getName());
  +if(log.isDebugEnabled())
  +log.debug("Invoking addValve on "+getContainer()+ " with 
class="+valve.getClass().getName());
   IntrospectionUtils.callMethodN(getContainer(), 
   "addValve", 
   new Object[]  {valve}, 
  @@ -387,7 +386,7 @@
   try {
   if ( clusterDeployer != null ) {
   clusterDeployer.setCluster(this);
  -Object deployer = 
IntrospectionUtils.getProperty(getContainer(), "deployer");
  +// Object deployer = 
IntrospectionUtils.getProperty(getContainer(), "deployer");
   // FIXME: clusterDeployer.setDeployer( 
(org.apache.catalina.Deployer) deployer);
   // clusterDeployer.setDeployer( deployer);
   clusterDeployer.start();
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java

[jfarcand]

jfarcand2004/11/22 07:16:24

  Modified:catalina/src/share/org/apache/catalina/valves
ByteBufferAccessLogValve.java
  Log:
  Remove wrong copyright.
  
  Revision  ChangesPath
  1.3   +0 -5  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ByteBufferAccessLogValve.java
  
  Index: ByteBufferAccessLogValve.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves/ByteBufferAccessLogValve.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ByteBufferAccessLogValve.java 19 Nov 2004 20:06:07 -  1.2
  +++ ByteBufferAccessLogValve.java 22 Nov 2004 15:16:24 -  1.3
  @@ -1,9 +1,4 @@
   /*
  - * Copyright 2004 Sun Microsystems, Inc. All rights reserved.
  - * SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
  - */
  -
  -/*
* Copyright 1999-2001,2004 The Apache Software Foundation.
* 
* Licensed under the Apache License, Version 2.0 (the "License");
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31276] - Child elements of context.xml are lost when deployed in a war

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31276


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:57 ---
This works for me fine when doing a clean deployment.  If there's already an 
app.xml in conf/[engine]/[host] then it won't be overwritten, and the effect is 
that META-INF/context.xml will appear to be ignored.  So you need to be 
vigilant about the server's configuration state with respect to these app.xml 
file when using the META-INF/context.xml feature.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 32282] - Uninstaller should not remove webapps/root

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32282


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 16:05 ---
Modification done for Tomcat 5.0.30 and 5.5.5, because other newbies are likely 
to use the ROOT directory in the same manner.  But please do start taking 
regular backups, and do consider using a real webapp instead of the ROOT hard-
coded name.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 32330] - JspC changes context classloader

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32330


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:55 ---
Not only is this good for your issue, it solves another one which I'd close as 
not reproducible.  So this is great.  Thank you for submitting this patch.

Done for 5.5.5 and 5.0.30.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

[yoavs]

yoavs   2004/11/22 07:04:59

  Modified:.tomcat.nsi
   webapps/docs changelog.xml
  Log:
  Bugzilla 32282: modified Windows Uninstaller to only remove webapps/ROOT and 
webapps if user asks to remove everything.
  
  Revision  ChangesPath
  1.67  +5 -5  jakarta-tomcat-5/tomcat.nsi
  
  Index: tomcat.nsi
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/tomcat.nsi,v
  retrieving revision 1.66
  retrieving revision 1.67
  diff -u -r1.66 -r1.67
  --- tomcat.nsi13 Nov 2004 18:57:05 -  1.66
  +++ tomcat.nsi22 Nov 2004 15:04:58 -  1.67
  @@ -617,12 +617,10 @@
 RMDir "$INSTDIR\logs"
 RMDir /r "$INSTDIR\server"
 RMDir /r "$INSTDIR\webapps\balancer"
  -  RMDir /r "$INSTDIR\webapps\ROOT"
 RMDir /r "$INSTDIR\webapps\tomcat-docs"
 RMDir /r "$INSTDIR\webapps\servlets-examples"
 RMDir /r "$INSTDIR\webapps\jsp-examples"
 RMDir /r "$INSTDIR\webapps\webdav"
  -  RMDir "$INSTDIR\webapps"
 RMDir /r "$INSTDIR\work"
 RMDir /r "$INSTDIR\temp"
 RMDir /r "$INSTDIR\src"
  @@ -631,9 +629,11 @@
 ; if $INSTDIR was removed, skip these next ones
 IfFileExists "$INSTDIR" 0 Removed 
   MessageBox MB_YESNO|MB_ICONQUESTION \
  -  "Remove all files in your Tomcat 5.5 directory? (If you have anything\
  +  "Remove all files in your Tomcat 5.5 directory? (If you have anything \
you created that you want to keep, click No)" IDNO Removed
  -Delete "$INSTDIR\*.*" ; this would be skipped if the user hits no
  +RMDir /r "$INSTDIR\webapps\ROOT" ; this would be skipped if the user 
hits no
  +RMDir "$INSTDIR\webapps"
  +Delete "$INSTDIR\*.*" 
   RMDir /r "$INSTDIR"
   Sleep 500
   IfFileExists "$INSTDIR" 0 Removed 
  
  
  
  1.179 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.178
  retrieving revision 1.179
  diff -u -r1.178 -r1.179
  --- changelog.xml 22 Nov 2004 14:52:28 -  1.178
  +++ changelog.xml 22 Nov 2004 15:04:58 -  1.179
  @@ -44,6 +44,9 @@
 
   32249: Updated logging documentation. (yoavs)
 
  +  
  +32282: Modify Windows Uninstaller to only remove 
webapps/ROOT and webapps if user asks to remove everything. (yoavs)
  +  
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

[yoavs]

yoavs   2004/11/22 07:02:55

  Modified:.Tag: TOMCAT_5_0 tomcat.nsi
   webapps/docs Tag: TOMCAT_5_0 changelog.xml
  Log:
  Bugzilla 32282: modified Windows Uninstaller to only remove webapps/ROOT and 
webapps if user asks to remove everything.
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.45.2.2  +5 -5  jakarta-tomcat-5/tomcat.nsi
  
  Index: tomcat.nsi
  ===
  RCS file: /home/cvs/jakarta-tomcat-5/tomcat.nsi,v
  retrieving revision 1.45.2.1
  retrieving revision 1.45.2.2
  diff -u -r1.45.2.1 -r1.45.2.2
  --- tomcat.nsi2 Sep 2004 10:02:05 -   1.45.2.1
  +++ tomcat.nsi22 Nov 2004 15:02:54 -  1.45.2.2
  @@ -553,12 +553,10 @@
 RMDir "$INSTDIR\logs"
 RMDir /r "$INSTDIR\server"
 RMDir /r "$INSTDIR\webapps\balancer"
  -  RMDir /r "$INSTDIR\webapps\ROOT"
 RMDir /r "$INSTDIR\webapps\tomcat-docs"
 RMDir /r "$INSTDIR\webapps\servlets-examples"
 RMDir /r "$INSTDIR\webapps\jsp-examples"
 RMDir /r "$INSTDIR\webapps\webdav"
  -  RMDir "$INSTDIR\webapps"
 RMDir /r "$INSTDIR\work"
 RMDir /r "$INSTDIR\temp"
 RMDir /r "$INSTDIR\src"
  @@ -567,9 +565,11 @@
 ; if $INSTDIR was removed, skip these next ones
 IfFileExists "$INSTDIR" 0 Removed 
   MessageBox MB_YESNO|MB_ICONQUESTION \
  -  "Remove all files in your Tomcat 5.0 directory? (If you have anything\
  +  "Remove all files in your Tomcat 5.0 directory? (If you have anything \
you created that you want to keep, click No)" IDNO Removed
  -Delete "$INSTDIR\*.*" ; this would be skipped if the user hits no
  +RMDir /r "$INSTDIR\webapps\ROOT" ; this would be skipped if the user 
hits no
  +RMDir "$INSTDIR\webapps"
  +Delete "$INSTDIR\*.*" 
   RMDir /r "$INSTDIR"
   Sleep 500
   IfFileExists "$INSTDIR" 0 Removed 
  
  
  
  No   revision
  No   revision
  1.70.2.81 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.80
  retrieving revision 1.70.2.81
  diff -u -r1.70.2.80 -r1.70.2.81
  --- changelog.xml 22 Nov 2004 14:54:56 -  1.70.2.80
  +++ changelog.xml 22 Nov 2004 15:02:55 -  1.70.2.81
  @@ -32,6 +32,9 @@
  
  When the package protection is not used, do not create the 
doPrivileged objects so we don't suffer the performance hit.
  
  +  
  +32282: Modify Windows Uninstaller to remove webapps and 
webapps/ROOT only if user asks to remove everything. (yoavs)
  +  
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Website updates

[Peter Rossbach]

Good  idea that people can read the jk doc without internet access.
regards,
Peter
Remy Maucherat schrieb:
I propose the following changes to the main website:
- in the "Documentation" section, add "JK 1.2"
- add the new JK documentation to the website
- in the "Documentation" section, add "mod_proxy", linking to the 
Apache 2.1 documentation
- when the next Tomcat 5.5 stable is released, update the "Tomcat 
Versions" chart with 5.5, and move the Tomcat 5.0 documentation link 
to the archives

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 28560] - Wrong session route used when more than one JSESSIONID cookie exists

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28560


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:58 ---
mod_jk2 is going away and this issue won't be addressed in its code base.  
Because it's already been fixed for mod_jk as you have noted, I'm closing the 
issue.  Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session DeltaManager.java DeltaSession.java SimpleTcpReplicationManager.java

[pero]

pero2004/11/22 06:51:19

  Modified:modules/cluster/src/share/org/apache/catalina/cluster/session
DeltaManager.java DeltaSession.java
SimpleTcpReplicationManager.java
  Log:
  Move processExpiresFrequency check to ManagerBase and reflect change to all 
subclasses (StandardManager, PersientManagerBase, DeltaManager)
  Better log support to DeltaManager to see detail information at debug level.
  
  Revision  ChangesPath
  1.36  +85 -111   
jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java
  
  Index: DeltaManager.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaManager.java,v
  retrieving revision 1.35
  retrieving revision 1.36
  diff -u -r1.35 -r1.36
  --- DeltaManager.java 13 Nov 2004 22:10:10 -  1.35
  +++ DeltaManager.java 22 Nov 2004 14:51:18 -  1.36
  @@ -103,17 +103,6 @@
   
   
   /**
  - * Path name of the disk file in which active sessions are saved
  - * when we stop, and from which these sessions are loaded when we start.
  - * A null value indicates that no persistence is desired.
  - * If this pathname is relative, it will be resolved against the
  - * temporary working directory provided by our context, available via
  - * the javax.servlet.context.tempdir context attribute.
  - */
  -private String pathname = "SESSIONS.ser";
  -
  -
  -/**
* Has this component been started yet?
*/
   private boolean started = false;
  @@ -130,6 +119,7 @@
   private boolean printToScreen;
   
   private boolean notifyListenersOnReplication = false;
  +
   // - 
Constructor
   public DeltaManager() {
   super();
  @@ -198,26 +188,6 @@
   this.rejectedSessions = rejectedSessions;
   }
   
  -/** Number of sessions that expired.
  - *
  - * @return The count
  - */
  -public int getExpiredSessions() {
  -return expiredSessions;
  -}
  -
  -public void setExpiredSessions(int expiredSessions) {
  -this.expiredSessions = expiredSessions;
  -}
  -
  -public long getProcessingTime() {
  -return processingTime;
  -}
  -
  -public void setProcessingTime(long processingTime) {
  -this.processingTime = processingTime;
  -}
  -
   /**
* Set the maximum number of actives Sessions allowed, or -1 for
* no limit.
  @@ -244,32 +214,6 @@
   
   }
   
  -
  -/**
  - * Return the session persistence pathname, if any.
  - */
  -public String getPathname() {
  -
  -return (this.pathname);
  -
  -}
  -
  -
  -/**
  - * Set the session persistence pathname to the specified value.  If no
  - * persistence support is desired, set the pathname to null.
  - *
  - * @param pathname New session persistence pathname
  - */
  -public void setPathname(String pathname) {
  -
  -String oldPathname = this.pathname;
  -this.pathname = pathname;
  -support.firePropertyChange("pathname", oldPathname, this.pathname);
  -
  -}
  -
  -
   // - Public 
Methods
   
   /**
  @@ -295,6 +239,14 @@
   return createSession(true);
   }
   
  +
  +/**
  + * create new session with check maxActiveSessions and send session 
creation to other
  + * cluster nodes.
  + * 
  + * @param distribute
  + * @return
  + */
   public Session createSession(boolean distribute) {
   
 if ((maxActiveSessions >= 0) &&
  @@ -333,10 +285,13 @@
 null,
 sessionId,
 sessionId+System.currentTimeMillis());
  +  if(log.isDebugEnabled())
  +  log.debug("Manager ("+name+") send new session (" +sessionId+ 
")");
 cluster.send(msg);
 session.resetDeltaRequest();
 }
  -  log.debug("Created a DeltaSession with Id["+session.getId()+"] Total 
count="+sessions.size());
  +  if(log.isDebugEnabled())
  +  log.debug("Created a DeltaSession with Id["+session.getId()+"] 
Total count="+sessions.size());
 
 return (session);
   
  @@ -611,7 +566,8 @@
   // Load unloaded sessions, if any
   try {
   //the channel is already running
  -log.info("Starting clustering manager...:"+getName());
  +if(log.isInfoEnabled())
  +log.info("Starting clustering manager...:"+getName());
   if ( cluster == null ) {
   log.error("Starting... no cluster associated with this 
context:"+getName());
   return;
  @@ -636,7 +592,8 @@
   

DO NOT REPLY [Bug 29904] - unable to instantiate tomcat jasper task more than once

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29904


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:55 ---
I believe we've got this now ;)

*** This bug has been marked as a duplicate of 32330 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 32330] - JspC changes context classloader

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32330


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:55 ---
*** Bug 29904 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

[yoavs]

yoavs   2004/11/22 06:54:57

  Modified:webapps/docs Tag: TOMCAT_5_0 changelog.xml
   jasper2/src/share/org/apache/jasper Tag: TOMCAT_5_0
JspC.java
  Log:
  Bugzilla 32330: JspC changes context classloader
  
  Revision  ChangesPath
  No   revision
  No   revision
  1.70.2.80 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.70.2.79
  retrieving revision 1.70.2.80
  diff -u -r1.70.2.79 -r1.70.2.80
  --- changelog.xml 19 Nov 2004 15:17:40 -  1.70.2.79
  +++ changelog.xml 22 Nov 2004 14:54:56 -  1.70.2.80
  @@ -98,6 +98,9 @@
 
   29866: JspReader#skipUntil may try to read beyond the end 
of the file. (yoavs)
 
  +  
  +32330: JspC changes context classloader. (yoavs)
  +  
   
 
   
  
  
  
  No   revision
  No   revision
  1.80.2.6  +22 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.80.2.5
  retrieving revision 1.80.2.6
  diff -u -r1.80.2.5 -r1.80.2.6
  --- JspC.java 19 Nov 2004 14:37:47 -  1.80.2.5
  +++ JspC.java 22 Nov 2004 14:54:56 -  1.80.2.6
  @@ -813,6 +813,8 @@
   private void processFile(String file)
   throws JasperException
   {
  +ClassLoader originalClassLoader = null;
  +
   try {
   // set up a scratch/output dir if none is provided
   if (scratchDir == null) {
  @@ -836,8 +838,9 @@
   clctxt.setServletPackageName(targetPackage);
   }
   
  -if( loader==null )
  -initClassLoader( clctxt );
  +if( loader==null ) {
  +originalClassLoader = initClassLoader( clctxt );
  +}
   
   clctxt.setClassLoader(loader);
   clctxt.setClassPath(classPath);
  @@ -877,6 +880,10 @@
 e.getMessage()));
   }
   throw new JasperException(e);
  +} finally {
  +if(originalClassLoader != null) {
  +
Thread.currentThread().setContextClassLoader(originalClassLoader);
  +}
   }
   }
   
  @@ -1082,7 +1089,15 @@
   tagPluginManager = new TagPluginManager(context);
   }
   
  -private void initClassLoader(JspCompilationContext clctxt)
  +/**
  + * Initializes the classloader for the given compilation
  + * context.
  + *
  + * @param clctxt The compilation context
  + * @return The original classloader before modifying
  + * @throws IOException If an error occurs
  + */
  +private ClassLoader initClassLoader(JspCompilationContext clctxt)
   throws IOException {
   
   classPath = getClassPath();
  @@ -1159,7 +1174,11 @@
   URL urlsA[]=new URL[urls.size()];
   urls.toArray(urlsA);
   loader = new URLClassLoader(urlsA, this.getClass().getClassLoader());
  +
  +ClassLoader originalClassLoader = 
Thread.currentThread().getContextClassLoader();
   Thread.currentThread().setContextClassLoader(loader);
  +
  +return originalClassLoader;
   }
   
   /**
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/webapps/docs changelog.xml

[pero]

pero2004/11/22 06:52:28

  Modified:webapps/docs changelog.xml
  Log:
  Move processExpiresFrequency check to ManagerBase and reflect change to all 
subclasses (StandardManager, PersientManagerBase, DeltaManager)
  Better log support to DeltaManager to see detail information at debug level.
  
  Revision  ChangesPath
  1.178 +11 -0 jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.177
  retrieving revision 1.178
  diff -u -r1.177 -r1.178
  --- changelog.xml 22 Nov 2004 14:44:55 -  1.177
  +++ changelog.xml 22 Nov 2004 14:52:28 -  1.178
  @@ -64,6 +64,9 @@
 
   32269: JNDIRealm fails with InvalidNameException to 
authenticate users if LDAP distinguished name (DN) contains slash or double 
quote character(s). (yoavs)
 
  + 
  +Move processExpiresFrequency check to ManagerBase and reflect change 
to all subclasses (StandardManager, PersientManagerBase, DeltaManager). (pero)
  +  
   
 
   
  @@ -75,6 +78,14 @@
 
   32330: JspC changes context classloader. (yoavs)
 
  +
  +  
  +  
  +  
  +
  +
  +  Better log support to DeltaManager to see detail information at 
debug level. (pero)
  +   
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session ManagerBase.java PersistentManagerBase.java StandardManager.java

[pero]

pero2004/11/22 06:50:23

  Modified:catalina/src/share/org/apache/catalina/session
ManagerBase.java PersistentManagerBase.java
StandardManager.java
  Log:
  Move processExpiresFrequency check to ManagerBase and reflect change to all 
subclasses (StandardManager, PersientManagerBase, DeltaManager)
  
  Revision  ChangesPath
  1.37  +95 -10
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java
  
  Index: ManagerBase.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/ManagerBase.java,v
  retrieving revision 1.36
  retrieving revision 1.37
  diff -u -r1.36 -r1.37
  --- ManagerBase.java  24 Sep 2004 14:55:13 -  1.36
  +++ ManagerBase.java  22 Nov 2004 14:50:23 -  1.37
  @@ -180,6 +180,25 @@
   protected int duplicates=0;
   
   protected boolean initialized=false;
  +
  +/**
  + * Processing time during session expiration.
  + */
  +protected long processingTime = 0;
  +
  +/**
  + * Iteration count for background processing.
  + */
  +private int count = 0;
  +
  +
  +/**
  + * Frequency of the session expiration, and related manager operations.
  + * Manager operations will be done once for the specified amount of
  + * backgrondProcess calls (ie, the lower the amount, the most often the
  + * checks will occur).
  + */
  +protected int processExpiresFrequency = 6;
   
   /**
* The string manager for this package.
  @@ -257,8 +276,6 @@
   Container oldContainer = this.container;
   this.container = container;
   support.firePropertyChange("container", oldContainer, 
this.container);
  -// TODO: find a good scheme for the log names
  -//log=LogFactory.getLog("tomcat.manager." + container.getName());
   }
   
   
  @@ -515,9 +532,11 @@
   this.random = new java.util.Random();
   this.random.setSeed(seed);
   }
  -long t2=System.currentTimeMillis();
  -if( (t2-t1) > 100 )
  -log.debug(sm.getString("managerBase.seeding", 
randomClass) + " " + (t2-t1));
  +if(log.isDebugEnabled()) {
  +long t2=System.currentTimeMillis();
  +if( (t2-t1) > 100 )
  +log.debug(sm.getString("managerBase.seeding", 
randomClass) + " " + (t2-t1));
  +}
   }
   }
   }
  @@ -571,6 +590,42 @@
   this.expiredSessions = expiredSessions;
   }
   
  +public long getProcessingTime() {
  +return processingTime;
  +}
  +
  +
  +public void setProcessingTime(long processingTime) {
  +this.processingTime = processingTime;
  +}
  +
  +/**
  + * Return the frequency of manager checks.
  + */
  +public int getProcessExpiresFrequency() {
  +
  +return (this.processExpiresFrequency);
  +
  +}
  +
  +/**
  + * Set the manager checks frequency.
  + *
  + * @param processExpiresFrequency the new manager checks frequency
  + */
  +public void setProcessExpiresFrequency(int processExpiresFrequency) {
  +
  +if (processExpiresFrequency <= 0) {
  +return;
  +}
  +
  +int oldProcessExpiresFrequency = this.processExpiresFrequency;
  +this.processExpiresFrequency = processExpiresFrequency;
  +support.firePropertyChange("processExpiresFrequency",
  +   new Integer(oldProcessExpiresFrequency),
  +   new 
Integer(this.processExpiresFrequency));
  +
  +}
   
   // - Public 
Methods
   
  @@ -579,8 +634,34 @@
* Implements the Manager interface, direct call to processExpires
*/
   public void backgroundProcess() {
  +count = (count + 1) % processExpiresFrequency;
  +if (count == 0)
  +processExpires();
   }
   
  +/**
  + * Invalidate all sessions that have expired.
  + */
  +public void processExpires() {
  +
  +long timeNow = System.currentTimeMillis();
  +Session sessions[] = findSessions();
  +int expireHere = 0 ;
  +
  +if(log.isDebugEnabled())
  +log.debug("Start expire sessions " + getName() + " at " + 
timeNow + " sessioncount " + sessions.length);
  +for (int i = 0; i < sessions.length; i++) {
  +if (!sessions[i].isValid()) {
  +expiredSessions++;
  +expireHere++;
  +}
  +}
  +long timeEnd = System.currentTimeMillis();
  +if(log.isDebugEnabled

Re: Website updates

[Mladen Turk]

Remy Maucherat wrote:
I propose the following changes to the main website:
- in the "Documentation" section, add "JK 1.2"
Since we'll maintain a single connector, IMO it should
be "Tomcat Connectors"
And perhaps 'Old JK documentation' for some time.
- add the new JK documentation to the website
- in the "Documentation" section, add "mod_proxy", linking to the Apache 
2.1 documentation
OK. But It's still work in progress :).
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java

[yoavs]

yoavs   2004/11/22 06:44:55

  Modified:webapps/docs changelog.xml
   jasper2/src/share/org/apache/jasper JspC.java
  Log:
  Bugzilla 32330: JspC changes context classloader
  
  Revision  ChangesPath
  1.177 +3 -0  jakarta-tomcat-catalina/webapps/docs/changelog.xml
  
  Index: changelog.xml
  ===
  RCS file: /home/cvs/jakarta-tomcat-catalina/webapps/docs/changelog.xml,v
  retrieving revision 1.176
  retrieving revision 1.177
  diff -u -r1.176 -r1.177
  --- changelog.xml 19 Nov 2004 16:58:11 -  1.176
  +++ changelog.xml 22 Nov 2004 14:44:55 -  1.177
  @@ -72,6 +72,9 @@
 
   Updated JspC usage messages to include recently added configurable 
parameters. (yoavs)
 
  +  
  +32330: JspC changes context classloader. (yoavs)
  +  
   
 
   
  
  
  
  1.90  +22 -3 
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
  
  Index: JspC.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
  retrieving revision 1.89
  retrieving revision 1.90
  diff -u -r1.89 -r1.90
  --- JspC.java 19 Nov 2004 14:30:22 -  1.89
  +++ JspC.java 22 Nov 2004 14:44:55 -  1.90
  @@ -812,6 +812,8 @@
   private void processFile(String file)
   throws JasperException
   {
  +ClassLoader originalClassLoader = null;
  +
   try {
   // set up a scratch/output dir if none is provided
   if (scratchDir == null) {
  @@ -835,8 +837,9 @@
   clctxt.setServletPackageName(targetPackage);
   }
   
  -if( loader==null )
  -initClassLoader( clctxt );
  +if( loader==null ) {
  +originalClassLoader = initClassLoader( clctxt );
  +}
   
   clctxt.setClassLoader(loader);
   clctxt.setClassPath(classPath);
  @@ -876,6 +879,10 @@
 e.getMessage()));
   }
   throw new JasperException(e);
  +} finally {
  +if(originalClassLoader != null) {
  +
Thread.currentThread().setContextClassLoader(originalClassLoader);
  +}
   }
   }
   
  @@ -1081,7 +1088,15 @@
   tagPluginManager = new TagPluginManager(context);
   }
   
  -private void initClassLoader(JspCompilationContext clctxt)
  +/**
  + * Initializes the classloader as/if needed for the given
  + * compilation context.
  + *
  + * @param clctxt The compilation context
  + * @return The original classloader before modifying
  + * @throws IOException If an error occurs
  + */
  +private ClassLoader initClassLoader(JspCompilationContext clctxt)
   throws IOException {
   
   classPath = getClassPath();
  @@ -1158,7 +1173,11 @@
   URL urlsA[]=new URL[urls.size()];
   urls.toArray(urlsA);
   loader = new URLClassLoader(urlsA, this.getClass().getClassLoader());
  +
  +ClassLoader originalClassLoader = 
Thread.currentThread().getContextClassLoader();
   Thread.currentThread().setContextClassLoader(loader);
  +
  +return originalClassLoader;
   }
   
   /**
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

RE: Website updates

[Shapira, Yoav]

Hi,
Seems reasonable...

Yoav Shapira http://www.yoavshapira.com


>-Original Message-
>From: Remy Maucherat [mailto:[EMAIL PROTECTED]
>Sent: Monday, November 22, 2004 9:39 AM
>To: Tomcat Developers List
>Subject: Website updates
>
>I propose the following changes to the main website:
>- in the "Documentation" section, add "JK 1.2"
>- add the new JK documentation to the website
>- in the "Documentation" section, add "mod_proxy", linking to the Apache
>2.1 documentation
>- when the next Tomcat 5.5 stable is released, update the "Tomcat
>Versions" chart with 5.5, and move the Tomcat 5.0 documentation link to
>the archives
>
>Rémy
>
>
>-
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]




This e-mail, including any attachments, is a confidential business 
communication, and may contain information that is confidential, proprietary 
and/or privileged.  This e-mail is intended only for the individual(s) to whom 
it is addressed, and may not be saved, copied, printed, disclosed or used by 
anyone else.  If you are not the(an) intended recipient, please immediately 
delete this e-mail from your computer system and notify the sender.  Thank you.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Website updates

[Remy Maucherat]

I propose the following changes to the main website:
- in the "Documentation" section, add "JK 1.2"
- add the new JK documentation to the website
- in the "Documentation" section, add "mod_proxy", linking to the Apache 
2.1 documentation
- when the next Tomcat 5.5 stable is released, update the "Tomcat 
Versions" chart with 5.5, and move the Tomcat 5.0 documentation link to 
the archives

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 30048] - Setting compressableMimeTypes is ignored.

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30048





--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:35 ---
Looking at the code, all the references are to compressableMimeTypes with an S 
at the end.  So it would appear the typo is in server.xml.  But it's strange 
that you say it works without the S, and fails with the S.  Is that also true 
on 5.0.28?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/valves ByteBufferAccessLogValve.java mbeans-descriptors.xml

[Remy Maucherat]

[EMAIL PROTECTED] wrote:
 Index: ByteBufferAccessLogValve.java
 ===
 /*
  * Copyright 2004 Sun Microsystems, Inc. All rights reserved.
  * SUN PROPRIETARY/CONFIDENTIAL. Use is subject to license terms.
  */
 

I noticed this ;)
Can you confirm you're allowed to contribute this class and remove the 
comment ?

Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 29091] - Non-ascii characters are not handled correctly...

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29091


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 15:12 ---
Per Mr. Ushakov's investigation and comments, I'm closing this issue.  Thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31567] - 505 request error from .NET client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31567





--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 12:25 ---
This report is invalid, please do not reopen it. The M$ client obviously misuses
expectations.
The solution is to either set this user-agent as restricted so that it uses
HTTP/1.0, or to disable keep-alive.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31269] - Configuration for Java 1.5 is too hairy

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31269





--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 12:23 ---
If you want to code with Java 5.0 inside your JSPs, you can:
- hack in the alpha JDT compiler
- configure Jasper to use Ant
- precompile your JSPs
Please do not reopen this bug report.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java

[Remy Maucherat]

[EMAIL PROTECTED] wrote:
billbarker2004/11/21 22:42:46
 Modified:http11/src/java/org/apache/coyote/http11
   Http11Processor.java
 Log:
 Reverting reversion of patch ;-)  

Sorry for the trouble ;)
Rémy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 31567] - 505 request error from .NET client

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31567





--- Additional Comments From [EMAIL PROTECTED]  2004-11-22 10:09 ---
Sorry for reopening. 

Shouldn't Tomcat somehow ignore the body of the first message? 

Doesn't the .NET Framework handle this correctly when it:
1. Posts soap message 
2. Receives 401 Unauthorized
3. Reposts and this time includes authorization data (since it was requested)



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]