Divorcing karma from CVS access? (Re: Vicious Abuse?)
On Sat, May 25, 2002 at 03:51:54PM +0100, Pier Fumagalli wrote: Jeff Turner [EMAIL PROTECTED] wrote: .. and thankful that people like Costin persevere in spite of rather vicious abuse. Vicious abuse? All I am proposing is to add greater flexibility to the freedom of those who are involved with the Jakarta project. I was objecting to unprovoked Costin-bashing outside tomcat-dev, not your proposal. People outside tomcat-dev may not understand why a PMC member deserved your comments ;P As for your proposal, a few thoughts: - AFAIK there is no requirement that a committer be a coder. See the definition on http://jakarta.apache.org/site/roles.html. An example: Diana Shannon voted as a Cocoon committer, for volunteering to coordinate docs: http://marc.theaimsgroup.com/?t=10189649374r=1w=2 - Your proposal redefined 'contributor' to include CVS access, and I think that will cause confusion with the existing, looser meaning. - (random thoughts..) The whole notion of defining a person's worth in terms of their CVS access seems backwards and wrong. The 'committer/non-committer' dividing line is an artifact of CVS's coarse-grained access control, and will disappear once we migrate to Subversion or whatever. It would be nice if there was a 'rating' system that didn't hijack the versioning system's terminology. Karma rated on a different scale to CVS access. Then there could be a one-way mapping, X karma - Y CVS access. The karma system could be something like advogato's (http://www.advogato.org/trust-metric.html http://www.advogato.org/person/). --Jeff -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: Wrong BUILDING.txt
On Sat, Mar 23, 2002 at 02:03:39PM +0100, Jose M. Palomar wrote: BUILDING.txt documentation file of CVS Tomcat 4 mentions the download of package commons-daemon. I've browsed builds directories searching for it and It was missing. What package replace this? It's in the jakarta-commons-sandbox CVS module. Doesn't look like it's being built nightly, so I think CVS is your only option. In theory, you can get any Gump-built jar from http://gump.covalent.net/jars/latest/, but it seems to be down ATM. --Jeff -- Jose M. Palomar www.talika.org -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
[PATCH] [3.3] etomcat target
Hi,
On the 17th, Costin added an 'etomcat' target:
Added a target to build 'embeded' style tomcat, i.e. a single jar containing
everything ( no more lib/container, etc ). It is self-runnable and should start
tomcat with the defaults settings ( no server.xml, etc ) using the current dir
as base. Just add webapps and shake.
This is nice for people who just need a simple jar with no strings attached (
configs, dir structure, etc ).
It looked pretty broken when I tried it. The attached patch gets it
compiled, I can now successfully start it by typing 'java
-Dtomcat.home=... -jar webserver.jar'.
The changes are:
- Declare dep on target that creates build/classes
- Change nonexistent ${servlet.jar} to ${servlet22.jar}
- Exclude all *SSL*, *JSSE*, *TLS* java files unless jsse.present. The
the previous approach of explicitly naming each class was not robust
enough. I found fully 9 other classes that weren't being excluded.
- Add the missing manifest.webserver, which I *guessed* should invoke
EmbededTomcat with the classpath crimson.jar and servlet22.jar
- Minor javadoc fixes in EmbededTomcat.java.
Incidentally, any tips on classloaders and EmbededTomcat? Everything
starts fine, but my servlet can't see any classes in WEB-INF/lib
*unless* I explicitly use the context classloader. Oh well, that's for
another mail.
Thanks,
--Jeff
? .bash_history
? .cvsrc
? .projrc
? .viminfo
? .vimrc
? etomcat.patch
Index: build.xml
===
RCS file: /home/cvspublic/jakarta-tomcat/build.xml,v
retrieving revision 1.162
diff -u -r1.162 build.xml
--- build.xml 2001/12/17 05:31:45 1.162
+++ build.xml 2001/12/25 14:00:15
@@ -598,7 +598,7 @@
!-- Embeded tomcat --
- target name=etomcat depends=init
+ target name=etomcat depends=init, prepare.dirs
javac destdir=${tomcat.build}/classes
debug=${debug}
optimize=${optimize}
@@ -608,28 +608,22 @@
pathelement location=${jsse.lib}/jsse.jar/
pathelement location=${jsse.lib}/jnet.jar/
pathelement location=${jsse.lib}/jcert.jar/
-pathelement location=${servlet.jar}/
+pathelement location=${servlet22.jar}/
/classpath
include name=org/apache/**/
- exclude name=**/util/net/SSLSocketFactory.java
+ exclude name=**/*SSL*.java
unless=jsse.present/
- exclude name=**/util/net/SSLSocketFactory.java
- unless=jdk12.present/
- exclude name=**/util/compat/JSSECertCompat.java
+ exclude name=**/*JSSE*.java
unless=jsse.present/
- exclude name=**/util/compat/JSSECertCompat.java
- unless=jdk12.present/
- exclude name=**/util/compat/Jdk12Support.java
+ exclude name=**/*TLS*.java
+ unless=jsse.present/
+ exclude name=**/util/compat/Jdk12Support.java
unless=jdk12.present/
exclude name=**/util/depend/DependClassLoader12.java
unless=jdk12.present/
exclude name=**/util/depend/DependClassLoader12.java
- unless=jdk12.present/
+ unless=jdk12.present/
exclude name=**/util/compat/Jdk12Support.java
- unless=jdk12.present/
- exclude name=**/util/compat/JSSECertCompat.java
- unless=jsse.present/
- exclude name=**/util/compat/JSSECertCompat.java
unless=jdk12.present/
/javac
@@ -657,7 +651,7 @@
mkdir dir=${etomcat} /
copy file=${jaxp.home}/crimson.jar todir=${etomcat} /
-copy file=${servlet.jar} todir=${etomcat} /
+copy file=${servlet22.jar} todir=${etomcat} /
jar jarfile=${etomcat}/webserver.jar
basedir=${tomcat.build}/classes
Index: src/build/manifests/manifest.webserver
===
RCS file: manifest.webserver
diff -N manifest.webserver
--- /dev/null Tue Dec 25 05:58:21 2001
+++ manifest.webserver Tue Dec 25 06:00:16 2001
@@ -0,0 +1,3 @@
+Manifest-Version: 1.0
+Main-Class: org.apache.tomcat.startup.EmbededTomcat
+Class-Path: crimson.jar servlet22.jar
Index: src/share/org/apache/tomcat/startup/EmbededTomcat.java
===
RCS file:
/home/cvspublic/jakarta-tomcat/src/share/org/apache/tomcat/startup/EmbededTomcat.java,v
retrieving revision 1.61
diff -u -r1.61 EmbededTomcat.java
--- src/share/org/apache/tomcat/startup/EmbededTomcat.java 2001/12/17 05:27:05
1.61
+++ src/share/org/apache/tomcat/startup/EmbededTomcat.java 2001/12/25 14:00:29
@@ -31,62 +31,65 @@
* Use this class to embed tomcat in your application. If all you want is to
* start/stop tomcat, with minimal customization, you can use Main.main()
*
- * This class is designed as a java bean, where you set different properties,
+ * pThis class is designed as a java bean, where you set different properties,
* then call
Re: DO NOT REPLY [Bug 5568] New: - Spelling: occured
This is the second time bugzilla has refused to let me attach a patch..
No file was provided, or it was empty., on Mozilla 0.9.3 and ns4.77.
Oh well, it's attached here.
--Jeff
? occurred.patch
Index: catalina/src/share/org/apache/catalina/cluster/LocalStrings.properties
===
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/cluster/LocalStrings.properties,v
retrieving revision 1.1
diff -u -r1.1 LocalStrings.properties
--- catalina/src/share/org/apache/catalina/cluster/LocalStrings.properties
2001/05/13 02:27:22 1.1
+++ catalina/src/share/org/apache/catalina/cluster/LocalStrings.properties
+2001/12/22 10:25:37
@@ -6,6 +6,6 @@
standardCluster.createReceiver=Creating a new receiver for {0}
standardCluster.createSender=Creating a new sender for {0}
standardCluster.invalidAddress=Invalid multicastAddress {0}
-standardCluster.joinException=An error occured when trying to join group {0}
-standardCluster.leaveException=An error occured when trying to leave group {0}
-multicastSender.sendException=An error occured when trying to replicate {0}
\ No newline at end of file
+standardCluster.joinException=An error occurred when trying to join group {0}
+standardCluster.leaveException=An error occurred when trying to leave group {0}
+multicastSender.sendException=An error occurred when trying to replicate {0}
Index: catalina/src/share/org/apache/catalina/cluster/MulticastReceiver.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/cluster/MulticastReceiver.java,v
retrieving revision 1.4
diff -u -r1.4 MulticastReceiver.java
--- catalina/src/share/org/apache/catalina/cluster/MulticastReceiver.java
2001/11/07 05:21:06 1.4
+++ catalina/src/share/org/apache/catalina/cluster/MulticastReceiver.java
+2001/12/22 10:25:38
@@ -235,10 +235,10 @@
if(obj.getSenderId().equals(this.senderId))
stack.add(obj);
} catch (IOException e) {
-log(An error occured when trying to replicate: +
+log(An error occurred when trying to replicate: +
e.toString());
} catch (ClassNotFoundException e) {
-log(An error occured when trying to replicate: +
+log(An error occurred when trying to replicate: +
e.toString());
}
}
Index: catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
retrieving revision 1.47
diff -u -r1.47 DefaultServlet.java
--- catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java 2001/12/21
21:15:45 1.47
+++ catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java 2001/12/22
+10:26:02
@@ -2033,7 +2033,7 @@
*
* @param istream The input stream to read from
* @param ostream The output stream to write to
- * @return Exception which occured during processing
+ * @return Exception which occurred during processing
*/
private IOException copyRange(InputStream istream,
ServletOutputStream ostream) {
@@ -2066,7 +2066,7 @@
*
* @param reader The reader to read from
* @param writer The writer to write to
- * @return Exception which occured during processing
+ * @return Exception which occurred during processing
*/
private IOException copyRange(Reader reader, PrintWriter writer) {
@@ -2100,7 +2100,7 @@
* @param ostream The output stream to write to
* @param start Start of the range which will be copied
* @param end End of the range which will be copied
- * @return Exception which occured during processing
+ * @return Exception which occurred during processing
*/
private IOException copyRange(InputStream istream,
ServletOutputStream ostream,
@@ -2152,7 +2152,7 @@
* @param writer The writer to write to
* @param start Start of the range which will be copied
* @param end End of the range which will be copied
- * @return Exception which occured during processing
+ * @return Exception which occurred during processing
*/
private IOException copyRange(Reader reader, PrintWriter writer,
long start, long end) {
Index: catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java,v
retrieving revision 1.25
diff -u -r1.25 WebdavServlet.java
--- catalina/src/share/org/apache/catalina/servlets/WebdavServlet.java 2001/09/14
[PATCH][3.3] tomcat.sh cleanup
Hi,
The help text displayed when you type ./tomcat.sh currently reads:
Usage:
tomcat (start|env|run|stop|jspc)
start - start tomcat in the background
run - start tomcat in the foreground
run -wait - wait until tomcat is initialized before returning
-security - use a SecurityManager when starting
stop - stop tomcat
env - set CLASSPATH and TOMCAT_HOME env. variables
jspc - run jsp pre compiler
This is out of date (missing 'enableAdmin' and 'estart'), is partially
incorrect (-wait applies to 'start', not 'run'), and is hard to read.
The attached patch fixes this, so it will print:
./tomcat.sh (start|run|stop|enableAdmin|estart|env|jspc)
start- start tomcat in the background
start -security - use a SecurityManager when starting
start -noout - redirect stdout/stderr to $TOMCAT_HOME/logs/stdout.log
start -wait - wait until tomcat is initialized before returning
run - start tomcat in the foreground
run -security- use a SecurityManager when starting
stop - stop tomcat
stop -force - stop tomcat with the 'kill' command if necessary
enableAdmin - Trust the admin web application,
i.e. rewrites conf/apps-admin.xml with trusted=true
estart - Start Tomcat using the/your EmbededTomcat class which
uses a hardcoded set of modules
env - set CLASSPATH and TOMCAT_HOME env. variables
jspc - run jsp pre compiler
The patch also fixes indentation, and parametrizes the MAX_WAIT variable to
reliably fix another doc bug.
Also, I noticed that line 294 contains:
TOMCAT_OPTS=$TOMCAT_OPTS -Djava.security.policy==${TOMCAT_HOME}/conf/tomcat.policy
Shouldn't that be a single '='? There is the same thing in tomcat.bat. Not
being sure of the implications, I haven't changed this in the patch.
--Jeff
Index: src/shell/tomcat.sh
===
RCS file: /home/cvspublic/jakarta-tomcat/src/shell/tomcat.sh,v
retrieving revision 1.30
diff -u -r1.30 tomcat.sh
--- src/shell/tomcat.sh 2001/09/20 03:35:41 1.30
+++ src/shell/tomcat.sh 2001/10/21 06:23:31
@@ -32,9 +32,9 @@
ls=`ls -ld $PRG`
link=`expr $ls : '.*- \(.*\)$'`
if expr $link : '.*/.*' /dev/null; then
- PRG=$link
+PRG=$link
else
- PRG=`dirname $PRG`/$link
+PRG=`dirname $PRG`/$link
fi
done
@@ -43,10 +43,10 @@
echo Guessing TOMCAT_INSTALL from tomcat.sh to ${TOMCAT_INSTALL_1}
fi
if [ -d ${TOMCAT_INSTALL_1}/lib ] ; then
- TOMCAT_INSTALL=${TOMCAT_INSTALL_1}
+TOMCAT_INSTALL=${TOMCAT_INSTALL_1}
if [ $DEBUG_HOMEFIND != false ] ; then
echo Setting TOMCAT_INSTALL to $TOMCAT_INSTALL
- fi
+fi
fi
fi
@@ -85,11 +85,11 @@
if [ $TOMCAT_HOME = ] ; then
if [ -d ./conf ] ; then
- TOMCAT_HOME=.
+TOMCAT_HOME=.
elif [ -d ../conf ] ; then
- TOMCAT_HOME=..
+TOMCAT_HOME=..
else
- TOMCAT_HOME=$TOMCAT_INSTALL
+TOMCAT_HOME=$TOMCAT_INSTALL
fi
fi
@@ -147,11 +147,12 @@
rm -f ${TOMCAT_HOME}/conf/ajp12.id
fi
+ MAX_WAIT=360
WAIT=0
if [ $1 = -wait ] ; then
shift
# wait at least 6 min
-WAIT=360
+WAIT=${MAX_WAIT}
fi
if [ $1 = -noout ] ; then
@@ -175,8 +176,8 @@
WAIT=`expr $WAIT - 1`
if [ $WAIT = 0 ] ; then
-echo Tomcat was no ready after 120 seconds, giving up waiting
- break;
+echo Tomcat was no ready after ${MAX_WAIT} seconds, giving up waiting
+break;
fi
done
fi
@@ -223,17 +224,17 @@
shift
CLASSPATH=.
for i in ${TOMCAT_HOME}/lib/container/* ${TOMCAT_HOME}/lib/common/* ; do
- CLASSPATH=${CLASSPATH}:$i
+CLASSPATH=${CLASSPATH}:$i
done
CLASSPATH=${CLASSPATH}:${JAVA_HOME}/lib/tools.jar
# Backdoor classpath setting for development purposes when all classes
- # are compiled into a /classes dir and are not yet jarred.
+# are compiled into a /classes dir and are not yet jarred.
if [ -d ${TOMCAT_HOME}/classes ]; then
- CLASSPATH=${TOMCAT_HOME}/classes:${CLASSPATH}
+CLASSPATH=${TOMCAT_HOME}/classes:${CLASSPATH}
fi
if [ $oldCP != ]; then
- CLASSPATH=${CLASSPATH}:${oldCP}
+CLASSPATH=${CLASSPATH}:${oldCP}
fi
(cd $TOMCAT_HOME; $JAVACMD $JSPC_OPTS -Dtomcat.home=${TOMCAT_HOME}
org.apache.jasper.JspC $@ )
@@ -266,15 +267,21 @@
else
echo Usage:
- echo tomcat (start|env|run|stop|jspc)
- echo start - start tomcat in the background
- echo run - start tomcat in the foreground
- echo run -wait - wait until tomcat is initialized before returning
- echo -security - use a SecurityManager when starting
- echo stop - stop tomcat
- echo
Re: [PATCH][3.3] tomcat.sh cleanup
On Sun, Oct 21, 2001 at 08:06:06AM -0400, Keith Wannamaker wrote:
It would be nice also to display the command that is used
to initialize the jk web config files, jkconf or whatever.
Oh yes.. you get that help currently if you type './tomcat.sh start -help'.
Rather than try to duplicate that, the attached revised patch adds 2 more
lines:
echo start -help - more options
echo start -help - more options
enableAdmin ought also to have -help, but it's currently broken.
--Jeff
Keith
Index: src/shell/tomcat.sh
===
RCS file: /home/cvspublic/jakarta-tomcat/src/shell/tomcat.sh,v
retrieving revision 1.30
diff -u -r1.30 tomcat.sh
--- src/shell/tomcat.sh 2001/09/20 03:35:41 1.30
+++ src/shell/tomcat.sh 2001/10/21 13:01:24
@@ -32,9 +32,9 @@
ls=`ls -ld $PRG`
link=`expr $ls : '.*- \(.*\)$'`
if expr $link : '.*/.*' /dev/null; then
- PRG=$link
+PRG=$link
else
- PRG=`dirname $PRG`/$link
+PRG=`dirname $PRG`/$link
fi
done
@@ -43,10 +43,10 @@
echo Guessing TOMCAT_INSTALL from tomcat.sh to ${TOMCAT_INSTALL_1}
fi
if [ -d ${TOMCAT_INSTALL_1}/lib ] ; then
- TOMCAT_INSTALL=${TOMCAT_INSTALL_1}
+TOMCAT_INSTALL=${TOMCAT_INSTALL_1}
if [ $DEBUG_HOMEFIND != false ] ; then
echo Setting TOMCAT_INSTALL to $TOMCAT_INSTALL
- fi
+fi
fi
fi
@@ -85,11 +85,11 @@
if [ $TOMCAT_HOME = ] ; then
if [ -d ./conf ] ; then
- TOMCAT_HOME=.
+TOMCAT_HOME=.
elif [ -d ../conf ] ; then
- TOMCAT_HOME=..
+TOMCAT_HOME=..
else
- TOMCAT_HOME=$TOMCAT_INSTALL
+TOMCAT_HOME=$TOMCAT_INSTALL
fi
fi
@@ -147,11 +147,12 @@
rm -f ${TOMCAT_HOME}/conf/ajp12.id
fi
+ MAX_WAIT=360
WAIT=0
if [ $1 = -wait ] ; then
shift
# wait at least 6 min
-WAIT=360
+WAIT=${MAX_WAIT}
fi
if [ $1 = -noout ] ; then
@@ -161,6 +162,7 @@
echo Using classpath: ${CLASSPATH}
echo Using JAVA_HOME: ${JAVA_HOME}
echo Using TOMCAT_HOME: ${TOMCAT_HOME}
+echo $JAVACMD $TOMCAT_OPTS -Dtomcat.home=${TOMCAT_HOME} $MAIN start $@
$JAVACMD $TOMCAT_OPTS -Dtomcat.home=${TOMCAT_HOME} $MAIN start $@
fi
@@ -175,8 +177,8 @@
WAIT=`expr $WAIT - 1`
if [ $WAIT = 0 ] ; then
-echo Tomcat was no ready after 120 seconds, giving up waiting
- break;
+echo Tomcat was no ready after ${MAX_WAIT} seconds, giving up waiting
+break;
fi
done
fi
@@ -223,17 +225,17 @@
shift
CLASSPATH=.
for i in ${TOMCAT_HOME}/lib/container/* ${TOMCAT_HOME}/lib/common/* ; do
- CLASSPATH=${CLASSPATH}:$i
+CLASSPATH=${CLASSPATH}:$i
done
CLASSPATH=${CLASSPATH}:${JAVA_HOME}/lib/tools.jar
# Backdoor classpath setting for development purposes when all classes
- # are compiled into a /classes dir and are not yet jarred.
+# are compiled into a /classes dir and are not yet jarred.
if [ -d ${TOMCAT_HOME}/classes ]; then
- CLASSPATH=${TOMCAT_HOME}/classes:${CLASSPATH}
+CLASSPATH=${TOMCAT_HOME}/classes:${CLASSPATH}
fi
if [ $oldCP != ]; then
- CLASSPATH=${CLASSPATH}:${oldCP}
+CLASSPATH=${CLASSPATH}:${oldCP}
fi
(cd $TOMCAT_HOME; $JAVACMD $JSPC_OPTS -Dtomcat.home=${TOMCAT_HOME}
org.apache.jasper.JspC $@ )
@@ -266,15 +268,23 @@
else
echo Usage:
- echo tomcat (start|env|run|stop|jspc)
- echo start - start tomcat in the background
- echo run - start tomcat in the foreground
- echo run -wait - wait until tomcat is initialized before returning
- echo -security - use a SecurityManager when starting
- echo stop - stop tomcat
- echo env - set CLASSPATH and TOMCAT_HOME env. variables
- echo jspc - run jsp pre compiler
-
+ echo $0 (start|run|stop|enableAdmin|estart|env|jspc)
+ echo start- start tomcat in the background
+ echo start -security - use a SecurityManager when starting
+ echo start -noout - redirect stdout/stderr to
+\$TOMCAT_HOME/logs/stdout.log
+ echo start -wait - wait until tomcat is initialized before returning
+ echo start -help - more options
+ echo run - start tomcat in the foreground
+ echo run -security- use a SecurityManager when starting
+ echo stop - stop tomcat
+ echo stop -force - stop tomcat with the 'kill' command if necessary
+ echo start -help - more options
+ echo enableAdmin - Trust the admin web application,
+ echo i.e. rewrites conf/apps-admin.xml with trusted=\true\
+ echo estart - Start Tomcat using the/your EmbededTomcat class which
+ echo uses a hardcoded set of modules
+ echo env - set CLASSPATH and
[PATCH][3.3] last minute doc fixes
Hi, Just did a sweep over the latest 3.3 docs, particularly the user guide, and picked up a few typos, apostrophe misuse and other stuff. Evidently tcsh users don't read user guides, because the tcsh-specific commands were all wrong. Patch attached.. --Jeff PS: by comparison with 3.2, the docs have been *greatly* improved. Someone has been very busy :) Index: src/doc/mod_jk-howto.html === RCS file: /home/cvspublic/jakarta-tomcat/src/doc/mod_jk-howto.html,v retrieving revision 1.14 diff -u -r1.14 mod_jk-howto.html --- src/doc/mod_jk-howto.html 2001/09/27 10:18:01 1.14 +++ src/doc/mod_jk-howto.html 2001/10/21 13:27:35 @@ -601,7 +601,7 @@ specified, defaults to ajp13 if an Ajp13Interceptor is in use, otherwise it defaults to ajp12./li libforwardAll/b - If true, forward all requests to Tomcat. -This helps insure that all the behavior configured in the web.xml +This helps ensure that all the behavior configured in the web.xml file functions correctly. If false, let Apache serve static resources. The default is true. Warning: When false, some configuration in the web.xml may not be duplicated in Apache. @@ -637,7 +637,7 @@ /blockquote differs from the file generated by Tomcat 3.2.x. In Tomcat 3.3, the default is to forward all requests to Tomcat for Tomcat's contexts (i.e. -forwardAll=true), excluding the root context. This helps insure +forwardAll=true), excluding the root context. This helps ensure that behavior configured in web.xml files will function properly. The configuration that best matches Tomcat 3.2.x behavior is: blockquote Index: src/doc/readme === RCS file: /home/cvspublic/jakarta-tomcat/src/doc/readme,v retrieving revision 1.21 diff -u -r1.21 readme --- src/doc/readme 2001/10/09 17:49:14 1.21 +++ src/doc/readme 2001/10/21 13:27:38 @@ -91,7 +91,7 @@ 6. The default auto-generated configuration files configure the external web server to send all requests for a context to Tomcat. That is the - best way to insure that behavior specified in the web application's + best way to ensure that behavior specified in the web application's web.xml functions properly. Also, by default, the configuration file doesn't try to send any requests for the root context to Tomcat. The external web server continues to serve its root context as they would Index: src/doc/serverxml.html === RCS file: /home/cvspublic/jakarta-tomcat/src/doc/serverxml.html,v retrieving revision 1.8 diff -u -r1.8 serverxml.html --- src/doc/serverxml.html 2001/10/19 03:16:13 1.8 +++ src/doc/serverxml.html 2001/10/21 13:27:46 @@ -32,7 +32,7 @@ number of settable properties and implements one or more 'hooks', providing a piece of functionality./p -pThe modules can be configured and assembled in sevaral ways, but the +pThe modules can be configured and assembled in several ways, but the default and most flexible mechanism uses XML files. Each module is described by an XML element, with attributes used to set module properties. The main configuration file is located in codeTOMCAT_HOME/conf/server.xml/code, used to @@ -69,8 +69,8 @@ h2Configuration Elements/h2 -pServer.xml is an XML document. Most elements corespond to tomcat modules, -with java setters beeing automatically associated with element attributes. The +pServer.xml is an XML document. Most elements correspond to tomcat modules, +with java setters being automatically associated with element attributes. The javadoc will contain most details, in this document we focus on the common and supported behaviors. /p @@ -105,8 +105,8 @@ dl dtlt;imodule_name/igt;/dt ddAdds a module to the configuration. Module names are defined in - module.xml, where each tag is associated with a class name that - implements the module. Each element attribute coresponds to a setter + modules.xml, where each tag is associated with a class name that + implements the module. Each element attribute corresponds to a setter method in the implementing class./dd dtlt;Contextgt;/dt ddDefines a web application. This is a legacy method of specifying a @@ -654,7 +654,7 @@ /tr tr valign=top tdforwardAll/td -tdIf codetrue/code, forward all requests to Tomcat. This helps insure that all the +tdIf codetrue/code, forward all requests to Tomcat. This helps ensure that +all the behavior configured in the web.xml file functions correctly. If codefalse/code, let Apache serve static resources. Warning: When codefalse/code, some configuration in the web.xml may not be duplicated in Apache. Review the mod_jk @@ -996,7 +996,7 @@ h4Description/h4 -pHandles incomming HTTP, or optionally HTTPS,
Re: [PATCH][3.3] tomcat.sh cleanup
On Sun, Oct 21, 2001 at 11:16:31PM +1000, Jeff Turner wrote:
On Sun, Oct 21, 2001 at 08:06:06AM -0400, Keith Wannamaker wrote:
It would be nice also to display the command that is used
to initialize the jk web config files, jkconf or whatever.
Oh yes.. you get that help currently if you type './tomcat.sh start -help'.
Rather than try to duplicate that, the attached revised patch adds 2 more
lines:
echo start -help - more options
echo start -help - more options
Feh.. that's as nonsensical as it sounds. Fixed patch attached. Extra entries:
start -help - more options
(config, debug, estart, home, install, jkconf, sandbox)
stop -help - more options
(ajpid, host, home, pass, port)
--Jeff
enableAdmin ought also to have -help, but it's currently broken.
--Jeff
Keith
Index: src/shell/tomcat.sh
===
RCS file: /home/cvspublic/jakarta-tomcat/src/shell/tomcat.sh,v
retrieving revision 1.30
diff -u -r1.30 tomcat.sh
--- src/shell/tomcat.sh 2001/09/20 03:35:41 1.30
+++ src/shell/tomcat.sh 2001/10/21 14:05:44
@@ -32,9 +32,9 @@
ls=`ls -ld $PRG`
link=`expr $ls : '.*- \(.*\)$'`
if expr $link : '.*/.*' /dev/null; then
- PRG=$link
+PRG=$link
else
- PRG=`dirname $PRG`/$link
+PRG=`dirname $PRG`/$link
fi
done
@@ -43,10 +43,10 @@
echo Guessing TOMCAT_INSTALL from tomcat.sh to ${TOMCAT_INSTALL_1}
fi
if [ -d ${TOMCAT_INSTALL_1}/lib ] ; then
- TOMCAT_INSTALL=${TOMCAT_INSTALL_1}
+TOMCAT_INSTALL=${TOMCAT_INSTALL_1}
if [ $DEBUG_HOMEFIND != false ] ; then
echo Setting TOMCAT_INSTALL to $TOMCAT_INSTALL
- fi
+fi
fi
fi
@@ -85,11 +85,11 @@
if [ $TOMCAT_HOME = ] ; then
if [ -d ./conf ] ; then
- TOMCAT_HOME=.
+TOMCAT_HOME=.
elif [ -d ../conf ] ; then
- TOMCAT_HOME=..
+TOMCAT_HOME=..
else
- TOMCAT_HOME=$TOMCAT_INSTALL
+TOMCAT_HOME=$TOMCAT_INSTALL
fi
fi
@@ -147,11 +147,12 @@
rm -f ${TOMCAT_HOME}/conf/ajp12.id
fi
+ MAX_WAIT=360
WAIT=0
if [ $1 = -wait ] ; then
shift
# wait at least 6 min
-WAIT=360
+WAIT=${MAX_WAIT}
fi
if [ $1 = -noout ] ; then
@@ -175,8 +176,8 @@
WAIT=`expr $WAIT - 1`
if [ $WAIT = 0 ] ; then
-echo Tomcat was no ready after 120 seconds, giving up waiting
- break;
+echo Tomcat was not ready after ${MAX_WAIT} seconds, giving up waiting
+break;
fi
done
fi
@@ -223,17 +224,17 @@
shift
CLASSPATH=.
for i in ${TOMCAT_HOME}/lib/container/* ${TOMCAT_HOME}/lib/common/* ; do
- CLASSPATH=${CLASSPATH}:$i
+CLASSPATH=${CLASSPATH}:$i
done
CLASSPATH=${CLASSPATH}:${JAVA_HOME}/lib/tools.jar
# Backdoor classpath setting for development purposes when all classes
- # are compiled into a /classes dir and are not yet jarred.
+# are compiled into a /classes dir and are not yet jarred.
if [ -d ${TOMCAT_HOME}/classes ]; then
- CLASSPATH=${TOMCAT_HOME}/classes:${CLASSPATH}
+CLASSPATH=${TOMCAT_HOME}/classes:${CLASSPATH}
fi
if [ $oldCP != ]; then
- CLASSPATH=${CLASSPATH}:${oldCP}
+CLASSPATH=${CLASSPATH}:${oldCP}
fi
(cd $TOMCAT_HOME; $JAVACMD $JSPC_OPTS -Dtomcat.home=${TOMCAT_HOME}
org.apache.jasper.JspC $@ )
@@ -266,15 +267,25 @@
else
echo Usage:
- echo tomcat (start|env|run|stop|jspc)
- echo start - start tomcat in the background
- echo run - start tomcat in the foreground
- echo run -wait - wait until tomcat is initialized before returning
- echo -security - use a SecurityManager when starting
- echo stop - stop tomcat
- echo env - set CLASSPATH and TOMCAT_HOME env. variables
- echo jspc - run jsp pre compiler
-
+ echo $0 (start|run|stop|enableAdmin|estart|env|jspc)
+ echo start- start tomcat in the background
+ echo start -security - use a SecurityManager when starting
+ echo start -noout - redirect stdout/stderr to
+\$TOMCAT_HOME/logs/stdout.log
+ echo start -wait - wait until tomcat is initialized before returning
+ echo start -help - more options
+ echo (config, debug, estart, home, install, jkconf,
+sandbox)
+ echo run - start tomcat in the foreground
+ echo run -security- use a SecurityManager when starting
+ echo stop - stop tomcat
+ echo stop -force - stop tomcat with the 'kill' command if necessary
+ echo stop -help - more options
+ echo (ajpid, host, home, pass, port)
+ echo enableAdmin - Trust the admin web application,
+ echo i.e
[PATCH][3.3] broken links
The attached patch fixes two broken links, one from the main
doc/index.html page.
--Jeff
Index: src/doc/Tomcat-Workers-HowTo.html
===
RCS file: /home/cvspublic/jakarta-tomcat/src/doc/Tomcat-Workers-HowTo.html,v
retrieving revision 1.2
diff -u -r1.2 Tomcat-Workers-HowTo.html
--- src/doc/Tomcat-Workers-HowTo.html 2001/01/30 04:27:38 1.2
+++ src/doc/Tomcat-Workers-HowTo.html 2001/10/22 04:10:18
@@ -5,7 +5,7 @@
!-- Copyright 1999, Apache Software Foundation --
meta http-equiv=Content-Type content=text/html
-link rel=stylesheet href=uguide/style.css
+link rel=stylesheet href=style.css
style type=text/css
td {
background-color: #E0E0E0;
Index: src/doc/readme
===
RCS file: /home/cvspublic/jakarta-tomcat/src/doc/readme,v
retrieving revision 1.22
diff -u -r1.22 readme
--- src/doc/readme 2001/10/21 17:40:17 1.22
+++ src/doc/readme 2001/10/22 04:10:19
@@ -39,7 +39,7 @@
Kit 1.1 or later environment, including JDKs conformant with Java2.
For detailed information about installing and running Tomcat, point your
-browser at the file tomcat_ug.html found in the same directory as this
+browser at the file tomcat-ug.html found in the same directory as this
file.
IMPORTANT NOTE: Some major changes have occurred in Tomcat 3.3 which
Index: src/doc/appdev/introduction.html
===
RCS file: /home/cvspublic/jakarta-tomcat/src/doc/appdev/introduction.html,v
retrieving revision 1.2
diff -u -r1.2 introduction.html
--- src/doc/appdev/introduction.html2000/03/28 00:44:11 1.2
+++ src/doc/appdev/introduction.html2001/10/22 04:10:20
@@ -93,7 +93,7 @@
chapters on servlet and JSP design are useful even when your application
does not require other J2EE platform components.
brbr
-lia href=../uguide/tomcat_ug.html target=_top../uguide/tomcat_ug.html/a -
+lia href=../tomcat-ug.html target=_top../tomcat-ug.html/a -
iTomcat - A Minimalistic User's Guide/i. This document covers the
detailed steps required to download and install Tomcat, including
configuration for a variety of environments. This guide is included
Re: [Tomcat 4.1] Proposed Slight Binary Distribution Rearrangement
How about naming it common instead of shared, to match Tomcat 3.3? --Jeff On Tue, Oct 02, 2001 at 04:54:54PM -0700, Craig R. McClanahan wrote: I'd like to propose a small change in the binary distribution layout for the next version of Tomcat (4.1). It's probably not a good idea to introduce this in a 4.0.1 maintenance update, though. Currently, the Shared class loader is set up based on unpacked classes in the $CATALINA_HOME/classes directory plus JAR files in the $CATALINA_HOME/lib directory. I would like to suggest that we change this to $CATALINA_HOME/shared/classes and $CATALINA_HOME/shared/lib instead, to have the directory names be more consistent with the class loader names. Anybody have any comments or thoughts on this? Craig
[PATCH] manager-howto error
Hi, In the manager app howto: http://jakarta.apache.org/tomcat/tomcat-4.0-doc/manager-howto.html The example for section Deploy A New Application is wrong. The following: http://localhost:8080/manager/install?path=/barwar=file:/path/to/bar.war ought to be: http://localhost:8080/manager/install?path=/barwar=jar:file:/path/to/bar.war!/ The attached patch fixes this, and adds an example using war=jar:http://..; thanks, --Jeff Index: webapps/tomcat-docs/manager-howto.xml === RCS file: /home/cvspublic/jakarta-tomcat-4.0/webapps/tomcat-docs/manager-howto.xml,v retrieving revision 1.3 diff -u -r1.3 manager-howto.xml --- webapps/tomcat-docs/manager-howto.xml 2001/09/13 15:49:15 1.3 +++ webapps/tomcat-docs/manager-howto.xml 2001/09/14 03:06:25 @@ -179,7 +179,9 @@ source http://localhost:8080/manager/install?path=/fooamp;war=file:/path/to/foo -http://localhost:8080/manager/install?path=/baramp;war=file:/path/to/bar.war +http://localhost:8080/manager/install?path=/baramp;war=jar:file:/path/to/bar.war!/ + +http://localhost:8080/manager/install?path=/baramp;war=jar:http://server:port/to/bar.war!/ + /source pInstall and start a new web application, attached to the specified context
Env variables (Re: cvs commit: jakarta-tomcat/src/shell tomcat.sh)
On Fri, Sep 14, 2001 at 04:11:20AM -, [EMAIL PROTECTED] wrote: ( well, I'm a lazy user as I never set TOMCAT_HOME, too many instances on my machine :-) I think that's useful advice generally. If the startup script of your app can automagically figure out the *_HOME directory, let it. A wrongly set TOMCAT_HOME left over from a previous installation (or ANT_HOME, etc) can cause lots of confusion. --Jeff
Re: xsl by extension
Ummm... perhaps invoke Jasper from your servlet?
Class clazz = Class.forName(org.apache.jasper.servlet.JspServlet);
HttpServlet jsp = (HttpServlet) clazz.newInstance();
jsp.init(context);
jsp.service(request, response);
That code is from Cocoon 2's JspGenerator, which uses Jasper to create
XML with JSP, which is then transformed and rendered in the Cocoon
pipeline.
--Jeff
On Thu, Sep 06, 2001 at 09:15:29PM +, javi . wrote:
hello everybody!!
i'm new here, and so excuse me if this thread has been
started (and closed) before. and xcuse me for my spelling ;)
my native language is java.
i'm trying to add to tomcat a nice feature of resin:
automatically apply a xsl transformation over all files
with .xtp extension (xml templates).
i've already done it, simply associating that extension
to my servlet. the servlet read the xsl path
from the .xtp itself.
the problem is that i want to allow the jsp code in the
xtp file to be executed, so i must retrieve it via http and not from
the os file system... but when i do it, of course, my
xtp servlet catch de call and began a recursive loop!
is there any way to avoid that? i've look at the code
by about ten hours and i don't see how to manage this
problem...
thank you very much in advance.
Javi Moreno (jv)
ps: i promise to post the servlet ;)
pps: yes, i will try {to take another English course...}
Re: Nice script to change all those cvsroots?
A collection of invaluable scripts for CVS: http://www.red-bean.com/cvsutils/ cvsco is the one I use daily.. removes all local modifications. Among them: cvschroot makes it possible to change CVS/Root in all subdirectories to the given value. --Jeff On Fri, Jul 20, 2001 at 12:22:32AM +0200, Martin van den Bemt wrote: Has anyone got a nice script to replace the jakarta.apache.org cvsroot to the cvs.apache.org cvs root? It's a lot of time to checkout everything again and gives lot's of other problems (losing changes I made to ant and tomcat eg..). It is for linux btw. Just a not : I have a checkout of all the jakarta projects, so I will save a lot of traffic to the cvs server with a nice change script.. (I'm not a guru on bash scripts..) Mvgr, Martin
Better instructions for getting JSSE/JMX?
Hi, I've been trying for the last half-hour to get JSSE and JMX to build Tomcat 4.0. Could someone provide instructions for traversing the password-protected recursive mess that is the Sun site? I've progressed through these pages: http://java.sun.com/products/jsse/ http://jsecom9a.sun.com/ECom/docs/SignOn.jsp?LMLoadBalanced=LMLoadBalanced= http://jsecom9a.sun.com/servlet/EComActionServlet/ECom.WelcomePageInfo Where I get to this page: " To get more information about a product, select the product from the list below: Insight Services Solaris 8 StarOffice Sun GridEngine " None of these have ANY relation to getting JSSE! So I try the "Download centre" link: http://www.sun.com/software/shop/index.html Which leads right back to the original page, http://java.sun.com/products/jsse/ AAARGGHHH.. --Jeff
Jasper Bug 652 (do*Body not called): not a bug?
Hi, Having a look through bug 652: BodyTag doInitBody and doAfterBody called on tags without body (http://znutar.cortexity.com/BugRatViewer/ShowReport/652) I don't think this is a bug. The JSP spec, p88, says: "If an action element can have a non-empty body and is interested in the content of that body, the methods doInitBody() and doAfterBody(), defined in the BodyTag interface are involved." Note, "can have", not "if it does have". So an element without a body, but that *could* have a body according to the TLD, still has do*Body methods called. So: my:tagfoo/my:tag has do*Body() called (obviously). my:tag/my:tag has do*Body() called (the body will just be blank) my:tag/ has do*Body() called, because according to the XML spec, this is shorthand for the my:tag/my:tag notation, and therefore processes equivalently. Interestingly, JRun3.0 has the opposite bug, and doesn't call setBodyContent if the tag doesn't have a body but could. Eg, in JRun the following action breaks: util:include url="foo.html"/ But this works: util:include url="foo.html"/util:include The taglib in question is from the Jakarta Taglibs project. Regards, --Jeff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, email: [EMAIL PROTECTED]
Re: CVS Help
On Mon, 11 Dec 2000, Sean wrote: I am trying to get CVS working on my machine so I can get download the latest Tomcat codebase but ... the documentation on the website does not say what or how to get a login and password to the CVS server. How do I get these so I can get access to the server? Any help you can provide on getting CVS up and running would be appreciated. There's pretty decent instructions at http://jakarta.apache.org/site/cvsindex.html It assumes you've got a CVS client installed properly (not a topic for this list; mail me privately if you like). --Jeff Sean
Re: [PROPOSAL] JSSI for Tomcat
-- God made the integers; all else is the work of Man. -- Kronecker On Sun, 10 Dec 2000, Hans Bergsten wrote: [EMAIL PROTECTED] wrote: [...] 1) Make this a new Jakarta subproject, named jakarta-jssi. The reason for this is that it's an optional module and it can live its own life outside the container development. +1 - but I would like more a "generic" name ( jakarta-jsse - java server side extensions ). JSSI seems a small project and it may not be worth the overhead of a top level modules. That will reduce the pressure on tomcat for developing feature-isms and non-standard extensions, and will keep it more focused on strict implementation of the servlet API. The extensions could be developed independent of tomcat, and maybe will be reused in other containers. As an additional benefit, people will not confuse "extensions" with "standards" :-) That's a good idea, and jakarta-jsse is as good a name as any ;-) If I may be the first to throw cold water on that name.. JSSE already stands for Java Secure Socket Extension (http://java.sun.com/products/jsse/), which is necessary for Tomcat's SSL support. Just imagine the confusion.. ;) [snip] --Jeff Hans -- Hans Bergsten [EMAIL PROTECTED] Gefion Software http://www.gefionsoftware.com Author of JavaServer Pages (O'Reilly), http://TheJSPBook.com
Re: [BUG] servlet-mapping breaks after misrequest
On Sat, 11 Nov 2000, Craig R. McClanahan wrote: Hi Jeff, Well, your reported behavior is definitely repeatable. But, after analyzing it, my conclusion is "user error ... don't do that". [snip "bug" report] What do you think? Fine :) I think it might be worth a FAQ entry though. I'll write one up unless I hear any objections. All the best, --Jeff --Jeff Craig McClanahan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[BUG] servlet-mapping breaks after misrequest
Hi, Sorry if someone's reported this before, I just found a bug that affects (at least) Tomcat 3.2b3 up to 3.3dev from CVS. The bug lets the user see the source for files mapped to servlets via the servlet-mapping tag in web.xml. The bug usually occurs during development, so it shouldn't be an issue with stable production sites. In the WEB-INF/web.xml file, one can remap URIs to servlets. This mapping doesn't take place when you re-request a page that previously didn't exist (the "misrequest" of the subject line), and the user gets delivered uninterpreted source. The most common situation is you request a mapped page from a webapp that doesn't exist, realise your mistake, regenerate the webapp and request the page again. You'll see the page source, as the page hasn't been interpreted by it's associated servlet. To reproduce the bug: 1) Create a small webapp ~/tomcatbug which maps *.xyz to the JSP interpreter, using the following script if you like: #!/bin/sh cd ~ mkdir -p tomcatbug/WEB-INF || exit cat tomcatbug/WEB-INF/web.xml EOF web-app servlet-mapping servlet-namejsp/servlet-name url-pattern*.xyz/url-pattern /servlet-mapping /web-app EOF cat tomcatbug/date.xyz EOF %@ page import="java.util.*" % %= (new java.util.Date() ).toLocaleString() % EOF 2) Add the "tomcatbug" context to your $TOMCAT_HOME/conf/server.xml: Context path="/tomcatbug" docBase="/home/jeff/tomcatbug" debug="9" reloadable="true" trusted="false" /Context (modify the docBase as appropriate). 3) Restart Tomcat 4) Verify that the webapp works and "date.xyz" works as expected. 5) Move ~/tomcatbug to ~/tomcatbug~ 6) Restart Tomcat 7) Request date.xyz. You should get the expected error: Not Found (404) Original request/tomcatbug/tomcat.notFoundHandler 8) Move ~/tomcatbug~ to ~/tomcatbug 9) Request date.xyz. You'll see the raw source: %@ page import="java.util.*" % %= (new java.util.Date() ).toLocaleString() % Btw, it's not the JSP interpreter's fault; I originally found the bug mapping *.xml to the Cocoon servlet. --Jeff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
