DO NOT REPLY [Bug 13081] - ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081 ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2002-10-03 16:18 --- *** This bug has been marked as a duplicate of 13132 *** -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 13081] - ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081 ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes --- Additional Comments From [EMAIL PROTECTED] 2002-10-01 16:48 --- See evaluation of 13132 for additional information. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 13081] - ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081
ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
--- Additional Comments From [EMAIL PROTECTED] 2002-10-01 18:21 ---
This problem is mostly unrelated to bug 13132 referenced in the last comment.
This is extremely easy to reproduce and I believe still well within the scope of
the JSP specification. Take for instance a very simple snippet of JSP code:
prefix:outerTag
prefix:innerTag id=x /
prefix:innerTag id=x /
/prefix:outerTag
This snippet will work fine in 4.1.x, but with one minor modification the page
will no longer compile.
prefix:outerTag
% if (true) { %
prefix:innerTag id=x /
% } %
prefix:innerTag id=x /
/prefix:outerTag
We have this in our pages. Even in our pages that are made up almost entirely
of tags, we have conditional statements like this. We feel that they are
REQUIRED because the overhead of the generated code required to invoke a tag is
too high when compared to a simple conditional check such as this.
As long as scriptlets are supported in JSP, this construct should be handled
correctly by Jasper or at least be made to conditionally handle this situation
via a configuration mechanism as I suggest in the original bug comments. I
would be more than willing to put together a patch for this configurable
support, if it would be accepted by the development team. Otherwise, it isn't
worth my time to build a patch and be constantly out of sync with the base
Tomcat codebase.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 13081] - ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081
ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
--- Additional Comments From [EMAIL PROTECTED] 2002-10-01 19:46 ---
I do believe the problem stated in 13132 does apply to your situation. Remember
13132 started out with this code fragment:
% if (condition) { %
i18n:message key=some.key id=myID/
% } else { %
i18n:message key=some.other.key id=myID/
% }
%
which is exactly what you are trying to do. The purpose of the example I gave in
the evaluation of 13132 is to show that some developers may rely on AT_END
variables to be declared after the call to the tag handler's doEndTag() method,
so that a nested tag may declare an AT_END variable of the same name, but with a
different type than an AT_END variable declared by the enclosing tag.
Would the workaround that I suggested for bug 13132 work for you, i.e., do
something like the following:
prefix:outerTag
% if (true) { %
prefix:innerTag id=x /
% } %
prefix:innerTag id=y /
/prefix:outerTag
I am little reluctant adding a configuration property for this, as it would not
be portable across containers.
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 13081] - ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081 ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes [EMAIL PROTECTED] changed: What|Removed |Added Severity|Blocker |Major --- Additional Comments From [EMAIL PROTECTED] 2002-09-27 14:57 --- Quite frankly, this is more likely to get fixed by fixing the spec rather than fixing Tomcat. Of course, the spec / Jasper gurus have the final word. Anyway, if I were you, I'd plan to either stick with Jasper 1 (I would use TC 4.1.12 + Jasper 1, as detailed in the 4.1.12 release notes, to get more reliability and performance) or fix my code (I think refactoring to get good code can't hurt in the long run). -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 13081] - ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13081 ScriptingVariableVisitor#setScriptingVars does not account for scriptlet scopes --- Additional Comments From [EMAIL PROTECTED] 2002-09-27 15:12 --- Remy, Thanks for the response. I understand what you are getting at. Unfortunately, although we would like to go strictly tags based, some of the platforms that we are trying to run on don't do tags very well... The extra generated code in the JSP servlets absolutely kills performance. Until we can remove support for that platform, we are stuck with a mix of Java scriplets and tags in some cases. That is our reality. I can take a look at using Jasper1 with 4.1.12, but unfortunately Jasper2 does some nice new code generation that would further help our performance in the cases that we do tags. We would like to be able to take advantage of that. As for the spec, you can certainly argue this one either way. I agree that clarification is probably necessary. I would also say that I believe as long as Java scriptlets are allowed in the pages by spec, that the page generation should not be allowed to do anything that would break because of that. -- To unsubscribe, e-mail: mailto:[EMAIL PROTECTED] For additional commands, e-mail: mailto:[EMAIL PROTECTED]
