RE: suggestion for taglib process
Howdy, Great! I'm glad you have an enhancement in mind: when you contribute a patch I'll be glad to review and commit it. ;) Yoav Shapira Millennium ChemInformatics >-Original Message- >From: Edson Alves Pereira [mailto:[EMAIL PROTECTED] >Sent: Tuesday, December 30, 2003 3:46 PM >To: 'Tomcat-User List' >Subject: suggestion for taglib process > > Hello folks, i´d like to see all error Tomcat´s messages related with >taglib changed to display exactly the taglib that the error cames from, for >example, take a look in this message: > >org.apache.jasper.JasperException: >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter method >for attribute: required > > I think it could be better if this message above would be like: > >org.apache.jasper.JasperException: >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter method >for attribute: required for oslib.tagext.NumberTag > > Regards, > Edson This e-mail, including any attachments, is a confidential business communication, and may contain information that is confidential, proprietary and/or privileged. This e-mail is intended only for the individual(s) to whom it is addressed, and may not be saved, copied, printed, disclosed or used by anyone else. If you are not the(an) intended recipient, please immediately delete this e-mail from your computer system and notify the sender. Thank you. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: suggestion for taglib process
I´m not sure this is the best change for Generator, maybe i must
know tomcat´s source in deep. But is here what we need.
///
//Old
org.apache.tomcat.jasper.compiler.Generator:1450
String attrName = attrs[i].getName();
Method m = handlerInfo.getSetterMethod(attrName);
if (m == null) {
err.jspError(n, "jsp.error.unable.to_find_method",
attrName);
}
///
New:
org.apache.tomcat.jasper.compiler.Generator:1450
StringBuffer sbMsg = null;
String attrName = attrs[i].getName();
Method m = handlerInfo.getSetterMethod(attrName);
if (m == null) {
sbMsg = new StringBuffer( );
sbMsg.append( ""jsp.error in [ " );
sbMsg.append(
handlerInfo.getTagHandlerClass( ).getName( ));
sbMsg.append( " ], unable.to_find_method "
);
err.jspError(
n,
sbMsg.toString( ),
attrName);
}
> --
> De: Shapira, Yoav[SMTP:[EMAIL PROTECTED]
> Responder:Tomcat Users List
> Enviada: quarta-feira, 31 de dezembro de 2003 10:46
> Para: Tomcat Users List
> Assunto: RE: suggestion for taglib process
>
>
> Howdy,
> Great! I'm glad you have an enhancement in mind: when you contribute a
> patch I'll be glad to review and commit it. ;)
>
> Yoav Shapira
> Millennium ChemInformatics
>
>
> >-Original Message-
> >From: Edson Alves Pereira [mailto:[EMAIL PROTECTED]
> >Sent: Tuesday, December 30, 2003 3:46 PM
> >To: 'Tomcat-User List'
> >Subject: suggestion for taglib process
> >
> > Hello folks, i´d like to see all error Tomcat´s messages related with
> >taglib changed to display exactly the taglib that the error cames from,
> for
> >example, take a look in this message:
> >
> >org.apache.jasper.JasperException:
> >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter
> method
> >for attribute: required
> >
> > I think it could be better if this message above would be like:
> >
> >org.apache.jasper.JasperException:
> >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter
> method
> >for attribute: required for oslib.tagext.NumberTag
> >
> > Regards,
> > Edson
>
>
>
>
> This e-mail, including any attachments, is a confidential business
> communication, and may contain information that is confidential,
> proprietary and/or privileged. This e-mail is intended only for the
> individual(s) to whom it is addressed, and may not be saved, copied,
> printed, disclosed or used by anyone else. If you are not the(an)
> intended recipient, please immediately delete this e-mail from your
> computer system and notify the sender. Thank you.
>
>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
RE: suggestion for taglib process
Howdy,
Actually, this seems very reasonable. Please submit it to Bugzilla as an enhancement
request and attach your code diff. Thanks ;)
Yoav Shapira
Millennium ChemInformatics
>-Original Message-
>From: Edson Alves Pereira [mailto:[EMAIL PROTECTED]
>Sent: Monday, January 05, 2004 9:46 AM
>To: 'Tomcat Users List'
>Subject: RE: suggestion for taglib process
>
> I´m not sure this is the best change for Generator, maybe i must
>know tomcat´s source in deep. But is here what we need.
>
>///
>//Old
>org.apache.tomcat.jasper.compiler.Generator:1450
>
> String attrName = attrs[i].getName();
> Method m = handlerInfo.getSetterMethod(attrName);
> if (m == null) {
> err.jspError(n, "jsp.error.unable.to_find_method",
> attrName);
> }
>
>///
>New:
>org.apache.tomcat.jasper.compiler.Generator:1450
>
> StringBuffer sbMsg = null;
> String attrName = attrs[i].getName();
> Method m = handlerInfo.getSetterMethod(attrName);
> if (m == null) {
> sbMsg = new StringBuffer( );
> sbMsg.append( ""jsp.error in [ " );
> sbMsg.append(
>handlerInfo.getTagHandlerClass( ).getName( ));
> sbMsg.append( " ], unable.to_find_method "
>);
>
> err.jspError(
> n,
> sbMsg.toString( ),
> attrName);
> }
>
>
>> --
>> De: Shapira, Yoav[SMTP:[EMAIL PROTECTED]
>> Responder: Tomcat Users List
>> Enviada: quarta-feira, 31 de dezembro de 2003 10:46
>> Para:Tomcat Users List
>> Assunto: RE: suggestion for taglib process
>>
>>
>> Howdy,
>> Great! I'm glad you have an enhancement in mind: when you contribute a
>> patch I'll be glad to review and commit it. ;)
>>
>> Yoav Shapira
>> Millennium ChemInformatics
>>
>>
>> >-Original Message-
>> >From: Edson Alves Pereira [mailto:[EMAIL PROTECTED]
>> >Sent: Tuesday, December 30, 2003 3:46 PM
>> >To: 'Tomcat-User List'
>> >Subject: suggestion for taglib process
>> >
>> > Hello folks, i´d like to see all error Tomcat´s messages related with
>> >taglib changed to display exactly the taglib that the error cames from,
>> for
>> >example, take a look in this message:
>> >
>> >org.apache.jasper.JasperException:
>> >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter
>> method
>> >for attribute: required
>> >
>> > I think it could be better if this message above would be like:
>> >
>> >org.apache.jasper.JasperException:
>> >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter
>> method
>> >for attribute: required for oslib.tagext.NumberTag
>> >
>> > Regards,
>> > Edson
>>
>>
>>
>>
>> This e-mail, including any attachments, is a confidential business
>> communication, and may contain information that is confidential,
>> proprietary and/or privileged. This e-mail is intended only for the
>> individual(s) to whom it is addressed, and may not be saved, copied,
>> printed, disclosed or used by anyone else. If you are not the(an)
>> intended recipient, please immediately delete this e-mail from your
>> computer system and notify the sender. Thank you.
>>
>>
>> -
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
This e-mail, including any attachments, is a confidential business communication, and
may contain information that is confidential, proprietary and/or privileged. This
e-mail is intended only for the individual(s) to whom it is addressed, and may not be
saved, copied, printed, disclosed or used by anyone else. If you are not the(an)
intended recipient, please immediately delete this e-mail from your computer system
and notify the sender. Thank you.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: suggestion for taglib process
Hello Yoav, i think we have here more that just "changing a error
message". I´ll try to explain:
The class that jasper says not found a method is named
CurrencyLookup and its method is setRequired, that´s why jasper complains
about something called "required" ( i telling you what is happening ).
CurrencyLookup extends Lookup and Lookup extends FieldHTML ( all of them are
taglibs ). setRequired is implemented in FieldHTML. After debug tomcat and
check which class jasper was complaining, i really couldn´t understand why
Generator can´t see this method. For me its sound like another bug, what do
you think.
PS. I´m using tomcat-4.1.24
> --
> De: Shapira, Yoav[SMTP:[EMAIL PROTECTED]
> Responder:Tomcat Users List
> Enviada: segunda-feira, 5 de janeiro de 2004 11:19
> Para: Tomcat Users List
> Assunto: RE: suggestion for taglib process
>
>
> Howdy,
> Actually, this seems very reasonable. Please submit it to Bugzilla as an
> enhancement request and attach your code diff. Thanks ;)
>
> Yoav Shapira
> Millennium ChemInformatics
>
>
> >-Original Message-
> >From: Edson Alves Pereira [mailto:[EMAIL PROTECTED]
> >Sent: Monday, January 05, 2004 9:46 AM
> >To: 'Tomcat Users List'
> >Subject: RE: suggestion for taglib process
> >
> > I´m not sure this is the best change for Generator, maybe i must
> >know tomcat´s source in deep. But is here what we need.
> >
> >/
> //
> >//Old
> >org.apache.tomcat.jasper.compiler.Generator:1450
> >
> > String attrName = attrs[i].getName();
> > Method m = handlerInfo.getSetterMethod(attrName);
> > if (m == null) {
> > err.jspError(n, "jsp.error.unable.to_find_method",
> > attrName);
> > }
> >
> >/
> //
> >New:
> >org.apache.tomcat.jasper.compiler.Generator:1450
> >
> > StringBuffer sbMsg = null;
> > String attrName = attrs[i].getName();
> > Method m = handlerInfo.getSetterMethod(attrName);
> > if (m == null) {
> > sbMsg = new StringBuffer( );
> > sbMsg.append( ""jsp.error in [ " );
> > sbMsg.append(
> >handlerInfo.getTagHandlerClass( ).getName( ));
> > sbMsg.append( " ], unable.to_find_method "
> >);
> >
> > err.jspError(
> > n,
> > sbMsg.toString( ),
> > attrName);
> > }
> >
> >
> >> --
> >> De:Shapira, Yoav[SMTP:[EMAIL PROTECTED]
> >> Responder: Tomcat Users List
> >> Enviada: quarta-feira, 31 de dezembro de 2003 10:46
> >> Para: Tomcat Users List
> >> Assunto: RE: suggestion for taglib process
> >>
> >>
> >> Howdy,
> >> Great! I'm glad you have an enhancement in mind: when you contribute a
> >> patch I'll be glad to review and commit it. ;)
> >>
> >> Yoav Shapira
> >> Millennium ChemInformatics
> >>
> >>
> >> >-Original Message-
> >> >From: Edson Alves Pereira [mailto:[EMAIL PROTECTED]
> >> >Sent: Tuesday, December 30, 2003 3:46 PM
> >> >To: 'Tomcat-User List'
> >> >Subject: suggestion for taglib process
> >> >
> >> > Hello folks, i´d like to see all error Tomcat´s messages related
> with
> >> >taglib changed to display exactly the taglib that the error cames
> from,
> >> for
> >> >example, take a look in this message:
> >> >
> >> >org.apache.jasper.JasperException:
> >> >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter
> >> method
> >> >for attribute: required
> >> >
> >> > I think it could be better if this message above would be like:
> >> >
> >> >org.apache.jasper.JasperException:
> >> >/jsp/cadastro/OS_cadastroProjetoEd.jsp(101,6) Unable to find setter
> >> method
> >> >for attribute: required for oslib.tagext.NumberTag
> >> >
> >> > Regards,
> >> > Edson
> >>
> >>
> >>
> >>
> >> This e-mail, including any attachments, is a co
