[tor-bugs] #22918 [Core Tor/Tor]: Add link protocol 5 throughout torspec

[Tor Bug Tracker & Wiki]

#22918: Add link protocol 5 throughout torspec
--+
 Reporter:  teor  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal|   Keywords:  tor-spec
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 {{{
The current "link" versions are: "1" through "4". See section 4.1 for
 more
information. All current Tor versions support "1-3"; version from
0.2.4.11-alpha and on support "1-4". Eventually we will drop "1" and
 "2".
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22894 [Core Tor/Stem]: run_tests.py fails when no system tor is installed

[Tor Bug Tracker & Wiki]

#22894: run_tests.py fails when no system tor is installed
---+
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by atagar):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Resolving since this is fixed and you filed another ticket for the
 deadlocks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+---
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  needs_information
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---
Changes (by atagar):

 * status:  new => needs_information


Comment:

 Fix pushed, you should no longer see deadlocks:
 https://gitweb.torproject.org/stem.git/commit/?id=7901ff1

 Ball's back in your court. What's the process test failing with?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22902 [Core Tor/Stem]: run_tests.py hangs in process or control.controller

[Tor Bug Tracker & Wiki]

#22902: run_tests.py hangs in process or control.controller
---+
 Reporter:  catalyst   |  Owner:  atagar
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Stem  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by atagar):

 Hi catalyst, think I know why you're getting a deadlock. Seems unexpected
 exceptions cause aynchronously run tests to never join. Fixing that. That
 said, there's likely a stacktrace somewhere earlier in your testing output
 and we need to sort out that too (what I'm working on now will simply turn
 the deadlock into a failing test).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17639 [Core Tor/Tor]: provide an option to display the expiry date of a given ed25519 signing key

[Tor Bug Tracker & Wiki]

#17639: provide an option to display the expiry date of a given ed25519 signing 
key
---+
 Reporter:  cypherpunks|  Owner:  isis
 Type:  enhancement| Status:  needs_review
 Priority:  High   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.2.7.2-alpha
 Severity:  Normal | Resolution:
 Keywords:  tor-ed25519-proto  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+
Changes (by isis):

 * status:  accepted => needs_review
 * version:  Tor: 0.3.0.7 => Tor: 0.2.7.2-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #17639 [Core Tor/Tor]: provide an option to display the expiry date of a given ed25519 signing key

[Tor Bug Tracker & Wiki]

#17639: provide an option to display the expiry date of a given ed25519 signing 
key
---+
 Reporter:  cypherpunks|  Owner:  isis
 Type:  enhancement| Status:  accepted
 Priority:  High   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor   |Version:  Tor: 0.3.0.7
 Severity:  Normal | Resolution:
 Keywords:  tor-ed25519-proto  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:
---+
Changes (by isis):

 * status:  new => accepted
 * owner:   => isis


Comment:

 Hi! I took a stab at this in my `bug17639`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug17639 branch].
 I'm not totally sold on that commandline flag or the inplementation, so if
 someone can think of something more user friendly or intuitive, I'd be
 happy to hear better ideas!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22909 [Core Tor/Tor]: Our Rust code is always built in debug mode

[Tor Bug Tracker & Wiki]

#22909: Our Rust code is always built in debug mode
-+-
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  reopened
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by isis):

 * status:  closed => reopened
 * resolution:  invalid =>


Comment:

 Replying to [comment:3 Sebastian]:
 > Reason this is invalid: We're matching Tor's C code behaviour here,
 which always includes debug symbols, even in releases.

 That makes sense to try to match the C behaviour. Although, I think
 building Rust code in debug mode isn't really comparable to a C binary
 with debugging symbols… there's extra stuff going on there (like the over
 /under-flow checks), and it's not like we can just run strip on it to make
 it what it would've been without debugging enabled. It's more like
 building a C binary with UBSan and whatever other sanitisers enabled,
 which IIRC we don't do (`--enable-expensive-hardening` is off by default).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22327 [Applications/Tor Browser]: First party isolation of Page Info

[Tor Bug Tracker & Wiki]

#22327: First party isolation of Page Info
-+-
 Reporter:  arthuredelstein  |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-7.0-must tbb-first-party |  Actual Points:
  TorBrowserTeam201705   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-7.0-must TorBrowserTeam201705 => tbb-7.0-must tbb-first-
 party TorBrowserTeam201705


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22452 [Applications/Tor Browser]: favicons in tab drop down list are not first-party isolated

[Tor Bug Tracker & Wiki]

#22452: favicons in tab drop down list are not first-party isolated
-+-
 Reporter:  arthuredelstein  |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-7.0-must tbb-first-party |  Actual Points:
  TorBrowserTeam201705R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-7.0-must TorBrowserTeam201705R => tbb-7.0-must tbb-first-
 party TorBrowserTeam201705R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22907 [Core Tor/Tor]: Investigate using cargo-vendor for offline dependencies

[Tor Bug Tracker & Wiki]

#22907: Investigate using cargo-vendor for offline dependencies
-+-
 Reporter:  isis |  Owner:
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+-

Comment (by isis):

 Replying to [comment:1 Sebastian]:
 > We're already using that I thought?

 Perhaps you used it when you were setting up the `RUST_DEPENDENCIES` build
 stuff? That would make a lot more sense! (I had not heard of `cargo
 vendor` until yesterday, and our docs don't say anything about it.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22563 [Applications/Tor Browser]: Many memory pages in tor.exe for Windows violate W^X

[Tor Bug Tracker & Wiki]

#22563: Many memory pages in tor.exe for Windows violate W^X
-+-
 Reporter:  arthuredelstein  |  Owner:
 |  arthuredelstein
 Type:  defect   | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  windows tor-client win32 tor-relay   |  Actual Points:
  security hardening 031-backport,   |
  TorBrowserTeam201707   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by arthuredelstein):

 Replying to [comment:8 cypherpunks]:
 > As you "have stolen" this ticket from Core Tor :), it should be noted
 that the right fix for this bug is, as Jonathan Yong
 
[https://sourceforge.net/p/mingw-w64/discussion/723798/thread/2f2c014b/#e385/9720/259e
 suggested], to "Use proper dllimport/dllexport in your code to avoid auto-
 imports." To check that you should compile Tor with `--disable-auto-
 import` for MinGW-w64.

 Thanks for the good suggestion. I tried it but I already run into an error
 when openssl is building. Namely:
 {{{
 libcrypto.a(cryptlib.o):cryptlib.c:(.text+0x9): undefined reference to
 `__stack_chk_guard'
 libcrypto.a(cryptlib.o):cryptlib.c:(.text+0x48): undefined reference to
 `__stack_chk_guard'
 libcrypto.a(cryptlib.o):cryptlib.c:(.text+0xd4): undefined reference to
 `__stack_chk_guard'
 libcrypto.a(cryptlib.o):cryptlib.c:(.text+0xe4): undefined reference to
 `__stack_chk_guard'
 libcrypto.a(cryptlib.o):cryptlib.c:(.text+0x106): undefined reference to
 `__stack_chk_guard'
 libcrypto.a(cryptlib.o):cryptlib.c:(.text+0x264): more undefined
 references to `__stack_chk_guard' follow
 
/var/tmp/dist/mingw-w64/lib/gcc/i686-w64-mingw32/5.1.0/../../../../i686-w64-mingw32/bin/ld:
 libcrypto.a(cryptlib.o): bad reloc address 0x200 in section `.rdata'
 collect2: error: ld returned 1 exit status
 make[4]: *** [link_a.cygwin] Error 1
 }}}

 I did not investigate further, but my best guess is the -fstack-protector
 implementation (when used with mingw-w64) relies on auto-import. Looks
 like we would need an additional patch for gcc or mingw or someplace to
 fix this.

 > Arthur could also make Firefox compile with `--disable-auto-import` (and
 also explain Mozillians why not to use `-mnop-fun-dllimport`) and get
 another one bounty ;)

 Good point. I have opened #22917 to investigate this further. In the
 meantime I think we should go ahead with using the bumped version of
 mingw-w64 because it is working at least for now.

 > In general, MinGW-w64 should remove `--enable-auto-import` by default,
 because future releases of Windows can enforce security, and such tricks
 will fail. Maybe, Arthur, might explain MinGW-w64 guys that they shouldn't
 "fix" incompatible programs (by default at least) with this dirty hack,
 which Arthur made much less dirty!

 My dear cypherpunk, maybe you would like to start that debate on the
 mingw-w64 discussion page? :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22917 [Applications/Tor Browser]: Use --disable-auto-import on mingw builds of TBB and tor

[Tor Bug Tracker & Wiki]

#22917: Use --disable-auto-import on mingw builds of TBB and tor
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-security
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 A cypherpunk [ticket:22563#comment:8 pointed out] that we could possibly
 use --disable-auto-import on our mingw builds of TBB and tor. This would
 probably require patching Firefox as well as stack protection in
 gcc/mingw.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22915 [Core Tor/Tor]: clang 4.0 double promotion warnings in clamp_double_to_int64()

[Tor Bug Tracker & Wiki]

#22915: clang 4.0 double promotion warnings in clamp_double_to_int64()
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport 030-backport|  Actual Points:
  031-backport   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:1 nickm]:
 > (Ignore deleted comment; it was wrong.)
 >
 > This is related to, but not the same as, #22081.
 #22081 is not related, but #22801 is.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22916 [Core Tor/Tor]: Clang warnings when building with openssl and scrypt

[Tor Bug Tracker & Wiki]

#22916: Clang warnings when building with openssl and scrypt
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  027-backport 028-backport|  Actual Points:  .1
  029-backport 030-backport 031-backport |
Parent ID:   | Points:  .1
 Reviewer:  isis |Sponsor:
 |  Sponsor3-can
-+-

Comment (by isis):

 LGTM!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22916 [Core Tor/Tor]: Clang warnings when building with openssl and scrypt

[Tor Bug Tracker & Wiki]

#22916: Clang warnings when building with openssl and scrypt
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  027-backport 028-backport|  Actual Points:  .1
  029-backport 030-backport 031-backport |
Parent ID:   | Points:  .1
 Reviewer:  isis |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * status:  needs_review => merge_ready


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22916 [Core Tor/Tor]: Clang warnings when building with openssl and scrypt

[Tor Bug Tracker & Wiki]

#22916: Clang warnings when building with openssl and scrypt
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  027-backport 028-backport|  Actual Points:  .1
  029-backport 030-backport 031-backport |
Parent ID:   | Points:  .1
 Reviewer:  isis |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * reviewer:   => isis
 * sponsor:   => Sponsor3-can


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:12 nickm]:
 > Sounds fine -- actually, if you just do a backport to 0.2.4, then when I
 merge to maint-0.2.4, it should merge forward cleanly to everything else.

 Okay, done in my `bug22636_0.2.4`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.2.4
 branch]. This is for 0.2.4 through 0.3.0.  I rebased out all the rust
 toolchain stuff, since that would fail and also waste time. [https
 ://travis-ci.org/isislovecruft/tor/builds/253404823 Tests pass].

 My `bug22636_0.3.1`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug22636_0.3.1
 branch] is for 0.3.1. [https://travis-
 ci.org/isislovecruft/tor/builds/253406184 Tests pass].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22916 [Core Tor/Tor]: Clang warnings when building with openssl and scrypt

[Tor Bug Tracker & Wiki]

#22916: Clang warnings when building with openssl and scrypt
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  027-backport 028-backport|  Actual Points:  .1
  029-backport 030-backport 031-backport |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review
 * actualpoints:   => .1


Comment:

 See branch `bug22916_027`.  I suggest we backport no farther than 0.2.9

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22916 [Core Tor/Tor]: Clang warnings when building with openssl and scrypt

[Tor Bug Tracker & Wiki]

#22916: Clang warnings when building with openssl and scrypt
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  027-backport 028-backport
 Severity:  Normal   |  029-backport 030-backport 031-backport
Actual Points:   |  Parent ID:
   Points:  .1   |   Reviewer:
  Sponsor:   |
-+-
 {{{
 src/test/test_crypto_slow.c:161:23: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
   ^
 src/test/test_crypto_slow.c:161:26: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
  ^
 src/test/test_crypto_slow.c:181:23: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
   ^
 src/test/test_crypto_slow.c:181:26: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
  ^
 src/test/test_crypto_slow.c:204:23: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
   ^
 src/test/test_crypto_slow.c:204:26: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
  ^
 src/test/test_crypto_slow.c:228:23: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
   ^
 src/test/test_crypto_slow.c:228:26: error: implicit conversion loses
 integer
   precision: 'uint64_t' (aka 'unsigned long') to 'uint32_t'
   (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
N, r, p, buf1, dk_len);
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22915 [Core Tor/Tor]: clang 4.0 double promotion warnings in clamp_double_to_int64()

[Tor Bug Tracker & Wiki]

#22915: clang 4.0 double promotion warnings in clamp_double_to_int64()
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport 030-backport|  Actual Points:
  031-backport   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * component:  - Select a component => Core Tor/Tor


Comment:

 The "Tor" component will greatly help :D.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22915 [- Select a component]: clang 4.0 double promotion warnings in clamp_double_to_int64()

[Tor Bug Tracker & Wiki]

#22915: clang 4.0 double promotion warnings in clamp_double_to_int64()
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  - Select a component |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport 030-backport|  Actual Points:
  031-backport   |
Parent ID:   | Points:  .1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => needs_review
 * points:   => .1


Comment:

 Please review branch `bug22915_029`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22915 [- Select a component]: clang 4.0 double promotion warnings in clamp_double_to_int64()

[Tor Bug Tracker & Wiki]

#22915: clang 4.0 double promotion warnings in clamp_double_to_int64()
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  - Select a component |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport 030-backport|  Actual Points:
  031-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 (Ignore deleted comment; it was wrong.)

 This is related to, but not the same as, #22081.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22915 [- Select a component]: clang 4.0 double promotion warnings in clamp_double_to_int64()

[Tor Bug Tracker & Wiki]

#22915: clang 4.0 double promotion warnings in clamp_double_to_int64()
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  - Select a component |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-backport 030-backport|  Actual Points:
  031-backport   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 This is related to, but not the same as, #22838.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22915 [- Select a component]: clang 4.0 double promotion warnings in clamp_double_to_int64()

[Tor Bug Tracker & Wiki]

#22915: clang 4.0 double promotion warnings in clamp_double_to_int64()
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: 0.3.2.x-final
Component:  - Select a   |Version:
  component  |   Keywords:  029-backport
 Severity:  Normal   |  030-backport 031-backport
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 Just upgraded to clang 4.0, and I'm seeing this:

 {{{
   CC   src/common/util.o
 src/common/util.c:5612:13: error: implicit conversion increases floating-
 point
   precision: 'double' to 'long double' [-Werror,-Wdouble-promotion]
   if (isnan(number)) {
   ~~^~~
 /usr/include/math.h:385:46: note: expanded from macro 'isnan'
 #  define isnan(x) __MATH_TG ((x), __isnan, (x))
~~^~~
 /usr/include/math.h:320:16: note: expanded from macro '__MATH_TG'
: FUNC ## l ARGS)
  ~ ^~~~
 src/common/util.c:5630:16: error: implicit conversion increases floating-
 point
   precision: 'double' to 'long double' [-Werror,-Wdouble-promotion]
   if (isfinite(number) && exponent <= 63) {
   ~^~~
 /usr/include/math.h:370:50: note: expanded from macro 'isfinite'
 #  define isfinite(x) __MATH_TG ((x), __finite, (x))
   ~~~^~~
 /usr/include/math.h:320:16: note: expanded from macro '__MATH_TG'
: FUNC ## l ARGS)
  ~ ^~~~
 src/common/util.c:5635:18: error: implicit conversion increases floating-
 point
   precision: 'double' to 'long double' [-Werror,-Wdouble-promotion]
   return signbit(number) ? INT64_MIN : INT64_MAX;
  ^~~
 /usr/include/math.h:361:58: note: expanded from macro 'signbit'
 #  define signbit(x) __MATH_TG ((x), __builtin_signbit, (x))
  ^~~
 /usr/include/math.h:320:16: note: expanded from macro '__MATH_TG'
: FUNC ## l ARGS)
  ~ ^~~~
 3 errors generated.
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20657 [Core Tor/Tor]: prop224: Implement service support.

[Tor Bug Tracker & Wiki]

#20657: prop224: Implement service support.
-+
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  needs_revision
 Priority:  Very High|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #12424   | Points:  6
 Reviewer:  nickm|Sponsor:  SponsorR-must
-+
Changes (by dgoulet):

 * status:  needs_review => needs_revision


Comment:

 Few things changed with #21979 so I'll resubmit soon a branch rebased on
 that with a new onion git link.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21979 [Core Tor/Tor]: prop224: Load and configure service

[Tor Bug Tracker & Wiki]

#21979: prop224: Load and configure service
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, review-group-19,|  implemented
  review-group-20|  Actual Points:
Parent ID:  #20657   | Points:  6
 Reviewer:  asn, nickm   |Sponsor:
 |  SponsorR-must
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 lgtm.  Merging!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21979 [Core Tor/Tor]: prop224: Load and configure service

[Tor Bug Tracker & Wiki]

#21979: prop224: Load and configure service
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, review-group-19,|  Actual Points:
  review-group-20|
Parent ID:  #20657   | Points:  6
 Reviewer:  asn, nickm   |Sponsor:
 |  SponsorR-must
-+-
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 See branch `ticket21979_032_04` for the squashed fixup.

 On extra commit on it to fix clang warnings: `965e3a66`

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16562 [Core Tor/Tor]: Harmonize curve25519-signature format with what others are doing

[Tor Bug Tracker & Wiki]

#16562: Harmonize curve25519-signature format with what others are doing
-+-
 Reporter:  nickm|  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay x25519 cross-signature |  Actual Points:
  needs-design   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Hi! I talked to Trevor briefly about this and he says:

 > Hi, it would be great to align!  The XEdDSA spec is here:
 https://whispersystems.org/docs/specifications/xeddsa/  .  However, I'm
 going to update that spec soon as "Generalized EdDSA":
 https://moderncrypto.org/mail-archive/curves/2017/000925.html .  This is
 compatible but has different private nonce generation.  This is already
 implemented at https://github.com/WhisperSystems/libsignal-
 protocol-c/tree/master/src/curve25519/ed25519/additions/generalized, so it
 would be easy to test for compatibility.

 He also says we could/should sit down some afternoon and grapple with all
 the differences.

 If we do change the verification format, is there already a subprotocol
 number which would need to change?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22883 [Core Tor/Tor]: Bridge unavailable during differential consensus update

[Tor Bug Tracker & Wiki]

#22883: Bridge unavailable during differential consensus update
--+
 Reporter:  torvlnt33r|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.1.4-alpha
 Severity:  Normal| Resolution:
 Keywords:  regression cpu usage  |  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:  dgoulet   |Sponsor:
--+
Changes (by nickm):

 * reviewer:   => dgoulet


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19476 [Core Tor/Tor]: Use conditional intervals in heartbeat_callback

[Tor Bug Tracker & Wiki]

#19476: Use conditional intervals in heartbeat_callback
-+-
 Reporter:  cypherpunks  |  Owner:
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-relay, heartbeat, usability, |  implemented
  review-group-20|  Actual Points:
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merged to master; thanks, everybody

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22883 [Core Tor/Tor]: Bridge unavailable during differential consensus update

[Tor Bug Tracker & Wiki]

#22883: Bridge unavailable during differential consensus update
--+
 Reporter:  torvlnt33r|  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  High  |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.1.4-alpha
 Severity:  Normal| Resolution:
 Keywords:  regression cpu usage  |  Actual Points:  1
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Merged the simple approach to 0.3.1 and forward.  The complex approach is
 still here, in need of review:

 For review on oniongit at: ​https://oniongit.eu/nickm/tor/merge_requests/3

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22520 [Core Tor/Tor]: Incorrect encoding for error message

[Tor Bug Tracker & Wiki]

#22520: Incorrect encoding for error message
-+-
 Reporter:  Vort |  Owner:  Vort
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.1.2-alpha
 Severity:  Minor| Resolution:  fixed
 Keywords:  encoding, windows, russian, nt-  |  Actual Points:
  service, win32, review-group-20|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Okay; merged to maint-0.3.1 and forward.  Thank you again!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22830 [Core Tor/Tor]: Problems with building with --enable-rust with RUST_DEPENDENCIES

[Tor Bug Tracker & Wiki]

#22830: Problems with building with --enable-rust with RUST_DEPENDENCIES
-+
 Reporter:  isis |  Owner:  chelseakomlo
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal   | Resolution:  fixed
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  isis |Sponsor:  SponsorZ
-+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Merged to 0.3.1 and forward. Thanks!

 (FWIW, I am giving rust build stuff only the most cursory of overviews
 here.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22803 [Core Tor/Tor]: Memory leak in link-handshake/certs_ok_ed25519

[Tor Bug Tracker & Wiki]

#22803: Memory leak in link-handshake/certs_ok_ed25519
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  030-backport 031-backport tor-tests  |  Actual Points:  .1
  memory-leak|
Parent ID:   | Points:
 Reviewer:  asn  |Sponsor:
-+-
Changes (by asn):

 * reviewer:   => asn


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13912 [Core Tor/Tor]: Key Security: Zeroing Buffers Is Insufficient (AES-NI leaves keys in SSE registers)

[Tor Bug Tracker & Wiki]

#13912: Key Security: Zeroing Buffers Is Insufficient (AES-NI leaves keys in SSE
registers)
-+-
 Reporter:  teor |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.6.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  security registers aesni memwipe |  Actual Points:
  tor-relay  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:12 yawning]:
 > Replying to [comment:11 cypherpunks]:
 > > What about ROP gadgets that do not provide turing complete behavior
 (so no "arbitrary" code execution), but still expose the sensitive
 registers?
 >
 > I think you've likewise effective lost at that point.  Patch OpenSSL's
 assembly in strategic locations if you actually care about this, though
 there's a a lot of other places in the code that don't scrub "sensitive"
 keying information so IMO this is a lost cause.

 Agreed. I think if we're at the point that an adversary can somehow chain
 ROP gadgets to get a partial key read from an xmm register, I'd be way
 more worried about a ROP chain for full RCE.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-

Comment (by nickm):

 Sounds fine -- actually, if you just do a backport to 0.2.4, then when I
 merge to maint-0.2.4, it should merge forward cleanly to everything else.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.1.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  implemented
  code easy  |  Actual Points:
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => implemented


Comment:

 Merged to master; thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.1.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * status:  accepted => needs_review


Comment:

 Please see my patch in my `bug19871`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug19871 branch].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.1.2.4-alpha
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * version:   => Tor: 0.1.2.4-alpha


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-+-
 Reporter:  asn  |  Owner:  isis
 Type:  defect   | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy  |
Parent ID:   | Points:  0.3
 Reviewer:   |Sponsor:
 |  Sponsor3-can
-+-
Changes (by isis):

 * status:  new => accepted
 * owner:   => isis
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 The only place these statistics are used is at the end of `dumpstats(int
 severity)` where `dump_pk_ops()` is called after getting a SIGUSR1 signal
 (but only if `severity < LOG_INFO`). You're both right that these
 statistics seem a bit useless, because this info is kind of weird info to
 keep around, i.e. I'm not sure why we'd want to know how many times we did
 TLS or how many signatures we verified.  (More seemingly useful info about
 public key operations would be higher-level, e.g. routers we're talking to
 for which some crypto operation has an anomalous failure rate.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21979 [Core Tor/Tor]: prop224: Load and configure service

[Tor Bug Tracker & Wiki]

#21979: prop224: Load and configure service
-+-
 Reporter:  dgoulet  |  Owner:  dgoulet
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tor-hs, prop224, review-group-19,|  Actual Points:
  review-group-20|
Parent ID:  #20657   | Points:  6
 Reviewer:  asn, nickm   |Sponsor:
 |  SponsorR-must
-+-

Comment (by nickm):

 Okay! I answered questions on that yesterday, but didn't go over the new
 code yet.  I'll have a look now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22831 [Applications/Tor Browser]: Merge Snowflake for mac

[Tor Bug Tracker & Wiki]

#22831: Merge Snowflake for mac
+--
 Reporter:  dcf |  Owner:  tbb-team
 Type:  task| Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  snowflake TorBrowserTeam201707  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--

Comment (by dcf):

 Replying to [comment:3 gk]:
 > Looks good. The `needs_revision` is mainly for the following nits:
 >
 > s/clang 0.3.8/clang 3.8.0/
 >
 > s/The linux descriptor builds its own copy of gn here/The linux
 descriptor builds its own copy of gn/
 >
 > s/the gn so build/the gn so built/

 Made a [https://gitweb.torproject.org/user/dcf/tor-browser-
 bundle.git/log/?h=snowflake-
 mac-6=faaeb294e36c233021bd2f4afa3d971bb3176c91 snowflake-mac-6] with
 [https://gitweb.torproject.org/user/dcf/tor-browser-bundle.git/diff/?h
 =snowflake-
 
mac-6=faaeb294e36c233021bd2f4afa3d971bb3176c91=f662c9cb1caea6348fe2dcb001d6600f2c813ae0
 those changes].

 > https://github.com/golang/go/issues/9206#issuecomment-310476743 is used
 for both path
 > and timestamp issue. It seems for the latter we want a different URL?

 That one URL illustrates both the timestamp and the path issues. It only
 talks about the path issue in the text, though. I couldn't find a more
 specific link for the timestamp issue. This part of the diff is due to a
 timestamp:
   {{{
   < 00333430  d4 15 4c 59 00 00 00 00  58 03 00 00 26 03 00 00
 |..LYX...&...|
   ---
   > 00333430  dc 15 4c 59 00 00 00 00  58 03 00 00 26 03 00 00
 |..LYX...&...|
   }}}
 This part of the diff is due to a path:
   {{{
   < 00359fe0  2f 67 6f 2d 6c 69 6e 6b  2d 34 34 37 31 39 35 39  |/go-
 link-4471959|
   < 00359ff0  38 34 2f 67 6f 2e 6f 00  72 75 6e 74 69 6d 65 2e
 |84/go.o.runtime.|
   ---
   > 00359fe0  2f 67 6f 2d 6c 69 6e 6b  2d 32 30 38 38 31 36 34  |/go-
 link-2088164|
   > 00359ff0  38 36 2f 67 6f 2e 6f 00  72 75 6e 74 69 6d 65 2e
 |86/go.o.runtime.|
   }}}

 > One thing I was wondering is whether it would be more beneficial to
 split up the big webrtc patch into
 > smaller ones. It might make it easier to follow the upstreaming efforts
 that way giving a clear impression on how many patches still need to get
 upstreamed and making patches easier to write once one or another of those
 patches is not needed anymore. I don't feel strongly about that, though.
 If you want to leave that as-is, fine with me.

 The patch actually is already split up into 8 smaller patches, each with
 their own commit message. They are just concatenated together into one
 file (i.e., in [https://git-scm.com/docs/git-am git am] format).

 > I have trouble to understand why `faketime` is needed now when building
 `go` given that we use `go` built without it for `obfs4proxy` and `meek`
 without any issues. "including those that arise here while compiling the
 Go runtime itself" should hold for the latter PTs as well, yet we don't
 need `faketime` in those cases. What is different between the `snowflake-
 client` and, say, the `obfs4proxy` case so that we need `faketime` for
 building `go` itself now? Are the problematic .o files plainly missing in
 `obfs4proxy`'s and `meek`s case? Or...

 I wondered about that too. I believe it is because of cgo. cgo invokes the
 system linker (i.e. Clang) and it is actually Clang that is the source of
 non-determinism, not go itself. See [https://dave.cheney.net/2016/01/18
 /cgo-is-not-go here] for example:
   When you `import "C"` in your Go package, `go build` has to do a lot
 more work to build your code. Building your package is no longer simply
 passing a list of all the `.go` files in scope to a single invocation of
 `go tool compile`, instead:
* The cgo tool needs to be invoked to generate the C to Go and Go to C
 thunks and stubs.
* Your system C compiler has to be invoked for every C file in the
 package.
* The individual compilation units are combined together into a single
 .o file.
* The resulting .o file take a trip through the system linker for fix-
 ups against shared objects they reference.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:  catalyst |Sponsor:
-+-
Changes (by catalyst):

 * reviewer:   => catalyst


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22636 [Core Tor/Tor]: Add Travis configs so GitHub forks get CI coverage

[Tor Bug Tracker & Wiki]

#22636: Add Travis configs so GitHub forks get CI coverage
-+-
 Reporter:  catalyst |  Owner:
 |  patrickod
 Type:  defect   | Status:
 |  needs_review
 Priority:  High |  Milestone:  Tor:
 |  0.3.2.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  continuous-integration ci testing|  Actual Points:  .5
  best-practice unit-testing new-developers  |
  travis |
Parent ID:   | Points:  .5
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Also this is totally safe to back-port to… well everything. (Not only
 safe, but potentially an improvement for people trying to make bugfixes on
 older releases.) Should I make branches to port it back to everything
 listed in
 
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases#Current
 ?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #19980 [Core Tor/Tor]: Use OpenSSL 1.1.0 X5519 in Tor when available (if it's good)

[Tor Bug Tracker & Wiki]

#19980: Use OpenSSL 1.1.0 X5519 in Tor when available (if it's good)
-+-
 Reporter:  nickm|  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  openssl110 performance tor-relay |  Actual Points:
  tor-client crypto  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by isis):

 Replying to [comment:7 yawning]:
 > Does it have a table driven scalar basepoint multiply?

 Yes, in `crypto/ec/curve25519.c`:

 {{{
 /* k25519Precomp[i][j] = (j+1)*256^i*B */
 static const ge_precomp k25519Precomp[32][8] = {
 […]
 }
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20957 [Applications/Tor Browser]: Get DieHarder working with Tor Browser

[Tor Bug Tracker & Wiki]

#20957: Get DieHarder working with Tor Browser
--+
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_revision
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-hardened  |  Actual Points:
Parent ID:  #20955| Points:
 Reviewer:|Sponsor:
--+

Comment (by arthuredelstein):

 FWIW, here are some short instructions for testing DieHarder with Firefox:
 https://gist.github.com/arthuredelstein/a00899ad13fe7174a667ed9a39e3f1cf

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:  SponsorZ
-+--

Comment (by isis):

 Replying to [comment:3 Sebastian]:
 > The Cargo.lock file is committed on purpose, because we want
 reproducible builds eventually and builds using exact versions now. In our
 setup we're building an "internal" library, not something other people
 would pull in from crates.io.
 >
 > The reason we're using "*" is that dependency updates are manual always
 (they include vendoring a new thing) so accidental updates should be
 impossible, unless I'm missing something here.

 If I understood correctly, which I might be wrong or still confused, but I
 think what was happening is that `cargo fetch` isn't actually looking at
 the `Cargo.lock` file when it does the dependency resolution, so it sees
 the `libc = "*"` in `src/rust/tor_util/Cargo.toml`, and it's like "great!
 0.2.26 is the latest, I'll grab that" and then later when the build
 scripts do `cargo build --release --quiet --frozen`, because we're using
 `--frozen` it finally does look at the `Cargo.lock` file and it gets upset
 that we don't have precisely version 0.2.22.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  merge_ready
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:  SponsorZ
-+--
Changes (by isis):

 * status:  new => merge_ready


Comment:

 Okay, chelseakomlo's fix for this branch is in my `bug22905`
 [https://gitweb.torproject.org/user/isis/torspec.git/commit/?h=bug22905
 branch] along with a changes file.

 This should possibly also be backported to 0.3.1.x (along with #22830),
 and my
 [https://gitweb.torproject.org/user/isis/torspec.git/commit/?h=bug22905_0.3.1
 branch] for that is `bug22905_0.3.1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22830 [Core Tor/Tor]: Problems with building with --enable-rust with RUST_DEPENDENCIES

[Tor Bug Tracker & Wiki]

#22830: Problems with building with --enable-rust with RUST_DEPENDENCIES
-+
 Reporter:  isis |  Owner:  chelseakomlo
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  isis |Sponsor:  SponsorZ
-+

Comment (by isis):

 Replying to [comment:15 chelseakomlo]:
 > Agreed that investigating #22907 first is a good idea, it would be nice
 to not have to re-invent the wheel with this!

 Agreed that it would be better to not munge `CARGO_HOME` and investigate
 #22907. Let's do that there, and merge the tiny fix here so that at least
 the builds complete, even if the offline build infrastructure isn't the
 best.

 > Tracking specifying libc versions in #22905; not having wildcard
 versions is a good policy to follow in general.

 Also agreed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22830 [Core Tor/Tor]: Problems with building with --enable-rust with RUST_DEPENDENCIES

[Tor Bug Tracker & Wiki]

#22830: Problems with building with --enable-rust with RUST_DEPENDENCIES
-+
 Reporter:  isis |  Owner:  chelseakomlo
 Type:  defect   | Status:  merge_ready
 Priority:  High |  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor |Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  isis |Sponsor:  SponsorZ
-+
Changes (by isis):

 * status:  needs_information => merge_ready
 * version:   => Tor: 0.3.1.1-alpha
 * milestone:  Tor: unspecified => Tor: 0.3.1.x-final


Comment:

 Hi! This looks great! There's two commits here, the first of which fixes
 this bug, and the second fixes #22905, so I've gone and split them into
 two branches and added changes files.

 The branch for this ticket is the `bug22830`
 [https://gitweb.torproject.org/user/isis/torspec.git/commit/?h=bug22830
 branch] in my repo, and contains chelseakomlo's fix plus the changes file.

 This should possibly be back-ported to 0.3.1.x-final, since it's a trivial
 fix and the rust builds are broken without it. My
 [https://gitweb.torproject.org/user/isis/torspec.git/commit/?h=bug22830_0.3.1
 branch] for that is `bug22830_0.3.1`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:  isis |Sponsor:  SponsorZ
-+--
Changes (by isis):

 * reviewer:   => isis


Comment:

 FWIW, chelseakomlo's `bug22830`
 [https://github.com/chelseakomlo/tor_patches/tree/bug22830 branch] for
 #22830 also includes a fix for this, by specifying `libc = "0.2.22"` in
 `src/rust/tor_util/Cargo.toml`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22874 [Obfuscation/Snowflake]: Standalone broker (independent of App Engine)

[Tor Bug Tracker & Wiki]

#22874: Standalone broker (independent of App Engine)
---+--
 Reporter:  dcf|  Owner:  cmm32
 Type:  project| Status:  assigned
 Priority:  High   |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by dcf):

 * priority:  Medium => High


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22782 [Obfuscation/Snowflake]: Change domain front for snowflake to something that isn't blocked

[Tor Bug Tracker & Wiki]

#22782: Change domain front for snowflake to something that isn't blocked
---+-
 Reporter:  cypherpunks|  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Obfuscation/Snowflake  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by dcf):

 Corresponding GitHub ticket is
 [https://github.com/keroserene/snowflake/issues/17 #17].

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by chelseakomlo):

 * cc: alexcrichton, chelseakomlo (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22914 [- Select a component]: Doctored police video exposed

[Tor Bug Tracker & Wiki]

#22914: Doctored police video exposed
--+-
 Reporter:  tobytoby  |  Owner:
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by tobytoby):

 * priority:  Medium => High
 * type:  defect => task


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22914 [- Select a component]: Doctored police video exposed

[Tor Bug Tracker & Wiki]

#22914: Doctored police video exposed
--+-
 Reporter:  tobytoby  |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+-
 Use link Watch part 1 & 2,
 "DOCTORED POLICE VIDEO EXPOSED!!" on YouTube
 https://youtu.be/kWzWtLd2lrQ

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22769 [Core Tor/Tor]: Investigate the reproducibility of Rust binaries

[Tor Bug Tracker & Wiki]

#22769: Investigate the reproducibility of Rust binaries
+
 Reporter:  isis|  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, SponsorZ  |  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by gk):

 * cc: gk (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22830 [Core Tor/Tor]: Problems with building with --enable-rust with RUST_DEPENDENCIES

[Tor Bug Tracker & Wiki]

#22830: Problems with building with --enable-rust with RUST_DEPENDENCIES
-+---
 Reporter:  isis |  Owner:  chelseakomlo
 Type:  defect   | Status:  needs_information
 Priority:  High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  isis |Sponsor:  SponsorZ
-+---

Comment (by chelseakomlo):

 Agreed that investigating #22907 first is a good idea, it would be nice to
 not have to re-invent the wheel with this!

 Tracking specifying libc versions in #22905; not having wildcard versions
 is a good policy to follow in general.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22830 [Core Tor/Tor]: Problems with building with --enable-rust with RUST_DEPENDENCIES

[Tor Bug Tracker & Wiki]

#22830: Problems with building with --enable-rust with RUST_DEPENDENCIES
-+---
 Reporter:  isis |  Owner:  chelseakomlo
 Type:  defect   | Status:  needs_information
 Priority:  High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  isis |Sponsor:  SponsorZ
-+---
Changes (by chelseakomlo):

 * status:  needs_review => needs_information


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by chelseakomlo):

 * cc: acrichton@… (removed)


Comment:

 Replying to [comment:2 alexcrichton]:

 > In any case though I'd probably recommend avoiding `"*"` dependencies.
 If you use more targeted dependencies (like `"0.2.24"` which stands for
 "semver compatible with 0.2.24" which is actually `>=0.2.24, < 0.3`) then
 you can typically use `cargo update` to safely update dependencies without
 worrying about actually breaking your code. This'll help to easily pick up
 bug fixes and such in libraries without accidentally introducing breakage
 sometimes.

 I think this is a good policy to follow in general, and something we do as
 a development requirement going forward.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22907 [Core Tor/Tor]: Investigate using cargo-vendor for offline dependencies

[Tor Bug Tracker & Wiki]

#22907: Investigate using cargo-vendor for offline dependencies
-+-
 Reporter:  isis |  Owner:
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.1.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, rust-pilot, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+-
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22839 [Core Tor/Tor]: Build tor with Rust code enabled on Windows

[Tor Bug Tracker & Wiki]

#22839: Build tor with Rust code enabled on Windows
--+--
 Reporter:  isis  |  Owner:
 Type:  task  | Status:  new
 Priority:  Medium|  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust, windows, tor-build  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:  SponsorZ
--+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22830 [Core Tor/Tor]: Problems with building with --enable-rust with RUST_DEPENDENCIES

[Tor Bug Tracker & Wiki]

#22830: Problems with building with --enable-rust with RUST_DEPENDENCIES
-+--
 Reporter:  isis |  Owner:  chelseakomlo
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:  isis |Sponsor:  SponsorZ
-+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22769 [Core Tor/Tor]: Investigate the reproducibility of Rust binaries

[Tor Bug Tracker & Wiki]

#22769: Investigate the reproducibility of Rust binaries
+
 Reporter:  isis|  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, SponsorZ  |  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22769 [Core Tor/Tor]: Investigate the reproducibility of Rust binaries

[Tor Bug Tracker & Wiki]

#22769: Investigate the reproducibility of Rust binaries
+
 Reporter:  isis|  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, SponsorZ  |  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  SponsorZ
+

Comment (by alexcrichton):

 The upstream issue here is https://github.com/rust-lang/rust/issues/34902
 and recent comments (https://github.com/rust-
 lang/rust/issues/34902#issuecomment-314078652) may mean that rustc may
 effectively have those done!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22818 [Core Tor/Tor]: Improve documentation for building Tor with Rust

[Tor Bug Tracker & Wiki]

#22818: Improve documentation for building Tor with Rust
-+--
 Reporter:  chelseakomlo |  Owner:
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:  Tor: unspecified
 Severity:  Normal   | Resolution:
 Keywords:  rust tor-build docs  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22816 [Core Tor/Tor]: Run tests for single Rust module

[Tor Bug Tracker & Wiki]

#22816: Run tests for single Rust module
--+
 Reporter:  chelseakomlo  |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Low   |  Milestone:  Tor:
  |  unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust unit-tests test-harness  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22771 [Core Tor/Tor]: Determine Rust support levels for our targeted platforms

[Tor Bug Tracker & Wiki]

#22771: Determine Rust support levels for our targeted platforms
+
 Reporter:  isis|  Owner:
 Type:  task| Status:  needs_information
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, SponsorZ  |  Actual Points:
Parent ID:  | Points:  .5
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22768 [Internal Services/Service - jenkins]: Add building Tor with Rust support to Jenkins

[Tor Bug Tracker & Wiki]

#22768: Add building Tor with Rust support to Jenkins
-+
 Reporter:  isis |  Owner:  weasel
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - jenkins  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-ci |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22769 [Core Tor/Tor]: Investigate the reproducibility of Rust binaries

[Tor Bug Tracker & Wiki]

#22769: Investigate the reproducibility of Rust binaries
+
 Reporter:  isis|  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, SponsorZ  |  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by alexcrichton):

 * cc: acrichton@… (removed)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22156 [Core Tor/Tor]: Add Rust linting/formatting tools

[Tor Bug Tracker & Wiki]

#22156: Add Rust linting/formatting tools
+--
 Reporter:  chelseakomlo|  Owner:
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust best-practice  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22769 [Core Tor/Tor]: Investigate the reproducibility of Rust binaries

[Tor Bug Tracker & Wiki]

#22769: Investigate the reproducibility of Rust binaries
+
 Reporter:  isis|  Owner:
 Type:  task| Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  rust, SponsorZ  |  Actual Points:
Parent ID:  | Points:  3
 Reviewer:  |Sponsor:  SponsorZ
+
Changes (by alexcrichton):

 * cc: acrichton@… (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

[Tor Bug Tracker & Wiki]

#21759: Add persistence for torperf/onionperf
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Replying to [comment:4 iwakeh]:
 > Should the standard annotation be changed from current `Onionperf("@type
 torperf 1.0\n")` to  `Onionperf("@type torperf 1.1\n")`?

 Yes. Though I didn't find where this is even used in the current code, but
 your patch might change that. So, yes, we should update this.

 I'll look at the
 [https://trac.torproject.org/projects/tor/ticket/21759?replyto=4#comment:5
 remaining comment 5] next, but that might be either tonight or tomorrow.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

[Tor Bug Tracker & Wiki]

#21759: Add persistence for torperf/onionperf
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-

Comment (by karsten):

 Replying to [comment:3 iwakeh]:
 > Currently, Onionperf files are stored accumulated (many single
 descriptors in one file) in both recent and out folders.
 > This sort of deviates from the usual process of storing only single
 descriptor files in the out folder.
 > Should onionperf storage be changed to storing single file descriptors
 in the out directory?

 Good question! To be honest, I don't find it particularly useful that
 current tarballs contain just a single descriptor per file. This works
 okay for large descriptors like consensuses or votes, but not so much for
 server descriptors or even microdescriptors. The main reason why we're
 still doing it is that it's easy to check whether we already have a given
 descriptor if we can identify it by filename. If we had a database for
 this information and if we were to rewrite the tarball-creating code, we
 might do things differently. For example, we could put all descriptors
 starting with digest `ee` into an `ee` file. That would probably speed up
 things a lot for people using our tarballs.

 So, for this case I'd say let's leave files as they are and not split them
 up.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22913 [Internal Services/Service - git]: New git repository in Infrastructure and Administration /project

[Tor Bug Tracker & Wiki]

#22913: New git repository in Infrastructure and Administration /project
-+-
 Reporter:  hiro |  Owner:  tor-gitadm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:  implemented
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  new => closed
 * resolution:   => implemented


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22913 [Internal Services/Service - git]: New git repository in Infrastructure and Administration /project

[Tor Bug Tracker & Wiki]

#22913: New git repository in Infrastructure and Administration /project
-+
 Reporter:  hiro |  Owner:  tor-gitadm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+

Comment (by nickm):

 Sure thing!  I'm making it publicly visible by default, but please let us
 know if it shouldn't be public.  I've made it RW by you only; please let
 us know if anybody else should have write access.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22912 [Metrics/metrics-lib]: tpf parsing drops trailing newline

[Tor Bug Tracker & Wiki]

#22912: tpf parsing drops trailing newline
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 The fix works fine for #21759; test still welcome.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22819 [Core Tor/Tor]: Choice of compressors seems to be suboptimal

[Tor Bug Tracker & Wiki]

#22819: Choice of compressors seems to be suboptimal
--+
 Reporter:  yurivict271   |  Owner:  ahf
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ahf):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 I'm going to close this for now. Feel free to reopen if there is an issue
 with the way we analyse the LZ4 compression in our `bench` tool.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  TorBrowserTeam201707R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 That should not happen as the default in that case at least is set to
 `addons://list/extension` (see: https://dxr.mozilla.org/mozilla-
 esr52/source/toolkit/mozapps/extensions/content/extensions.js#207). This
 is commit b3989f16138112084c008f89d54ecbe9cd4804d7 on `tor-
 browser-52.2.0esr-7.5-1`. I guess we could think about backporting it to
 the stable branch as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22073 [Applications/Tor Browser]: Disable GetAddons pane on about:addons

[Tor Bug Tracker & Wiki]

#22073: Disable GetAddons pane on about:addons
--+--
 Reporter:  gk|  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201707R |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by mcs):

 r=brade, r=mcs
 This change is fine. The spinning icon problem is a little annoying but
 something we can probably live with as long as it does not happen when
 about:addons is opened for the very first time. On the browser console I
 see:
 {{{
 13:13:31.058 NS_ERROR_FAILURE: Root node doesn't exist for 'discover' view
 1 extensions.js:852
 gViewController.loadViewInternal
 chrome://mozapps/content/extensions/extensions.js:852:13
 gViewController.loadInitialView
 chrome://mozapps/content/extensions/extensions.js:822:5
 initialize chrome://mozapps/content/extensions/extensions.js:238:3
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22913 [Internal Services/Service - git]: New git repository in Infrastructure and Administration /project

[Tor Bug Tracker & Wiki]

#22913: New git repository in Infrastructure and Administration /project
-+
 Reporter:  hiro |  Owner:  tor-gitadm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Description changed by hiro:

Old description:

> I have been working on a small web app that should serve as a submission
> forms for grant proposal. Could I get a git repository for it?

New description:

 I have been working on a small web app that should serve as a submission
 forms for grant proposal. Could I get a git repository for it? I'd like it
 to be under Infrastructure and Administration /project/pipeline if that's
 ok.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22913 [Internal Services/Service - git]: New git repository in Infrastructure and Administration /project

[Tor Bug Tracker & Wiki]

#22913: New git repository in Infrastructure and Administration /project
-+
 Reporter:  hiro |  Owner:  tor-gitadm
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Service - git  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 I have been working on a small web app that should serve as a submission
 forms for grant proposal. Could I get a git repository for it?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

[Tor Bug Tracker & Wiki]

#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by dgoulet):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22908 [Core Tor/Tor]: Establish guidelines for contributing large bodies of code

[Tor Bug Tracker & Wiki]

#22908: Establish guidelines for contributing large bodies of code
-+-
 Reporter:  catalyst |  Owner:
 |  catalyst
 Type:  task | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  best-practice new-developers tor-|  Actual Points:
  doc|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by dgoulet):

 * keywords:  best-practice new-developers => best-practice new-developers
 tor-doc
 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22906 [Core Tor/Tor]: We might not want to commit Cargo.lock files

[Tor Bug Tracker & Wiki]

#22906: We might not want to commit Cargo.lock files
-+--
 Reporter:  isis |  Owner:
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:  SponsorZ
-+--
Changes (by dgoulet):

 * milestone:   => Tor: unspecified


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22831 [Applications/Tor Browser]: Merge Snowflake for mac

[Tor Bug Tracker & Wiki]

#22831: Merge Snowflake for mac
+--
 Reporter:  dcf |  Owner:  tbb-team
 Type:  task| Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  snowflake TorBrowserTeam201707  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  snowflake TorBrowserTeam201707R => snowflake
 TorBrowserTeam201707
 * status:  needs_review => needs_revision


Comment:

 Looks good. The `needs_revision` is mainly for the following nits:

 s/clang 0.3.8/clang 3.8.0/

 https://github.com/golang/go/issues/9206#issuecomment-310476743 is used
 for both path
 and timestamp issue. It seems for the latter we want a different URL?

 s/The linux descriptor builds its own copy of gn here/The linux descriptor
 builds its own copy of gn/

 s/the gn so build/the gn so built/

 ---

 One thing I was wondering is whether it would be more beneficial to split
 up the big webrtc patch into
 smaller ones. It might make it easier to follow the upstreaming efforts
 that way giving a clear impression on how many patches still need to get
 upstreamed and making patches easier to write once one or another of those
 patches is not needed anymore. I don't feel strongly about that, though.
 If you want to leave that as-is, fine with me.

 I have trouble to understand why `faketime` is needed now when building
 `go` given that we use `go` built without it for `obfs4proxy` and `meek`
 without any issues. "including those that arise here while compiling the
 Go runtime itself" should hold for the latter PTs as well, yet we don't
 need `faketime` in those cases. What is different between the `snowflake-
 client` and, say, the `obfs4proxy` case so that we need `faketime` for
 building `go` itself now? Are the problematic .o files plainly missing in
 `obfs4proxy`'s and `meek`s case? Or...

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

[Tor Bug Tracker & Wiki]

#21759: Add persistence for torperf/onionperf
---+-
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+-
Changes (by iwakeh):

 * status:  needs_information => needs_review


Comment:

 Assuming 'no' for the question in comment:3 (store only one file in out)
 and 'yes' for comment:4 please find
 
[https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-21759=28c402e370ed45185caf39737a8be431b8d966d2
 this branch] for review.

 This branch introduces sync-functionality for Onionperf, but not yet
 storing via the persistence mechanism, because the latter is currently
 implemented using an implicit transaction, i.e., all descriptors in one
 downloaded descriptor file are only stored, if all were valid.  This is
 different from the sync-approach where invalid/unparseable descriptors are
 ignored, but valid ones stored no matter if they came in one file.

 Could the sync-approach be also used for directly downloaded descriptors?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22893 [Core Tor/Tor]: prop224: Make intro point per-service and not per-descriptor

[Tor Bug Tracker & Wiki]

#22893: prop224: Make intro point per-service and not per-descriptor
+--
 Reporter:  dgoulet |  Owner:  dgoulet
 Type:  enhancement | Status:  accepted
 Priority:  High|  Milestone:  Tor:
|  0.3.2.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs, prop224, prop224-extra  |  Actual Points:
Parent ID:  #20657  | Points:  1
 Reviewer:  |Sponsor:  SponsorR-
|  must
+--
Changes (by asn):

 * keywords:  tor-hs, prop224 => tor-hs, prop224, prop224-extra


Comment:

 Also marking it as prop224-extra since I keep track of open prop224-extra
 tickets.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22798 [Core Tor/Tor]: Windows relay is several times slower than Linux relay

[Tor Bug Tracker & Wiki]

#22798: Windows relay is several times slower than Linux relay
---+---
 Reporter:  Vort   |  Owner:
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:  Tor:
   |  unspecified
Component:  Core Tor/Tor   |Version:  Tor: 0.2.9.11
 Severity:  Normal | Resolution:
 Keywords:  tor-relay performance windows  |  Actual Points:
Parent ID: | Points:  5
 Reviewer: |Sponsor:
---+---

Comment (by Vort):

 Here is my attempt to fix this problem:
 attachment:tor_windows_upload_hackfix_v1.patch

 It breaks build, but allows to produce tor.exe for testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13203 [HTTPS Everywhere/HTTPS Everywhere: Chrome]: youtube videos doesn't load

[Tor Bug Tracker & Wiki]

#13203: youtube videos doesn't load
-+-
 Reporter:  brunoqc  |  Owner:  zyan
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  HTTPS Everywhere/HTTPS Everywhere:   |Version:
  Chrome | Resolution:
 Severity:  Normal   |  worksforme
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  new => closed
 * resolution:   => worksforme
 * severity:   => Normal


Comment:

 Issue no longer present when I tested it. Closing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22910 [Applications/Tor Browser Sandbox]: Deprecate the extra codecs/volatile extension dir options

[Tor Bug Tracker & Wiki]

#22910: Deprecate the extra codecs/volatile extension dir options
--+-
 Reporter:  yawning   |  Owner:  yawning
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser Sandbox  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-

Comment (by cypherpunks):

 Please don't, sandboxed tor browser + enabling addons is still WAY more
 secure than vanilla Tor Browser. And you already put a very big "UNSAFE"
 next to them.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

[Tor Bug Tracker & Wiki]

#21759: Add persistence for torperf/onionperf
---+---
 Reporter:  iwakeh |  Owner:  iwakeh
 Type:  enhancement| Status:  needs_information
 Priority:  Medium |  Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+---

Comment (by iwakeh):

 Should the standard annotation be changed from current `Onionperf("@type
 torperf 1.0\n")` to  `Onionperf("@type torperf 1.1\n")`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22912 [Metrics/metrics-lib]: tpf parsing drops trailing newline

[Tor Bug Tracker & Wiki]

#22912: tpf parsing drops trailing newline
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by iwakeh):

 That looks fine!  Thanks for the quick fix!

 I'll apply this to #21759 and once that works, set this ticket to merge-
 ready.

 What about a test for that and the other trailing newlines?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22912 [Metrics/metrics-lib]: tpf parsing drops trailing newline

[Tor Bug Tracker & Wiki]

#22912: tpf parsing drops trailing newline
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  new => needs_review


Comment:

 Like [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/commit/?h=task-22912=44e1c2566b954834bb39c8e1e3aa994a62d98f06
 this]?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22884 [Applications/Tor Browser]: about:tor page is not showing up in non-e10s mode after fix for #18913 landed

[Tor Bug Tracker & Wiki]

#22884: about:tor page is not showing up in non-e10s mode after fix for #18913
landed
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:
 |  assigned
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201707, tbb-torbutton  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_information => assigned


Comment:

 Yes. I guess adding `about:tor` to our whitelist as we did with a bunch of
 other `about:` pages solved this for me.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22912 [Metrics/metrics-lib]: tpf parsing drops trailing newline

[Tor Bug Tracker & Wiki]

#22912: tpf parsing drops trailing newline
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:
Component:  Metrics/metrics-lib  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 When descriptors are read from a file the trailing newline should be
 preserved (which is the case for all types except tpf desc.).

 The raw-byte dump of TorperfResult drops the newlines at the end.

 Setting to high-prio b/c this blocks #21759.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22642 [Applications/Tor Browser]: TorBrowser 7.x Mac - Disable kMDItemWhereFroms extended attributes at least in Private Browsing Mode

[Tor Bug Tracker & Wiki]

#22642: TorBrowser 7.x Mac - Disable kMDItemWhereFroms extended attributes at 
least
in Private Browsing Mode
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-disk-leak |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: DrMikeTwiddle (added)
 * keywords:   => tbb-disk-leak


Comment:

 #22904 is a duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22904 [Applications/Tor Browser]: macOS: Downloaded files in Tor Browser are being added to a system download history list.

[Tor Bug Tracker & Wiki]

#22904: macOS: Downloaded files in Tor Browser are being added to a system 
download
history list.
-+-
 Reporter:  DrMikeTwiddle|  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  Mac, File Quarantine,|  duplicate
  com.apple.LaunchServices.QuarantineEventsV2|  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Duplicate of #22642.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs