Re: [tor-bugs] #4187 [Core Tor/Tor]: A verified unverified-consensus should be renamed to cached-consensus

2018-01-24 Thread Tor Bug Tracker & Wiki
#4187: A verified unverified-consensus should be renamed to cached-consensus
-+-
 Reporter:  anonym   |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.2.33
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, directory, rename, fs,   |  Actual Points:
  easy, 032-unreached|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-

Comment (by fristonio):

 Hey, if no one is assigned to this issue I would really love to work to
 resolve this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23650 [Core Tor/Tor]: Tor source code has many typos

2018-01-24 Thread Tor Bug Tracker & Wiki
#23650: Tor source code has many typos
--+--
 Reporter:  cypherpunks   |  Owner:  arma
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by fristonio):

 Here is link to the patch on my GitHub repository :
 https://github.com/fristonio/tor-patches/blob/master/0001-Fix-spelling-
 mistakes-corresponding-to-ticket-23650.patch

 Thanks for your help @teor and @arma

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23650 [Core Tor/Tor]: Tor source code has many typos

2018-01-24 Thread Tor Bug Tracker & Wiki
#23650: Tor source code has many typos
--+--
 Reporter:  cypherpunks   |  Owner:  arma
 Type:  defect| Status:  new
 Priority:  Very Low  |  Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |Version:
 Severity:  Trivial   | Resolution:
 Keywords:  easy  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by fristonio):

 * Attachment "0001-Fix-spelling-mistakes-corresponding-to-
 ticket-23650.patch" added.

 Fix typos in tor source code.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25012 [Applications/Tor Browser]: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions file

2018-01-24 Thread Tor Bug Tracker & Wiki
#25012: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions
file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:  wontfix
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 It seems there is a fix proposed downstream, good. Let's get the problem
 solved there then.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25012 [Applications/Tor Browser]: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions file

2018-01-24 Thread Tor Bug Tracker & Wiki
#25012: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions
file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: ToringOnion (added)


Comment:

 Resolved #25010 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25010 [Applications]: Tor fails to launch after update

2018-01-24 Thread Tor Bug Tracker & Wiki
#25010: Tor fails to launch after update
--+---
 Reporter:  ToringOnion   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  Immediate |  Milestone:
Component:  Applications  |Version:
 Severity:  Critical  | Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 That's a torbrowser-launcher issue and not a Tor Browser one, see:
 https://github.com/micahflee/torbrowser-launcher/issues/306

 That tool is barely maintained. We recommend using Tor Browser directly,
 as we ship it. Duping this over to #25012.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25012 [Applications/Tor Browser]: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions file

2018-01-24 Thread Tor Bug Tracker & Wiki
#25012: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions
file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * cc: e-inquirer (added)


Comment:

 Resolved #25015 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25015 [Applications/Tor Browser]: TBB fails to launch in Linux after last update

2018-01-24 Thread Tor Bug Tracker & Wiki
#25015: TBB fails to launch in Linux after last update
--+---
 Reporter:  e-inquirer|  Owner:  tbb-team
 Type:  defect| Status:  closed
 Priority:  Immediate |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  | Resolution:  duplicate
 Keywords:  linux |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---
Changes (by gk):

 * owner:  (none) => tbb-team
 * component:  - Select a component => Applications/Tor Browser
 * status:  new => closed
 * resolution:   => duplicate


Comment:

 That's a torbrowser-launcher issue and no Tor Browser one, see:
 https://github.com/micahflee/torbrowser-launcher/issues/306

 That tool is barely maintained. We recommend using Tor Browser directly,
 as we ship it. Duping this over to #25012.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

2018-01-24 Thread Tor Bug Tracker & Wiki
#25013: Move TorButton code to the tor browser repository
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201801R |  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:  gk, sysrqb, mcs   |Sponsor:
--+--
Changes (by gk):

 * keywords:   => TorBrowserTeam201801R


Comment:

 Good stuff! FWIW: we'd need a `tor-browser-build` patch, too, I guess
 making sure that Torbutton is not built anymore and not shipped as an
 extension anymore in Tor Browser.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25012 [Applications/Tor Browser]: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions file

2018-01-24 Thread Tor Bug Tracker & Wiki
#25012: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions
file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by gk):

 I am not convinced yet this is a Tor Browser bug. If we don't need a
 versions file (which we apparently don't do) then just adding one because
 torbrowser-launcher depends on it does not make much sense to me.
 Especially as it is barely maintained anymore. I think the much better
 solution would be to get this fixed on torbrowser-launcher's end.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21876 [Applications/Tor Browser]: e10s is not enabled on Linux (and probably OS X) by default in ESR 52 based nightlies

2018-01-24 Thread Tor Bug Tracker & Wiki
#21876: e10s is not enabled on Linux (and probably OS X) by default in ESR 52 
based
nightlies
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Very High|  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  ff52-esr, tbb-7.0-must-alpha,|  Actual Points:
  TorBrowserTeam201704R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201704R =>
 ff52-esr, tbb-7.0-must-alpha, TorBrowserTeam201704R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25017 [Webpages/Website]: Remove 2017 homepage banner

2018-01-24 Thread Tor Bug Tracker & Wiki
#25017: Remove 2017 homepage banner
--+
 Reporter:  arthuredelstein   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #23482| Points:
 Reviewer:|Sponsor:
--+

Comment (by arthuredelstein):

 hiro, could you review this patch? Thanks!

 https://github.com/arthuredelstein/webml/commit/25017

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25017 [Webpages/Website]: Remove 2017 homepage banner

2018-01-24 Thread Tor Bug Tracker & Wiki
#25017: Remove 2017 homepage banner
--+--
 Reporter:  arthuredelstein   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #23482| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arthuredelstein):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25017 [Webpages/Website]: Remove 2017 homepage banner

2018-01-24 Thread Tor Bug Tracker & Wiki
#25017: Remove 2017 homepage banner
--+
 Reporter:  arthuredelstein   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #23482
   Points:|   Reviewer:
  Sponsor:|
--+
 The campaign is finished, so we can remove the homepage banner.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25016 [Applications/Tor Browser]: Remove 2017 in-browser donation banner

2018-01-24 Thread Tor Bug Tracker & Wiki
#25016: Remove 2017 in-browser donation banner
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam201801R |  Actual Points:
Parent ID:  #23482| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arthuredelstein):

 * keywords:  TorBrowserTeam2018R => TorBrowserTeam201801R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25016 [Applications/Tor Browser]: Remove 2017 in-browser donation banner

2018-01-24 Thread Tor Bug Tracker & Wiki
#25016: Remove 2017 in-browser donation banner
--+--
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  TorBrowserTeam2018R   |  Actual Points:
Parent ID:  #23482| Points:
 Reviewer:|Sponsor:
--+--
Changes (by arthuredelstein):

 * keywords:  TorBrowserTeam2018 => TorBrowserTeam2018R
 * status:  new => needs_review


Comment:

 Here is a patch for review:

 https://github.com/arthuredelstein/torbutton/commit/25016

 The same patch on top of the maint-1.9.7 branch:

 
https://github.com/arthuredelstein/torbutton/commit/f6fe17fe5dbfe7de2af8ad7021b560bbe11a8a53

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25010 [Applications]: Tor fails to launch after update (was: Tor fails to launch)

2018-01-24 Thread Tor Bug Tracker & Wiki
#25010: Tor fails to launch after update
--+
 Reporter:  ToringOnion   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Applications  |Version:
 Severity:  Critical  | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25010 [Applications]: Tor fails to launch

2018-01-24 Thread Tor Bug Tracker & Wiki
#25010: Tor fails to launch
--+
 Reporter:  ToringOnion   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Applications  |Version:
 Severity:  Critical  | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by ToringOnion):

 Another user is having the issue after the update. #25015

 I started to get this issue after the update.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25010 [Applications]: Tor fails to launch (was: Tor does not start)

2018-01-24 Thread Tor Bug Tracker & Wiki
#25010: Tor fails to launch
--+
 Reporter:  ToringOnion   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  Applications  |Version:
 Severity:  Critical  | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by ToringOnion):

 * priority:  Low => Immediate
 * severity:  Minor => Critical


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25015 [- Select a component]: TBB fails to launch in Linux after last update

2018-01-24 Thread Tor Bug Tracker & Wiki
#25015: TBB fails to launch in Linux after last update
--+
 Reporter:  e-inquirer|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  - Select a component  |Version:
 Severity:  Critical  | Resolution:
 Keywords:  linux |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by ToringOnion):

 Same here, I created a ticket for it. #25010

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25016 [Applications/Tor Browser]: Remove 2017 in-browser donation banner

2018-01-24 Thread Tor Bug Tracker & Wiki
#25016: Remove 2017 in-browser donation banner
--+
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  TorBrowserTeam2018
Actual Points:|  Parent ID:  #23482
   Points:|   Reviewer:
  Sponsor:|
--+
 Now that the donation campaign is finished, we can remove the donation
 banner.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13028 [Applications/Tor Browser]: Grovel through Firefox source for non-nsHTTPChannel networking

2018-01-24 Thread Tor Bug Tracker & Wiki
#13028: Grovel through Firefox source for non-nsHTTPChannel networking
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Blocker  | Resolution:  fixed
 Keywords:  ff31-esr, TorBrowserTeam201409,  |  Actual Points:
  MikePerry201409, tbb-proxy-bypass  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff31-esr, TorBrowserTeam201409, MikePerry201409 => ff31-esr,
 TorBrowserTeam201409, MikePerry201409, tbb-proxy-bypass
 * severity:   => Blocker


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25015 [- Select a component]: TBB fails to launch in Linux after last update

2018-01-24 Thread Tor Bug Tracker & Wiki
#25015: TBB fails to launch in Linux after last update
--+
 Reporter:  e-inquirer|  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Immediate |  Milestone:
Component:  - Select a component  |Version:
 Severity:  Critical  |   Keywords:  linux
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 After the last update (around Jan 24th) for Linux, TBB fails to launch.
 Attempting to reinstall via the Tor Browser Launcher also fails.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

2018-01-24 Thread Tor Bug Tracker & Wiki
#25013: Move TorButton code to the tor browser repository
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:  gk, sysrqb, mcs   |Sponsor:
--+--
Changes (by igt0):

 * reviewer:   => gk, sysrqb, mcs


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

2018-01-24 Thread Tor Bug Tracker & Wiki
#25013: Move TorButton code to the tor browser repository
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:|Sponsor:
--+--
Changes (by igt0):

 * status:  new => needs_review


Comment:

 The code can be seen here: https://github.com/igortoliveira/tor-
 browser/commits/tbb-dev-desktop:

  **Move Tor Button source code to the browser/extensions directory**
  https://github.com/igortoliveira/tor-
 browser/commit/eb2e1cec3b027647d3a873e8ce2e18102c926b7f

  **Integrate Tor Button in the browser build system**
  https://github.com/igortoliveira/tor-
 browser/commit/d41ab6c701cbcaf00512061b05fb1e5e106a0923

  **Use anonymous function to keep the torbutton.js and prefereces.js scope
 limited to the parent function**
  https://github.com/igortoliveira/tor-
 browser/commit/2c09ab0d4010c78af52a5655d865971600a215ed

  **Initialize startup.homepage in the startup-observer component**
  https://github.com/igortoliveira/tor-
 browser/commit/b73742421735d6fea70ba4d7d550dcea22c1642c

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12637 [Webpages/Website]: Add new links to press page

2018-01-24 Thread Tor Bug Tracker & Wiki
#12637: Add new links to press page
--+
 Reporter:  jmtodaro  |  Owner:  phobos
 Type:  task  | Status:  closed
 Priority:  Medium|  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Blocker   | Resolution:  fixed
 Keywords:  website press |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by Jadon):

 * severity:   => Blocker


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25014 [Applications/Tor Browser]: Options UX for Extensions isn't allowing JS execution

2018-01-24 Thread Tor Bug Tracker & Wiki
#25014: Options UX for Extensions isn't allowing JS execution
--+--
 Reporter:  legind|  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 When you visit `about:addons` within Tor Browser while TorButton is in the
 middle ("Safer") or highest ("Safest") security levels, the HTTPS
 Everywhere options UX does not work.  This is because it is dependent on
 JavaScript execution, which is disabled in those security levels, but
 should not be disabled for extension UX in general.

 This problem is also exhibited when JavaScript is disabled in Firefox ESR,
 so this is an underlying Firefox problem.  A fix has been made as the
 latest Firefox does not exhibit this problem, but they haven't bothered
 backporting it to ESR.

 This problem is very similar to what we encountered in
 https://trac.torproject.org/projects/tor/ticket/23258.  In that case, UX
 elements for the HTTPS Everywhere extension popup were not working
 properly.  This is the same, but applied to the options UX.  We had to
 apply a backported patch to the TB build then in order to restore
 functionality.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13612 [Applications/Tor Browser]: social.remote-install.enabled option in Tor Browser

2018-01-24 Thread Tor Bug Tracker & Wiki
#13612: social.remote-install.enabled option in Tor Browser
-+-
 Reporter:  cypherpunks  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201705R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * keywords:  ff52-esr, tbb-7.0-must, TorBrowserTeam201705R => ff52-esr,
 tbb-7.0-must, TorBrowserTeam201705R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21862 [Applications/Tor Browser]: Make rust code in ESR 52 proxy safe

2018-01-24 Thread Tor Bug Tracker & Wiki
#21862: Make rust code in ESR 52 proxy safe
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  ff52-esr, tbb-7.0-must,  |  Actual Points:
  TorBrowserTeam201706R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * keywords:  ff52-esr, tbb-7.0-must, TorBrowserTeam201706R => ff52-esr,
 tbb-7.0-must, TorBrowserTeam201706R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

2018-01-24 Thread Tor Bug Tracker & Wiki
#25013: Move TorButton code to the tor browser repository
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:|Sponsor:
--+--
Changes (by igt0):

 * parent:   => #24855


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

2018-01-24 Thread Tor Bug Tracker & Wiki
#25013: Move TorButton code to the tor browser repository
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 As discussed in the[1], this is the first step to make the tor button to
 work on mobile.

 [1] https://lists.torproject.org/pipermail/tbb-
 dev/2018-January/000740.html

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25012 [Applications/Tor Browser]: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions file

2018-01-24 Thread Tor Bug Tracker & Wiki
#25012: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions
file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-rbm   |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by boklm):

 https://github.com/micahflee/torbrowser-launcher/issues/306

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25012 [Applications/Tor Browser]: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions file

2018-01-24 Thread Tor Bug Tracker & Wiki
#25012: Tor Browser 7.5 doesn't have a Browser/TorBrowser/Docs/sources/versions
file
--+--
 Reporter:  boklm |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  tbb-rbm
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 A user reported on the blog a problem using torbrowser-launcher:
 https://blog.torproject.org/comment/273588#comment-273588

 It seems that torbrowser-launcher is looking at the file
 `Browser/TorBrowser/Docs/sources/versions` to find which version is
 installed, and fails if the file does not exists.

 This file was present in the versions built with gitian/tor-browser-
 bundle, but is not in the versions built with rbm/tor-browser-build.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18995 [Applications/Tor Browser]: Investigate CacheStorage feature for tracking usage in Tor Browser

2018-01-24 Thread Tor Bug Tracker & Wiki
#18995: Investigate CacheStorage feature for tracking usage in Tor Browser
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  ff45-esr, TorBrowserTeam201605R, |  Actual Points:
  tbb-no-uplift  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff45-esr, TorBrowserTeam201605R, tbb-dont-uplift => ff45-esr,
 TorBrowserTeam201605R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14392 [Applications/Tor Browser]: about:tor should behave more like about:newtab

2018-01-24 Thread Tor Bug Tracker & Wiki
#14392: about:tor should behave more like about:newtab
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-pref, tbb-usability, |  Actual Points:
  TorBrowserTeam201502, MikePerry201502, tbb-|
  no-uplift  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:
 tbb-pref, tbb-usability, TorBrowserTeam201502, MikePerry201502, tbb-
 dont-uplift
 =>
 tbb-pref, tbb-usability, TorBrowserTeam201502, MikePerry201502, tbb-
 no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14392 [Applications/Tor Browser]: about:tor should behave more like about:newtab

2018-01-24 Thread Tor Bug Tracker & Wiki
#14392: about:tor should behave more like about:newtab
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-pref, tbb-usability, |  Actual Points:
  TorBrowserTeam201502, MikePerry201502, tbb-|
  dont-uplift|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * severity:  Blocker => Normal


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #14392 [Applications/Tor Browser]: about:tor should behave more like about:newtab

2018-01-24 Thread Tor Bug Tracker & Wiki
#14392: about:tor should behave more like about:newtab
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Blocker  | Resolution:  fixed
 Keywords:  tbb-pref, tbb-usability, |  Actual Points:
  TorBrowserTeam201502, MikePerry201502, tbb-|
  dont-uplift|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-pref, tbb-usability, TorBrowserTeam201502, MikePerry201502
 =>
 tbb-pref, tbb-usability, TorBrowserTeam201502, MikePerry201502, tbb-
 dont-uplift
 * severity:   => Blocker


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18995 [Applications/Tor Browser]: Investigate CacheStorage feature for tracking usage in Tor Browser

2018-01-24 Thread Tor Bug Tracker & Wiki
#18995: Investigate CacheStorage feature for tracking usage in Tor Browser
-+-
 Reporter:  gk   |  Owner:
 |  arthuredelstein
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  ff45-esr, TorBrowserTeam201605R, |  Actual Points:
  tbb-dont-uplift|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff45-esr, TorBrowserTeam201605R => ff45-esr,
 TorBrowserTeam201605R, tbb-dont-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #2176 [Applications/Tor bundles/installation]: Branding of TBB

2018-01-24 Thread Tor Bug Tracker & Wiki
#2176: Branding of TBB
-+-
 Reporter:  ioerror  |  Owner:  erinn
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor |Version:
  bundles/installation   |
 Severity:  Blocker  | Resolution:  invalid
 Keywords:  Bounty, tbb-branding, tbb-no-uplift  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  Bounty, tbb-branding => Bounty, tbb-branding, tbb-no-uplift
 * severity:   => Blocker


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #2950 [Firefox Patch Issues]: Make Permissions-Manager memory-only in TorBrowser

2018-01-24 Thread Tor Bug Tracker & Wiki
#2950: Make Permissions-Manager memory-only in TorBrowser
-+-
 Reporter:  mikeperry|  Owner:
 |  mikeperry
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Firefox Patch Issues |Version:
 Severity:  Blocker  | Resolution:  fixed
 Keywords:  MikePerryIteration20110515, tbb-no-  |  Actual Points:  3
  uplift |
Parent ID:  #2877| Points:  2
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  MikePerryIteration20110515 => MikePerryIteration20110515, tbb-
 no-uplift
 * severity:   => Blocker


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #12620 [Applications/Tor Browser]: Rebase TBB patches to Firefox 31 and add unit tests

2018-01-24 Thread Tor Bug Tracker & Wiki
#12620: Rebase TBB patches to Firefox 31 and add unit tests
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Blocker  | Resolution:  fixed
 Keywords:  ff31-esr, tbb-rebase, tbb-firefox-   |  Actual Points:
  patch, TorBrowserTeam201409D, tbb-no-uplift|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  ff31-esr, tbb-rebase, tbb-firefox-patch, TorBrowserTeam201409D
 =>
 ff31-esr, tbb-rebase, tbb-firefox-patch, TorBrowserTeam201409D, tbb-
 no-uplift
 * severity:   => Blocker


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #16441 [Applications/Tor Browser]: 8-month-old Tor Browser offers to "Reset Tor Browser", removes extensions

2018-01-24 Thread Tor Bug Tracker & Wiki
#16441: 8-month-old Tor Browser offers to "Reset Tor Browser", removes 
extensions
-+-
 Reporter:  dcf  |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-security, tbb-usability, |  Actual Points:
  TorBrowserTeam201512R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-security, tbb-usability, TorBrowserTeam201512R => tbb-
 security, tbb-usability, TorBrowserTeam201512R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24478 [Applications/Tor Browser]: Enable tests and debug assertions in our ASan builds

2018-01-24 Thread Tor Bug Tracker & Wiki
#24478: Enable tests and debug assertions in our ASan builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201712R,   |  Actual Points:
  GeorgKoppen201712, tbb-rbm, tbb-no-uplift  |
Parent ID:  #24154   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor4
-+-
Changes (by arthuredelstein):

 * keywords:  TorBrowserTeam201712R, GeorgKoppen201712, tbb-rbm =>
 TorBrowserTeam201712R, GeorgKoppen201712, tbb-rbm, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23881 [Core Tor/Tor]: Implement a way to utilise tor's logging system from Rust code

2018-01-24 Thread Tor Bug Tracker & Wiki
#23881: Implement a way to utilise tor's logging system from Rust code
---+---
 Reporter:  isis   |  Owner:
   |  chelseakomlo
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  High   |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  rust, rust-pilot, review-group-29  |  Actual Points:
Parent ID: | Points:  3
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by chelseakomlo):

 Sounds good! I got a late start on this but about 3/4 of the way through,
 hoping to have everything up soon.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18918 [Core Tor/Tor]: Clarify directory and ORPort checking functions

2018-01-24 Thread Tor Bug Tracker & Wiki
#18918: Clarify directory and ORPort checking functions
-+-
 Reporter:  teor |  Owner:  (none)
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.2.8.1-alpha
 Severity:  Normal   | Resolution:
 Keywords:  easy, doc, code, refactor|  Actual Points:
  technical-debt tor-relay   |
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by ffmancera):

 * status:  new => needs_review


Comment:

 > Let's rename this to router_has_bandwidth_to_be_dirserver(). "to
 dirserver" is confusing, it could refer to another dirserver.

 Sorry I wrote it wrong in the ticket comment.

 > When we remove statements because they are obviously correct, we usually
 insert a tor_assert_nonfatal_once() or if(BUG()) to make sure the
 condition holds. If the condition depends on code outside the function,
 please check it inside the function.

 `tor_assert_nonfatal_once()` gave me a warning on tests so the conditions
 were needed.

 > If both functions are short, this is ok.
 > But if the combined function is longer than a standard terminal window
 (24 lines), let's not combine them.

 We shouldn't combine them because the combined function is longer than 24
 lines.

 Everything else was done, please check my github
 [https://github.com/ffmancera/tor-1/tree/bug18918 branch bug18918]. All
 tests pass succesfully and Travis CI seems happy, I hope everything is
 fine :-)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24432 [Obfuscation/BridgeDB]: The meek<->moat tunneling isn't set up correctly

2018-01-24 Thread Tor Bug Tracker & Wiki
#24432: The meek<->moat tunneling isn't set up correctly
--+--
 Reporter:  isis  |  Owner:  isis
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:
Component:  Obfuscation/BridgeDB  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:  moat bridgedb-dist|  Actual Points:
Parent ID:  #24689| Points:  2
 Reviewer:|Sponsor:  SponsorM
--+--
Changes (by mcs):

 * cc: dcf (added)


Comment:

 (I added dcf to the Cc in case he has any insight into problem 1 below).

 Thanks for your work on this Isis! I feel like we are very close to having
 a working system. Kathy and I have found two problems so far, but I am not
 ready to reopen this ticket yet because I am not sure what component is at
 fault.

 '''Problem 1:''' The meek tunnel does not work reliably for us.
 Specifically, if we use curl as the SOCKS client it seems to always work
 and if we use Tor Browser it does not. When we test with our own meek-
 server + BridgeDB, things also work fine. I am having trouble debugging
 the meek-client code, probably due to my lack of golang knowledge, but I
 wonder if there is an incompatibility between the meek-client we are
 running and the meek-server that you are running. What version of meek-
 server are you using at tor-bridges-hyphae-channel.appspot.com? Kathy and
 I are using a meek-client that was built from dcf's ​bug24642 branch (and
 I don't know of any recent changes to meek that would cause this kind of
 communication problem).

 Another data point: if I insert an socat pipe between the meek-client
 SOCKS port and Tor Browser, it started working. Maybe there is a data
 buffering issue at work here. All of our client side testing so far has
 been on macOS.

 '''Problem 2:''' When we do manage to send a good `check` request (one
 that includes the correct response and challenge), we always receive a "No
 bridges available to fulfill request" response. We tried with both
 "vanilla" and "obfs4" transports. Here is a sample response:
   {"errors": [{"status": "Not Found", "code": 404, "detail": "No bridges
 available to fulfill request: None.", "version": "0.1.0", "type": "moat-
 bridges", "id": 6}]}
 Is the Moat responder throttling things so we do not receive too many
 bridges? I don't think we have ever received any bridges from the
 production BridgeDB server via Moat, but even if we did I thought BridgeDB
 would send back the same set of bridges if we ask again. I can get new
 bridges repeatedly if I use a browser to interact with
 https://bridges.torproject.org/bridges?transport=obfs4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13017 [Applications/Tor Browser]: Determine if AudioBuffers/OfflineAudioContext are a fingerprinting vector

2018-01-24 Thread Tor Bug Tracker & Wiki
#13017: Determine if AudioBuffers/OfflineAudioContext are a fingerprinting 
vector
--+-
 Reporter:  mikeperry |  Owner:  arthuredelstein
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Major | Resolution:
 Keywords:  tbb-fingerprinting|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by gk):

 * severity:  Blocker => Major


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #13017 [Applications/Tor Browser]: Determine if AudioBuffers/OfflineAudioContext are a fingerprinting vector

2018-01-24 Thread Tor Bug Tracker & Wiki
#13017: Determine if AudioBuffers/OfflineAudioContext are a fingerprinting 
vector
--+-
 Reporter:  mikeperry |  Owner:  arthuredelstein
 Type:  task  | Status:  new
 Priority:  High  |  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Blocker   | Resolution:
 Keywords:  tbb-fingerprinting|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+-
Changes (by gk):

 * priority:  Very High => High
 * status:  needs_review => new
 * severity:  Critical => Blocker
 * keywords:  tbb-fingerprinting-os => tbb-fingerprinting


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #7176 [Core Tor/Tor]: Adapt and update AccessLabs' patches for reduced Tor memory consumption for embedded devices

2018-01-24 Thread Tor Bug Tracker & Wiki
#7176: Adapt and update AccessLabs' patches for reduced Tor memory consumption 
for
embedded devices
-+-
 Reporter:  cypherpunks  |  Owner:  nickm
 Type:  enhancement  | Status:
 |  accepted
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  tor-client, embedded, low-memory,|  Actual Points:
  sponsor8-maybe |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
 |  Sponsor8-can
-+-
Changes (by nickm):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24715 [Core Tor/Tor]: Job for tor.service failed when /var/run is tmpfs

2018-01-24 Thread Tor Bug Tracker & Wiki
#24715: Job for tor.service failed when /var/run is tmpfs
-+-
 Reporter:  vilhelmgray  |  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.6-alpha
 Severity:  Normal   | Resolution:
 Keywords:  tmpfs, tor.service, systemd  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Do you think you could write those lines as a patch to the tor.service
 file?  And/or can anybody else test them out?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23881 [Core Tor/Tor]: Implement a way to utilise tor's logging system from Rust code

2018-01-24 Thread Tor Bug Tracker & Wiki
#23881: Implement a way to utilise tor's logging system from Rust code
---+---
 Reporter:  isis   |  Owner:
   |  chelseakomlo
 Type:  enhancement| Status:
   |  needs_revision
 Priority:  High   |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  rust, rust-pilot, review-group-29  |  Actual Points:
Parent ID: | Points:  3
 Reviewer:  nickm  |Sponsor:
---+---

Comment (by nickm):

 (I'm still okay with taking this in 0.3.3 postfreeze if it remains pretty
 much rust-only.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25009 [Core Tor/Tor]: I think KIST can use hash tables much less.

2018-01-24 Thread Tor Bug Tracker & Wiki
#25009: I think KIST can use hash tables much less.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  032-backport  |  Actual Points:
Parent ID:  #23777| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 See also #24554

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #2149, #10059, #8453, #16387, ...

2018-01-24 Thread Tor Bug Tracker & Wiki
Batch modification to #2149, #10059, #8453, #16387, #17806, #21814, #22029, 
#23846, #23886, #24033, #24405, #24406, #24659, #24660, #24767, #2915 by nickm:
milestone to Tor: 0.3.4.x-final

Comment:
Deferring various "new"-status enhancement tickets to 0.3.4

--
Tickets URL: 

Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20916 [Core Tor/Tor]: Proposal: Put Relay IPv6 Addresses in the microdesc consensus

2018-01-24 Thread Tor Bug Tracker & Wiki
#20916: Proposal: Put Relay IPv6 Addresses in the microdesc consensus
---+---
 Reporter:  teor   |  Owner:  teor
 Type:  task   | Status:  assigned
 Priority:  Medium |  Milestone:  Tor:
   |  0.3.3.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop283, ipv6, regression  |  Actual Points:
Parent ID: | Points:  1
 Reviewer: |Sponsor:  SponsorV-can
---+---
Changes (by nickm):

 * status:  new => assigned


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25007 [Core Tor/Tor]: See if we can allocate less for HMAC in Tor relays

2018-01-24 Thread Tor Bug Tracker & Wiki
#25007: See if we can allocate less for HMAC in Tor relays
-+-
 Reporter:  nickm|  Owner:  (none)
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  memory, performance, malloc  |  Actual Points:
Parent ID:  #23777   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 We can almost certainly do better with our hkdf usage by using openssl's
 EVP_PKEY_HKDF where available.

 Resusing an HMAC_CTX structure for other HMAC operations may also improve
 performance.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25011 [Webpages/Blog]: Match blog spacing in article to archive

2018-01-24 Thread Tor Bug Tracker & Wiki
#25011: Match blog spacing in article to archive
---+--
 Reporter:  steph  |  Owner:  hiro
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by steph):

 * Attachment "title-spacing-comparison.png" added.

 comparison

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25011 [Webpages/Blog]: Match blog spacing in article to archive

2018-01-24 Thread Tor Bug Tracker & Wiki
#25011: Match blog spacing in article to archive
---+--
 Reporter:  steph  |  Owner:  hiro
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Webpages/Blog  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor: |
---+--
 Reduce the spacing between the title, authoring info, and image inside the
 individual blog post to match the spacing on the main blog page
 (blog.torproject.org)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24459 [Webpages/Website]: Update references to Atlas, Compass and Globe

2018-01-24 Thread Tor Bug Tracker & Wiki
#24459: Update references to Atlas, Compass and Globe
--+--
 Reporter:  t0wer |  Owner:  irl
 Type:  defect| Status:  needs_review
 Priority:  Low   |  Milestone:
Component:  Webpages/Website  |Version:
 Severity:  Major | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by karsten):

 Replying to [comment:2 irl]:
 > I have updated here all references to Atlas/RS, Globe and Compass. There
 will need to be a second update to the links for RS once #23518 is
 completed.
 >
 > https://people.torproject.org/~irl/volatile/0001-Updates-references-for-
 Atlas-Globe-and-Compass-Fixes.patch

 FWIW, this patch (shasum a004dfa9ca0aba61733707a9a9cd6cef764d7ccd) reads
 fine to me. I didn't test whether it merges or builds cleanly. But the
 changes look good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18923 [Applications/Tor Browser]: Add a script in tor-browser.git to run all of our TBB-specific regression tests

2018-01-24 Thread Tor Bug Tracker & Wiki
#18923: Add a script in tor-browser.git to run all of our TBB-specific 
regression
tests
-+-
 Reporter:  arthuredelstein  |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201607R, tbb-no-   |  Actual Points:
  uplift |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  TorBrowserTeam201607R => TorBrowserTeam201607R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20707 [Applications/Tor Browser]: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds

2018-01-24 Thread Tor Bug Tracker & Wiki
#20707: Preferences tab is broken in non-en-US 6.5a4(-hardened) builds
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Major| Resolution:  fixed
 Keywords:  tbb-usability,   |  Actual Points:
  TorBrowserTeam201611R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  tbb-usability, TorBrowserTeam201611R => tbb-usability,
 TorBrowserTeam201611R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24823 [Metrics/Website]: Avoid sending an error after a (partial) response

2018-01-24 Thread Tor Bug Tracker & Wiki
#24823: Avoid sending an error after a (partial) response
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24823 [Metrics/Website]: Avoid sending an error after a (partial) response

2018-01-24 Thread Tor Bug Tracker & Wiki
#24823: Avoid sending an error after a (partial) response
-+--
 Reporter:  karsten  |  Owner:  karsten
 Type:  defect   | Status:  accepted
 Priority:  Low  |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  needs_review => accepted
 * owner:  metrics-team => karsten


Comment:

 Accepting this ticket as something I'm probably going to work on over the
 next week. Currently blocking on the review, though.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24729 [Metrics/Onionoo]: Find reason for 'null' values in Onionoo document

2018-01-24 Thread Tor Bug Tracker & Wiki
#24729: Find reason for 'null' values in Onionoo document
-+--
 Reporter:  Dbryrtfbcbhgf|  Owner:  karsten
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #24155   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 Setting to needs_review to get a review of the idea above to add 6 month
 graphs and skip graphs as soon as we run into a single data point with too
 long reporting period.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24729 [Metrics/Onionoo]: Find reason for 'null' values in Onionoo document

2018-01-24 Thread Tor Bug Tracker & Wiki
#24729: Find reason for 'null' values in Onionoo document
-+--
 Reporter:  Dbryrtfbcbhgf|  Owner:  karsten
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Major| Resolution:
 Keywords:   |  Actual Points:
Parent ID:  #24155   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by karsten):

 * status:  new => accepted
 * owner:  metrics-team => karsten


Comment:

 Accepting this ticket as something I'm going to work on over the next
 week.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24617 [Core Tor/Tor]: Feature flags for new controller-accessible Tor features

2018-01-24 Thread Tor Bug Tracker & Wiki
#24617: Feature flags for new controller-accessible Tor features
+
 Reporter:  meejah  |  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  needs-proposal  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:   => needs-proposal
 * milestone:   => Tor: 0.3.5.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24717 [Metrics/Bot]: Improve design of relay and bridge badges and map overlay

2018-01-24 Thread Tor Bug Tracker & Wiki
#24717: Improve design of relay and bridge badges and map overlay
-+--
 Reporter:  irl  |  Owner:  antonela
 Type:  enhancement  | Status:  assigned
 Priority:  Medium   |  Milestone:
Component:  Metrics/Bot  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  ux-team  |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by teor):

 Hey, this map has some serious cropping, geographical, and political
 issues:
 * it has cropped out Japan, eastern Australia, New Zealand, parts of
 south-east Asia, and the pacific islands
 * Nigeria and parts of northern China are not shown in grey on the map
 * Afghanistan and Pakistan are shown unified, as is the former USSR

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25004 [Applications/rbm]: Rename abbrev_lenght to abbrev_length

2018-01-24 Thread Tor Bug Tracker & Wiki
#25004: Rename abbrev_lenght to abbrev_length
---+
 Reporter:  boklm  |  Owner:  boklm
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/rbm   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam201801R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Okay, looks good. Cherry-picked to `master` with commit
 b83c74ca4b91732f64011f0255a1594f7747b340.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24982 [Applications/rbm]: Update url in README file and add script to help updating the website

2018-01-24 Thread Tor Bug Tracker & Wiki
#24982: Update url in README file and add script to help updating the website
---+
 Reporter:  boklm  |  Owner:  boklm
 Type:  task   | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/rbm   |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords:  TorBrowserTeam201801R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. Merged to `master` as commit
 0eb1f12241ed067ef9c013ef0f72e9cca89ee5e6 and
 213fad5a8fe04272359c33778626a2802efc4ebc.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25009 [Core Tor/Tor]: I think KIST can use hash tables much less. (was: Can outbuf_table_add be made to allocate less?)

2018-01-24 Thread Tor Bug Tracker & Wiki
#25009: I think KIST can use hash tables much less.
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  032-backport  |  Actual Points:
Parent ID:  #23777| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


Old description:

> It shows up in our malloc profile (#23777), where I hadn't been expecting
> to see it.

New description:

 Originally, I observed that outbuf_table_add shows up in our malloc
 profile (#23777), where I hadn't been expecting to see it.

 After a little more thinking, I'm wondering why we have outbuf_table and
 socket_table at all:

 The contents of socket_table_ent could become a member of channel_t, and
 save us a hashtable lookup there.

 The outbuf_table could become a smartlist with a corresponding index
 pointer in channel_t, since we're basically using it as an unordered set.

--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23777 [Core Tor/Tor]: tor spends a lot of time in malloc/free

2018-01-24 Thread Tor Bug Tracker & Wiki
#23777: tor spends a lot of time in malloc/free
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by Hello71):

 I think protocol_list_supports_protocol fixed by rust protover. I think
 dgoulet is working on outbuf_table_add. I looked at cell handling but I
 think a lot of that work overlaps with
 https://lists.torproject.org/pipermail/tor-dev/2017-October/012536.html.

 excessive malloc/free could also be mitigated by switching to jemalloc on
 Linux #20424-ish

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

2018-01-24 Thread Tor Bug Tracker & Wiki
#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  032-backport? malloc performance |  Actual Points:
  protover   |
Parent ID:  #23777   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 Proposed change in branch `bug25008`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25010 [Applications]: Tor does not start (was: Tor not configured properly)

2018-01-24 Thread Tor Bug Tracker & Wiki
#25010: Tor does not start
--+
 Reporter:  ToringOnion   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25010 [Applications]: Tor not configured properly

2018-01-24 Thread Tor Bug Tracker & Wiki
#25010: Tor not configured properly
--+
 Reporter:  ToringOnion   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:
Component:  Applications  |Version:
 Severity:  Minor |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I got this issue yesterday for both Debian and Ubuntu. I tried
 uninstalling and reinstalling Tor and torbrowser-launcher, but no luck.
 Here's the Terminal outputs:

 **The OS where I reinstalled Tor:**

 $ tor
 Jan 24 18:03:00.709 [notice] Tor 0.2.9.11 (git-aa8950022562be76) running
 on Linux with Libevent 2.0.21-stable, OpenSSL 1.0.2g and Zlib 1.2.8.
 Jan 24 18:03:00.709 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Jan 24 18:03:00.709 [notice] Read configuration file "/etc/tor/torrc".
 Jan 24 18:03:00.711 [notice] Opening Socks listener on 127.0.0.1:9050
 Jan 24 18:03:00.711 [warn] Could not bind to 127.0.0.1:9050: Address
 already in use. Is Tor already running?
 Jan 24 18:03:00.711 [warn] Failed to parse/validate config: Failed to bind
 one of the listener ports.
 Jan 24 18:03:00.711 [err] Reading config failed--see warnings above.

 $ torbrowser-launcher
 Tor Browser Launcher
 By Micah Lee, licensed under MIT
 version 0.2.4
 https://github.com/micahflee/torbrowser-launcher
 Traceback (most recent call last):

   File "/usr/bin/torbrowser-launcher", line 30, in 
 torbrowser_launcher.main()
   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/__init__.py",
 line 62, in main
 app = Launcher(common, url_list)
   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py",
 line 94, in __init__
 self.run(False)
   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py",
 line 519, in run
 if not self.check_min_version():
   File "/usr/lib/python2.7/dist-packages/torbrowser_launcher/launcher.py",
 line 507, in check_min_version
 for line in open(self.common.paths[wiki:'tbb' tbb][wiki:'versions'
 versions]).readlines():

 IOError: [Errno 2] No such file or directory:
 '/home/user/.local/share/torbrowser/tbb/x86_64/tor-browser_en-
 US/Browser/TorBrowser/Docs/sources/versions'

 **The OS where I didn't reinstall Tor:**

 $ torbrowser-launcher
 ok received from application launch request
 $ tor
 Jan 24 18:15:52.696 [notice] Tor 0.2.9.14 (git-a211f886ad759cab) running
 on Linux with Libevent 2.0.21-stable, OpenSSL 1.1.0f and Zlib 1.2.8.
 Jan 24 18:15:52.696 [notice] Tor can't help you if you use it wrong! Learn
 how to be safe at https://www.torproject.org/download/download#warning
 Jan 24 18:15:52.697 [notice] Read configuration file "/etc/tor/torrc".
 Jan 24 18:15:52.699 [notice] Opening Socks listener on 127.0.0.1:9050
 Jan 24 18:15:52.699 [warn] Could not bind to 127.0.0.1:9050: Address
 already in use. Is Tor already running?
 Jan 24 18:15:52.699 [notice] Opening DNS listener on 127.0.0.1:5353
 Jan 24 18:15:52.699 [notice] Opening Transparent pf/netfilter listener on
 127.0.0.1:9040
 Jan 24 18:15:52.699 [warn] Could not bind to 127.0.0.1:9040: Address
 already in use. Is Tor already running?
 Jan 24 18:15:52.700 [warn] /var/run/tor is not owned by this user (user,
 1000) but by  (105). Perhaps you are running Tor as the wrong
 user?
 Jan 24 18:15:52.700 [warn] Before Tor can create a control socket in
 "/var/run/tor/control", the directory "/var/run/tor" needs to exist, and
 to be accessible only by the user and group account that is running Tor.
 (On some Unix systems, anybody who can list a socket can connect to it, so
 Tor is being careful.)
 Jan 24 18:15:52.700 [notice] Closing partially-constructed DNS listener on
 127.0.0.1:5353
 Jan 24 18:15:52.700 [warn] Failed to parse/validate config: Failed to bind
 one of the listener ports.
 Jan 24 18:15:52.700 [err] Reading config failed--see warnings above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25009 [Core Tor/Tor]: Can outbuf_table_add be made to allocate less?

2018-01-24 Thread Tor Bug Tracker & Wiki
#25009: Can outbuf_table_add be made to allocate less?
--+
 Reporter:  nickm |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  032-backport
Actual Points:|  Parent ID:  #23777
   Points:|   Reviewer:
  Sponsor:|
--+
 It shows up in our malloc profile (#23777), where I hadn't been expecting
 to see it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

2018-01-24 Thread Tor Bug Tracker & Wiki
#25008: Call protocol_list_supports_protocol less often to save time and 
allocation
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
Component:  Core |Version:
  Tor/Tor|   Keywords:  032-backport? malloc performance
 Severity:  Normal   |  protover
Actual Points:   |  Parent ID:  #23777
   Points:   |   Reviewer:
  Sponsor:   |
-+-
 This function appeared on the heap profile of #23777, and there's no
 reason it should have done so.  It appears to have been getting called by
 circuit_extend(), which suggests that we have some dodgy logic somewhere.
 I blame node_supports_ed25519_link_allocation.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25007 [Core Tor/Tor]: See if we can allocate less for HMAC in Tor relays

2018-01-24 Thread Tor Bug Tracker & Wiki
#25007: See if we can allocate less for HMAC in Tor relays
--+-
 Reporter:  nickm |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  memory, performance, malloc
Actual Points:|  Parent ID:  #23777
   Points:|   Reviewer:
  Sponsor:|
--+-
 Our HMAC usage accounts for a comparatively large fraction of our
 allocations, according to the data from #23777.  Let's see if we can make
 it allocate less, since it's part of our critical path.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23777 [Core Tor/Tor]: tor spends a lot of time in malloc/free

2018-01-24 Thread Tor Bug Tracker & Wiki
#23777: tor spends a lot of time in malloc/free
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Circling around to this ticket again now that 0.3.3 is feature-frozen.

 The biggest offender seems to have been
 `channel_rsa_id_group_set_badness`, which should have been fixed a lot bug
 #24119.  So that's good.

 There are some things I'm surprised to see in the profile:
   * onion_skin_server_handshake (19.22%)
   * protocol_list_supports_protocol (10.95%)
   * outbuf_table_add (3.5%)

 Let's have a look and see how much we can do there.

 Another improvement on this area would be to see about making cell-handing
 inside Tor involve fewer copies; but that might be better handled as part
 of our Rust work.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24609 [Core Tor/Tor]: consdiff implementation in Rust

2018-01-24 Thread Tor Bug Tracker & Wiki
#24609: consdiff implementation in Rust
--+
 Reporter:  Sebastian |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  rust  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24909 [Core Tor/Tor]: Update dir-spec for new compression options

2018-01-24 Thread Tor Bug Tracker & Wiki
#24909: Update dir-spec for new compression options
+
 Reporter:  teor|  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, doc, tor-dir  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 See branch 'document_prop278' in my public torspec repo.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24909 [Core Tor/Tor]: Update dir-spec for new compression options

2018-01-24 Thread Tor Bug Tracker & Wiki
#24909: Update dir-spec for new compression options
+
 Reporter:  teor|  Owner:  nickm
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.1.1-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-spec, doc, tor-dir  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm


Comment:

 I don't see gzip mentioned in dir-spec at all; only zlib/deflate.  I'll
 try writing something here.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24914 [Core Tor/Tor]: Maybe make relay_digest_matches() not use tor_malloc()

2018-01-24 Thread Tor Bug Tracker & Wiki
#24914: Maybe make relay_digest_matches() not use tor_malloc()
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-relay |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Branch `bug24914` has a simple patch for this.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23916 [Applications/Tor Browser]: Create a new MAR signing key for Tor Browser

2018-01-24 Thread Tor Bug Tracker & Wiki
#23916: Create a new MAR signing key for Tor Browser
-+-
 Reporter:  gk   |  Owner:  tbb-
 |  team
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  GeorgKoppen201801,   |  Actual Points:
  TorBrowserTeam201801R, tbb-no-uplift   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by arthuredelstein):

 * keywords:  GeorgKoppen201801, TorBrowserTeam201801R => GeorgKoppen201801,
 TorBrowserTeam201801R, tbb-no-uplift


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24914 [Core Tor/Tor]: Maybe make relay_digest_matches() not use tor_malloc()

2018-01-24 Thread Tor Bug Tracker & Wiki
#24914: Maybe make relay_digest_matches() not use tor_malloc()
--+
 Reporter:  dgoulet   |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-relay |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  new => accepted
 * owner:  (none) => nickm
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25006 [- Select a component]: How can I fix the constant scale of all pages by default (67%)?

2018-01-24 Thread Tor Bug Tracker & Wiki
#25006: How can I fix the constant scale of all pages by default (67%)?
--+
 Reporter:  artaxerxes|  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  High  |  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 How can I fix the constant scale of all pages by default (67%)?
 Как можно зафиксировать постоянный масштаб всех страниц по-умолчанию
 (67%)?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24587 [Core Tor/Tor]: Reset bootstrapping state on shutdown

2018-01-24 Thread Tor Bug Tracker & Wiki
#24587: Reset bootstrapping state on shutdown
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tor-mobile, s8-api  |  Actual Points:
Parent ID:  #23847  | Points:
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  assigned => needs_review
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23750 [Core Tor/Tor]: Isolate libevent usage to a few locations

2018-01-24 Thread Tor Bug Tracker & Wiki
#23750: Isolate libevent usage to a few locations
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  refactoring technical-debt  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * status:  assigned => needs_review
 * milestone:  Tor: 0.3.3.x-final => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25005 [Core Tor/Tor]: memory leak in test-scheduler unit tests

2018-01-24 Thread Tor Bug Tracker & Wiki
#25005: memory leak in test-scheduler unit tests
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Fixed with 6ba2881aec7299fb486ab0f821c4f2ddcc88190e

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25005 [Core Tor/Tor]: memory leak in test-scheduler unit tests

2018-01-24 Thread Tor Bug Tracker & Wiki
#25005: memory leak in test-scheduler unit tests
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 I have a fix; just grabbing a ticket number.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23954 [Core Tor/Tor]: Race condition in LOG_PROTOCOL_WARN

2018-01-24 Thread Tor Bug Tracker & Wiki
#23954: Race condition in LOG_PROTOCOL_WARN
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  assigned => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23954 [Core Tor/Tor]: Race condition in LOG_PROTOCOL_WARN

2018-01-24 Thread Tor Bug Tracker & Wiki
#23954: Race condition in LOG_PROTOCOL_WARN
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 Branch `bug23954` is ready for review.  I used the atomic_counter_t
 structure here so we could get good performance on platforms with
 stdatomic support.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24996 [Metrics/Statistics]: OnionPerf showing >200% timeouts

2018-01-24 Thread Tor Bug Tracker & Wiki
#24996: OnionPerf showing >200% timeouts
+--
 Reporter:  irl |  Owner:  karsten
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by karsten):

 * status:  accepted => needs_review


Comment:

 It looks like we implemented the database query for filling the
 `"requests"` column in the
 [https://metrics.torproject.org/stats/torperf-1.1.csv underlying CSV file]
 as '''completed requests''' and later used the data in the graph as if it
 contained '''total requests made'''. The latter definition is also what we
 wrote in the [https://metrics.torproject.org/stats.html#torperf-1.1
 specification], so I'd say let's change the database query. At least I
 can't come up with a good reason for keeping the current implementation.

 Please review [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=task-24996=034008835fecd498180d5aba31500b1fd7013129
 commit 0340088 in my task-24996 branch] with a small fix. If that looks
 okay, I can deploy it easily on the server, and the next module run will
 fix the CSV file and graph.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25004 [Applications/rbm]: Rename abbrev_lenght to abbrev_length

2018-01-24 Thread Tor Bug Tracker & Wiki
#25004: Rename abbrev_lenght to abbrev_length
---+--
 Reporter:  boklm  |  Owner:  boklm
 Type:  defect | Status:  needs_review
 Priority:  Medium |  Milestone:
Component:  Applications/rbm   |Version:
 Severity:  Normal | Resolution:
 Keywords:  TorBrowserTeam201801R  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by boklm):

 * cc: gk (added)
 * status:  new => needs_review
 * keywords:   => TorBrowserTeam201801R


Comment:

 I pushed a patch for this in branch `bug_25004`:
 
https://gitweb.torproject.org/user/boklm/rbm.git/commit/?h=bug_25004=8d2cb3efee650fdc7f167a760772eeaddbeec7a7

 We don't use this option anywhere in `tor-browser-build` or `tor-
 messenger-build` (except in #24995) so there is no need to rename it
 there.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

2018-01-24 Thread Tor Bug Tracker & Wiki
#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
+--
 Reporter:  TheDcoder   |  Owner:  tbb-team
 Type:  defect  | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * status:  needs_review => needs_revision


Comment:

 We should fix #25004 first.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25004 [Applications/rbm]: Rename abbrev_lenght to abbrev_length

2018-01-24 Thread Tor Bug Tracker & Wiki
#25004: Rename abbrev_lenght to abbrev_length
--+---
 Reporter:  boklm |  Owner:  boklm
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/rbm  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+---
 We should rename the `abbrev_lenght` option to `abbrev_length`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25001 [Internal Services/Tor Sysadmin Team]: Refresh gpg key for boklm

2018-01-24 Thread Tor Bug Tracker & Wiki
#25001: Refresh gpg key for boklm
-+
 Reporter:  boklm|  Owner:  tpa
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Internal Services/Tor Sysadmin Team  |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by weasel):

 * status:  new => closed
 * resolution:   => fixed


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24995 [Applications/Tor Browser]: Truncated git hash not available in the windows expert bundle build for Tor 0.3.2.9

2018-01-24 Thread Tor Bug Tracker & Wiki
#24995: Truncated git hash not available in the windows expert bundle build for 
Tor
0.3.2.9
+--
 Reporter:  TheDcoder   |  Owner:  tbb-team
 Type:  defect  | Status:  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801R  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by boklm):

 * keywords:  tbb-rbm => tbb-rbm, TorBrowserTeam201801R
 * status:  new => needs_review


Comment:

 I pushed a patch to fix that in branch `bug_24995_v2`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_24995_v2=ab4a36dc316968cd3f87f4dace6e9983508bebb9

 After building an Expert Bundle with:
 {{{
 ./rbm/rbm build --target alpha --target torbrowser-windows-i686 --target
 expert-bundle tor
 }}}

 The git hash is again in the `tor.exe --version` output.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25003 [Applications/Tor Browser]: Set the browser header for the first ESR 60 based alpha to be the same as ESR 52

2018-01-24 Thread Tor Bug Tracker & Wiki
#25003: Set the browser header for the first ESR 60 based alpha to be the same 
as
ESR 52
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:  ff60-esr
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 When the first ESR 60 based alpha is released, ESR 52 is still used for
 the stable release, and so this makes the TB alpha users more
 fingerprintable during that period.

 Solution: Set the browser header for the first ESR 60 based alpha to be
 the same as ESR 52 before the release of the first ESR 60 based TB stable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24968 [Core Tor/Tor]: Tor's DNSPort become unreliable after I upgraded to latest 0329 stable.

2018-01-24 Thread Tor Bug Tracker & Wiki
#24968: Tor's DNSPort become unreliable after I upgraded to latest 0329 stable.
--+
 Reporter:  cypherpunks   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Normal| Resolution:
 Keywords:  tor-dns, regression?  |  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 When you say you upgraded to tor 0.3.2.9 -- what did you upgrade _from_?
 What is the last release where DNSPort works well for you?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25002 [Metrics/Onionoo]: Make data and results from Onionoo deterministic

2018-01-24 Thread Tor Bug Tracker & Wiki
#25002: Make data and results from Onionoo deterministic
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 As started with #16513 all documents and data generated by Onionoo should
 be deterministic with reasonable effort.

 One other step is discussed
 [https://trac.torproject.org/projects/tor/ticket/16513#comment:38 here].

 More topics will be added as comment, when they appear.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24946 [Core Tor/Tor]: connection_ap_expire_beginning(): Bug: circuit->purpose == CIRCUIT_PURPOSE_C_GENERAL failed

2018-01-24 Thread Tor Bug Tracker & Wiki
#24946: connection_ap_expire_beginning(): Bug: circuit->purpose ==
CIRCUIT_PURPOSE_C_GENERAL failed
--+
 Reporter:  arma  |  Owner:  mikeperry
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Closing this one per comments above.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

  1   2   >