Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  closed
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:  implemented
 Keywords:  prop272, TorCoreTeam201608  |  Actual Points:  .1
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 Merging, now that #19958 is in.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
+--
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  prop272, TorCoreTeam201608  |  Actual Points:  .1
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * keywords:  prop272, TorCoreTeam201608, review-group-8 => prop272,
 TorCoreTeam201608


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Okay, this can sit in merge_ready till #19958 goes in.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me. Hooray for unittest.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Replying to [comment:14 asn]:
 > Review:
  [...]

 Thanks!

 I've fixed the typo issues and squashed the commits in a new branch,
 `ticket20001_v2`.  It has also been rebased to master.  I've added a unit
 test in a second commit.

 > - As a step further, does this mean that we can eventually deprecate the
 `is_valid` and `is_flagged_running` flags, and assume that they are set?
 When can this be done? I guess we can already do this for `is_valid` but
 we need to wait till `MIN_METHOD_FOR_EXCLUDING_INVALID_NODES` becomes
 standard to remove `is_flagged_running`.

 I think you have those backwards, but yeah. We could do that eventually.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Review:

 - The following change is wrong and probably accidental:
 {{{
 -rs->is_flagged_running = 1;
 +rs->is_flagged_running = 1 *;
 }}}

   Also please squash both commits as they are overwriting each other.

 - I don't see the `MIN_METHOD_FOR_EXCLUDING_INVALID_NODES` consensus
 method defined anywhere. However, it seems like it's included in the
 #20002 branch so this is just a rebase issue.

 - As a step further, does this mean that we can eventually deprecate the
 `is_valid` and `is_flagged_running` flags, and assume that they are set?
 When can this be done? I guess we can already do this for `is_valid` but
 we need to wait till `MIN_METHOD_FOR_EXCLUDING_INVALID_NODES` becomes
 standard to remove `is_flagged_running`.

 Marking this as `needs_revision` for the fist comment.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 (Actually, even after reivew, I don't want to merge this till *after*
 proposal 264 is in.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Will do when I merge.

 How does the updated `ticket20001` branch look?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by dgoulet):

 Spec change looks good. Maybe also close prop272?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => needs_review


Comment:

 Branch updated; review would be welcome. :)

 I've also pushed a `prop272_part2` branch for torspec.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by nickm):

 Checking the consensus method would be easy; method 24 for Valid and
 method 5 (which is always available) for Running.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-

Comment (by andrea):

 Alternate but more complex suggestion to avoid the deployment dependency:
 check the consensus method.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
-+-
 Reporter:  nickm|  Owner:  nickm
 Type:  enhancement  | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  prop272, TorCoreTeam201608, review-  |  Actual Points:  .1
  group-8|
Parent ID:   | Points:  .2
 Reviewer:   |Sponsor:
-+-
Changes (by andrea):

 * status:  needs_review => merge_ready


Comment:

 This one looks fine to me, but shouldn't be merged until the authorities
 actually behave this way.  Marking it merge_ready for now but sequence it
 after #20002 is merged and running on auths.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
---+---
 Reporter:  nickm  |  Owner:  nickm
 Type:  enhancement| Status:  needs_review
 Priority:  Medium |  Milestone:  Tor:
   |  0.2.9.x-final
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords:  prop272 TorCoreTeam201608  |  Actual Points:  .1
Parent ID: | Points:  .2
 Reviewer: |Sponsor:
---+---
Changes (by nickm):

 * keywords:  prop272 => prop272 TorCoreTeam201608


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  prop272   |  Actual Points:  .1
Parent ID:| Points:  .2
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * keywords:  needs-proposal => prop272


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  needs-proposal  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * owner:   => nickm
 * status:  new => accepted


Comment:

 Please have a look at branch "ticket20001" in my public repository.  We
 shouldn't actually merge this till #20002 is also done and deployed, and
 we may want to do it in conjunction with #19958.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
+
 Reporter:  nickm   |  Owner:  nickm
 Type:  enhancement | Status:  needs_review
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  needs-proposal  |  Actual Points:  .1
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+
Changes (by nickm):

 * status:  accepted => needs_review
 * actualpoints:   => .1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
+
 Reporter:  nickm   |  Owner:
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  needs-proposal  |  Actual Points:
Parent ID:  | Points:  .2
 Reviewer:  |Sponsor:
+

Comment (by nickm):

 This is part of proposal 272.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #20001 [Core Tor/Tor]: Infer running and valid from presence in consensus

[Tor Bug Tracker & Wiki]

#20001: Infer running and valid from presence in consensus
--+
 Reporter:  nickm |  Owner:
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:  needs-proposal
Actual Points:|  Parent ID:
   Points:  .2|   Reviewer:
  Sponsor:|
--+
 We no longer include in the consensus any non-running nodes.

 We are no longer _supposed_ to include in the consensus any non-Valid
 nodes.

 Let us update Tor to infer these flags as true from their presence in the
 consensus.  This could work with prop#266 as another means to kill off
 obsolete clients.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs