Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:  closed
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile tbb-fingerprinting, TorBrowserTeam201712 => tbb-
 mobile tbb-fingerprinting, TorBrowserTeam201712R
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks for all three fixups. The patches got applied to `tor-
 browser-52.5.2esr-7.5-2` as commit
 a1beadc5b70e1b6e4727506656723684cf3225bf and
 a72faadea544a71ae5ca95ec816f2684c205b56a).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the feedback! I updated the patch.

 https://trac.torproject.org/projects/tor/attachment/ticket/22084/0001
 -PATCH-Bug-1372072-Part-1-Spoofing-network-informatio.2.patch

 https://trac.torproject.org/projects/tor/attachment/ticket/22084/0002
 -PATCH-Bug-1372072-Part-2-Add-a-test-case-for-check-w.2.patch

 Replying to [comment:13 gk]:
 > We are close! Could you just remove two superfluous newlines? One at:
 > {{{
 >  #include "nsINetworkProperties.h"
 > +#include "nsContentUtils.h"
 > +
 > }}}
 > and the other one, which is `git` complaining about, at the end of the
 test file:
 > {{{
 > +  await testWindow();
 > +});
 > +
 > }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * Attachment "0002-PATCH-Bug-1372072-Part-2-Add-a-test-case-for-
 check-w.2.patch" added.

 Version 3 - Remove superfluous lines

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * Attachment "0001-PATCH-Bug-1372072-Part-1-Spoofing-network-
 informatio.2.patch" added.

 Version 3 - Remove superfluous lines

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 We are close! Could you just remove two superfluous newlines? One at:
 {{{
  #include "nsINetworkProperties.h"
 +#include "nsContentUtils.h"
 +
 }}}
 and the other one, which is `git` complaining about, at the end of the
 test file:
 {{{
 +  await testWindow();
 +});
 +
 }}}

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by cypherpunks):

 * status:  needs_revision => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by igt0):

 Thanks,

 I attached the back ported patches following the proposed workflow:

 Part 1:
 https://trac.torproject.org/projects/tor/attachment/ticket/22084/0001
 -PATCH-Bug-1372072-Part-1-Spoofing-network-informatio.patch

 Part 2:
 https://trac.torproject.org/projects/tor/attachment/ticket/22084/0002
 -PATCH-Bug-1372072-Part-2-Add-a-test-case-for-check-w.patch

 Replying to [comment:10 gk]:
 > Thanks. I think the code backported looks good. However, I think we
 should have a better patch format. First, we should keep the Mozilla bug
 number. That makes it easier to find the patch(es) in our tree. Second, we
 should keep the patch(set) structure: one commit in our tree should match
 one commit taken from Mozilla. This allows us to pinpoint possible issues
 easier. Third, we should fix up the commit message if needed (in your case
 you still have included "This tests not only windows, but also workers."
 even though you rightly omitted the workers related part).
 >
 > A workflow that works fine for me is having `mozilla-central` as a git
 remote and cherry picking the patches from that one into `tor-browser`
 one-by-one, fixing them up if needed and adapting the commit message
 afterwards with `git commit --amend` if needed as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * Attachment "0002-PATCH-Bug-1372072-Part-2-Add-a-test-case-for-
 check-w.patch" added.

 Version 2 - Backport test from firefox

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * Attachment "0001-PATCH-Bug-1372072-Part-1-Spoofing-network-
 informatio.patch" added.

 Version 2 - Backport code from Firefox

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_revision
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712   |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-mobile tbb-fingerprinting, TorBrowserTeam201712R => tbb-
 mobile tbb-fingerprinting, TorBrowserTeam201712


Comment:

 Thanks. I think the code backported looks good. However, I think we should
 have a better patch format. First, we should keep the Mozilla bug number.
 That makes it easier to find the patch(es) in our tree. Second, we should
 keep the patch(set) structure: one commit in our tree should match one
 commit taken from Mozilla. This allows us to pinpoint possible issues
 easier. Third, we should fix up the commit message if needed (in your case
 you still have included "This tests not only windows, but also workers."
 even though you rightly omitted the workers related part).

 A workflow that works fine for me is having `mozilla-central` as a git
 remote and cherry picking the patches from that one into `tor-browser`
 one-by-one, fixing them up if needed and adapting the commit message
 afterwards with `git commit --amend` if needed as well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
-+-
 Reporter:  gk   |  Owner:  igt0
 Type:  task | Status:
 |  needs_review
 Priority:  High |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting,   |  Actual Points:
  TorBrowserTeam201712R  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-mobile tbb-fingerprinting => tbb-mobile tbb-
 fingerprinting, TorBrowserTeam201712R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  needs_review
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by igt0):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  accepted
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by igt0):

 * Attachment "0001-Spoofing-network-information-API-and-blocking-
 ontype.patch" added.

 Version 1 - Backport commits from firefox

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  accepted
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by mcs):

 * cc: brade, mcs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  accepted
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by igt0):

 Replying to [comment:5 gk]:
 > Replying to [comment:4 igt0]:
 > > There is already an upstream fix for this bug:
 > >
 > > https://hg.mozilla.org/mozilla-central/rev/69970dbe2b5a
 > > https://hg.mozilla.org/mozilla-central/rev/12f8c79dabb4
 >
 > Thanks. I guess we want to backport those for our esr52-based branch. Do
 you think you want to do that?

 Yep, I am on it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  accepted
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by gk):

 Replying to [comment:4 igt0]:
 > There is already an upstream fix for this bug:
 >
 > https://hg.mozilla.org/mozilla-central/rev/69970dbe2b5a
 > https://hg.mozilla.org/mozilla-central/rev/12f8c79dabb4

 Thanks. I guess we want to backport those for our esr52-based branch. Do
 you think you want to do that?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  accepted
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

Comment (by igt0):

 There is already an upstream fix for this bug:

 https://hg.mozilla.org/mozilla-central/rev/69970dbe2b5a
 https://hg.mozilla.org/mozilla-central/rev/12f8c79dabb4

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  igt0
 Type:  task   | Status:  accepted
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--
Changes (by igt0):

 * status:  new => accepted
 * owner:  tbb-team => igt0


Comment:

 I am working on it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22084 [Applications/Tor Browser]: Neuter NetworkInformation API on Tor Browser Mobile (was: Neuter NetworkInformatin API on Tor Browser Mobile)

[Tor Bug Tracker & Wiki]

#22084: Neuter NetworkInformation API on Tor Browser Mobile
---+--
 Reporter:  gk |  Owner:  tbb-team
 Type:  task   | Status:  new
 Priority:  High   |  Milestone:
Component:  Applications/Tor Browser   |Version:
 Severity:  Normal | Resolution:
 Keywords:  tbb-mobile tbb-fingerprinting  |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs