Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-15 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:  implemented
 Keywords:|  Actual Points:  .7
Parent ID:  #13339| Points:  .5
 Reviewer:  ahf   |Sponsor:  Sponsor4
--+
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:  .5 => .7


Comment:

 prop140_aftermath_url_v3 created, reviewed, merged, and fixed. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-15 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .5
Parent ID:  #13339| Points:  .5
 Reviewer:  ahf   |Sponsor:  Sponsor4
--+

Comment (by nickm):

 `prop140_aftermath_cfg` merged cleanly and pushed.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-15 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .5
Parent ID:  #13339| Points:  .5
 Reviewer:  ahf   |Sponsor:  Sponsor4
--+

Comment (by nickm):

 ok; I'll aim to merge these and resolve conflicts after the #21667 merge.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-15 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  merge_ready
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .5
Parent ID:  #13339| Points:  .5
 Reviewer:  ahf   |Sponsor:  Sponsor4
--+
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Both `prop140_aftermath_cfg` and `prop140_aftermath_url` looks good. It
 also fixes one of my questions on #22149.

 This looks like it will cause some conflicts for the changes in #21667,
 but that should be easy to handle.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-08 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .5
Parent ID:  #13339| Points:  .5
 Reviewer:  ahf   |Sponsor:  Sponsor4
--+
Changes (by ahf):

 * reviewer:   => ahf


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-05 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:  .5
Parent ID:  #13339| Points:  .5
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by nickm):

 * actualpoints:   => .5


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-05 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13339| Points:  .5
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Replying to [ticket:22148 nickm]:
 > There are some remaining issues in my prop140_complete branch.
 >
 > We should [allocate] a protover for directories that support these new
 requests.

 Done in `prop140_aftermath_url`, which now I've tested. :)

 > Right now, we treat failures to apply a consensus diff as if the
 consensus download had failed.  Is this what we should be doing?

 Still remains. I've made this into #22172 since it will take more
 thinking.

 > The proposal specifies a method for downloading diffs without using the
 X-Or-Diff-From-Consensus syntax.  We should implement that on the server
 side.

 Done in `prop140_aftermath_url`.

 > Our proposal specifies networkstatus parameters, but the code doesn't
 implement them.

 Done in `prop140_aftermath_cfg`.

 > The proposal says that sha3 digests may be truncated in requests: I
 propose we do not implement that, and revise the proposal to match.

 Done in torspec in 28816242f9eaa5509dc400a48ade1e7c4a591717 and
 522d75dd3969a4e220a113d38cf2c4497d264ab4.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-04 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13339| Points:  .5
 Reviewer:|Sponsor:  Sponsor4
--+

Comment (by nickm):

 note to self: prop140_aftermath_cfg is done

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-04 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13339| Points:  .5
 Reviewer:|Sponsor:  Sponsor4
--+

Comment (by nickm):

 note to self: prop140_aftermath_url is done but needs more testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-03 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13339| Points:  .5
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by ahf):

 * cc: ahf (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-03 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:  #13339
   Points:  .5|   Reviewer:
  Sponsor:  Sponsor4  |
--+
 There are some remaining issues in my prop140_complete branch.

 We should allocated a protover for directories that support these new
 requests.

 Right now, we treat failures to apply a consensus diff as if the consensus
 download had failed.  Is this what we should be doing?

 The proposal specifies a method for downloading diffs without using the X
 -Or-Diff-From-Consensus syntax.  We should implement that on the server
 side.

 Our proposal specifies networkstatus parameters, but the code doesn't
 implement them.

 The proposal says that sha3 digests may be truncated in requests: I
 propose we do not implement that, and revise the proposal to match.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22148 [Core Tor/Tor]: prop140: conformance to proposal, unhandled corner cases

2017-05-03 Thread Tor Bug Tracker & Wiki
#22148: prop140: conformance to proposal, unhandled corner cases
--+
 Reporter:  nickm |  Owner:  nickm
 Type:  defect| Status:  accepted
 Priority:  Medium|  Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:  #13339| Points:  .5
 Reviewer:|Sponsor:  Sponsor4
--+
Changes (by nickm):

 * status:  new => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs