Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks. Applied to `master` (commit
 fb8c46b3fb3e89b0fd182f87ba3139f5b31ad186).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by igt0):

 Here you go (25126-rebased branch):

 
https://github.com/igortoliveira/torbutton/commit/703b228d75dfb0d7a44de4ad5a056406e44691e5


 Replying to [comment:18 gk]:
 > Replying to [comment:15 igt0]:
 > > Replying to [comment:14 mcs]:
 > > > This looks good, except we found one additional problem: using a
 fixed size for the `bubble` elements does not work for all languages. We
 tested by setting `general.useragent.locale` to `de` and found that the
 text extended below the bubble background. Kathy and I removed the height
 rule and that seemed to fix the problem, but maybe there is a better
 solution.
 > > >
 > >
 > > In fact I think it is a good solution, thus the height of the higher
 bubble item will define the height of the parent element. I gave a try and
 tested in different languages and screen size, and looks good.
 > >
 > > > Also, please update the year within the copyright notice of both
 files.
 > >
 > > nice catch, thanks.
 > >
 > > Updated code:
 > >
 > > **bug 25126: Make about:tor layout responsive**
 > >
 
https://github.com/igortoliveira/torbutton/commit/bcc6dc11e5c9bed40ffe976ab93ec6da17ee33ea
 >
 > I get merge conflicts for some reason. Could you rebase your patch on
 latest `master`. Please use a new branch for that, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by gk):

 Replying to [comment:15 igt0]:
 > Replying to [comment:14 mcs]:
 > > This looks good, except we found one additional problem: using a fixed
 size for the `bubble` elements does not work for all languages. We tested
 by setting `general.useragent.locale` to `de` and found that the text
 extended below the bubble background. Kathy and I removed the height rule
 and that seemed to fix the problem, but maybe there is a better solution.
 > >
 >
 > In fact I think it is a good solution, thus the height of the higher
 bubble item will define the height of the parent element. I gave a try and
 tested in different languages and screen size, and looks good.
 >
 > > Also, please update the year within the copyright notice of both
 files.
 >
 > nice catch, thanks.
 >
 > Updated code:
 >
 > **bug 25126: Make about:tor layout responsive**
 >
 
https://github.com/igortoliveira/torbutton/commit/bcc6dc11e5c9bed40ffe976ab93ec6da17ee33ea

 I get merge conflicts for some reason. Could you rebase your patch on
 latest `master`. Please use a new branch for that, thanks.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by cypherpunks):

 Replying to [comment:15 igt0]:
 >
 
https://github.com/igortoliveira/torbutton/commit/bcc6dc11e5c9bed40ffe976ab93ec6da17ee33ea
 tbb-team, open it with Safest and look at your CPU!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-

Comment (by mcs):

 r=brade, r=mcs
 This looks good to us. It probably makes sense to test it in the desktop
 alpha before merging into stable though (Kathy and I only tested the new
 code on macOS so far).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * keywords:  tbb-torbutton, TorBrowserTeam201804 => tbb-torbutton,
 TorBrowserTeam201804R
 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:14 mcs]:
 > This looks good, except we found one additional problem: using a fixed
 size for the `bubble` elements does not work for all languages. We tested
 by setting `general.useragent.locale` to `de` and found that the text
 extended below the bubble background. Kathy and I removed the height rule
 and that seemed to fix the problem, but maybe there is a better solution.
 >

 In fact I think it is a good solution, thus the height of the higher
 bubble item will define the height of the parent element. I gave a try and
 tested in different languages and screen size, and looks good.

 > Also, please update the year within the copyright notice of both files.

 nice catch, thanks.

 Updated code:

 **bug 25126: Make about:tor layout responsive**
 
https://github.com/igortoliveira/torbutton/commit/bcc6dc11e5c9bed40ffe976ab93ec6da17ee33ea

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201804  |  Actual Points:
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  tbb-torbutton, TorBrowserTeam201804R => tbb-torbutton,
 TorBrowserTeam201804
 * status:  needs_review => needs_revision


Comment:

 This looks good, except we found one additional problem: using a fixed
 size for the `bubble` elements does not work for all languages. We tested
 by setting `general.useragent.locale` to `de` and found that the text
 extended below the bubble background. Kathy and I removed the height rule
 and that seemed to fix the problem, but maybe there is a better solution.

 Also, please update the year within the copyright notice of both files.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, TorBrowserTeam201804 => tbb-torbutton,
 TorBrowserTeam201804R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201804  |  Actual Points:
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 Thanks Kathy and mcs. Indeed I rebased with the wrong branch. The patch
 bellow fixes all the issues described by you.

**bug 25126: Make about:tor layout responsive**
 
https://github.com/igortoliveira/torbutton/commit/d12165d161817573e59ca0b6effa5d5e8d5cafe0

 Replying to [comment:11 mcs]:
 > Kathy and I reviewed the changes and tested them using a desktop
 browser. We like the use of flexbox layout (very nice), but we found a few
 things that we should be fixed:
 > * We could merge this now if it didn't depend on some earlier changes.
 It is also confusing that the patch "undoes" some earlier changes, so
 please make a new patch that does not depend on
 a35a746ca206706f4c5742d70bc90b649c1bfdf0 and
 40682676e33570d464534adc07bf94acb36a76fe.
 > * The class name `container` is very generic. Please replace it with a
 more specific name such as `torstatus-container`.
 > * Removing `.top` from `aboutTor.css` causes the "WARNING: this browser
 is out of date." text to no longer be centered.
 > * The fancy arrow that points to the toolbar item to encourage users to
 update their browser loses its horizontal tail when the browser window is
 at its default width. Somehow the div that has no id (that immediately
 follows the #torstatus div) is now wider than it used to be. This may be a
 consequence of the flexbox layout or just the adding of the .container
 div.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201804  |  Actual Points:
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  tbb-torbutton, TorBrowserTeam201804R => tbb-torbutton,
 TorBrowserTeam201804
 * status:  needs_review => needs_revision


Comment:

 Kathy and I reviewed the changes and tested them using a desktop browser.
 We like the use of flexbox layout (very nice), but we found a few things
 that we should be fixed:
 * We could merge this now if it didn't depend on some earlier changes. It
 is also confusing that the patch "undoes" some earlier changes, so please
 make a new patch that does not depend on
 a35a746ca206706f4c5742d70bc90b649c1bfdf0 and
 40682676e33570d464534adc07bf94acb36a76fe.
 * The class name `container` is very generic. Please replace it with a
 more specific name such as `torstatus-container`.
 * Removing `.top` from `aboutTor.css` causes the "WARNING: this browser is
 out of date." text to no longer be centered.
 * The fancy arrow that points to the toolbar item to encourage users to
 update their browser loses its horizontal tail when the browser window is
 at its default width. Somehow the div that has no id (that immediately
 follows the #torstatus div) is now wider than it used to be. This may be a
 consequence of the flexbox layout or just the adding of the .container
 div.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,   |  Actual Points:
  TorBrowserTeam201804R  |
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton, TorBrowserTeam201803R => tbb-torbutton,
 TorBrowserTeam201804R


Comment:

 mcs, brade: can you take a look at that one?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,TorBrowserTeam201802R  |  Actual Points:
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * keywords:  tbb-torbutton,TorBrowserTeam201802 => tbb-
 torbutton,TorBrowserTeam201802R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
+--
 Reporter:  igt0|  Owner:  tbb-team
 Type:  enhancement | Status:
|  needs_review
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-torbutton,TorBrowserTeam201802  |  Actual Points:
Parent ID:  #24855  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by igt0):

 * status:  needs_revision => needs_review


Comment:

 I updated the code:

**bug 25126: Make about:tor layout responsive**
 
https://github.com/igortoliveira/torbutton/commit/17b1d031bb64d4c4ad38ab35a1730cda18ac0664

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
+--
 Reporter:  igt0|  Owner:  tbb-team
 Type:  enhancement | Status:
|  needs_revision
 Priority:  Medium  |  Milestone:
Component:  Applications/Tor Browser|Version:
 Severity:  Normal  | Resolution:
 Keywords:  tbb-torbutton,TorBrowserTeam201802  |  Actual Points:
Parent ID:  #24855  | Points:
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-torbutton,TorBrowserTeam201802R => tbb-
 torbutton,TorBrowserTeam201802


Comment:

 Marking this as `needs_revision` as the #25013 needs to get revised as
 well.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
-+-
 Reporter:  igt0 |  Owner:  tbb-
 |  team
 Type:  enhancement  | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  tbb-torbutton,TorBrowserTeam201802R  |  Actual Points:
Parent ID:  #24855   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by mcs):

 * keywords:  tbb-torbutton => tbb-torbutton,TorBrowserTeam201802R


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:|Sponsor:
--+--
Changes (by igt0):

 * Attachment "abouttor-mobile320480.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  enhancement   | Status:  needs_review
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:|Sponsor:
--+--
Changes (by igt0):

 * status:  new => needs_review


Comment:

 As discussed in the weekly meeting(02/05). It would be interesting to make
 the current about:tor layout responsive while we are waiting for the new
 design.

 The code can be found here:
   **bug 25126: Make about:tor layout responsive**
   https://github.com/igortoliveira/tor-
 browser/commit/637076be7d34b9aed43715e862b2e14b0a3902a0

 and it depends of the #25013 patch set.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25126 [Applications/Tor Browser]: about:tor should work on small screens (mobile)

[Tor Bug Tracker & Wiki]

#25126: about:tor should work on small screens (mobile)
--+--
 Reporter:  igt0  |  Owner:  tbb-team
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-torbutton |  Actual Points:
Parent ID:  #24855| Points:
 Reviewer:|Sponsor:
--+--
Changes (by gk):

 * keywords:   => tbb-torbutton
 * owner:  (none) => tbb-team
 * component:  Applications/Torbutton => Applications/Tor Browser


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs